Re: [net PATCH v2] net: sched, fix OOO packets with pfifo_fast

2018-05-08 Thread Paolo Abeni
Hi all, I'm still crashing my head on this item... On Wed, 2018-04-18 at 09:44 -0700, John Fastabend wrote: > There is a set of conditions > that if met we can run without the lock. Possibly ONETXQUEUE and > aligned cpu_map is sufficient. We could detect this case and drop > the locking. For

Re: [net PATCH v2] net: sched, fix OOO packets with pfifo_fast

2018-04-19 Thread Paolo Abeni
On Wed, 2018-04-18 at 09:44 -0700, John Fastabend wrote: > Thanks for bringing this up. I'll think about it for a bit maybe > there is something we can do here. There is a set of conditions > that if met we can run without the lock. Possibly ONETXQUEUE and > aligned cpu_map is sufficient. I

Re: [net PATCH v2] net: sched, fix OOO packets with pfifo_fast

2018-04-18 Thread John Fastabend
On 04/18/2018 12:28 AM, Paolo Abeni wrote: > Hi, > > let me revive this old thread... > > On Mon, 2018-03-26 at 11:16 -0700, John Fastabend wrote: >> On 03/26/2018 10:30 AM, Cong Wang wrote: >>> On Sat, Mar 24, 2018 at 10:25 PM, John Fastabend >>> wrote: After the

Re: [net PATCH v2] net: sched, fix OOO packets with pfifo_fast

2018-04-18 Thread Paolo Abeni
Hi, let me revive this old thread... On Mon, 2018-03-26 at 11:16 -0700, John Fastabend wrote: > On 03/26/2018 10:30 AM, Cong Wang wrote: > > On Sat, Mar 24, 2018 at 10:25 PM, John Fastabend > > wrote: > > > After the qdisc lock was dropped in pfifo_fast we allow

Re: [net PATCH v2] net: sched, fix OOO packets with pfifo_fast

2018-03-26 Thread John Fastabend
On 03/26/2018 10:30 AM, Cong Wang wrote: > On Sat, Mar 24, 2018 at 10:25 PM, John Fastabend > wrote: >> After the qdisc lock was dropped in pfifo_fast we allow multiple >> enqueue threads and dequeue threads to run in parallel. On the >> enqueue side the skb bit ooo_okay

Re: [net PATCH v2] net: sched, fix OOO packets with pfifo_fast

2018-03-26 Thread Cong Wang
On Sat, Mar 24, 2018 at 10:25 PM, John Fastabend wrote: > After the qdisc lock was dropped in pfifo_fast we allow multiple > enqueue threads and dequeue threads to run in parallel. On the > enqueue side the skb bit ooo_okay is used to ensure all related > skbs are

Re: [net PATCH v2] net: sched, fix OOO packets with pfifo_fast

2018-03-26 Thread John Fastabend
On 03/26/2018 09:36 AM, David Miller wrote: > From: John Fastabend > Date: Sat, 24 Mar 2018 22:25:06 -0700 > >> After the qdisc lock was dropped in pfifo_fast we allow multiple >> enqueue threads and dequeue threads to run in parallel. On the >> enqueue side the skb bit

Re: [net PATCH v2] net: sched, fix OOO packets with pfifo_fast

2018-03-26 Thread David Miller
From: John Fastabend Date: Sat, 24 Mar 2018 22:25:06 -0700 > After the qdisc lock was dropped in pfifo_fast we allow multiple > enqueue threads and dequeue threads to run in parallel. On the > enqueue side the skb bit ooo_okay is used to ensure all related > skbs are

[net PATCH v2] net: sched, fix OOO packets with pfifo_fast

2018-03-24 Thread John Fastabend
After the qdisc lock was dropped in pfifo_fast we allow multiple enqueue threads and dequeue threads to run in parallel. On the enqueue side the skb bit ooo_okay is used to ensure all related skbs are enqueued in-order. On the dequeue side though there is no similar logic. What we observe is with