Re: [PATCH bpf-next v2 00/14] nfp: bpf: relocations, verifier log, signed jumps and other updates

2018-01-10 Thread Daniel Borkmann
On 01/10/2018 01:25 PM, Quentin Monnet wrote: > Jakub says: > > Hi! > > This series starts with a fix to Jesper's recent work, somehow I forgot > about control rings during review. Second patch is cleaning up a vNIC > header, in kdoc we should not use @ for #define constants. Aligning of > the

[PATCH bpf-next v2 00/14] nfp: bpf: relocations, verifier log, signed jumps and other updates

2018-01-10 Thread Quentin Monnet
Jakub says: Hi! This series starts with a fix to Jesper's recent work, somehow I forgot about control rings during review. Second patch is cleaning up a vNIC header, in kdoc we should not use @ for #define constants. Aligning of the top of the stack as well as bottom (last bytes will be

[PATCH bpf-next 00/14] nfp: bpf: relocations, verifier log, signed jumps and other updates

2018-01-09 Thread Jakub Kicinski
Hi! This series starts with a fix to Jesper's recent work, somehow I forgot about control rings during review. Second patch is cleaning up a vNIC header, in kdoc we should not use @ for #define constants. Aligning of the top of the stack as well as bottom (last bytes will be unused) helps the

Re: BPF relocations

2017-05-20 Thread Maciej W. Rozycki
On Fri, 12 May 2017, David Miller wrote: > Internally, we have to emit some kind of relocation as GAS makes it's > first pass over the instructions. Not really, you can defer that until the relaxation pass, e.g. to avoid figuring out what to do about forward local symbol references, especially

Re: BPF relocations

2017-05-11 Thread Alexei Starovoitov
On 5/11/17 6:19 PM, David Miller wrote: From: Alexei Starovoitov Date: Thu, 11 May 2017 16:10:35 -0700 I don't see what we would use pc-relative relo for. We must have them at least for banches. Internally, we have to emit some kind of relocation as GAS makes it's first pass

Re: BPF relocations

2017-05-11 Thread David Miller
From: Alexei Starovoitov Date: Thu, 11 May 2017 16:10:35 -0700 > I don't see what we would use pc-relative relo for. We must have them at least for banches. Internally, we have to emit some kind of relocation as GAS makes it's first pass over the instructions. Afterwards, it

Re: BPF relocations

2017-05-11 Thread Alexei Starovoitov
On 5/11/17 12:31 PM, David Miller wrote: I haven't done more work on bintuils BPF support because we need to figure out exactly what to do with relocations. So I've been trying to spend time thinking about this. As far as I can tell the 64-bit BPF relocation llvm uses is used in two

BPF relocations

2017-05-11 Thread David Miller
I haven't done more work on bintuils BPF support because we need to figure out exactly what to do with relocations. So I've been trying to spend time thinking about this. As far as I can tell the 64-bit BPF relocation llvm uses is used in two situations: 1) 64-bit relocations against data 2)