On Fri, Feb 16, 2018 at 09:34:39AM +, Jose Abreu wrote:
> Hi Niklas,
>
> Thank you for looking into this!
>
> On 13-02-2018 13:33, Niklas Cassel wrote:
> > Hello Jose,
> >
> >
> > I remember that you had a problem
> > with a use after free in stmmac_tx_clean().
> > I still don't think that it
Hi Niklas,
Thank you for looking into this!
On 13-02-2018 13:33, Niklas Cassel wrote:
> Hello Jose,
>
>
> I remember that you had a problem
> with a use after free in stmmac_tx_clean().
> I still don't think that it is related to
> commit 05cf0d1bf4, however, when comparing
> the stmmac driver to
Hello Jose,
I remember that you had a problem
with a use after free in stmmac_tx_clean().
I still don't think that it is related to
commit 05cf0d1bf4, however, when comparing
the stmmac driver to the amd-xgbe driver
I realized that:
xgbe_tx_poll() has both a smp_rmb() after fetching
cur_tx, and
On Thu, Nov 30, 2017 at 04:50:38PM +, Jose Abreu wrote:
> Hi Niklas,
>
> Thanks for the detailed explanation!
>
> On 30-11-2017 03:51, Niklas Cassel wrote:
> >
> > Could you try to see if the following patch
> > solves your problem:
> > (still don't see why it should be needed,
> > considerin
Hi Niklas,
Thanks for the detailed explanation!
On 30-11-2017 03:51, Niklas Cassel wrote:
>
> Could you try to see if the following patch
> solves your problem:
> (still don't see why it should be needed,
> considering stmmac_tx_clean() should set all non-NULL
> entries to NULL)
>
> diff --git a/
On Mon, Nov 27, 2017 at 02:41:00PM +, Jose Abreu wrote:
> Hi Niklas,
Hello Jose,
>
> I think your commit 05cf0d1bf4 ("net: stmmac: free an skb first
> when there are no longer any descriptors using it") is breaking
> stmmac driver in multi-queue configuration (this stacktrace may
> contain s
Hi Niklas,
I think your commit 05cf0d1bf4 ("net: stmmac: free an skb first
when there are no longer any descriptors using it") is breaking
stmmac driver in multi-queue configuration (this stacktrace may
contain some extra characters as I was using serial port):
->8-
genera
