RE: [PATCH 15/17] switch kernel_sendmsg() and kernel_recvmsg() to iov_iter_kvec()

2015-04-15 Thread David Laight
From: Al Viro Sent: 14 April 2015 17:59 On Tue, Apr 14, 2015 at 04:36:36PM +, David Laight wrote: From: Al Viro Sent: 14 April 2015 17:34 On Tue, Apr 14, 2015 at 04:21:02PM +, David Laight wrote: Massive NAK. This breaks any code that is using msg_control to set SCTP

Re: [PATCH 15/17] switch kernel_sendmsg() and kernel_recvmsg() to iov_iter_kvec()

2015-04-15 Thread Daniel Borkmann
On 04/15/2015 11:08 AM, David Laight wrote: ... Apart from any other code that is using the interface. I know you guys don't do anything to help out of tree code, but removing the setfs() stuff from the kernel_recvmsg() code would break anything using sctp. Then that might just be one more

RE: [PATCH 15/17] switch kernel_sendmsg() and kernel_recvmsg() to iov_iter_kvec()

2015-04-15 Thread David Laight
From: Daniel Borkmann Sent: 15 April 2015 10:37 On 04/15/2015 11:08 AM, David Laight wrote: ... Apart from any other code that is using the interface. I know you guys don't do anything to help out of tree code, but removing the setfs() stuff from the kernel_recvmsg() code would break