Re: [Patch 1/1] updated: TCP/UDP getpeersec

2006-03-10 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 09 Mar 2006 11:33:19 +1100 Acked-by: Herbert Xu [EMAIL PROTECTED] Dave, perhaps we should queue this for 2.6.17? Applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: RFC [Patch 1/1] Unix Datagram getpeersec

2006-03-10 Thread David S. Miller
From: James Morris [EMAIL PROTECTED] Date: Thu, 9 Mar 2006 22:40:09 -0500 (EST) On Thu, 9 Mar 2006, Catherine Zhang wrote: As per request from Stephen, I have enclosed the patch for Unix Datagram getpeersec. As always, comments are welcome! Looks fine to me. Acked-by: James

Re: Fw: [Bugme-new] [Bug 6197] New: unregister_netdevice: waiting for ppp9 to become free. Usage count = 658

2006-03-10 Thread Baruch Even
Herbert Xu wrote: Baruch Even [EMAIL PROTECTED] wrote: + case NETDEV_UNREGISTER: case NETDEV_GOING_DOWN: case NETDEV_DOWN: /* Find every socket on this device and kill it. */ This brings up the question as to why we need to flush it on NETDEV_GOING_DOWN

Re: [GIT] DECnet: Fix for big-endian machines

2006-03-10 Thread David S. Miller
From: Patrick Caulfield [EMAIL PROTECTED] Date: Fri, 10 Feb 2006 10:26:45 + The git repository is still correct at git://git.kernel.org/pub/scm/linux/kernel/git/steve/decnet-2.6.17 I pulled these patches into my net-2.6.17 tree, sorry for taking so long :-/ - To unsubscribe from this

Re: [PATCH] snap: needs hardware checksum fix

2006-03-10 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Tue, 7 Feb 2006 22:21:37 +1100 [NET]: Replace skb_pull/skb_postpull_rcsum with skb_pull_rcsum We're now starting to have quite a number of places that do skb_pull followed immediately by an skb_postpull_rcsum. We can merge these two operations into

Re: KERNEL: assertion (!sk-sk_forward_alloc) failed

2006-03-10 Thread David S. Miller
From: Ian McDonald [EMAIL PROTECTED] Date: Fri, 10 Feb 2006 08:37:48 +1300 On 2/10/06, Boris B. Zhmurov [EMAIL PROTECTED] wrote: Hello, Ian McDonald. On 09.02.2006 22:25 you said the following: Is it possible for you to download 2.6.16-rc2 or similar and see if it goes away?

Re: [PATCH] IPv6: Cleanups for net/ipv6/addrconf.c (kzalloc, early exit) v2

2006-03-10 Thread David S. Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Sun, 12 Feb 2006 02:11:03 +0900 (JST) In article [EMAIL PROTECTED] (at Sat, 11 Feb 2006 17:37:18 +0100), Ingo Oeser [EMAIL PROTECTED] says: From: Ingo Oeser [EMAIL PROTECTED] Here are some possible (and trivial) cleanups. - use

Re: KERNEL: assertion (!sk-sk_forward_alloc) failed

2006-03-10 Thread David S. Miller
From: Jesse Brandeburg [EMAIL PROTECTED] Date: Wed, 8 Feb 2006 18:10:21 -0800 I think the commit id that is missing from 2.6.14.X is fb5f5e6e0cebd574be737334671d1aa8f170d5f3 It's in 2.6.14.x I just double checked. - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH] [IPV6]: fix ipv6_saddr_score struct element

2006-03-10 Thread David S. Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Sun, 05 Mar 2006 21:07:19 +0900 (JST) In article [EMAIL PROTECTED] (at Tue, 28 Feb 2006 15:03:31 -0500), Brian Haley [EMAIL PROTECTED] says: The scope element in the ipv6_saddr_score struct used in ipv6_dev_get_saddr() is an unsigned

Re: patch to MAINTAINERS for net-2.6.git path

2006-03-10 Thread David S. Miller
From: G. Allen Morris III [EMAIL PROTECTED] Date: Fri, 03 Mar 2006 23:24:00 -0500 incorrect git path in MAINTAINERS. Patch doesn't apply cleanly to 2.6.16-rc5, please regenerate, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: ipip.c to work as module with CONFIG_INET_TUNNEL

2006-03-10 Thread David S. Miller
From: G. Allen Morris III [EMAIL PROTECTED] Date: Fri, 03 Mar 2006 23:24:03 -0500 -#ifdef CONFIG_INET_TUNNEL +#if defined(CONFIG_INET_TUNNEL) || defined(CONFIG_INET_TUNNEL_MODULE) + static struct xfrm_tunnel ipip_handler = { .handler= ipip_rcv, .err_handler

Re: remove useless test in ip6_append_data

2006-03-10 Thread David S. Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 16:42:05 +0900 (JST) In article [EMAIL PROTECTED] (at Mon, 6 Mar 2006 02:34:16 -0500), Dave Jones [EMAIL PROTECTED] says: We've already dereferenced 'np' a dozen times at this point, so it's safe to say it's not null.

Re: move br_nf_post_routing null skb check

2006-03-10 Thread David S. Miller
From: Dave Jones [EMAIL PROTECTED] Date: Mon, 6 Mar 2006 03:24:19 -0500 Coverity bug #980 If skb-dev can be null, we should check it before dereferencing. Signed-off-by: Dave Jones [EMAIL PROTECTED] This code looks different now and I think the skb-dev cannot be NULL so better to remove

Re: CWND underused when TSO on

2006-03-10 Thread David S. Miller
From: Lachlan Andrew [EMAIL PROTECTED] Date: Tue, 7 Mar 2006 18:44:50 -0800 The reason for tcp_tso_should_defer appears to be to allow enough space for a full-sized 64k socket buffer to be created. I propose checking that condition explicitly, as in the attached patch, reproduced below,

Re: [RFC: 2.6 patch] let NET_CLS_ACT no longer depend on EXPERIMENTAL

2006-03-10 Thread David S. Miller
From: jamal [EMAIL PROTECTED] Date: Sat, 04 Mar 2006 13:52:21 -0500 So on Adrian's patch and above reasoning: ACKed-by: Jamal Hadi Salim [EMAIL PROTECTED] Applied, thanks Adrian. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: RFC [Patch 1/1] Unix Datagram getpeersec

2006-03-10 Thread Xiaolan Zhang
Thanks everyone for your help! It's been a pleasure working with you. Catherine David S. Miller [EMAIL PROTECTED] wrote on 03/10/2006 03:39:51 AM: From: James Morris [EMAIL PROTECTED] Date: Thu, 9 Mar 2006 22:40:09 -0500 (EST) On Thu, 9 Mar 2006, Catherine Zhang wrote: As per

[PATCH] fix spidernet build issue

2006-03-10 Thread Jens Osterkamp
This patch fixes a spidernet build issue found in 2.6.16-rc5-mm2. Signed-off-by: Jens Osterkamp [EMAIL PROTECTED] Index: linux-2.6.16-rc5/drivers/net/Makefile === --- linux-2.6.16-rc5.orig/drivers/net/Makefile +++

Re: [UPDATED PATCH] Re: [Lse-tech] Re: [Patch 7/7] Generic netlink interface (delay accounting)

2006-03-10 Thread jamal
On Thu, 2006-09-03 at 20:07 +0530, Balbir Singh wrote: Please find the latest version of the patch for review. The genetlink code has been updated as per your review comments. The changelog is provided below 1. Eliminated TASKSTATS_CMD_LISTEN and TASKSTATS_CMD_IGNORE 2. Provide generic

Re: [UPDATED PATCH] Re: [Lse-tech] Re: [Patch 7/7] Generic netlink interface (delay accounting)

2006-03-10 Thread jamal
On Fri, 2006-10-03 at 09:53 -0500, jamal wrote: a) shipping of the taskstats from kernel to user-space asynchronously to all listeners on multicast channel/group TASKSTATS_LISTEN_GRP at the point when some process exits. b) responding to queries issued by the user to the kernel for

net-2.6.17 build broken due to SELinux

2006-03-10 Thread Arnaldo Carvalho de Melo
Hi, commit ddf1c0e35d73b05ebc9fc12cb374315f806a2764 introduced these problems, are people testing with _and_ without SELinux? security_sid_to_context is only found at security/selinux/include/security.h, i.e. at SELinux, not at the LSM level, was some LSM patch introducing

Re: KERNEL: assertion (!sk-sk_forward_alloc) failed

2006-03-10 Thread Krzysztof Oledzki
On Fri, 10 Mar 2006, David S. Miller wrote: From: Ian McDonald [EMAIL PROTECTED] Date: Fri, 10 Feb 2006 08:37:48 +1300 On 2/10/06, Boris B. Zhmurov [EMAIL PROTECTED] wrote: Hello, Ian McDonald. On 09.02.2006 22:25 you said the following: Is it possible for you to download 2.6.16-rc2 or

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-10 Thread Eric Molitor
Thanks for bearing with my questions. The RFC makes it very clear why this is bad and I agree that workarounds in the kernel for naughty apps are silly and a bad idea. I do suspect that Java wont be the only app that has issues with this. In the meantime there is a workaround. Thanks all, Eric

Re: net-2.6.17 build broken due to SELinux

2006-03-10 Thread Xiaolan Zhang
Hi, I will work on a fix. Catherine [EMAIL PROTECTED] wrote on 03/10/2006 10:48:18 AM: Hi, commit ddf1c0e35d73b05ebc9fc12cb374315f806a2764 introduced these problems, are people testing with _and_ without SELinux? security_sid_to_context is only found at

Re: [UPDATED PATCH] Re: [Lse-tech] Re: [Patch 7/7] Generic netlink interface (delay accounting)

2006-03-10 Thread Balbir Singh
On Fri, Mar 10, 2006 at 09:53:53AM -0500, jamal wrote: On Thu, 2006-09-03 at 20:07 +0530, Balbir Singh wrote: Please let us know if we missed something out. Design still shaky IMO - now that i think i may understand what your end goal is. Using the principles i described in earlier email,

Re: net-2.6.17 build broken due to SELinux

2006-03-10 Thread Arnaldo Carvalho de Melo
On 3/10/06, Xiaolan Zhang [EMAIL PROTECTED] wrote: Hi, I will work on a fix. Thanks. - Arnaldo - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Bugme-new] [Bug 6197] New: unregister_netdevice: waiting for ppp9 to become free. Usage count = 658

2006-03-10 Thread Stephen Hemminger
On Fri, 10 Mar 2006 10:41:51 + Baruch Even [EMAIL PROTECTED] wrote: Herbert Xu wrote: Baruch Even [EMAIL PROTECTED] wrote: + case NETDEV_UNREGISTER: case NETDEV_GOING_DOWN: case NETDEV_DOWN: /* Find every socket on this device and kill it. */

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-10 Thread Rick Jones
Eric Molitor wrote: Thanks for bearing with my questions. The RFC makes it very clear why this is bad and I agree that workarounds in the kernel for naughty apps are silly and a bad idea. I do suspect that Java wont be the only app that has issues with this. In the meantime there is a

Re: TSO and IPoIB performance degradation

2006-03-10 Thread Rick Jones
David S. Miller wrote: From: Rick Jones [EMAIL PROTECTED] Date: Thu, 09 Mar 2006 16:21:05 -0800 well, there are stacks which do stretch acks (after a fashion) that make sure when they see packet loss to do the right thing wrt sending enough acks to allow cwnds to open again in a timely

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-10 Thread Stephen Hemminger
On Fri, 10 Mar 2006 09:31:19 -0800 Rick Jones [EMAIL PROTECTED] wrote: Eric Molitor wrote: Thanks for bearing with my questions. The RFC makes it very clear why this is bad and I agree that workarounds in the kernel for naughty apps are silly and a bad idea. I do suspect that Java wont be

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-10 Thread Rick Jones
Part of the issue is that NODELAY has dual meaning. It means don't delay acks (on receiver), and don't coalesce writes (on sender). If java didn't turn on NODELAY, it would get coalescing but it would then get delayed acks. Ah, this is the first time I've heard that TCP_NODELAY on a receiver

Re: net-2.6.17 build broken due to SELinux

2006-03-10 Thread Arnaldo Carvalho de Melo
On 3/10/06, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: On 3/10/06, Xiaolan Zhang [EMAIL PROTECTED] wrote: Hi, I will work on a fix. Thanks. More breakage, this time with make allmodconfig, please fix. - Arnaldo /pub/scm/linux/kernel/git/acme/net-2.6.17/security/dummy.c: In

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-10 Thread Stephen Hemminger
On Fri, 10 Mar 2006 10:27:35 -0800 Rick Jones [EMAIL PROTECTED] wrote: Part of the issue is that NODELAY has dual meaning. It means don't delay acks (on receiver), and don't coalesce writes (on sender). If java didn't turn on NODELAY, it would get coalescing but it would then get

Re: net-2.6.17 build broken due to SELinux

2006-03-10 Thread Arnaldo Carvalho de Melo
On 3/10/06, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: On 3/10/06, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: On 3/10/06, Xiaolan Zhang [EMAIL PROTECTED] wrote: Hi, I will work on a fix. Thanks. More breakage, this time with make allmodconfig, please fix. -

[2.6 patch] hostap_ap.c:hostap_add_sta(): inconsequent NULL checking

2006-03-10 Thread Adrian Bunk
The Coverity checker spotted this inconsequent NULL checking (unconditionally dereferencing directly after checking for NULL isn't a good idea). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6.16-rc5-mm3-full/drivers/net/wireless/hostap/hostap_ap.c.old 2006-03-10

Re: net-2.6.17 build broken due to SELinux

2006-03-10 Thread Xiaolan Zhang
Hi, Arnaldo, This looks a bit surprising because that 2 lines should have already been in the patch (lsm-secpeer) that this patch (lsm-secpeer-unix) depends on. See below: thanks, Catherine diff -puN security/dummy.c~lsm-secpeer security/dummy.c ---

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-10 Thread Eric Molitor
Was there a trace posted somewhere? I would indeed like to look at it. I'd be quite happy to slam java it it happened to be putting logically associated data onto the connection in separate send calls :) It was sent to Bugzilla but too large so Andrew Morton kindly uploaded it to

Re: net-2.6.17 build broken due to SELinux

2006-03-10 Thread Arnaldo Carvalho de Melo
On 3/10/06, Xiaolan Zhang [EMAIL PROTECTED] wrote: Hi, Arnaldo, This looks a bit surprising because that 2 lines should have already been in the patch (lsm-secpeer) that this patch (lsm-secpeer-unix) depends on. See below: Look at:

Re: net-2.6.17 build broken due to SELinux

2006-03-10 Thread Xiaolan Zhang
Arnaldo, Thanks for the update and quick fix! Catherine [EMAIL PROTECTED] wrote on 03/10/2006 02:50:48 PM: On 3/10/06, Xiaolan Zhang [EMAIL PROTECTED] wrote: Hi, Arnaldo, This looks a bit surprising because that 2 lines should have already been in the patch (lsm-secpeer) that this

[PATCH 2.6.16-rc5] S2io: Receive packet classification and steering mechanisms

2006-03-10 Thread Ravinandan Arakali
Hi, Attached below is a patch to several receive packet classification and steering mechanisms for Xframe NIC hw channels. Current Xframe ASIC supports one hardware channel per CPU, up to 8 channels. This number will increase in the next ASIC release. A channel could be attached to a specific

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-10 Thread Rick Jones
Eric Molitor wrote: Was there a trace posted somewhere? I would indeed like to look at it. I'd be quite happy to slam java it it happened to be putting logically associated data onto the connection in separate send calls :) It was sent to Bugzilla but too large so Andrew Morton kindly

[PATCH] dl2k: DMA freeing error

2006-03-10 Thread Jon Mason
This patch fixes an error in the dl2k driver's DMA mapping/unmapping. The adapter uses the upper 16bits of the DMA address for the buffer size. However, this is not masked off when referencing the DMA address, and can lead to errors by trying to free a DMA address out of range. Thanks, Jon

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-10 Thread Rick Jones
ABC is strictly enforcing byte based CWND growth now. All the details are in RFC3465. That certainly is an odd looking trace. There doesn't happen to be a system call trace to go along with it does there? It looks like it goes along like this: 13:23:33.458806 IP l.5877 l.12823: P

CS8920 documentation anyone?

2006-03-10 Thread Deepak Saxena
Hi, I'm working on cleaning up/rewriting the CS89x0 driver as it is a mess and is turning into more of due to embedded systems using this chip. I've been able to find CS8900 docs on Cirrus' website but can't find any cs8920-specific documentation and the existing driver has lots of 8920-isms

Re: [Bugme-new] [Bug 6177] New: Java remote debugging is slow due to apparent networking bug

2006-03-10 Thread Stephen Hemminger
The strace shows that the client? does lots of little send's also, the response is handled in a different thread than the sender so they spend a lot of time banging on futex's. I got these by doing strace -ff -o /tmp/foo eclipse sched_getscheduler(15164) = 0 (SCHED_OTHER)

[PATCH 8/9] [DCCP] minisock: Rename struct dccp_options to struct dccp_minisock

2006-03-10 Thread Arnaldo Carvalho de Melo
This will later be included in struct dccp_request_sock so that we can have per connection feature negotiation state while in the 3way handshake, when we clone the DCCP_ROLE_LISTEN socket (in dccp_create_openreq_child) we'll just copy this state from dreq_minisock to dccps_minisock. Also the

[PATCH 2/9] [ICSK] compat: Introduce inet_csk_compat_[gs]etsockopt

2006-03-10 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- include/net/inet_connection_sock.h |5 + net/dccp/proto.c | 23 +++ net/ipv4/inet_connection_sock.c| 30 ++ net/ipv4/tcp.c | 26

[PATCH 0/9] Build Fixes, cleanups and some DCCP trivial patches

2006-03-10 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.17.git Best Regards, - Arnaldo b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c |2 b/include/linux/dccp.h | 43 --- b/include/net/inet_connection_sock.h

[PATCH 6/9] [NET]: Identation other cleanups related to compat_[gs]etsockopt cset

2006-03-10 Thread Arnaldo Carvalho de Melo
No code changes, just tidying up, in some cases moving EXPORT_SYMBOLs to just after the function exported, etc. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/core/sock.c| 20 +++--- net/dccp/ipv4.c| 72 +++ net/dccp/ipv6.c

[PATCH 9/9] [DCCP] feat: Pass dccp_minisock ptr where only the minisock is used

2006-03-10 Thread Arnaldo Carvalho de Melo
This is in preparation for having a dccp_minisock embedded into dccp_request_sock so that feature negotiation can be done prior to creating the full blown dccp_sock. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/feat.c | 30 ++

[PATCH 4/9] [SECURITY] getpeersec: Fix build breakage

2006-03-10 Thread Arnaldo Carvalho de Melo
a265d6baa827bd6411d1c5566b9e3596fec88a91 removes dummy_socket_getpeersec, replacing it with two new functions, but still references the removed function in the security_fixup_ops table, fix it by doing the replacement operation in the fixup table too. Signed-off-by: Arnaldo Carvalho de Melo

[PATCH 3/9] [INFINIBAND] ipoib: Remove leftover use of neigh_ops-destructor

2006-03-10 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- drivers/infiniband/ulp/ipoib/ipoib_multicast.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) b4692710ef01c342b050947b55240424854d272e diff --git a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c

[PATCH 5/9] [SK_BUFF]: export skb_pull_rcsum

2006-03-10 Thread Arnaldo Carvalho de Melo
*** Warning: skb_pull_rcsum [net/bridge/bridge.ko] undefined! *** Warning: skb_pull_rcsum [net/8021q/8021q.ko] undefined! *** Warning: skb_pull_rcsum [drivers/net/pppoe.ko] undefined! *** Warning: skb_pull_rcsum [drivers/net/ppp_generic.ko] undefined! Signed-off-by: Arnaldo Carvalho de Melo

[PATCH 7/9] [SELINUX]: selinux_socket_getpeer_{stream,dgram} fixup

2006-03-10 Thread Arnaldo Carvalho de Melo
Signed-off-by: Catherine Zhang [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- security/selinux/include/xfrm.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) 4efa8434cce5535cefea8e9f44fada7136159722 diff --git

[PATCH 1/9] [SNAP]: Remove leftover unused hdr variable

2006-03-10 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/802/psnap.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) ad864a85e3a5ff4f063d8e415ffd44a7a249feb2 diff --git a/net/802/psnap.c b/net/802/psnap.c index 97c95ee..270b9d2 100644 --- a/net/802/psnap.c +++

Re: [PATCH 0/9] Build Fixes, cleanups and some DCCP trivial patches

2006-03-10 Thread David S. Miller
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Fri, 10 Mar 2006 18:22:17 -0300 Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.17.git Thanks for fixing all of this stuff up, pulled. - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-10 Thread Stephen Hemminger
On Fri, 10 Mar 2006 13:41:28 -0800 Rick Jones [EMAIL PROTECTED] wrote: ABC is strictly enforcing byte based CWND growth now. All the details are in RFC3465. That certainly is an odd looking trace. There doesn't happen to be a system call trace to go along with it does there? It

Re: [Bugme-new] [Bug 6177] New: Java remote debugging is slow due to apparent networking bug

2006-03-10 Thread Eric Molitor
Am I correct in assuming by Client you mean Eclipse and by the other side you mean the JDK? On 3/10/06, Stephen Hemminger [EMAIL PROTECTED] wrote: The strace shows that the client? does lots of little send's also, the response is handled in a different thread than the sender so they spend a

Re: [Bugme-new] [Bug 6177] New: Java remote debugging is slow due to apparent networking bug

2006-03-10 Thread Stephen Hemminger
On Fri, 10 Mar 2006 16:11:07 -0600 Eric Molitor [EMAIL PROTECTED] wrote: Am I correct in assuming by Client you mean Eclipse and by the other side you mean the JDK? Since the process are all inside the JVM it is impossible to really tell, but that's my assumption. - To unsubscribe from this

Re: [PATCH] fix spidernet build issue

2006-03-10 Thread Andrew Morton
Jens Osterkamp [EMAIL PROTECTED] wrote: This patch fixes a spidernet build issue found in 2.6.16-rc5-mm2. What build issue? The duplicate symbols? I forget what they were, actually. It really helps if you can include the compiler/linker error messages when fixing build problems please.

Re: [PATCH] IPv6: Cleanups for net/ipv6/addrconf.c (kzalloc, early exit) v2

2006-03-10 Thread Ingo Oeser
From: Ingo Oeser [EMAIL PROTECTED] Here are some possible (and trivial) cleanups. - use kzalloc() where possible - invert allocation failure test like if (object) { /* Rest of function here */ } to if (object == NULL) return NULL; /* Rest of function here */

[2.6 patch] net/decnet/dn_route.c: fix inconsequent NULL checking

2006-03-10 Thread Adrian Bunk
The Coverity checker noted this inconsequent NULL checking in dnrt_drop(). Since all callers ensure that NULL isn't passed, we can simply remove the check. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6.16-rc5-mm3-full/net/decnet/dn_route.c.old 2006-03-10 23:34:57.0 +0100

net-2.6.17 build still broken due to getpeersec

2006-03-10 Thread David S. Miller
The Unix getpeersec changes added calls to security_sid_to_context(), but there is no implementation available when CONFIG_SECURITY is not enabled. In file included from net/unix/af_unix.c:112: include/net/scm.h: In function 'scm_recv': include/net/scm.h:74: warning: implicit declaration of

Re: [PATCH] orinoco: fix BAP0 offset error after several days of operation

2006-03-10 Thread Pavel Roskin
On Thu, 2006-03-09 at 18:44 +0100, Jiri Benc wrote: After several days of operation of Netgear MA311 card, the card becomes to seek improperly and needs reset. This patch tries to reset the card when this situation occurs. Thanks, applied. I had to move the location closer to the end because

Re: net-2.6.17 build still broken due to getpeersec

2006-03-10 Thread Xiaolan Zhang
Hi, David, David S. Miller [EMAIL PROTECTED] wrote on 03/10/2006 06:45:17 PM: The Unix getpeersec changes added calls to security_sid_to_context(), but there is no implementation available when CONFIG_SECURITY is not enabled. In file included from net/unix/af_unix.c:112:

Re: [Bugme-new] [Bug 6177] New: Java remote debugging is slow due to apparent networking bug

2006-03-10 Thread Rick Jones
Stephen Hemminger wrote: The strace shows that the client? does lots of little send's also, the response is handled in a different thread than the sender so they spend a lot of time banging on futex's. I got these by doing strace -ff -o /tmp/foo eclipse sched_getscheduler(15164) = 0

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-10 Thread Rick Jones
I would have thought that byte based growth of the CWND would have meant that the ACK's above would have allowed more bytes to flow, yet more bytes are not flowing. That makes it seem like cwnd isn't strictly bytes, but is also tracked in terms of number of outstanding segments. Linux cwnd

Re: net-2.6.17 build still broken due to getpeersec

2006-03-10 Thread David S. Miller
From: Xiaolan Zhang [EMAIL PROTECTED] Date: Fri, 10 Mar 2006 18:58:20 -0500 I'm working on this tonight. James has a patch that deals with this issue so I'll borrow from that. Thank you, let me know when you have a patch ready. - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-10 Thread Stephen Hemminger
On Fri, 10 Mar 2006 16:16:07 -0800 Rick Jones [EMAIL PROTECTED] wrote: I would have thought that byte based growth of the CWND would have meant that the ACK's above would have allowed more bytes to flow, yet more bytes are not flowing. That makes it seem like cwnd isn't strictly bytes,

Re: [PATCH 4/6 v2] IB: address translation to map IP toIB addresses (GIDs)

2006-03-10 Thread Roland Dreier
The ib_addr module depends on CONFIG_INET, because it uses symbols like arp_tbl, which are only exported if INET is enabled. I fixed this up by creating a new (non-user-visible) config symbol to control when ib_addr is built -- I put the following diff on top of your patch in my tree: diff --git

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-10 Thread Rick Jones
Stephen Hemminger wrote: On Fri, 10 Mar 2006 16:16:07 -0800 Rick Jones [EMAIL PROTECTED] wrote: I would have thought that byte based growth of the CWND would have meant that the ACK's above would have allowed more bytes to flow, yet more bytes are not flowing. That makes it seem like cwnd

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-10 Thread David S. Miller
From: Rick Jones [EMAIL PROTECTED] Date: Fri, 10 Mar 2006 17:15:14 -0800 /* RFC3465: Slow Start * TCP sender SHOULD increase cwnd by the number of * previously unacknowledged bytes ACKed by each incoming * acknowledgment, provided the

drivers/net/chelsio/sge.c: two array overflows

2006-03-10 Thread Adrian Bunk
The Coverity checker spotted the following two array overflows in drivers/net/chelsio/sge.c (in both cases, the arrays contain 3 elements): -- snip -- ... static void restart_tx_queues(struct sge *sge) { ... sge-stats.cmdQ_restarted[3]++; ... static int

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-10 Thread Rick Jones
David S. Miller wrote: From: Rick Jones [EMAIL PROTECTED] Date: Fri, 10 Mar 2006 17:15:14 -0800 /* RFC3465: Slow Start * TCP sender SHOULD increase cwnd by the number of * previously unacknowledged bytes ACKed by each incoming

[PATCH 0/8] Intel I/O Acceleration Technology (I/OAT)

2006-03-10 Thread Chris Leech
This patch series is the a full release of the Intel(R) I/O Acceleration Technology (I/OAT) for Linux. It includes an in kernel API for offloading memory copies to hardware, a driver for the I/OAT DMA memcpy engine, and changes to the TCP stack to offload copies of received networking data to

[PATCH 1/8] [I/OAT] DMA memcpy subsystem

2006-03-10 Thread Chris Leech
Provides an API for offloading memory copies to DMA devices Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/Kconfig |2 drivers/Makefile |1 drivers/dma/Kconfig | 13 ++ drivers/dma/Makefile |1 drivers/dma/dmaengine.c | 360

[PATCH 3/8] [I/OAT] Setup the networking subsystem as a DMA client

2006-03-10 Thread Chris Leech
Attempts to allocate per-CPU DMA channels Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/dma/Kconfig | 12 + include/linux/netdevice.h |6 +++ include/net/netdma.h | 37 + net/core/dev.c| 100

[PATCH 6/8] [I/OAT] Rename cleanup_rbuf to tcp_cleanup_rbuf and make non-static

2006-03-10 Thread Chris Leech
Needed to be able to call tcp_cleanup_rbuf in tcp_input.c for I/OAT Signed-off-by: Chris Leech [EMAIL PROTECTED] --- include/net/tcp.h |2 ++ net/ipv4/tcp.c| 10 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index

[PATCH 8/8] [I/OAT] TCP recv offload to I/OAT

2006-03-10 Thread Chris Leech
Locks down user pages and sets up for DMA in tcp_recvmsg, then calls dma_async_try_early_copy in tcp_v4_do_rcv Signed-off-by: Chris Leech [EMAIL PROTECTED] --- include/net/netdma.h |1 net/ipv4/tcp.c | 110 +- net/ipv4/tcp_input.c |

[PATCH 7/8] [I/OAT] Add a sysctl for tuning the I/OAT offloaded I/O threshold

2006-03-10 Thread Chris Leech
Any socket recv of less than this ammount will not be offloaded Signed-off-by: Chris Leech [EMAIL PROTECTED] --- include/linux/sysctl.h |1 + include/net/tcp.h |1 + net/core/user_dma.c|4 net/ipv4/sysctl_net_ipv4.c | 10 ++ 4 files changed, 16

[PATCH 2/8] [I/OAT] Driver for the Intel(R) I/OAT DMA engine

2006-03-10 Thread Leech, Christopher
From: Chris Leech [mailto:[EMAIL PROTECTED] Sent: Friday, March 10, 2006 6:29 PM To: Subject: [PATCH 2/8] [I/OAT] Driver for the Intel(R) I/OAT DMA engine Adds a new ioatdma driver Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/dma/Kconfig |9 drivers/dma/Makefile

[PATCH 4/8] [I/OAT] Utility functions for offloading sk_buff to iovec copies

2006-03-10 Thread Chris Leech
Provides for pinning user space pages in memory, copying to iovecs, and copying from sk_buffs including fragmented and chained sk_buffs. Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/dma/Makefile |3 drivers/dma/iovlock.c | 301

[PATCH 5/8] [I/OAT] Structure changes for TCP recv offload to I/OAT

2006-03-10 Thread Chris Leech
Adds an async_wait_queue and some additional fields to tcp_sock, and a dma_cookie_t to sk_buff. Signed-off-by: Chris Leech [EMAIL PROTECTED] --- include/linux/skbuff.h |6 ++ include/linux/tcp.h| 10 ++ include/net/sock.h |2 ++ include/net/tcp.h |9

Re: [2.6 patch] net/decnet/dn_route.c: fix inconsequent NULL checking

2006-03-10 Thread Herbert Xu
Adrian Bunk [EMAIL PROTECTED] wrote: The Coverity checker noted this inconsequent NULL checking in dnrt_drop(). Since all callers ensure that NULL isn't passed, we can simply remove the check. Ack. In fact it's pointless even if the caller didn't check as dst_release checks it anyway.

[2.6 patch] drivers/net/wireless/ipw2200.c: fix an array overun

2006-03-10 Thread Adrian Bunk
This patch fixes a big array overun found by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6.16-rc5-mm3-full/drivers/net/wireless/ipw2200.c.old 2006-03-11 02:41:23.0 +0100 +++ linux-2.6.16-rc5-mm3-full/drivers/net/wireless/ipw2200.c2006-03-11

RE: [PATCH 4/6 v2] IB: address translation to map IP toIB addresses (GIDs)

2006-03-10 Thread Sean Hefty
The ib_addr module depends on CONFIG_INET, because it uses symbols like arp_tbl, which are only exported if INET is enabled. I fixed this up by creating a new (non-user-visible) config symbol to control when ib_addr is built -- I put the following diff on top of your patch in my tree: Thanks!