* Francois Romieu [EMAIL PROTECTED] [2007-01-25 00:17]:
Untested, straight from the release early dept. You have been warned.
Works here.
Regards,
Bernhard
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On 26-01-2007 04:37, Masayuki Nakagawa wrote:
This patch simply replaces __kfree_skb() in exit path with kfree_skb().
In tcp_rcv_state_process(), generally skbs should be destroyed only when
the ref count is zero.
That is the way things are supposed to be done in the kernel.
This change
From: Baruch Even [EMAIL PROTECTED]
Date: Fri, 26 Jan 2007 08:40:09 +0200
You actually need recv_sack_cache to detect if you can use the fast
path. Another alternative is to somehow hash the values of the sack
blocks but then you rely on probabilty that you will properly detect the
ability to
From: Jan Engelhardt [EMAIL PROTECTED]
Date: Thu, 25 Jan 2007 23:14:49 +0100 (MET)
People really depend on this. Much more than than pid/comm/smpunsafe stuff.
For example, a web server [cgi enabled, etc.] which also runs squid,
to force all webtraffic through it:
-A OUTPUT -p tcp --dport 80
On Fri, Jan 26, 2007 at 09:28:38AM +0100, Jarek Poplawski wrote:
So maybe for some time there should be added skb-users
test with a warning to reveal this?
Or just replace __kfree_skb by kfree_skb. The atomic operation (the
expensive part of kfree_skb vs. __kfree_skb) is only taken when it
On Fri, Jan 26, 2007 at 08:16:06PM +1100, Herbert Xu wrote:
On Fri, Jan 26, 2007 at 09:28:38AM +0100, Jarek Poplawski wrote:
So maybe for some time there should be added skb-users
test with a warning to reveal this?
Or just replace __kfree_skb by kfree_skb. The atomic operation (the
On Fri, Jan 26, 2007 at 10:49:50AM +0100, Jarek Poplawski wrote:
How do we know about those improper deals?
I understand there should be no other users here
if it's __kfree_skb now. So I mean to test and warn
before kfree_skb for some debugging time.
We only need to do that if there is a
On Fri, Jan 26, 2007 at 08:52:51PM +1100, Herbert Xu wrote:
On Fri, Jan 26, 2007 at 10:49:50AM +0100, Jarek Poplawski wrote:
How do we know about those improper deals?
I understand there should be no other users here
if it's __kfree_skb now. So I mean to test and warn
before kfree_skb
On Friday 26 January 2007 03:44, John W. Linville wrote:
On Sat, Dec 30, 2006 at 11:25:15PM -0600, Larry Finger wrote:
The current bcm43xx driver ignores any wireless-enable switches on mini-PCI
and mini-PCI-E cards. This patch implements a new routine to interrogate the
radio hardware
On Fri, Jan 26, 2007 at 11:18:38AM +0100, Jarek Poplawski wrote:
I don't mean it's necessary. I mean now skb is freed
unconditionally and after this patch, if there is some
error in counting, skb will stay. I thought Masayuki
wrote about such possibility, but if I missed his
point, then the
From: Herbert Xu [EMAIL PROTECTED]
Date: Fri, 26 Jan 2007 21:45:18 +1100
I'm not aware of anybody who has coded in this way. Alexey Dave,
do you know of any place where __kfree_skb is used to free an skb
whose ref count is greater than 1?
Not at all.
-
To unsubscribe from this list: send
On Fri, Jan 26, 2007 at 09:45:18PM +1100, Herbert Xu wrote:
On Fri, Jan 26, 2007 at 11:18:38AM +0100, Jarek Poplawski wrote:
I don't mean it's necessary. I mean now skb is freed
unconditionally and after this patch, if there is some
error in counting, skb will stay. I thought Masayuki
I’m working on an embedded network interface (core by Synopsys) and I’ve already
written my first Linux network device driver.
My hardware has an internal DMA so I’ve used the scatter gather implementation.
Moreover, this HW doesn’t support the TSO feature.
I’m wondering if I can use the new GSO
David Miller writes:
Yes the case when the trie is just a single leaf got wrong with the
iterator and your patchs cures it. I think we have a similar problem
with /proc/net/fib_trie
I'm happy to review a fix for that :-)
When main table is just a single leaf this gets printed as
This patch adds improved version of enable_fiber for both the 5421 and
the 5461 phy. It is now possible to specify with these wether you want
autonegotiation or not. This is needed for bladecenter switches where
some expect autonegotiation and some dont seem to like this at all.
Depending on this
This patch modifies the patch submitted by Kou Ishizaki to make it work on the
blade (http://marc.theaimsgroup.com/?l=linux-netdevm=116593424505539w=2).
Unfortunately I dont have access to a Celleb so I cannot test it there.
The basic logic behind this is simple : when the interface first comes
On Fri, Jan 26, 2007 at 12:02:35PM +0100, Jarek Poplawski wrote:
On Fri, Jan 26, 2007 at 09:45:18PM +1100, Herbert Xu wrote:
On Fri, Jan 26, 2007 at 11:18:38AM +0100, Jarek Poplawski wrote:
I don't mean it's necessary. I mean now skb is freed
unconditionally and after this patch, if
Francois Romieu wrote:
Untested, straight from the release early dept. You have been warned.
Realtek's driver restricts itself to 0x8169 and 0x8167.
It won't be surprising if it breaks on anything else until
I merge the new 0x8168 and 0x8136 bits.
Signed-off-by: Francois Romieu [EMAIL
On Thu, 2007-01-25 at 09:34 -0500, Gene Heskett wrote:
MLME? More acronyms I've not put in my wet dictionary.. :)
The 802.11 specs have a huge list of acronyms you might want to be
somewhat familiar with. I think I have a printout somewhere, can't ever
remember them either ;)
johannes
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
---
drivers/usb/net/asix.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/net/asix.c b/drivers/usb/net/asix.c
index 896449f..4206df2 100644
--- a/drivers/usb/net/asix.c
+++ b/drivers/usb/net/asix.c
@@
s/FEter/FEther/.
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
---
drivers/usb/net/pegasus.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/net/pegasus.h b/drivers/usb/net/pegasus.h
index 98f6898..c746782 100644
--- a/drivers/usb/net/pegasus.h
+++
On Fri, Jan 26, 2007 at 02:18:08PM +0100, Jarek Poplawski wrote:
...
I've only now read the original thread of this problem
and this long note about security. I need more time to
understand this, but now I'm not sure Masayuki's server
isn't doing something against the policy of this note
This
YOSHIFUJI Hideaki / 吉藤英明 wrote:
In article [EMAIL PROTECTED] (at Thu, 25 Jan 2007 14:45:00 -0500), Neil
Horman [EMAIL PROTECTED] says:
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 2a7e461..46f91ee 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -830,7 +830,8
Hello!
do you know of any place where __kfree_skb is used to free an skb
whose ref count is greater than 1?
No.
Actually, since kfree_skb is not inline, __kfree_skb could be made static
and remaining places still using it switched to kfree_skb.
-
To unsubscribe from this list: send the
On Thu, Jan 25, 2007 at 05:13:57PM -0500, Vlad Yasevich wrote:
Hi Neil
I prefer to be more explicit in my order of operation, but that does seem
more
consistent with the prevaling style. New patch attached.
Looks good to me.
One question thought. What causes the stack to
Kumar,
I've got a BCM5461 that requires this fix to be able to force the speeds
on the PHY. Not sure if its needed on the other variants or not. The
problem is the genphy_config_aneg resets the PHY when forcing the speed
and once we reset the BCM5461 it doesn't remember any of its
Robert Olsson [EMAIL PROTECTED] writes:
David Miller writes:
Yes the case when the trie is just a single leaf got wrong with the
iterator and your patchs cures it. I think we have a similar problem
with /proc/net/fib_trie
I'm happy to review a fix for that :-)
When main
In article [EMAIL PROTECTED] (at Fri, 26 Jan 2007 09:27:30 -0500), Neil
Horman [EMAIL PROTECTED] says:
I'm looking for it at the moment, but I too had assumed that redirecting the
outgoing packet to the default router would happen automatically within the
routing code as a result of not
On Fri, 26 Jan 2007, Kumar Gala wrote:
It looks like phy_timer has changed a bit in 2.6.20-rc6, what exactly was the
intent of these changes?
As I wrote, I'll have a look at these patches after 2.6.20 again. These
bits are from September (see the timestamps) and some of them may well
have
This patch is an incremental fix to the flow_cache_genid
patch for selinux that breaks the build of 2.6.20-rc6 when
xfrm is not configured.
Signed-off-by: Venkat Yekkirala [EMAIL PROTECTED]
---
security/selinux/include/xfrm.h |9 +
security/selinux/ss/services.c |6 +++---
2
On Fri, Jan 26, 2007 at 02:09:29PM +0100, Jens Osterkamp wrote:
This patch modifies the patch submitted by Kou Ishizaki to make it work on the
blade (http://marc.theaimsgroup.com/?l=linux-netdevm=116593424505539w=2).
Index: linux-2.6/drivers/net/spider_net.c
+ if (card-aneg_count
On Sat, Jan 27, 2007 at 12:44:29AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote:
In article [EMAIL PROTECTED] (at Fri, 26 Jan 2007 09:27:30 -0500), Neil
Horman [EMAIL PROTECTED] says:
I'm looking for it at the moment, but I too had assumed that redirecting the
outgoing packet to the default
On Fri, Jan 26, 2007 at 09:13:31AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote:
In article [EMAIL PROTECTED] (at Thu, 25 Jan 2007 14:45:00 -0500), Neil
Horman [EMAIL PROTECTED] says:
New patch attached with most of your suggestions incorporated. I've a few
comments mixed in for some of the
Version update to 1.11.1.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- sky2-2.6.orig/drivers/net/sky2.c2007-01-26 11:27:42.0 -0800
+++ sky2-2.6/drivers/net/sky2.c 2007-01-26 11:27:45.0
These patches are against netdev-2.6#upstream. The enhancements
are WOL support and use of dev_printk.
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Maintain packet statistics in software rather than hardware.
This is slightly slower, but allows easier debugging of problems
where packets are still being received by PHY but not being handled
by hardware.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c | 21
If alloc_etherdev() failed, then sky2_init_netdev will return NULL,
and sky2_probe would end up returning 0 instead of -ENOMEM.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- sky2-2.6.orig/drivers/net/sky2.c2007-01-25 13:09:31.0 -0800
+++ sky2-2.6/drivers/net/sky2.c
Adds basic magic packet wake on lan support to the sky2 driver.
Note: initial WOL value is based on BIOS settings.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c | 208 ++---
drivers/net/sky2.h | 28 ++-
2 files
Use the standard dev_printk functions instead of printk directly for
error reports. Fix a bug where the initialization would return 0
if allocation of network device failed.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c | 75
On Fri, 2007-01-26 at 14:09 +0100, Jens Osterkamp wrote:
This patch modifies the patch submitted by Kou Ishizaki to make it work on the
blade (http://marc.theaimsgroup.com/?l=linux-netdevm=116593424505539w=2).
Unfortunately I dont have access to a Celleb so I cannot test it there.
The basic
On Fri, 2007-01-26 at 14:07 +0100, Jens Osterkamp wrote:
This patch adds improved version of enable_fiber for both the 5421 and
the 5461 phy. It is now possible to specify with these wether you want
autonegotiation or not. This is needed for bladecenter switches where
some expect
Hi Neil
Neil Horman wrote:
On Fri, Jan 26, 2007 at 09:13:31AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote:
In article [EMAIL PROTECTED] (at Thu, 25 Jan 2007 14:45:00 -0500), Neil
Horman [EMAIL PROTECTED] says:
New patch attached with most of your suggestions incorporated. I've a few
comments
On Fri, 2007-01-26 at 22:57 +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote:
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
Acked-by: David Hollis [EMAIL PROTECTED]
---
drivers/usb/net/asix.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/net/asix.c
On Fri, Jan 26, 2007 at 03:28:40PM -0500, Vlad Yasevich wrote:
Hi Neil
Neil Horman wrote:
On Fri, Jan 26, 2007 at 09:13:31AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote:
In article [EMAIL PROTECTED] (at Thu, 25 Jan 2007 14:45:00 -0500), Neil
Horman [EMAIL PROTECTED] says:
New patch
Patch is whitespace damaged...
sending it again as attachment...
Jens
Subject: spidernet: add improved phy support
This patch adds improved version of enable_fiber for both the 5421 and
the 5461 phy. It is now possible to specify with these wether you want
autonegotiation or not. This is
JUNG, Christian [EMAIL PROTECTED] wrote:
Jay Vosburgh [EMAIL PROTECTED] wrote:
Is your test occuring on an isolated network, and is there other
concurrent network traffic that might be affecting things?
The problem still persists as long as the box is connected to our Ciscos.
I tried
Jens Osterkamp [EMAIL PROTECTED] :
Patch is whitespace damaged...
sending it again as attachment...
Inlined patches are preferred.
Index: linux-2.6.20-rc5/drivers/net/sungem_phy.c
===
---
On Fri, 26 Jan 2007, mirek kratochvil wrote:
In case you have BIOS 04.., try to upgrade to 06.. version. Also, does
it help when you boot with acpi=off kernel commandline parameter? (do
you compile kernel with both acpi and apic support?).
Upgraded to bios 0802, but still the same
While working with the latest bonding code I noticed a nasty problem
that will prevent arp monitoring from always functioning correctly on
x86_64 systems. Comparing ints to longs and expecting reliable results
on x86_64 is a bad idea. With this patch, arp monitoring works correctly
again.
This
FYI- The patch can be viewed here:
http://marc.theaimsgroup.com/?l=linux-netdevm=116983297300536w=2
-Original Message-
From: Michal Piotrowski [mailto:[EMAIL PROTECTED]
Sent: Friday, January 26, 2007 1:04 PM
To: Adrian Bunk
Cc: Linus Torvalds; Andrew Morton; Linux Kernel Mailing
Andy Gospodarek [EMAIL PROTECTED] wrote:
While working with the latest bonding code I noticed a nasty problem
that will prevent arp monitoring from always functioning correctly on
x86_64 systems. Comparing ints to longs and expecting reliable results
on x86_64 is a bad idea. With this patch, arp
David Miller [EMAIL PROTECTED] wrote:
Shaper is actually OK. None of these hardware header callbacks
should be invoked if the device is down. Yet, this is what is
accidently being allowed in the AF_PACKET socket layer.
Hmm, what if the device goes down after the check?
Cheers,
--
Visit
This email lists some known regressions in 2.6.20-rc6 compared to 2.6.19
that are not yet fixed in Linus' tree.
If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you caused a breakage or I'm
Hi,
Adrian Bunk napisał(a):
This email lists some known regressions in 2.6.20-rc6 compared to 2.6.19
that are not yet fixed in Linus' tree.
If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you
On Tuesday 16 January 2007 19:55, Marcelo Tosatti wrote:
Announcing an updated patch of the Marvell Libertas 8388 802.11 USB
driver.
Diff can be found at
http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch
_Please_ review, this driver is targeted for mainline inclusion.
From: Venkat Yekkirala [EMAIL PROTECTED]
Date: Fri, 26 Jan 2007 10:58:03 -0600
This patch is an incremental fix to the flow_cache_genid
patch for selinux that breaks the build of 2.6.20-rc6 when
xfrm is not configured.
Signed-off-by: Venkat Yekkirala [EMAIL PROTECTED]
Applied, thanks for
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Fri, 26 Jan 2007 08:42:25 -0700
Robert Olsson [EMAIL PROTECTED] writes:
David Miller writes:
Yes the case when the trie is just a single leaf got wrong with the
iterator and your patchs cures it. I think we have a similar problem
From: Herbert Xu [EMAIL PROTECTED]
Date: Sat, 27 Jan 2007 11:45:05 +1100
David Miller [EMAIL PROTECTED] wrote:
Shaper is actually OK. None of these hardware header callbacks
should be invoked if the device is down. Yet, this is what is
accidently being allowed in the AF_PACKET socket
From: Herbert Xu [EMAIL PROTECTED]
Date: Sat, 27 Jan 2007 12:01:46 +1100
In fact, the shaper device doesn't even seem to take a ref count of
the device it has attached to. So that device can go away at any time.
What's more, there are drivers that can change hard_header at run-time
(s390).
drivers/net/b44.c: In function `b44_sync_dma_desc_for_cpu':
drivers/net/b44.c:144: warning: implicit declaration of function
`dma_sync_single_range_for_cpu'
several architectures appear to not implement dma_sync_single_range_for_cpu()
-
To unsubscribe from this list: send the line unsubscribe
60 matches
Mail list logo
