Re: PATCH: netdev: add a cast NLMSG_OK to avoid a GCC warning in users' code

| From: David Miller | From: "D. Hugh Redelmeier" | Date: Wed, 9 Sep 2015 16:24:07 -0400 (EDT) | > 1) netlink(3) says that the type of the second parameter is "int". | >From the synopsis: | >int NLMSG_OK(struct nlmsghdr *nlh, int len); | >

Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

Petr Cvek writes: >> Should have been posted to linux arm kernel mailing list, unless my mailer >> failed ... >> > Searching for: > > "ARM: pxa: add resources to pxaficp_ir" > > did not found anything, same was for "ficp" in the > linux-arm-kernel/netdev/linux-kernel >

Re: [PATCH/RFC v2 net-next 3/4] ravb: Document binding for r8a7795 SoC

Hi Simon, On Fri, Sep 11, 2015 at 4:01 AM, Simon Horman wrote: > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt > @@ -6,8 +6,11 @@ interface contains. > Required properties: > - compatible:

Re: PATCH: netdev: add a cast NLMSG_OK to avoid a GCC warning in users' code

| From: David Miller | Everyone either uses an unsigned type (such as "size_t") or adds an | explicit cast to an unsinged type for the second argument. That sounded odd to me. So I looked through the Fedora code base, as indexed by searchcode.com. This took a stupid

Re: NFS/TCP/IPv6 acting strangely in 4.2

On Fri, Sep 11, 2015 at 05:24:17PM +0100, Russell King - ARM Linux wrote: > On Fri, Sep 11, 2015 at 08:18:43AM -0700, Eric Dumazet wrote: > > On Fri, 2015-09-11 at 16:06 +0100, Russell King - ARM Linux wrote: > > > On Fri, Sep 11, 2015 at 03:33:47PM +0100, Russell King - ARM Linux wrote: > > > >

[PATCH v3 net 2/5] ipv6: Rename the dst_cache helper functions in ip6_tunnel

It is a prep work to fix the dst_entry refcnt bugs in ip6_tunnel. This patch rename: 1. ip6_tnl_dst_check() to ip6_tnl_dst_get() to better reflect that it will take a dst refcnt in the next patch. 2. ip6_tnl_dst_store() to ip6_tnl_dst_set() to have a more conventional name matching with

[fw filter]: Broken! fw mark based tc class selection not working

Recently I came to know that, Without any options fw classifier maps fwmark to classid. tc filter add dev parent protocol ip prio 1 fw i.e. if my packet has mark(0x10001) and class id is not set, then above tc filter, will set class id = 0x10001 i.e. 1:1 But when I am trying it out, its not

RE: PATCH: netdev: add a cast NLMSG_OK to avoid a GCC warning in users' code

| From: David Laight | From: D. Hugh Redelmeier | > #define NLMSG_OK(nlh,len) ((len) >= (int)sizeof(struct nlmsghdr) && \ | >(nlh)->nlmsg_len >= sizeof(struct nlmsghdr) && \ | >(nlh)->nlmsg_len <= (len)) | Why not cast

Re: NFS/TCP/IPv6 acting strangely in 4.2

On Fri, Sep 11, 2015 at 08:18:43AM -0700, Eric Dumazet wrote: > On Fri, 2015-09-11 at 16:06 +0100, Russell King - ARM Linux wrote: > > On Fri, Sep 11, 2015 at 03:33:47PM +0100, Russell King - ARM Linux wrote: > > > It looks like 0c78789e3a030615c6650fde89546cadf40ec2cc might be relevant > > > too,

Re: [PATCH] ebpf: emit correct src_reg for conditional jumps

On 09/11/2015 05:50 PM, Tycho Andersen wrote: On Fri, Sep 11, 2015 at 08:40:43AM -0700, Alexei Starovoitov wrote: On Fri, Sep 11, 2015 at 11:28:24AM +0200, Daniel Borkmann wrote: [off topic for this patch] ... this requirement also breaks down for cases where you have a single classic BPF

Re: v2 of seccomp filter c/r patches

On Fri, Sep 11, 2015 at 9:30 AM, Andy Lutomirski wrote: > On Sep 10, 2015 5:22 PM, "Tycho Andersen" > wrote: >> >> Hi all, >> >> Here is v2 of the seccomp filter c/r set. The patch notes have individual >> changes from the last series, but

Re: [PATCH] x86: Wire up 32-bit direct socket calls

On Fri, Sep 11, 2015 at 3:14 AM, Arnd Bergmann wrote: > On Friday 11 September 2015 11:54:50 Geert Uytterhoeven wrote: >> To make sure I don't miss any (it seems I missed recvmmsg and sendmmsg for >> the socketcall case, sigh), this is the list of ipc syscalls to implement? >> >>

[PATCH net] bridge: fix igmpv3 / mldv2 report parsing

With the newly introduced helper functions the skb pulling is hidden in the checksumming function - and undone before returning to the caller. The IGMPv3 and MLDv2 report parsing functions in the bridge still assumed that the skb is pointing to the beginning of the IGMP/MLD message while it is

[PATCH] Net: core: datagram.c coding style fixes

Fixed several coding style issues reported by checkpatch.pl Signed-off-by: Krzysztof Majzerowicz-Jaszcz --- net/core/datagram.c | 89 ++--- 1 file changed, 51 insertions(+), 38 deletions(-) diff --git a/net/core/datagram.c

Re: [PATCH v2 2/5] seccomp: make underlying bpf ref counted as well

On Fri, Sep 11, 2015 at 06:03:59PM +0200, Daniel Borkmann wrote: > On 09/11/2015 04:44 PM, Tycho Andersen wrote: > >On Fri, Sep 11, 2015 at 03:02:36PM +0200, Daniel Borkmann wrote: > >>On 09/11/2015 02:20 AM, Tycho Andersen wrote: > >>>In the next patch, we're going to add a way to access the

Re: v2 of seccomp filter c/r patches

On Fri, Sep 11, 2015 at 10:00:22AM -0700, Andy Lutomirski wrote: > On Fri, Sep 11, 2015 at 9:30 AM, Andy Lutomirski wrote: > > On Sep 10, 2015 5:22 PM, "Tycho Andersen" > > wrote: > >> > >> Hi all, > >> > >> Here is v2 of the seccomp filter c/r

[PATCH v3 net 0/5] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

v3: - Merge a 'if else if' test in patch 4 - Use rcu_dereference_protected in patch 5 to fix a sparse check when CONFIG_SPARSE_RCU_POINTER is enabled v2: - Add patch 4 and 5 to remove the spinlock v1: This patch series is to fix the dst refcnt bugs in ip6_tunnel. Patch 1 and 2 are the prep

[PATCH v3 net 4/5] ipv6: Avoid double dst_free

It is a prep work to get dst freeing from fib tree undergo a rcu grace period. The following is a common paradigm: if (ip6_del_rt(rt)) dst_free(rt) which means, if rt cannot be deleted from the fib tree, dst_free(rt) now. 1. We don't know the ip6_del_rt(rt) failure is because it was

[PATCH v3 net 1/5] ipv6: Refactor common ip6gre_tunnel_init codes

It is a prep work to fix the dst_entry refcnt bugs in ip6_tunnel. This patch refactors some common init codes used by both ip6gre_tunnel_init and ip6gre_tap_init. Signed-off-by: Martin KaFai Lau --- net/ipv6/ip6_gre.c | 37 - 1 file changed, 24

[PATCH v3 net 5/5] ipv6: Replace spinlock with seqlock and rcu in ip6_tunnel

This patch uses a seqlock to ensure consistency between idst->dst and idst->cookie. It also makes dst freeing from fib tree to undergo a rcu grace period. Signed-off-by: Martin KaFai Lau --- include/net/ip6_tunnel.h | 4 ++-- net/ipv6/ip6_fib.c | 9 +++--

[PATCH v3 net 3/5] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

Problems in the current dst_entry cache in the ip6_tunnel: 1. ip6_tnl_dst_set is racy. There is no lock to protect it: - One major problem is that the dst refcnt gets messed up. F.e. the same dst_cache can be released multiple times and then triggering the infamous dst refcnt < 0

Re: [PATCH v2 2/5] seccomp: make underlying bpf ref counted as well

On 09/11/2015 04:44 PM, Tycho Andersen wrote: On Fri, Sep 11, 2015 at 03:02:36PM +0200, Daniel Borkmann wrote: On 09/11/2015 02:20 AM, Tycho Andersen wrote: In the next patch, we're going to add a way to access the underlying filters via bpf fds. This means that we need to ref-count both the

Re: [PATCH net] openvswitch: Fix mask generation for nested attributes.

On Thu, Sep 10, 2015 at 6:36 PM, Jesse Gross wrote: > Masks were added to OVS flows in a way that was backwards compatible > with userspace programs that did not generate masks. As a result, it is > possible that we may receive flows that do not have a mask and we need > to

Re: [PATCH v2 4/5] seccomp: add a way to access filters via bpf fds

On Sep 10, 2015 5:22 PM, "Tycho Andersen" wrote: > > This patch adds a way for a process that is "real root" to access the > seccomp filters of another process. The process first does a > PTRACE_SECCOMP_GET_FILTER_FD to get an fd with that process' seccomp filter >

[RFC PATCH 0/3] 1588 support for Zynq Ultrascale+ MPSoC

This series adds 1588 support in Cadence MACB driver for Zynq Ultrascale+ MPSoC This IP supports HW timestamping and this is accesible through extended BD. The first patch adds support for extended BD through a config option. Since this required the use two extra u32 variables in the

[PATCH] bnx2x: use ktime_get_seconds() for timestamp

commit c48f350ff5e7 "bnx2x: Add MFW dump support" added the bnx2x_update_mfw_dump() function that reads the current time and stores it in a 32-bit field that gets passed into a buffer in a fixed format. This is potentially broken when the epoch overflows in 2038, and otherwise overflows in 2106.

Re: xfrm4_garbage_collect reaching limit

Hi Dan. On Thu, Sep 10, 2015 at 05:01:26PM -0400, Dan Streetman wrote: > Hi Steffen, > > I've been working with Jay on a ipsec issue, which I believe he > discussed with you. Yes, we talked about this at the LPC. > In this case the xfrm4_garbage_collect is > returning error because the

Re: [PATCH] x86: Wire up 32-bit direct socket calls

On Fri, Sep 11, 2015 at 10:46 AM, Arnd Bergmann wrote: > On Friday 11 September 2015 10:24:29 Heiko Carstens wrote: >> >> FWIW, the s390 approach (ignoring the "new" system calls) is only >> temporarily. >> I'll enable the seperate calls later when I have time to test everything,

Re: [PATCH] x86: Wire up 32-bit direct socket calls

On Mon, Sep 07, 2015 at 02:53:12PM +0200, Arnd Bergmann wrote: > On Wednesday 02 September 2015 13:16:19 H. Peter Anvin wrote: > > On 09/02/2015 02:48 AM, Geert Uytterhoeven wrote: > > > > > > Should all other architectures follow suit? > > > Or should we follow the s390 approach: > > > > > > >

[RFC PATCH 3/3] devicetree: macb: Add optional property tsu-clk

Add TSU clock frequency to be used for 1588 support in macb driver. Signed-off-by: Harini Katakam --- Documentation/devicetree/bindings/net/macb.txt |3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt

[RFC PATCH 1/3] net: macb: Add support for extended BD with a config option

Cadence GEM supports extended buffer descriptors. This patch adds a config option to enable use of extended BD. This adds two extra words to the TX BD and RX BD by configuring the necessary registers. Corresponding variables are added to the macb_dma_desc structure. Signed-off-by: Harini Katakam

[RFC PATCH 2/3] net: macb: Add support for 1588 for Zynq Ultrascale+ MPSoC

Cadence GEM in Zynq Ultrascale+ MPSoC supports 1588 and provides a 102 bit time counter with 48 bits for seconds, 30 bits for nsecs and 24 bits for sub-nsecs. The timestamp is made available to the SW through registers as well as (more precisely) through upper two words in an extended BD. This

RE: PATCH: netdev: add a cast NLMSG_OK to avoid a GCC warning in users' code

From: D. Hugh Redelmeier > Sent: 09 September 2015 21:24 ... > 2) if you use the type "unsigned int" on a 32-bit machine, you get the >warning for an earlier conjunct: > > #define NLMSG_OK(nlh,len) ((len) >= (int)sizeof(struct nlmsghdr) && \ > (nlh)->nlmsg_len >=

Re: [PATCH/RFC v2 net-next 3/4] ravb: Document binding for r8a7795 SoC

Hi Simon, On Fri, Sep 11, 2015 at 10:14 AM, Simon Horman wrote: >> > @@ -18,6 +21,9 @@ Required properties: >> > Optional properties: >> > - interrupt-parent: the phandle for the interrupt controller that services >> > interrupts for this device. >> > +-

Re: [PATCH] x86: Wire up 32-bit direct socket calls

On Friday 11 September 2015 10:24:29 Heiko Carstens wrote: > > FWIW, the s390 approach (ignoring the "new" system calls) is only temporarily. > I'll enable the seperate calls later when I have time to test everything, > especially the glibc stuff. Ok, thanks for clarifying. > The same is true

Re: [PATCH/RFC v2 net-next 3/4] ravb: Document binding for r8a7795 SoC

On Fri, Sep 11, 2015 at 10:41:31AM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Sep 11, 2015 at 10:14 AM, Simon Horman wrote: > >> > @@ -18,6 +21,9 @@ Required properties: > >> > Optional properties: > >> > - interrupt-parent: the phandle for the interrupt

Re: [PATCH] ebpf: emit correct src_reg for conditional jumps

On 09/11/2015 10:45 AM, Daniel Borkmann wrote: On 09/11/2015 02:25 AM, Tycho Andersen wrote: Instead of always emitting BPF_REG_X, let's emit BPF_REG_X only when the source actually is BPF_X. This causes programs generated by the classic converter to not be importable via bpf(), as the eBPF

[PATCH] xfrm6: Fix ICMPv6 and MH header checks in _decode_session6

From: Mathias Krause Ensure there's enough data left prior calling pskb_may_pull(). If skb->data was already advanced, we'll call pskb_may_pull() with a negative value converted to unsigned int -- leading to a huge positive value. That won't matter in practice as

Re: [PATCH] ebpf: emit correct src_reg for conditional jumps

On 09/11/2015 02:25 AM, Tycho Andersen wrote: Instead of always emitting BPF_REG_X, let's emit BPF_REG_X only when the source actually is BPF_X. This causes programs generated by the classic converter to not be importable via bpf(), as the eBPF verifier checks that the src_reg is correct or 0.

[PATCH] at86rf230: fix build warning

e616a00ce786 ("drivers/net/ieee802154/at86rf230.c: seq_printf() now returns NULL") has removed the usage of the integer "ret" but missed removing the variable. And we were getting a build warning about "unused variable". Fixes: e616a00ce786 ("drivers/net/ieee802154/at86rf230.c: seq_printf() now

Re: [PATCH/RFC v2 net-next 3/4] ravb: Document binding for r8a7795 SoC

On Fri, Sep 11, 2015 at 09:12:17AM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Sep 11, 2015 at 4:01 AM, Simon Horman > wrote: > > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt > > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt

Re: [net-next PATCH] net: bridge: fix for bridging 802.1Q without REORDER_HDR

On Fri, 11 Sep 2015 21:22:03 +0200 Phil Sutter wrote: > When forwarding packets from an 802.1Q interface with REORDER_HDR set to > zero, the VLAN header previously inserted by vlan_do_receive() needs to > be stripped from the packet and the mac_header adjustment undone, > otherwise

[PATCH] Net: core: stream.c: coding style fixes

Fixed coding style issues reported by checkpatch.pl Signed-off-by: Krzysztof Majzerowicz-Jaszcz --- net/core/stream.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/net/core/stream.c b/net/core/stream.c index

[PATCH] net-sysfs: get_netdev_queue_index() cleanup

Redo commit ed1acc8cd8c22efa919da8d300bab646e01c2dce. Commit 822b3b2ebfff8e9b3d006086c527738a7ca00cd0 ("net: Add max rate tx queue attribute") moved get_netdev_queue_index around, but kept the old version. Probably because of a reuse of the original patch from before Eric's change to that

Re: [PATCH net] netlink, mmap: transform mmap skb into full skb on taps

On 09/11/2015 09:42 PM, David Miller wrote: From: Daniel Borkmann Date: Fri, 11 Sep 2015 12:25:45 +0200 Already calling into skb_clone() is an issue itself, as the data area is user space buffer, and skb_clone() as well as skb_copy() access skb_shinfo() area. :/ So in

[PATCH v3 net-next] rtnetlink: RTEXT_FILTER_SKIP_STATS support to avoid dumping inet/inet6 stats

Many commonly used functions like getifaddrs() invoke RTM_GETLINK to dump the interface information, and do not need the the AF_INET6 statististics that are always returned by default from rtnl_fill_ifinfo(). Computing the statistics can be an expensive operation that impacts scaling, so it is

Re: [PATCHv2 RFC] RTEXT_FILTER_SKIP_STATS support to avoid dumping inet/inet6 stats

On (09/12/15 00:22), Raghavendra K T wrote: > > Sowmini, Thanks for the patch which is more cleaner way without > breaking current behaviour. > > [ Though RTEXT_FILTER_NEED_STATS flag with reverse effect would have > helped immediately :)] Agree, but existing legacy usage will not set this

Re: [PATCH net] netlink, mmap: transform mmap skb into full skb on taps

From: Daniel Borkmann Date: Fri, 11 Sep 2015 12:25:45 +0200 > Already calling into skb_clone() is an issue itself, as the data > area is user space buffer, and skb_clone() as well as skb_copy() > access skb_shinfo() area. :/ So in that regard netlink mmap skbs are > even

Re: [net-next PATCH] net: bridge: fix for bridging 802.1Q without REORDER_HDR

On Fri, Sep 11, 2015 at 12:24:45PM -0700, Stephen Hemminger wrote: > On Fri, 11 Sep 2015 21:22:03 +0200 > Phil Sutter wrote: > > > When forwarding packets from an 802.1Q interface with REORDER_HDR set to > > zero, the VLAN header previously inserted by vlan_do_receive() needs to > >

[net-next PATCH] net: bridge: fix for bridging 802.1Q without REORDER_HDR

When forwarding packets from an 802.1Q interface with REORDER_HDR set to zero, the VLAN header previously inserted by vlan_do_receive() needs to be stripped from the packet and the mac_header adjustment undone, otherwise a tagged frame with first four bytes missing will be transmitted.

Re: [RFC PATCH 3/3] devicetree: macb: Add optional property tsu-clk

Hi Harini, On Fri, 2015-09-11 at 01:27PM +0530, Harini Katakam wrote: > Add TSU clock frequency to be used for 1588 support in macb driver. > > Signed-off-by: Harini Katakam > --- > Documentation/devicetree/bindings/net/macb.txt |3 +++ > 1 file changed, 3 insertions(+)

[PATCH v2] net: stmmac: Use msleep rather then udelay for reset delay

The reset delays used for stmmac are in the order of 10ms to 1 second, which is far too long for udelay usage, so switch to using msleep. Practically this fixes the PHY not being reliably detected in some cases as udelay wouldn't actually delay for long enough to let the phy reliably be reset.

Re: [PATCHv2 RFC] RTEXT_FILTER_SKIP_STATS support to avoid dumping inet/inet6 stats

On 09/11/2015 03:04 AM, Sowmini Varadhan wrote: Many commonly used functions like getifaddrs() invoke RTM_GETLINK to dump the interface information, and do not need the the AF_INET6 statististics that are always returned by default from rtnl_fill_ifinfo(). Computing the statistics can be an

Re: [PATCH] net-sysfs: get_netdev_queue_index() cleanup

On 15-09-11 01:08 PM, Thadeu Lima de Souza Cascardo wrote: > Redo commit ed1acc8cd8c22efa919da8d300bab646e01c2dce. > > Commit 822b3b2ebfff8e9b3d006086c527738a7ca00cd0 ("net: Add max rate tx queue > attribute") moved get_netdev_queue_index around, but kept the old version. > Probably because of a

Re: [PATCH] Net: core: stream.c: coding style fixes

On Fri, 11 Sep 2015 22:13:00 +0200 Krzysztof Majzerowicz-Jaszcz wrote: > * So we (will) share it here. > * > - * Authors:Arnaldo Carvalho de Melo > - * (from old tcp.c code) > - * Alan Cox

Re: [fw filter]: Broken! fw mark based tc class selection not working

On Fri, Sep 11, 2015 at 9:34 AM, Akshat Kakkar wrote: > Recently I came to know that, > Without any options fw classifier maps fwmark to classid. > > tc filter add dev parent protocol ip prio 1 fw > > i.e. if my packet has mark(0x10001) and class id is not set, > then

Re: [PATCH net] netlink, mmap: transform mmap skb into full skb on taps

From: Daniel Borkmann Date: Fri, 11 Sep 2015 22:35:08 +0200 > On 09/11/2015 09:42 PM, David Miller wrote: >> @@ -2220,7 +2221,8 @@ static inline void skb_orphan(struct sk_buff >> *skb) >>*/ >> static inline int skb_orphan_frags(struct sk_buff *skb, gfp_t >>

[PATCH] irda: ali-ircc: Fix deadlock in ali_ircc_sir_change_speed()

ali_ircc_sir_change_speed() is always called with self->lock held, so acquiring the lock inside it leads to unavoidable deadlock. Call graph: ali_ircc_sir_change_speed() is called from ali_ircc_change_speed() ali_ircc_fir_hard_xmit() under spin_lock_irqsave(>lock, flags);

Re: [PATCH net] bridge: fix igmpv3 / mldv2 report parsing

From: Linus Lüssing Date: Fri, 11 Sep 2015 18:39:48 +0200 > With the newly introduced helper functions the skb pulling is hidden in > the checksumming function - and undone before returning to the caller. > > The IGMPv3 and MLDv2 report parsing functions in the bridge

Re: [PATCH net] openvswitch: Fix dependency on IPv6 defrag.

On Fri, Sep 11, 2015 at 3:01 PM, Joe Stringer wrote: > When NF_CONNTRACK is built-in, NF_DEFRAG_IPV6 is a module, and > OPENVSWITCH is built-in, the following build error would occur: > > net/built-in.o: In function `ovs_ct_execute': > (.text+0x10f587): undefined reference

Re: [fw filter]: Broken! fw mark based tc class selection not working

There is no handle with fw filter. That's the whole point is. If handle and class (flow id) is not specified, then whatever be the mark on the packet, its automatically set as flowid. So if mark is 0x10003, then this fw filter tc filter add dev eth0 parent 1:0 protocol ip fw will cause 0x10003

Re: [PATCH] ebpf: emit correct src_reg for conditional jumps

From: Tycho Andersen Date: Thu, 10 Sep 2015 18:25:07 -0600 > Instead of always emitting BPF_REG_X, let's emit BPF_REG_X only when the > source actually is BPF_X. This causes programs generated by the classic > converter to not be importable via bpf(), as the eBPF

Re: [PATCH net v2] sctp: fix race on protocol/netns initialization

From: Marcelo Ricardo Leitner Date: Thu, 10 Sep 2015 17:31:15 -0300 > Consider sctp module is unloaded and is being requested because an user > is creating a sctp socket. > > During initialization, sctp will add the new protocol type and then > initialize pernet

Re: [PATCH v3 net 1/5] ipv6: Refactor common ip6gre_tunnel_init codes

From: Martin KaFai Lau Date: Fri, 11 Sep 2015 11:06:17 -0700 > @@ -1460,19 +1474,16 @@ static void ip6gre_netlink_parms(struct nlattr > *data[], > static int ip6gre_tap_init(struct net_device *dev) > { > struct ip6_tnl *tunnel; > + int ret; > > - tunnel =

Re: [PATCH v3 net 1/5] ipv6: Refactor common ip6gre_tunnel_init codes

On Fri, Sep 11, 2015 at 03:30:59PM -0700, David Miller wrote: > From: Martin KaFai Lau > Date: Fri, 11 Sep 2015 11:06:17 -0700 > > > @@ -1460,19 +1474,16 @@ static void ip6gre_netlink_parms(struct nlattr > > *data[], > > static int ip6gre_tap_init(struct net_device *dev) > > { >

Re: randconfig build error with next-20150911, in net/openvswitch

On 11 September 2015 at 09:53, Jim Davis wrote: > Building with the attached random configuration file, > > net/built-in.o: In function `ovs_ct_execute': > (.text+0x10f587): undefined reference to `nf_ct_frag6_gather' Thanks for the report, I sent a patch:

Re: [PATCH V5 net-next 1/2] net: introduce socket family constants

From: Ursula Braun Date: Fri, 11 Sep 2015 14:09:09 +0200 > @@ -0,0 +1,13 @@ > +/* > + * SMC Definitions for the SMC protocol. > + * > + * Author: Ursula Braun > + */ > +#ifndef _SMC_H > +#define _SMC_H > + > +/* SMC socket

[PATCH net] openvswitch: Fix dependency on IPv6 defrag.

When NF_CONNTRACK is built-in, NF_DEFRAG_IPV6 is a module, and OPENVSWITCH is built-in, the following build error would occur: net/built-in.o: In function `ovs_ct_execute': (.text+0x10f587): undefined reference to `nf_ct_frag6_gather' Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action")

Re: [PATCH] bnx2x: use ktime_get_seconds() for timestamp

From: Arnd Bergmann Date: Fri, 11 Sep 2015 11:33:01 +0200 > commit c48f350ff5e7 "bnx2x: Add MFW dump support" added the > bnx2x_update_mfw_dump() function that reads the current time and stores > it in a 32-bit field that gets passed into a buffer in a fixed format. > > This is

Re: [PATCH net] netlink, mmap: transform mmap skb into full skb on taps

On 09/11/2015 11:34 PM, David Miller wrote: ... Another approach would be to put the mmap user data into a page frag, but that obviously has some costs associated with it. However, nothing in netlink is ready for fragged skbs yet. It's the reason why we have the large skb via vmalloc facility.

Re: [PATCH net] openvswitch: Fix dependency on IPv6 defrag.

From: Joe Stringer Date: Fri, 11 Sep 2015 15:01:16 -0700 > When NF_CONNTRACK is built-in, NF_DEFRAG_IPV6 is a module, and > OPENVSWITCH is built-in, the following build error would occur: > > net/built-in.o: In function `ovs_ct_execute': > (.text+0x10f587): undefined

Re: [PATCH] irda: ali-ircc: Fix deadlock in ali_ircc_sir_change_speed()

From: Alexey Khoroshilov Date: Sat, 12 Sep 2015 00:34:48 +0300 > ali_ircc_sir_change_speed() is always called with self->lock held, > so acquiring the lock inside it leads to unavoidable deadlock. > > Call graph: > ali_ircc_sir_change_speed() is called from

Re: [PATCH v3 net 1/5] ipv6: Refactor common ip6gre_tunnel_init codes

From: Martin KaFai Lau Date: Fri, 11 Sep 2015 16:20:26 -0700 > or I am missing something and have overlooked a bug? My bad, I simply misread your patch. Sorry about that. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH v2 4/5] seccomp: add a way to access filters via bpf fds

On 09/11/2015 02:21 AM, Tycho Andersen wrote: This patch adds a way for a process that is "real root" to access the seccomp filters of another process. The process first does a PTRACE_SECCOMP_GET_FILTER_FD to get an fd with that process' seccomp filter attached, and then iterates on this with

Re: [PATCH/RFC v2 net-next 1/4] phylib: Add phy_set_max_speed helper

Hello. On 9/11/2015 5:01 AM, Simon Horman wrote: Add a helper to allow ethernet drivers to limit the speed of a phy (that they are attached to). This mainly involves factoring out the business-end of of_set_phy_supported() and exporting a new symbol. This code seems to be open coded in

Re: [PATCH v2 3/5] ebpf: add a way to dump an eBPF program

On 09/11/2015 02:21 AM, Tycho Andersen wrote: This commit adds a way to dump eBPF programs. The initial implementation doesn't support maps, and therefore only allows dumping seccomp ebpf programs which themselves don't currently support maps. v2: don't export a prog_id for the filter

Re: v2 of seccomp filter c/r patches

On Sep 10, 2015 5:22 PM, "Tycho Andersen" wrote: > > Hi all, > > Here is v2 of the seccomp filter c/r set. The patch notes have individual > changes from the last series, but there are two points not noted: > > * The series still does not allow us to correctly

Re: [PATCH v2 4/5] seccomp: add a way to access filters via bpf fds

On Fri, Sep 11, 2015 at 09:20:55AM -0700, Andy Lutomirski wrote: > On Sep 10, 2015 5:22 PM, "Tycho Andersen" > wrote: > > > > This patch adds a way for a process that is "real root" to access the > > seccomp filters of another process. The process first does a > >

Re: [PATCH v2 2/5] seccomp: make underlying bpf ref counted as well

On 09/11/2015 07:33 PM, Tycho Andersen wrote: On Fri, Sep 11, 2015 at 06:03:59PM +0200, Daniel Borkmann wrote: On 09/11/2015 04:44 PM, Tycho Andersen wrote: On Fri, Sep 11, 2015 at 03:02:36PM +0200, Daniel Borkmann wrote: On 09/11/2015 02:20 AM, Tycho Andersen wrote: In the next patch, we're

Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

Dne 11.9.2015 v 08:18 Robert Jarzmik napsal(a): > Petr Cvek writes: > >>> Should have been posted to linux arm kernel mailing list, unless my mailer >>> failed ... >>> >> Searching for: >> >> "ARM: pxa: add resources to pxaficp_ir" >> >> did not found anything, same was

Re: [PATCH net] netlink, mmap: transform mmap skb into full skb on taps

On 09/11/2015 07:11 AM, David Miller wrote: ... Looking more deeply into this, I think we have the same exact problem with netlink skbs that use vmalloc memory at skb->head. Yes, agreed, the test in the patch covered those as well via: if (netlink_skb_is_mmaped(skb) ||

[PATCH V5 net-next 0/2] net: implement SMC-R solution

From: Ursula Braun Dave, this is V5 of my SMC-R patches taking care about your V4 comments: getting rid of tcp_set_keepalive() and enforcing inverse christmas tree ordering for local variables. Since you are asking for a solution "100% in our own separate module with

Re: [PATCH v2 4/5] seccomp: add a way to access filters via bpf fds

HI Tycho On 11 September 2015 at 02:21, Tycho Andersen wrote: > This patch adds a way for a process that is "real root" to access the > seccomp filters of another process. The process first does a > PTRACE_SECCOMP_GET_FILTER_FD to get an fd with that process'

RE: [PATCH] bnx2x: use ktime_get_seconds() for timestamp

> I assume that it is not possible to change the ABI any more, otherwise > we should try to use a 64-bit field. Actually, I did suggest exactly that to our management team, But this was the decided ABI. Acked-by: Yuval Mintz -- To unsubscribe from this list: send the

Re: [PATCH net-next] Revert "net/ipv6: add sysctl option accept_ra_min_hop_limit"

YOSHIFUJI Hideaki wrote: > Sabrina Dubroca wrote: > > 2015-09-10, 14:52:45 +0900, YOSHIFUJI Hideaki wrote: > >> Sabrina Dubroca wrote: > >>> Would you agree with a default of 64, as Florian suggested? > >> > >> 1 was chosen to restore our behavior before

NFS/TCP/IPv6 acting strangely in 4.2

I have a recent Marvell Armada 388 board here which uses the mvneta driver. I'm seeing some weird effects with NFS with it acting as a client. Unfortunately, the board does not have a functional RTC. The NFS server is the same NFS server that I've used for years with multiple other clients

Re: [PATCH v2 1/5] ebpf: add a seccomp program type

On 11 September 2015 at 02:20, Tycho Andersen wrote: > seccomp uses eBPF as its underlying storage and execution format, and eBPF > has features that seccomp would like to make use of in the future. This > patch adds a formal seccomp type to the eBPF verifier. > >

[PATCH V5 net-next 1/2] net: introduce socket family constants

From: Ursula Braun The new socket family is assigned the next available address / protocol family constant 41. Signed-off-by: Ursula Braun --- include/linux/socket.h | 4 +++- include/net/smc.h | 13 + 2 files changed, 16

Re: [PATCH v2 5/5] seccomp: add a way to attach a filter via eBPF fd

On 11 September 2015 at 02:21, Tycho Andersen wrote: > This is the final bit needed to support seccomp filters created via the bpf > syscall. The patch adds a new seccomp operation SECCOMP_MODE_FILTER_EBPF, > which takes exactly one command (presumably to be expanded

Re: [PATCH] x86: Wire up 32-bit direct socket calls

On Friday 11 September 2015 11:54:50 Geert Uytterhoeven wrote: > To make sure I don't miss any (it seems I missed recvmmsg and sendmmsg for > the socketcall case, sigh), this is the list of ipc syscalls to implement? > > sys_msgget > sys_msgctl > sys_msgrcv > sys_msgsnd >

Re: [PATCH net-next] Revert "net/ipv6: add sysctl option accept_ra_min_hop_limit"

On 11/09/15 12:53, Florian Westphal wrote: > YOSHIFUJI Hideaki wrote: >> Sabrina Dubroca wrote: >>> 2015-09-10, 14:52:45 +0900, YOSHIFUJI Hideaki wrote: Sabrina Dubroca wrote: > Would you agree with a default of 64, as Florian suggested? 1

Re: [v2 04/11] soc/fsl: Introduce drivers for the DPAA QMan

On Wed, Aug 12, 2015 at 04:14:50PM -0400, Roy Pledge wrote: > +/* Lock/unlock frame queues, subject to the "LOCKED" flag. This is about > + * inter-processor locking only. Note, FQLOCK() is always called either > under a > + * local_irq_save() or from interrupt context - hence there's no need for

Re: [PATCH net] openvswitch: Fix mask generation for nested attributes.

On Fri, Sep 11, 2015 at 9:04 AM, Pravin Shelar wrote: > On Thu, Sep 10, 2015 at 6:36 PM, Jesse Gross wrote: >> Masks were added to OVS flows in a way that was backwards compatible >> with userspace programs that did not generate masks. As a result, it is >>

[PATCH net v2] openvswitch: Fix mask generation for nested attributes.

Masks were added to OVS flows in a way that was backwards compatible with userspace programs that did not generate masks. As a result, it is possible that we may receive flows that do not have a mask and we need to synthesize one. Generating a mask requires iterating over attributes and

Re: [fw filter]: Broken! fw mark based tc class selection not working

On Fri, Sep 11, 2015 at 3:24 PM, Akshat Kakkar wrote: > There is no handle with fw filter. That's the whole point is. If > handle and class (flow id) is not specified, then whatever be the mark > on the packet, its automatically set as flowid. So if mark is 0x10003, > then

[PATCH] ip link: missing options in bond usage

Signed-off-by: Arthur Gautier --- ip/iplink_bond.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iplink_bond.c b/ip/iplink_bond.c index 9d96cfeee88b..cb2f045a5a27 100644 --- a/ip/iplink_bond.c +++ b/ip/iplink_bond.c @@ -145,7 +145,7 @@ static void

Re: [PATCH v2 5/5] seccomp: add a way to attach a filter via eBPF fd

On 09/11/2015 02:21 AM, Tycho Andersen wrote: This is the final bit needed to support seccomp filters created via the bpf syscall. The patch adds a new seccomp operation SECCOMP_MODE_FILTER_EBPF, which takes exactly one command (presumably to be expanded upon later when seccomp EBPFs support

Re: NFS/TCP/IPv6 acting strangely in 4.2

On Fri, 2015-09-11 at 12:38 +0100, Russell King - ARM Linux wrote: > I have a recent Marvell Armada 388 board here which uses the mvneta > driver. I'm seeing some weird effects with NFS with it acting as a > client. Unfortunately, the board does not have a functional RTC. > > The NFS server is

Re: [PATCH v2 2/5] seccomp: make underlying bpf ref counted as well

On 09/11/2015 02:20 AM, Tycho Andersen wrote: In the next patch, we're going to add a way to access the underlying filters via bpf fds. This means that we need to ref-count both the struct seccomp_filter objects and the struct bpf_prog objects separately, in case a process dies but a filter is

Re: NFS/TCP/IPv6 acting strangely in 4.2

On Fri, Sep 11, 2015 at 06:04:51AM -0700, Eric Dumazet wrote: > On Fri, 2015-09-11 at 12:38 +0100, Russell King - ARM Linux wrote: > > I have a recent Marvell Armada 388 board here which uses the mvneta > > driver. I'm seeing some weird effects with NFS with it acting as a > > client.

  1   2   >