Re: [PATCH iproute2 -next] examples, bpf: further improve examples

On Wed, 2 Dec 2015 00:25:36 +0100 Daniel Borkmann wrote: > Improve example files further and add a more generic set of possible > helpers for them that can be used. > > Signed-off-by: Daniel Borkmann Sure, applied to net-next -- To unsubscribe from

Re: [PATCH iproute] ila: Add support for ILA lwtunnels

On Mon, 30 Nov 2015 14:57:28 -0800 Tom Herbert wrote: > This patch: > - Adds a utility function for parsing a 64 bit address > - Adds a utility function for converting a 64 bit address to ASCII > - Adds and ILA encap type in lwt tunnels > > Signed-off-by: Tom Herbert

Re: [PATCH net v2] net: Flush local routes when device changes vrf association

On 12/10/2015 07:25 PM, David Ahern wrote: > The VRF driver cycles netdevs when an interface is enslaved or released: > the down event is used to flush neighbor and route tables and the up > event (if the interface was already up) effectively moves local and > connected routes to the proper table.

[PATCH net] uapi: export ila.h

The file ila.h used for lightweight tunnels is being used by iproute2 but is not exported yet. Signed-off-by: Stephen Hemminger --- include/uapi/linux/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild

[PATCH net 1/4] mpls: validate L2 via address length

If an L2 via address for an mpls nexthop is specified, the length of the L2 address must match that expected by the output device, otherwise it could access memory beyond the end of the via address buffer in the route. This check was present prior to commit f8efb73c97e2 ("mpls: multipath route

[PATCH net 0/4] mpls: fixes for nexthops without via addresses

These four fixes all apply to the case of having an mpls route with an output device, but without a nexthop. Patches 2 and 3 could really have been combined in one patch, but I wanted to separate the fix for some recent breakage from the fix for a day-1 issue. Robert Shearman (4): mpls:

Re: [PATCH net-next v4 8/8] openvswitch: Interface with NAT.

On Tue, Dec 08, 2015 at 05:01:10PM -0800, Jarno Rajahalme wrote: > - /* Call the helper right after nf_conntrack_in() for confirmed > - * connections, but only when commiting for unconfirmed connections. > - */ > ct = nf_ct_get(skb, ); > - if (ct && (nf_ct_is_confirmed(ct)

[PATCH net 2/4] mpls: don't dump RTA_VIA attribute if not specified

The problem seen is that when adding a route with a nexthop with no via address specified, iproute2 generates bogus output: # ip -f mpls route add 100 dev lo # ip -f mpls route list 100 via inet 0.0.8.0 dev lo The reason for this is that the kernel generates an RTA_VIA attribute with the

[PATCH net-next] hv_netvsc: Fix race condition on Multi-Send Data field

In commit 2a04ae8acb14 ("hv_netvsc: remove locking in netvsc_send()"), the locking for MSD (Multi-Send Data) field was removed. This could cause a race condition between RNDIS control messages and data packets processing, because these two types of traffic are not synchronized. This patch fixes

[PATCH net 4/4] mpls: make via address optional for multipath routes

The via address is optional for a single path route, yet is mandatory when the multipath attribute is used: # ip -f mpls route add 100 dev lo # ip -f mpls route add 101 nexthop dev lo RTNETLINK answers: Invalid argument Make them consistent by making the via address optional when the

[PATCH net 3/4] mpls: fix out-of-bounds access when via address not specified

When a via address isn't specified, the via table is left initialised to 0 (NEIGH_ARP_TABLE), and the via address length also left initialised to 0. This results in a via address array of length 0 being allocated (contiguous with route and nexthop array), meaning that when a packet is sent using

Re: [PATCH net-next v4 2/8] netfilter: Factor out nf_ct_get_info().

On Tue, Dec 08, 2015 at 05:01:04PM -0800, Jarno Rajahalme wrote: > Define a new inline function to map conntrack status to enum > ip_conntrack_info. This removes the need to otherwise duplicate this > code in a later patch ("openvswitch: Find existing conntrack entry > after upcall."). > >

Re: [PATCH 1/4] list: introduce list_is_first()

On Thu, 10 Dec 2015, Jens Axboe wrote: > It's a balance, as we also should not make APIs out of everything. As I said, > purely my opinion, but I think the is_last/is_first have jumped the shark. I don't have a strong opinion either way. What I think we should do though, is to either have both

Re: [iproute PATCH] tc.8: Fix reference to tc-tcindex.8

On Thu, 10 Dec 2015 13:24:51 +0100 Phil Sutter wrote: > Just a typo there, it's spelled correctly in SEE ALSO section.. > > Signed-off-by: Phil Sutter Applied -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH net] net: Flush local routes when device changes vrf association

On 12/9/15 6:35 PM, David Ahern wrote: The VRF driver cycles netdevs when an interface is enslaved or released: the down event is used to flush neighbor and route tables and the up event (if the interface was already up) effectively moves local and connected routes to the proper table. As of

Re: [PATCH iproute2] vrf: Add support for table names

On Tue, 8 Dec 2015 12:24:44 -0800 David Ahern wrote: > Currently, the table id for VRF devices requires an integer. Convert > it to use rtnl_rttable_a2n which handles table names from the iproute2 > directory. > > This also fixes a bug in the original commit where

RE: [PATCH v2 0/2] net: thunderx: Support for pass-2 hw features

All series: Reviewed-by: Pavel Fedin Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Sunil Goutham Sent: Thursday,

Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set

On Dec 9 23:43, Francois Romieu wrote: > Corinna Vinschen : > [...] > > This patch is supposed to fix this behaviour. If LanWake is 0, the > > function now returns 0. Thus ethtool correctly reports "Wake-on: d". > > Can you turn it into a DMI controlled one (something

[PATCH v2 2/2] net: thunderx: Enable CQE count threshold interrupt

From: Sunil Goutham This feature is introduced in pass-2 chip and with this CQ interrupt coalescing will work based on both timer and count. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/nicvf_queues.c |2 +-

[PATCH net-next v3 1/3] rco: Clean up casting errors

Fixe a couple of cast errors found by sparse. Signed-off-by: Tom Herbert --- include/net/checksum.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/net/checksum.h b/include/net/checksum.h index 9fcaedf..10a16b5 100644 ---

Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

On Thu, Dec 10, 2015 at 11:23 PM, Joe Stringer wrote: > On 10 December 2015 at 13:06, Or Gerlitz wrote: >> On Wed, Dec 9, 2015 at 2:22 AM, Joe Stringer wrote: > As far as the mask, I briefly discussed this with Jarno and it seems > like

Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set

On Dec 10 21:40, Francois Romieu wrote: > Corinna Vinschen : > [...] > > I could do this (after I could lay my hands on such a board, that is), > > but I'm not convinced that this makes a lot of sense for two reasons. > > Ok, let's get this change applied. Whatever happens

[PATCH net-next v3 3/3] geneve: Remote Checksum Offload support

Add support for remote checksum offload in both the normal and GRO paths. netlinks command are used to enable sending of the Remote Checksum Data, and allow processing of it on receive. Signed-off-by: Tom Herbert --- drivers/net/geneve.c | 162

[PATCH net-next v3 0/3] geneve: Add support for Remote Checksum Offload

This patch set adds UDP checksum configuration via netlink and Remote Checksum Offload for Geneve, v2: - Fix type in commi log v3: - Fix issue of taking sizeof a pointer instead of the actual object (for real) Testing (10Gbps mlx4): Single connection TCP_STREAM in netperf - No UDP

[PATCH net-next v3 2/3] geneve: UDP checksum configuration via netlink

Add support to enable and disable UDP checksums via netlink. This is similar to how VXLAN and GUE allow this. This includes support for enabling the UDP zero checksum (for both TX and RX). Signed-off-by: Tom Herbert --- drivers/net/geneve.c | 93

Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set

Corinna Vinschen : [...] > I could do this (after I could lay my hands on such a board, that is), > but I'm not convinced that this makes a lot of sense for two reasons. Ok, let's get this change applied. Whatever happens should not be hard to manage (I'm thinking about

Re: Checksum offload queries

Edward Cree wrote: > I have just realised something startling. Assuming the inner protocol uses > the ones complement checksum in the way IP, UDP and TCP do, the outer > checksum can be computed *without looking at the payload*. Why? Because the > ones complement sum

Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

On Wed, Dec 9, 2015 at 2:22 AM, Joe Stringer wrote: > On 8 December 2015 at 13:23, Or Gerlitz wrote: >> On Tue, Dec 8, 2015 at 9:20 PM, Joe Stringer wrote: Apologies for the delayed response, we haven't found anything interesting yet

Re: [RFC PATCHv2 net-next 1/2] tcp: RTO Restart (RTOR)

> 10 dec. 2015 kl. 16:37 skrev Neal Cardwell : > >> On Thu, Dec 10, 2015 at 1:51 AM, Per Hurtig wrote: >> >>> On 08 Dec 2015, at 14:47, Eric Dumazet wrote: >>> >>> On Tue, 2015-12-08 at 10:19 +0100, Per Hurtig wrote: >>>

Re: Checksum offload queries

On 10/12/15 16:26, Tom Herbert wrote: > It sounds like potentially interesting work. You'll probably want my patches > that provider helper functions that allow a driver to verify that it can > offload a checksum. We'll have to update those also to allow two checksums. I have just realised

Re: [PATCH net-next v3 3/3] geneve: Remote Checksum Offload support

On Thu, Dec 10, 2015 at 12:37 PM, Tom Herbert wrote: > Add support for remote checksum offload in both the normal and GRO > paths. netlinks command are used to enable sending of the Remote > Checksum Data, and allow processing of it on receive. > > Signed-off-by: Tom Herbert

Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

On 10 December 2015 at 13:06, Or Gerlitz wrote: > On Wed, Dec 9, 2015 at 2:22 AM, Joe Stringer wrote: >> On 8 December 2015 at 13:23, Or Gerlitz wrote: >>> On Tue, Dec 8, 2015 at 9:20 PM, Joe Stringer wrote: > >

Re: [PATCH v3 2/4] VSOCK: Introduce virtio-vsock.ko

Stefan Hajnoczi writes: > From: Asias He > > VM sockets virtio transport implementation. This module runs in guest > kernel. checkpatch warns on a bunch of whitespace/tab issues. > > Signed-off-by: Asias He > Signed-off-by: Stefan

[PATCH net-next] bpf, inode: allow for rename and link ops

Add support for renaming and hard links to the fs. Most of this can be implemented by using simple library operations under the same constraints that we don't use a reserved name like elsewhere. Linking can be useful to share/manage things like maps across subsystem users. It works within the file

[PATCH net-next v2 2/3] geneve: UDP checksum configuration via netlink

Add support to enable and disable UDP checksums via netlink. This is similar to how VXLAN and GUE allow this. This includes support for enabling the UDP zero checksum (for both TX and RX). Signed-off-by: Tom Herbert --- drivers/net/geneve.c | 93

[PATCH net-next v2 0/3] geneve: Add support for Remote Checksum Offload

This patch set adds UDP checksum configuration via netlink and Remote Checksum Offload for Geneve, v2: - Fix issue of taking sizeof a pointer instead of the actual object - Fix type in commi log Testing (10Gbps mlx4): Single connection TCP_STREAM in netperf - No UDP checksums, no RCO

[PATCH net-next v2 3/3] geneve: Remote Checksum Offload support

Add support for remote checksum offload in both the normal and GRO paths. netlinks command are used to enable sending of the Remote Checksum Data, and allow processing of it on receive. Signed-off-by: Tom Herbert --- drivers/net/geneve.c | 162

[PATCH net-next v2 1/3] rco: Clean up casting errors

Fixe a couple of cast errors found by sparse. Signed-off-by: Tom Herbert --- include/net/checksum.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/net/checksum.h b/include/net/checksum.h index 9fcaedf..10a16b5 100644 ---

Re: [PATCH net-next v4 2/8] netfilter: Factor out nf_ct_get_info().

> On Dec 10, 2015, at 11:14 AM, Pablo Neira Ayuso wrote: > > On Tue, Dec 08, 2015 at 05:01:04PM -0800, Jarno Rajahalme wrote: >> Define a new inline function to map conntrack status to enum >> ip_conntrack_info. This removes the need to otherwise duplicate this >> code in

RE: [Intel-wired-lan] [next PATCH 03/11] ixgbe: Simplify definitions for regidx and bit in set_vfta

> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 03/11] ixgbe:

RE: [Intel-wired-lan] [next PATCH 08/11] ixgbe: Add support for VLAN promiscuous with SR-IOV

> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 08/11] ixgbe:

RE: [Intel-wired-lan] [next PATCH 07/11] ixgbe: Reorder search to work from the top down instead of bottom up

> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 07/11] ixgbe:

Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

On 10 December 2015 at 13:43, Or Gerlitz wrote: > On Thu, Dec 10, 2015 at 11:23 PM, Joe Stringer wrote: >> On 10 December 2015 at 13:06, Or Gerlitz wrote: >>> On Wed, Dec 9, 2015 at 2:22 AM, Joe Stringer wrote: > >> As

[PATCH net-next v4 2/4] rhashtable: add function to replace an element

Add the rhashtable_replace_fast function. This replaces one object in the table with another atomically. The hashes of the new and old objects must be equal. Signed-off-by: Tom Herbert --- include/linux/rhashtable.h | 82 ++ 1

[PATCH net-next v4 4/4] ila: Add generic ILA translation facility

This patch implements an ILA tanslation table. This table can be configured with identifier to locator mappings, and can be be queried to resolve a mapping. Queries can be parameterized based on interface, direction (incoming or outoing), and matching locator. The table is implemented using

[PATCH net-next v4 1/4] ila: Create net/ipv6/ila directory

Create ila directory in preparation for supporting other hooks in the kernel than LWT for doing ILA. This includes: - Moving ila.c to ila/ila_lwt.c - Splitting out some common functions into ila_common.c Signed-off-by: Tom Herbert --- net/ipv6/Makefile | 2 +-

[PATCH net-next v4 3/4] netlink: add a start callback for starting a netlink dump

The start callback allows the caller to set up a context for the dump callbacks. Presumably, the context can then be destroyed in the done callback. Signed-off-by: Tom Herbert --- include/linux/netlink.h | 2 ++ include/net/genetlink.h | 2 ++ net/netlink/af_netlink.c

RE: [Intel-wired-lan] [next PATCH 01/11] ixgbe: Return error on failure to allocate mac_table

> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:09 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 01/11] ixgbe:

RE: [Intel-wired-lan] [next PATCH 11/11] ixgbe: Clean stale VLANs when changing port vlan or resetting

> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:11 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 11/11] ixgbe:

Suspicious RCU from iwlwifi driver

Hi, I'm currently seeing a suspicous RCU usage warning: === [ INFO: suspicious RCU usage. ] 4.4.0-rc4-next-20151210 #23 Not tainted --- drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1226 suspicious rcu_dereference_protected() usage

Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set

Corinna Vinschen : [...] > It's still a bit weird. On the machines I tested this on, if I disable > LanWake and shutdown the machine, I can send, e.g., MagicPackets as much > as I like, the machined don't come up. Isn't it a bit misleading then > if ethtool reports that

Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Hello. On 10/12/15 19:16, Marcel Holtmann wrote: Hi Stefan, From: Markus Elfring Date: Mon, 16 Nov 2015 13:50:23 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This

RE: [Intel-wired-lan] [next PATCH 04/11] ixgbe: Reduce VT code indent in set_vfta by introducing jump label

> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 04/11] ixgbe:

RE: [Intel-wired-lan] [next PATCH 09/11] ixgbe: Fix VLAN promisc in relation to SR-IOV

> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 09/11] ixgbe:

RE: [Intel-wired-lan] [next PATCH 05/11] ixgbe: Simplify configuration of setting VLVF and VLVFB

> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 05/11] ixgbe:

RE: [Intel-wired-lan] [next PATCH 06/11] ixgbe: Add support for adding/removing VLAN on PF bypassing the VLVF

> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 06/11] ixgbe:

RE: [Intel-wired-lan] [next PATCH 02/11] ixgbe: Fix SR-IOV VLAN pool configuration

> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 02/11] ixgbe:

RE: [Intel-wired-lan] [next PATCH 10/11] ixgbe: Clear stale pool mappings

> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 10/11] ixgbe:

[PATCH net-next v4 0/4] ila: Optimization to preserve value of early demux

In the current implementation of ILA, LWT is used to perform translation on both the input and output paths. This is functional, however there is a big performance hit in the receive path. Early demux occurs before the routing lookup (a hit actually obviates the route lookup). Therefore the stack

Re: [PATCH] mm: memcontrol: MEMCG no longer works with SLOB

On Wed, Dec 09, 2015 at 03:01:07PM -0500, Johannes Weiner wrote: > On Wed, Dec 09, 2015 at 05:32:39PM +0100, Arnd Bergmann wrote: > > The change to move the kmem accounting into the normal memcg > > code means we can no longer use memcg with slob, which lacks > > the memcg_params member in its

Re: [PATCH 2/3] ser_gigaset: fix deallocation of platform device structure

On wo, 2015-12-09 at 12:10 +0100, Tilman Schmidt wrote: > Am 09.12.2015 um 00:12 schrieb Paul Bolle: > > So what does setting > > cs->hw.ser->dev.dev.driver_data to NULL just before freeing it buy > > us? > > We're freeing cs->hw.ser, not cs->hw.ser->dev. > Clearing the reference to cs from the

Re: [PATCH 0/3] ser_gigaset fixes

Hi Tilman, On di, 2015-12-08 at 12:00 +0100, Tilman Schmidt wrote: > this series is the result of our discussion on the "freeing an > active object" bug. I split my proposed patch into two patches > for the separate topics of moving the ser_cardstate kfree() and > dropping the useless kfree()s,

[iproute PATCH] tc.8: Fix reference to tc-tcindex.8

Just a typo there, it's spelled correctly in SEE ALSO section.. Signed-off-by: Phil Sutter --- man/man8/tc.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/tc.8 b/man/man8/tc.8 index 6275c4b32b167..4e99dcad5b1da 100644 --- a/man/man8/tc.8 +++

RE: [PATCH net] ipv6: sctp: clone options to avoid use after free

From: Daniel Borkmann > Sent: 09 December 2015 19:19 > On 12/09/2015 06:11 PM, Marcelo Ricardo Leitner wrote: > > Em 09-12-2015 14:31, David Laight escreveu: > >> From: Eric Dumazet [mailto:eric.duma...@gmail.com] > >>> Sent: 09 December 2015 16:00 > >>> On Wed, 2015-12-09 at 15:49 +, David

Re: [PATCH v3 1/4] VSOCK: Introduce virtio-vsock-common.ko

Stefan Hajnoczi writes: > From: Asias He > > This module contains the common code and header files for the following > virtio-vsock and virtio-vhost kernel modules. General comment checkpatch has a bunch of warnings about 80 character limits, extra

Re: [PATCH] iwlegacy: mark il_adjust_beacon_interval as noinline

On Wed, Dec 09, 2015 at 05:42:41PM +0100, Arnd Bergmann wrote: > With the new optimized do_div() code, some versions of gcc > produce obviously incorrect code that leads to a link error > in iwlegacy/common.o: > > drivers/built-in.o: In function `il_send_rxon_timing': > :(.text+0xa6b4d4):

Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Marcel, On 17/11/15 17:18, Stefan Schmidt wrote: Hello. On 17/11/15 17:17, Stefan Schmidt wrote: From: Markus Elfring Date: Mon, 16 Nov 2015 13:50:23 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test

Re: [iproute PATCH] route: ignore RTAX_HOPLIMIT of value -1

On Wed, 2 Dec 2015 12:50:22 + Phil Sutter wrote: > Older kernels use -1 internally as indicator to use the sysctl default, > but they still export the setting. Newer kernels use 0 to indicate that > (which is why the conversion from -1 to 0 was done here), but they also >

Re: [PATCH iproute2] libnetlink: don't confuse variables in rtnl_talk()

On Thu, 3 Dec 2015 17:13:48 +0100 Nicolas Dichtel wrote: > There is two variables named 'len' in rtnl_talk. In fact, commit > c079e121a73a didn't work. For example, it was possible to trigger > a seg fault with this command: > $ ip link set gre2 type ip6gre hoplimit

Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Hi Stefan, >>> From: Markus Elfring >>> Date: Mon, 16 Nov 2015 13:50:23 +0100 >>> >>> The kfree_skb() function tests whether its argument is NULL and then >>> returns immediately. Thus the test around the call is not needed. >>> >>> This issue was detected by

[PATCH net v2] net: Flush local routes when device changes vrf association

The VRF driver cycles netdevs when an interface is enslaved or released: the down event is used to flush neighbor and route tables and the up event (if the interface was already up) effectively moves local and connected routes to the proper table. As of 4f823defdd5b the local route is left

Re: [PATCH] ip neigh: device is optional for proxy entries

On Tue, 01 Dec 2015 01:17:06 +0300 Konstantin Khlebnikov wrote: > Though dumping such entries crashes present kernels. > > Signed-off-by: Konstantin Khlebnikov Applied thanks, but I nobody will use it until after your kernel patch makes it to stable. -- To

Re: [PATCH v5 1/4] stmmac: create of compatible mdio bus for stmacc driver

Hi also pls fix this typo stmmac: create of compatible mdio bus for stmacc driver stmmac On 12/9/2015 9:39 AM, Phil Reid wrote: The DSA driver needs to be passed a reference to an mdio bus. Typically

RE: [PATCH net] ipv6: sctp: clone options to avoid use after free

From: Eric Dumazet > Sent: 10 December 2015 15:58 > > BTW, are you even using IPv6 SCTP sessions ? Our M3UA/SCTP protocol stack supports them and defaults to using IPv6 listening sockets for IPv4 connections. I very much doubt than any customers have used them yet. So most of the IPv6

Re: [BUG] net: performance regression on ixgbe (Intel 82599EB 10-Gigabit NIC)

On 12/10/2015 06:18 AM, Otto Sabart wrote: *) Is irqbalance disabled and the IRQs set the same each time, or might there be variability possible there? Each of the five netperf runs will be a different four-tuple which means each may (or may not) get RSS hashed/etc differently. The irqbalance

Re: [PATCH net] sfc: only use RSS filters if we're using RSS

From: Bert Kenward Date: Thu, 10 Dec 2015 13:30:08 + > Without this filter insertion on a VF would fail if only one channel > was in use. This would include the unicast station filter and therefore > no traffic would be received. > > Signed-off-by: Bert Kenward

Re: [PATCH] sched/cls_flow.c : allow nfct-* keys work on ingress interfaces

Hello, On Thu, Dec 10, 2015 at 5:24 AM, Гаврилов Игорь wrote: > Improved CTTUPLE macro with code from sched/act_connmark.c, so it be able to > get unNATed addresses from nf_conntrack. Please follow the guideline to submit a formal kernel patch:

Re: [PATCH v3 1/4] VSOCK: Introduce virtio-vsock-common.ko

On Thu, Dec 10, 2015 at 10:17:07AM +, Alex Bennée wrote: > Stefan Hajnoczi writes: > > > From: Asias He > > > > This module contains the common code and header files for the following > > virtio-vsock and virtio-vhost kernel modules. > > General

Re: [PATCH v5 1/4] stmmac: create of compatible mdio bus for stmacc driver

G'day Giuseppe, On 11/12/2015 1:16 AM, Giuseppe CAVALLARO wrote: Hi also pls fix this typo stmmac: create of compatible mdio bus for stmacc driver stmmac Will do. On 12/9/2015 9:39 AM, Phil Reid

Re: [PATCH v3 2/4] VSOCK: Introduce virtio-vsock.ko

On Thu, Dec 10, 2015 at 09:23:25PM +, Alex Bennée wrote: > Stefan Hajnoczi writes: > > > From: Asias He > > > > VM sockets virtio transport implementation. This module runs in guest > > kernel. > > checkpatch warns on a bunch of whitespace/tab issues.

[PATCH net] sfc: only use RSS filters if we're using RSS

Without this filter insertion on a VF would fail if only one channel was in use. This would include the unicast station filter and therefore no traffic would be received. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 23 +++

[PATCH v2] wlcore/wl12xx: spi: fix oops on firmware load

The maximum chunks used by the function is (SPI_AGGR_BUFFER_SIZE / WSPI_MAX_CHUNK_SIZE + 1). The original commands array had space for (SPI_AGGR_BUFFER_SIZE / WSPI_MAX_CHUNK_SIZE) commands. When the last chunk is used (len > 4 * WSPI_MAX_CHUNK_SIZE), the last command is stored outside the bounds

Re: [PATCH net 1/2] xfrm: add rcu grace period in xfrm_policy_destroy()

On Tue, Dec 08, 2015 at 10:58:29PM -0500, David Miller wrote: > From: Eric Dumazet > Date: Tue, 8 Dec 2015 07:22:01 -0800 > > > We will soon switch sk->sk_policy[] to RCU protection, > > as SYNACK packets are sent while listener socket is not locked. > > > > This patch

Re: [PATCH] [BACKPORT] [3.14.56] bnx2x: Don't notify about scratchpad parities

On Friday 06 November 2015 09:32:46 Greg KH wrote: > On Thu, Nov 05, 2015 at 11:18:37AM +0100, Patrick Schaaf wrote: > > bnx2x: Don't notify about scratchpad parities > > > > This is a (trivial) "backport" of ad6afbe9578d1fa26680faf78c846bd8c00d1d6e > > to stable kernel 3.14.56. > > This patch

[PATCH] sched/cls_flow.c : allow nfct-* keys work on ingress interfaces

Improved CTTUPLE macro with code from sched/act_connmark.c, so it be able to get unNATed addresses from nf_conntrack.--- cls_flow.c 2015-11-02 02:05:25.0 +0200 +++ net/sched/cls_flow.c 2015-12-10 17:04:03.075202330 +0200 @@ -30,6 +30,8 @@ #if defined(CONFIG_NF_CONNTRACK) ||

Re: [PATCH 2/3] ser_gigaset: fix deallocation of platform device structure

Hi Tilman, On 12/09/2015 03:10 AM, Tilman Schmidt wrote: > Am 09.12.2015 um 00:12 schrieb Paul Bolle: > >>> --- a/drivers/isdn/gigaset/ser-gigaset.c >>> +++ b/drivers/isdn/gigaset/ser-gigaset.c >>> @@ -370,19 +370,23 @@ static void gigaset_freecshw(struct cardstate >>> *cs) >>>

[PATCH] ixgbe: on recv increment rx.ring->stats.yields instead of tx

It seem to be non intentionaly changed to tx in ms commit: adc810900a703ee78fe88fd65e086d359fec04b2 ixgbe: Refactor busy poll socket code to address multiple issues Lock is taken from ixgbe_low_latency_recv, and there under this lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment

Re: Checksum offload queries

On 09/12/15 18:00, Tom Herbert wrote: > That is not at all true. If the stack has set up VXLAN RCO and the > device > decides to set the inner checksum itself then the checksum > will be bad. The > checksum interface is very specific please read it > carefully (sk_buff.h), > if the

Re: [PATCH net] ipv6: sctp: clone options to avoid use after free

On Thu, 2015-12-10 at 12:26 +, David Laight wrote: > Yes, I'm worried about whether our M3UA code is likely to crash customer > systems, not whether hostile applications can crash it. > These boxes ought to be on private networks since the sigtran protocols > themselves have nothing that even

Re: [PATCH v3 3/4] i40e: Kernel dependency update for i40e to support geneve offload

On Tue, 2015-12-08 at 10:12 -0800, Anjali Singhai Jain wrote: > Update the Kconfig file with dependency for supporting GENEVE tunnel > offloads. > > Signed-off-by: Anjali Singhai Jain > Signed-off-by: Kiran Patil Acked-by: Jeff Kirsher

Re: [PATCH v3 2/4] i40e: geneve tunnel offload support

On Tue, 2015-12-08 at 10:12 -0800, Anjali Singhai Jain wrote: > This patch adds driver hooks to implement ndo_ops to add/del > udp port in the HW to identify GENEVE tunnels. > > Signed-off-by: Anjali Singhai Jain > Signed-off-by: Kiran Patil

[PATCH 2/4] livepatch: use list_is_first()

For better readability, use list_is_first() instead of open-coded. Signed-off-by: Geliang Tang --- kernel/livepatch/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c index bc2c85c..be64106 100644 ---

[PATCH 4/4] elevator: use list_is_{first,last}

For better readability, use list_is_{first,last}() instead of open-coded. Signed-off-by: Geliang Tang --- block/noop-iosched.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/noop-iosched.c b/block/noop-iosched.c index a163c48..d44326e 100644

[PATCH 3/4] netfilter: ipset: use list_is_first()

For better readability, use list_is_first() instead of open-coded. Signed-off-by: Geliang Tang --- net/netfilter/ipset/ip_set_list_set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/ipset/ip_set_list_set.c

Re: [BUG] net: performance regression on ixgbe (Intel 82599EB 10-Gigabit NIC)

Hi Rick, > *) It is good to be binding netperf and netserver - helps with > reproducibility, but why the two -T options? A brief look at src/netsh.c > suggests it will indeed set the two binding options separately but that is > merely a side-effect of how I wrote the code. It wasn't an

[PATCH 1/4] list: introduce list_is_first()

We already have list_is_last(), it makes sense to also add list_is_first() for consistency. This list utility function to check for first element in a list. Signed-off-by: Geliang Tang --- include/linux/list.h | 11 +++ 1 file changed, 11 insertions(+) diff --git

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

Hi Sascha, On jeu., déc. 10 2015, Sascha Hauer wrote: > Hi Gregory, > > On Wed, Dec 09, 2015 at 06:49:43PM +0100, Gregory CLEMENT wrote: >> With device tree it is no more possible to reset the PHY at board >> level. Furthermore, doing in the driver allow to power down

Re: [PATCH 1/4] list: introduce list_is_first()

On 12/10/2015 07:17 AM, Geliang Tang wrote: We already have list_is_last(), it makes sense to also add list_is_first() for consistency. This list utility function to check for first element in a list. Honestly, I think we already have way too many of these kind of helpers. IMHO they don't

[PATCH net-next V1 7/9] net/mlx5_core: Flow steering tree initialization

From: Maor Gottlieb Flow steering initialization is based on static tree which illustrates the flow steering tree when the driver is loaded. The initialization considers the max supported flow table level of the device, a minimum of 2 kernel flow tables(vlan and mac) are

[PATCH net-next V1 6/9] net/mlx5_core: Introduce flow steering API

From: Maor Gottlieb Introducing the following objects: mlx5_flow_root_namespace: represent the root of specific flow table type tree(e.g NIC receive, FDB, etc..) mlx5_flow_group: define the mask of the flow specification. fs_fte(flow steering flow table entry): defines the

  1   2   >