Re: rhashtable: Prevent spurious EBUSY errors on insertion

2015-12-17 Thread Herbert Xu
On Thu, Dec 17, 2015 at 04:46:00PM +0800, Xin Long wrote: > > sorry for late test, but unfortunately, my case with rhashtalbe still > return EBUSY. > I added some debug code in rhashtable_insert_rehash(), and found: > *future_tbl is null* > > fail: > /* Do not fail the insert if someone

Re: rhashtable: Prevent spurious EBUSY errors on insertion

2015-12-17 Thread Xin Long
On Thu, Dec 17, 2015 at 4:48 PM, Herbert Xu wrote: > On Thu, Dec 17, 2015 at 04:46:00PM +0800, Xin Long wrote: >> >> sorry for late test, but unfortunately, my case with rhashtalbe still >> return EBUSY. >> I added some debug code in rhashtable_insert_rehash(), and

Re: Load Balancing for AF_INET Raw Sockets

2015-12-17 Thread Prashant Upadhyaya
On Tue, Dec 15, 2015 at 6:26 PM, Prashant Upadhyaya wrote: > Hi, > > I open a raw socket for listening to all the UDP packets in a raw fashion -- > > socket(AF_INET, SOCK_RAW, IPPROTO_UDP); > > Then I use recvfrom to read the packets over the socket. > > The above works

[PATCH 1/1] bonding: restrict up state in 802.3ad mode

2015-12-17 Thread zyjzyj2000
From: Zhu Yanjun In 802.3ad mode, the speed and duplex is needed. But in some NIC, there is a time span between NIC up state and getting speed and duplex. As such, sometimes a slave in 802.3ad mode is in up state without speed and duplex. This will make bonding in 802.3ad

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

2015-12-17 Thread Gregory CLEMENT
Hi Arnd, On mer., déc. 16 2015, Arnd Bergmann wrote: > On Wednesday 16 December 2015 19:31:30 Gregory CLEMENT wrote: >> diff --git a/drivers/net/ethernet/cadence/macb.c >> b/drivers/net/ethernet/cadence/macb.c >> index 88c1e1a..35661aa 100644 >> ---

Re: rhashtable: Prevent spurious EBUSY errors on insertion

2015-12-17 Thread Xin Long
On Thu, Dec 3, 2015 at 8:41 PM, Herbert Xu wrote: > On Mon, Nov 30, 2015 at 06:18:59PM +0800, Herbert Xu wrote: >> >> OK that's better. I think I see the problem. The test in >> rhashtable_insert_rehash is racy and if two threads both try >> to grow the table one of

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

2015-12-17 Thread Hannes Frederic Sowa
Hi all, On 17.12.2015 01:04, David Miller wrote: > From: Hannes Frederic Sowa > Date: Tue, 15 Dec 2015 21:01:54 +0100 > >> udp tunnel offloads tend to aggregate datagrams based on inner >> headers. gro engine gets notified by tunnel implementations about >> possible

Re: Does the Community use Coverity ?

2015-12-17 Thread pavi1729
Sanket, Jeff, Thanks a ton, that was helpful. Cheers, Pavi On Wed, Dec 16, 2015 at 12:32 AM, Jeff Haran wrote: >>-Original Message- >>From: kernelnewbies-bounces+jharan=bytemobile@kernelnewbies.org >>[mailto:kernelnewbies-

Re: [PATCH] af_unix: Revert 'lock_interruptible' in stream receive code

2015-12-17 Thread Hannes Frederic Sowa
On 16.12.2015 21:09, Rainer Weikusat wrote: > With b3ca9b02b00704053a38bfe4c31dbbb9c13595d0, the AF_UNIX SOCK_STREAM > receive code was changed from using mutex_lock(>readlock) to > mutex_lock_interruptible(>readlock) to prevent signals from being > delayed for an indefinite time if a thread

[PATCH] net/macb: Update device tree binding for resetting PHY using GPIO

2015-12-17 Thread Gregory CLEMENT
Instead of being at the MAC level the reset gpio preperty is moved at the PHY child node level. It is still managed by the MAC, but from the point of view of the binding it make more sense to be part of the PHY node. This commit also fixes a build errors if GPIOLIB is not selected.

Re: [PATCH 0/2] net: usb: cdc_ncm: Adding support for two new Dell devices

2015-12-17 Thread Daniele Palmas
Hi Bjorn, 2015-12-17 13:21 GMT+01:00 Bjørn Mork : > Dan Williams writes: >> On Wed, 2015-12-16 at 10:39 +0100, Daniele Palmas wrote: >>> This patch series add support in the cdc_ncm driver for two devices >>> based on the same platform, that are different only for

Re: [PATCH] net/macb: add proper header file

2015-12-17 Thread Nicolas Ferre
t;gregory.clem...@free-electrons.com> > Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> This one is fixed and handled by Gregory here: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/394433.html Thanks a lot anyay, bye, > --- > > build log with

[PATCH 1/1] mac80211: improve the contiguous mask checking

2015-12-17 Thread Zeng Zhaoxiu
If the result of adding the first set bit to the mask is power of 2, the mask must be contiguous. "mask & -mask" can get the first set bit of mask gracefully. Signed-off-by: Zeng Zhaoxiu --- net/mac80211/iface.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

Re: [PATCH] net/macb: add proper header file

2015-12-17 Thread Sudip Mukherjee
On Thu, Dec 17, 2015 at 01:41:59PM +0100, Gregory CLEMENT wrote: > Hi Sudip, > > On jeu., déc. 17 2015, Sudip Mukherjee wrote: > > > mips allmodconfig build fails with the error: > > > > drivers/net/ethernet/cadence/macb.c: In function 'macb_probe': > >

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

2015-12-17 Thread Phil Sutter
On Thu, Dec 17, 2015 at 12:45:33PM +0300, Dmitrii Shcherbakov wrote: > >I don't think your patch should contain this cleanup of "b4". > > It seems that b3 is only used for the legacy overhead part and if I remove > it, b3 is not going to be used. So I figured I remove b4 put b3 instead. No

[PATCH net 1/2] net/mlx4_en: Remove dependency between timestamping capability and service_task

2015-12-17 Thread Or Gerlitz
From: Eugenia Emantayev Service task is responsible for other tasks in addition to timestamping overflow check. Launch it even if timestamping is not supported by device. Fixes: 07841f9d94c1 ('net/mlx4_en: Schedule napi when RX buffers allocation fails') Signed-off-by:

[PATCH net 2/2] net/mlx4_en: Fix HW timestamp init issue upon system startup

2015-12-17 Thread Or Gerlitz
From: Eugenia Emantayev mlx4_en_init_timestamp was called before creation of netdev and port init, thus used uninitialized values. Specifically - NIC frequency was incorrect causing wrong calculations and later wrong HW timestamps. Fixes: 1ec4864b1017 ('net/mlx4_en: Fixed

[PATCH net 0/2] Mellanox mlx4 driver fixes

2015-12-17 Thread Or Gerlitz
Hi Dave, Two small fixes from Jenny for code flows that deal with time-stamping. Or. Eugenia Emantayev (2): net/mlx4_en: Remove dependency between timestamping capability and service_task net/mlx4_en: Fix HW timestamp init issue upon system startup

[PATCH net-next] team: Advertise tunneling offload features

2015-12-17 Thread Or Gerlitz
From: Eran Ben Elisha When the underlying device supports offloads encapulated traffic, we need to reflect that through the hw_enc_features field of the team net-device. This will cause the xmit path in the core networking stack to provide team with encapsulated GSO frames

Re: Load Balancing for AF_INET Raw Sockets

2015-12-17 Thread Eric Dumazet
On Thu, 2015-12-17 at 11:40 +0530, Prashant Upadhyaya wrote: > On Tue, Dec 15, 2015 at 8:09 PM, Eric Dumazet wrote: > > On Tue, 2015-12-15 at 18:26 +0530, Prashant Upadhyaya wrote: > >> Hi, > >> > >> I open a raw socket for listening to all the UDP packets in a raw fashion

Re: [PATCH 0/2] net: usb: cdc_ncm: Adding support for two new Dell devices

2015-12-17 Thread Daniele Palmas
Hi Dan, 2015-12-16 18:12 GMT+01:00 Dan Williams : > On Wed, 2015-12-16 at 10:39 +0100, Daniele Palmas wrote: >> This patch series add support in the cdc_ncm driver for two devices >> based on the same platform, that are different only for carrier >> customization. >> >> The

[PATCH net-next] nfp: call netif_carrier_off() during init

2015-12-17 Thread Jakub Kicinski
Netdevs default to carrier on, we should call netif_carrier_off() during initialization since we handle carrier state changes in the driver. Signed-off-by: Jakub Kicinski Reviewed-by: Rolf Neugebauer ---

Re: [PATCH] net/macb: add proper header file

2015-12-17 Thread Gregory CLEMENT
nsg too: http://marc.info/?l=linux-netdev=145034590619620=2 Thanks, Gregory > > Fixes: 5833e0526820 ("net/macb: add support for resetting PHY using GPIO") > Cc: Gregory CLEMENT <gregory.clem...@free-electrons.com> > Signed-off-by: Sudip Mukherjee <su...@vector

[iproute PATCH v2 2/2] ss: support closing inet sockets via SOCK_DESTROY.

2015-12-17 Thread Lorenzo Colitti
This patch adds a -K / --kill option to ss that attempts to forcibly close matching sockets using SOCK_DESTROY. This is implemented by adding a new "struct action" to struct filter. If necessary, this can be extended later on to support further actions on sockets. Because ss typically prints

Re: [RFCv4 bluetooth-next 1/2] 6lowpan: iphc: add support for stateful compression

2015-12-17 Thread Alexander Aring
On Thu, Dec 17, 2015 at 12:26:37PM +, Duda, Lukasz wrote: > Hi Alex! > > > -Original Message- > > From: Alexander Aring [mailto:alex.ar...@gmail.com] > > Sent: Tuesday, December 15, 2015 12:09 > > To: Duda, Lukasz > > Cc: linux-w...@vger.kernel.org; linux-blueto...@vger.kernel.org; >

[PATCH net] sctp: sctp should release assoc when sctp_make_abort_user return NULL in sctp_close

2015-12-17 Thread Xin Long
In sctp_close, sctp_make_abort_user may return NULL because of memory allocation failure. If this happens, it will bypass any state change and never free the assoc. The assoc has no chance to be freed and it will be kept in memory with the state it had even after the socket is closed by

Re: pull-request: mac80211 2015-12-15

2015-12-17 Thread Johannes Berg
On Wed, 2015-12-16 at 18:34 -0500, David Miller wrote: >  > Something about your text encoding kept this from ending up > in patchwork for some reason. > Hm. I don't see anything special with this, seems to just be plain text 8bit transfer encoding. Do you want me to watch out for things

[iproute PATCH v2 1/2] libnetlink: add a variant of rtnl_send_check that consumes ACKs

2015-12-17 Thread Lorenzo Colitti
The new variant is identical to rtnl_send_check, except it also consumes the kernel response instead of using MSG_PEEK. This is useful for callers that send simple commands that never cause a response but only ACKs, and that expect to receive and deal with errors without printing them to stderr

Re: [PATCH net-next v5 2/8] netfilter: Factor out nf_ct_get_info().

2015-12-17 Thread Sergei Shtylyov
Hello. On 12/17/2015 3:36 AM, Jarno Rajahalme wrote: Define a new inline function to map conntrack status to enum ip_conntrack_info. This removes the need to otherwise duplicate this code in a later patch ("openvswitch: Find existing conntrack entry after upcall."). Signed-off-by: Jarno

Re: [PATCH net-next v5 7/8] openvswitch: Delay conntrack helper call for new connections.

2015-12-17 Thread Sergei Shtylyov
Hello. On 12/17/2015 3:36 AM, Jarno Rajahalme wrote: There is no need to help connections that are not confirmed, so we can delay helping new connections to the time when they are confirmed. This change is needed for NAT support, and having this as a separate patch will make the following NAT

Re: [iproute PATCH v2 2/2] ss: support closing inet sockets via SOCK_DESTROY.

2015-12-17 Thread Eric Dumazet
On Thu, 2015-12-17 at 22:22 +0900, Lorenzo Colitti wrote: > This patch adds a -K / --kill option to ss that attempts to > forcibly close matching sockets using SOCK_DESTROY. > > This is implemented by adding a new "struct action" to struct > filter. If necessary, this can be extended later on to

Re: [PATCH] af_unix: Revert 'lock_interruptible' in stream receive code

2015-12-17 Thread Rainer Weikusat
Hannes Frederic Sowa writes: > On 16.12.2015 21:09, Rainer Weikusat wrote: >> With b3ca9b02b00704053a38bfe4c31dbbb9c13595d0, the AF_UNIX SOCK_STREAM >> receive code was changed from using mutex_lock(>readlock) to >> mutex_lock_interruptible(>readlock) to prevent

[PATCH net] be2net: Avoid accessing eq object in be_msix_register routine, when i < 0.

2015-12-17 Thread Venkat Duvvuru
When the first request_irq fails in be_msix_register, i value would be zero. The current code decrements the i value and accesses the eq object without validating the decremented "i" value. This can cause an "invalid memory address access" violation. This patch fixes the problem by accessing the

Re: [Patch net] net: check both type and procotol for tcp sockets

2015-12-17 Thread Willem de Bruijn
On Thu, Dec 17, 2015 at 2:39 AM, Cong Wang wrote: > Dmitry reported the following out-of-bound access: > > Call Trace: > [] __asan_report_load4_noabort+0x3e/0x40 > mm/kasan/report.c:294 > [] sock_setsockopt+0x1284/0x13d0 net/core/sock.c:880 > [< inline >]

[PATCH] net ixgbevf: ethtool statistics yields/misses fixes

2015-12-17 Thread Tristan Colgate
ixgbevf over counts yields and does not actually count misses. --- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbevf/ethtool.c b/drivers/net/ethernet/intel/ixgbevf/ethtool.c index

Re: [PATCH 07/15] i40iw: add hw and utils files

2015-12-17 Thread Christoph Hellwig
> +#ifndef UNREFERENCED_PARAMETER > +#define UNREFERENCED_PARAMETER(_p) \ > +{\ > + (_p) = (_p);\ > +} > +#endif No need for this, just remove it. > +#define I40E_MASK(mask, shift) (mask << shift) Please just opencode the shit, this

Re: rhashtable: Prevent spurious EBUSY errors on insertion

2015-12-17 Thread Xin Long
On Thu, Dec 17, 2015 at 5:00 PM, Xin Long wrote: > On Thu, Dec 17, 2015 at 4:48 PM, Herbert Xu > wrote: >> On Thu, Dec 17, 2015 at 04:46:00PM +0800, Xin Long wrote: >>> >>> sorry for late test, but unfortunately, my case with rhashtalbe still

[PATCH net-next 0/2] Local checksum offload for VXLAN

2015-12-17 Thread Edward Cree
When the inner packet checksum is offloaded, the outer UDP checksum is easy to calculate as it doesn't depend on the payload (because the inner checksum cancels out everything from the inner packet except the pseudo header). Thus, transmit checksums for VXLAN (and in principle other

Re: [PATCH 1/1] mac80211: improve the contiguous mask checking

2015-12-17 Thread Johannes Berg
On Thu, 2015-12-17 at 22:59 +0800, Zeng Zhaoxiu wrote: > If the result of adding the first set bit to the mask is power of 2, > the mask must be contiguous. "mask & -mask" can get the first set bit > of mask gracefully. > - if (__ffs64(mask) + hweight64(mask) != fls64(mask)) > { > +

RE: Random packet loss using IPsec with AES128-SHA1

2015-12-17 Thread Gabriele Beltrame
Hi Steffen, I don't think it's IPsec (I can see the outbound packet in tcpdump), not alone at least but the XEN /AWS Ethernet driver (or multiple things concurring to the issue) actually... the odd thing is that it does seem to affect AES-CBS only (3DES-CBS, AES-GCM are fine) This is the short

Re: [PATCH] af_unix: Revert 'lock_interruptible' in stream receive code

2015-12-17 Thread Hannes Frederic Sowa
On 17.12.2015 16:28, Rainer Weikusat wrote: > Hannes Frederic Sowa writes: >> On 16.12.2015 21:09, Rainer Weikusat wrote: >>> With b3ca9b02b00704053a38bfe4c31dbbb9c13595d0, the AF_UNIX SOCK_STREAM >>> receive code was changed from using mutex_lock(>readlock) to >>>

Re: [PATCH/RFC net-next] ravb: Add dma queue interrupt support

2015-12-17 Thread Yoshihiro Kaneko
Hi, 2015-12-16 4:00 GMT+09:00 Sergei Shtylyov : > Hello. > > On 12/15/2015 03:23 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple

Re: [PATCH 08/15] i40iw: add files for iwarp interface

2015-12-17 Thread Christoph Hellwig
> + i40iw_next_iw_state(iwqp, I40IW_QP_STATE_ERROR, 0, 0, 0); > + > + if (!iwqp->user_mode) { > + if (iwqp->iwscq) > + i40iw_clean_cqes(iwqp, iwqp->iwscq); > + if ((iwqp->iwrcq) && (iwqp->iwrcq != iwqp->iwscq)) Please try to do a pass

[PATCH net-next 2/2] net: vxlan: enable local checksum offload on HW_CSUM devices

2015-12-17 Thread Edward Cree
Signed-off-by: Edward Cree --- drivers/net/vxlan.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 6369a57..c1660d6 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -1785,6 +1785,9 @@

[PATCH net-next 1/2] net: udp: local checksum offload for encapsulation

2015-12-17 Thread Edward Cree
The arithmetic properties of the ones-complement checksum mean that a correctly checksummed inner packet, including its checksum, has a ones complement sum depending only on whatever value was used to initialise the checksum field before checksumming (in the case of TCP and UDP, this is the

Re: [iproute PATCH v2 1/2] libnetlink: add a variant of rtnl_send_check that consumes ACKs

2015-12-17 Thread Eric Dumazet
On Thu, 2015-12-17 at 22:22 +0900, Lorenzo Colitti wrote: > The new variant is identical to rtnl_send_check, except it also > consumes the kernel response instead of using MSG_PEEK. This is > useful for callers that send simple commands that never cause a > response but only ACKs, and that expect

Instantaneous Threshold ECN marking for DCTCP

2015-12-17 Thread Bryce Cronkite-Ratcliff
Hi there, I am attempting to run some experiments with DCTCP using mininet (so this is all user-level emulation -- my switch is a linux namespace using OVS). My question is on how to apply DCTCP's AQM. DCTCP's AQM just marks all packets with CE if they are received when the queue is over a

Re: rhashtable: Prevent spurious EBUSY errors on insertion

2015-12-17 Thread David Miller
From: Xin Long Date: Thu, 17 Dec 2015 17:00:35 +0800 > On Thu, Dec 17, 2015 at 4:48 PM, Herbert Xu > wrote: >> On Thu, Dec 17, 2015 at 04:46:00PM +0800, Xin Long wrote: >>> >>> sorry for late test, but unfortunately, my case with rhashtalbe

[RFC 4/5] ethtool: support per queue sub command --show-coalesce

2015-12-17 Thread kan . liang
From: Kan Liang Get all masked queues' coalesce from kernel and dump them one by one. Example: $ sudo ./ethtool --set-perqueue-command eth5 queue_mask 0x11 --show-coalesce Queue: 0 Adaptive RX: off TX: off stats-block-usecs: 0 sample-interval: 0 pkt-rate-low: 0

[RFC 2/5] ethtool: move cmdline_coalesce out of do_scoalesce

2015-12-17 Thread kan . liang
From: Kan Liang Moving cmdline_coalesce out of do_scoalesce, so it can be shared with other functions. No behavior change. Signed-off-by: Kan Liang --- ethtool.c | 147 +++--- 1 file changed, 74

[RFC 3/5] ethtool: introduce new ioctl for per queue setting

2015-12-17 Thread kan . liang
From: Kan Liang Introduce a new ioctl for per queue parameters setting. Users can apply commands to specific queues by setting SUB_COMMAND and queue_mask as following command. ethtool --set-perqueue-command DEVNAME [queue_mask %x] SUB_COMMAND If queue_mask is not set, the

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

2015-12-17 Thread David Miller
From: Gregory CLEMENT Date: Thu, 17 Dec 2015 09:39:32 +0100 > if I remebered well you do not remove patch from yout branch. So would > you agree to take a follow-up patch on top of 5833e0526820 "net/macb: > add support for resetting PHY using GPIO" ? Yes. --

Re: [PATCH net-next 0/2] Local checksum offload for VXLAN

2015-12-17 Thread Tom Herbert
On Thu, Dec 17, 2015 at 7:27 AM, Edward Cree wrote: > When the inner packet checksum is offloaded, the outer UDP checksum is easy > to calculate as it doesn't depend on the payload (because the inner checksum > cancels out everything from the inner packet except the pseudo

[RFC 2/5] net/ethtool: support get coalesce per queue

2015-12-17 Thread kan . liang
From: Kan Liang Device driver has to provide an interface to get per queue coalesce. The interrupt coalescing parameters of each masked queue will be copied back to user space one by one. Signed-off-by: Kan Liang --- include/linux/ethtool.h | 5 -

[RFC 5/5] i40e/ethtool: support coalesce setting by queue

2015-12-17 Thread kan . liang
From: Kan Liang This patch implements set_per_queue_coalesce for i40e driver. For i40e driver, only rx and tx usecs has per queue value. Changing these two parameters only impact the specific queue. For other interrupt coalescing parameters, they are shared among queues. The

[RFC 1/5] net/ethtool: introduce a new ioctl for per queue setting

2015-12-17 Thread kan . liang
From: Kan Liang Introduce a new ioctl ETHTOOL_PERQUEUE for per queue parameters setting. The following patches will enable some SUB_COMMANDs for per queue setting. Signed-off-by: Kan Liang --- include/uapi/linux/ethtool.h | 18 ++

[RFC 4/5] i40e/ethtool: support coalesce getting by queue

2015-12-17 Thread kan . liang
From: Kan Liang This patch implements get_per_queue_coalesce for i40e driver. For i40e driver, only rx and tx usecs has per queue value. So only these two parameters are read from specific registers. For other interrupt coalescing parameters, they are shared among queues.

[RFC 3/5] net/ethtool: support set coalesce per queue

2015-12-17 Thread kan . liang
From: Kan Liang Device driver has to provide an interface to set per queue coalesce. The wanted coalesce information are stored in "data" for each masked queue, which can copy from userspace. Signed-off-by: Kan Liang --- include/linux/ethtool.h | 4

[RFC 5/5] ethtool: support per queue sub command --coalesce

2015-12-17 Thread kan . liang
From: Kan Liang This patch uses a similar way as do_scoalesce to set coalesce per queue. It reads the current settings, change them, and write them back to the kernel for each masked queue. Example: $ sudo ./ethtool --set-perqueue-command eth5 queue_mask 0x1 --coalesce

[RFC 1/5] ethtool: move option parsing related codes into function

2015-12-17 Thread kan . liang
From: Kan Liang Move option parsing code into find_option function. No behavior changes. Signed-off-by: Kan Liang --- ethtool.c | 49 +++-- 1 file changed, 31 insertions(+), 18 deletions(-) diff --git

Re: pull-request: mac80211 2015-12-15

2015-12-17 Thread David Miller
From: Johannes Berg Date: Thu, 17 Dec 2015 13:44:32 +0100 > On Wed, 2015-12-16 at 18:34 -0500, David Miller wrote: >>  >> Something about your text encoding kept this from ending up >> in patchwork for some reason. >> > > Hm. I don't see anything special with this,

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

2015-12-17 Thread Hannes Frederic Sowa
On 17.12.2015 18:32, Tom Herbert wrote: > On Thu, Dec 17, 2015 at 12:49 AM, Hannes Frederic Sowa > wrote: >> With user namespaces a normal user can start a new network namespace >> with all privileges and thus add new offloads, letting the other stack >> interpret this

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

2015-12-17 Thread Tom Herbert
On Thu, Dec 17, 2015 at 12:49 AM, Hannes Frederic Sowa wrote: > Hi all, > > On 17.12.2015 01:04, David Miller wrote: >> From: Hannes Frederic Sowa >> Date: Tue, 15 Dec 2015 21:01:54 +0100 >> >>> udp tunnel offloads tend to aggregate

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

2015-12-17 Thread Tom Herbert
On Thu, Dec 17, 2015 at 9:40 AM, Hannes Frederic Sowa wrote: > On 17.12.2015 18:32, Tom Herbert wrote: >> On Thu, Dec 17, 2015 at 12:49 AM, Hannes Frederic Sowa >> wrote: >>> With user namespaces a normal user can start a new network

Re: [PATCH/RFC net-next] ravb: Add dma queue interrupt support

2015-12-17 Thread Sergei Shtylyov
Hello. On 12/17/2015 07:29 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (descriptor, error, management) - One interrupt for emac - Four interrupts for dma queue (best effort

Re: pull-request: mac80211 2015-12-15

2015-12-17 Thread David Rivshin (Allworx)
On Thu, 17 Dec 2015 12:04:48 -0500 (EST) David Miller wrote: > From: Johannes Berg > Date: Thu, 17 Dec 2015 13:44:32 +0100 > > > On Wed, 2015-12-16 at 18:34 -0500, David Miller wrote: > >>  > >> Something about your text encoding kept this from

Re: [PATCH net] sctp: sctp should release assoc when sctp_make_abort_user return NULL in sctp_close

2015-12-17 Thread Vlad Yasevich
On 12/17/2015 09:30 AM, Xin Long wrote: > In sctp_close, sctp_make_abort_user may return NULL because of memory > allocation failure. If this happens, it will bypass any state change > and never free the assoc. The assoc has no chance to be freed and it > will be kept in memory with the state it

Re: [PATCH net] sctp: sctp should release assoc when sctp_make_abort_user return NULL in sctp_close

2015-12-17 Thread Marcelo Ricardo Leitner
Em 17-12-2015 16:29, Vlad Yasevich escreveu: On 12/17/2015 09:30 AM, Xin Long wrote: In sctp_close, sctp_make_abort_user may return NULL because of memory allocation failure. If this happens, it will bypass any state change and never free the assoc. The assoc has no chance to be freed and it

Re: [PATCHv3 net-next] ipv6: allow routes to be configured with expire values

2015-12-17 Thread David Miller
From: Xin Long Date: Wed, 16 Dec 2015 17:50:11 +0800 > Add the support for adding expire value to routes, requested by > Tom Gundersen for systemd-networkd, and NetworkManager > wants it too. > > implement it by adding the new RTNETLINK attribute

Re: [PATCHv3 net-next] ipv6: allow routes to be configured with expire values

2015-12-17 Thread Hannes Frederic Sowa
On 17.12.2015 21:23, Dan Williams wrote: > On Thu, 2015-12-17 at 15:08 -0500, David Miller wrote: >> From: Dan Williams >> Date: Wed, 16 Dec 2015 11:03:52 -0600 >> >>> On Wed, 2015-12-16 at 17:50 +0800, Xin Long wrote: Add the support for adding expire value to routes,

Re: [Patch net] net: check both type and procotol for tcp sockets

2015-12-17 Thread David Miller
From: Cong Wang Date: Wed, 16 Dec 2015 23:39:04 -0800 > Dmitry reported the following out-of-bound access: > > Call Trace: > [] __asan_report_load4_noabort+0x3e/0x40 > mm/kasan/report.c:294 > [] sock_setsockopt+0x1284/0x13d0 net/core/sock.c:880 > [< inline

Re: pull-request: mac80211 2015-12-15

2015-12-17 Thread Joe Perches
On Thu, 2015-12-17 at 13:44 +0100, Johannes Berg wrote: > On Wed, 2015-12-16 at 18:34 -0500, David Miller wrote: > >   > > Something about your text encoding kept this from ending up > > in patchwork for some reason. > > > > Hm. I don't see anything special with this, seems to just be plain >

Re: [PATCH net-next V1 3/4] net/mlx5e: Add HW timestamping (TS) support

2015-12-17 Thread Richard Cochran
On Thu, Dec 17, 2015 at 02:35:34PM +0200, Saeed Mahameed wrote: > @@ -63,6 +65,7 @@ > #define MLX5E_TX_CQ_POLL_BUDGET128 > #define MLX5E_UPDATE_STATS_INTERVAL200 /* msecs */ > #define MLX5E_SQ_BF_BUDGET 16 > +#define MLX5E_SERVICE_TASK_DELAY (HZ / 4) Hm... >

Re: [PATCH net-next] ipv6: addrconf: use stable address generator for ARPHRD_NONE

2015-12-17 Thread David Miller
From: Bjørn Mork Date: Wed, 16 Dec 2015 16:44:38 +0100 > Add a new address generator mode, using the stable address generator > with an automatically generated secret. This is intended as a default > address generator mode for device types with no EUI64 implementation. > The new

Re: [PATCH net-next V1 3/4] net/mlx5e: Add HW timestamping (TS) support

2015-12-17 Thread Richard Cochran
On Thu, Dec 17, 2015 at 02:35:34PM +0200, Saeed Mahameed wrote: > +static int mlx5e_get_ts_info(struct net_device *dev, > + struct ethtool_ts_info *info) > +{ > + struct mlx5e_priv *priv = netdev_priv(dev); > + int ret; > + > + ret = ethtool_op_get_ts_info(dev,

Re: [PATCH] net/macb: Update device tree binding for resetting PHY using GPIO

2015-12-17 Thread David Miller
From: Gregory CLEMENT Date: Thu, 17 Dec 2015 10:51:04 +0100 > Instead of being at the MAC level the reset gpio preperty is moved at the > PHY child node level. It is still managed by the MAC, but from the point > of view of the binding it make more sense to be

Re: [PATCH net-next V1 4/4] net/mlx5e: Add PTP Hardware Clock (PHC) support

2015-12-17 Thread Richard Cochran
On Thu, Dec 17, 2015 at 02:35:35PM +0200, Saeed Mahameed wrote: > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c > b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c > index 8e86f2c..b2e5014 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c > +++

Re: [PATCH net-next] tun: honor IFF_UP in tun_get_user()

2015-12-17 Thread David Miller
From: Eric Dumazet Date: Wed, 16 Dec 2015 08:57:37 -0800 > From: Eric Dumazet > > If a tun interface is turned down, we should not allow packet injection > into the kernel. > > Kernel does not send packets to the tun already. > > TUNATTACHFILTER

Re: [PATCH net] tcp: restore fastopen with no data in SYN packet

2015-12-17 Thread David Miller
From: Eric Dumazet Date: Wed, 16 Dec 2015 13:53:10 -0800 > From: Eric Dumazet > > Yuchung tracked a regression caused by commit 57be5bdad759 ("ip: convert > tcp_sendmsg() to iov_iter primitives") for TCP Fast Open. > > Some Fast Open users do not

Re: [PATCHv3 net-next] ipv6: allow routes to be configured with expire values

2015-12-17 Thread David Miller
From: Dan Williams Date: Wed, 16 Dec 2015 11:03:52 -0600 > On Wed, 2015-12-16 at 17:50 +0800, Xin Long wrote: >> Add the support for adding expire value to routes, requested by >> Tom Gundersen for systemd-networkd, and NetworkManager >> wants it too. >> >>

Re: [PATCH net-next] nfp: clear ring delayed kick counters

2015-12-17 Thread David Miller
From: Jakub Kicinski Date: Wed, 16 Dec 2015 19:08:52 + > We need to clear delayed kick counters when we free rings otherwise > after ndo_close()/ndo_open() we could kick HW by more entries than > actually written to rings. > > Signed-off-by: Jakub Kicinski

Re: [PATCH] af_unix: Revert 'lock_interruptible' in stream receive code

2015-12-17 Thread David Miller
From: Rainer Weikusat Date: Wed, 16 Dec 2015 20:09:25 + > With b3ca9b02b00704053a38bfe4c31dbbb9c13595d0, the AF_UNIX SOCK_STREAM > receive code was changed from using mutex_lock(>readlock) to > mutex_lock_interruptible(>readlock) to prevent signals from

Re: [PATCH v2 0/3] drivers: net: cpsw: Fix bugs in fixed-link PHY DT parsing

2015-12-17 Thread David Miller
From: "David Rivshin (Allworx)" Date: Wed, 16 Dec 2015 23:02:08 -0500 > I have tested on the following hardware configurations: > - (EVMSK) dual emac with two real MDIO-connected phys using RGMII-TXID > - single emac with fixed-link using RGMII > Testing of other

Re: [PATCH net] sctp: sctp should release assoc when sctp_make_abort_user return NULL in sctp_close

2015-12-17 Thread Vlad Yasevich
On 12/17/2015 02:01 PM, Marcelo Ricardo Leitner wrote: > Em 17-12-2015 16:29, Vlad Yasevich escreveu: >> On 12/17/2015 09:30 AM, Xin Long wrote: >>> In sctp_close, sctp_make_abort_user may return NULL because of memory >>> allocation failure. If this happens, it will bypass any state change >>>

Re: [PATCH net-next] ipv6: add IPV6_HDRINCL option for raw sockets

2015-12-17 Thread David Miller
From: Hannes Frederic Sowa Date: Wed, 16 Dec 2015 17:22:47 +0100 > Same as in Windows, we miss IPV6_HDRINCL for SOL_IPV6 and SOL_RAW. > The SOL_IP/IP_HDRINCL is not available for IPv6 sockets. > > Signed-off-by: Hannes Frederic Sowa This

Re: [PATCHv3 net-next] ipv6: allow routes to be configured with expire values

2015-12-17 Thread Dan Williams
On Thu, 2015-12-17 at 15:08 -0500, David Miller wrote: > From: Dan Williams > Date: Wed, 16 Dec 2015 11:03:52 -0600 > > > On Wed, 2015-12-16 at 17:50 +0800, Xin Long wrote: > >> Add the support for adding expire value to routes, requested by > >> Tom Gundersen

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

2015-12-17 Thread Hannes Frederic Sowa
On 17.12.2015 19:10, Tom Herbert wrote: > On Thu, Dec 17, 2015 at 9:40 AM, Hannes Frederic Sowa > wrote: >> On 17.12.2015 18:32, Tom Herbert wrote: >>> On Thu, Dec 17, 2015 at 12:49 AM, Hannes Frederic Sowa >>> wrote: With user

Re: [PATCHv2 net-next 0/4] Few l2 table related enhancements for cxgb4

2015-12-17 Thread David Miller
From: Hariprasad Shenai Date: Thu, 17 Dec 2015 13:45:06 +0530 > This series adds a new API to allocate and update l2t entry, replaces > arpq_head/arpq_tail with double skb double linked list. Use t4_mgmt_tx() > to send control packets of l2t write request. Use symbolic

[PATCH 2/2] mkiss: Fix use after free in sixpack_close().

2015-12-17 Thread David Miller
Need to do the unregister_device() after all references to the driver private have been done. Signed-off-by: David S. Miller --- drivers/net/hamradio/mkiss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hamradio/mkiss.c

Re: [PATCH net-next] net: qmi_wwan: ignore bogus CDC Union descriptors

2015-12-17 Thread David Miller
From: Bjørn Mork Date: Thu, 17 Dec 2015 12:44:04 +0100 > The CDC descriptors found on these vendor specific functions should > not be considered authoritative. They seem to be ignored by drivers > for other systems, and the quality is therefore low. > > One device (1e0e:9001)

Re: [PATCH net-next] team: Advertise tunneling offload features

2015-12-17 Thread David Miller
From: Or Gerlitz Date: Thu, 17 Dec 2015 16:11:55 +0200 > From: Eran Ben Elisha > > When the underlying device supports offloads encapulated traffic, > we need to reflect that through the hw_enc_features field of the > team net-device. > > This will

Re: use-after-free in sixpack_close

2015-12-17 Thread Ralf Baechle DL5RB
On Thu, Dec 17, 2015 at 04:05:32PM -0500, David Miller wrote: > This should fix it, the only thing I'm unsure of is if we should perhaps > also use del_timer_sync() here. Anyone? I think so. Ralf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2015-12-17 Thread Jay Vosburgh
wrote: >From: Zhu Yanjun > >In 802.3ad mode, the speed and duplex is needed. But in some NIC, >there is a time span between NIC up state and getting speed and duplex. >As such, sometimes a slave in 802.3ad mode is in up state without >speed and

Re: [PATCH] decnet: fix possible NULL deref in dnet_select_source()

2015-12-17 Thread Vegard Nossum
On 7 April 2014 at 21:18, David Miller wrote: > From: Eric Dumazet > Date: Sun, 06 Apr 2014 14:59:14 -0700 > >> From: Eric Dumazet >> >> dnet_select_source() should make sure dn_ptr is not NULL. >> >> While looking at this decnet

[GIT] Networking

2015-12-17 Thread David Miller
1) Fix uninitialized variable warnings in nfnetlink_queue, a lot of people reported this... From Arnd Bergmann. 2) Don't init mutex twice in i40e driver, from Jesse Brandeburg. 3) Fix spurious EBUSY in rhashtable, from Herbert Xu. 4) Missing DMA unmaps in mvpp2 driver, from Marcin Wojtas.

Re: use-after-free in sixpack_close

2015-12-17 Thread David Miller
From: One Thousand Gnomes Date: Thu, 17 Dec 2015 11:41:04 + >> This report is then followed by a dozen of other use-after-free reports. >> >> On commit edb42dc7bc0da0125ceacab810a553ce1f0cac8d (Dec 15). >> >> Thank you > > sixpack_close does

Re: [PATCHv3 net-next] ipv6: allow routes to be configured with expire values

2015-12-17 Thread David Miller
From: Dan Williams Date: Thu, 17 Dec 2015 14:23:57 -0600 > On Thu, 2015-12-17 at 15:08 -0500, David Miller wrote: >> That brings up an interesting issue, and I do not agree that we >> should >> publish the value for the purpose of determining if the kernel >> supports >> it or

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

2015-12-17 Thread Tom Herbert
On Thu, Dec 17, 2015 at 12:33 PM, Hannes Frederic Sowa wrote: > On 17.12.2015 19:10, Tom Herbert wrote: >> On Thu, Dec 17, 2015 at 9:40 AM, Hannes Frederic Sowa >> wrote: >>> On 17.12.2015 18:32, Tom Herbert wrote: On Thu, Dec 17, 2015

Re: [PATCH 2/2] mkiss: Fix use after free in sixpack_close().

2015-12-17 Thread Ralf Baechle
On Thu, Dec 17, 2015 at 04:05:49PM -0500, David Miller wrote: > Subject: [PATCH 2/2] mkiss: Fix use after free in sixpack_close(). Make that subject "... mkiss_close()." Ralf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH net-next] ipv6: addrconf: use stable address generator for ARPHRD_NONE

2015-12-17 Thread Hannes Frederic Sowa
On 16.12.2015 16:44, Bjørn Mork wrote: > Add a new address generator mode, using the stable address generator > with an automatically generated secret. This is intended as a default > address generator mode for device types with no EUI64 implementation. > The new generator is used for ARPHRD_NONE

  1   2   >