[PATCH net v2] tg3: Fix for tg3 transmit queue 0 timed out when too many gso_segs

From: Siva Reddy Kallam tg3_tso_bug() can hit a condition where the entire tx ring is not big enough to segment the GSO packet. For example, if MSS is very small, gso_segs can exceed the tx ring size. When we hit the condition, it will cause tx timeout. tg3_tso_bug()

Re: ixgbe: get link speed as a slave nic unrelated with link

Hi, Emil Thanks for your reply. I made simple tests. And maybe this patch should work. Because you can reproduce this problem, would you like to make tests with this patch? If this patch can fix this problem, it can prove that the root cause is correct. We can find another solution to fix

Re: [net-next PATCH 0/7] tc offload for cls_u32 on ixgbe

On 2/3/2016 12:21 PM, John Fastabend wrote: Thanks, we will need at least a v2 to fixup some build errors with various compile flags caught by build_bot and missed by me. Hi John, You didn't mark that as RFC... but we said this direction/approach yet to be talked @ netdev next-week, so.. can

[patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it

From: Jiri Pirko There a is need for some userspace API that would allow to expose things that are not directly related to any device class like net_device of ib_device, but rather chip-wide/switch-ASIC-wide stuff. Use cases: 1) get/set of port type (Ethernet/InfiniBand) 2)

[RESEND PATCH iproute2] tc: fix compilation with old gcc (< 4.6) (bis)

Commit 8f80d450c3cb ("tc: fix compilation with old gcc (< 4.6)") was reverted to ease the merge of the net-next branch. Here is the new version. Signed-off-by: Nicolas Dichtel Signed-off-by: Daniel Borkmann --- tc/tc_bpf.c | 58

[PATCH net] enic: increment devcmd2 result ring in case of timeout

From: Sandeep Pillai Firmware posts the devcmd result in result ring. In case of timeout, driver does not increment the current result pointer and firmware could post the result after timeout has occurred. During next devcmd, driver would be reading the result of previous

Re: [net-next PATCH 04/11] net: bulk alloc and reuse of SKBs in NAPI context

On Tue, 2 Feb 2016 16:52:50 -0800 Alexei Starovoitov wrote: > On Tue, Feb 02, 2016 at 10:12:01PM +0100, Jesper Dangaard Brouer wrote: > > Think twice before applying > > - This patch can potentially introduce added latency in some workloads > > > > This patch

Re: [PATCH v3] net:Add sysctl_max_skb_frags

On Wed, Feb 03, 2016 at 09:26:57AM +0100, Hans Westgaard Ry wrote: > Devices may have limits on the number of fragments in an skb they support. > Current codebase uses a constant as maximum for number of fragments one > skb can hold and use. > When enabling scatter/gather and running traffic with

Re: [PATCH net-next 2/4] drivers: net: xgene: Add support for RSS

Hi Iyappan, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Iyappan-Subramanian/Add-support-for-Classifier-and-RSS/20160203-155838 config: i386-allmodconfig (attached as .config) reproduce: # save the attached .config to linux build tree

Re: [net-next PATCH 1/7] net: rework ndo tc op to consume additional qdisc handle parameter

Hi John, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/John-Fastabend/tc-offload-for-cls_u32-on-ixgbe/20160203-173342 config: x86_64-randconfig-x005-201605 (attached as .config) reproduce: # save the attached .config to linux build tree

[patch net-next RFC 1/6] Introduce devlink infrastructure

From: Jiri Pirko Introduce devlink infrastructure for drivers to register and expose to userspace via generic Netlink interface. There are two basic objects defined: devlink - one instance for every "parent device", for example switch ASIC devlink port - one instance for

[patch net-next RFC 5/6] mlx4: Implement hardware messages notification using devlink

From: Jiri Pirko Use devlink HW message notification facilities to pass massages going to and from HW to userspace via Netlink multicast. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlx4/fw.c | 9 + include/uapi/linux/devlink.h

[patch net-next RFC 3/6] mlxsw: Implement hardware messages notification using devlink

From: Jiri Pirko Use devlink HW message notification facilities to pass massages going to and from HW to userspace via Netlink multicast. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/core.c | 15 +++

[patch net-next RFC 4/6] mlx4: Implement devlink interface

From: Jiri Pirko Implement newly introduced devlink interface. Add devlink port instances for every port and set the port types accordingly. Signed-off-by: Jiri Pirko --- drivers/infiniband/hw/mlx4/main.c | 7

[patch net-next RFC 2/6] mlxsw: Implement devlink interface

From: Jiri Pirko Implement newly introduced devlink interface. Add devlink port instances for every port and set the port types accordingly. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/core.c | 24 ++--

Re: [PATCH net] ipv6: fix a lockdep splat

On 03.02.2016 02:55, Eric Dumazet wrote: From: Eric Dumazet Silence lockdep false positive about rcu_dereference() being used in the wrong context. First one should use rcu_dereference_protected() as we own the spinlock. > Second one should be a normal assignation, as

Re: [PATCH v3] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

On Wed, Feb 03, 2016 at 02:21:46PM +0900, Byeoungwook Kim wrote: > Conditional codes in rtl_addr_delay() were improved in readability and > performance by using switch codes. > > Reviewed-by: Julian Calaby > Signed-off-by: Byeoungwook Kim >

[net-next PATCH 2/7] net: rework setup_tc ndo op to consume general tc operand

This patch updates setup_tc so we can pass additional parameters into the ndo op in a generic way. To do this we provide structured union and type flag. This lets each classifier and qdisc provide its own set of attributes without having to add new ndo ops or grow the signature of the callback.

[net-next PATCH 5/7] net: tc: helper functions to query action types

This is a helper function drivers can use to learn if the action type is a drop action. Signed-off-by: John Fastabend --- include/net/tc_act/tc_gact.h | 16 1 file changed, 16 insertions(+) diff --git a/include/net/tc_act/tc_gact.h

[net-next PATCH 4/7] net: add tc offload feature flag

Its useful to turn off the qdisc offload feature at a per device level. This gives us a big hammer to enable/disable offloading. More fine grained control (i.e. per rule) may be supported later. Signed-off-by: John Fastabend --- include/linux/netdev_features.h |3

[net-next PATCH 3/7] net: sched: add cls_u32 offload hooks for netdevs

This patch allows netdev drivers to consume cls_u32 offloads via the ndo_setup_tc ndo op. This works aligns with how network drivers have been doing qdisc offloads for mqprio. Signed-off-by: John Fastabend --- include/linux/netdevice.h |6 +++-

[net-next PATCH 1/7] net: rework ndo tc op to consume additional qdisc handle parameter

The ndo_setup_tc() op was added to support drivers offloading tx qdiscs however only support for mqprio was ever added. So we only ever added support for passing the number of traffic classes to the driver. This patch generalizes the ndo_setup_tc op so that a handle can be provided to indicate if

Re: [net-next PATCH 7/7] net: ixgbe: add support for tc_u32 offload

On Wed, Feb 03, 2016 at 01:29:59AM -0800, John Fastabend wrote: > This adds initial support for offloading the u32 tc classifier. This > initial implementation only implements a few base matches and actions > to illustrate the use of the infrastructure patches. > > However it is an interesting

Re: [PATCH iproute2] ipmonitor: match user option 'all' before 'all-nsid'

Le 03/02/2016 01:53, Roopa Prabhu a écrit : From: Roopa Prabhu 'ip monitor all' is broken on older kernels. This patch fixes 'ip monitor all' to match 'all' and not 'all-nsid'. It moves parsing arg 'all-nsid' to after parsing 'all'. Before: $ip monitor all

Re: [PATCH v3] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

Hi Sudip, This patch is exsisted depencency like next. http://marc.info/?l=linux-wireless=145447963305712=2 I wrote review and the followup patch. but i seem to that don't write a Cc document. Sorry for your confused. Regards, Byeoungwook. 2016-02-03 17:56 GMT+09:00 Sudip Mukherjee

Re: [PATCH v2 net 6/6] net: mvneta: Fix race condition during stopping

On Mon, 1 Feb 2016 14:07:47 +0100 Gregory CLEMENT wrote: > When stopping the port, the CPU notifier are still there whereas the > mvneta_stop_dev function calls mvneta_percpu_disable() on each CPUs. > It was possible to have a new CPU coming at this point which could be > racy. > > This patch

[PATCH net-next V2 5/6] e1000: call ndo_stop() instead of dev_close() when running offline selftest

Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the current behaviour is

[PATCH net-next V2 2/6] ixgbe: call ndo_stop() instead of dev_close() when running offline selftest

Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the current behaviour is

[PATCH net-next V2 4/6] igb: call ndo_stop() instead of dev_close() when running offline selftest

Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the current behaviour is

[PATCH net-next V2 6/6] e1000e: call ndo_stop() instead of dev_close() when running offline selftest

Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the current behaviour is

[PATCH net-next V2 0/6] net/intel: call ndo_stop() instead of dev_close() when running offline selftest

Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the current behaviour is

[PATCH net-next V2 1/6] i40e: call ndo_stop() instead of dev_close() when running offline selftest

Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the current behaviour is

[patch net-next 1/3] bridge: mdb: add support for offloaded mdb entries

From: Elad Raz Add new bitmask member 'flags' to br_mdb_entry structure. Adding MDB_FLAGS_OFFLOAD bit which indicates MDB entries is offloaded to hardware. Signed-off-by: Elad Raz Signed-off-by: Jiri Pirko ---

[patch net-next 2/3] bridge: mdb: Separate br_mdb_entry->state from net_bridge_port_group->state

From: Elad Raz Change net_bridge_port_group 'state' member to 'flags' and define new set of flags internal to the kernel. Signed-off-by: Elad Raz Signed-off-by: Jiri Pirko --- net/bridge/br_mdb.c | 16

[patch net-next 3/3] bridge: mdb: Passing the port-group pointer to br_mdb module

From: Elad Raz Passing the port-group to br_mdb in order to allow direct access to the structure. br_mdb will later use the structure to reflect HW reflection status via "state" variable. Signed-off-by: Elad Raz Signed-off-by: Jiri Pirko

[net-next PATCH 7/7] net: ixgbe: add support for tc_u32 offload

This adds initial support for offloading the u32 tc classifier. This initial implementation only implements a few base matches and actions to illustrate the use of the infrastructure patches. However it is an interesting subset because it handles the u32 next hdr logic to correctly map tcp

[net-next PATCH 6/7] net: ixgbe: add minimal parser details for ixgbe

This adds an ixgbe data structure that is used to determine what headers:fields can be matched and in what order they are supported. For hardware devices this can be a bit tricky because typically only pre-programmed (firmware, ucode, rtl) parse graphs will be supported and we don't yet have an

[net-next PATCH 0/7] tc offload for cls_u32 on ixgbe

This extends the setup_tc framework so it can support more than just the mqprio offload and push other classifiers and qdiscs into the hardware. The series here targets the u32 classifier and ixgbe driver. I worked out the u32 classifier because it is protocol oblivious and aligns with multiple

Re: [net-next PATCH 1/7] net: rework ndo tc op to consume additional qdisc handle parameter

Hi John, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/John-Fastabend/tc-offload-for-cls_u32-on-ixgbe/20160203-173342 config: x86_64-randconfig-x016-201605 (attached as .config) reproduce: # save the attached .config to linux build tree

Re: [net-next PATCH 0/7] tc offload for cls_u32 on ixgbe

On Wed, Feb 03, 2016 at 01:27:32AM -0800, John Fastabend wrote: > This extends the setup_tc framework so it can support more than just > the mqprio offload and push other classifiers and qdiscs into the > hardware. The series here targets the u32 classifier and ixgbe > driver. I worked out the u32

Re: [net-next PATCH 3/7] net: sched: add cls_u32 offload hooks for netdevs

Hi John, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/John-Fastabend/tc-offload-for-cls_u32-on-ixgbe/20160203-173342 config: i386-randconfig-x009-02010231 (attached as .config) reproduce: # save the attached .config to linux build tree

Re: [net-next PATCH 7/7] net: ixgbe: add support for tc_u32 offload

On 16-02-03 02:07 AM, Amir Vadai" wrote: > On Wed, Feb 03, 2016 at 01:29:59AM -0800, John Fastabend wrote: >> This adds initial support for offloading the u32 tc classifier. This >> initial implementation only implements a few base matches and actions >> to illustrate the use of the infrastructure

[patch net-next RFC 6/6] mlx4: Implement port type setting via devlink interface

From: Jiri Pirko So far, there has been an mlx4-specific sysfs file allowing user to change port type to either Ethernet of InfiniBand. This is very inconvenient. Allow to expose the same ability to set port type in a generic way using devlink interface. Signed-off-by: Jiri

Re: [PATCH net-next 2/4] net: dev: add batching to net_device notifiers

Hello, On Tue, 2 Feb 2016, Salam Noureddine wrote: > On Tue, Feb 2, 2016 at 12:55 PM, Julian Anastasov wrote: > > > > If the rule is once per net, the above call... > > > >> } > > > > should be here: > > > >

[PATCH net-next V2 3/6] ixgbevf: call ndo_stop() instead of dev_close() when running offline selftest

Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the current behaviour is

Re: [PATCH v3] net:Add sysctl_max_skb_frags

On 03.02.2016 12:25, Herbert Xu wrote: On Wed, Feb 03, 2016 at 09:26:57AM +0100, Hans Westgaard Ry wrote: Devices may have limits on the number of fragments in an skb they support. Current codebase uses a constant as maximum for number of fragments one skb can hold and use. When enabling

[3.16.y-ckt stable] Patch "=?UTF-8?q?veth:=20don=E2=80=99t=20modify=20ip=5Fsummed;=20doing?= =?UTF-8?q?=20so=20treats=20packets=20with=20bad=20checksums=20as=20good.?=" has been added to the 3.16.y-ck

This is a note to let you know that I have just added a patch titled =?UTF-8?q?veth:=20don=E2=80=99t=20modify=20ip=5Fsummed;=20doing?= =?UTF-8?q?=20so=20treats=20packets=20with=20bad=20checksums=20as=20good.?= to the linux-3.16.y-queue branch of the 3.16.y-ckt extended stable tree which

Re: [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it

On Wed, 3 Feb 2016 11:47:56 +0100 Jiri Pirko wrote: > From: Jiri Pirko > > There a is need for some userspace API that would allow to expose things > that are not directly related to any device class like net_device of > ib_device, but rather

[PATCH v2 12/15] ptp: pch: Allow build on MIPS platforms

Allow the ptp_pch driver to be built on MIPS platforms in preparation for use on the MIPS Boston board. Signed-off-by: Paul Burton Acked-by: Richard Cochran --- Changes in v2: None drivers/ptp/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 1/6] net: pch_gbe: Allow build on MIPS platforms

Allow the pch_gbe driver to be built on MIPS platforms, in preparation for its use on the MIPS Boston board. Signed-off-by: Paul Burton --- Changes in v2: None drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v2 0/6] pch_gbe fixes for Imagination Technologies MIPS Boston

This series has been extracted from an earlier larger series adding support for the Imagination Technologies MIPS Boston development board. The current version of that series without these patches included can be found here: http://marc.info/?l=linux-mips=145449909110835=2 This series is

Re: [net-next PATCH 7/7] net: ixgbe: add support for tc_u32 offload

On 16-02-03 05:26 AM, John Fastabend wrote: On 16-02-03 02:07 AM, Amir Vadai" wrote: On Wed, Feb 03, 2016 at 01:29:59AM -0800, John Fastabend wrote: This adds initial support for offloading the u32 tc classifier. This initial implementation only implements a few base matches and actions to

Re: [PATCH net-next] hv_netvsc: Increase delay for RNDIS_STATUS_NETWORK_CHANGE

Haiyang Zhang writes: > We simulates a link down period for RNDIS_STATUS_NETWORK_CHANGE message to > trigger DHCP renew. User daemons may need multiple seconds to trigger the > link down event. (e.g. ifplugd: 5sec, network-manager: 4sec.) So update > this link down period

Re: [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it

Wed, Feb 03, 2016 at 02:31:33PM CET, bro...@redhat.com wrote: >On Wed, 3 Feb 2016 11:47:56 +0100 >Jiri Pirko wrote: > >> From: Jiri Pirko >> >> There a is need for some userspace API that would allow to expose things >> that are not directly related to any

[RFC (v3) 10/19] nfp: cleanup tx ring flush and rename to reset

Since we never used flush without freeing the ring later the functionality of the two operations is mixed. Rename flush to ring reset and move there all the things which have to be done after FW ring state is cleared. While at it do some clean-ups. Signed-off-by: Jakub Kicinski

[RFC (v3) 05/19] nfp: don't trust netif_running() in debug code

Since change_mtu() can fail and leave us with netif_running() returning true even though all rings were freed - we should look at NFP_NET_CFG_CTRL_ENABLE flag to determine if device is really opened. Signed-off-by: Jakub Kicinski ---

[RFC (v3) 19/19] nfp: allow ring size reconfiguration at runtime

Since much of the required changes have already been made for changing MTU at runtime let's use it for ring size changes as well. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 1 +

[RFC (v3) 17/19] nfp: convert .ndo_change_mtu() to prepare/commit paradigm

When changing MTU on running device first allocate new rings and buffers and once it succeeds proceed with changing MTU. Allocation of new rings is not really necessary for this operation - it's done to keep the code simple and because size of the extra ring memory is quite small compared to the

[RFC (v3) 16/19] nfp: propagate list buffer size in struct rx_ring

Free list buffer size needs to be propagated to few functions as a parameter and added to struct nfp_net_rx_ring since soon some of the functions will be reused to manage rings with buffers of size different than nn->fl_bufsz. Signed-off-by: Jakub Kicinski ---

[RFC (v3) 18/19] nfp: pass ring count as function parameter

Soon ring resize will call this functions with values different than the current configuration we need to explicitly pass the ring count as parameter. Signed-off-by: Jakub Kicinski --- .../net/ethernet/netronome/nfp/nfp_net_common.c| 23 +-

Re: [net-next PATCH 1/7] net: rework ndo tc op to consume additional qdisc handle parameter

Hi John, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/John-Fastabend/tc-offload-for-cls_u32-on-ixgbe/20160203-173342 config: x86_64-allmodconfig (attached as .config) reproduce: # save the attached .config to linux build tree make

RE: [PATCH v2] unix: properly account for FDs passed over unix sockets

From: Linus Torvalds > Sent: 02 February 2016 20:45 > On Tue, Feb 2, 2016 at 12:32 PM, Hannes Frederic Sowa > wrote: > > > > Unfortunately we never transfer a scm_cookie via the skbs but merely use it > > to initialize unix_skb_parms structure in skb->cb and destroy it

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

On 03/02/16 11:56, David Herrmann wrote: > However, with Hannes' revised patch, a different DoS attack against > dbus-daemon is possible. Imagine a peer that receives batches of FDs, > but never dequeues them. They will be accounted on the inflight-limit > of dbus-daemon, as such causing messages

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

On 02/02/16 17:34, David Herrmann wrote: > Furthermore, with this patch in place, a process better not pass any > file-descriptors to an untrusted process. ... > Did anyone notify the dbus maintainers of this? They > might wanna document this, if not already done (CC: smcv). Sorry, I'm not clear

[RFC (v3) 02/19] nfp: free buffers before changing MTU

For freeing DMA buffers we depend on nfp_net.fl_bufsz having the same value as during allocation therefore in .ndo_change_mtu we must first free the buffers and then change the setting. Signed-off-by: Jakub Kicinski Reviewed-by: Rolf Neugebauer

[RFC (v3) 01/19] nfp: return error if MTU change fails

When reopening device fails after MTU change, let the userspace know. MTU remains changed even though error is returned, this is what all ethernet devices are doing. Signed-off-by: Jakub Kicinski Reviewed-by: Rolf Neugebauer ---

[RFC (v3) 14/19] nfp: slice .ndo_open() and .ndo_stop() up

Divide .ndo_open() and .ndo_stop() into logical, callable chunks. No functional changes. Signed-off-by: Jakub Kicinski --- .../net/ethernet/netronome/nfp/nfp_net_common.c| 213 + 1 file changed, 131 insertions(+), 82 deletions(-) diff

[RFC (v3) 07/19] nfp: break up nfp_net_{alloc|free}_rings

nfp_net_{alloc|free}_rings contained strange mix of allocations and vector initialization. Remove it, declare vector init as a separate function and handle allocations explicitly. Signed-off-by: Jakub Kicinski --- .../net/ethernet/netronome/nfp/nfp_net_common.c

[RFC (v3) 08/19] nfp: make *x_ring_init do all the init

nfp_net_[rt]x_ring_init functions used to be called from probe path only and some of their functionality was spilled to the call site. In order to reuse them for ring reconfiguration we need them to do all the init. Signed-off-by: Jakub Kicinski ---

[RFC (v3) 09/19] nfp: allocate ring SW structs dynamically

To be able to switch rings more easily on config changes allocate them dynamically, separately from nfp_net structure. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 6 ++--- .../net/ethernet/netronome/nfp/nfp_net_common.c

[RFC (v3) 06/19] nfp: move link state interrupt request/free calls

We need to be able to disable the link state interrupt when the device is brought down. We used to just free the IRQ at the beginning of .ndo_stop(). As we now move towards more ordered .ndo_open()/.ndo_stop() paths LSC allocation should be placed in the "allocate resource" section. Since the

[RFC (v3) 13/19] nfp: move filling ring information to FW config

nfp_net_[rt]x_ring_{alloc,free} should only allocate or free ring resources without touching the device. Move setting parameters in the BAR to separate functions. This will make it possible to reuse alloc/free functions to allocate new rings while the device is running. Signed-off-by: Jakub

[RFC (v3) 00/19] MTU changes and other fixes

Hi Dave, I'm posting this as RFC because I think +625/-339 of mostly code refactoring is not good for net, my intention is to show you I did the homework and then repost this as two parts - for net and for net-next. In retrospect I could've just asked you right away where you intend this series

[RFC (v3) 04/19] nfp: fix RX buffer length validation

Meaning of data_len and meta_len RX WB descriptor fields depend slightly on whether rx_offset is dynamic or not. For dynamic offsets data_len includes meta_len. This makes the code harder to follow, in fact our RX buffer length check is incorrect - we are comparing allocation length to data_len

[PATCH v2 2/6] net: pch_gbe: Mark Minnow PHY reset GPIO active low

The Minnow PHY reset GPIO is set to 0 to enter reset & 1 to leave reset - that is, it is an active low GPIO. In order to allow for the code to be made more generic by further patches, indicate to the GPIO subsystem that the GPIO is active low & invert the values it is set to such that they reflect

[PATCH v3] net:Add sysctl_max_skb_frags

Devices may have limits on the number of fragments in an skb they support. Current codebase uses a constant as maximum for number of fragments one skb can hold and use. When enabling scatter/gather and running traffic with many small messages the codebase uses the maximum number of fragments and

Re: [PATCH net-next v5 2/2] virtio_net: add ethtool support for set and get of settings

On 02/03/2016 04:04 AM, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > This patch allows the user to set and retrieve speed and duplex of the > virtio_net device via ethtool. Having this functionality is very helpful > for simulating different

RE: bnx2x commits needed to use 7.51.10 firmware?

+Yuval > -Original Message- > From: Dan Streetman [mailto:dan.street...@canonical.com] > Sent: Wednesday, February 03, 2016 2:20 AM > To: Ariel Elior > Cc: netdev > Subject: bnx2x commits needed to use 7.51.10 firmware? > > Hi Ariel, > >

Re: [net-next PATCH 0/7] tc offload for cls_u32 on ixgbe

On 16-02-03 02:11 AM, Amir Vadai" wrote: > On Wed, Feb 03, 2016 at 01:27:32AM -0800, John Fastabend wrote: >> This extends the setup_tc framework so it can support more than just >> the mqprio offload and push other classifiers and qdiscs into the >> hardware. The series here targets the u32

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

On 03.02.2016 12:36, Simon McVittie wrote: On 02/02/16 17:34, David Herrmann wrote: Furthermore, with this patch in place, a process better not pass any file-descriptors to an untrusted process. ... Did anyone notify the dbus maintainers of this? They might wanna document this, if not already

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

Hi On Wed, Feb 3, 2016 at 12:36 PM, Simon McVittie wrote: > Am I right in saying that the advice I give to D-Bus users should be > something like this? > > * system services should not send fds at all, unless they trust the > dbus-daemon > * system services

[PATCH v2 6/6] net: pch_gbe: Allow longer for resets

Resets of the EG20T MAC on the MIPS Boston development board take longer than the 1000 loops that pch_gbe_wait_clr_bit was performing. Bump up the number of loops. Signed-off-by: Paul Burton --- Changes in v2: None drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c

[PATCH v2 4/6] net: pch_gbe: Always reset PHY along with MAC

On the MIPS Boston development board, the EG20T MAC does not report receiving the RX clock from the (RGMII) RTL8211E PHY unless the PHY is reset at the same time as the MAC. Since the pch_gbe driver resets the MAC a number of times - twice during probe, and when taking down the network interface -

[PATCH v2 3/6] net: pch_gbe: Pull PHY GPIO handling out of Minnow code

The MIPS Boston development board uses the Intel EG20T Platform Controller Hub, including its gigabit ethernet controller, and requires that its RTL8211E PHY be reset much like the Minnow platform. Pull the PHY reset GPIO handling out of Minnow-specific code such that it can be shared by later

[PATCH v2 5/6] net: pch_gbe: Add device tree support

Introduce support for retrieving the PHY reset GPIO from device tree, which will be used on the MIPS Boston development board. This requires support for probe deferral in order to work correctly, since the order of device probe is not guaranteed & typically the EG20T GPIO controller device will be

[PATCH net-next] bonding: 3ad: apply ad_actor settings changes immediately

From: Nikolay Aleksandrov Currently the bonding allows to set ad_actor_system and prio while the bond device is down, but these are actually applied only if there aren't any slaves yet (applied to bond device when first slave shows up, and to slaves at 3ad bind

Re: [PATCH] flowi: add concept of "not_oif"

Hello, On Wed, 3 Feb 2016, Jason A. Donenfeld wrote: > This patch simply adds support for specifying a "not_oif" device in > flowi4 and flowi6 lookups, that will find a matching route that _isn't_ > via the specified device. If you check every flowi4_oif user you will notice

Re: [PATCH] of: of_mdio: Add marvell,88e1145 to whitelist of PHY compatibilities.

Hi, On Wed, Feb 03, 2016 at 09:08:57PM +0100, Andrew Lunn wrote: > On Wed, Feb 03, 2016 at 09:35:29PM +0200, Aaro Koskinen wrote: > > Commit ae461131960b ("of: of_mdio: Add a whitelist of PHY > > compatibilities.") missed one compatible string used in in-tree DTBs: > > in OCTEON, for selected

[PATCH net 4/4] net: phy: bcm7xxx: Make MII_BCM7XX_64CLK_MDIO naming consistent

The driver is BCM7xxx, we were missing an additional X in the constant naming, fix that to be consistent. Signed-off-by: Florian Fainelli --- drivers/net/phy/bcm7xxx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/bcm7xxx.c

[PATCH net 1/4] net: phy: bcm7xxx: Fix shadow mode 2 disabling

The clear and set masks in the call to phy_set_clr_bits() called from bcm7xxx_config_init() are inverted. We need to fix this by swapping the two arguments, that is, set 0 bits, but clear the shade mode 2 enable bit. Fixes: b560a58c45c66 ("net: phy: add Broadcom BCM7xxx internal PHY driver")

[PATCH net 2/4] net: phy: bcm7xxx: Fix 40nm EPHY features

The PHY entries for BCM7425/29/35 declare the 40nm Ethernet PHY as being 10/100/1000 capable, while this is just a 10/100 capable PHY device, fix that. Fixes: d068b02cfdfc2 ("net: phy: add BCM7425 and BCM7429 PHYs") Fixes: 9458ceab4917 ("net: phy: bcm7xxx: Add entry for BCM7435") Signed-off-by:

[PATCH net 0/4] net: phy: bcm7xxx 40nm PHY fixes

Hi David, Here is a collection of fixes for the 40nm Ethernet PHY supported by the 7xxx PHY driver, please also queue these fixes for stable. Let me know if you think patch 4 is too much of a cleanup to be taken as a fix. Thanks! Florian Fainelli (4): net: phy: bcm7xxx: Fix shadow mode 2

Re: [PATCH] flowi: add concept of "not_oif"

Hi Julian, Thanks a lot for your review. Much appreciated. On Wed, Feb 3, 2016 at 9:42 PM, Julian Anastasov wrote: > If you check every flowi4_oif user you will notice > that some places can not fulfil this requirement: > - fib_select_path -> fib_select_multipath >

[PATCH] net: ethernet: davicom: fix devicetree irq resource

The dm9000 driver doesn't work in at least one device-tree configuration, spitting an error message on irq resource : [1.062495] dm9000 800.ethernet: insufficient resources [1.068439] dm9000 800.ethernet: not found (-2). [1.073451] dm9000: probe of 800.ethernet failed with

Re: Keystone 2 boards boot failure

On Wednesday 03 February 2016 18:31:00 Grygorii Strashko wrote: > On 02/03/2016 06:20 PM, Arnd Bergmann wrote: > > On Wednesday 03 February 2016 16:21:05 Grygorii Strashko wrote: > >> On 02/03/2016 04:11 PM, Franklin S Cooper Jr. wrote: > >>> On 02/02/2016 07:19 PM, Franklin S Cooper Jr. wrote: >

Re: Keystone 2 boards boot failure

On Wednesday 03 February 2016 11:41:40 Murali Karicheri wrote: > > > > This looks wrong: I was getting the build warnings originally > > because of 64-bit dma_addr_t, and that should be the only way that > > this driver can operate, because in some configurations on keystone > > there is no

[PATCH net 3/4] net: phy: bcm7xxx: Fix bcm7xxx_config_init() check

Since we were wrongly advertising gigabit features for these 10/100 only Ethernet PHYs, bcm7xxx_config_init() which is supposed to apply workaround would have not run since the check would be true, now that we have fixed the PHY features, remove that check since it has no reasoning to be there

Re: [PATCH net-next] sxgbe: remove unused code

On 02/03/2016 01:11 PM, Jεan Sacren wrote: > From: Jean Sacren > > With the introduction of this commit 1edb9ca69e8a > ("net: sxgbe: add basic framework for Samsung 10Gb ethernet driver"), > the following interface was added: > > int sxgbe_xpcs_init(struct net_device

Re: [PATCH] of: of_mdio: Add marvell,88e1145 to whitelist of PHY compatibilities.

> The compatibility strings may be present in deployed firmware, they > cannot be removed. For many OCTEON boards, the device tree is a > firmware-kernel ABI, it is not practical to unilaterally decide to > change the bindings on the kernel side as you don't control the > firmware. Hi David We

Re: [PATCH] of: of_mdio: Add marvell,88e1145 to whitelist of PHY compatibilities.

On 02/03/2016 12:08 PM, Andrew Lunn wrote: On Wed, Feb 03, 2016 at 09:35:29PM +0200, Aaro Koskinen wrote: Commit ae461131960b ("of: of_mdio: Add a whitelist of PHY compatibilities.") missed one compatible string used in in-tree DTBs: in OCTEON, for selected boards, the kernel DTB pruning code

  1   2   3   >