[PATCH v4 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-02-16 Thread Bendik Rønning Opstad
RDB is a mechanism that enables a TCP sender to bundle redundant (already sent) data with TCP packets containing new data. By bundling (retransmitting) already sent data with each TCP packet containing new data, the connection will be more resistant to sporadic packet loss which reduces the

[PATCH v4 net-next 0/2] tcp: Redundant Data Bundling (RDB)

2016-02-16 Thread Bendik Rønning Opstad
Redundant Data Bundling (RDB) is a mechanism for TCP aimed at reducing the latency for applications sending time-dependent data. Latency-sensitive applications or services, such as online games and remote desktop, produce traffic with thin-stream characteristics, characterized by small packets

[PATCH net v4]r8169: Correcting start poll() operations.

2016-02-16 Thread Corcodel Marian
This patch enable poll operations when chip is ready. poll op. Will start after autoneg process, after transmission is started. Signed-off-by: Corcodel Marian --- drivers/net/ethernet/realtek/r8169.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [patch net-next 00/13] rocker: do world split

2016-02-16 Thread Jiri Pirko
Tue, Feb 16, 2016 at 01:55:25PM CET, j...@resnulli.us wrote: >From: Jiri Pirko > >This patchset allows new rocker worlds to be easily added in future. >Two new worlds are now under development: P4 and eBPF. > >The main part of the patchset is the OF-DPA carve-out. It resuts in

[patch net-next v2 13/13] rocker: return -EOPNOTSUPP for undefined world ops

2016-02-16 Thread Jiri Pirko
Suggested-by: Scott Feldman Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker_main.c | 33 --- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/rocker/rocker_main.c

[patch net-next v2 02/13] rocker: rename rocker.h to rocker_hw.h

2016-02-16 Thread Jiri Pirko
From: Jiri Pirko Since "rocker.h" file is going to be used for different purpose, rename the hardware-specific header to "rocker_hw.h". Signed-off-by: Jiri Pirko Acked-by: Scott Feldman --- drivers/net/ethernet/rocker/rocker.c| 2

[patch net-next v2 09/13] rocker: pre-allocate wait structures during cmd ring init

2016-02-16 Thread Jiri Pirko
From: Jiri Pirko This avoids need to alloc/free wait structure for every command call. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker_main.c | 87 +++ 1 file changed, 66 insertions(+), 21 deletions(-) diff

Re: [PATCH net-next 1/3] lwtunnel: autoload of lwt modules

2016-02-16 Thread Robert Shearman
On 15/02/16 21:33, Eric W. Biederman wrote: Robert Shearman writes: @@ -85,6 +109,14 @@ int lwtunnel_build_state(struct net_device *dev, u16 encap_type, ret = -EOPNOTSUPP; rcu_read_lock(); ops = rcu_dereference(lwtun_encaps[encap_type]); +#ifdef

[patch net-next v2 10/13] rocker: remove trans parameter to rocker_cmd_exec function

2016-02-16 Thread Jiri Pirko
From: Jiri Pirko The only purpose of passing this parameter is to check for prepare phase. The only reason for a failure in that state is if TLVs don't fit into descriptor. That is highly unlikely and if that happens, it is a driver bug. So remove this parameter from

[patch net-next v2 00/13] rocker: do world split

2016-02-16 Thread Jiri Pirko
From: Jiri Pirko This patchset allows new rocker worlds to be easily added in future. Two new worlds are now under development: P4 and eBPF. The main part of the patchset is the OF-DPA carve-out. It resuts in OF-DPA specific file. Clean cut. Note this patchset is based on my

[patch net-next v2 08/13] rocker: pass "learning" value as a parameter to rocker_port_set_learning

2016-02-16 Thread Jiri Pirko
From: Jiri Pirko Be consistent with the rest of the setting functions, and pass "learning" as a bool function parameter. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker_main.c | 14 +- 1 file changed, 9 insertions(+), 5

[patch net-next v2 06/13] rocker: move rocker and rocker_port structs into header

2016-02-16 Thread Jiri Pirko
From: Jiri Pirko And take some other related thing along. They are going to be pushed into of-dpa part anyway. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker.h | 75 +++

[patch net-next v2 05/13] rocker: implement get settings mode command

2016-02-16 Thread Jiri Pirko
From: Jiri Pirko Introduce a helper to ask HW for the port mode (world). Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker_main.c | 32 +++ 1 file changed, 32 insertions(+) diff --git

[patch net-next v2 07/13] rocker: introduce worlds infrastructure

2016-02-16 Thread Jiri Pirko
From: Jiri Pirko This is another step on the way to per-world clean cut. Introduce world ops hooks which each world can implement in world-specific way. Also introduce world infrastructure along with OF-DPA world stub. Signed-off-by: Jiri Pirko ---

[patch net-next v2 04/13] rocker: push tlv processing into separate files

2016-02-16 Thread Jiri Pirko
From: Jiri Pirko Carve out TLV processing helpers into separate files. Signed-off-by: Jiri Pirko Acked-by: Scott Feldman --- drivers/net/ethernet/rocker/Makefile | 2 +- drivers/net/ethernet/rocker/rocker.h | 27

[patch net-next v2 11/13] rocker: call rocker_cmd_exec function with "nowait" boolean instead of flags

2016-02-16 Thread Jiri Pirko
From: Jiri Pirko No need to push down rocker flags just to check if this is nowait or not. Let the caller handle that. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker_main.c | 38 +++ 1 file changed, 23

[patch net-next v2 01/13] rocker: remove unused rocker_port param from alloc funcs and shorten their names

2016-02-16 Thread Jiri Pirko
From: Jiri Pirko No need to pass rocker_port around to alloc/free rocker functions, since they now use switchdev_trans for memory management storage. With the param removal, shorten the name of the functions since they now has nothing to do with rocker port. Signed-off-by:

Re: [PATCH net-next] net: macb: make magic-packet property generic

2016-02-16 Thread Sergei Shtylyov
Hello. On 2/16/2016 3:13 AM, Sergio Prado wrote: Signed-off-by: Sergio Prado --- As requested by Rob Herring on patch https://patchwork.ozlabs.org/patch/580862/ --- Documentation/devicetree/bindings/net/macb.txt | 2 +- drivers/net/ethernet/cadence/macb.c

[PATCH v2 1/3] vhost: fix error path in vhost_init_used()

2016-02-16 Thread Greg Kurz
We don't want side effects. If something fails, we rollback vq->is_le to its previous value. Signed-off-by: Greg Kurz --- drivers/vhost/vhost.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/vhost/vhost.c

[PATCH v2 0/3] vhost: cross-endian code cleanup

2016-02-16 Thread Greg Kurz
This series is a new tentative to have cleaner cross-endian code. Patches 1/3 is new: it fixes a side-effect in case vhost_init_used() fails. Patch 2/3 comes from v1: it renames cross-endian helpers Patch 3/3 is new: it simply renames vhost_init_used() as suggested by Michael. --- Greg Kurz

[PATCH v2 3/3] vhost: rename vhost_init_used()

2016-02-16 Thread Greg Kurz
Looking at how callers use this, maybe we should just rename init_used to vhost_vq_init_access. The _used suffix was a hint that we access the vq used ring. But maybe what callers care about is that it must be called after access_ok. Also, this function manipulates the vq->is_le field which isn't

[PATCH v2 2/3] vhost: rename cross-endian helpers

2016-02-16 Thread Greg Kurz
The default use case for vhost is when the host and the vring have the same endianness (default native endianness). But there are cases where they differ and vhost should byteswap when accessing the vring. The first case is when the host is big endian and the vring belongs to a virtio 1.0 device,

[PATCH net 0/6] Mellanox 10/40G mlx4 driver fixes for 4.5-rc

2016-02-16 Thread Or Gerlitz
Hi Dave, Bunch of fixes from the team to the mlx4 Eth and core drivers. Series generated against net commit db92ea5 "dscc4: Undefined signed int shift" Or. Amir Vadai (1): net/mlx4_en: Do not count dropped packets twice Daniel Jurgens (1): net/mlx4_core: Do not BUG_ON during reset when

[PATCH net 6/6] net/mlx4_en: Avoid changing dev->features directly in run-time

2016-02-16 Thread Or Gerlitz
From: Eugenia Emantayev It's forbidden to manually change dev->features in run-time. Currently, this is done in the driver to make sure that GSO_UDP_TUNNEL is advertized only when VXLAN tunnel is set. However, since the stack actually does features intersection with

[PATCH net 4/6] net/mlx4_core: Do not BUG_ON during reset when PCI is offline

2016-02-16 Thread Or Gerlitz
From: Daniel Jurgens The PCI channel could go offline during reset due to EEH. Don't bug on in this case, the error is recoverable. Fixes: f6bc11e42646 ('net/mlx4_core: Enhance the catas flow to support device reset') Signed-off-by: Daniel Jurgens

[PATCH net 3/6] net/mlx4_core: Fix potential corruption in counters database

2016-02-16 Thread Or Gerlitz
From: Eran Ben Elisha The error flow in procedure handle_existing_counter() is wrong. The procedure should exit after encountering the error, not continue as if everything is OK. Fixes: 68230242cdbc ('net/mlx4_core: Add port attribute when tracking counters')

[PATCH net 5/6] net/mlx4_core: Set UAR page size to 4KB regardless of system page size

2016-02-16 Thread Or Gerlitz
From: Huy Nguyen problem description: The current code sets UAR page size equal to system page size. The ConnectX-3 and ConnectX-3 Pro HWs require minimum 128 UAR pages. The mlx4 kernel drivers are not loaded if there is less than 128 UAR pages. solution: Always set UAR

pull request [net]: batman-adv 20160216

2016-02-16 Thread Antonio Quartulli
Hello David, this pull request is intended for net. Two of the fixes included in this patchset prevent a wrong memory access - it was triggered when removing an object from a list after it was already free'd due to bad reference counting. This misbehaviour existed for both the gw_node and the

[PATCH net 2/6] net/mlx4_en: Choose time-stamping shift value according to HW frequency

2016-02-16 Thread Or Gerlitz
From: Eugenia Emantayev Previously, the shift value used for time-stamping was constant and didn't depend on the HW chip frequency. Change that to take the frequency into account and calculate the maximal value in cycles per wraparound of ten seconds. This time slot was

[PATCH 3/3] batman-adv: Avoid endless loop in bat-on-bat netdevice check

2016-02-16 Thread Antonio Quartulli
From: Andrew Lunn batman-adv checks in different situation if a new device is already on top of a different batman-adv device. This is done by getting the iflink of a device and all its parent. It assumes that this iflink is always a parent device in an acyclic graph. But this

[PATCH 2/3] batman-adv: Only put orig_node_vlan list reference when removed

2016-02-16 Thread Antonio Quartulli
From: Sven Eckelmann The batadv_orig_node_vlan reference counter in batadv_tt_global_size_mod can only be reduced when the list entry was actually removed. Otherwise the reference counter may reach zero when batadv_tt_global_size_mod is called from two different contexts for

[PATCH 1/3] batman-adv: Only put gw_node list reference when removed

2016-02-16 Thread Antonio Quartulli
From: Sven Eckelmann The batadv_gw_node reference counter in batadv_gw_node_update can only be reduced when the list entry was actually removed. Otherwise the reference counter may reach zero when batadv_gw_node_update is called from two different contexts for the same

[PATCH net 1/6] net/mlx4_en: Do not count dropped packets twice

2016-02-16 Thread Or Gerlitz
From: Amir Vadai RdropOvflw counter was mistakenly copied into rx_missed_errors. Because of that it was counted twice for the device dropped packets accounting. Fixes: c27a02cd94d6 ('mlx4_en: Add driver for Mellanox ConnectX 10GbE NIC') Signed-off-by: Amir Vadai

[PATCH iproute2 1/5] iplink: bridge_slave: export read-only values

2016-02-16 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Export all the read-only values that get returned about a bridge port such as the timers, the ids, designated_port and cost, topology_change_ack and config_pending. For the bridge ids the br_dump_bridge_id function is exported from

[PATCH iproute2 3/5] iplink: bridge_slave: add support for IFLA_BRPORT_PROXYARP_WIFI

2016-02-16 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add support to be able to view and change IFLA_BRPORT_PROXYARP_WIFI port attribute. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge_slave.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH iproute2 4/5] iplink: bridge_slave: add support for IFLA_BRPORT_MULTICAST_ROUTER

2016-02-16 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add support to be able to view and change IFLA_BRPORT_MULTICAST_ROUTER port attribute. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge_slave.c | 13 + 1 file changed, 13 insertions(+) diff

[PATCH iproute2 2/5] iplink: bridge_slave: add support for IFLA_BRPORT_PROXYARP

2016-02-16 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add support to be able to view and change IFLA_BRPORT_PROXYARP port attribute. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge_slave.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH net-next] net: bridge: log port STP state on change

2016-02-16 Thread Vivien Didelot
Remove the shared br_log_state function and print the info directly in br_set_state, where the net_bridge_port state is actually changed. Signed-off-by: Vivien Didelot --- net/bridge/br_netlink.c | 1 - net/bridge/br_private.h | 1 -

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-16 Thread João Paulo Rechi Vita
On 10 February 2016 at 12:12, Johannes Berg wrote: > On 2016-02-10 17:53, Dan Williams wrote: >> >> Yeah, I get that now. It's just that to me, something called >> "AIRPLANE_MODE_CHANGE" seems like it should actually change airplane >> mode on/off, which implies

[PATCH iproute2 5/5] iplink: bridge_slave: add support for IFLA_BRPORT_FAST_LEAVE

2016-02-16 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add support to be able to view and change IFLA_BRPORT_FAST_LEAVE port attribute. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge_slave.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH iproute2 0/5] bridge: complete port netlink support

2016-02-16 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, This small set completes the port netlink support for iproute2 and allows to view and set all the available netlink port attributes. Cheers, Nik Nikolay Aleksandrov (5): iplink: bridge_slave: export read-only values iplink:

Re: [net-next PATCH v2 1/1] net_sched fix: reclassification needs to consider ether protocol changes

2016-02-16 Thread Daniel Borkmann
On 02/16/2016 01:37 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim actions could change the etherproto in particular with ethernet tunnelled data. Typically such actions, after peeling the outer header, will ask for the packet to be reclassified. We then need to restart

Re: [PATCH] net: ipv6: Make address flushing on ifdown optional

2016-02-16 Thread David Ahern
On 2/16/16 1:45 AM, YOSHIFUJI Hideaki wrote: >> diff --git a/Documentation/networking/ip-sysctl.txt >> b/Documentation/networking/ip-sysctl.txt >> index 24ce97f42d35..7ddbbb67f0db 100644 >> --- a/Documentation/networking/ip-sysctl.txt >> +++ b/Documentation/networking/ip-sysctl.txt >> @@ -1563,6

Re: wlcore: Fix regression in wlcore_set_partition()

2016-02-16 Thread Kalle Valo
Ross Green writes: > On Fri, Feb 12, 2016 at 8:45 PM, Kalle Valo wrote: >> >>> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a >>> regression causing the wlcore to time out and go into recovery. Reverting >>> the >>> changes

Re: [PATCH v3] phy: marvell: Fix and unify reg-init behavior

2016-02-16 Thread Andrew Lunn
On Mon, Feb 15, 2016 at 11:46:45PM +0100, Clemens Gruber wrote: > For the Marvell 88E1510, marvell_of_reg_init was called too late, in the > config_aneg function. > Since commit 113c74d83eef ("net: phy: turn carrier off on phy attach"), > this lead to the link not coming up at boot anymore, due to

[PATCH v2 net-next 0/8] API set for HW Buffer management

2016-02-16 Thread Gregory CLEMENT
Hello, A few weeks ago I sent a proposal for a API set for HW Buffer management, to have a better view of the motivation for this API see the cover letter of this proposal: http://thread.gmane.org/gmane.linux.kernel/2125152 Since this version I took into account the review from Florian: - The

Re: [PATCH v2 0/3] vhost: cross-endian code cleanup

2016-02-16 Thread Michael S. Tsirkin
On Tue, Feb 16, 2016 at 03:54:18PM +0100, Greg Kurz wrote: > This series is a new tentative to have cleaner cross-endian code. > > Patches 1/3 is new: it fixes a side-effect in case vhost_init_used() fails. > > Patch 2/3 comes from v1: it renames cross-endian helpers > > Patch 3/3 is new: it

[PATCH v2 2/8] ARM: dts: armada-38x: enable buffer manager support on Armada 38x boards

2016-02-16 Thread Gregory CLEMENT
From: Marcin Wojtas Since mvneta driver supports using hardware buffer management (BM), in order to use it, board files have to be adjusted accordingly. This commit enables BM on: * A385-DB-AP - each port has its own pool for long and common pool for short packets, *

[PATCH v2 net-next 6/8] net: mvneta: bm: add support for hardware buffer management

2016-02-16 Thread Gregory CLEMENT
From: Marcin Wojtas Buffer manager (BM) is a dedicated hardware unit that can be used by all ethernet ports of Armada XP and 38x SoC's. It allows to offload CPU on RX path by sparing DRAM access on refilling buffer pool, hardware-based filling of descriptor ring data and

[PATCH v2 net-next 8/8] net: mvneta: Use the new hwbm framework

2016-02-16 Thread Gregory CLEMENT
Now that the hardware buffer management framework had been introduced, let's use it. Signed-off-by: Gregory CLEMENT --- drivers/net/ethernet/marvell/Kconfig | 1 + drivers/net/ethernet/marvell/mvneta.c| 45 +++---

[PATCH v2 net-next 7/8] net: add a hardware buffer management helper API

2016-02-16 Thread Gregory CLEMENT
This basic implementation allows to share code between driver using hardware buffer management. As the code is hardware agnostic, there is few helpers, most of the optimization brought by the an HW BM has to be done at driver level. Signed-off-by: Gregory CLEMENT

[PATCH v2 net-next 5/8] bus: mvebu-mbus: provide api for obtaining IO and DRAM window information

2016-02-16 Thread Gregory CLEMENT
From: Marcin Wojtas This commit enables finding appropriate mbus window and obtaining its target id and attribute for given physical address in two separate routines, both for IO and DRAM windows. This functionality is needed for Armada XP/38x Network Controller's Buffer

[PATCH v2 1/8] ARM: dts: armada-38x: add buffer manager nodes

2016-02-16 Thread Gregory CLEMENT
From: Marcin Wojtas Armada 38x network controller supports hardware buffer management (BM). Since it is now enabled in mvneta driver, appropriate nodes can be added to armada-38x.dtsi - for the actual common BM unit (bm@c8000) and its internal SRAM (bm-bppi), which is used for

[PATCH v2 3/8] ARM: dts: armada-xp: add buffer manager nodes

2016-02-16 Thread Gregory CLEMENT
From: Marcin Wojtas Armada XP network controller supports hardware buffer management (BM). Since it is now enabled in mvneta driver, appropriate nodes can be added to armada-xp.dtsi - for the actual common BM unit (bm@c) and its internal SRAM (bm-bppi), which is used for

[PATCH v2 4/8] ARM: dts: armada-xp: enable buffer manager support on Armada XP boards

2016-02-16 Thread Gregory CLEMENT
From: Marcin Wojtas Since mvneta driver supports using hardware buffer management (BM), in order to use it, board files have to be adjusted accordingly. This commit enables BM on AXP-DB and AXP-GP in same manner - because number of ports on those boards is the same as number

Re: [PATCH net-next 1/2] mpls: packet stats

2016-02-16 Thread David Miller
Statistics not provided via netlink are useless in real installations. In fact I would say to forego the proc interface entirely, it's a second class citizen for statistics gathering and has a non-triviel per-device cost for instantiation.

Re: [PATCH v2 0/3] vhost: cross-endian code cleanup

2016-02-16 Thread Greg Kurz
On Tue, 16 Feb 2016 17:34:13 +0200 "Michael S. Tsirkin" wrote: > On Tue, Feb 16, 2016 at 03:54:18PM +0100, Greg Kurz wrote: > > This series is a new tentative to have cleaner cross-endian code. > > > > Patches 1/3 is new: it fixes a side-effect in case vhost_init_used() fails.

[PATCH] net: igmp: use IS_ENABLED(CONFIG_IP_MULTICAST) instead of ifdef

2016-02-16 Thread Arnd Bergmann
A recent change to use correct network namespace in net/ipv4/igmp.c caused a couple of harmless build warnings when CONFIG_MULTICAST is disabled: net/ipv4/igmp.c: In function 'igmp_group_added': net/ipv4/igmp.c:1227:14: error: unused variable 'net' [-Werror=unused-variable] net/ipv4/igmp.c: In

[PATCH net-next 2/5] bnx2x: Add Geneve inner-RSS support

2016-02-16 Thread Yuval Mintz
This adds the ability to perform RSS hashing based on encapsulated headers for a geneve-encapsulated packet. This also changes the Vxlan implementation in bnx2x to be uniform for both vxlan and geneve [from configuration perspective]. Signed-off-by: Yuval Mintz

[PATCH net-next 0/5] bnx2x: driver updates

2016-02-16 Thread Yuval Mintz
This series contains several changes - the biggest change is the addition of Geneve NDO support [allows device to perform RSS according to inner-headers of encapsulated packet, similar to what it does for vxlan]. It also extends dcbx support, as well as introducing some minor changes. Dave,

[PATCH net-next 1/5] bnx2x: Remove unneccessary EXPORT_SYMBOL

2016-02-16 Thread Yuval Mintz
bnx2x_schedule_sp_rtnl is exported by bnx2x, although no other module uses it. Reported-by: Benjamin Poirier Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 1 - 1

Re: [PATCH] net: igmp: use IS_ENABLED(CONFIG_IP_MULTICAST) instead of ifdef

2016-02-16 Thread Nikolay Borisov
On 02/16/2016 05:59 PM, Arnd Bergmann wrote: > A recent change to use correct network namespace in net/ipv4/igmp.c > caused a couple of harmless build warnings when CONFIG_MULTICAST is > disabled: > > net/ipv4/igmp.c: In function 'igmp_group_added': > net/ipv4/igmp.c:1227:14: error: unused

[PATCH net-next 4/5] bnx2x: extend DCBx support

2016-02-16 Thread Yuval Mintz
This adds support for default application priority. Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c | 57 +++-- drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h | 5 ++-

[PATCH net-next 5/5] bnx2x: Warn about grc timeouts in register dump

2016-02-16 Thread Yuval Mintz
There are several scenarios where taking a register dump from a device might log benign GRC timeout attentions to system logs. Most common of those is when taking the dump from a 2-port device. Sadly, there's no easy way to mask the problematic attentions during the flow - Changing this behvaior

[PATCH net-next 3/5] bnx2x: Add support for single-port DCBx

2016-02-16 Thread Yuval Mintz
Driver is currently looking at shared information for determining whether DCBx can be supported for a given port. On 4-port devices, up-to-date management firmware can support DCBx on each port of a given engine independently - but that would cause bnx2x to misinterpert the support and assume DCBx

[PATCH v2] net: igmp: use IS_ENABLED(CONFIG_IP_MULTICAST) instead of ifdef

2016-02-16 Thread Arnd Bergmann
A recent change to use correct network namespace in net/ipv4/igmp.c caused a couple of harmless build warnings when CONFIG_MULTICAST is disabled: net/ipv4/igmp.c: In function 'igmp_group_added': net/ipv4/igmp.c:1227:14: error: unused variable 'net' [-Werror=unused-variable] net/ipv4/igmp.c: In

Re: [PATCH] net: igmp: use IS_ENABLED(CONFIG_IP_MULTICAST) instead of ifdef

2016-02-16 Thread Arnd Bergmann
On Tuesday 16 February 2016 18:10:52 Nikolay Borisov wrote: > On 02/16/2016 05:59 PM, Arnd Bergmann wrote: > > @@ -1821,17 +1807,15 @@ static int ip_mc_del_src(struct in_device *in_dev, > > __be32 *pmca, int sfmode, > > if (!err && rv < 0) > > err = rv; > > } >

Re: [PATCH net v2 2/3] geneve: Relax MTU constraints

2016-02-16 Thread Tom Herbert
On Tue, Feb 16, 2016 at 4:33 AM, David Wragg wrote: > Jesse Gross writes: >> On Wed, Feb 10, 2016 at 3:21 PM, Tom Herbert wrote: >>> On Wed, Feb 10, 2016 at 12:59 PM, Jesse Gross wrote: On Wed, Feb 10, 2016 at

Re: [patch net-next RFC 4/6] mlx4: Implement devlink interface

2016-02-16 Thread Or Gerlitz
On 2/3/2016 12:48 PM, Jiri Pirko wrote: Implement newly introduced devlink interface. Add devlink port instances for every port and set the port types accordingly. Lets see how to use the newly introduced interface in a way which would allow us to get a configuration profile from user-space

Re: [PATCH net-next 08/10] bus: mvenus-mbus: Fix size test for mvebu_mbus_get_dram_win_info

2016-02-16 Thread Gregory CLEMENT
Hi David, On jeu., janv. 14 2016, David Laight wrote: > From: Gregory CLEMENT >> Sent: 12 January 2016 19:11 >> Signed-off-by: Gregory CLEMENT >> --- >> drivers/bus/mvebu-mbus.c | 2 +- >> 1 file changed, 1 insertion(+), 1

Re: [patch net-next RFC 4/6] mlx4: Implement devlink interface

2016-02-16 Thread Jiri Pirko
Tue, Feb 16, 2016 at 05:43:53PM CET, ogerl...@mellanox.com wrote: >On 2/3/2016 12:48 PM, Jiri Pirko wrote: >>Implement newly introduced devlink interface. Add devlink port instances >>for every port and set the port types accordingly. >> > >Lets see how to use the newly introduced interface in a

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V2

2016-02-16 Thread Andrew Lunn
On Sat, Feb 13, 2016 at 11:04:45PM +0100, John Holland wrote: > Hello, > > The Intel i211 LOM pcie ethernet controllers' iNVM operates as an > OTP and has no externel EEPROM interface [1]. The following allows > the driver to pickup the MAC address from a device tree blob when > CONFIG_OF has

[PATCH 0/6] Netfilter fixes for net

2016-02-16 Thread Pablo Neira Ayuso
Hi David, The following patchset contain a rather large batch for your net that includes accumulated bugfixes, they are: 1) Run conntrack cleanup from workqueue process context to avoid hitting soft lockup via watchdog for large tables. This is required by the IPv6 masquerading extension.

[PATCH 2/6] netfilter: nfnetlink: use original skbuff when acking batches

2016-02-16 Thread Pablo Neira Ayuso
Since bd678e09dc17 ("netfilter: nfnetlink: fix splat due to incorrect socket memory accounting in skbuff clones"), we don't manually attach the sk to the skbuff clone anymore, so we have to use the original skbuff from netlink_ack() which needs to access the sk pointer. Fixes: bd678e09dc17

[PATCH 1/6] netfilter: conntrack: resched in nf_ct_iterate_cleanup

2016-02-16 Thread Pablo Neira Ayuso
From: Florian Westphal Ulrich reports soft lockup with following (shortened) callchain: NMI watchdog: BUG: soft lockup - CPU#1 stuck for 22s! __netif_receive_skb_core+0x6e4/0x774 process_backlog+0x94/0x160 net_rx_action+0x88/0x178 call_do_softirq+0x24/0x3c do_softirq+0x54/0x6c

[PATCH 6/6] netfilter: nft_counter: fix erroneous return values

2016-02-16 Thread Pablo Neira Ayuso
From: Anton Protopopov The nft_counter_init() and nft_counter_clone() functions should return negative error value -ENOMEM instead of positive ENOMEM. Signed-off-by: Anton Protopopov Signed-off-by: Pablo Neira Ayuso ---

[PATCH 4/6] netfilter: nfnetlink: correctly validate length of batch messages

2016-02-16 Thread Pablo Neira Ayuso
From: Phil Turnbull If nlh->nlmsg_len is zero then an infinite loop is triggered because 'skb_pull(skb, msglen);' pulls zero bytes. The calculation in nlmsg_len() underflows if 'nlh->nlmsg_len < NLMSG_HDRLEN' which bypasses the length validation and will later trigger

[PATCH 3/6] netfilter: cttimeout: fix deadlock due to erroneous unlock/lock conversion

2016-02-16 Thread Pablo Neira Ayuso
From: Florian Westphal The spin_unlock call should have been left as-is, revert. Fixes: b16c29191dc89bd ("netfilter: nf_conntrack: use safer way to lock all buckets") Reported-by: kernel test robot Signed-off-by: Florian Westphal

[PATCH 5/6] netfilter: tee: select NF_DUP_IPV6 unconditionally

2016-02-16 Thread Pablo Neira Ayuso
From: Arnd Bergmann The NETFILTER_XT_TARGET_TEE option selects NF_DUP_IPV6 whenever IP6_NF_IPTABLES is enabled, and it ensures that it cannot be builtin itself if NF_CONNTRACK is a loadable module, as that is a dependency for NF_DUP_IPV6. However, NF_DUP_IPV6 can be enabled even

Re: [Intel-wired-lan] [PATCH net-next V2 5/6] e1000: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-16 Thread Rustad, Mark D
Aaron F wrote: From: Intel-wired-lan [intel-wired-lan-boun...@lists.osuosl.org] on behalf of Stefan Assmann [sassm...@kpanic.de] Sent: Wednesday, February 03, 2016 12:20 AM To: intel-wired-...@lists.osuosl.org Cc: netdev@vger.kernel.org; da...@davemloft.net;

Re: [Intel-wired-lan] [PATCH net-next V2 4/6] igb: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-16 Thread Rustad, Mark D
Aaron F wrote: From: Intel-wired-lan [intel-wired-lan-boun...@lists.osuosl.org] on behalf of Stefan Assmann [sassm...@kpanic.de] Sent: Wednesday, February 03, 2016 12:20 AM To: intel-wired-...@lists.osuosl.org Cc: netdev@vger.kernel.org; da...@davemloft.net;

Re: [PATCH net] af_unix: Guard against other == sk in unix_dgram_sendmsg

2016-02-16 Thread David Miller
From: Rainer Weikusat Date: Thu, 11 Feb 2016 19:37:27 + > The unix_dgram_sendmsg routine use the following test > > if (unlikely(unix_peer(other) != sk && unix_recvq_full(other))) { > > to determine if sk and other are in an n:1 association (either >

Re: [PATCH 0/6] Netfilter fixes for net

2016-02-16 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 16 Feb 2016 18:02:31 +0100 > The following patchset contain a rather large batch for your net that > includes accumulated bugfixes, they are: ... > Due to the NetDev 1.1 organization burden, I had no chance to pass up > this to you any

Re: [PATCH] i40e: remove redundant check on vsi->active_vlans

2016-02-16 Thread Shannon Nelson
On Sat, Feb 13, 2016 at 3:57 PM, Colin King wrote: > From: Colin Ian King > > active_vlans is an unsigned long array, hence a null check on this > array is superfluous and can be removed. > > Detected with static analysis by smatch: > >

Re: [PATCH] af_unix: Don't set err in unix_stream_read_generic unless there was an error

2016-02-16 Thread David Miller
From: Rainer Weikusat Date: Mon, 08 Feb 2016 18:47:19 + > The present unix_stream_read_generic contains various code sequences of > the form > > err = -EDISASTER; > if () > goto out; > > This has the unfortunate side effect of possibly causing the

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-16 Thread Jesse Gross
On Thu, Feb 11, 2016 at 2:41 AM, Jiri Benc wrote: > On Wed, 10 Feb 2016 16:47:21 +0100, Paolo Abeni wrote: >> --- a/drivers/net/geneve.c >> +++ b/drivers/net/geneve.c >> @@ -1441,7 +1441,8 @@ struct net_device *geneve_dev_create_fb(struct net >> *net, const char *name, >>

Re: [PATCH v7 3/8] time: Remove duplicated code in ktime_get_raw_and_real()

2016-02-16 Thread Christopher Hall
On Mon, 15 Feb 2016 23:52:10 -0800, Richard Cochran wrote: @@ -888,6 +888,8 @@ void ktime_get_snapshot(struct system_time_snapshot *systime_snapshot) s64 nsec_real; cycle_t now; + WARN_ON(timekeeping_suspended); ... -

Re: [PATCH net 4/6] net/mlx4_core: Do not BUG_ON during reset when PCI is offline

2016-02-16 Thread Sergei Shtylyov
Hello. On 02/16/2016 06:01 PM, Or Gerlitz wrote: From: Daniel Jurgens The PCI channel could go offline during reset due to EEH. Don't bug on in this case, the error is recoverable. Fixes: f6bc11e42646 ('net/mlx4_core: Enhance the catas flow to support device reset')

Re: [PATCH net 1/6] net/mlx4_en: Do not count dropped packets twice

2016-02-16 Thread Rick Jones
On 02/16/2016 07:01 AM, Or Gerlitz wrote: From: Amir Vadai RdropOvflw counter was mistakenly copied into rx_missed_errors. Because of that it was counted twice for the device dropped packets accounting. Fixes: c27a02cd94d6 ('mlx4_en: Add driver for Mellanox ConnectX 10GbE NIC')

Re: [PATCH net] geneve: Refine MTU limit

2016-02-16 Thread Jesse Gross
On Tue, Feb 16, 2016 at 4:33 AM, David Wragg wrote: > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index 028e387..f57f9bc 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > @@ -37,6 +37,9 @@ MODULE_PARM_DESC(log_ecn_error, "Log packets received

Re: [net-next PATCH v2 0/8] tc offload for cls_u32 on ixgbe

2016-02-16 Thread Or Gerlitz
On Tue, Feb 16, 2016 at 8:00 AM, John Fastabend wrote: [...] > Specifically this uses a 'big hammer' feature bit > to do the offload or not. If the bit is set you get offloaded rules > if it is not then rules will not be offloaded. If we can agree on > this patch series

RE: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

2016-02-16 Thread Bryan.Whitehead
Hi Andrew, You can find my comments below wrapped in ... -Original Message- From: Andrew Lunn [mailto:and...@lunn.ch] Sent: Friday, February 12, 2016 12:11 PM To: Bryan Whitehead - C21958 Cc: da...@davemloft.net; netdev@vger.kernel.org Subject: Re: [PATCH net-next,V2] Add LAN9352

RE: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

2016-02-16 Thread Bryan.Whitehead
Andrew, At this point, I am not tasked with implementing switch features, which would likely take a long time to complete. If it is too difficult to add switch features later, then they may come as an entirely new driver at that time. So this driver should only be thought of as operating a

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-16 Thread David Miller
From: Jesse Gross Date: Tue, 16 Feb 2016 10:22:38 -0800 > On Thu, Feb 11, 2016 at 2:41 AM, Jiri Benc wrote: > There's a bigger problem here, not really related to lightweight tunnels or > OVS. > > The VXLAN RFC says (referring to the UDP checksum and not

Re: [net-next PATCH v2 0/8] tc offload for cls_u32 on ixgbe

2016-02-16 Thread David Miller
From: Or Gerlitz Date: Tue, 16 Feb 2016 21:30:18 +0200 > On Tue, Feb 16, 2016 at 8:00 AM, John Fastabend > wrote: > [...] > >> Specifically this uses a 'big hammer' feature bit >> to do the offload or not. If the bit is set you get offloaded

Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

2016-02-16 Thread David Miller
From: Date: Tue, 16 Feb 2016 19:34:26 + > Hi Andrew, > > You can find my comments below wrapped in ... Do not do this. Please reply to emails appropriately, which means proper quotation and no top-posting. Look at how other people reply to postings on

Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

2016-02-16 Thread David Miller
Please stop top-posting. Thank you.

[PATCH V5 4/8] net/ethtool: support get coalesce per queue

2016-02-16 Thread Kan Liang
From: Kan Liang This patch implements sub command ETHTOOL_GCOALESCE for ioctl ETHTOOL_PERQUEUE. It introduces an interface get_per_queue_coalesce to get coalesce of each masked queue from device driver. Then the interrupt coalescing parameters will be copied back to user

Re: [PATCH 0/2] ravb: fix the fallout of R-Car gen3 gPTP support

2016-02-16 Thread David Miller
From: Sergei Shtylyov Date: Sat, 06 Feb 2016 17:45:37 +0300 >Here's a set of 2 patches against DaveM's 'net.git' repo fixing up the > incomplete commit f5d7837f96e5 ("ravb: ptp: Add CONFIG mode support"). > I'm proposing these as fixes but they can be

[PATCH V5 0/8] ethtool per queue parameters support

2016-02-16 Thread Kan Liang
Modern network interface controllers usually support multiple receive and transmit queues. Each queue may have its own parameters. For example, Intel XL710/X710 hardware supports per queue interrupt moderation. However, current ethtool does not support per queue parameters option. User has to set

  1   2   3   >