Re: ipv6 not bringing up due to qdisc_tx_is_noop failing

On 16.03.2016 18:14, Nikolay Borisov wrote: On Wed, Mar 16, 2016 at 7:07 PM, Hannes Frederic Sowa wrote: On 16.03.2016 16:29, Nikolay Borisov wrote: I have stack traces which do show this sequence of events, so my questions now are: 1. What's the difference

Re: [PATCH] ipv6: Fix the pmtu path for connected UDP socket

I don't think ip6_sk_update_pmtu() is a good place to put it as all it does is to call ip6_update_pmtu(). And ip6_update_pmtu() does the route lookup and call __ip6_rt_update_pmtu. We can put it in ip6_update_pmtu(). But that still means we need to pass sk to ip6_update_pmtu() and I don't think it

[iproute PATCH 4/4] testsuite: add a test for tc pedit action

This is not a full test, since kernel functionality is not actually tested. It only compares that the kernel returned values when listing the action are what one expects them to be. Since this test succeeded on both a little-endian and a big-endian system, it shows that any endianness issues have

Re: [RFC PATCH 1/1] net namespace: dynamically configure new net namespace inherit net config

Hi, all Would you like to give me some advice? Any reply is appreciated. Zhu Yanjun On 03/10/2016 10:54 AM, Zhu Yanjun wrote: Sometimes the system engineer and application expect a new net namespace to inherit config from the base net config. Sometimes the current net config is expected by

Re: [PATCH net-next] net/mlx4_core: Fix backward compatibility on VFs

On 03/18/2016 08:45 PM, Alexey Kardashevskiy wrote: On 03/18/2016 03:49 AM, Eli Cohen wrote: Commit 85743f1eb345 ("net/mlx4_core: Set UAR page size to 4KB regardless of system page size") introduced dependency where old VF drivers without this fix fail to load if the PF driver runs with this

Re: [PATCH v3 2/3] IB/hns: Add HiSilicon RoCE driver support

On Sat, Mar 19, 2016 at 06:50:57PM +0800, Lijun Ou wrote: > The driver for HiSilicon RoCE is a platform driver. > The driver will support multiple versions of hardware. Currently only "v1" > for hip06 SoC is supported. > The driver includes two parts: common driver and hardware-specific >

Re: [PATCH net-next] net/mlx4_core: Fix backward compatibility on VFs

On Fri, Mar 18, 2016 at 11:11:06PM -0400, David Miller wrote: > From: Eli Cohen > Date: Thu, 17 Mar 2016 18:49:42 +0200 > > > Commit 85743f1eb345 ("net/mlx4_core: Set UAR page size to 4KB regardless > > of system page size") introduced dependency where old VF drivers without >

[iproute PATCH 2/8] tc: connmark, pedit: Rename BRANCH to CONTROL

As Jamal suggested, BRANCH is the wrong name, as these keywords go beyond simple branch control - e.g. loops are possible, too. Therefore rename the non-terminal to CONTROL instead which should be more appropriate. Signed-off-by: Phil Sutter --- man/man8/tc-connmark.8 | 6 +++---

[PATCH net-next v4 2/2] RDS: TCP: Remove unused constant

RDS_TCP_DEFAULT_BUFSIZE has been unused since commit 1edd6a14d24f ("RDS-TCP: Do not bloat sndbuf/rcvbuf in rds_tcp_tune"). Signed-off-by: Sowmini Varadhan --- v3: review comments from Santosh Shilimkar net/rds/tcp.c |2 -- 1 files changed, 0 insertions(+), 2

Re: [PATCH] iwlwifi: dvm: convert create_singlethread_workqueue() to alloc_workqueue()

On Thu, 2016-03-17 at 20:37 +0800, Eva Rachel Retuya wrote: > Use alloc_workqueue() to allocate the workqueue instead of > create_singlethread_workqueue() since the latter is deprecated and is > scheduled for removal. Scheduled where? >  static void iwl_setup_deferred_work(struct iwl_priv *priv)

Re: [PATCH net-next] net/mlx4_core: Fix backward compatibility on VFs

On Sun, Mar 20, 2016 at 9:07 AM, Yuval Shaia wrote: > On Fri, Mar 18, 2016 at 11:11:06PM -0400, David Miller wrote: >> From: Eli Cohen >> Date: Thu, 17 Mar 2016 18:49:42 +0200 >> > Commit 85743f1eb345 ("net/mlx4_core: Set UAR page size to 4KB

[PATCH] change nfqueue fail-open mechanism to apply also to receive message

Signed-off-by: Yigal Reiss --- This is follow-up on http://marc.info/?l=netfilter-devel=145765526817347=2 Existing fail-open mechanism for nfqueue only applies for message that cannot be sent due to queue size (queue_maxlen). It does not apply when the failure is due to

Re: [PATCH net-next 0/2] ovs: refresh a flow via netlink

2016-03-17 0:23 GMT+01:00 Jesse Gross : > On Wed, Mar 16, 2016 at 8:07 AM, Samuel Gauthier > wrote: >> This patchset adds a netlink api to refresh an existing flow in >> openvswitch. >> >> When a packet is sent in the openvswitch kernel datapath and no

Re: [PATCH] USB: qmi_wwan: add Dell Wireless 5809e Gobi 4G HSPA+ (rev3)

Patrik Halfar writes: > --- a/drivers/net/usb/qmi_wwan.c > +++ b/drivers/net/usb/qmi_wwan.c > @@ -884,6 +884,7 @@ static const struct usb_device_id products[] = { > {QMI_FIXED_INTF(0x413c, 0x81a8, 8)},/* Dell Wireless 5808 Gobi(TM) > 4G LTE Mobile Broadband

[PATCH net 1/3] ipip: Properly mark ipip GRO packets as encapsulated.

ipip encapsulated packets can be merged together by GRO but the result does not have the proper GSO type set or even marked as being encapsulated at all. Later retransmission of these packets will likely fail if the device does not support ipip offloads. This is similar to the issue resolved in

Re: linux-next: manual merge of the rdma tree with the net-next tree

On Wed, Mar 16, 2016 at 10:35 AM, Doug Ledford wrote: > On 3/16/2016 1:18 PM, Linus Torvalds wrote: >> On Tue, Mar 15, 2016 at 5:58 PM, Stephen Rothwell >> wrote: >>> >>> I fixed it up (see below) and can carry the fix as necessary (no action >>> is

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

Hello, Jiri. On Thu, Mar 17, 2016 at 01:00:13PM +0100, Jiri Slaby wrote: > >> I have not done that yet, but today, I see: > >> destroy_workqueue: name='req_hci0' pwq=88002f590300 > >> wq->dfl_pwq=88002f591e00 pwq->refcnt=2 pwq->nr_active=0 delayed_works: > >>pwq 12: cpus=0-1 node=0

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

On Thu, Mar 17, 2016 at 2:41 PM, Andrew Lunn wrote: > On Thu, Mar 17, 2016 at 09:14:17AM +0100, Yegor Yefremov wrote: >> On Thu, Mar 17, 2016 at 12:05 AM, Andrew Lunn wrote: >> > On Wed, Mar 16, 2016 at 11:23:59PM +0100, Yegor Yefremov wrote: >> >> Hi Andrew, >>

Re: [PATCH (net-next.git)] stmmac: fix TX normal DESC

On 16 March 2016 at 11:21, Giuseppe Cavallaro wrote: > This patch fixs a regression raised when test on chips that use > the normal descriptor layout. In fact, no len bits were set for > the TDES1 and no OWN bit inside the TDES0. > > Signed-off-by: Giuseppe CAVALLARO

Build failure in mainline kernel due to 'lan78xx: add ndo_get_stats64'

Hi, your commit a59f8c5b048 ("lan78xx: add ndo_get_stats64") is causing the following build failure if CONFIG_PM is not enabled. drivers/net/usb/lan78xx.c: In function 'lan78xx_get_stats64': drivers/net/usb/lan78xx.c:3274:27: error: 'struct dev_pm_info' has no member named 'runtime_auto'

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB

On 18/03/2016 20:12, Uwe Kleine-König wrote: > On Fri, Mar 18, 2016 at 04:56:21PM +0100, Sebastian Frias wrote: > >> What would you think of making at803x_link_change_notify() print a >> message every time it should do a reset but does not has a way to do it? > > Then this question is obsolete

[PATCH] mac80211: add doc for RX_FLAG_DUP_VALIDATED flag

Add documentation for the flag for duplication check. Fixes the following warning when running make htmldocs: warning: Enum value 'RX_FLAG_DUP_VALIDATED' not described in enum 'mac80211_rx_flags' Signed-off-by: Luis de Bethencourt --- Hi, While running make htmldocs I

Re: [PATCH] ipv6: Fix the pmtu path for connected UDP socket

From: Eric Dumazet Date: Wed, 16 Mar 2016 17:22:07 -0700 > One of the issue is that IPV6_MTU getsockopt() will not check the dst, > but simply use __sk_dst_get() : It will then report old mtu. That's a bug. ipv4 does it right with a proper sk_dst_get() and so should

Re: ipv6 not bringing up due to qdisc_tx_is_noop failing

Hello, On 16.03.2016 16:29, Nikolay Borisov wrote: I have stack traces which do show this sequence of events, so my questions now are: 1. What's the difference between netdev_queue->qdisc and netdev_queue->qdisc_sleeping. Git blaming indicates those member haves existed even before the git

Re: [RFC v2 -next 1/2] virtio: Start feature MTU support

On Wed, Mar 16, 2016 at 11:23:14AM -0700, Stephen Hemminger wrote: > On Tue, 15 Mar 2016 17:04:12 -0400 > Aaron Conole wrote: > > > --- a/include/uapi/linux/virtio_net.h > > +++ b/include/uapi/linux/virtio_net.h > > @@ -55,6 +55,7 @@ > > #define VIRTIO_NET_F_MQ22 /*

[iproute PATCH 0/4] tc: pedit: further fixes

The following series was created after testing pedit on a big-endian system. It starts with a patch fixing coding style in tc/p_ip.c, then the actual big-endian fixup, a fix for raw op discovered when writing the pedit test for testsuite and finally the actual testsuite addon. Phil Sutter (4):

Re: [RFC v2 -next 0/2] virtio-net: Advised MTU feature

Pankaj Gupta writes: >> >> The following series adds the ability for a hypervisor to set an MTU on the >> guest during feature negotiation phase. This is useful for VM orchestration >> when, for instance, tunneling is involved and the MTU of the various systems >> should be

Re: [PATCH net-next] virtio_net: replace netdev_alloc_skb_ip_align() with napi_alloc_skb()

On Thu, 2016-03-17 at 18:01 -0700, Venkatesh Srinivas wrote: > On Thu, Mar 17, 2016 at 7:44 AM, Paolo Abeni wrote: > > > > This gives small but noticeable rx performance improvement (2-3%) > > and will allow exploiting future napi improvement. > > > > Signed-off-by: Paolo Abeni

Re: [PATCH] xfrm: don't segment UFO packets

On Thu, Mar 17, 2016 at 01:03:59PM +0800, Herbert Xu wrote: > On Wed, Mar 16, 2016 at 05:00:26PM +0100, Jiri Bohac wrote: > > Prevent xfrm_output() from segmenting UFO packets so that they will be > > fragmented after the xfrm transforms. > > Fair enough. But I wonder if this is enough.

[PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

If CONFIG_PM=n: drivers/net/usb/lan78xx.c: In function ‘lan78xx_get_stats64’: drivers/net/usb/lan78xx.c:3274: error: ‘struct dev_pm_info’ has no member named ‘runtime_auto’ If PM is disabled, the runtime_auto flag is not available, but auto suspend is not enabled anyway. Hence protect

[PATCH iproute2 2/2] geneve: Add support for configuring UDP checksums.

Enable support for configuring outer UDP checksums on Geneve tunnels: ip link add type geneve id 10 remote 10.0.0.2 udpcsum Signed-off-by: Jesse Gross --- ip/iplink_geneve.c | 48 1 file changed, 48 insertions(+) diff --git

[iproute PATCH 3/4] tc: pedit: Fix raw op

The retain value was wrong for u16 and u8 types. Signed-off-by: Phil Sutter --- tc/m_pedit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tc/m_pedit.c b/tc/m_pedit.c index 7de47800040bc..23bd1d5727f85 100644 --- a/tc/m_pedit.c +++ b/tc/m_pedit.c @@

Re: [RFCv2 0/3] mac80211: implement fq codel

I've re-tested selected cases with wmm_enabled=0 set on the DUT AP. I'm attaching results. Naming: * "old-" is without mac/ath10k changes (referred to as kvalo-reverts previously) and fq_codel on qdiscs, * "patched-" is all patches applied (both mac and ath), * "-be-bursts" is stock "bursts"

Re: [PATCH net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl

On 03/16/2016 02:34 PM, Xin Long wrote: > This patchset is used to support sending rntl info to user in some places, > and ensure that whenever those attributes change internally or from sysfs, > that a netlink notification is sent out to listeners. > > It also make some adjustment in bridge

[iproute PATCH 1/4] tc/p_ip.c: Lint through checkpatch.pl

This diff was generated by using the fix-inplace option of checkpatch.pl and breaking the overlong lines of parse_ip() and parse_ip6() signatures. Signed-off-by: Phil Sutter --- tc/p_ip.c | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-)

Re: [net-next v2] virtio_net: replace netdev_alloc_skb_ip_align() with napi_alloc_skb()

On Fri, Mar 18, 2016 at 04:42:48PM +0100, Paolo Abeni wrote: > This gives small but noticeable rx performance improvement (2-3%) > and will allow exploiting future napi improvement. > > Signed-off-by: Paolo Abeni I am not sure this is necessarily worth doing for this dumb

[PATCH v2 1/2] Revert "vsock: Fix blocking ops call in prepare_to_wait"

This reverts commit 5988818008257ca42010d6b43a3e0e48afec9898 ("vsock: Fix blocking ops call in prepare_to_wait") Signed-off-by: Claudio Imbrenda --- net/vmw_vsock/af_vsock.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git

Re: [RFD] workqueue: WQ_MEM_RECLAIM usage in network drivers

Hello, On Fri, Mar 18, 2016 at 05:24:05PM -0400, J. Bruce Fields wrote: > > But does that actually work? It's pointless to add WQ_MEM_RECLAIM to > > workqueues unless all other things are also guaranteed to make forward > > progress regardless of memory pressure. > > It's supposed to work. > >

Re: [PATCH v1 0/2] basic ioctl support for netlink sockets

From: David Decotigny Date: Thu, 17 Mar 2016 17:03:54 -0700 > This removes the requirement that ethtool be tied to the support > of a specific L3 protocol, also updates a comment. You're adding an ioctl handler to netlink sockets, and it is not at all apparent to me how this

[PATCH] brcmfmac: sdio: remove unused variable retry_limit

From: Colin Ian King retry_limit has never been used during the life of this driver, so we may as well remove it as it is redundant. Signed-off-by: Colin Ian King --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 3 --- 1 file

[PATCH net] net: remove a dubious unlikely() clause

From: Eric Dumazet TCP protocol is still used these days, and TCP uses clones in its transmit path. We can not optimize linux stack assuming it is mostly used in routers, or that TCP is dead. Fixes: 795bb1c00d ("net: bulk free infrastructure for NAPI context, use

Re: [PATCH net 0/3] flowi6_tos fixes

From: Daniel Borkmann Date: Fri, 18 Mar 2016 18:37:56 +0100 > This set is a follow-up to address Jiri's recent feedback [1] on > the flowi6_tos issue, that it is not used for IPv6 route lookups. > The three patches fix all current users of flowi6_tos and remove > the define

[PATCH] net/mlx4: remove unused array zero_gid[]

From: Colin Ian King zero_gid is not used, so remove this redundant array. Signed-off-by: Colin Ian King --- drivers/net/ethernet/mellanox/mlx4/mcg.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCH net-next 5/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_if

On 03/16/2016 02:34 PM, Xin Long wrote: > Now when we change the attributes of bridge or br_port by netlink, > a relevant netlink notification will be sent, but if we change them > by ioctl or sysfs, no notification will be sent. > > We should ensure that whenever those attributes change

[PATCH net-next v2 4/4] vxlan: implement GPE

Implement VXLAN-GPE. Only COLLECT_METADATA is supported for now (it is possible to support static configuration, too, if there is demand for it). The GPE header parsing has to be moved before iptunnel_pull_header, as we need to know the protocol. v2: Removed what was called "L2 mode" in v1 of

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

On March 17, 2016 1:10:31 PM PDT, Murali Karicheri wrote: >David, > >On 08/18/2015 04:47 PM, David Miller wrote: >> I see some drivers where the foo_debugfs.c file is larger than the >rest >> of the driver. Once people start using it, it's like crack, and they >> dump every

[PATCH v2 ethtool 0/2] IPv6 RXNFC

This series adds support for steering of IPv6 receive flows. Changes since v1: * Fixed and simplified IPv6 address and mask parsing * Made help text / man page more consistent * Dropped ethtool-copy.h patch as upstream is now newer Edward Cree (2): Add IPv6 support to NFC Documentation for

Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

On Sun, 2016-03-20 at 11:43 +0100, Geert Uytterhoeven wrote: > If CONFIG_PM=n: > > drivers/net/usb/lan78xx.c: In function ‘lan78xx_get_stats64’: > drivers/net/usb/lan78xx.c:3274: error: ‘struct dev_pm_info’ has no member > named ‘runtime_auto’ > > If PM is disabled, the runtime_auto

[PULL] virtio/vhost: new features, performance improvements, cleanups

The following changes since commit e1f33be9186363da7955bcb5f0b03e6685544c50: vhost: fix error path in vhost_init_used() (2016-03-02 17:01:49 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up

Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface

Schemmel Hans-Christoph writes: > Added support for Gemalto's Cinterion PHxx WWAN interfaces > by adding QMI_FIXED_INTF with Cinterion's VID and PID. > > PHxx can have: > 2 RmNet Interfaces (PID 0x0082) or > 1 RmNet + 1 USB Audio interface (PID 0x0083). > >

Re: [PATCH net v2 0/3] Tunneling fixes

From: Jesse Gross Date: Sat, 19 Mar 2016 09:31:59 -0700 > This series fixes a problem that was reported where encapsulated packets > do not have their encapsulation offload markers stripped off when being > decapsulated. This causes a significant performance drop if the packets

Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

From: Eric Dumazet Date: Sun, 20 Mar 2016 09:35:52 -0700 > On Sun, 2016-03-20 at 11:43 +0100, Geert Uytterhoeven wrote: >> If CONFIG_PM=n: >> >> drivers/net/usb/lan78xx.c: In function ‘lan78xx_get_stats64’: >> drivers/net/usb/lan78xx.c:3274: error: ‘struct

Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

On 03/20/2016 03:43 AM, Geert Uytterhoeven wrote: If CONFIG_PM=n: drivers/net/usb/lan78xx.c: In function ‘lan78xx_get_stats64’: drivers/net/usb/lan78xx.c:3274: error: ‘struct dev_pm_info’ has no member named ‘runtime_auto’ If PM is disabled, the runtime_auto flag is not available,

Re: [PATCH] appletalk: Pass IP-over-DDP packets through when 'ipddp0' interface is not present

On Thu, 2016-02-25 at 19:46 -0500, Adam Seering wrote: > On Thu, 2016-02-25 at 14:33 -0500, David Miller wrote: > > From: Adam Seering > > Date: Tue, 23 Feb 2016 09:19:13 -0500 > > > > > Let userspace programs transmit and receive raw IP-over-DDP > > > packets > > > with a

Re: [PATCH] net: sched: Add description for cpu_bstats argument

From: Luis de Bethencourt Date: Sat, 19 Mar 2016 21:31:38 + > Commit 22e0f8b9322c ("net: sched: make bstats per cpu and estimator RCU safe") > added the argument cpu_bstats to functions gen_new_estimator and > gen_replace_estimator and now the descriptions of these

Re: [PATCH] gen_stats.c: Add description for cpu argument

From: Luis de Bethencourt Date: Sat, 19 Mar 2016 21:19:55 + > Function gnet_stats_copy_basic is missing the description of the cpu > argument in the documentation. Adding it. > > Signed-off-by: Luis de Bethencourt Applied.

Re: [PATCH v7] isdn: Use ktime_t instead of 'struct timeval'

From: Tina Ruchandani Date: Sat, 19 Mar 2016 11:21:14 -0700 > 'struct timeval' uses 32-bit representation for seconds which will > overflow in year 2038 and beyond. mISDN/clock.c needs to compute and > store elapsed time in intervals of 125 microseconds. This patch

Re: [PATCH] sctp: do not leak chunks that are sent to unconfirmed paths

From: Marcelo Ricardo Leitner Date: Fri, 18 Mar 2016 18:39:19 -0300 > Currently, if a chunk is scheduled to be sent through a transport that > is currently unconfirmed, it will be leaked as it is dequeued from outq > and is not re-queued nor freed. > > As I'm not

Re: [PATCH v2] sctp: align MTU to a word

From: Marcelo Ricardo Leitner Date: Sat, 19 Mar 2016 12:17:20 -0300 > SCTP is a protocol that is aligned to a word (4 bytes). Thus using bare > MTU can sometimes return values that are not aligned, like for loopback, > which is 65536 but ipv4_mtu() limits that to

Re: [PATCH] sctp: do not update a_rwnd if we are not issuing a sack

From: Marcelo Ricardo Leitner Date: Fri, 18 Mar 2016 18:39:18 -0300 > The SACK can be lost pretty much elsewhere, but if its allocation fail, > we know we are not sending it, so it is better to revert a_rwnd to its > previous value as this may give it a chance to issue

Re: [PATCH net] net: remove a dubious unlikely() clause

From: Eric Dumazet Date: Sun, 20 Mar 2016 11:27:47 -0700 > From: Eric Dumazet > > TCP protocol is still used these days, and TCP uses > clones in its transmit path. We can not optimize linux > stack assuming it is mostly used in routers, or that TCP

Re: [PATCH] net/mlx4: remove unused array zero_gid[]

From: Colin King Date: Sun, 20 Mar 2016 17:44:56 + > From: Colin Ian King > > zero_gid is not used, so remove this redundant array. > > Signed-off-by: Colin Ian King Applied.