Re: [PATCH pci] pci: Add helper function to set VPD size

On 4/14/2016 1:35 PM, Steve Wise wrote: The fix is to add a PCI helper function to set the VPD size, so the driver can expicitly set the exact size of the VPD. Fixes commit 104daa71b396 ("PCI: Determine actual VPD size on first access") Signed-off-by: Casey Leedom

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

On Thu 14 Apr 16:34 PDT 2016, Timur Tabi wrote: [..] > So I think the solution is to create a device tree (and ACPI) property that > holds the mask. > > dma-mask = <0 0x>; > > or > > dma-mask = <0x 0x>; > > The driver will then do this: > > u64

Re: [patch net-next] devlink: fix sb register stub in case devlink is disabled

From: Jiri Pirko Date: Fri, 15 Apr 2016 09:17:08 +0200 > From: Jiri Pirko > > Reported-by: kbuild test robot > Fixes: bf7974710a40 ("devlink: add shared buffer configuration") > Signed-off-by: Jiri Pirko

Re: [patch net-next 0/2] mlxsw: spectrum_buffers: couple of cosmetic patches

From: Jiri Pirko Date: Fri, 15 Apr 2016 15:09:36 +0200 > As suggested by David Laight Series applied.

Re: [PATCH pci] pci: Add helper function to set VPD size

On Fri, Apr 15, 2016 at 11:12:02AM -0500, Steve Wise wrote: > On 4/14/2016 1:35 PM, Steve Wise wrote: > >>The fix is to add a PCI helper function to set the VPD size, so the > >>driver can expicitly set the exact size of the VPD. > >> > >>Fixes commit 104daa71b396 ("PCI: Determine actual VPD size

Re: [PATCH for-next V1 0/2] mlx5_core: mlx5_ifc updates

On Wed, Apr 13, 2016 at 7:11 PM, Saeed Mahameed wrote: > Hi Dave and Doug > > Changes form V0: > - 2nd patch commit message fixes. > > This series include mlx5_core updates for both net-next and rdma > trees for 4.7 kernel cycle. This is the only shared code planned >

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

Bjorn Andersson wrote: For platform devices being populated via from DT you will pass: of_platform_bus_create() of_platform_device_create_pdata() of_dma_configure() Which calls of_dma_get_range() to acquire this information from the dma-ranges property and set up the dma ops and

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

Rob Herring wrote: > > dma-mask = <0 0x>; > >or > > dma-mask = <0x 0x>; No. See dma-ranges. How exactly should I use dma-ranges? I can't find any other drivers that queries that property and uses the result to call dma_set_mask. I thought the

Re: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

On Thu, Apr 14, 2016 at 7:49 PM, KY Srinivasan wrote: > > >> -Original Message- >> From: Alexander Duyck [mailto:alexander.du...@gmail.com] >> Sent: Thursday, April 14, 2016 4:18 PM >> To: KY Srinivasan >> Cc: David Miller ;

RE: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Friday, April 15, 2016 8:40 AM > To: KY Srinivasan > Cc: David Miller ; Netdev > ; linux-ker...@vger.kernel.org; >

Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel()

Hi Kalle, On Fri, Apr 15, 2016 at 10:09 PM, Kalle Valo wrote: > Julian Calaby writes: > >> Hi Kalle, >> >> On Sat, Jan 2, 2016 at 5:25 AM, SF Markus Elfring >> wrote: >>> From: Markus Elfring

Re: Deleting child qdisc doesn't reset parent to default qdisc?

On Fri, 2016-04-15 at 08:42 -0400, Jamal Hadi Salim wrote: > On 16-04-14 01:49 PM, Eric Dumazet wrote: > > > And what would be the chosen behavior ? > > > > TBF is probably a bad example because it started life as > a classless qdisc. There was only one built-in fifo queue > that was shaped.

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

On Fri, Apr 15, 2016 at 10:44 AM, Timur Tabi wrote: > Rob Herring wrote: >>> >>> > >>> > dma-mask = <0 0x>; >>> > >>> >or >>> > >>> > dma-mask = <0x 0x>; >> >> No. See dma-ranges. > > > How exactly should I use dma-ranges? I can't

Re: [RFC PATCH 0/2] selinux: avoid nf hooks overhead when not needed

On 4/15/2016 2:38 AM, Paolo Abeni wrote: > On Thu, 2016-04-14 at 18:53 -0400, Paul Moore wrote: >> On Tue, Apr 12, 2016 at 4:52 AM, Paolo Abeni wrote: >>> Will be ok if we post a v2 version of this series, removing the hooks >>> de-registration bits, but preserving the selinux

Re: Fwd: Re: Section 4 No. 9,10 Failed was occurred by IPv6 Ready Logo Conformance Test

> On April 15, 2016 at 10:47 AM Yuki Machida > wrote: > > >> commit 9d289715eb5c252ae15bd547cb252ca547a3c4f2 > >> Author: Hagen Paul Pfeifer > >> Date: Thu Jan 15 22:34:25 2015 +0100 > >> > >> ipv6: stop sending PTB packets for MTU < 1280 > >>

Re: [PATCH v2 01/15] wcn36xx: Clean up wcn36xx_smd_send_beacon

Bjorn Andersson writes: > On Sun 03 Apr 15:16 PDT 2016, Bjorn Andersson wrote: > >> From: Pontus Fuchs >> >> Needed for coming improvements. No functional changes. >> > > Kalle, Eugene, > > Have you picked up these patches yet? > > As I was

RE: [patch net-next 05/18] mlxsw: spectrum_buffers: Push out indexes and direction out of SB structs

From: Jiri Pirko > Sent: 15 April 2016 09:53 .. > >> @@ -106,10 +96,9 @@ static int mlxsw_sp_port_pb_init(struct mlxsw_sp_port > >> *mlxsw_sp_port) > >>mlxsw_reg_pbmc_pack(pbmc_pl, mlxsw_sp_port->local_port, > >>0x, 0x / 2); > >>for (i = 0; i <

Re: [PATCH pci] pci: Add helper function to set VPD size

[+cc Hannes, Ariel, LKML] On Thu, Apr 14, 2016 at 11:42:05PM +0530, Hariprasad Shenai wrote: > commit 104daa71b396 ("PCI: Determine actual VPD size on first access") > introduced a regression in cxgb4 driver and used to fail in pci probe. > > The problem is stemming from the fact that the

[PATCH net-next 6/7] net: dsa: mv88e6xxx: add number of database to info

Move the number of databases to the info structure. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 6 +++--- drivers/net/dsa/mv88e6131.c | 8 drivers/net/dsa/mv88e6171.c | 8 drivers/net/dsa/mv88e6352.c | 12 ++--

[PATCH net-next 5/7] net: dsa: mv88e6xxx: add number of ports to info

Drop the ps->num_ports variable for a new member of the info structure. This removes the need to assign it at setup time. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 19 +++ drivers/net/dsa/mv88e6131.c | 26

[PATCH net-next 1/7] net: dsa: mv88e6xxx: drop double ds assignment

Every driver assigns ps->ds even though it gets assigned in the shared mv88e6xxx_setup_common function. Kill redundancy. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 2 -- drivers/net/dsa/mv88e6131.c | 2 -- drivers/net/dsa/mv88e6171.c | 2

Re: [PATCH net-next 2/7] net: dsa: mv88e6xxx: drop revision probing

> --- a/drivers/net/dsa/mv88e6xxx.c > +++ b/drivers/net/dsa/mv88e6xxx.c > @@ -2663,11 +2663,15 @@ int mv88e6xxx_setup_ports(struct dsa_switch *ds) > int mv88e6xxx_setup_common(struct dsa_switch *ds) > { > struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); > + int id; > > ps->ds

Re: [PATCH net-next 7/7] net: dsa: mv88e6xxx: drop switch id

On Fri, Apr 15, 2016 at 02:25:50PM -0400, Vivien Didelot wrote: > We already have the product number and revision stored in the info > structure and the switch private state. > > It is not necessary to clutter the header file with shifted product > number for devices that we don't even support

Re: [PATCH net-next 6/7] net: dsa: mv88e6xxx: add number of database to info

Hi Andrew, Andrew Lunn writes: > On Fri, Apr 15, 2016 at 02:25:49PM -0400, Vivien Didelot wrote: >> Move the number of databases to the info structure. > > Isn't the number of databases a property of the family? No. We've seen [1] for instance that 6061 and 6065 are both part

Re: [PATCH net-next 6/7] net: dsa: mv88e6xxx: add number of database to info

On Fri, Apr 15, 2016 at 04:24:26PM -0400, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > On Fri, Apr 15, 2016 at 02:25:49PM -0400, Vivien Didelot wrote: > >> Move the number of databases to the info structure. > > > > Isn't the number of databases a property of

Re: [PATCH net-next v2] vxlan: synchronously and race-free destruction of vxlan sockets

From: Hannes Frederic Sowa Date: Fri, 8 Apr 2016 22:55:01 +0200 > @@ -1053,7 +1052,9 @@ static void __vxlan_sock_release(struct vxlan_sock *vs) > vxlan_notify_del_rx_port(vs); > spin_unlock(>sock_lock); > > - queue_work(vxlan_wq, >del_work); > +

FlameGraph of mlx4 early drop with order-0 pages

Hi Mel, I did an experiment that you might find interesting. Using Brenden's early drop with eBPF in the mxl4 driver. I changed the mlx4 driver to use order-0 pages. It usually use order-3 pages to amortize the cost of calling the page allocator (which is problematic for other reasons, like

Re: [PATCH net-next 6/7] net: dsa: mv88e6xxx: add number of database to info

On Fri, Apr 15, 2016 at 02:25:49PM -0400, Vivien Didelot wrote: > Move the number of databases to the info structure. Isn't the number of databases a property of the family? I would add a table indexed by family. Andrew

[PATCH] net: phy: Ensure the state machine is called when phy is UP

Commit d5c3d84657db ("net: phy: Avoid polling PHY with PHY_IGNORE_INTERRUPTS") removed the last polling done on the phy. Since then, the last actual poll done on the phy happens PHY_STATE_TIME seconds (that is actually one second) after registering the phy. If the interface is not UP by that time,

Re: [PATCH net-next 0/5] tipc: improvements to the link setup algorithm

From: Jon Maloy Date: Fri, 15 Apr 2016 13:33:02 -0400 > This series addresses some smaller issues regarding the link setup > algorithm. The first commit fixes a rare bug we have discovered during > testing; the second one may have some future impact on cluster >

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

On 15/04/16 12:56, Alexandre Belloni wrote: > Commit d5c3d84657db ("net: phy: Avoid polling PHY with > PHY_IGNORE_INTERRUPTS") removed the last polling done on the phy. Since > then, the last actual poll done on the phy happens PHY_STATE_TIME seconds > (that is actually one second) after

[PATCH net-next 1/3] ila: Add struct definitions and helpers

Add structures for identifiers, locators, and an ila address which is composed of a locator and identifier and in6_addr can be cast to it. This includes a three bit type field and enums for the types defined in ILA I-D. In ILA lwt don't allow user to set a translation for a non-ILA address (type

[PATCH net-next 3/3] ila: add checksum neutral ILA translations

Support checksum neutral ILA as described in the ILA draft. The low order 16 bits of the identifier are used to contain the checksum adjustment value. The csum-mode parameter is added to described checksum processing. There are three values: - adjust transport checksum (previous behavior) - do

[PATCH net-next 2/3] ila: xlat changes

Change model of xlat to be used only for input where lookup is done on the locator part of an address (comparing to locator_match as key in rhashtable). This is needed for checksum neutral translation which obfuscates the low order 16 bits of the identifier. It also permits hosts to be in muliple

[PATCH net-next 0/3] ila: Support for checksum neutral translations

This patch set updates ILA to support draft-herbert-nvo3-ila-02. The primary addition is support checksum neutral ILA translation. This allows address to be performed and still keep any transport layer checksums that include the addresses in their pseudo header to still be correct without the

[PATCH net-next 1/2] staging: rtl8188eu: Convert to using IFF_NO_QUEUE

Cc: Jakub Sitnicki Signed-off-by: Phil Sutter --- drivers/staging/rtl8188eu/os_dep/mon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/mon.c b/drivers/staging/rtl8188eu/os_dep/mon.c index

Re: Deleting child qdisc doesn't reset parent to default qdisc?

From: Eric Dumazet Date: Fri, 15 Apr 2016 07:58:48 -0700 > Having some hidden qdiscs is the real problem here. +1

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

Rob Herring wrote: You may only care about the size, but the binding has to handle the more complex case. Here's an example <0x0 0x2 0x0 0x1 0x0> dma address 0 (cell 0) maps to cpu (parent) address 0x2_ (cell 1-2) and the range/size is 4G (cell 3-4). If you have the same base address,

[PATCH net-next 2/2] openvswitch: Convert to using IFF_NO_QUEUE

Cc: Pravin Shelar Signed-off-by: Phil Sutter --- net/openvswitch/vport-internal_dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c index

[PATCH net-next 0/2] Minor IFF_NO_QUEUE conversion follow-up

The following series converts two further drivers away from setting 'tx_queue_len = 0' to adding IFF_NO_QUEUE to priv_flags instead. The first one, rtl8188eu in staging didn't exist back when all drivers were converted. The second one, openvswitch seems to have slipped through my grep'ing back

[PATCH net-next 2/7] net: dsa: mv88e6xxx: drop revision probing

There is no point in having special case for the revision when probing a switch model. The code gets cluttered with unnecessary defines, and leads to errors when code such as mv88e6131_setup compares PORT_SWITCH_ID_6131_B2 to ps->id which mask the revision. Drop every revision definitions, add a

Re: [PATCH net-next 3/7] net: dsa: mv88e6xxx: add switch info

On Fri, Apr 15, 2016 at 02:25:46PM -0400, Vivien Didelot wrote: > Add a new switch info structure which will be later extended to store > switch models static information, such as product number, name, number > of ports, number of databases, etc. > > Merge the lookup function in the probing code,

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

On Fri 15 Apr 10:00 PDT 2016, Timur Tabi wrote: > Bjorn Andersson wrote: > >For platform devices being populated via from DT you will pass: > >of_platform_bus_create() > > of_platform_device_create_pdata() > > of_dma_configure() > > > >Which calls of_dma_get_range() to acquire this

Re: [PATCH pci] pci: Add helper function to set VPD size

| From: Steve Wise | Sent: Friday, April 15, 2016 9:12 AM | | On 4/14/2016 1:35 PM, Steve Wise wrote: | >> The fix is to add a PCI helper function to set the VPD size, so the | >> driver can expicitly set the exact size of the VPD. | >> | >> Fixes commit 104daa71b396

[RFC net-next] soreuseport: fix ordering for mixed v4/v6 sockets

From: Craig Gallek With the SO_REUSEPORT socket option, it is possible to create sockets in the AF_INET and AF_INET6 domains which are bound to the same IPv4 address. This is only possible with SO_REUSEPORT and when not using IPV6_V6ONLY on the AF_INET6 sockets. Prior to the

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

Bjorn Andersson wrote: Your driver is a platform driver and it's being probed from DT. As such all this is already taken care of for you, by the core. The listing is for your reference to know why the dma-ranges property would affect your device. Ah, sorry. I misunderstood what you meant by

Re: [PATCH net-next 4/7] net: dsa: mv88e6xxx: add family to info

On Fri, Apr 15, 2016 at 02:25:47PM -0400, Vivien Didelot wrote: > Add an mv88e6xxx_family enum to the info structure for better family > indentification. > > Signed-off-by: Vivien Didelot > --- > drivers/net/dsa/mv88e6123.c | 6 ++-- >

[PATCH net] net: bcmgenet: device stats are unsigned long

From: Eric Dumazet On 64bit kernels, device stats are 64bit wide, not 32bit. Fixes: 1c1008c793fa4 ("net: bcmgenet: add main driver file") Signed-off-by: Eric Dumazet Cc: Florian Fainelli ---

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

Byeoungwook Kim writes: > rtl_*_delay() functions were reused same codes about addr variable. > So i have converted to rtl_addr_delay() from code about addr variable. > > Signed-off-by: Byeoungwook Kim > Reviewed-by: Julian Calaby

[PATCH net-next 4/7] net: dsa: mv88e6xxx: add family to info

Add an mv88e6xxx_family enum to the info structure for better family indentification. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 6 ++-- drivers/net/dsa/mv88e6131.c | 8 ++--- drivers/net/dsa/mv88e6171.c | 8 ++---

[PATCH net-next 0/7] net: dsa: mv88e6xxx: factorize switch info

This patchset factorizes drastically the mv88e6xxx code by sharing a new extendable info structure to store static data such as switch family, product number, number of ports, number of databases and the name. The next step is to add a "features" bitmap member to the info structure in order to

[PATCH net-next 3/7] net: dsa: mv88e6xxx: add switch info

Add a new switch info structure which will be later extended to store switch models static information, such as product number, name, number of ports, number of databases, etc. Merge the lookup function in the probing code, so that we avoid multiple checking of the MII bus, as well a multiple ID

Re: [PATCH net-next 0/2] act_bpf, cls_bpf: send eBPF bytecode through

On Fri, Apr 15, 2016 at 12:41:05PM +0200, Daniel Borkmann wrote: > Hi Quentin, > > On 04/15/2016 12:07 PM, Quentin Monnet wrote: > >When a new BPF traffic control filter or action is set up with tc, the > >bytecode is sent back to userspace through a netlink socket for cBPF, but > >not for eBPF

[PATCH net-next] enic: set netdev->vlan_features

From: Govindarajulu Varadarajan <_gov...@gmx.com> Driver sets vlan_feature to netdev->features as hardware supports all of them on vlan interface. Signed-off-by: Govindarajulu Varadarajan <_gov...@gmx.com> --- drivers/net/ethernet/cisco/enic/enic_main.c | 1 + 1 file changed, 1 insertion(+)

[PATCH net-next 5/5] tipc: let first message on link be a state message

According to the link FSM, a received traffic packet can take a link from state ESTABLISHING to ESTABLISHED, but the link can still not be fully set up in one atomic operation. This means that even if the the very first packet on the link is a traffic packet with sequence number 1 (one), it has to

[PATCH net-next 7/7] net: dsa: mv88e6xxx: drop switch id

We already have the product number and revision stored in the info structure and the switch private state. It is not necessary to clutter the header file with shifted product number for devices that we don't even support yet. Remove them. Signed-off-by: Vivien Didelot

Hello DEAR

Hi my name is Mitchell H Peacock. I'm an American soldier currently in Syria fighting IS. This might be a little strange for you but Its very lonely out here. I miss normal human interaction and being loved by someone so I would love to get to know you and keep in touch with you. I'm loving,

[PATCH net-next v3 RFC 2/2] ipv6: add support for stats via RTM_GETSTATS

From: Roopa Prabhu This patch is an example of adding af stats in RTM_GETSTATS. It adds a new nested IFLA_STATS_LINK_INET6 attribute for ipv6 af stats. stats attributes inside IFLA_STATS_LINK_INET6 nested attribute use the existing ipv6 stats attributes from ipv6

[PATCH net-next v3 0/2] rtnetlink: new message for stats

From: Roopa Prabhu This patch adds a new RTM_GETSTATS message to query stats via netlink from the kernel. RTM_NEWLINK also dumps links stats today, but RTM_NEWLINK returns a lot more than just stats and is expensive in some cases when frequent polling for stats from

[PATCH net-next v3 1/2] rtnetlink: add new RTM_GETSTATS message to query stats

From: Roopa Prabhu This patch adds a new RTM_GETSTATS message to query stats via netlink from the kernel. RTM_NEWLINK also dumps link stats today, but RTM_NEWLINK returns a lot more than just stats and is expensive in some cases when frequent polling for stats from

RE: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

> -Original Message- > From: KY Srinivasan > Sent: Friday, April 15, 2016 9:01 AM > To: 'Alexander Duyck' > Cc: David Miller ; Netdev > ; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de;

[PATCH] net: ipv6: Do not fix up linklocal and loopback addresses

f1705ec197e7 added the option to retain user configured addresses on an admin down. A comment to one of the later revisions suggested using the IFA_F_PERMANENT flag rather than adding a user_managed boolean to the ifaddr struct. A side effect of this change is that link local and loopback

Re: [PATCH net v2] vlan: pull on __vlan_insert_tag error path and fix csum correction

From: Daniel Borkmann Date: Sat, 16 Apr 2016 02:27:58 +0200 > When __vlan_insert_tag() fails from skb_vlan_push() path due to the > skb_cow_head(), we need to undo the __skb_push() in the error path > as well that was done earlier to move skb->data pointer to mac header. >

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

Hi Kalle, On Sat, Apr 16, 2016 at 4:25 AM, Kalle Valo wrote: > Byeoungwook Kim writes: > >> rtl_*_delay() functions were reused same codes about addr variable. >> So i have converted to rtl_addr_delay() from code about addr variable. >> >>

[PATCH net-next] rtnetlink: rtnl_fill_stats: avoid an unnecssary stats copy

From: Roopa Prabhu This patch passes netlink attr data ptr directly to dev_get_stats thus elimiating a stats copy. Suggested-by: David Miller Signed-off-by: Roopa Prabhu --- net/core/rtnetlink.c | 23

[PATCH net-next 1/5] tipc: guarantee peer bearer id exchange after reboot

When a link endpoint is going down locally, e.g., because its interface is being stopped, it will spontaneously send out a RESET message to its peer, informing it about this fact. This saves the peer from detecting the failure via probing, and hence gives both speedier and less resource consuming

[PATCH net-next 2/5] tipc: reduce transmission rate of reset messages when link is down

When a link is down, it will continuously try to re-establish contact with the peer by sending out a RESET or an ACTIVATE message at each timeout interval. The default value for this interval is currently 375 ms. This is wasteful, and may become a problem in very large clusters with dozens or

[PATCH net-next 3/5] tipc: refactor function tipc_link_timeout()

The function tipc_link_timeout() is unnecessary complex, and can easily be made more readable. We do that with this commit. The only functional change is that we remove a redundant test for whether the broadcast link is up or not. Acked-by: Ying Xue Signed-off-by: Jon

[PATCH net-next 4/5] tipc: ensure that first packets on link are sent in order

In some link establishment scenarios we see that packet #2 may be sent out before packet #1, forcing the receiver to demand retransmission of the missing packet. This is harmless, but may cause confusion among people tracing the packet flow. Since this is extremely easy to fix, we do so by adding

[PATCH net-next 0/5] tipc: improvements to the link setup algorithm

This series addresses some smaller issues regarding the link setup algorithm. The first commit fixes a rare bug we have discovered during testing; the second one may have some future impact on cluster scalabilty, while remaining ones can be regarded as cosmetic in a wider sense of the word. Jon

Re: [PATCH net-next v2 1/7] net: dsa: mv88e6xxx: drop double ds assignment

On Fri, Apr 15, 2016 at 07:21:22PM -0400, Vivien Didelot wrote: > Every driver assigns ps->ds even though it gets assigned in the shared > mv88e6xxx_setup_common function. Kill redundancy. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn

Re: [PATCH net-next v2 2/7] net: dsa: mv88e6xxx: drop revision probing

On Fri, Apr 15, 2016 at 07:21:23PM -0400, Vivien Didelot wrote: > There is no point in having special case for the revision when probing a > switch model. The code gets cluttered with unnecessary defines, and > leads to errors when code such as mv88e6131_setup compares > PORT_SWITCH_ID_6131_B2 to

Re: qdisc spin lock

On Fri, 2016-04-15 at 16:05 -0700, Michael Ma wrote: > Would definitely appreciate that. If you can share the patch it will > be helpful as well. Let me know if I can help with this... Sure, here is what I am going to test : diff --git a/drivers/net/bonding/bond_main.c

Re: [PATCH net-next v2 3/7] net: dsa: mv88e6xxx: add switch info

> + for (i = 0, info = [i]; i < num; info = [++i]) > + if (info->prod_num == (id & 0xfff0) >> 4) > + goto found; > > return NULL; > -} > > -char *mv88e6xxx_drv_probe(struct device *dsa_dev, struct device *host_dev, > - int

Re: [PATCH net-next v2 4/7] net: dsa: mv88e6xxx: add family to info

On Fri, Apr 15, 2016 at 07:21:25PM -0400, Vivien Didelot wrote: > Add an mv88e6xxx_family enum to the info structure for better family > indentification. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v2 5/7] net: dsa: mv88e6xxx: add number of ports to info

On Fri, Apr 15, 2016 at 07:21:26PM -0400, Vivien Didelot wrote: > Drop the ps->num_ports variable for a new member of the info structure. > This removes the need to assign it at setup time. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn

Re: [PATCH net-next v2 7/7] net: dsa: mv88e6xxx: remove switch ID

On Fri, Apr 15, 2016 at 07:21:28PM -0400, Vivien Didelot wrote: > ps->id is not needed anymore, so remove it as well as the related > defined values. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Thanks Andrew

Re: [PATCH net-next] phy: make some bits preserved while setup forced mode

From: Weidong Wang Date: Thu, 14 Apr 2016 15:43:52 +0800 > When tested the PHY SGMII Loopback: > 1.set the LOOPBACK bit, > 2.set the autoneg to AUTONEG_DISABLE, it calls the > genphy_setup_forced which will clear the bit. > > The BMCR_LOOPBACK bit should be preserved. >

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

On Sat, Apr 16, 2016 at 12:17:11AM +0200, Alexandre Belloni wrote: > On 16/04/2016 at 00:05:08 +0200, Andrew Lunn wrote : > > > Trace without my patch: > > > libphy: MACB_mii_bus: probed > > > macb f802.ethernet eth0: Cadence GEM rev 0x00020120 at 0xf802 irq > > > 27 (fc:c2:3d:0c:6e:05) >

Re: qdisc spin lock

On Fri, 2016-04-15 at 15:46 -0700, Michael Ma wrote: > 2016-04-08 7:19 GMT-07:00 Eric Dumazet : > > On Thu, 2016-03-31 at 16:48 -0700, Michael Ma wrote: > >> I didn't really know that multiple qdiscs can be isolated using MQ so > >> that each txq can be associated with a

[PATCH net-next v2 2/7] net: dsa: mv88e6xxx: drop revision probing

There is no point in having special case for the revision when probing a switch model. The code gets cluttered with unnecessary defines, and leads to errors when code such as mv88e6131_setup compares PORT_SWITCH_ID_6131_B2 to ps->id which mask the revision. Drop every revision definitions, add a

Re: Poorer networking performance in later kernels?

On 04/15/2016 02:02 PM, Butler, Peter wrote: (Please keep me CC'd to all comments/responses) I've tried a kernel upgrade from 3.4.2 to 4.4.0 and see a marked drop in networking performance. Nothing was changed on the test systems, other than the kernel itself (and kernel modules). The

Re: qdisc spin lock

2016-04-15 15:54 GMT-07:00 Eric Dumazet : > On Fri, 2016-04-15 at 15:46 -0700, Michael Ma wrote: >> 2016-04-08 7:19 GMT-07:00 Eric Dumazet : >> > On Thu, 2016-03-31 at 16:48 -0700, Michael Ma wrote: >> >> I didn't really know that multiple qdiscs can

Re: [PATCH net-next v2 6/7] net: dsa: mv88e6xxx: add number of db to info

On Fri, Apr 15, 2016 at 07:21:27PM -0400, Vivien Didelot wrote: > Add the number of databases to the info structure. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Thanks Andrew

[PATCH net v2] vlan: pull on __vlan_insert_tag error path and fix csum correction

When __vlan_insert_tag() fails from skb_vlan_push() path due to the skb_cow_head(), we need to undo the __skb_push() in the error path as well that was done earlier to move skb->data pointer to mac header. Moreover, I noticed that when in the non-error path the __skb_pull() is done and the

Re: Poorer networking performance in later kernels?

On Fri, 2016-04-15 at 21:02 +, Butler, Peter wrote: > (Please keep me CC'd to all comments/responses) > > I've tried a kernel upgrade from 3.4.2 to 4.4.0 and see a marked drop in > networking performance. Nothing was changed on the test systems, other than > the kernel itself (and kernel

Re: qdisc spin lock

2016-04-08 7:19 GMT-07:00 Eric Dumazet : > On Thu, 2016-03-31 at 16:48 -0700, Michael Ma wrote: >> I didn't really know that multiple qdiscs can be isolated using MQ so >> that each txq can be associated with a particular qdisc. Also we don't >> really have multiple

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

On 16/04/2016 at 00:30:26 +0200, Andrew Lunn wrote : > On Sat, Apr 16, 2016 at 12:17:11AM +0200, Alexandre Belloni wrote: > > On 16/04/2016 at 00:05:08 +0200, Andrew Lunn wrote : > > > > Trace without my patch: > > > > libphy: MACB_mii_bus: probed > > > > macb f802.ethernet eth0: Cadence GEM

Re: [PATCH 2/3] phy: add generic function to support ksetting support

On 15/04/16 04:50, Fugang Duan wrote: From: Philippe Reynes Sent: Friday, April 15, 2016 6:35 AM To: da...@davemloft.net; de...@googlers.com; f.faine...@gmail.com; Fugang Duan Cc: linux-ker...@vger.kernel.org; netdev@vger.kernel.org; Philippe Reynes

[PATCH net-next v2 0/7] net: dsa: mv88e6xxx: factorize switch info

This patchset factorizes the mv88e6xxx code by sharing a new extendable info structure to store static data such as switch family, product number, number of ports, number of databases and the name. The next step is to add a "flags" bitmap member to the info structure in order to simplify the

[PATCH net-next v2 6/7] net: dsa: mv88e6xxx: add number of db to info

Add the number of databases to the info structure. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 3 +++ drivers/net/dsa/mv88e6131.c | 4 drivers/net/dsa/mv88e6171.c | 4 drivers/net/dsa/mv88e6352.c | 6 ++

[PATCH net-next v2 3/7] net: dsa: mv88e6xxx: add switch info

Add a new switch info structure which will be later extended to store switch models static information, such as product number, name, number of ports, number of databases, etc. Merge the lookup function in the probing code, so that we avoid multiple checking of the MII bus, as well a multiple ID

[PATCH net-next v2 5/7] net: dsa: mv88e6xxx: add number of ports to info

Drop the ps->num_ports variable for a new member of the info structure. This removes the need to assign it at setup time. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 16 +++- drivers/net/dsa/mv88e6131.c | 22

[PATCH net-next v2 7/7] net: dsa: mv88e6xxx: remove switch ID

ps->id is not needed anymore, so remove it as well as the related defined values. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx.c | 3 --- drivers/net/dsa/mv88e6xxx.h | 32 2 files changed, 35 deletions(-)

[PATCH net-next v2 4/7] net: dsa: mv88e6xxx: add family to info

Add an mv88e6xxx_family enum to the info structure for better family indentification. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 3 ++ drivers/net/dsa/mv88e6131.c | 4 +++ drivers/net/dsa/mv88e6171.c | 4 +++

[PATCH net-next v2 1/7] net: dsa: mv88e6xxx: drop double ds assignment

Every driver assigns ps->ds even though it gets assigned in the shared mv88e6xxx_setup_common function. Kill redundancy. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6123.c | 2 -- drivers/net/dsa/mv88e6131.c | 2 -- drivers/net/dsa/mv88e6171.c | 2

Re: [PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered_workqueue

From: Amitoj Kaur Chawla Date: Sat, 9 Apr 2016 17:27:45 +0530 > Replace deprecated create_singlethread_workqueue with > alloc_ordered_workqueue. > > Work items include getting tx/rx frame sizes, resetting MPI processor, > setting asic recovery bit so ordering seems

Re: [PATCH net-next v2] vxlan: synchronously and race-free destruction of vxlan sockets

On Sat, 09 Apr 2016 01:55:06 +0200 Hannes Frederic Sowa wrote: > > > On Sat, Apr 9, 2016, at 01:24, Cong Wang wrote: > > On Fri, Apr 8, 2016 at 1:55 PM, Hannes Frederic Sowa > > wrote: > > > Due to the fact that the udp socket is

Re: [PATCH net-next 7/7] net: dsa: mv88e6xxx: drop switch id

Hi Andrew, Andrew Lunn writes: >> -#define PORT_SWITCH_ID_6350 0x3710 >> -#define PORT_SWITCH_ID_6351 0x3750 >> -#define PORT_SWITCH_ID_6352 0x3520 > > NACK > > These numbers are not obvious. PORT_SWITCH_ID_6320 i can > understand. 0x1150 i have no idea what it is. 0x1150 is

Re: [PATCH for-next V1 0/2] mlx5_core: mlx5_ifc updates

From: Saeed Mahameed Date: Fri, 15 Apr 2016 20:10:07 +0300 > On Wed, Apr 13, 2016 at 7:11 PM, Saeed Mahameed wrote: >> Hi Dave and Doug >> >> Changes form V0: >> - 2nd patch commit message fixes. >> >> This series include mlx5_core updates

  1   2   >