Re: [PATCH v3 net 1/1] net sched actions: fix GETing actions

2016-09-15 Thread Sergei Shtylyov
On 9/13/2016 2:07 AM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim With the batch changes that translated transient actions into a temporary list lost in the translation was the fact that tcf_action_destroy() will eventually delete the action from the permanent location

Re: [PATCH] net/mlx4_en: fix off by one in error handling

2016-09-15 Thread Tariq Toukan
On 14/09/2016 7:08 PM, Sebastian Ott wrote: On Wed, 14 Sep 2016, Tariq Toukan wrote: On 14/09/2016 4:53 PM, Sebastian Ott wrote: On Wed, 14 Sep 2016, Tariq Toukan wrote: On 14/09/2016 2:09 PM, Sebastian Ott wrote: If an error occurs in mlx4_init_eq_table the index used in the err_out_unmap

[PATCH net-next V2 0/3] net/sched: cls_flower: Add ports masks

2016-09-15 Thread Or Gerlitz
Hi Dave, This series adds the ability to specify tcp/udp ports masks for TC/flower filter matches. I also removed an unused fields from the flower keys struct and clarified the format of the recently added vlan attibutes. Or. v1--> v2 changes: * fixes typo in patch #2 title and change

[PATCH net-next V2 1/3] net/sched: cls_flower: Support masking for matching on tcp/udp ports

2016-09-15 Thread Or Gerlitz
Add the definitions for src/dst udp/tcp port masks and use them when setting && dumping the relevant keys. Signed-off-by: Or Gerlitz Signed-off-by: Paul Blakey Acked-by: Jiri Pirko --- include/uapi/linux/pkt_cls.h | 4

[PATCH net-next V2 2/3] net/sched: cls_flower: Remove an unused field from the filter key structure

2016-09-15 Thread Or Gerlitz
Commit c3f8324188fa "net: Add full IPv6 addresses to flow_keys" added an unused instance of struct flow_dissector_key_addrs into struct fl_flow_key, remove it. Signed-off-by: Or Gerlitz Reported-by: Hadar Hen Zion Acked-by: Jiri Pirko

[PATCH net-next V2 3/3] net/sched: cls_flower: Specify vlan attributes format in the UAPI header

2016-09-15 Thread Or Gerlitz
Specify the format (size and endianess) for the vlan attributes. Signed-off-by: Or Gerlitz Acked-by: Jiri Pirko --- include/uapi/linux/pkt_cls.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/uapi/linux/pkt_cls.h

[PATCH net-next 0/3] mlx5e Order-0 pages for Striding RQ

2016-09-15 Thread Tariq Toukan
Hi Dave, In this series, we refactor our Striding RQ receive-flow to always use fragmented WQEs (Work Queue Elements) using order-0 pages, omitting the flow that allocates and splits high-order pages which would fragment and deplete high-order pages in the system. The first patch gives a slight

[PATCH] mwifiex: fix null pointer deference when adapter is null

2016-09-15 Thread Colin King
From: Colin Ian King If adapter is null the error exit path in mwifiex_shutdown_sw is to down the semaphore sem and print some debug via mwifiex_dbg. However, passing a NULL adapter to mwifiex_dbg causes a null pointer deference when accessing adapter->dev. This fix

[PATCH net 4/7] qeth: check not more than 16 SBALEs on the completion queue

2016-09-15 Thread Ursula Braun
af_iucv socket programs with HiperSockets as transport make use of the qdio completion queue. Running such an af_iucv socket program may result in a crash: [90341.677709] Oops: 0038 ilc:2 [#1] SMP [90341.677743] CPU: 1 PID: 0 Comm: swapper/1 Not tainted

[PATCH net 2/7] s390/qeth: use ip_lock for hsuid configuration

2016-09-15 Thread Ursula Braun
qeth_l3_dev_hsuid_store() changes the ip hash table, which requires the ip_lock. Signed-off-by: Ursula Braun --- drivers/s390/net/qeth_l3_sys.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/s390/net/qeth_l3_sys.c b/drivers/s390/net/qeth_l3_sys.c

[PATCH net 1/7] qeth: restore device features after recovery

2016-09-15 Thread Ursula Braun
From: Hans Wippel After device recovery, only a basic set of network device features is enabled on the device. If features like checksum offloading or TSO were enabled by the user before the recovery, this results in a mismatch between the network device features,

[PATCH net 7/7] s390/qeth: fix setting VIPA address

2016-09-15 Thread Ursula Braun
From: Thomas Richter commit 5f78e29ceebf ("qeth: optimize IP handling in rx_mode callback") restructured the internal address handling. This work broke setting a virtual IP address. The command echo 10.1.1.1 > /sys/bus/ccwgroup/devices//vipa/add4 fails with file exist

[PATCH net 5/7] qeth: do not limit number of gso segments

2016-09-15 Thread Ursula Braun
To reduce the need of skb_linearize() calls, gso_max_segs of qeth net_devices had been limited according to the maximum number of qdio SBAL elements. But a gso segment cannot be larger than the mtu-size, while an SBAL element can contain up to 4096 bytes. The gso_max_segs limitation limits the

[PATCH net 3/7] s390/qeth: allow hsuid configuration in DOWN state

2016-09-15 Thread Ursula Braun
The qeth IP address mapping logic has been reworked recently. It causes now problems to specify qeth sysfs attribute "hsuid" in DOWN state, which is allowed. Postpone registering or deregistering of IP-addresses in this case. Signed-off-by: Ursula Braun Reviewed-by:

[PATCH net-next 0/2] i40e: clean-up and fix for the i40e debug code

2016-09-15 Thread Stefan Assmann
Stefan Assmann (2): i40e: remove superfluous I40E_DEBUG_USER statement i40e: fix setting debug parameter early drivers/net/ethernet/intel/i40e/i40e_common.c | 3 -- drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 6 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 --

Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from refclk freq

2016-09-15 Thread Richard Cochran
On Thu, Sep 15, 2016 at 01:58:15PM +0200, Richard Cochran wrote: > Can the input clock be higher than 1 GHz? If not, I suggest using > clocks_calc_mult_shift() with maxsec=4 and a setting the watchdog also > to 4*HZ. On second thought, with the new 12% timer batching, using 4*HZ for 32 bits of 1

[PATCH net-next 1/2] i40e: remove superfluous I40E_DEBUG_USER statement

2016-09-15 Thread Stefan Assmann
This debug statement is confusing and never set in the code. Any debug output should be guarded by the proper I40E_DEBUG_* statement which can be enabled via the debug module parameter. Remove or convert the I40E_DEBUG_USER cases to I40E_DEBUG_INIT. Signed-off-by: Stefan Assmann

[PATCH net-next 2/2] i40e: fix setting debug parameter early

2016-09-15 Thread Stefan Assmann
pf->msg_enable is a bitmask, therefore assigning the value of the "debug" parameter is wrong. It is initialized again later in i40e_sw_init() so it didn't cause any problem, except that we missed early debug messages. Moved the initialization and assigned pf->hw.debug_mask the bitmask as that's

[PATCH net-next 3/3] net/mlx5e: Implement RX mapped page cache for page recycle

2016-09-15 Thread Tariq Toukan
Instead of reallocating and mapping pages for RX data-path, recycle already used pages in a per ring cache. Performance tests: The following results were measured on a freshly booted system, giving optimal baseline performance, as high-order pages are yet to be fragmented and depleted. We ran

[PATCH net-next 2/3] net/mlx5e: Introduce API for RX mapped pages

2016-09-15 Thread Tariq Toukan
Manage the allocation and deallocation of mapped RX pages only through dedicated API functions. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 46 +++-- 1 file

[PATCH net-next 1/3] net/mlx5e: Single flow order-0 pages for Striding RQ

2016-09-15 Thread Tariq Toukan
To improve the memory consumption scheme, we omit the flow that demands and splits high-order pages in Striding RQ, and stay with a single Striding RQ flow that uses order-0 pages. Moving to fragmented memory allows the use of larger MPWQEs, which reduces the number of UMR posts and filler CQEs.

Re: [PATCH] mwifiex: fix null pointer deference when adapter is null

2016-09-15 Thread Julian Calaby
Hi All, On Thu, Sep 15, 2016 at 11:42 PM, Colin King wrote: > From: Colin Ian King > > If adapter is null the error exit path in mwifiex_shutdown_sw is > to down the semaphore sem and print some debug via mwifiex_dbg. > However, passing a NULL

[PATCH net 6/7] qeth: do not turn on SG per default

2016-09-15 Thread Ursula Braun
According to recent performance measurements, turning on net_device feature NETIF_F_SG only behaves well, but turning on feature NETIF_F_GSO shows bad results. Since the kernel activates NETIF_F_GSO automatically as soon as the driver configures feature NETIF_F_SG, qeth should not activate feature

[PATCH net 0/7] 390: qeth patches

2016-09-15 Thread Ursula Braun
Hi Dave, here are several fixes for the s390 qeth driver, built for net. Thanks, Ursula Hans Wippel (1): qeth: restore device features after recovery Thomas Richter (1): s390/qeth: fix setting VIPA address Ursula Braun (5): s390/qeth: use ip_lock for hsuid configuration s390/qeth:

I hope this email meets you well in good health condition

2016-09-15 Thread Jones
How you doing today? I hope you are doing well. My name is Jones, from the US. I'm in Syria right now fighting ISIS. I want to get to know you better, if I may be so bold. I consider myself an easy-going man, and I am currently looking for a relationship in which I feel loved. Please tell me

Re: [RFC 06/11] Add support for QP verbs

2016-09-15 Thread Leon Romanovsky
On Mon, Sep 12, 2016 at 07:07:40PM +0300, Ram Amrani wrote: > Add support for Queue Pair verbs which adds, deletes, > modifies and queries Queue Pairs. > > Signed-off-by: Rajesh Borundia > Signed-off-by: Ram Amrani > --- >

RE: [RFC 09/11] Add LL2 RoCE interface

2016-09-15 Thread Amrani, Ram
> > + DP_ERR(cdev, > > + "QED RoCE set MAC filter failed - roce_info/ll2 NULL\n"); > > + return -EINVAL; > > + } > > + > > + p_ptt = qed_ptt_acquire(QED_LEADING_HWFN(cdev)); > > + if (!p_ptt) { > > + DP_ERR(cdev, > > + "qed roce

Re: [PATCH] iproute2: build nsid-name cache only for commands that need it

2016-09-15 Thread Nicolas Dichtel
Le 15/09/2016 à 10:23, Anton Aksola a écrit : [snip] > --- a/ip/ipnetns.c > +++ b/ip/ipnetns.c > @@ -775,8 +775,6 @@ static int netns_monitor(int argc, char **argv) > > int do_netns(int argc, char **argv) > { > - netns_map_init(); > - > if (argc < 1) > return

Re: [Xen-devel] [RFC PATCH] xen-netback: fix error handling on netback_probe()

2016-09-15 Thread Filipe Manco
On 14-09-2016 12:10, Wei Liu wrote: CC xen-devel as well. On Tue, Sep 13, 2016 at 02:11:27PM +0200, Filipe Manco wrote: In case of error during netback_probe() (e.g. an entry missing on the xenstore) netback_remove() is called on the new device, which will set the device backend state to

Re: [Xen-devel] [RFC PATCH] xen-netback: fix error handling on netback_probe()

2016-09-15 Thread Wei Liu
On Thu, Sep 15, 2016 at 04:05:17PM +0200, Filipe Manco wrote: > On 14-09-2016 12:10, Wei Liu wrote: > >CC xen-devel as well. > > > >On Tue, Sep 13, 2016 at 02:11:27PM +0200, Filipe Manco wrote: > >>In case of error during netback_probe() (e.g. an entry missing on the > >>xenstore) netback_remove()

[PATCH net] net: avoid sk_forward_alloc overflows

2016-09-15 Thread Eric Dumazet
From: Eric Dumazet A malicious TCP receiver, sending SACK, can force the sender to split skbs in write queue and increase its memory usage. Then, when socket is closed and its write queue purged, we might overflow sk_forward_alloc (It becomes negative) sk_mem_reclaim()

RE: [PATCH net] tcp: fix overflow in __tcp_retransmit_skb()

2016-09-15 Thread David Laight
From: Eric Dumazet > Sent: 15 September 2016 16:13 > If a TCP socket gets a large write queue, an overflow can happen > in a test in __tcp_retransmit_skb() preventing all retransmits. ... > if (atomic_read(>sk_wmem_alloc) > > - min(sk->sk_wmem_queued + (sk->sk_wmem_queued >> 2),

[PATCH] mwifiex: fix memory leak on regd when chan is zero

2016-09-15 Thread Colin King
From: Colin Ian King When chan is zero mwifiex_create_custom_regdomain does not kfree regd and we have a memory leak. Fix this by freeing regd before the return. Signed-off-by: Colin Ian King ---

[PATCH net-next] tcp: prepare skbs for better sack shifting

2016-09-15 Thread Eric Dumazet
From: Eric Dumazet With large BDP TCP flows and lossy networks, it is very important to keep a low number of skbs in the write queue. RACK and SACK processing can perform a linear scan of it. We should avoid putting any payload in skb->head, so that SACK shifting can be

[net-next PATCH] net: netlink messages for HW addr programming

2016-09-15 Thread Patrick Ruddy
Add RTM_NEWADDR and RTM_DELADDR netlink messages with family AF_UNSPEC to indicate interest in specific unicast and multicast hardware addresses. These messages are sent when addresses are added or deleted from the appropriate interface driver. Added AF_UNSPEC GETADDR function to allow the netlink

Re: [PATCH] mwifiex: fix null pointer deference when adapter is null

2016-09-15 Thread kbuild test robot
Hi Colin, [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on next-20160915] [cannot apply to v4.8-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --b

Re: [PATCH net] tcp: fix overflow in __tcp_retransmit_skb()

2016-09-15 Thread Eric Dumazet
On Thu, 2016-09-15 at 15:52 +, David Laight wrote: > From: Eric Dumazet > > Sent: 15 September 2016 16:13 > > If a TCP socket gets a large write queue, an overflow can happen > > in a test in __tcp_retransmit_skb() preventing all retransmits. > ... > > if (atomic_read(>sk_wmem_alloc) > > >

[PATCH] irda: Free skb on irda_accept error path.

2016-09-15 Thread Phil Turnbull
skb is not freed if newsk is NULL. Rework the error path so free_skb is unconditionally called on function exit. Fixes: c3ea9fa27413 ("[IrDA] af_irda: IRDA_ASSERT cleanups") Signed-off-by: Phil Turnbull --- net/irda/af_irda.c | 5 ++--- 1 file changed, 2 insertions(+),

Re: [PATCH] mwifiex: fix memory leak on regd when chan is zero

2016-09-15 Thread Kalle Valo
Colin King writes: > From: Colin Ian King > > When chan is zero mwifiex_create_custom_regdomain does not kfree > regd and we have a memory leak. Fix this by freeing regd before > the return. > > Signed-off-by: Colin Ian King

Re: [PATCH 3/3] mm: memcontrol: consolidate cgroup socket tracking

2016-09-15 Thread Johannes Weiner
es was built on] > > [Check https://git-scm.com/docs/git-format-patch for more information] > > > > url: > > https://github.com/0day-ci/linux/commits/Johannes-Weiner/mm-memcontrol-make-per-cpu-charge-cache-IRQ-safe-for-socket-accounting/20160915-035634 > > confi

Re: [PATCH V3 1/3] Documentation: devicetree: add qca8k binding

2016-09-15 Thread Andrew Lunn
B1;2802;0cOn Thu, Sep 15, 2016 at 04:26:39PM +0200, John Crispin wrote: > Add device-tree binding for ar8xxx switch families. > > Cc: devicet...@vger.kernel.org > Signed-off-by: John Crispin Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v2 3/5] cxgb4: add parser to translate u32 filters to internal spec

2016-09-15 Thread John Fastabend
On 16-09-13 04:42 AM, Rahul Lakkireddy wrote: > Parse information sent by u32 into internal filter specification. > Add support for parsing several fields in IPv4, IPv6, TCP, and UDP. > > Signed-off-by: Rahul Lakkireddy > Signed-off-by: Hariprasad Shenai

[PATCH V3 3/3] net-next: dsa: add new driver for qca8xxx family

2016-09-15 Thread John Crispin
This patch contains initial support for the QCA8337 switch. It will detect a QCA8337 switch, if present and declared in the DT. Each port will be represented through a standalone net_device interface, as for other DSA switches. CPU can communicate with any of the ports by setting an IP@ on ethN

[PATCH V3 1/3] Documentation: devicetree: add qca8k binding

2016-09-15 Thread John Crispin
Add device-tree binding for ar8xxx switch families. Cc: devicet...@vger.kernel.org Signed-off-by: John Crispin --- Changes in V2 * fixup example to include phy nodes and corresponding phandles * add a note explaining why we need to phy nodes Changes in V3 * add note stating

Re: [net-next,RFC,1/2] fib: introduce fib notification infrastructure

2016-09-15 Thread Andy Gospodarek
On Tue, Sep 6, 2016 at 8:01 AM, Jiri Pirko wrote: > From: Jiri Pirko > > This allows to pass information about added/deleted fib entries to > whoever is interested. This is done in a very similar way as devinet > notifies address

Re: [4.4-RT PATCH RFC/RFT] drivers: net: cpsw: mark rx/tx irq as IRQF_NO_THREAD

2016-09-15 Thread Sebastian Andrzej Siewior
On 2016-09-09 15:46:44 [+0300], Grygorii Strashko wrote: > > It looks like scheduler playing ping-pong between CPUs with threaded irqs > irq/354-355. > And seems this might be the case - if I pin both threaded IRQ handlers to CPU0 > I can see better latency and netperf improvement > cyclictest

Re: [net-next,RFC,1/2] fib: introduce fib notification infrastructure

2016-09-15 Thread Andy Gospodarek
On Thu, Sep 15, 2016 at 10:45 AM, Jiri Pirko wrote: > Thu, Sep 15, 2016 at 04:41:20PM CEST, a...@greyhouse.net wrote: >>On Tue, Sep 6, 2016 at 8:01 AM, Jiri Pirko >> wrote: >>> From: Jiri Pirko >>> >>> This allows to pass

Re: [PATCH RFC 01/11] net/mlx5e: Single flow order-0 pages for Striding RQ

2016-09-15 Thread Tariq Toukan
Hi Alexei, On 07/09/2016 8:31 PM, Alexei Starovoitov wrote: On Wed, Sep 07, 2016 at 03:42:22PM +0300, Saeed Mahameed wrote: From: Tariq Toukan To improve the memory consumption scheme, we omit the flow that demands and splits high-order pages in Striding RQ, and stay

Re: [net-next PATCH 00/11] iw_cxgb4,cxgbit: remove duplicate code

2016-09-15 Thread Varun Prakash
Hi Or, On Wed, Sep 14, 2016 at 02:02:43PM +0530, Or Gerlitz wrote: > On Tue, Sep 13, 2016 at 6:53 PM, Varun Prakash wrote: > > This patch series removes duplicate code from > > iw_cxgb4 and cxgbit by adding common function definitions in libcxgb. > > Is that bunch of misc

[PATCH V3 0/3] net-next: dsa: add QCA8K support

2016-09-15 Thread John Crispin
This series is based on the AR8xxx series posted by Matthieu Olivari in may 2015. The following changes were made since then * fixed the nitpicks from the previous review * updated to latest API * turned it into an mdio device * added callbacks for fdb, bridge offloading, stp, eee, port status *

[PATCH V3 2/3] net-next: dsa: add Qualcomm tag RX/TX handler

2016-09-15 Thread John Crispin
Add support for the 2-bytes Qualcomm tag that gigabit switches such as the QCA8337/N might insert when receiving packets, or that we need to insert while targeting specific switch ports. The tag is inserted directly behind the ethernet header. Reviewed-by: Andrew Lunn

Re: [PATCH RFC 01/11] net/mlx5e: Single flow order-0 pages for Striding RQ

2016-09-15 Thread Tariq Toukan
Hi Jesper, On 07/09/2016 10:18 PM, Jesper Dangaard Brouer wrote: On Wed, 7 Sep 2016 15:42:22 +0300 Saeed Mahameed wrote: From: Tariq Toukan To improve the memory consumption scheme, we omit the flow that demands and splits high-order pages in

[PATCH v2] xen-netback: fix error handling on netback_probe()

2016-09-15 Thread Filipe Manco
In case of error during netback_probe() (e.g. an entry missing on the xenstore) netback_remove() is called on the new device, which will set the device backend state to XenbusStateClosed by calling set_backend_state(). However, the backend state wasn't initialized by netback_probe() at this point,

[PATCH net] tcp: fix overflow in __tcp_retransmit_skb()

2016-09-15 Thread Eric Dumazet
From: Eric Dumazet If a TCP socket gets a large write queue, an overflow can happen in a test in __tcp_retransmit_skb() preventing all retransmits. The flow then stalls and resets after timeouts. Tested: sysctl -w net.core.wmem_max=10 netperf -H dest -- -s

Re: [net-next,RFC,1/2] fib: introduce fib notification infrastructure

2016-09-15 Thread Jiri Pirko
Thu, Sep 15, 2016 at 04:41:20PM CEST, a...@greyhouse.net wrote: >On Tue, Sep 6, 2016 at 8:01 AM, Jiri Pirko > wrote: >> From: Jiri Pirko >> >> This allows to pass information about added/deleted fib entries to >> whoever is interested. This is

pull-request: wireless-drivers-next 2016-09-15

2016-09-15 Thread Kalle Valo
Hi Dave, here's the first pull request for 4.9. The ones I want to point out are the FIELD_PREP() and FIELD_GET() macros added to bitfield.h, which are reviewed by Linus, and make it possible to remove util.h from mt7601u. Also we have new HW support to various drivers and other smaller

[PATCH] llc: switch type to bool as the timeout is only tested versus 0

2016-09-15 Thread Alan
(As asked by Dave in Februrary) Signed-off-by: Alan Cox --- net/llc/af_llc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c index 8ae3ed9..db916cf 100644 --- a/net/llc/af_llc.c +++ b/net/llc/af_llc.c @@ -38,7

[PATCH net] sctp: fix SSN comparision

2016-09-15 Thread Marcelo Ricardo Leitner
This function actually operates on u32 yet its paramteres were declared as u16, causing integer truncation upon calling. Note in patch context that ADDIP_SERIAL_SIGN_BIT is already 32 bits. Signed-off-by: Marcelo Ricardo Leitner --- This issue exists since before git

[PATCH net-next] net: l3mdev: Remove netif_index_is_l3_master

2016-09-15 Thread David Ahern
No longer used after e0d56fdd73422 ("net: l3mdev: remove redundant calls") Signed-off-by: David Ahern --- include/net/l3mdev.h | 24 1 file changed, 24 deletions(-) diff --git a/include/net/l3mdev.h b/include/net/l3mdev.h index

Re: [PATCH net-next] tcp: prepare skbs for better sack shifting

2016-09-15 Thread Yuchung Cheng
On Thu, Sep 15, 2016 at 9:33 AM, Eric Dumazet wrote: > > From: Eric Dumazet > > With large BDP TCP flows and lossy networks, it is very important > to keep a low number of skbs in the write queue. > > RACK and SACK processing can perform a linear scan

[PATCH net-next] net: vrf: Remove RT_FL_TOS

2016-09-15 Thread David Ahern
No longer used after d66f6c0a8f3c0 ("net: ipv4: Remove l3mdev_get_saddr") Signed-off-by: David Ahern --- drivers/net/vrf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index 55674b0e65b7..85c271c70d42 100644 ---

Re: [PATCH net-next 1/7] lwt: Add net to build_state argument

2016-09-15 Thread Roopa Prabhu
On 9/14/16, 4:22 PM, Tom Herbert wrote: > Users of LWT need to know net if they want to have per net operations > in LWT. > > Signed-off-by: Tom Herbert > --- > Acked-by: Roopa Prabhu

Re: [PATCH] mwifiex: fix memory leak on regd when chan is zero

2016-09-15 Thread Colin Ian King
On 15/09/16 18:10, Kalle Valo wrote: > Colin King writes: > >> From: Colin Ian King >> >> When chan is zero mwifiex_create_custom_regdomain does not kfree >> regd and we have a memory leak. Fix this by freeing regd before >> the return. >> >>

MDB offloading of local ipv4 multicast groups

2016-09-15 Thread John Crispin
Hi, While adding MDB support to the qca8k dsa driver I found that ipv4 mcast groups don't always get propagated to the dsa driver. In my setup there are 2 clients connected to the switch, both running a mdns client. The .port_mdb_add() callback is properly called for 33:33:00:00:00:FB but

[PATCHv4 net-next 02/15] net: cls_bpf: limit hardware offload by software-only flag

2016-09-15 Thread Jakub Kicinski
Add cls_bpf support for the TCA_CLS_FLAGS_SKIP_HW flag. Unlike U32 and flower cls_bpf already has some netlink flags defined. Create a new attribute to be able to use the same flag values as the above. Unlike U32 and flower reject unknown flags. Signed-off-by: Jakub Kicinski

[PATCHv4 net-next 14/15] nfp: bpf: add support for legacy redirect action

2016-09-15 Thread Jakub Kicinski
Data path has redirect support so expressing redirect to the port frame came from is a trivial matter of setting the right result code. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_bpf.h | 1 +

[PATCHv4 net-next 01/15] net: cls_bpf: add hardware offload

2016-09-15 Thread Jakub Kicinski
This patch adds hardware offload capability to cls_bpf classifier, similar to what have been done with U32 and flower. Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann --- v3: - s/filter/prog/ in struct tc_cls_bpf_offload. v2: - drop

[PATCHv4 net-next 00/15] BPF hardware offload (cls_bpf for now)

2016-09-15 Thread Jakub Kicinski
Hi! Dave, this set depends on bitfield.h which is sitting in the pull request from Kalle. I'm expecting buildbot to complain about patch 8, please pull wireless-drivers-next before applying. v4: - rename parser -> analyzer; - reorganize the analyzer patches a bit; - use bitfield.h directly.

[PATCHv4 net-next 13/15] net: act_mirred: allow statistic updates from offloaded actions

2016-09-15 Thread Jakub Kicinski
Implement .stats_update() callback. The implementation is generic and can be reused by other simple actions if needed. Signed-off-by: Jakub Kicinski --- net/sched/act_mirred.c | 8 1 file changed, 8 insertions(+) diff --git a/net/sched/act_mirred.c

[PATCHv4 net-next 08/15] nfp: add BPF to NFP code translator

2016-09-15 Thread Jakub Kicinski
Add translator for JITing eBPF to operations which can be executed on NFP's programmable engines. Signed-off-by: Jakub Kicinski --- v4: - use bitfield.h directly. v3: - don't clone the program for the verifier (no longer needed); - temporarily add a local copy of

[PATCHv4 net-next 06/15] bpf: enable non-core use of the verfier

2016-09-15 Thread Jakub Kicinski
Advanced JIT compilers and translators may want to use eBPF verifier as a base for parsers or to perform custom checks and validations. Add ability for external users to invoke the verifier and provide callbacks to be invoked for every intruction checked. For now only add most basic callback for

[PATCHv4 net-next 11/15] nfp: bpf: allow offloaded filters to update stats

2016-09-15 Thread Jakub Kicinski
Periodically poll stats and call into offloaded actions to update them. Signed-off-by: Jakub Kicinski --- v3: - add missing hunk with ethtool stats. --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 19 +++

[PATCHv4 net-next 09/15] nfp: bpf: add hardware bpf offload

2016-09-15 Thread Jakub Kicinski
Add hardware bpf offload on our smart NICs. Detect if capable firmware is loaded and use it to load the code JITed with just added translator onto programmable engines. This commit only supports offloading cls_bpf in legacy mode (non-direct action). Signed-off-by: Jakub Kicinski

[PATCHv4 net-next 03/15] net: cls_bpf: add support for marking filters as hardware-only

2016-09-15 Thread Jakub Kicinski
Add cls_bpf support for the TCA_CLS_FLAGS_SKIP_SW flag. Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann --- net/sched/cls_bpf.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git

[PATCHv4 net-next 12/15] nfp: bpf: add packet marking support

2016-09-15 Thread Jakub Kicinski
Add missing ABI defines and eBPF instructions to allow mark to be passed on and extend prepend parsing on the RX path to pick it up from packet metadata. Signed-off-by: Jakub Kicinski --- v3: - change metadata format. ---

[PATCHv4 net-next 05/15] bpf: expose internal verfier structures

2016-09-15 Thread Jakub Kicinski
Move verifier's internal structures to a header file and prefix their names with bpf_ to avoid potential namespace conflicts. Those structures will soon be used by external analyzers. Signed-off-by: Jakub Kicinski --- v4: - separate from adding the analyzer; -

[PATCHv4 net-next 04/15] bpf: don't (ab)use instructions to store state

2016-09-15 Thread Jakub Kicinski
Storing state in reserved fields of instructions makes it impossible to run verifier on programs already marked as read-only. Allocate and use an array of per-instruction state instead. While touching the error path rename and move existing jump target. Suggested-by: Alexei Starovoitov

[PATCHv4 net-next 10/15] net: cls_bpf: allow offloaded filters to update stats

2016-09-15 Thread Jakub Kicinski
Call into offloaded filters to update stats. Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann --- include/net/pkt_cls.h | 1 + net/sched/cls_bpf.c | 11 +++ 2 files changed, 12 insertions(+) diff --git

[PATCHv4 net-next 07/15] bpf: recognize 64bit immediate loads as consts

2016-09-15 Thread Jakub Kicinski
When running as parser interpret BPF_LD | BPF_IMM | BPF_DW instructions as loading CONST_IMM with the value stored in imm. The verifier will continue not recognizing those due to concerns about search space/program complexity increase. Signed-off-by: Jakub Kicinski

[PATCHv4 net-next 15/15] nfp: bpf: add offload of TC direct action mode

2016-09-15 Thread Jakub Kicinski
Add offload of TC in direct action mode. We just need to provide appropriate checks in the verifier and a new outro block to translate the exit codes to what data path expects Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_bpf.h |

XDP user interface confusions

2016-09-15 Thread Jesper Dangaard Brouer
Hi Brenden, I don't quite understand the semantics of the XDP userspace interface. We allow XDP programs to be (unconditionally) exchanged by another program, this avoids taking the link down+up and avoids reallocating RX ring resources (which is great). We have two XDP samples programs in

[PATCH next] sctp: make use of WORD_TRUNC macro

2016-09-15 Thread Marcelo Ricardo Leitner
No functional change. Just to avoid the usage of '&~3'. Also break the line to make it easier to read. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/chunk.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/sctp/chunk.c

XDP user interface conclusions

2016-09-15 Thread Jesper Dangaard Brouer
Hi Brenden, I don't quite understand the semantics of the XDP userspace interface. We allow XDP programs to be (unconditionally) exchanged by another program, this avoids taking the link down+up and avoids reallocating RX ring resources (which is great). We have two XDP samples programs in

Re: XDP user interface confusions

2016-09-15 Thread Brenden Blanco
On Thu, Sep 15, 2016 at 08:14:02PM +0200, Jesper Dangaard Brouer wrote: > Hi Brenden, > > I don't quite understand the semantics of the XDP userspace interface. > > We allow XDP programs to be (unconditionally) exchanged by another > program, this avoids taking the link down+up and avoids

Re: [RFC v3 18/22] cgroup,landlock: Add CGRP_NO_NEW_PRIVS to handle unprivileged hooks

2016-09-15 Thread Mickaël Salaün
On 15/09/2016 03:25, Andy Lutomirski wrote: > On Wed, Sep 14, 2016 at 3:11 PM, Mickaël Salaün wrote: >> >> On 14/09/2016 20:27, Andy Lutomirski wrote: >>> On Wed, Sep 14, 2016 at 12:24 AM, Mickaël Salaün wrote: Add a new flag CGRP_NO_NEW_PRIVS for each

Re: [RFC v3 18/22] cgroup,landlock: Add CGRP_NO_NEW_PRIVS to handle unprivileged hooks

2016-09-15 Thread Mickaël Salaün
On 15/09/2016 06:48, Alexei Starovoitov wrote: > On Wed, Sep 14, 2016 at 09:38:16PM -0700, Andy Lutomirski wrote: >> On Wed, Sep 14, 2016 at 9:31 PM, Alexei Starovoitov >> wrote: >>> On Wed, Sep 14, 2016 at 09:08:57PM -0700, Andy Lutomirski wrote: On Wed, Sep

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-15 Thread David Ahern
On 9/13/16 11:19 AM, Cyrill Gorcunov wrote: > In criu we are actively using diag interface to collect sockets > present in the system when dumping applications. And while for > unix, tcp, udp[lite], packet, netlink it works as expected, > the raw sockets do not have. Thus add it. > > v2: > - add

[PATCH net-next 1/4] ip_tunnel: add collect_md mode to IPIP tunnel

2016-09-15 Thread Alexei Starovoitov
Similar to gre, vxlan, geneve tunnels allow IPIP tunnels to operate in 'collect metadata' mode. bpf_skb_[gs]et_tunnel_key() helpers can make use of it right away. ovs can use it as well in the future (once appropriate ovs-vport abstractions and user apis are added). Note that just like in other

[PATCH net-next 4/4] samples/bpf: add comprehensive ipip, ipip6, ip6ip6 test

2016-09-15 Thread Alexei Starovoitov
the test creates 3 namespaces with veth connected via bridge. First two namespaces simulate two different hosts with the same IPv4 and IPv6 addresses configured on the tunnel interface and they communicate with outside world via standard tunnels. Third namespace creates collect_md tunnel that is

[PATCH net-next 2/4] ip6_tunnel: add collect_md mode to IPv6 tunnels

2016-09-15 Thread Alexei Starovoitov
Similar to gre, vxlan, geneve tunnels allow IPIP6 and IP6IP6 tunnels to operate in 'collect metadata' mode. Unlike ipv4 code here it's possible to reuse ip6_tnl_xmit() function for both collect_md and traditional tunnels. bpf_skb_[gs]et_tunnel_key() helpers and ovs (in the future) are the users.

[PATCH net-next 3/4] samples/bpf: extend test_tunnel_bpf.sh with IPIP test

2016-09-15 Thread Alexei Starovoitov
extend existing tests for vxlan, geneve, gre to include IPIP tunnel. It tests both traditional tunnel configuration and dynamic via bpf helpers. Signed-off-by: Alexei Starovoitov --- samples/bpf/tcbpf2_kern.c | 58 ++

[PATCH net-next 0/4] ip_tunnel: add collect_md mode to IPv4/IPv6 tunnels

2016-09-15 Thread Alexei Starovoitov
Similar to geneve, vxlan, gre tunnels implement 'collect metadata' mode in ipip, ipip6, ip6ip6 tunnels. Alexei Starovoitov (4): ip_tunnel: add collect_md mode to IPIP tunnel ip6_tunnel: add collect_md mode to IPv6 tunnels samples/bpf: extend test_tunnel_bpf.sh with IPIP test samples/bpf:

Re: [PATCH net-next] net/sched: act_tunnel_key: Remove rcu_read_lock protection

2016-09-15 Thread David Miller
From: Hadar Hen Zion Date: Mon, 12 Sep 2016 15:19:21 +0300 > Remove rcu_read_lock protection from tunnel_key_dump and use > rtnl_dereference, dump operation is protected by rtnl lock. > > Also, remove rcu_read_lock from tunnel_key_release and use >

RE: [Intel-wired-lan] [net-next PATCH v3 1/3] e1000: track BQL bytes regardless of skb or not

2016-09-15 Thread Brown, Aaron F
> > [ cut here ] > > WARNING: CPU: 1 PID: 0 at net/sched/sch_generic.c:316 > dev_watchdog+0x1c2/0x1d0 > > NETDEV WATCHDOG: eth1 (e1000): transmit queue 0 timed out > > Thanks a lot for the tests! Really appreciate it. np, I needed to get my old compatibility systems back

Re: [PATCH 0/5] Make /sys/class/net per net namespace objects belong to container

2016-09-15 Thread Eric W. Biederman
Dmitry Torokhov writes: > On Mon, Aug 29, 2016 at 5:38 AM, Eric W. Biederman > wrote: >> David Miller writes: >> >>> From: Dmitry Torokhov >>> Date: Tue, 16 Aug 2016 15:33:10 -0700 >>> There

Re: Modification to skb->queue_mapping affecting performance

2016-09-15 Thread Michael Ma
2016-09-14 10:46 GMT-07:00 Michael Ma : > 2016-09-13 22:22 GMT-07:00 Eric Dumazet : >> On Tue, 2016-09-13 at 22:13 -0700, Michael Ma wrote: >> >>> I don't intend to install multiple qdisc - the only reason that I'm >>> doing this now is to leverage MQ to

Re: [net-next PATCH 00/11] iw_cxgb4,cxgbit: remove duplicate code

2016-09-15 Thread David Miller
From: Varun Prakash Date: Tue, 13 Sep 2016 21:23:55 +0530 > This patch series removes duplicate code from > iw_cxgb4 and cxgbit by adding common function > definitions in libcxgb. > > Please review. Series applied, thanks.

Re: [PATCH V3 1/3] Documentation: devicetree: add qca8k binding

2016-09-15 Thread Florian Fainelli
On 09/15/2016 07:26 AM, John Crispin wrote: > Add device-tree binding for ar8xxx switch families. > > Cc: devicet...@vger.kernel.org > Signed-off-by: John Crispin Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v6 net-next 1/1] net_sched: Introduce skbmod action

2016-09-15 Thread David Miller
From: Jamal Hadi Salim Date: Mon, 12 Sep 2016 20:13:09 -0400 > From: Jamal Hadi Salim > > This action is intended to be an upgrade from a usability perspective > from pedit (as well as operational debugability). > Compare this: > > sudo tc filter add dev

cdc_ncm driver padding problem (WAS: Question about CDC_NCM_FLAG_NDP_TO_END)

2016-09-15 Thread Enrico Mioso
Hello guys. Some very good people managed to detect there is a problem with some Huawei firmwares and NCM padding. I actually don't think I have the hardware to test btw. On Wed, 14 Sep 2016, Marek Brudka wrote: Sorry Marek - I forwarded this message without asking for your consent. Let me

  1   2   >