Re: [PATCH net-next] net/vxlan: Avoid unaligned access in vxlan_build_skb()

2016-09-23 Thread Alexander Duyck
On Fri, Sep 23, 2016 at 4:41 PM, Sowmini Varadhan wrote: > On (09/23/16 10:38), Alexander Duyck wrote: >> >> So basically what I was thinking is we do something like reserving >> NET_IP_ALIGN and continue writing headers to skb->data, but we force >> the tracking for

Re: [Intel-wired-lan] [PATCH net-next v2 2/2] i40e: fix setting debug parameter early

2016-09-23 Thread Alexander Duyck
On Fri, Sep 23, 2016 at 6:30 AM, Stefan Assmann wrote: > pf->msg_enable is a bitmask, therefore assigning the value of the > "debug" parameter is wrong. It is initialized again later in > i40e_sw_init() so it didn't cause any problem, except that we missed > early debug

Re: [RFC] net: store port/representative id in metadata_dst

2016-09-23 Thread John Fastabend
On 16-09-23 01:45 PM, Jakub Kicinski wrote: > On Fri, 23 Sep 2016 13:25:10 -0700, John Fastabend wrote: >> On 16-09-23 01:17 PM, Jakub Kicinski wrote: >>> On Fri, 23 Sep 2016 10:22:59 -0700, Samudrala, Sridhar wrote: On 9/23/2016 8:29 AM, Jakub Kicinski wrote: >> [...] >> [...]

Re: [PATCH net] i40e: fix call of ndo_dflt_bridge_getlink()

2016-09-23 Thread Jeff Kirsher
On Fri, 2016-09-23 at 11:12 +0200, Nicolas Dichtel wrote: > Le 19/09/2016 à 18:14, Nicolas Dichtel a écrit : > > From: Huaibin Wang > >  > > Order of arguments is wrong. > > The wrong code has been introduced by commit 7d4f8d871ab1, but is > compiled > > only since commit

Re: [PATCH net-next v2] Documentation: devicetree: revise ethernet device-tree binding about TRGMII

2016-09-23 Thread Rob Herring
On Fri, Sep 23, 2016 at 02:04:09PM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > add phy-mode "trgmii" to > Documentation/devicetree/bindings/net/ethernet.txt > > Cc: devicet...@vger.kernel.org > Reported-by: Sergei Shtylyov

Re: [PATCH net-next] Documentation: devicetree: fix typo in MediaTek ethernet device-tree binding

2016-09-23 Thread Rob Herring
On Fri, Sep 23, 2016 at 02:09:32PM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > fix typo in > Documentation/devicetree/bindings/net/mediatek-net.txt > > Cc: devicet...@vger.kernel.org > Reported-by: Sergei Shtylyov >

[PATCH] hv_netvsc: fix comments

2016-09-23 Thread sthemmin
From: Stephen Hemminger Typo's and spelling errors. Also remove old comment from staging era. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git

Re: [PATCH net-next] net/vxlan: Avoid unaligned access in vxlan_build_skb()

2016-09-23 Thread Sowmini Varadhan
On (09/23/16 10:38), Alexander Duyck wrote: > > So basically what I was thinking is we do something like reserving > NET_IP_ALIGN and continue writing headers to skb->data, but we force > the tracking for the inner headers into frag[0] so that we can keep > the inner headers aligned without

Re: Alignment issues with freescale FEC driver

2016-09-23 Thread David Miller
From: Eric Nelson Date: Fri, 23 Sep 2016 10:33:29 -0700 > Since the hardware requires longword alignment for its' DMA transfers, > aligning the IP header will require a memcpy, right? I wish hardware designers didn't do this. There is no conflict between DMA alignment and

Re: [PATCH] net: bcmgenet: Fix EPHY reset in power up

2016-09-23 Thread Jaedon Shin
Hi Florian, > On 24 Sep 2016, at 1:54 AM, Florian Fainelli wrote: > > On 09/23/2016 08:04 AM, Jaedon Shin wrote: >> Hi Andrew, >> >> On 23 Sep 2016, at 11:06 PM, Andrew Lunn wrote: >>> >>> On Fri, Sep 23, 2016 at 10:20:04PM +0900, Jaedon Shin wrote:

Re: [RFC] net: store port/representative id in metadata_dst

2016-09-23 Thread Jakub Kicinski
On Fri, 23 Sep 2016 13:25:10 -0700, John Fastabend wrote: > On 16-09-23 01:17 PM, Jakub Kicinski wrote: > > On Fri, 23 Sep 2016 10:22:59 -0700, Samudrala, Sridhar wrote: > >> On 9/23/2016 8:29 AM, Jakub Kicinski wrote: > [...] > [...] > >> > >> The 'accel' parameter in

Re: Modification to skb->queue_mapping affecting performance

2016-09-23 Thread Michael Ma
2016-09-16 15:00 GMT-07:00 Michael Ma : > 2016-09-16 12:53 GMT-07:00 Eric Dumazet : >> On Fri, 2016-09-16 at 10:57 -0700, Michael Ma wrote: >> >>> This is actually the problem - if flows from different RX queues are >>> switched to the same RX queue in

Re: [net-next 5/5] PCI: disable FLR for 82579 device

2016-09-23 Thread Jeff Kirsher
On Fri, 2016-09-23 at 09:01 -0500, Bjorn Helgaas wrote: > On Thu, Sep 22, 2016 at 11:39:01PM -0700, Jeff Kirsher wrote: > > > > From: Sasha Neftin > > > > 82579 has a problem reattaching itself after the device is detached. > > The bug was reported by Redhat. The

Re: [PATCH 3/3] bpf powerpc: add support for bpf constant blinding

2016-09-23 Thread Daniel Borkmann
On 09/23/2016 10:35 PM, Naveen N. Rao wrote: In line with similar support for other architectures by Daniel Borkmann. 'MOD Default X' from test_bpf without constant blinding: 84 bytes emitted from JIT compiler (pass:3, flen:7) d58a4688 + : 0: nop 4: nop 8: std

[PATCH] netfilter: don't permit unprivileged writes to global state via sysctls

2016-09-23 Thread Jann Horn
This prevents the modification of nf_conntrack_max in unprivileged network namespaces. For unprivileged network namespaces, ip_conntrack_max is kept as a readonly sysctl in order to minimize potential compatibility issues. This patch should apply cleanly to the net tree. Signed-off-by: Jann Horn

[PATCH] Revert "net: ethernet: bcmgenet: use phydev from struct net_device"

2016-09-23 Thread Jaedon Shin
This reverts commit 62469c76007e ("net: ethernet: bcmgenet: use phydev from struct net_device") without this patch, we call twice bcmgenet_mii_reset, and that is intended: - first time from bcmgenet_power_up() to make sure the PHY is initialized *before* we get to initialize the UniMAC, this is

Re: [PATCH 2/3] bpf powerpc: implement support for tail calls

2016-09-23 Thread Daniel Borkmann
On 09/23/2016 10:35 PM, Naveen N. Rao wrote: Tail calls allow JIT'ed eBPF programs to call into other JIT'ed eBPF programs. This can be achieved either by: (1) retaining the stack setup by the first eBPF program and having all subsequent eBPF programs re-using it, or, (2) by unwinding/tearing

[PATCH 2/2] bpf samples: update tracex5 sample to use __seccomp_filter

2016-09-23 Thread Naveen N. Rao
seccomp_phase1() does not exist anymore. Instead, update sample to use __seccomp_filter(). While at it, set max locked memory to unlimited. Signed-off-by: Naveen N. Rao --- I am not completely sure if __seccomp_filter is the right place to hook in. This works for

[PATCH 1/2] bpf samples: fix compiler errors with sockex2 and sockex3

2016-09-23 Thread Naveen N. Rao
These samples fail to compile as 'struct flow_keys' conflicts with definition in net/flow_dissector.h. Fix the same by renaming the structure used in the sample. Signed-off-by: Naveen N. Rao --- samples/bpf/sockex2_kern.c | 10 +-

Re: [PATCH] softirq: let ksoftirqd do its job

2016-09-23 Thread Peter Zijlstra
On Fri, Sep 23, 2016 at 06:51:04PM +0200, Jesper Dangaard Brouer wrote: > This is your git tree, right: > https://git.kernel.org/cgit/linux/kernel/git/peterz/queue.git/ > > Doesn't look like you pushed it yet, or do I need to look at a specific > branch? I mainly work from a local quilt queue

Re: Alignment issues with freescale FEC driver

2016-09-23 Thread David Miller
From: Eric Nelson Date: Fri, 23 Sep 2016 11:35:17 -0700 > From the i.MX6DQ reference manual, bit 7 of ENET_RACC says this: > > "RX FIFO Shift-16 > > When this field is set, the actual frame data starts at bit 16 of the first > word read from the RX FIFO aligning the Ethernet

[PATCH] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-09-23 Thread chris.roth
From: Chris Roth From: Allan Chou Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller (Vendor=04b4 ProdID=3610). Patch verified on x64 linux kernel 4.7.4 system with the Kensington SD4600P USB-C Universal Dock with Power, which

Re: [Intel-wired-lan] [PATCH net-next v2 1/2] i40e: remove superfluous I40E_DEBUG_USER statement

2016-09-23 Thread Alexander Duyck
On Fri, Sep 23, 2016 at 6:30 AM, Stefan Assmann wrote: > This debug statement is confusing and never set in the code. Any debug > output should be guarded by the proper I40E_DEBUG_* statement which can > be enabled via the debug module parameter or ethtool. > Remove or convert

Re: [PATCH] Revert "net: ethernet: bcmgenet: use phydev from struct net_device"

2016-09-23 Thread David Miller
From: Jaedon Shin Date: Sat, 24 Sep 2016 06:08:19 +0900 > This reverts commit 62469c76007e ("net: ethernet: bcmgenet: use phydev > from struct net_device") > > without this patch, we call twice bcmgenet_mii_reset, and that is intended: > - first time from

RE: Alignment issues with freescale FEC driver

2016-09-23 Thread Andy Duan
From: David Miller Sent: Saturday, September 24, 2016 10:46 AM > To: e...@nelint.com > Cc: and...@lunn.ch; eduma...@google.com; Andy Duan > ; ota...@ossystems.com.br; > netdev@vger.kernel.org; troy.ki...@boundarydevices.com; >

[PATCH 5/6] mISDN: mark symbols static where possible

2016-09-23 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/isdn/mISDN/layer2.c:120:1: warning: no previous declaration for 'l2headersize' [-Wmissing-declarations] drivers/isdn/mISDN/layer2.c:127:1: warning: no previous declaration for 'l2addrsize' [-Wmissing-declarations]

[PATCH 1/6] isdn/eicon: add function declarations

2016-09-23 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/isdn/hardware/eicon/diddfunc.c:95:12: warning: no previous prototype for 'diddfunc_init' [-Wmissing-prototypes] drivers/isdn/hardware/eicon/s_4bri.c:128:6: warning: no previous prototype for 'start_qBri_hardware' [-Wmissing-prototypes]

[PATCH 2/6] isdn/hardware/eicon: add missing header dependencies

2016-09-23 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/isdn/hardware/eicon/diva.c:655:6: warning: no previous prototype for 'xdiFreeFile' [-Wmissing-prototypes] In fact, this function is declared in drivers/isdn/hardware/eicon/helpers.h, so this patch adds missing header dependencies.

[PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up

2016-09-23 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/isdn/hisax/hscx.c:175:1: warning: no previous prototype for 'open_hscxstate' [-Wmissing-prototypes] In fact, this function is declared in drivers/isdn/hisax/elsa_ser.c, but should be declard in a header file, thus can be recognized in other

[PATCH 3/6] isdn/hisax: add function declarations

2016-09-23 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/isdn/hisax/teles3.c:273:5: warning: no previous prototype for 'setup_teles3' [-Wmissing-prototypes] drivers/isdn/hisax/s0box.c:213:5: warning: no previous prototype for 'setup_s0box' [-Wmissing-prototypes]

[PATCH 6/6] mISDN: remove unused function

2016-09-23 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/isdn/mISDN/layer2.c:463:1: warning: no previous declaration for 'IsRR' [-Wmissing-declarations] In fact, this function is called by no one and not exported, so this patch removes it. Signed-off-by: Baoyou Xie ---

[PATCH net-next v2] Documentation: devicetree: revise ethernet device-tree binding about TRGMII

2016-09-23 Thread sean.wang
From: Sean Wang add phy-mode "trgmii" to Documentation/devicetree/bindings/net/ethernet.txt Cc: devicet...@vger.kernel.org Reported-by: Sergei Shtylyov Signed-off-by: Sean Wang ---

Re: [RFC] net: store port/representative id in metadata_dst

2016-09-23 Thread Jiri Pirko
Thu, Sep 22, 2016 at 09:26:57PM CEST, jakub.kicin...@netronome.com wrote: >Switches and modern SR-IOV enabled NICs may multiplex traffic from >representators and control messages over single set of hardware queues. >Control messages and muxed traffic may need ordered delivery. > >Those

[PATCH net-next] Documentation: devicetree: fix typo in MediaTek ethernet device-tree binding

2016-09-23 Thread sean.wang
From: Sean Wang fix typo in Documentation/devicetree/bindings/net/mediatek-net.txt Cc: devicet...@vger.kernel.org Reported-by: Sergei Shtylyov Signed-off-by: Sean Wang ---

Re: [PATCH] fs/select: add vmalloc fallback for select(2)

2016-09-23 Thread Hillf Danton
> > The select(2) syscall performs a kmalloc(size, GFP_KERNEL) where size grows > with the number of fds passed. We had a customer report page allocation > failures of order-4 for this allocation. This is a costly order, so it might > easily fail, as the VM expects such allocation to have a

Re: [PATCH] fs/select: add vmalloc fallback for select(2)

2016-09-23 Thread Nicholas Piggin
On Fri, 23 Sep 2016 14:42:53 +0800 "Hillf Danton" wrote: > > > > The select(2) syscall performs a kmalloc(size, GFP_KERNEL) where size grows > > with the number of fds passed. We had a customer report page allocation > > failures of order-4 for this allocation. This is

[PATCH RFC] IPsec performance optimizations

2016-09-23 Thread Steffen Klassert
This patchset adds several performance optimizations for the ESP IPsec protocol. This RFC version is intended to be a discussion base for the IPsec workshop at the netdev 1.2 conference. The patchset has two parts, patches 1 - 4 are software optimizations. These patches are complete and could go

[PATCH RFC 11/11] xfrm: Add encapsulation header offsets while SKB is not encrypted

2016-09-23 Thread Steffen Klassert
From: Ilan Tayari Both esp4 and esp6 used to assume that the SKB payload is encrypted and therefore the inner_network and inner_transport offsets are not relevant. When doing crypto offload in the NIC, this is no longer the case and the NIC driver needs these offsets so it

[PATCH RFC 08/11] xfrm: Move device notifications to a sepatate file

2016-09-23 Thread Steffen Klassert
This is needed for the upcomming IPsec device offloading. Signed-off-by: Steffen Klassert --- include/net/xfrm.h | 1 + net/xfrm/Makefile | 2 +- net/xfrm/xfrm_device.c | 43 +++ net/xfrm/xfrm_policy.c | 17

[PATCH RFC 09/11] xfrm: Add an IPsec hardware offloading API

2016-09-23 Thread Steffen Klassert
This patch adds all the bits that are needed to do IPsec hardware offload for IPsec states and ESP packets. We add xfrmdev_ops to the net_device. xfrmdev_ops has function pointers that are needed to manage the xfrm states in the hardware and to do a per packet offloading decision. Joint work

[PATCH RFC 04/11] esp: Add a software GRO codepath

2016-09-23 Thread Steffen Klassert
This patch adds GRO callbacks for ESP on ipv4 and ipv6. In case the GRO layer detects an ESP packet, the esp{4,6}_gro_receive() function calls the xfrm input layer which decapsulates the packet and reinject it into layer 2 by calling netif_rx(). Signed-off-by: Steffen Klassert

[net-next 1/5] igb: fix non static symbol warning

2016-09-23 Thread Jeff Kirsher
From: Wei Yongjun Fixes the following sparse warning: drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: symbol 'igb_rxnfc_write_vlan_prio_filter' was not declared. Should it be static? Signed-off-by: Wei Yongjun Tested-by: Aaron

[net-next 2/5] igbvf: bump version to igbvf-2.4.0

2016-09-23 Thread Jeff Kirsher
From: Todd Fujinaka Bump version to match other igbvf drivers. Signed-off-by: Todd Fujinaka Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher ---

[net-next 4/5] igb: restore PPS signal on igb_ptp_reset

2016-09-23 Thread Jeff Kirsher
From: Jacob Keller When a reset occurs, the PPS SYS_WRAP interrupt was not re-enabled which resulted in disabling of the PPS signaling. Fix this by recording when the interrupt is on and ensuring that we re-enable it every time we reset. Signed-off-by: Jacob Keller

[net-next 0/5][pull request] 1GbE Intel Wired LAN Driver Updates 2016-09-22

2016-09-23 Thread Jeff Kirsher
This series contains updates to igb, igbvf and PCI quirks. Wei Yongjun makes a function static to shut up sparse. Todd bumps the igb and igbvf version, which is long overdue. Jake fixes an issue where the PPS SYS_WRAP interrupt was not re-enabled after a reset, which resulted in disabling of

[net-next 5/5] PCI: disable FLR for 82579 device

2016-09-23 Thread Jeff Kirsher
From: Sasha Neftin 82579 has a problem reattaching itself after the device is detached. The bug was reported by Redhat. The suggested fix is to disable FLR capability in PCIe configuration space. Reproduction: Attach the device to a VM, then detach and try to attach

[net-next 3/5] igb: bump version to igb-5.4.0

2016-09-23 Thread Jeff Kirsher
From: Todd Fujinaka Bump igb version to match other igb drivers. Signed-off-by: Todd Fujinaka Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher ---

[PATCH RFC 03/11] net: Prepare for IPsec GRO

2016-09-23 Thread Steffen Klassert
This patch prepares the generic codepath for IPsec GRO. We introduce a new GRO_CONSUMED notifier to reflect that IPsec can return asynchronous. On IPsec GRO we grab the packet and reinject it back to layer 2 after IPsec processing. We also use one xfrm_gro bit on the sk_buff that will be set from

[PATCH RFC 01/11] esp4: Avoid skb_cow_data whenever possible

2016-09-23 Thread Steffen Klassert
This patch tries to avoid skb_cow_data on esp4. On the encrypt side we add the IPsec tailbits to the lineaer part of the buffer if there is space on on it. If there is no space on the linaer part, we add a page fragment with the tailbits to the buffer and use separate src and dst scatterlists.

[PATCH RFC 10/11] xfrm: Add xfrm_replay_overflow functions for offloading

2016-09-23 Thread Steffen Klassert
This patch adds functions that handles IPsec sequence numbers for GSO segments and TSO offloading. We need to calculate and update the sequence numbers based on the segments that GSO/TSO will generate. We need this to keep software and hardware sequence number counter in sync. Signed-off-by:

[PATCH RFC 05/11] skbuff: Extend gso_type to unsigned int.

2016-09-23 Thread Steffen Klassert
All available gso_type flags are currently in use, so extend gso_type to be able to add further flags. Signed-off-by: Steffen Klassert --- include/linux/skbuff.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/skbuff.h

[PATCH RFC 06/11] net: Add ESP offload features

2016-09-23 Thread Steffen Klassert
This patch adds netdev features to configure IPsec offloads. Signed-off-by: Steffen Klassert --- include/linux/netdev_features.h | 8 +++- include/linux/netdevice.h | 1 + include/linux/skbuff.h | 2 ++ net/core/ethtool.c | 3 +++ 4

[PATCH RFC 02/11] esp6: Avoid skb_cow_data whenever possible

2016-09-23 Thread Steffen Klassert
This patch tries to avoid skb_cow_data on esp6. On the encrypt side we add the IPsec tailbits to the lineaer part of the buffer if there is space on on it. If there is no space on the linear part, we add a page fragment with the tailbits to the buffer and use separate src and dst scatterlists.

[PATCH RFC 07/11] esp: Add gso handlers for esp4 and esp6

2016-09-23 Thread Steffen Klassert
This patch extends the xfrm_type by an encap function pointer and implements esp4_gso_encap and esp6_gso_encap. These functions doing the basic esp encapsulation for a GSO packet. In case the GSP packet needs to be segmented in software, we add gso_segment functions. The secpath is extended to

[net-next 03/10] ixgbe: Resolve NULL reference by setting {read, write}_reg_mdi

2016-09-23 Thread Jeff Kirsher
From: Mark Rustad Set the read_reg_mdi and write_reg_mdi method pointers for X550EM_A_10G_T devices to resolve jumping to NULL. Signed-off-by: Mark Rustad Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 10/10] ixgbe: reset before SRIOV init to avoid mailbox issues

2016-09-23 Thread Jeff Kirsher
From: Emil Tantilov Enabling SRIOV while the ixgbevf driver is loaded will result in all mailbox requests from ixgbevf_open() being rejected by ixgbe because adapter->clear_to_send is set to false on reset. Call ixgbe_sriov_reinit() before pci_enable_sriov() to make

[net-next 02/10] ixgbe: make ixgbe_led_on/off_t_x550em static

2016-09-23 Thread Jeff Kirsher
From: Emil Tantilov These functions are only used in ixgbe_x550.c. Fixes a warning when compiling with -Wmissing-prototypes Reported-by: Krishneil Singh Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers

[net-next 08/10] ixgbe: Limit reporting of redirection table if SR-IOV is enabled

2016-09-23 Thread Jeff Kirsher
From: Alexander Duyck The hardware redirection table can support more queues then the PF currently has when SR-IOV is enabled. In order to account for this use the RSS mask to trim of the bits that are not used. Signed-off-by: Alexander Duyck

[net-next 09/10] ixgbe: Support 4 queue RSS on VFs with 1 or 2 queue RSS on PF

2016-09-23 Thread Jeff Kirsher
From: Alexander Duyck Instead of limiting the VFs if we don't use 4 queues for RSS in the PF we can instead just limit the RSS queues used to a power of 2. By doing this we can support use cases where VFs are using more queues than the PF is currently using and can

[net-next 01/10] ixgbe: simplify the logic for setting VLAN filtering

2016-09-23 Thread Jeff Kirsher
From: Emil Tantilov Simplify the logic for setting VLNCTRL.VFE by checking the VMDQ flag and 82598 MAC instead of having to maintain a list of MAC types. Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers

[net-next 00/10][pull request] 10GbE Intel Wired LAN Driver Updates 2016-09-23

2016-09-23 Thread Jeff Kirsher
This series contains updates to ixgbe and ixgbevf. Emil provides several changes, first simplifies the logic for setting VLAN filtering by checking the VMDQ flag and the old 82598 MAC, instead of having to maintain a list of MAC types. Then made two functions static that are used only within the

[net-next 04/10] ixgbe: Indicate support for pause frames in all cases

2016-09-23 Thread Jeff Kirsher
From: Mark Rustad All the MACs supported by ixgbe support pause frames, so indicate that support in ethtool. Also set advertising according to requested mode. Signed-off-by: Mark Rustad Tested-by: Andrew Bowers

[net-next 05/10] ixgbevf: add spinlocks for MTU change calls

2016-09-23 Thread Jeff Kirsher
From: Emil Tantilov Protect set_rlpml with mailbox lock to make sure the MTU configuration is handled properly. This change resolves an issue where set_rlpml can fail when the VF interface is brought up: ixgbevf :03:1d.6: Failed to set MTU at 1500 Signed-off-by:

[net-next 06/10] ixgbe: Use MDIO_PRTAD_NONE consistently

2016-09-23 Thread Jeff Kirsher
From: Mark Rustad The value MDIO_PRTAD_NONE should be used to indicate no PHY address. Not 0, not 0x. Use the MDIO_PRTAD_NONE value consistently. Signed-off-by: Mark Rustad Tested-by: Andrew Bowers Signed-off-by:

[net-next 07/10] ixgbe: Allow setting multiple queues when SR-IOV is enabled

2016-09-23 Thread Jeff Kirsher
From: Alexander Duyck The maximum queue count reported was 1, however support for multiple queues with SR-IOV was added some time ago so we should report support for it to the user so that they can select multiple queues if they so desire. Signed-off-by: Alexander

Re: [PATCHv2 iproute2 0/2] ip rule: merger iprule_flush and add selector support

2016-09-23 Thread Phil Sutter
On Fri, Sep 23, 2016 at 11:25:53AM +0800, Hangbin Liu wrote: > When merge iprule_flush() and iprule_list_or_save(). Renamed > rtnl_filter_t filter to filter_fn because we want to use global > variable 'filter' to filter nlmsg in the next patch. > > Hangbin Liu (2): > ip rule: merge ip rule

[PATCH 2/2] xfrm: state lookup can be lockless

2016-09-23 Thread Steffen Klassert
From: Florian Westphal This is called from the packet input path, we get lock contention if many cpus handle ipsec in parallel. After recent rcu conversion it is safe to call __xfrm_state_lookup without the spinlock. Signed-off-by: Florian Westphal

pull request (net-next): ipsec-next 2016-09-23

2016-09-23 Thread Steffen Klassert
Only two patches this time: 1) Fix a comment reference to struct xfrm_replay_state_esn. From Richard Guy Briggs. 2) Convert xfrm_state_lookup to rcu, we don't need the xfrm_state_lock anymore in the input path. From Florian Westphal. Please pull or let me know if there are problems.

[PATCH 1/2] xfrm: fix header file comment reference to struct xfrm_replay_state_esn

2016-09-23 Thread Steffen Klassert
From: Richard Guy Briggs Reported-by: Paul Wouters Signed-off-by: Richard Guy Briggs Signed-off-by: Steffen Klassert --- include/uapi/linux/xfrm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH net-next v2 1/3] net: ethernet: mediatek: add extension of phy-mode for TRGMII

2016-09-23 Thread Sergei Shtylyov
Hello. On 9/23/2016 6:32 AM, Sean Wang wrote: From: Sean Wang adds PHY-mode "trgmii" as an extension for the operation mode of the PHY interface for PHY_INTERFACE_MODE_TRGMII. .. deleted What? Why? switch (of_get_phy_mode(np)) { + case

Re: pull-request: can 2016-09-22

2016-09-23 Thread David Miller
From: Marc Kleine-Budde Date: Thu, 22 Sep 2016 14:42:21 +0200 > this is a pull request of one patch for the upcoming linux-4.8 release. > > The patch by Sergei Miroshnichenko fixes a potential deadlock in the generic > CAN device code that cann occour after a bus-off.

Re: [RFC] net: store port/representative id in metadata_dst

2016-09-23 Thread Jiri Benc
On Fri, 23 Sep 2016 08:34:29 +0200, Jiri Pirko wrote: > So if I understand that correctly, this would need some "shared netdev" > which would effectively serve only as a sink for all port netdevices to > tx packets to. On RX, this would be completely avoided. This lower > device looks like half

[patch net-next v2 4/6] rocker: use FIB notifications instead of switchdev calls

2016-09-23 Thread Jiri Pirko
From: Jiri Pirko Until now, in order to offload a FIB entry to HW we use switchdev op. Use the newly introduced FIB notifier infrasturucture to process FIB entries to offload the in HW. Abort mechanism is now handled within the rocker driver. Signed-off-by: Jiri Pirko

[patch net-next v2 2/6] fib: introduce FIB info offload flag helpers

2016-09-23 Thread Jiri Pirko
From: Jiri Pirko These helpers are to be used in case someone offloads the FIB entry. The result is that if the entry is offloaded to at least one device, the offload flag is set. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel

[patch net-next v2 3/6] mlxsw: spectrum_router: Use FIB notifications instead of switchdev calls

2016-09-23 Thread Jiri Pirko
From: Jiri Pirko Until now, in order to offload a FIB entry to HW we use switchdev op. However that has limits. Mainly in case we need to make the HW aware of all route prefixes configured in kernel. HW needs to know those in order to properly trap appropriate packets and pass

[patch net-next v2 0/6] fib offload: switch to notifier

2016-09-23 Thread Jiri Pirko
From: Jiri Pirko The goal of this patchset is to allow driver to propagate all prefixes configured in kernel down HW. This is necessary for routing to work as expected. If we don't do that HW might forward prefixes known to kernel incorrectly. Take an example when default

[patch net-next v2 1/6] fib: introduce FIB notification infrastructure

2016-09-23 Thread Jiri Pirko
From: Jiri Pirko This allows to pass information about added/deleted FIB entries/rules to whoever is interested. This is done in a very similar way as devinet notifies address additions/removals. Signed-off-by: Jiri Pirko --- include/net/ip_fib.h| 34

[patch net-next v2 6/6] doc: update switchdev L3 section

2016-09-23 Thread Jiri Pirko
From: Jiri Pirko This is to reflect the change of FIB offload infrastructure from switchdev objects to FIB notifier. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- Documentation/networking/switchdev.txt | 27

[patch net-next v2 5/6] switchdev: remove FIB offload infrastructure

2016-09-23 Thread Jiri Pirko
From: Jiri Pirko Since this is now taken care of by FIB notifier, remove the code, with all unused dependencies. Signed-off-by: Jiri Pirko --- include/net/ip_fib.h | 2 - include/net/switchdev.h | 40 -- net/ipv4/fib_frontend.c | 13

RE: [PATCH v2] fs/select: add vmalloc fallback for select(2)

2016-09-23 Thread David Laight
From: Vlastimil Babka > Sent: 22 September 2016 18:55 ... > So in the case of select() it seems like the memory we need 6 bits per file > descriptor, multiplied by the highest possible file descriptor (nfds) as > passed > to the syscall. According to the man page of select: > > EINVAL

Re: [PATCH v2] fs/select: add vmalloc fallback for select(2)

2016-09-23 Thread Vlastimil Babka
On 09/23/2016 11:42 AM, David Laight wrote: > From: Vlastimil Babka >> Sent: 22 September 2016 18:55 > ... >> So in the case of select() it seems like the memory we need 6 bits per file >> descriptor, multiplied by the highest possible file descriptor (nfds) as >> passed >> to the syscall.

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

2016-09-23 Thread Jamal Hadi Salim
On 16-09-20 06:00 PM, Tom Herbert wrote: This patch creates an infrastructure for registering and running code at XDP hooks in drivers. This is based on the orignal XDP?BPF and borrows heavily from the techniques used by netfilter to make generic nfhooks. An XDP hook is defined by the

Re: [PATCH net-next 0/9] Mellanox 100G SRIOV offloads vlan push/pop

2016-09-23 Thread David Miller
From: Saeed Mahameed Date: Thu, 22 Sep 2016 20:01:40 +0300 > From Or Gerlitz: > > This series further enhances the SRIOV TC offloads of mlx5 to handle > the TC vlan push and pop actions. This serves a common use-case in > virtualization systems where the virtual switch add

Re: [PATCH] softirq: let ksoftirqd do its job

2016-09-23 Thread Daniel Borkmann
On 09/02/2016 08:39 AM, David Miller wrote: From: Eric Dumazet Date: Wed, 31 Aug 2016 10:42:29 -0700 From: Eric Dumazet A while back, Paolo and Hannes sent an RFC patch adding threaded-able napi poll loop support :

Re: [PATCH] brcmfmac: fix memory leak in brcmf_fill_bss_param

2016-09-23 Thread Arend Van Spriel
On 21-9-2016 8:23, Rafał Miłecki wrote: > From: Rafał Miłecki > > This function is called from get_station callback which means that every > time user space was getting/dumping station(s) we were leaking 2 KiB. > Acked-by: Arend van Spriel >

[PATCH] netfilter: xt_socket: fix transparent match for IPv6 request sockets

2016-09-23 Thread KOVACS Krisztian
The introduction of TCP_NEW_SYN_RECV state, and the addition of request sockets to the ehash table seems to have broken the --transparent option of the socket match for IPv6 (around commit a9407000). Now that the socket lookup finds the TCP_NEW_SYN_RECV socket instead of the listener, the

Re: [PATCH net] act_ife: Add support for machines with hard_header_len != mac_len

2016-09-23 Thread David Miller
From: Yotam Gigi Date: Wed, 21 Sep 2016 15:54:13 +0300 > Without that fix, the following could occur: ... I don't think what you are doing in mlxsw is valid. You can't set hard_header_len arbitrarily, it's the MAC length. If you need to prepend special headers or

Re: [PATCH net] i40e: fix call of ndo_dflt_bridge_getlink()

2016-09-23 Thread Nicolas Dichtel
Le 19/09/2016 à 18:14, Nicolas Dichtel a écrit : > From: Huaibin Wang > > Order of arguments is wrong. > The wrong code has been introduced by commit 7d4f8d871ab1, but is compiled > only since commit 9df70b66418e. > > Note that this may break netlink dumps. > > Fixes:

[PATCH v2 2/2] net: thunderx: Support for byte queue limits

2016-09-23 Thread sunil . kovvuri
From: Sunil Goutham This patch adds support for byte queue limits Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 14 -- drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 30 ++ 2

Re: [PATCH net-next 2/3] udp: implement memory accounting helpers

2016-09-23 Thread Paolo Abeni
On Thu, 2016-09-22 at 13:34 -0700, Eric Dumazet wrote: > On Thu, 2016-09-22 at 22:27 +0200, Paolo Abeni wrote: > > On Thu, 2016-09-22 at 09:30 -0700, Eric Dumazet wrote: > > > On Thu, 2016-09-22 at 18:14 +0200, Paolo Abeni wrote: > > > > > > > I think that the idea behind using atomic ops

Re: [PATCH next 0/2] improvements to SSN and TSN handling

2016-09-23 Thread David Miller
From: Marcelo Ricardo Leitner Date: Tue, 20 Sep 2016 18:19:12 -0300 > First patch fixes a potential issue made visible by the second one > noticed by David Laight and is a preparation for the next one. > > The second patch changes how SSN, TSN and ASCONF serials are

[PATCH] mlxsw: spectrum: remove redundant check if err is zero

2016-09-23 Thread Colin King
From: Colin Ian King There is an earlier check and return if err is non-zero, so the check to see if it is zero is redundant in every iteration of the loop and hence the check can be removed. Signed-off-by: Colin Ian King ---

[PATCH v2 1/2] net: thunderx: Fix issue with IRQ namimg

2016-09-23 Thread sunil . kovvuri
From: Sunil Goutham This patch fixes a regression caused by previous commit when irq name exceeds 20 byte array if interface's name size is large. Fixes: e412621394fa ("net: thunderx: Use netdev's name for naming VF's interrupts") Signed-off-by: Sunil Goutham

[PATCH v2 0/2] BQL support and fix for a regression issue

2016-09-23 Thread sunil . kovvuri
From: Sunil Goutham These patches add byte queue limit support and also fixes a regression issue introduced by commit 'net: thunderx: Use netdev's name for naming VF's interrupts' Changes from v1: - As suggested added 'Fixes' tag with commit id of previous commit which

Re: [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module

2016-09-23 Thread Sergei Shtylyov
Hello. On 9/23/2016 3:13 AM, David Miller wrote: Despite my comments? Sigh... Sorry, I thought he had addressed your feedback in v2. IIRC, I had only commented to v2, not v1. I'll wait longer next time. Thank you. :-) MBR, Sergei

Re: [PATCH][V2] cxgb4: fix signed wrap around when decrementing index idx

2016-09-23 Thread David Miller
From: Colin King Date: Thu, 22 Sep 2016 18:48:58 +0100 > From: Colin Ian King > > Change predecrement compare to post decrement compare to avoid an > unsigned integer wrap-around comparison when decrementing idx in > the while loop. > > For

Re: [net-next 5/5] PCI: disable FLR for 82579 device

2016-09-23 Thread Sergei Shtylyov
Hello. On 9/23/2016 9:39 AM, Jeff Kirsher wrote: From: Sasha Neftin 82579 has a problem reattaching itself after the device is detached. The bug was reported by Redhat. The suggested fix is to disable FLR capability in PCIe configuration space. Reproduction: Attach

Re: [PATCH net-next] drivers: net: xgene: Fix MSS programming

2016-09-23 Thread David Miller
From: Iyappan Subramanian Date: Thu, 22 Sep 2016 15:47:33 -0700 > Current driver programs static value of MSS in hardware register for TSO > offload engine to segment the TCP payload regardless the MSS value > provided by network stack. > > This patch fixes this by

Re: [PATCH net-next 0/7] hv_netvsc changes

2016-09-23 Thread David Miller
From: sthem...@exchange.microsoft.com Date: Thu, 22 Sep 2016 16:56:28 -0700 > These are mostly about improving the handling of interaction between > the virtual network device (netvsc) and the SR-IOV VF network device. Series applied, thanks Stephen.

Re: [PATCH v6 5/6] net: ipv4, ipv6: run cgroup ebpf egress programs

2016-09-23 Thread Pablo Neira Ayuso
On Thu, Sep 22, 2016 at 05:12:57PM +0200, Daniel Borkmann wrote: > On 09/22/2016 02:05 PM, Pablo Neira Ayuso wrote: [...] > >Have a look at net/ipv4/netfilter/nft_chain_route_ipv4.c for instance. > >In your case, you have to add a new chain type: > > > >static const struct nf_chain_type

  1   2   3   >