Re: pull-request: wireless-drivers-next 2016-09-29

2016-10-04 Thread David Miller
From: Kalle Valo Date: Wed, 05 Oct 2016 07:50:39 +0300 > net-next still fails to compile for me. I verified that these two > patches fix it but I don't see them in net-next yet. Pablo please get those fixes to me as soon as possible.

Re: pull-request: wireless-drivers-next 2016-09-29

2016-10-04 Thread Kalle Valo
Aaron Conole writes: > David Miller writes: > >> From: Kalle Valo >> Date: Thu, 29 Sep 2016 19:57:28 +0300 >> > ... >>> Or actually I had one problem. While doing a test merge I noticed that >>> net-next fails to compile for me,

RE: [PATCH] igb: Realign bad indentation

2016-10-04 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Joe Perches > Sent: Monday, September 26, 2016 8:46 PM > To: Kirsher, Jeffrey T > Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org >

[PATCH v3] mwifiex: report wakeup for wowlan

2016-10-04 Thread Rajat Jain
Register the WLAN device as a wakeup source since it can wake the system via wake-on-wireless-lan. In an actual wowlan event, notify the PM core that we are the current wakeup source. This allows the PM core to update the wakeup attributes in /sys. This was causing wakeup issues on chromeos as

Re: [ISSUE: mv88e6xxx]: Down/Up link and not forwarding

2016-10-04 Thread Andrew Lunn
> >The main difference is GLOBAL2 5th register. When the unit is just > >initialized, the driver sets this register to 00ff, however, when > >the issue happens, its value is c12f. You might want to hack the MDIO driver and get it to trap writes to this register and give you a call stack.

Re: [PATCH net-next] openvswitch: correctly fragment packet with mpls headers

2016-10-04 Thread Pravin Shelar
On Tue, Oct 4, 2016 at 2:28 AM, Jiri Benc wrote: > On Tue, 4 Oct 2016 10:24:58 +0200, Jiri Benc wrote: >> On Mon, 3 Oct 2016 11:04:46 -0700, Pravin Shelar wrote: >> > This is not correct way to detect MPLS packet. inner_protocol can be >> > set by any tunnel device for using

Re: [PATCH net-next] openvswitch: correctly fragment packet with mpls headers

2016-10-04 Thread Jiri Benc
On Tue, 4 Oct 2016 09:53:25 -0700, Pravin Shelar wrote: > This code can be executed on encapsulated geneve or vxlan packets. How? The encapsulation header is in the form of metadata_dst at this point and not present in the packet itself. Am I missing something? If this patch is wrong, then the

Re: [ISSUE: mv88e6xxx]: Down/Up link and not forwarding

2016-10-04 Thread Florian Fainelli
On October 4, 2016 8:37:13 AM PDT, Jose Antonio Delgado Alfonso wrote: >We are working in an ARMv7 embedded system running kernel 4.1 but >including patches to upgrade dsa/mv88e6xxx to kernel version 4.3 >(5acf4d0, Wed, 27 May 2015 15:32:15 -0700) "[PATCH] blk:

ethtool 4.8 released

2016-10-04 Thread John W. Linville
ethtool version 4.8 has been released. Home page: https://www.kernel.org/pub/software/network/ethtool/ Download link: https://www.kernel.org/pub/software/network/ethtool/ethtool-4.8.tar.xz Release notes: * Feature: QSFP Plus/QSFP28 Diagnostics Information Support * Feature:

kernel v4.8: iptables logs are truncated with the 4.8 kernel?

2016-10-04 Thread Justin Piszcz
Hello, kernel 4.8 with ulogd-2.0.5- IPs are no longer logged: Oct 4 17:51:30 atom INPUT_BLOCK IN=eth1 OUT= MAC=00:1b:21:9c:3b:fa:3e:94:d5:d2:49:1e:08:00 LEN=0 TOS=00 PREC=0x00 TTL=0 ID=0 PROTO=0 MARK=0 Oct 4 17:51:31 atom INPUT_BLOCK IN=eth1 OUT= MAC=00:1b:21:9c:3b:fa:3e:94:d5:d2:49:1e:08:00

A bug in team driver

2016-10-04 Thread Alex Sidorenko
The problem was found on RHEL7.2 but is still present in the latest upstream kernel (according to visual sources inspection). While using roundrobin runner we have noticed that after sending on team0 about 2.1 billion packets we started seeing 50% packet drop on team0 (according to 'netstat

Re: [PATCH v3] net: hns: mark symbols static where possible

2016-10-04 Thread Arnd Bergmann
On Saturday, October 1, 2016 4:15:26 PM CEST Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:76:21: warning: no previous > prototype for 'hns_ae_get_handle' [-Wmissing-prototypes] >

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-10-04 Thread James Chapman
On 04/10/16 04:12, R. Parameswaran wrote: > > Hi James, > > Please see inline, thanks for the reply: > > On Sat, 1 Oct 2016, James Chapman wrote: > >> On 30/09/16 03:39, R. Parameswaran wrote: > + /* Adjust MTU, factor overhead - underlay L3 hdr, overlay L2 hdr*/ > + if

[PATCH v2 net-next 5/7] xen-netback: process guest rx packets in batches

2016-10-04 Thread Paul Durrant
From: David Vrabel Instead of only placing one skb on the guest rx ring at a time, process a batch of up-to 64. This improves performance by ~10% in some tests. Signed-off-by: David Vrabel [re-based] Signed-off-by: Paul Durrant

[PATCH v2 net-next 0/7] xen-netback: guest rx side refactor

2016-10-04 Thread Paul Durrant
This series refactors the guest rx side of xen-netback: - The code is moved into its own source module. - The prefix variant of GSO handling is retired (since it is no longer in common use, and alternatives exist). - The code is then simplified and modifications made to improve performance.

[PATCH v2 net-next 7/7] xen/netback: add fraglist support for to-guest rx

2016-10-04 Thread Paul Durrant
From: Ross Lagerwall This allows full 64K skbuffs (with 1500 mtu ethernet, composed of 45 fragments) to be handled by netback for to-guest rx. Signed-off-by: Ross Lagerwall [re-based] Signed-off-by: Paul Durrant

[PATCH v2 net-next 6/7] xen-netback: batch copies for multiple to-guest rx packets

2016-10-04 Thread Paul Durrant
From: David Vrabel Instead of flushing the copy ops when an packet is complete, complete packets when their copy ops are done. This improves performance by reducing the number of grant copy hypercalls. Latency is still limited by the relatively small size of the copy

[PATCH v2 net-next 3/7] xen-netback: refactor guest rx

2016-10-04 Thread Paul Durrant
From: David Vrabel Refactor the to-guest (rx) path to: 1. Push responses for completed skbs earlier, reducing latency. 2. Reduce the per-queue memory overhead by greatly reducing the maximum number of grant copy ops in each hypercall (from 4352 to 64). Each

[PATCH iproute2] fix netlink message length checks

2016-10-04 Thread Igor Ryzhov
Signed-off-by: Igor Ryzhov --- ip/ipaddress.c | 2 +- lib/ll_map.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index fcc3c53..3614837 100644 --- a/ip/ipaddress.c +++ b/ip/ipaddress.c @@ -1218,7 +1218,7 @@ static int

[net-next 08/13] fsl/fman: check pcsphy pointer before use

2016-10-04 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman_memac.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c index 96dfe7e..53ef51e 100644 ---

[net-next 05/13] fsl/fman: simplify device tree reads

2016-10-04 Thread Madalin Bucur
From: Madalin Bucur Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman.c | 30 ++--- drivers/net/ethernet/freescale/fman/fman_port.c | 24 ++--

[net-next 02/13] fsl/fman: fix loadable module compilation

2016-10-04 Thread Madalin Bucur
From: Igal Liberman Signed-off-by: Igal Liberman --- drivers/net/ethernet/freescale/fman/Makefile| 10 --- drivers/net/ethernet/freescale/fman/fman.c | 35 +++--

[net-next 06/13] fsl/fman: return a phy_dev pointer from init

2016-10-04 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/mac.c | 22 +++--- drivers/net/ethernet/freescale/fman/mac.h | 3 ++- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/mac.c

pull-request: mac80211-next 2016-10-04

2016-10-04 Thread Johannes Berg
Hi Dave, Here's a version with the conflicts resolved - had to jigger some code around, but it's all described in the merge commit message. Let me know if there's any problem. Thanks, johannes The following changes since commit 9a8dd213d2a38349e5ea2ca400952112b45c: Merge branch

[net-next 11/13] fsl/fman: fix return value checking

2016-10-04 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c index 1fc1049..dafd9e1 100644 ---

[net-next 01/13] fsl/fman: split lines over 80 characters

2016-10-04 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman_muram.c | 3 ++- drivers/net/ethernet/freescale/fman/fman_muram.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/fman_muram.c

[net-next 12/13] fsl/fman: remove leftover comment

2016-10-04 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman_mac.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/fman_mac.h b/drivers/net/ethernet/freescale/fman/fman_mac.h index ddf0260..dd6d052 100644 ---

[net-next 04/13] fsl/fman: use of_get_phy_mode()

2016-10-04 Thread Madalin Bucur
From: Madalin Bucur Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/mac.c | 33 ++- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git

[net-next 13/13] MAINTAINERS: net: add entry for Freescale QorIQ DPAA FMan driver

2016-10-04 Thread Madalin Bucur
Add record for Freescale QORIQ DPAA FMan driver adding myself as maintainer. Signed-off-by: Madalin Bucur --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 669909e..3460152 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[net-next 03/13] fsl/fman: small fixes

2016-10-04 Thread Madalin Bucur
From: Madalin Bucur Make module params static, proper NULL checks, remove __iomem label when misused. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman.c | 6 +++---

[net-next 00/13] fsl/fman: cleanup and small fixes

2016-10-04 Thread Madalin Bucur
This series contains fixes for the DPAA FMan driver. Adding myself as maintainer of the driver. The following are changes since commit a4cc96d1f0170b779c32c6b2cc58764f5d2cdef0 net: phy: Add Edge-rate driver for Microsemi PHYs. and are available on the fman-next branch in the git repository at

[net-next 10/13] fsl/fman: simplify redundant condition

2016-10-04 Thread Madalin Bucur
Change suggested by David Binderman, thanks. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/fman.c

[net-next 09/13] fsl/fman: check of_get_phy_mode() return value

2016-10-04 Thread Madalin Bucur
For unknown compatibles avoid crashing and default to SGMII. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/mac.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/mac.c

[net-next 07/13] fsl/fman: MEMAC may use QSGMII PHY interface mode

2016-10-04 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman_memac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c index

[net-next 00/13] fsl/fman: cleanup and small fixes

2016-10-04 Thread Madalin Bucur
This series contains fixes for the DPAA FMan driver. Adding myself as maintainer of the driver. The following are changes since commit a4cc96d1f0170b779c32c6b2cc58764f5d2cdef0 net: phy: Add Edge-rate driver for Microsemi PHYs. and are available on the fman-next branch in the git repository at

Re: [PATCH net-next] openvswitch: correctly fragment packet with mpls headers

2016-10-04 Thread Jiri Benc
On Mon, 3 Oct 2016 11:04:46 -0700, Pravin Shelar wrote: > This is not correct way to detect MPLS packet. inner_protocol can be > set by any tunnel device for using tunnel offloads. So this would > break the fragmentation for encapsulated packets. You're right, stupid me. > How about using

Re: [PATCH v5 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-04 Thread Raju Lakkaraju
Hi Andrew, Thank you for comments. I will fix and send the patch. Thanks, Raju. On Tue, Oct 04, 2016 at 08:54:01AM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > On Tue, Oct 04, 2016 at 12:48:59AM -0400, David Miller wrote: > > From: Raju Lakkaraju > > Date:

[patch net 0/2] mlxsw: Couple of fixes

2016-10-04 Thread Jiri Pirko
From: Jiri Pirko Couple of fixes from Yotam. Yotam Gigi (2): mlxsw: spectrum: Fix misuse of hard_header_len mlxsw: switchx2: Fix misuse of hard_header_len drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +- drivers/net/ethernet/mellanox/mlxsw/switchx2.c | 2 +- 2

[patch net 2/2] mlxsw: switchx2: Fix misuse of hard_header_len

2016-10-04 Thread Jiri Pirko
From: Yotam Gigi In order to specify that the mlxsw switchx2 driver needs additional headroom for packets, there have been use of the hard_header_len field of the netdevice struct. This commit changes that to use needed_headroom instead, as this is the correct way to do

[net-next 01/13] fsl/fman: split lines over 80 characters

2016-10-04 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman_muram.c | 3 ++- drivers/net/ethernet/freescale/fman/fman_muram.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/fman_muram.c

[patch net 1/2] mlxsw: spectrum: Fix misuse of hard_header_len

2016-10-04 Thread Jiri Pirko
From: Yotam Gigi In order to specify that the mlxsw spectrum driver needs additional headroom for packets, there have been use of the hard_header_len field of the netdevice struct. This commit changes that to use needed_headroom instead, as this is the correct way to do

Re: [PATCH net-next] openvswitch: correctly fragment packet with mpls headers

2016-10-04 Thread Jiri Benc
On Tue, 4 Oct 2016 10:24:58 +0200, Jiri Benc wrote: > On Mon, 3 Oct 2016 11:04:46 -0700, Pravin Shelar wrote: > > This is not correct way to detect MPLS packet. inner_protocol can be > > set by any tunnel device for using tunnel offloads. So this would > > break the fragmentation for encapsulated

Re: [PATCH v5 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-04 Thread Andrew Lunn
On Tue, Oct 04, 2016 at 03:01:34AM -0400, David Miller wrote: > From: Andrew Lunn > Date: Tue, 4 Oct 2016 08:54:01 +0200 > > > Oh dear. It was not ready for acceptance yet. I guess you missed all > > the discussion because it was attached to the previous version of the > > patch.

RE: [PATCH net-next 0/7] xen-netback: guest rx side refactor

2016-10-04 Thread Paul Durrant
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: 04 October 2016 05:52 > To: Paul Durrant > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org > Subject: Re: [PATCH net-next 0/7] xen-netback: guest rx side refactor > > From:

[PATCH v2 net-next 4/7] xen-netback: immediately wake tx queue when guest rx queue has space

2016-10-04 Thread Paul Durrant
From: David Vrabel When an skb is removed from the guest rx queue, immediately wake the tx queue, instead of after processing them. Signed-off-by: David Vrabel [re-based] Signed-off-by: Paul Durrant --- Cc: Wei Liu

[PATCH v2 net-next 1/7] xen-netback: separate guest side rx code into separate module

2016-10-04 Thread Paul Durrant
The netback source module has become very large and somewhat confusing. This patch simply moves all code related to the backend to frontend (i.e guest side rx) data-path into a separate rx source module. This patch contains no functional change, it is code movement and minimal changes to avoid

[PATCH v2 net-next 2/7] xen-netback: retire guest rx side prefix GSO feature

2016-10-04 Thread Paul Durrant
As far as I am aware only very old Windows network frontends make use of this style of passing GSO packets from backend to frontend. These frontends can easily be replaced by the freely available Xen Project Windows PV network frontend, which uses the 'default' mechanism for passing GSO packets,

Re: [Xen-devel] [PATCH v2 net-next 2/7] xen-netback: retire guest rx side prefix GSO feature

2016-10-04 Thread David Vrabel
On 04/10/16 10:29, Paul Durrant wrote: > As far as I am aware only very old Windows network frontends make use of > this style of passing GSO packets from backend to frontend. These > frontends can easily be replaced by the freely available Xen Project > Windows PV network frontend, which uses the

Re: [PATCH v6 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-04 Thread Raju Lakkaraju
Hi Andrew, Thank you for review comment. In another thread, I wrote my comment as below. - > In edge_table, remove the -'s and call edge_rate_magic_get with > positive values. The table is also missing "static const". >

Re: [Xen-devel] [PATCH v2 net-next 5/7] xen-netback: process guest rx packets in batches

2016-10-04 Thread Konrad Rzeszutek Wilk
On Tue, Oct 04, 2016 at 10:29:16AM +0100, Paul Durrant wrote: > From: David Vrabel > > Instead of only placing one skb on the guest rx ring at a time, process > a batch of up-to 64. This improves performance by ~10% in some tests. And does it regress latency workloads?

[PATCH v2 2/4] net: phy: dp83867: add support for MAC impedance configuration

2016-10-04 Thread Mugunthan V N
Add support for programmable MAC impedance configuration Signed-off-by: Mugunthan V N --- drivers/net/phy/dp83867.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 91177a4..795ae17

Re: [PATCH v2 3/4] ARM: dts: dra72-evm-revc: fix correct phy delay and impedance settings

2016-10-04 Thread Andrew Lunn
On Tue, Oct 04, 2016 at 06:26:06PM +0530, Mugunthan V N wrote: > The default impedance settings of the phy is not the optimal > value, due to this the second ethernet is not working. Fix it > with correct values which makes the second ethernet port to work. > > Signed-off-by: Mugunthan V N

Re: [PATCH v2 2/4] net: phy: dp83867: add support for MAC impedance configuration

2016-10-04 Thread Lokesh Vutla
On Tuesday 04 October 2016 06:26 PM, Mugunthan V N wrote: > Add support for programmable MAC impedance configuration > > Signed-off-by: Mugunthan V N > --- > drivers/net/phy/dp83867.c | 28 > 1 file changed, 28 insertions(+) > > diff --git

Re: [PATCH v2 3/4] ARM: dts: dra72-evm-revc: fix correct phy delay and impedance settings

2016-10-04 Thread Lokesh Vutla
On Tuesday 04 October 2016 06:26 PM, Mugunthan V N wrote: > The default impedance settings of the phy is not the optimal > value, due to this the second ethernet is not working. Fix it > with correct values which makes the second ethernet port to work. > > Signed-off-by: Mugunthan V N

[PATCH net-next 2/2] openvswitch: fix vlan subtraction from packet length

2016-10-04 Thread Jiri Benc
When the packet has its vlan tag in skb->vlan_tci, the length of the VLAN header is not counted in skb->len. It doesn't make sense to subtract it. In addition, to honor the comment below the code, the VLAN header length should not be subtracted if there's a vlan tag in skb->vlan_tci. This leads

Re: [v2] mwifiex: report wakeup for wowlan

2016-10-04 Thread Kalle Valo
Rajat Jain writes: > Hello Kalie, > > On Mon, Oct 3, 2016 at 6:04 AM, Kalle Valo wrote: >> Rajat Jain wrote: >>> Enable notifying wakeup source to the PM core in case of >>> a wake on wireless LAN event. >>> >>> Signed-off-by:

Re: [PATCH v2 4/4] ARM: dts: dra72-evm-revc: fix correct phy delay

2016-10-04 Thread Andrew Lunn
On Tue, Oct 04, 2016 at 06:26:07PM +0530, Mugunthan V N wrote: > The current delay settings of the phy are not the optimal value, > fix it with correct values. This should be a separate patch, since it has nothing to do with impedance. Andrew > > Signed-off-by: Mugunthan V N

[net-next PATCH] drivers: net: cpsw-phy-sel: add support to configure rgmii internal delay

2016-10-04 Thread Mugunthan V N
Add support to enable CPSW RGMII internal delay (id mode) bits when rgmii internal delay is configured in phy. Signed-off-by: Mugunthan V N --- drivers/net/ethernet/ti/cpsw-phy-sel.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

RE: [Xen-devel] [PATCH v2 net-next 2/7] xen-netback: retire guest rx side prefix GSO feature

2016-10-04 Thread Paul Durrant
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: 04 October 2016 13:52 > To: Paul Durrant ; annie...@oracle.com; > joao.m.mart...@oracle.com > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org; Wei Liu >

[PATCH net-next 0/2] openvswitch: vlan fixes

2016-10-04 Thread Jiri Benc
Fix a bug and inefficiency in the vlan handling code introduced by the 802.1AD set. Strictly speaking, both were present even before that set but it made them more prominent. Jiri Benc (2): openvswitch: remove nonreachable code in vlan parsing openvswitch: fix vlan subtraction from packet

[PATCH net-next 1/2] openvswitch: remove nonreachable code in vlan parsing

2016-10-04 Thread Jiri Benc
It can never happen that there's a vlan tag in the packet but not in skb->vlan_tci. This is ensured in __netif_receive_skb_core and honored by skb_vlan_push and skb_vlan_pop. The code dealing with such case is a dead code. Moreover, the likely() statement around skb_vlan_tag_present is bogus.

Re: [Xen-devel] [PATCH v2 net-next 4/7] xen-netback: immediately wake tx queue when guest rx queue has space

2016-10-04 Thread Konrad Rzeszutek Wilk
On Tue, Oct 04, 2016 at 02:29:15AM -0700, Paul Durrant wrote: > From: David Vrabel > > When an skb is removed from the guest rx queue, immediately wake the > tx queue, instead of after processing them. Please, could the description explain why? > > Signed-off-by:

Re: [PATCH v6 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-04 Thread Andrew Lunn
> Regarding remove the -'s in table, PHY data sheet descript the > concept of edge rate with table. I would like to keep the same table > in driver. The double negative makes the code ugly. Plus a negative slowdown is a speed up! The kernel maintainability and sanity comes first, and if the data

[PATCH v2 0/4] add support for impedance control for TI dp83867 phy and fix 2nd ethernet on dra72 rev C evm

2016-10-04 Thread Mugunthan V N
Add support for configurable impedance control for TI dp83867 phy via devicetree. More documentation in [1]. CPSW second ethernet is not working, fix it by enabling impedance configuration on the phy. Verified the patch on DRA72 Rev C evm, logs at [2]. Also pushed a branch [3] for others to test.

Re: [PATCH v2 2/4] net: phy: dp83867: add support for MAC impedance configuration

2016-10-04 Thread Andrew Lunn
> + if (of_property_read_bool(of_node, "ti,max-output-imepdance")) > + dp83867->io_impedance = DP83867_IO_MUX_CFG_IO_IMPEDANCE_MAX; > + else if (of_property_read_bool(of_node, "ti,min-output-imepdance")) Did you really test this? Or did you make the same typos in your device

Re: [PATCH] net: hns: qdd missing \n to end of dev_err messages

2016-10-04 Thread Sergei Shtylyov
Hello. On 10/04/2016 02:06 PM, Colin King wrote: From: Colin Ian King Trival fix, dev_err messages are missing a \n, so add it. Signed-off-by: Colin Ian King --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 4 ++-- 1 file changed,

Re: [Xen-devel] [PATCH v2 net-next 2/7] xen-netback: retire guest rx side prefix GSO feature

2016-10-04 Thread Konrad Rzeszutek Wilk
On Tue, Oct 04, 2016 at 10:29:13AM +0100, Paul Durrant wrote: > As far as I am aware only very old Windows network frontends make use of > this style of passing GSO packets from backend to frontend. These > frontends can easily be replaced by the freely available Xen Project > Windows PV network

[PATCH v2 3/4] ARM: dts: dra72-evm-revc: fix correct phy delay and impedance settings

2016-10-04 Thread Mugunthan V N
The default impedance settings of the phy is not the optimal value, due to this the second ethernet is not working. Fix it with correct values which makes the second ethernet port to work. Signed-off-by: Mugunthan V N --- arch/arm/boot/dts/dra72-evm-revc.dts | 2 ++ 1 file

[PATCH v2 4/4] ARM: dts: dra72-evm-revc: fix correct phy delay

2016-10-04 Thread Mugunthan V N
The current delay settings of the phy are not the optimal value, fix it with correct values. Signed-off-by: Mugunthan V N --- arch/arm/boot/dts/dra72-evm-revc.dts | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH][V2] net: hns: Add missing \n to end of dev_err messages, tidy up text

2016-10-04 Thread Colin King
From: Colin Ian King Trival fix, dev_err messages are missing a \n, so add it. Also fix grammer, spelling mistake and add white spaces to various error messages. Signed-off-by: Colin Ian King ---

[PATCH v2 1/4] net: phy: dp83867: Add documentation for optional impedance control

2016-10-04 Thread Mugunthan V N
Add documention of ti,impedance-control which can be used to correct MAC impedance mismatch using phy extended registers. Signed-off-by: Mugunthan V N --- Documentation/devicetree/bindings/net/ti,dp83867.txt | 12 1 file changed, 12 insertions(+) diff --git

Re: [Xen-devel] [PATCH v2 net-next 7/7] xen/netback: add fraglist support for to-guest rx

2016-10-04 Thread David Vrabel
On 04/10/16 10:29, Paul Durrant wrote: > From: Ross Lagerwall > > This allows full 64K skbuffs (with 1500 mtu ethernet, composed of 45 > fragments) to be handled by netback for to-guest rx. Reviewed-by: David Vrabel David

[PATCH] net: axienet: Add missing \n to end of dev_err messages

2016-10-04 Thread Colin King
From: Colin Ian King Trival fix, dev_err messages are missing a \n, so add it. Signed-off-by: Colin Ian King --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

RE: [PATCH net-next 1/3] net: ethernet: mediatek: get the chip id by ETHDMASYS registers

2016-10-04 Thread Nelson Chang
Hi John, Thanks for your review! I will modify that as below. Would you think it is okay? static int mtk_get_chip_id(struct mtk_eth *eth, u32 *chip_id) { u32 val[2], id[4]; regmap_read(eth->ethsys, ETHSYS_CHIPID0_3, [0]); regmap_read(eth->ethsys, ETHSYS_CHIPID4_7, [1]);

[PATCH] net: hns: qdd missing \n to end of dev_err messages

2016-10-04 Thread Colin King
From: Colin Ian King Trival fix, dev_err messages are missing a \n, so add it. Signed-off-by: Colin Ian King --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2] phy: micrel.c: Enable ksz9031 energy-detect power-down mode

2016-10-04 Thread Florian Fainelli
On 10/03/2016 10:52 PM, Mike Looijmans wrote: > Set bit 0 in register 1C.23 to enable the EDPD feature of the > KSZ9031 PHY. This reduces power consumption when the link is > down. > > Signed-off-by: Mike Looijmans Reviewed-by: Florian Fainelli

[PATCH] net: ps3_gelic: Add missing \n to end of deb_dbg message

2016-10-04 Thread Colin King
From: Colin Ian King Trival fix, dev_dbg message is missing a \n, so add it. Signed-off-by: Colin Ian King --- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH net-next 1/3] net: ethernet: mediatek: get the chip id by ETHDMASYS registers

2016-10-04 Thread John Crispin
On 04/10/2016 14:12, Nelson Chang wrote: > Hi John, > > Thanks for your review! > I will modify that as below. Would you think it is okay? > > static int mtk_get_chip_id(struct mtk_eth *eth, u32 *chip_id) > { > u32 val[2], id[4]; > > regmap_read(eth->ethsys, ETHSYS_CHIPID0_3,

[PATCH] i40e: Add missing \n to end of dev_err message

2016-10-04 Thread Colin King
From: Colin Ian King Trival fix, dev_err message is missing a \n, so add it. Signed-off-by: Colin Ian King --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH net-next 0/7] qed*: Add qedr infrastructure support

2016-10-04 Thread Doug Ledford
On 10/3/2016 11:24 PM, David Miller wrote: > From: Yuval Mintz > Date: Sat, 1 Oct 2016 21:59:54 +0300 > >> In the last couple of weeks we've been sending RFCs for the qedr >> driver - the RoCE driver for QLogic FastLinQ 4 line of adapters. >> Latest RFC can be

Re: [PATCH v6 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-04 Thread Andrew Lunn
On Tue, Oct 04, 2016 at 05:11:12PM +0530, Raju Lakkaraju wrote: > From: Raju Lakkaraju > > Edge-rate: > As system and networking speeds increase, a signal's output transition, > also know as the edge rate or slew rate (V/ns), takes on greater importance > because

[PATCH v6 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-04 Thread Raju Lakkaraju
From: Raju Lakkaraju Edge-rate: As system and networking speeds increase, a signal's output transition, also know as the edge rate or slew rate (V/ns), takes on greater importance because high-speed signals come with a price. That price is an assortment of

Re: [PATCH net-next 2/3] net: ethernet: mediatek: get hw lro capability by the chip id instead of by the dtsi

2016-10-04 Thread Nelson Chang
Hi John, do you plan to add more chips to the mtk_is_hwlro_supporte() function ? => yes, there will be more chips with hw lro in the future, so i think using mtk_is_hwlro_supporte() function can have the scalability. Thanks. Nelson -Original Message- From: John Crispin

Re: [PATCH v6 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-04 Thread Raju Lakkaraju
Hi Andrew, Thank you for review comments. I accepted your review comment and change the code. I resent for code review. Thanks, Raju. On Tue, Oct 04, 2016 at 02:53:19PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > Regarding remove the -'s in table, PHY data sheet descript the > >

RE: [Xen-devel] [PATCH v2 net-next 5/7] xen-netback: process guest rx packets in batches

2016-10-04 Thread Paul Durrant
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: 04 October 2016 13:48 > To: Paul Durrant > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org; Wei Liu > ; David Vrabel

Re: [PATCH net-next 1/2] net: phy: Add Wake-on-LAN driver for Microsemi PHYs.

2016-10-04 Thread Raju Lakkaraju
Hi Andrew, Thank you for code review and valuable comments. On Wed, Sep 28, 2016 at 06:27:05PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > +#define MSCC_PHY_WOL_MAC_CONTROL 27 > > +#define EDGE_RATE_CNTL_POS 5 > > +#define EDGE_RATE_CNTL_MASK0x00E0 > >

Re: [PATCH 6/6] mISDN: remove unused function

2016-10-04 Thread Arnd Bergmann
On Saturday, September 24, 2016 1:28:02 PM CEST Baoyou Xie wrote: > diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c > index f6ab6027..2519510 100644 > --- a/drivers/isdn/mISDN/layer2.c > +++ b/drivers/isdn/mISDN/layer2.c > @@ -459,15 +459,6 @@ IsDISC(u_char *data) >

RE: [Xen-devel] [PATCH v2 net-next 4/7] xen-netback: immediately wake tx queue when guest rx queue has space

2016-10-04 Thread Paul Durrant
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: 04 October 2016 13:49 > To: Paul Durrant > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org; Wei Liu > ; David Vrabel

Re: [Xen-devel] [PATCH v2 net-next 5/7] xen-netback: process guest rx packets in batches

2016-10-04 Thread David Vrabel
On 04/10/16 13:47, Konrad Rzeszutek Wilk wrote: > On Tue, Oct 04, 2016 at 10:29:16AM +0100, Paul Durrant wrote: >> From: David Vrabel >> >> Instead of only placing one skb on the guest rx ring at a time, process >> a batch of up-to 64. This improves performance by ~10%

[PATCH v2 2/7] ethtool: avoid resource leak of strings in do_gprivflags

2016-10-04 Thread John W. Linville
Coverity issue: 1363119 Fixes: e1ee596326ae ("Add support for querying and setting private flags") Signed-off-by: John W. Linville Reviewed-by: Greg Rose --- ethtool.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff

Re: [PATCH 2/7] ethtool: avoid resource leak of strings in do_gprivflags

2016-10-04 Thread John W. Linville
On Mon, Oct 03, 2016 at 01:54:26PM -0400, Jarod Wilson wrote: > On Fri, Sep 30, 2016 at 03:56:16PM -0400, John W. Linville wrote: > > Coverity issue: 1363119 > > Fixes: e1ee596326ae ("Add support for querying and setting private flags") > > > > Signed-off-by: John W. Linville

Re: [PATCH net-next 1/2] net: phy: Add Wake-on-LAN driver for Microsemi PHYs.

2016-10-04 Thread Raju Lakkaraju
Hi Florian, Thank you for code review and valuable comments. On Wed, Sep 28, 2016 at 10:37:07AM -0700, Florian Fainelli wrote: > EXTERNAL EMAIL > > > On 09/28/2016 05:01 AM, Raju Lakkaraju wrote: > > From: Raju Lakkaraju > > > > Wake-on-LAN (WoL) is an Ethernet

RE: [net-next 08/13] fsl/fman: check pcsphy pointer before use

2016-10-04 Thread David Laight
From: Madalin Bucur > Sent: 04 October 2016 08:33 > Subject: [net-next 08/13] fsl/fman: check pcsphy pointer before use .. > --- a/drivers/net/ethernet/freescale/fman/fman_memac.c > +++ b/drivers/net/ethernet/freescale/fman/fman_memac.c > @@ -507,6 +507,9 @@ static void

[PATCH v7 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-04 Thread Raju Lakkaraju
From: Raju Lakkaraju Edge-rate: As system and networking speeds increase, a signal's output transition, also know as the edge rate or slew rate (V/ns), takes on greater importance because high-speed signals come with a price. That price is an assortment of

Re: [Xen-devel] [PATCH v2 net-next 2/7] xen-netback: retire guest rx side prefix GSO feature

2016-10-04 Thread Konrad Rzeszutek Wilk
On Tue, Oct 04, 2016 at 01:35:41PM +, Paul Durrant wrote: > > -Original Message- > > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > > Sent: 04 October 2016 13:52 > > To: Paul Durrant ; annie...@oracle.com; > > joao.m.mart...@oracle.com > > Cc:

Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

2016-10-04 Thread Raju Lakkaraju
Hi Andrew, Thank you for code review and valuable comments. On Wed, Sep 28, 2016 at 10:24:51PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > + reg_val = phy_read(phydev, MSCC_PHY_BYPASS_CONTROL); > > + if ((mdix == ETH_TP_MDI) || (mdix == ETH_TP_MDI_X)) { > > + reg_val

Re: [PATCH v7 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-04 Thread Andrew Lunn
> v7: > - As per review comment, Removed '-'s (minus) sign in Edge rate table. Still no exact match on the table. So if i specify a voltage of 3301, 53% slowdown it looks i will actually get 0% slowdown and no error message. That is not very helpful. Andrew

Re: [PATCH net-next 1/2] openvswitch: remove nonreachable code in vlan parsing

2016-10-04 Thread Eric Garver
Hi Jiri, On Tue, Oct 04, 2016 at 02:30:01PM +0200, Jiri Benc wrote: > It can never happen that there's a vlan tag in the packet but not in > skb->vlan_tci. This is ensured in __netif_receive_skb_core and honored by > skb_vlan_push and skb_vlan_pop. The code dealing with such case is a dead >

Re: [PATCH net-next 0/7] rxrpc: More fixes and adjustments

2016-10-04 Thread David Miller
From: David Howells Date: Tue, 04 Oct 2016 17:01:30 +0100 > What's the procedure for sending more fixes at this point? Do I send them > against net-next, since net doesn't contain the things to be fixed yet, or do > I wait for net to catch up? I'm sending Linus a pull

Re: Assertion faileda at samples/bpf/test_maps

2016-10-04 Thread William Tu
Hi Louie, Can you check whether your num_possible_cpu == num_online_cpu? by doing: cat /sys/devices/system/cpu/possible and see how many cpu[0-9] ls /sys/devices/system/cpu/cpu* There is a related discussion here: https://www.mail-archive.com/netdev@vger.kernel.org/msg121258.html Regards,

  1   2   >