[PATCH net-next v3 0/3] NCSI VLAN Filtering Support

2017-08-28 Thread Samuel Mendoza-Jonas
This series (mainly patch 2) adds VLAN filtering to the NCSI implementation. A fair amount of code already exists in the NCSI stack for VLAN filtering but none of it is actually hooked up. This goes the final mile and fixes a few bugs in the existing code found along the way (patch 1). Patch 3

Re: [PATCH] connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback_entry()

2017-08-28 Thread Dan Carpenter
On Sun, Aug 27, 2017 at 11:16:06PM +, Waskiewicz Jr, Peter wrote: > On 8/27/17 3:26 PM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Sun, 27 Aug 2017 21:18:37 +0200 > > > > Omit an extra message for a memory allocation failure in this function. >

[PATCH net-next v3 1/3] net/ncsi: Fix several packet definitions

2017-08-28 Thread Samuel Mendoza-Jonas
Signed-off-by: Samuel Mendoza-Jonas --- v2: Rebased on latest net-next net/ncsi/ncsi-cmd.c | 10 +- net/ncsi/ncsi-pkt.h | 2 +- net/ncsi/ncsi-rsp.c | 3 ++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c

[PATCH net-next v3 2/3] net/ncsi: Configure VLAN tag filter

2017-08-28 Thread Samuel Mendoza-Jonas
Make use of the ndo_vlan_rx_{add,kill}_vid callbacks to have the NCSI stack process new VLAN tags and configure the channel VLAN filter appropriately. Several VLAN tags can be set and a "Set VLAN Filter" packet must be sent for each one, meaning the ncsi_dev_state_config_svf state must be

[PATCH net-next v3 3/3] ftgmac100: Support NCSI VLAN filtering when available

2017-08-28 Thread Samuel Mendoza-Jonas
Register the ndo_vlan_rx_{add,kill}_vid callbacks and set the NETIF_F_HW_VLAN_CTAG_FILTER if NCSI is available. This allows the VLAN core to notify the NCSI driver when changes occur so that the remote NCSI channel can be properly configured to filter on the set VLAN tags. Signed-off-by: Samuel

Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode

2017-08-28 Thread Antoine Tenart
Hi Russell, On Fri, Aug 25, 2017 at 11:43:13PM +0100, Russell King - ARM Linux wrote: > On Fri, Aug 25, 2017 at 04:48:12PM +0200, Antoine Tenart wrote: > > The link mode (speed, duplex) was forced based on what the phylib > > returns. This should not be the case, and only forced by ethtool > >

Re: [PATCH] net: sunrpc: svcsock: fix NULL-pointer exception

2017-08-28 Thread Vadim Lomovtsev
On Fri, Aug 25, 2017 at 06:01:28PM -0400, J. Bruce Fields wrote: > On Fri, Aug 18, 2017 at 06:00:47AM -0400, Vadim Lomovtsev wrote: > > While running nfs/connectathon tests kernel NULL-pointer exception > > has been observed due to races in svcsock.c. > > > > Race is appear when kernel accepts

Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode

2017-08-28 Thread Marcin Wojtas
Hi Antoine, 2017-08-28 8:55 GMT+02:00 Antoine Tenart : > Hi Russell, > > On Fri, Aug 25, 2017 at 11:43:13PM +0100, Russell King - ARM Linux wrote: >> On Fri, Aug 25, 2017 at 04:48:12PM +0200, Antoine Tenart wrote: >> > The link mode (speed, duplex) was forced

Re: connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback_entry()

2017-08-28 Thread SF Markus Elfring
> Did coccinelle trip on the message I suggest to reconsider this implementation detail with the combination of a function call like “kzalloc”. A script for the semantic patch language can point various update candidates out according to a source code search pattern which is similar to

RE: Question about ip_defrag

2017-08-28 Thread liujian (CE)
Hi I checked our 3.10 kernel, we had backported all percpu_counter bug fix in lib/percpu_counter.c and include/linux/percpu_counter.h. And I check 4.13-rc6, also has the issue if NIC's rx cpu num big enough. > > > > the issue: > > > > Ip_defrag fail caused by frag_mem_limit reached

PTP: PHY timestamping when MAC is PTP capable

2017-08-28 Thread Sørensen , Stefan
Hi, I have run into a problem with packet timestamping on a platform (cpsw + dp83640) where both the PHY and the MAC is PTP capable and I need the PHY to perform the timestamping. In the current code, SIOCGHWTSTAMP is passed to the MAC driver and only if it does not support PTP itself will it

Re: [PATCH] NFC: fix device-allocation error return

2017-08-28 Thread Johan Hovold
Samuel or David, On Sat, Jul 22, 2017 at 03:32:28PM +0200, Johan Hovold wrote: > On Sun, Jul 09, 2017 at 01:08:58PM +0200, Johan Hovold wrote: > > A recent change fixing NFC device allocation itself introduced an > > error-handling bug by returning an error pointer in case device-id > >

Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode

2017-08-28 Thread Russell King - ARM Linux
On Mon, Aug 28, 2017 at 10:38:37AM +0200, Marcin Wojtas wrote: > Hi Antoine, > > Can you be 100% sure that when using SGMII with PHY's (like Marvell > Alaska 88E1xxx series), is in-band link information always available? > I'd be very cautious with such assumption and use in-band management > only

[patch net-next 3/3] net/sched: Change act_api and act_xxx modules to use IDR

2017-08-28 Thread Chris Mi
Typically, each TC filter has its own action. All the actions of the same type are saved in its hash table. But the hash buckets are too small that it degrades to a list. And the performance is greatly affected. For example, it takes about 0m11.914s to insert 64K rules. If we convert the hash

[patch net-next 2/3] net/sched: Change cls_flower to use IDR

2017-08-28 Thread Chris Mi
Currently, all filters with the same priority are linked in a doubly linked list. Every filter should have a unique handle. To make the handle unique, we need to iterate the list every time to see if the handle exists or not when inserting a new filter. It is time-consuming. For example, it takes

[patch net-next 0/3] net/sched: Improve getting objects by indexes

2017-08-28 Thread Chris Mi
Using current TC code, it is very slow to insert a lot of rules. In order to improve the rules update rate in TC, we introduced the following two changes: 1) changed cls_flower to use IDR to manage the filters. 2) changed all act_xxx modules to use IDR instead of a

[patch net-next 1/3] idr: Add new APIs to support unsigned long

2017-08-28 Thread Chris Mi
The following new APIs are added: int idr_alloc_ext(struct idr *idr, void *ptr, unsigned long *index, unsigned long start, unsigned long end, gfp_t gfp); static inline void *idr_remove_ext(struct idr *idr, unsigned long id); static inline void *idr_find_ext(const struct idr

Re: [PATCH net-next v2 09/14] net: mvpp2: dynamic reconfiguration of the PHY mode

2017-08-28 Thread Antoine Tenart
Hi Russell, On Fri, Aug 25, 2017 at 11:46:16PM +0100, Russell King - ARM Linux wrote: > On Fri, Aug 25, 2017 at 04:48:16PM +0200, Antoine Tenart wrote: > > This patch adds logic to reconfigure the comphy/gop when the link status > > change at runtime. This is very useful on boards such as the

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-28 Thread Pavel Machek
Hi! Thanks for review. > > + case PHY_REG_STATUS: > > + ksz_pread8(sw, p, P_LINK_STATUS, ); > > + ksz_pread8(sw, p, P_SPEED_STATUS, ); > > + data = PHY_100BTX_FD_CAPABLE | > > + PHY_100BTX_CAPABLE | > > + PHY_10BT_FD_CAPABLE | >

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-28 Thread Pavel Machek
Hi! > > No, tag_ksz part probably is not acceptable. Do you see solution > > better than just copying it into tag_ksz1 file? > > How about something like this, which needs further work to actually > compile, but should give you the idea. If that's acceptable, yes, I can do something similar. I

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-28 Thread Pavel Machek
Hi! > >No, tag_ksz part probably is not acceptable. Do you see solution > >better than just copying it into tag_ksz1 file? > > You could have all Micrel tag implementations live under net/dsa/tag_ksz.c > and have e.g: DSA_TAG_PROTO_KSZ for the current (newer) switches and >

pull-request: wireless-drivers-next 2017-08-28

2017-08-28 Thread Kalle Valo
Hi Dave, here's a pull request to net-next for 4.14. Because I pulled wireless-drivers (at least that's my suspicion) the diffstat was wrong again and I created it manually. I recall Linus somewhere saying that in certain cases this is normal and it's ok to create the diffstat manually, so I

Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode

2017-08-28 Thread Antoine Tenart
On Mon, Aug 28, 2017 at 09:51:52AM +0100, Russell King - ARM Linux wrote: > On Mon, Aug 28, 2017 at 10:38:37AM +0200, Marcin Wojtas wrote: > > > > Can you be 100% sure that when using SGMII with PHY's (like Marvell > > Alaska 88E1xxx series), is in-band link information always available? > > I'd

Re: [PATCH net-next 1/4] net: Add SRIOV VGT+ support

2017-08-28 Thread Saeed Mahameed
On Mon, Aug 28, 2017 at 3:38 AM, Jakub Kicinski wrote: > On Sun, 27 Aug 2017 14:06:15 +0300, Saeed Mahameed wrote: >> From: Mohamad Haj Yahia >> >> VGT+ is a security feature that gives the administrator the ability of >> controlling the allowed vlan-ids

Re: [PATCH net-next 3/4] net/core: Add violation counters to VF statisctics

2017-08-28 Thread Saeed Mahameed
On Mon, Aug 28, 2017 at 3:43 AM, Jakub Kicinski wrote: > On Sun, 27 Aug 2017 14:06:17 +0300, Saeed Mahameed wrote: >> From: Eugenia Emantayev >> >> Add receive and transmit violation counters to be >> displayed in iproute2 VF statistics. >> >> Signed-off-by:

Re: [PATCH 6/6] mpls: VPLS support

2017-08-28 Thread Amine Kherbouche
any opinion on vpls driver path ? On 08/21/2017 07:15 PM, David Lamparter wrote: [work-in-progress, works but needs changes] [v2: refactored lots of things, e.g. dst_metadata, no more genetlink] [v4: removed pointless include/net/vpls.h, squashed pseudowire control word support, squashed

Re: [PATCH net-next] xen-netback: update ubuf_info initialization to anonymous union

2017-08-28 Thread Wei Liu
On Fri, Aug 25, 2017 at 01:10:43PM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > The xen driver initializes struct ubuf_info fields using designated > initializers. I recently moved these fields inside a nested anonymous > struct inside an anonymous union. I had

Re: DSA support for Micrel KSZ8895

2017-08-28 Thread Pavel Machek
Hi! > > > I'll forward your email to our support. > > > AFAIK, KSZ8895 has different register mapping from KSZ9477, > > > it will be more than ID changes in current driver. > > > > More than ID changes, indeed. As layout is completely different, it > > looks like different source file will be

Re: [PATCH] dt-binding: net/phy: fix interrupts description

2017-08-28 Thread Baruch Siach
Hi Dave, On Wed, Aug 23, 2017 at 09:11:00AM +0300, Baruch Siach wrote: > Commit b053dc5a722ea (powerpc: Refactor device tree binding) split the > Ethernet PHY binding documentation out of the big booting-without-of.txt > file, leaving a dangling reference to "section 2" in the 'interrupts' >

Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode

2017-08-28 Thread Russell King - ARM Linux
On Mon, Aug 28, 2017 at 11:40:51AM +0200, Antoine Tenart wrote: > On Mon, Aug 28, 2017 at 09:51:52AM +0100, Russell King - ARM Linux wrote: > > On Mon, Aug 28, 2017 at 10:38:37AM +0200, Marcin Wojtas wrote: > > > > > > Can you be 100% sure that when using SGMII with PHY's (like Marvell > > >

Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode

2017-08-28 Thread Antoine Tenart
On Mon, Aug 28, 2017 at 12:06:24PM +0100, Russell King - ARM Linux wrote: > On Mon, Aug 28, 2017 at 11:40:51AM +0200, Antoine Tenart wrote: > > On Mon, Aug 28, 2017 at 09:51:52AM +0100, Russell King - ARM Linux wrote: > > > On Mon, Aug 28, 2017 at 10:38:37AM +0200, Marcin Wojtas wrote: > > > > > >

Re: [patch net-next 2/3] net/sched: Change cls_flower to use IDR

2017-08-28 Thread Simon Horman
On Mon, Aug 28, 2017 at 02:41:16AM -0400, Chris Mi wrote: > Currently, all filters with the same priority are linked in a doubly > linked list. Every filter should have a unique handle. To make the > handle unique, we need to iterate the list every time to see if the > handle exists or not when

[ethtool] ethtool: Remove UDP Fragmentation Offload use from ethtool

2017-08-28 Thread Tariq Toukan
From: Shaker Daibes UFO was removed in kernel, here we remove it in ethtool app. Fixes the following issue: Features for ens8: Cannot get device udp-fragmentation-offload settings: Operation not supported Tested with "make check" Signed-off-by: Shaker Daibes

Re: DSA support for Micrel KSZ8895

2017-08-28 Thread Andrew Lunn
> I'm working at 4.13-rc. For network code, it is a good idea to use net-next. That is what you need to target in order to get patches with new features merged. Andrew

Re: [PATCH RFC WIP 0/5] IGMP snooping for local traffic

2017-08-28 Thread Andrew Lunn
On Sun, Aug 27, 2017 at 07:44:15PM -0700, Florian Fainelli wrote: > Hi Andrew, > > On 08/26/2017 01:56 PM, Andrew Lunn wrote: > > This is a WIP patchset i would like comments on from bridge, > > switchdev and hardware offload people. > > > > The linux bridge supports IGMP snooping. It will

Re: PTP: PHY timestamping when MAC is PTP capable

2017-08-28 Thread Richard Cochran
On Mon, Aug 28, 2017 at 08:39:44AM +, Sørensen, Stefan wrote: > I have run into a problem with packet timestamping on a platform (cpsw > + dp83640) where both the PHY and the MAC is PTP capable and I need > the PHY to perform the timestamping. In the current code, > SIOCGHWTSTAMP is passed to

[net-next PATCH 2/9] bpf: sockmap, remove STRPARSER map_flags and add multi-map support

2017-08-28 Thread John Fastabend
The addition of map_flags BPF_SOCKMAP_STRPARSER flags was to handle a specific use case where we want to have BPF parse program disabled on an entry in a sockmap. However, Alexei found the API a bit cumbersome and I agreed. Lets remove the STRPARSER flag and support the use case by allowing socks

[net-next PATCH 1/9] bpf: convert sockmap field attach_bpf_fd2 to type

2017-08-28 Thread John Fastabend
In the initial sockmap API we provided strparser and verdict programs using a single attach command by extending the attach API with a the attach_bpf_fd2 field. However, if we add other programs in the future we will be adding a field for every new possible type, attach_bpf_fd(3,4,..). This seems

[net-next PATCH 3/9] bpf: sockmap add missing rcu_read_(un)lock in smap_data_ready

2017-08-28 Thread John Fastabend
References to psock must be done inside RCU critical section. Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support") Signed-off-by: John Fastabend --- kernel/bpf/sockmap.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 3/8] tty/bcm63xx_uart: use refclk for the expected clock name

2017-08-28 Thread Greg Kroah-Hartman
On Wed, Aug 02, 2017 at 11:34:24AM +0200, Jonas Gorski wrote: > We now have the clock available under refclk, so use that. > > Signed-off-by: Jonas Gorski Acked-by: Greg Kroah-Hartman

[net-next PATCH 0/9] sockmap UAPI updates and fixes

2017-08-28 Thread John Fastabend
This series updates sockmap UAPI, adds additional test cases and provides a couple fixes. First the UAPI changes. The original API added two sockmap specific API artifacts (a) a new map_flags field with a sockmap specific update command and (b) a new sockmap specific attach field in the attach

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-28 Thread Andrew Lunn
> I may be confused here, but AFAICT: > > 1) Yes, it has standard layout when accessed over MDIO. Section 4.8 of the datasheet says: All the registers defined in this section can be also accessed via the SPI interface. Meaning all PHY registers can be access via the SPI

[net-next PATCH 9/9] bpf: test_maps add sockmap stress test

2017-08-28 Thread John Fastabend
Sockmap is a bit different than normal stress tests that can run in parallel as is. We need to reuse the same socket pool and map pool to get good stress test cases. Signed-off-by: John Fastabend --- tools/testing/selftests/bpf/test_maps.c | 29

Re: [PATCH net-next] bridge: fdb add and delete tracepoints

2017-08-28 Thread Roopa Prabhu
On Sun, Aug 27, 2017 at 7:11 PM, Florian Fainelli wrote: > On 08/27/2017 02:33 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Tracepoints to trace bridge forwarding database updates. > > Thanks for adding this! > >> >> Signed-off-by: Roopa

Re: [PATCH] connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback_entry()

2017-08-28 Thread Waskiewicz Jr, Peter
On 8/28/17 2:06 AM, Dan Carpenter wrote: > On Sun, Aug 27, 2017 at 11:16:06PM +, Waskiewicz Jr, Peter wrote: >> On 8/27/17 3:26 PM, SF Markus Elfring wrote: >>> From: Markus Elfring >>> Date: Sun, 27 Aug 2017 21:18:37 +0200 >>> >>> Omit an extra message for a

[PATCH net-next] hinic: don't build the module by default

2017-08-28 Thread Vitaly Kuznetsov
We probably don't want to enable code supporting particular hardware by default e.g. when someone does 'make defconfig'. Other ethernet modules don't do it. Signed-off-by: Vitaly Kuznetsov --- drivers/net/ethernet/huawei/hinic/Kconfig | 1 - 1 file changed, 1 deletion(-)

[net-next PATCH 6/9] bpf: harden sockmap program attach to ensure correct map type

2017-08-28 Thread John Fastabend
When attaching a program to sockmap we need to check map type is correct. Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support") Signed-off-by: John Fastabend --- kernel/bpf/sockmap.c |3 ++

[net-next PATCH 7/9] bpf: sockmap indicate sock events to listeners

2017-08-28 Thread John Fastabend
After userspace pushes sockets into a sockmap it may not be receiving data (assuming stream_{parser|verdict} programs are attached). But, it may still want to manage the socks. A common pattern is to poll/select for a POLLRDHUP event so we can close the sock. This patch adds the logic to wake up

[net-next PATCH 8/9] bpf: sockmap requires STREAM_PARSER add Kconfig entry

2017-08-28 Thread John Fastabend
SOCKMAP uses strparser code (compiled with Kconfig option CONFIG_STREAM_PARSER) to run the parser BPF program. Without this config option set sockmap wont be compiled. However, at the moment the only way to pull in the strparser code is to enable KCM. To resolve this create a BPF specific config

Re: Question about ip_defrag

2017-08-28 Thread Florian Westphal
liujian (CE) wrote: > Hi > > I checked our 3.10 kernel, we had backported all percpu_counter bug fix in > lib/percpu_counter.c and include/linux/percpu_counter.h. > And I check 4.13-rc6, also has the issue if NIC's rx cpu num big enough. > > > > > > the issue: > > > > >

[net-next PATCH 4/9] bpf: additional sockmap self tests

2017-08-28 Thread John Fastabend
Add some more sockmap tests to cover, - forwarding to NULL entries - more than two maps to test list ops - forwarding to different map Signed-off-by: John Fastabend --- tools/testing/selftests/bpf/sockmap_parse_prog.c |6 +

[net-next PATCH 5/9] bpf: more SK_SKB selftests

2017-08-28 Thread John Fastabend
Tests packet read/writes and additional skb fields. Signed-off-by: John Fastabend --- tools/testing/selftests/bpf/test_verifier.c | 98 +++ 1 file changed, 98 insertions(+) diff --git a/tools/testing/selftests/bpf/test_verifier.c

[PATCH net-next 4/4] net/mlx4: Add user mac FW update support

2017-08-28 Thread Tariq Toukan
From: Moshe Shemesh Adding support for updating the FW on new port mac, when port mac change is requested by the user. This info is required by the FW as OEM management tools require this info directly from the NIC FW. Check device capability bit to verify the FW supports

[PATCH net-next 0/4] mlx4 misc patches

2017-08-28 Thread Tariq Toukan
Hi Dave, This patchset contains misc patches from the team to the mlx4 Core and Eth drivers. Patch 1 by Eran replaces large static allocations by dynamic ones. Patch 2 by Leon makes an explicit conversion and solves a smatch warning. In patch 3 I fix a misplaced brackets of the sizeof operation.

[PATCH net-next 3/4] net/mlx4_core: Fix misplaced brackets of sizeof

2017-08-28 Thread Tariq Toukan
When changing the sizeof style usage in the patch cited below, one brackets misplacement was introduced. Here we fix it. Fixes: 31975e27a4b5 ("mlx4: sizeof style usage") Signed-off-by: Tariq Toukan Cc: Stephen Hemminger ---

[PATCH net-next 1/4] net/mlx4_core: Dynamically allocate structs at mlx4_slave_cap

2017-08-28 Thread Tariq Toukan
From: Eran Ben Elisha In order to avoid temporary large structs on the stack, allocate them dynamically. Signed-off-by: Eran Ben Elisha Signed-off-by: Tal Alon Signed-off-by: Tariq Toukan Signed-off-by: Saeed

[PATCH net-next 2/4] net/mlx4_core: Make explicit conversion to 64bit value

2017-08-28 Thread Tariq Toukan
From: Leon Romanovsky The "lg" variable is declared as int so in all places where this variable is used as a shift operand, the output will be int too. This produces the following smatch warning: drivers/net/ethernet/mellanox/mlx4/fw.c:1532 mlx4_map_cmd() warn:

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-28 Thread Maxim Uvarov
Micrel has some drivers on their web site to support some chips. For that chips they do virtual mdio over spi. And driver is available on download page: http://www.microchip.com/wwwproducts/en/KSZ8895 Documentation->Software library. Both driver and DSA driver. Driver has to work with some minor

[PATCH net-next v3 00/13] net: mvpp2: comphy configuration

2017-08-28 Thread Antoine Tenart
Hi all, This series, following up the one one the GoP/MAC configuration, aims at stopping to depend on the firmware/bootloader configuration when using the PPv2 engine. With this series the PPv2 driver does not need to rely on a previous configuration, and dynamic reconfiguration while the kernel

[PATCH net-next v3 09/13] arm64: dts: marvell: extend the cp110 syscon register area length

2017-08-28 Thread Antoine Tenart
This patch extends on both cp110 the system register area length to include some of the comphy registers as well. Signed-off-by: Antoine Tenart --- arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi | 2 +- arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi

[PATCH net-next v3 04/13] net: mvpp2: initialize the comphy

2017-08-28 Thread Antoine Tenart
On some platforms, the comphy is between the MAC GoP and the PHYs. The mvpp2 driver currently relies on the firmware/bootloader to configure the comphy. As a comphy driver was added to the generic PHY framework, this patch uses it in the mvpp2 driver to configure the comphy at boot time to avoid

[PATCH net-next v3 05/13] net: mvpp2: simplify the link_event function

2017-08-28 Thread Antoine Tenart
The link_event function is somewhat complicated. This cosmetic patch simplifies it. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git

[PATCH net-next v3 12/13] arm64: dts: marvell: 7040-db: add comphy references to Ethernet ports

2017-08-28 Thread Antoine Tenart
This patch adds comphy phandles to the Ethernet ports in the 7040-db device tree. The comphy is used to configure the serdes PHYs used by these ports. Signed-off-by: Antoine Tenart --- arch/arm64/boot/dts/marvell/armada-7040-db.dts | 1 + 1 file changed, 1

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-28 Thread Andy Gospodarek
On Fri, Aug 25, 2017 at 08:28:55AM -0700, Michael Chan wrote: > On Fri, Aug 25, 2017 at 8:10 AM, John Fastabend > wrote: > > On 08/25/2017 05:45 AM, Jesper Dangaard Brouer wrote: > >> On Thu, 24 Aug 2017 20:36:28 -0700 > >> Michael Chan wrote:

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-28 Thread Alexander Duyck
On Mon, Aug 28, 2017 at 9:02 AM, Andy Gospodarek wrote: > On Fri, Aug 25, 2017 at 08:28:55AM -0700, Michael Chan wrote: >> On Fri, Aug 25, 2017 at 8:10 AM, John Fastabend >> wrote: >> > On 08/25/2017 05:45 AM, Jesper Dangaard Brouer wrote: >> >> On

Re: [Intel-wired-lan] [PATCH] e1000e: apply burst mode settings only on default

2017-08-28 Thread Alexander Duyck
On Sun, Aug 27, 2017 at 1:30 AM, Neftin, Sasha wrote: > On 8/25/2017 18:06, Willem de Bruijn wrote: >> >> From: Willem de Bruijn >> >> Devices that support FLAG2_DMA_BURST have different default values >> for RDTR and RADV. Apply burst mode default

[PATCH net-next v3 06/13] net: mvpp2: improve the link management function

2017-08-28 Thread Antoine Tenart
When the link status changes, the phylib calls the link_event function in the mvpp2 driver. Before this patch only the egress/ingress transmit was enabled/disabled. This patch adds more functionality to the link status management code by enabling/disabling the port per-cpu interrupts, and the port

Re: mlxsw and rtnl lock

2017-08-28 Thread Roopa Prabhu
On Sat, Aug 26, 2017 at 10:04 AM, Ido Schimmel wrote: > On Fri, Aug 25, 2017 at 01:26:07PM -0700, David Ahern wrote: >> Jiri / Ido: >> >> [snip] > > Regarding the silent abort, that's intentional. You can look at the same > code in v4.9 - when the chain was still blocking - and

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-28 Thread John Fastabend
On 08/28/2017 09:02 AM, Andy Gospodarek wrote: > On Fri, Aug 25, 2017 at 08:28:55AM -0700, Michael Chan wrote: >> On Fri, Aug 25, 2017 at 8:10 AM, John Fastabend >> wrote: >>> On 08/25/2017 05:45 AM, Jesper Dangaard Brouer wrote: On Thu, 24 Aug 2017 20:36:28 -0700

[PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-28 Thread Antoine Tenart
On the CP110 unit, which can be found on various Marvell platforms such as the 7k and 8k (currently), a comphy (common PHYs) hardware block can be found. This block provides a number of PHYs which can be used in various modes by other controllers (network, SATA ...). These common PHYs must be

[PATCH net-next v3 03/13] Documentation/bindings: phy: document the Marvell comphy driver

2017-08-28 Thread Antoine Tenart
The Marvell Armada 7K/8K SoCs contains an hardware block called COMPHY that provides a number of shared PHYs used by various interfaces in the SoC: network, SATA, PCIe, etc. This Device Tree binding allows to describe this COMPHY hardware block. Signed-off-by: Antoine Tenart

[PATCH net-next v3 08/13] net: mvpp2: dynamic reconfiguration of the comphy/GoP/MAC

2017-08-28 Thread Antoine Tenart
This patch adds logic to reconfigure the comphy/GoP/MAC when the link state is updated at runtime. This is very useful on boards where many link speed are supported: depending on what is negotiated the PPv2 driver will automatically reconfigures the link between the PHY and the MAC.

Re: [PATCH net-next] bridge: fdb add and delete tracepoints

2017-08-28 Thread Roopa Prabhu
On Sun, Aug 27, 2017 at 7:11 PM, Florian Fainelli wrote: > On 08/27/2017 02:33 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Tracepoints to trace bridge forwarding database updates. > > Thanks for adding this! > >> >> Signed-off-by: Roopa

[PATCH net-next v3 10/13] arm64: dts: marvell: add comphy nodes on cp110 master and slave

2017-08-28 Thread Antoine Tenart
Now that the comphy driver is available, this patch adds the corresponding nodes in the cp110 master and slave device trees. Signed-off-by: Antoine Tenart --- .../boot/dts/marvell/armada-cp110-master.dtsi | 38 ++

[PATCH net-next v3 01/13] phy: add sgmii and 10gkr modes to the phy_mode enum

2017-08-28 Thread Antoine Tenart
This patch adds more generic PHY modes to the phy_mode enum, to allow configuring generic PHYs to the SGMII and/or the 10GKR mode by using the set_mode callback. Signed-off-by: Antoine Tenart --- include/linux/phy/phy.h | 2 ++ 1 file changed, 2 insertions(+)

Re: IPv6 loopback issue report

2017-08-28 Thread David Ahern
On 8/28/17 8:48 AM, Tariq Toukan wrote: > #  /bin/ping6 -c 3 fe80::7efe:90ff:fecb:7502%ens8 > PING fe80::7efe:90ff:fecb:7502%ens8(fe80::7efe:90ff:fecb:7502) 56 data > bytes > > --- fe80::7efe:90ff:fecb:7502%ens8 ping statistics --- > 3 packets transmitted, 0 received, 100% packet loss, time

Re: [PATCH net-next 1/4] net: Add SRIOV VGT+ support

2017-08-28 Thread Sabrina Dubroca
2017-08-27, 14:06:15 +0300, Saeed Mahameed wrote: [...] > +#define VF_VLAN_BITMAP DIV_ROUND_UP(VF_VLAN_N_VID, sizeof(__u64) * > BITS_PER_BYTE) > +struct ifla_vf_vlan_trunk { > + __u32 vf; > + __u64 allowed_vlans_8021q_bm[VF_VLAN_BITMAP]; > + __u64

[PATCH net v1 1/1] tipc: permit bond slave as bearer

2017-08-28 Thread Parthasarathy Bhuvaragan
For a bond slave device as a tipc bearer, the dev represents the bond interface and orig_dev represents the slave in tipc_l2_rcv_msg(). Since we decode the tipc_ptr from bonding device (dev), we fail to find the bearer and thus tipc links are not established. In this commit, we register the tipc

[PATCH net-next v3 07/13] net: mvpp2: do not set GMAC autoneg when using XLG MAC

2017-08-28 Thread Antoine Tenart
When using the XLG MAC, it does not make sense to force the GMAC autoneg parameters. This patch adds checks to only set the GMAC autoneg parameters when needed (i.e. when not using the XLG MAC). Signed-off-by: Antoine Tenart ---

Re: [PATCH RFC WIP 0/5] IGMP snooping for local traffic

2017-08-28 Thread Stephen Hemminger
On Sat, 26 Aug 2017 22:56:05 +0200 Andrew Lunn wrote: > This is a WIP patchset i would like comments on from bridge, switchdev > and hardware offload people. > > The linux bridge supports IGMP snooping. It will listen to IGMP > reports on bridge ports and keep track of which

Fwd: DA850-evm MAC Address is random

2017-08-28 Thread Adam Ford
The davinvi_emac MAC address seems to attempt a call to ti_cm_get_macid in cpsw-common.c but it returns the message 'davinci_emac davinci_emac.1: incompatible machine/device type for reading mac address ' and then generates a random MAC address. The function appears to lookup varions boards using

Re: [PATCH net-next] bpf: fix oops on allocation failure

2017-08-28 Thread John Fastabend
On 08/25/2017 01:47 PM, Daniel Borkmann wrote: > On 08/25/2017 10:27 PM, Dan Carpenter wrote: >> "err" is set to zero if bpf_map_area_alloc() fails so it means we return >> ERR_PTR(0) which is NULL. The caller, find_and_alloc_map(), is not >> expecting NULL returns and will oops. >> >> Fixes:

IPv6 loopback issue report

2017-08-28 Thread Tariq Toukan
Hi all, We encountered the following issue in our regression tests over net-next branch. IPv6 loopback ping fails, while it works for IPv4. Reproduces with all NICs, doesn't seem to be a driver issue. Example: # ifconfig ens8 ens8: flags=4163 mtu 1500

Re: [ethtool] ethtool: Remove UDP Fragmentation Offload use from ethtool

2017-08-28 Thread Eric Dumazet
On Mon, 2017-08-28 at 15:38 +0300, Tariq Toukan wrote: > From: Shaker Daibes > > UFO was removed in kernel, here we remove it in ethtool app. > > Fixes the following issue: > Features for ens8: > Cannot get device udp-fragmentation-offload settings: Operation not supported

[PATCH net-next v3 13/13] arm64: defconfig: enable Marvell CP110 comphy

2017-08-28 Thread Antoine Tenart
From: Miquel Raynal The comphy is an hardware block giving access to common PHYs that can be used by various other engines (Network, SATA, ...). This is used on Marvell 7k/8k platforms for now. Enable the corresponding driver. Signed-off-by: Miquel Raynal

[PATCH net-next v3 11/13] arm64: dts: marvell: mcbin: add comphy references to Ethernet ports

2017-08-28 Thread Antoine Tenart
This patch adds comphy phandles to the Ethernet ports in the mcbin device tree. The comphy is used to configure the serdes PHYs used by these ports. Signed-off-by: Antoine Tenart --- arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts | 3 +++ 1 file changed, 3

Re: [PATCH net 0/2] netfilter: ipvs: some fixes in sctp_conn_schedule

2017-08-28 Thread Pablo Neira Ayuso
On Sun, Aug 20, 2017 at 01:38:06PM +0800, Xin Long wrote: > Patch 1/2 fixes the regression introduced by commit 5e26b1b3abce. > Patch 2/2 makes ipvs not create conn for sctp ABORT packet. Will wait for Julian and Simon to tell me what I should do with this. Thanks!

Re: [ethtool] ethtool: Remove UDP Fragmentation Offload use from ethtool

2017-08-28 Thread David Miller
From: Eric Dumazet Date: Mon, 28 Aug 2017 08:00:11 -0700 > On Mon, 2017-08-28 at 15:38 +0300, Tariq Toukan wrote: >> From: Shaker Daibes >> >> UFO was removed in kernel, here we remove it in ethtool app. >> >> Fixes the following issue: >>

Re: [net-next PATCH 1/9] bpf: convert sockmap field attach_bpf_fd2 to type

2017-08-28 Thread Alexei Starovoitov
On Mon, Aug 28, 2017 at 07:10:04AM -0700, John Fastabend wrote: > In the initial sockmap API we provided strparser and verdict programs > using a single attach command by extending the attach API with a the > attach_bpf_fd2 field. > > However, if we add other programs in the future we will be

[iproute PATCH] ss: Fix for added diag support check

2017-08-28 Thread Phil Sutter
Commit 9f66764e308e9 ("libnetlink: Add test for error code returned from netlink reply") changed rtnl_dump_filter_l() to return an error in case NLMSG_DONE would contain one, even if it was ENOENT. This in turn breaks ss when it tries to dump DCCP sockets on a system without support for it: The

Re: [net-next PATCH 8/9] bpf: sockmap requires STREAM_PARSER add Kconfig entry

2017-08-28 Thread Alexei Starovoitov
On Mon, Aug 28, 2017 at 07:12:21AM -0700, John Fastabend wrote: > SOCKMAP uses strparser code (compiled with Kconfig option > CONFIG_STREAM_PARSER) to run the parser BPF program. Without this > config option set sockmap wont be compiled. However, at the moment > the only way to pull in the

Re: [net-next PATCH 5/9] bpf: more SK_SKB selftests

2017-08-28 Thread Alexei Starovoitov
On Mon, Aug 28, 2017 at 07:11:24AM -0700, John Fastabend wrote: > Tests packet read/writes and additional skb fields. > > Signed-off-by: John Fastabend Acked-by: Alexei Starovoitov > { > + "invalid access of tc_classid for SK_SKB",

Re: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet driver

2017-08-28 Thread Andrew Lunn
On Sun, Aug 27, 2017 at 01:47:19PM +, Chocron, Jonathan wrote: > This is a fixed version of my previous response (using proper indentation and > leaving only the specific questions responded to). Wow, this is old. 3 Feb 2017. I had to go dig into the archive to refresh my memory. > > > +/*

Re: [PATCH net 0/5] l2tp: fix some l2tp_tunnel_find() issues in l2tp_netlink

2017-08-28 Thread David Miller
From: Guillaume Nault Date: Fri, 25 Aug 2017 16:51:39 +0200 > Since l2tp_tunnel_find() doesn't take a reference on the tunnel it > returns, its users are almost guaranteed to be racy. > > This series defines l2tp_tunnel_get() which can be used as a safe > replacement, and

Re: [PATCH] igb: check memory allocation failure

2017-08-28 Thread Christophe JAILLET
Le 28/08/2017 à 01:09, Waskiewicz Jr, Peter a écrit : On 8/27/17 2:42 AM, Christophe JAILLET wrote: Check memory allocation failures and return -ENOMEM in such cases, as already done for other memory allocations in this function. This avoids NULL pointers dereference. Signed-off-by:

Re: [net-next PATCH 6/9] bpf: harden sockmap program attach to ensure correct map type

2017-08-28 Thread Alexei Starovoitov
On Mon, Aug 28, 2017 at 07:11:43AM -0700, John Fastabend wrote: > When attaching a program to sockmap we need to check map type > is correct. > > Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support") > Signed-off-by: John Fastabend good catch. Great to see that

Re: [net-next PATCH 4/9] bpf: additional sockmap self tests

2017-08-28 Thread Alexei Starovoitov
On Mon, Aug 28, 2017 at 07:11:05AM -0700, John Fastabend wrote: > Add some more sockmap tests to cover, > > - forwarding to NULL entries > - more than two maps to test list ops > - forwarding to different map > > Signed-off-by: John Fastabend Acked-by: Alexei

[PATCH] ipv6: sr: fix get_srh() to comply with IPv6 standard "RFC 8200"

2017-08-28 Thread Ahmed Abdelsalam
IPv6 packet may carry more than one extension header, and IPv6 nodes must acceptand attempt to process extension headers in any order and occurring any number of times in the same packet. Hence, there should be no assumption that Segment Routing extension header is to appear immediately after the

Re: [ethtool] ethtool: Remove UDP Fragmentation Offload use from ethtool

2017-08-28 Thread John W. Linville
On Mon, Aug 28, 2017 at 08:00:11AM -0700, Eric Dumazet wrote: > On Mon, 2017-08-28 at 15:38 +0300, Tariq Toukan wrote: > > From: Shaker Daibes > > > > UFO was removed in kernel, here we remove it in ethtool app. > > > > Fixes the following issue: > > Features for ens8: > >

Re: [PATCH 5/7] RDS: make rhashtable_params const

2017-08-28 Thread David Miller
From: Bhumika Goyal Date: Fri, 25 Aug 2017 19:51:45 +0530 > Make this const as it is either used during a copy operation or passed > to a const argument of the function rhltable_init > > Signed-off-by: Bhumika Goyal Applied.

  1   2   3   >