[RFC PATCH v3 6/6] i40e: Add support setting TC max bandwidth rates

2017-09-07 Thread Amritha Nambiar
This patch enables setting up maximum Tx rates for the traffic classes in i40e. The maximum rate is offloaded to the hardware through the mqprio framework by specifying the mode option as 'channel' and shaper option as 'bw_rlimit' and is configured for the VSI. Configuring minimum Tx rate limit is

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-07 Thread Richard Cochran
On Thu, Sep 07, 2017 at 07:34:11AM +0200, Henrik Austad wrote: > Also, does this mean that when you create the qdisc, you have locked the > bandwidth for the scheduler? Meaning, if I later want to add another > stream that requires more bandwidth, I have to close all active streams, >

Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it

2017-09-07 Thread Kalle Valo
Luca Coelho writes: > From: Luca Coelho > > The LEDS_CMD command is only supported in some newer FW versions > (e.g. iwlwifi-8000C-31.ucode), so we can't send it to older versions > (such as iwlwifi-8000C-27.ucode). > > To fix this, check for a new bit

[PATCH] drivers: net: Display proper debug level up to 6

2017-09-07 Thread Mathieu Malaterre
This will make it explicit some messages are of the form: dm9000_dbg(db, 5, ... Signed-off-by: Mathieu Malaterre --- drivers/net/ethernet/davicom/dm9000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/davicom/dm9000.c

Re: [PATCH] ath10: mark PM functions as __maybe_unused

2017-09-07 Thread Kalle Valo
Arnd Bergmann writes: > When CONFIG_PM_SLEEP is disabled, we get a compile-time > warning: > > drivers/net/wireless/ath/ath10k/pci.c:3417:12: error: 'ath10k_pci_pm_resume' > defined but not used [-Werror=unused-function] > static int ath10k_pci_pm_resume(struct device *dev) >

nfp bpf offload add/replace

2017-09-07 Thread Jiri Pirko
Hi Kuba. I'm looking into cls_bpf code and nfp_net_bpf_offload function in your driver. Why do you need TC_CLSBPF_ADD? Seems like TC_CLSBPF_REPLACE should be enough. It would make the cls_bpf code easier. Note that other cls just have replace/destroy (u32 too, as drivers handle NEW/REPLACE in

Re: [PATCH v2 2/2] selftests: bpf: test_kmod.sh: use modprobe on target device

2017-09-07 Thread Daniel Borkmann
On 09/07/2017 10:19 AM, naresh.kamb...@linaro.org wrote: From: Naresh Kamboju on ARM and ARM64 devices kernel source tree is not available so insmod "$SRC_TREE/lib/test_bpf.ko" is not working. on these target devices the test_bpf.ko is installed under

[RFC PATCH v3 2/6] i40e: Add macro for PF reset bit

2017-09-07 Thread Amritha Nambiar
Introduce a macro for the bit setting the PF reset flag and update its usages. This makes it easier to use this flag in functions to be introduced in future without encountering checkpatch issues related to alignment and line over 80 characters. Signed-off-by: Amritha Nambiar

[RFC PATCH v3 4/6] i40e: Enable 'channel' mode in mqprio for TC configs

2017-09-07 Thread Amritha Nambiar
The i40e driver is modified to enable the new mqprio hardware offload mode and factor the TCs and queue configuration by creating channel VSIs. In this mode, the priority to traffic class mapping and the user specified queue ranges are used to configure the traffic classes by setting the mode

[RFC PATCH v3 3/6] i40e: Add infrastructure for queue channel support

2017-09-07 Thread Amritha Nambiar
This patch sets up the infrastructure for offloading TCs and queue configurations to the hardware by creating HW channels(VSI). A new channel is created for each of the traffic class configuration offloaded via mqprio framework except for the first TC (TC0). TC0 for the main VSI is also

[RFC PATCH v3 1/6] mqprio: Introduce new hardware offload mode and shaper in mqprio

2017-09-07 Thread Amritha Nambiar
The offload types currently supported in mqprio are 0 (no offload) and 1 (offload only TCs) by setting these values for the 'hw' option. If offloads are supported by setting the 'hw' option to 1, the default offload mode is 'dcb' where only the TC values are offloaded to the device. This patch

[RFC PATCH v3 0/6] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

2017-09-07 Thread Amritha Nambiar
The following series introduces a new hardware offload mode in tc/mqprio where the TCs, the queue configurations and bandwidth rate limits are offloaded to the hardware. The existing mqprio framework is extended to configure the queue counts and layout and also added support for rate limiting.

[RFC PATCH v3 5/6] i40e: Refactor VF BW rate limiting

2017-09-07 Thread Amritha Nambiar
This patch refactors the BW rate limiting for Tx traffic on the VF to be reused in the next patch for rate limiting Tx traffic for the VSIs on the PF as well. v3: Minor fixes, clean up log messages based on Shannon's comments. Signed-off-by: Amritha Nambiar ---

Re: Fwd: DA850-evm MAC Address is random

2017-09-07 Thread Sekhar Nori
On Thursday 07 September 2017 03:11 AM, Adam Ford wrote: > On Mon, Sep 4, 2017 at 11:42 PM, Sekhar Nori wrote: >> Hi Adam, >> >> On Wednesday 30 August 2017 11:08 AM, Sekhar Nori wrote: I wonder if U-Boot isn't pushing something to Linux because it doesn't appear to be

Re: [PATCH v2 1/2] selftests: bpf: test_kmod.sh: check if module is present in the path before insert

2017-09-07 Thread Daniel Borkmann
On 09/07/2017 10:19 AM, naresh.kamb...@linaro.org wrote: From: Naresh Kamboju The test script works when kernel source and build module test_bpf.ko present on the machine. This patch will check if module is present in the path. Signed-off-by: Naresh Kamboju

[PATCH net v4 1/3] dt-bindings: add SFF vendor prefix

2017-09-07 Thread Baruch Siach
Acked-by: Rob Herring Signed-off-by: Baruch Siach --- v4: No change v3: Add Rob's ack v2: New patch in this series --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH net v4 2/3] dt-binding: net: sfp binding documentation

2017-09-07 Thread Baruch Siach
Add device-tree binding documentation SFP transceivers. Support for SFP transceivers has been recently introduced (drivers/net/phy/sfp.c). Signed-off-by: Baruch Siach --- v4: Remove redundant 'single' from the gpio specifier Rename 'moddef0-gpios' property to

Re: ipset losing entries on its own

2017-09-07 Thread Akshat Kakkar
Another observation : At times rehashing happens (v6.32) and hashsize increases to 2048 from 1024. But this is at times and not always. Needless to mention, it is for exactly same IPs added to the ipset in exactly same order.

[RFC, iproute2 PATCH v2] tc/mqprio: Offload mode and shaper options in mqprio

2017-09-07 Thread Amritha Nambiar
Adds new mqprio options for 'mode' and 'shaper'. The mode option can take values for offload modes such as 'dcb' (default), 'channel' with the 'hw' option set to 1. The 'shaper' option is to support HW shapers ('dcb' default) and takes the value 'bw_rlimit' for bandwidth rate limiting. The

[V2 PATCH net-next 0/2] Fixes for XDP_REDIRECT map

2017-09-07 Thread Jesper Dangaard Brouer
This my V2 of catching XDP_REDIRECT and bpf_redirect_map() API usage that can potentially crash the kernel. Addressed Daniels feedback in patch01, and added patch02 which catch and cleanup dangling map pointers. I know John and Daniel are working on a more long-term solution, of recording the

[V2 PATCH net-next 1/2] xdp: implement xdp_redirect_map for generic XDP

2017-09-07 Thread Jesper Dangaard Brouer
Using bpf_redirect_map is allowed for generic XDP programs, but the appropriate map lookup was never performed in xdp_do_generic_redirect(). Instead the map-index is directly used as the ifindex. For the xdp_redirect_map sample in SKB-mode '-S', this resulted in trying sending on ifindex 0 which

[V2 PATCH net-next 2/2] xdp: catch invalid XDP_REDIRECT API usage

2017-09-07 Thread Jesper Dangaard Brouer
Catch different invalid XDP_REDIRECT and bpf_redirect_map API usage. It is fairly easy to create a dangling redirect_info->map pointer, which (until John or Daniel fix this) can crash the kernel. The intended usage of the BPF helper bpf_redirect_map(), is to return XDP_REDIRECT action after

[PATCH net v4 3/3] net: phy: sfp: rename dt properties to match the binding

2017-09-07 Thread Baruch Siach
Make the Rx rate select control gpio property name match the documented binding. This would make the addition of 'rate-select1-gpios' for SFP+ support more natural. Also, make the MOD-DEF0 gpio property name match the documentation. Signed-off-by: Baruch Siach --- v4: Rename

Re: [PATCH] netfilter: xt_hashlimit: avoid 64-bit division

2017-09-07 Thread Pablo Neira Ayuso
On Wed, Sep 06, 2017 at 10:48:22PM +0200, Arnd Bergmann wrote: > On Wed, Sep 6, 2017 at 10:22 PM, Vishwanath Pai wrote: > > On 09/06/2017 03:57 PM, Arnd Bergmann wrote: > >> 64-bit division is expensive on 32-bit architectures, and > >> requires a special function call to avoid a

Re: [PATCH] netfilter: xt_hashlimit: avoid 64-bit division

2017-09-07 Thread Arnd Bergmann
On Thu, Sep 7, 2017 at 12:19 PM, Pablo Neira Ayuso wrote: > On Wed, Sep 06, 2017 at 10:48:22PM +0200, Arnd Bergmann wrote: >> On Wed, Sep 6, 2017 at 10:22 PM, Vishwanath Pai wrote: >> > On 09/06/2017 03:57 PM, Arnd Bergmann wrote: >> >> 64-bit division is

Re: [PATCH 1/3] security: bpf: Add eBPF LSM hooks to security module

2017-09-07 Thread Stephen Smalley
On Tue, 2017-09-05 at 15:24 -0700, Chenbo Feng via Selinux wrote: > On Fri, Sep 1, 2017 at 5:50 AM, Stephen Smalley > wrote: > > On Thu, 2017-08-31 at 13:56 -0700, Chenbo Feng wrote: > > > From: Chenbo Feng > > > > > > Introduce 5 LSM hooks to provide finer

Re: [PATCH] netfilter: xt_hashlimit: avoid 64-bit division

2017-09-07 Thread Geert Uytterhoeven
Hi Arnd, On Wed, Sep 6, 2017 at 9:57 PM, Arnd Bergmann wrote: > 64-bit division is expensive on 32-bit architectures, and > requires a special function call to avoid a link error like: > > net/netfilter/xt_hashlimit.o: In function `hashlimit_mt_common': >

[PATCH iproute2 2/4] devlink: Add support for special format protocol headers

2017-09-07 Thread Arkadi Sharshevsky
In case of global header (protocol header), the header:field ids are used to perform lookup for special format printer. In case no printer existence fallback to plain value printing. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko ---

[PATCH iproute2 0/4] Add support for dpipe's global header formatting

2017-09-07 Thread Arkadi Sharshevsky
Some dpipe's global header values need special formatting, for example Ethernet and IP addresses. This patchset adds support for IPv4/6 and Ethernet's special format. Arkadi Sharshevsky (4): devlink: Make match/action parsing more flexible devlink: Add support for special format protocol

[PATCH iproute2 4/4] devlink: Add support for protocol IPv4/IPv6/Ethernet special formats

2017-09-07 Thread Arkadi Sharshevsky
Add support for protocol IPv4/IPv6/Ethernet special formats. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- devlink/devlink.c | 75 ++- 1 file changed, 74 insertions(+), 1 deletion(-)

Re:

2017-09-07 Thread Quick Loan
Hello dear I am an International loan lender, I give out loans at 1% interest rate, email me at:(rich_ken2...@usa.com)

Re: [V2 PATCH net-next 1/2] xdp: implement xdp_redirect_map for generic XDP

2017-09-07 Thread Daniel Borkmann
On 09/07/2017 02:33 PM, Jesper Dangaard Brouer wrote: Using bpf_redirect_map is allowed for generic XDP programs, but the appropriate map lookup was never performed in xdp_do_generic_redirect(). Instead the map-index is directly used as the ifindex. For the xdp_redirect_map sample in SKB-mode

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-07 Thread Richard Cochran
On Thu, Sep 07, 2017 at 05:27:51PM +0200, Henrik Austad wrote: > On Thu, Sep 07, 2017 at 02:40:18PM +0200, Richard Cochran wrote: > And if you want to this driver to act as a bridge, how do you accomodate > change in network requirements? (i.e. how does this work with switchdev?) To my

Re: [PATCH net] smsc95xx: Configure pause time to 0xffff when tx flow control enabled

2017-09-07 Thread Andrew Lunn
On Thu, Sep 07, 2017 at 06:51:37AM +, nisar.sa...@microchip.com wrote: > From: Nisar Sayed > > Configure pause time to 0x when tx flow control enabled Hi Nisar You should explain the 'Why' in the commit message. Why do we want a pause time of 0x?

Re: nfp bpf offload add/replace

2017-09-07 Thread Jiri Pirko
Thu, Sep 07, 2017 at 03:44:12PM CEST, kubak...@wp.pl wrote: >On Thu, 7 Sep 2017 11:10:33 +0200, Jiri Pirko wrote: >> Hi Kuba. >> >> I'm looking into cls_bpf code and nfp_net_bpf_offload function in your >> driver. Why do you need TC_CLSBPF_ADD? Seems like TC_CLSBPF_REPLACE >> should be enough. It

[PATCH] net: ethernet: ti: netcp_core: no need in netif_napi_del

2017-09-07 Thread Ivan Khoronzhuk
Don't remove rx_napi specifically just before free_netdev(), it's supposed to be done in it and is confusing w/o tx_napi deletion. Signed-off-by: Ivan Khoronzhuk --- Based on net-next/master drivers/net/ethernet/ti/netcp_core.c | 1 - 1 file changed, 1 deletion(-)

Re: [PATCH net 2/3] lan78xx: Allow EEPROM write for less than MAX_EEPROM_SIZE

2017-09-07 Thread Andrew Lunn
On Thu, Sep 07, 2017 at 07:11:26AM +, nisar.sa...@microchip.com wrote: > From: Nisar Sayed > > Allow EEPROM write for less than MAX_EEPROM_SIZE > > Signed-off-by: Nisar Sayed > --- > drivers/net/usb/lan78xx.c | 4 > 1 file

[PATCH iproute2 1/4] devlink: Make match/action parsing more flexible

2017-09-07 Thread Arkadi Sharshevsky
This patch decouples the match/action parsing from printing. This is done as a preparation for adding the ability to print global header values, for example print IPv4 address, which require special formatting. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko

[PATCH iproute2 3/4] devlink: Update devlink UAPI file

2017-09-07 Thread Arkadi Sharshevsky
Update devlink UAPI file. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- include/linux/devlink.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/linux/devlink.h b/include/linux/devlink.h index

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-07 Thread Henrik Austad
On Thu, Sep 07, 2017 at 02:40:18PM +0200, Richard Cochran wrote: > On Thu, Sep 07, 2017 at 07:34:11AM +0200, Henrik Austad wrote: > > Also, does this mean that when you create the qdisc, you have locked the > > bandwidth for the scheduler? Meaning, if I later want to add another > > stream that

Re: [PATCH net 0/3] lan78xx: Fixes to lan78xx driver

2017-09-07 Thread Andrew Lunn
On Thu, Sep 07, 2017 at 07:10:51AM +, nisar.sa...@microchip.com wrote: > From: Nisar Sayed > > This series of patches are for lan78xx driver. > > These patches fixes potential issues associated with lan78xx driver Hi Nisar So this is version 2? Please include v2

Re: [V2 PATCH net-next 2/2] xdp: catch invalid XDP_REDIRECT API usage

2017-09-07 Thread Daniel Borkmann
Hey Jesper, On 09/07/2017 02:33 PM, Jesper Dangaard Brouer wrote: Catch different invalid XDP_REDIRECT and bpf_redirect_map API usage. It is fairly easy to create a dangling redirect_info->map pointer, which (until John or Daniel fix this) can crash the kernel. [...] Here's what I wrote up

Re: [PATCH 3/3] lan78xx: Use default value loaded from EEPROM/OTP when resetting

2017-09-07 Thread Andrew Lunn
On Thu, Sep 07, 2017 at 07:11:50AM +, nisar.sa...@microchip.com wrote: > From: Nisar Sayed > > Use default value loaded from EEPROM/OTP when resetting Hi Nisar Subject: [PATCH 3/3] Is this a fix for net, or further development for net-next? Why do we want the

RE: [PATCH net 0/3] lan78xx: Fixes to lan78xx driver

2017-09-07 Thread Woojung.Huh
> > > > This series of patches are for lan78xx driver. > > > > > > > > These patches fixes potential issues associated with lan78xx driver > > > > > > Hi Nisar > > > > > > So this is version 2? Please include v2 in the subject line. > > > > > > Also, briefly list what is different from the

Re: [PATCH net 0/3] lan78xx: Fixes to lan78xx driver

2017-09-07 Thread Andrew Lunn
On Thu, Sep 07, 2017 at 02:03:38PM +, woojung@microchip.com wrote: > > On Thu, Sep 07, 2017 at 07:10:51AM +, nisar.sa...@microchip.com > > wrote: > > > From: Nisar Sayed > > > > > > This series of patches are for lan78xx driver. > > > > > > These patches

Re: [PATCH 0/2] 9p: Fixes for hard-to-hit bugs

2017-09-07 Thread Latchesar Ionkov
Acked-by: Latchesar Ionkov On Wed, Sep 6, 2017 at 8:59 AM, Tuomas Tynkkynen wrote: > These two patches fix two hard-to-hit (but really annoying) bugs in 9p. > The first one was posted earlier in February (with one R-b), the second > is a new one. > > Both of

Re: nfp bpf offload add/replace

2017-09-07 Thread Jakub Kicinski
On Thu, 7 Sep 2017 11:10:33 +0200, Jiri Pirko wrote: > Hi Kuba. > > I'm looking into cls_bpf code and nfp_net_bpf_offload function in your > driver. Why do you need TC_CLSBPF_ADD? Seems like TC_CLSBPF_REPLACE > should be enough. It would make the cls_bpf code easier. > > Note that other cls just

Re: [PATCH net 1/3] lan78xx: Fix for eeprom read/write when device autosuspend

2017-09-07 Thread Andrew Lunn
On Thu, Sep 07, 2017 at 07:11:06AM +, nisar.sa...@microchip.com wrote: > From: Nisar Sayed > > Fix for eeprom read/write when device autosuspend So this is a fix? And you said [PATCH net 1/3], meaning it is supposed to go into stable? You should try to add a fixes

RE: [PATCH net 0/3] lan78xx: Fixes to lan78xx driver

2017-09-07 Thread Woojung.Huh
> On Thu, Sep 07, 2017 at 07:10:51AM +, nisar.sa...@microchip.com > wrote: > > From: Nisar Sayed > > > > This series of patches are for lan78xx driver. > > > > These patches fixes potential issues associated with lan78xx driver > > Hi Nisar > > So this is version

Re: [RFC PATCH v3 0/6] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

2017-09-07 Thread Nambiar, Amritha
On 9/7/2017 11:34 AM, Florian Fainelli wrote: > On 09/07/2017 04:00 AM, Amritha Nambiar wrote: >> The following series introduces a new hardware offload mode in >> tc/mqprio where the TCs, the queue configurations and bandwidth >> rate limits are offloaded to the hardware. The existing mqprio

Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it

2017-09-07 Thread Linus Torvalds
On Thu, Sep 7, 2017 at 5:39 AM, Kalle Valo wrote: > > Linus, do you want to apply this directly or should we take it via the > normal route (wireless-drivers -> net)? If your prefer the latter when > I'm planning to submit this to Dave in a day or two and expecting it to >

Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches

2017-09-07 Thread Gustavo A. R. Silva
Hi Larry, On 08/30/2017 11:48 PM, Larry Finger wrote: On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1226788 Signed-off-by: Gustavo A. R.

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-07 Thread Henrik Austad
On Thu, Sep 07, 2017 at 05:53:15PM +0200, Richard Cochran wrote: > On Thu, Sep 07, 2017 at 05:27:51PM +0200, Henrik Austad wrote: > > On Thu, Sep 07, 2017 at 02:40:18PM +0200, Richard Cochran wrote: > > And if you want to this driver to act as a bridge, how do you accomodate > > change in network

Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it

2017-09-07 Thread Kalle Valo
Linus Torvalds writes: > On Thu, Sep 7, 2017 at 5:39 AM, Kalle Valo wrote: >> >> Linus, do you want to apply this directly or should we take it via the >> normal route (wireless-drivers -> net)? If your prefer the latter when >> I'm planning

Re: [RFC PATCH v3 0/6] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

2017-09-07 Thread Florian Fainelli
On 09/07/2017 04:00 AM, Amritha Nambiar wrote: > The following series introduces a new hardware offload mode in > tc/mqprio where the TCs, the queue configurations and > bandwidth rate limits are offloaded to the hardware. The existing > mqprio framework is extended to configure the queue counts

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-07 Thread Guedes, Andre
Hi Henrik, Thanks for your feedback! I'll address some of your comments below. On Thu, 2017-09-07 at 07:34 +0200, Henrik Austad wrote: > > As for the shapers config interface: > > > >  * CBS (802.1Qav) > > > >    This patchset is proposing a new qdisc called 'cbs'. Its 'tc' cmd line > > is: >

[PATCH] net: tulip: Constify tulip_tbl

2017-09-07 Thread Kees Cook
It looks like all users of tulip_tbl are reads, so mark this table as read-only. $ git grep tulip_tbl # edited to avoid line-wraps... interrupt.c: iowrite32(tulip_tbl[tp->chip_id].valid_intrs, ... interrupt.c: iowrite32(tulip_tbl[tp->chip_id].valid_intrs&~RxPollInt, ... interrupt.c:

Re: [PATCH 0/2] net: Fix crashes due to activity during suspend

2017-09-07 Thread Florian Fainelli
On 08/23/2017 10:13 AM, Florian Fainelli wrote: > On 08/23/2017 04:45 AM, Geert Uytterhoeven wrote: >> Hi Florian, >> >> On Tue, Aug 22, 2017 at 8:49 PM, Florian Fainelli >> wrote: >>> On 08/22/2017 11:37 AM, Geert Uytterhoeven wrote: If an Ethernet device is used

Re: [V2 PATCH net-next 2/2] xdp: catch invalid XDP_REDIRECT API usage

2017-09-07 Thread Daniel Borkmann
On 09/07/2017 04:13 PM, Daniel Borkmann wrote: [...] +uint64_t addr = (unsigned long)prog; And of course: s/uint64_t/u64/. Lack of context switch. ;-)

Bad escapes in ip -online

2017-09-07 Thread John Kodis
The -online option to the 'ip link', 'ip addr', and perhaps others is putting out a backslash in places where a newline character should go, as so: 1: lo: mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000\link/loopback 00:00:00:00:00:00 brd

Re: [Intel-wired-lan] [RFC PATCH v3 0/6] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

2017-09-07 Thread Shannon Nelson
On 9/7/2017 4:00 AM, Amritha Nambiar wrote: The following series introduces a new hardware offload mode in tc/mqprio where the TCs, the queue configurations and bandwidth rate limits are offloaded to the hardware. The existing mqprio framework is extended to configure the queue counts and layout

Re: nfp bpf offload add/replace

2017-09-07 Thread Jakub Kicinski
On Thu, 7 Sep 2017 16:05:03 +0200, Jiri Pirko wrote: > Thu, Sep 07, 2017 at 03:44:12PM CEST, kubak...@wp.pl wrote: > >On Thu, 7 Sep 2017 11:10:33 +0200, Jiri Pirko wrote: > >> Hi Kuba. > >> > >> I'm looking into cls_bpf code and nfp_net_bpf_offload function in your > >> driver. Why do you need

Re: [Patch net v2 2/2] net_sched: fix all the madness of tc filter chain

2017-09-07 Thread Cong Wang
On Wed, Sep 6, 2017 at 11:32 PM, Jiri Pirko wrote: > Thu, Sep 07, 2017 at 06:26:07AM CEST, xiyou.wangc...@gmail.com wrote: >>This patch fixes the following madness of tc filter chain: > > Could you avoid expressive words like "madness" and such? > Please be technical. > If the

Re: pull-request: mac80211 2017-09-07

2017-09-07 Thread David Miller
From: Johannes Berg Date: Thu, 7 Sep 2017 09:09:38 +0200 > During my long absence some things have accumulated, but there wasn't > actually all that much that could've gone into the last cycle, and a > fix or two was taken care of by others. > > The most important

Re: iwlwifi: mvm: only send LEDS_CMD when the FW supports it

2017-09-07 Thread Kalle Valo
Luciano Coelho wrote: > From: Luca Coelho > > The LEDS_CMD command is only supported in some newer FW versions > (e.g. iwlwifi-8000C-31.ucode), so we can't send it to older versions > (such as iwlwifi-8000C-27.ucode). > > To fix this, check for a new

Re: Bad escapes in ip -online

2017-09-07 Thread Stephen Hemminger
On Thu, 7 Sep 2017 12:08:56 -0400 John Kodis wrote: > The -online option to the 'ip link', 'ip addr', and perhaps others is > putting out a backslash in places where a newline character should go, > as so: > > 1: lo: mtu 65536 qdisc noqueue state

Re: [Intel-wired-lan] [RFC PATCH v3 0/6] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

2017-09-07 Thread Nambiar, Amritha
On 9/7/2017 9:45 AM, Shannon Nelson wrote: > On 9/7/2017 4:00 AM, Amritha Nambiar wrote: >> The following series introduces a new hardware offload mode in >> tc/mqprio where the TCs, the queue configurations and >> bandwidth rate limits are offloaded to the hardware. The existing >> mqprio

Re: [Intel-wired-lan] [RFC PATCH v3 0/6] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

2017-09-07 Thread Shannon Nelson
On 9/7/2017 10:22 AM, Nambiar, Amritha wrote: On 9/7/2017 9:45 AM, Shannon Nelson wrote: [...] It would be nice to know what has changed since the last review, either summarized here or in the individual patch files. [...] For all those patch files that have changed since the last

[PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in ksz_common.c

2017-09-07 Thread Tristram.Ha
From: Tristram Ha Create new ksz9477.c file from original ksz_common.c. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c new file mode 100644 index 000..bc722b4 ---

[PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers.

2017-09-07 Thread Tristram.Ha
From: Tristram Ha This series of patches is to modify the original KSZ9477 DSA driver so that other KSZ switch drivers can be added and use the common code. This patch set is against net-next. drivers/net/dsa/microchip/Makefile |2 +-

[PATCH RFC 4/6] The common header ksz_priv.h does not contain chip specific data

2017-09-07 Thread Tristram.Ha
From: Tristram Ha The header ksz_priv.h is used by all KSZ switch drivers so chip specific data are removed and commonly used variables are added. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/ksz_priv.h

[PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ switch drivers.

2017-09-07 Thread Tristram.Ha
From: Tristram Ha Break ksz_common.c into 2 files so that the common code can be used by other KSZ switch drivers. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/Makefile b/drivers/net/dsa/microchip/Makefile index

[PATCH RFC 1/5] Add KSZ8795 switch driver support in Kconfig

2017-09-07 Thread Tristram.Ha
From: Tristram Ha Add KSZ8795 switch support with SPI access. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/Kconfig b/drivers/net/dsa/microchip/Kconfig index a8b8f59..0b6225e 100644 ---

[PATCH RFC 0/5] Add DSA driver support for KSZ8795 switch

2017-09-07 Thread Tristram.Ha
From: Tristram Ha This series of patches is to add DSA driver support for KSZ8795 switch. Previous patches for KSZ9477 have to be applied first before these. This patch set is against net-next. drivers/net/dsa/microchip/Kconfig | 18 +

Re: Can you help to analyze this panic issue when using VPN?

2017-09-07 Thread Cong Wang
On Thu, Sep 7, 2017 at 3:18 AM, Songchuan wrote: > <4>[ 1730.085113s][pid:1928,cpu3,HeapTaskDaemon]CPU: 3 PID: 1928 Comm: > HeapTaskDaemon Tainted: GB W 4.1.18-kasan-g6e99722-dirty #1 Sorry, 4.1 is too old for upstream. As you know 4.13 is just out. Please try

Re: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

2017-09-07 Thread Linus Walleij
On Thu, Sep 7, 2017 at 11:30 PM, wrote: >> If someone is using GPIO descriptors with GPIO disabled, i.e. calling >> gpiod_get() and friends, this is very likely to be a bug, and what >> the driver wants to do is: >> >> depends on GPIOLIB >> >> or >> >> select GPIOLIB

latest netdev net-next kernel panic

2017-09-07 Thread Paweł Staszewski
I want to mention also here cause last trace for RIP was dst_dev_put https://bugzilla.kernel.org/attachment.cgi?id=258259

Re: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in ksz_common.c

2017-09-07 Thread Andrew Lunn
On Thu, Sep 07, 2017 at 09:09:04PM +, tristram...@microchip.com wrote: > From: Tristram Ha > > Create new ksz9477.c file from original ksz_common.c. > > Signed-off-by: Tristram Ha > --- > diff --git a/drivers/net/dsa/microchip/ksz9477.c

Re: [PATCH RFC 5/6] Switch SPI driver calls its own driver switch register function

2017-09-07 Thread Andrew Lunn
On Thu, Sep 07, 2017 at 09:09:22PM +, tristram...@microchip.com wrote: > From: Tristram Ha > > SPI driver calls own specific switch register function. > Shutdown callback function is added to reset switch to default state. > > Signed-off-by: Tristram Ha

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-07 Thread Guedes, Andre
On Thu, 2017-09-07 at 18:18 +0200, Henrik Austad wrote: > On Thu, Sep 07, 2017 at 05:53:15PM +0200, Richard Cochran wrote: > > On Thu, Sep 07, 2017 at 05:27:51PM +0200, Henrik Austad wrote: > > > On Thu, Sep 07, 2017 at 02:40:18PM +0200, Richard Cochran wrote: > > > And if you want to this driver

RE: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

2017-09-07 Thread Woojung.Huh
> >>> If someone is using GPIO descriptors with GPIO disabled, i.e. calling > >>> gpiod_get() and friends, this is very likely to be a bug, and what > >>> the driver wants to do is: > >>> > >>> depends on GPIOLIB > >>> > >>> or > >>> > >>> select GPIOLIB > >>> > >>> in Kconfig. The whole

Re: latest netdev net-next kernel panic

2017-09-07 Thread Paweł Staszewski
Also this panic occured about 3 minutes after traffic rise to 40G before host was working without trafic for about 30minutes - after traffic start to flow this bug start. Now i have this host without traffic and it is working for almost 1 hour :) W dniu 2017-09-07 o 23:47, Paweł Staszewski

[PATCH RFC 3/6] The file ksz_common.c contains common code shared by all KSZ switch drivers

2017-09-07 Thread Tristram.Ha
From: Tristram Ha The file ksz_common.c only holds common code used by all KSZ switch drivers. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index

[PATCH RFC 5/6] Switch SPI driver calls its own driver switch register function

2017-09-07 Thread Tristram.Ha
From: Tristram Ha SPI driver calls own specific switch register function. Shutdown callback function is added to reset switch to default state. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/ksz_spi.c

[PATCH RFC 6/6] Modify tag_ksz.c to support other KSZ switch drivers

2017-09-07 Thread Tristram.Ha
From: Tristram Ha The KSZ tail tag code can be used by different KSZ switch drivers. Signed-off-by: Tristram Ha --- diff --git a/net/dsa/tag_ksz.c b/net/dsa/tag_ksz.c index 010ca0a..d5faf14 100644 --- a/net/dsa/tag_ksz.c +++

[PATCH RFC 4/5] Add KSZ8795 register definitions

2017-09-07 Thread Tristram.Ha
From: Tristram Ha Add KSZ8795 switch support with register definitions. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/ksz8795.h b/drivers/net/dsa/microchip/ksz8795.h new file mode 100644 index 000..005eda5 ---

[PATCH RFC 5/5] Add KSZ8795 SPI driver

2017-09-07 Thread Tristram.Ha
From: Tristram Ha Add KSZ8795 switch support with SPI access. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/ksz8795_spi.c b/drivers/net/dsa/microchip/ksz8795_spi.c new file mode 100644 index 000..0f9c731 ---

[PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile

2017-09-07 Thread Tristram.Ha
From: Tristram Ha Add KSZ8795 switch support with SPI access. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/Makefile b/drivers/net/dsa/microchip/Makefile index 0961c30..0d8ba48 100644 ---

[PATCH net] bpf: don't select potentially stale ri->map from buggy xdp progs

2017-09-07 Thread Daniel Borkmann
We can potentially run into a couple of issues with the XDP bpf_redirect_map() helper. The ri->map in the per CPU storage can become stale in several ways, mostly due to misuse, where we can then trigger a use after free on the map: i) prog A is calling bpf_redirect_map(), returning XDP_REDIRECT

[PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added

2017-09-07 Thread Tristram.Ha
From: Tristram Ha Add other KSZ switches support so that patch check does not complain. Signed-off-by: Tristram Ha --- Documentation/devicetree/bindings/net/dsa/ksz.txt | 117 -- 1 file changed, 62 insertions(+), 55

Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ switch drivers.

2017-09-07 Thread Andrew Lunn
On Thu, Sep 07, 2017 at 09:08:58PM +, tristram...@microchip.com wrote: > From: Tristram Ha > > Break ksz_common.c into 2 files so that the common code can be used by other > KSZ switch drivers. > > Signed-off-by: Tristram Ha > --- >

Re: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

2017-09-07 Thread Florian Fainelli
On 09/07/2017 02:33 PM, Linus Walleij wrote: > On Thu, Sep 7, 2017 at 11:30 PM, wrote: >>> If someone is using GPIO descriptors with GPIO disabled, i.e. calling >>> gpiod_get() and friends, this is very likely to be a bug, and what >>> the driver wants to do is: >>>

Re: latest netdev net-next kernel panic

2017-09-07 Thread Eric Dumazet
On Thu, 2017-09-07 at 23:30 +0200, Paweł Staszewski wrote: > I want to mention also here cause last trace for RIP was dst_dev_put > > https://bugzilla.kernel.org/attachment.cgi?id=258259 Can you provide a bit more context ? Thanks !

Re: [PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added

2017-09-07 Thread Andrew Lunn
> -- compatible: For external switch chips, compatible string must be exactly > one > - of: "microchip,ksz9477" > +- compatible: Should be "microchip,ksz9477" for KSZ9477 chip, > + "microchip,ksz8795" for KSZ8795 chip, > + "microchip,ksz8794" for KSZ8794 chip, > +

Re: [PATCH iproute2 3/4] devlink: Update devlink UAPI file

2017-09-07 Thread Stephen Hemminger
On Thu, 7 Sep 2017 17:26:42 +0300 Arkadi Sharshevsky wrote: > Update devlink UAPI file. > > Signed-off-by: Arkadi Sharshevsky > Signed-off-by: Jiri Pirko > --- > include/linux/devlink.h | 18 ++ > 1 file changed,

Re: [PATCH iproute2 0/4] Add support for dpipe's global header formatting

2017-09-07 Thread Stephen Hemminger
On Thu, 7 Sep 2017 17:26:39 +0300 Arkadi Sharshevsky wrote: > Some dpipe's global header values need special formatting, for example > Ethernet and IP addresses. This patchset adds support for IPv4/6 and > Ethernet's special format. > > Arkadi Sharshevsky (4): >

Re: [Patch net v2 2/2] net_sched: fix all the madness of tc filter chain

2017-09-07 Thread Jiri Pirko
Thu, Sep 07, 2017 at 07:45:49PM CEST, xiyou.wangc...@gmail.com wrote: >On Wed, Sep 6, 2017 at 11:32 PM, Jiri Pirko wrote: >> Thu, Sep 07, 2017 at 06:26:07AM CEST, xiyou.wangc...@gmail.com wrote: >>>This patch fixes the following madness of tc filter chain: >> >> Could you avoid

[PATCH RFC 3/5] Add KSZ8795 switch driver

2017-09-07 Thread Tristram.Ha
From: Tristram Ha Add KSZ8795 switch support with function code. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/ksz8795.c b/drivers/net/dsa/microchip/ksz8795.c new file mode 100644 index 000..e4d4e6a ---

RE: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

2017-09-07 Thread Woojung.Huh
> If someone is using GPIO descriptors with GPIO disabled, i.e. calling > gpiod_get() and friends, this is very likely to be a bug, and what > the driver wants to do is: > > depends on GPIOLIB > > or > > select GPIOLIB > > in Kconfig. The whole optional thing is mainly a leftover from when

Re: [PATCH RFC 6/6] Modify tag_ksz.c to support other KSZ switch drivers

2017-09-07 Thread Andrew Lunn
On Thu, Sep 07, 2017 at 09:09:30PM +, tristram...@microchip.com wrote: > From: Tristram Ha > > The KSZ tail tag code can be used by different KSZ switch drivers. > > Signed-off-by: Tristram Ha > --- > diff --git a/net/dsa/tag_ksz.c

  1   2   >