Re: [PATCH] netfilter: nat: constify rhashtable_params

On Wed, Aug 30, 2017 at 05:18:04PM +0530, Arvind Yadav wrote: > rhashtable_params are not supposed to change at runtime. All > Functions rhashtable_* working with const rhashtable_params > provided by . So mark the non-const structs > as const. Applied to nf, thanks.

Re: [PATCH v2] netfilter: xt_hashlimit: fix build error caused by 64bit division

On Fri, Sep 08, 2017 at 01:38:58AM -0400, Vishwanath Pai wrote: > 64bit division causes build/link errors on 32bit architectures. It > prints out error messages like: > > ERROR: "__aeabi_uldivmod" [net/netfilter/xt_hashlimit.ko] undefined! > > The value of avg passed through by userspace in BYTE

Re: [PATCH 2/2] netfilter/libxt_hashlimit: new feature/algorithm for xt_hashlimit

On Fri, Aug 18, 2017 at 04:59:06PM -0400, Vishwanath Pai wrote: > This patch adds a new feature to hashlimit that allows matching on the > current packet/byte rate without rate limiting. This can be enabled > with a new flag --hashlimit-rate-match. The match returns true if the > current rate of

Re: [PATCH v5 10/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

> > > +static int mdio_mux_syscon_switch_fn(int current_child, int > > > desired_child, > > > + void *data) > > > +{ > > > + struct stmmac_priv *priv = data; > > > + struct sunxi_priv_data *gmac = priv->plat->bsp_priv; > > > + u32 reg, val; > > > + int ret = 0; > > >

Re: [PATCH iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough

Hi Hangbin, On Fri, Sep 08, 2017 at 06:14:56PM +0800, Hangbin Liu wrote: [...] > diff --git a/lib/libnetlink.c b/lib/libnetlink.c > index be7ac86..37cfb5a 100644 > --- a/lib/libnetlink.c > +++ b/lib/libnetlink.c > @@ -402,6 +402,59 @@ static void rtnl_dump_error(const struct rtnl_handle > *rth,

Re: [PATCH net] bpf: don't select potentially stale ri->map from buggy xdp progs

On Fri, 08 Sep 2017 12:34:28 +0200 Daniel Borkmann wrote: > On 09/08/2017 07:06 AM, Jesper Dangaard Brouer wrote: > > On Fri, 8 Sep 2017 00:14:51 +0200 > > Daniel Borkmann wrote: > > > >> + /* This is really only caused by a deliberately crappy >

Re: [PATCH iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough

On Fri, Sep 08, 2017 at 01:02:47PM +0200, Phil Sutter wrote: > Hi Hangbin, > > On Fri, Sep 08, 2017 at 06:14:56PM +0800, Hangbin Liu wrote: > [...] > > diff --git a/lib/libnetlink.c b/lib/libnetlink.c > > index be7ac86..37cfb5a 100644 > > --- a/lib/libnetlink.c > > +++ b/lib/libnetlink.c > > @@

[PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

The UniPhier platform from Socionext provides the AVE ethernet controller that includes MAC and MDIO bus supporting RGMII/RMII modes. The controller is named AVE. Signed-off-by: Kunihiko Hayashi Signed-off-by: Jassi Brar ---

[PATCH net-next 1/3] dt-bindings: net: add DT bindings for Socionext UniPhier AVE

DT bindings for the AVE ethernet controller found on Socionext's UniPhier platforms. Signed-off-by: Kunihiko Hayashi Signed-off-by: Jassi Brar --- .../bindings/net/socionext,uniphier-ave4.txt | 44 ++ 1 file

[PATCH net-next 0/3] add UniPhier AVE ethernet support

This series adds support for Socionext AVE ethernet controller implemented on UniPhier SoCs. This driver supports RGMII/RMII modes. Furthermore, this series includes support for realtek RTL8201F PHY to be implemented on some supported boards. Jassi Brar (1): net: phy: realtek: add RTL8201F

Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers.

Hi Tristram, tristram...@microchip.com writes: > From: Tristram Ha > > This series of patches is to modify the original KSZ9477 DSA driver so that > other KSZ switch drivers can be added and use the common code. Please see

[PATCH net-next 3/3] net: phy: realtek: add RTL8201F phy-id and functions

From: Jassi Brar Add RTL8201F phy-id and the related functions to the driver. The original patch is as follows: https://patchwork.kernel.org/patch/2538341/ Signed-off-by: Jongsung Kim Signed-off-by: Jassi Brar

Re: [PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added

2017-09-08 0:54 GMT+03:00 Andrew Lunn : >> -- compatible: For external switch chips, compatible string must be exactly >> one >> - of: "microchip,ksz9477" >> +- compatible: Should be "microchip,ksz9477" for KSZ9477 chip, >> + "microchip,ksz8795" for KSZ8795 chip, >> +

Re: [PATCH net] bpf: don't select potentially stale ri->map from buggy xdp progs

On 09/08/2017 01:52 PM, Jesper Dangaard Brouer wrote: On Fri, 08 Sep 2017 12:34:28 +0200 Daniel Borkmann wrote: On 09/08/2017 07:06 AM, Jesper Dangaard Brouer wrote: On Fri, 8 Sep 2017 00:14:51 +0200 Daniel Borkmann wrote: + /* This is

Re: [PATCH iproute2 2/2] lib/libnetlink: update rtnl_talk to support malloc buff at run time

On Fri, Sep 08, 2017 at 01:06:52PM +0200, Phil Sutter wrote: > Hi Hangbin, > > On Fri, Sep 08, 2017 at 06:14:57PM +0800, Hangbin Liu wrote: > [...] > > diff --git a/genl/ctrl.c b/genl/ctrl.c > > index 448988e..699657b 100644 > > --- a/genl/ctrl.c > > +++ b/genl/ctrl.c > > @@ -55,6 +55,7 @@ int

Re: [PATCH v5 10/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

On Fri, Sep 08, 2017 at 03:05:20PM +0200, Andrew Lunn wrote: > > +#define DWMAC_sUN8I_MDIO_MUX_INTERNAL_ID 0 > > +#define DWMAC_sUN8I_MDIO_MUX_EXTERNAL_ID 1 > > > > /* H3/A64 specific bits */ > > #define SYSCON_RMII_EN BIT(13) /* 1: enable RMII (overrides > > EPIT) */ > > @@

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

> +static int ave_mdio_busywait(struct net_device *ndev) > +{ > + int ret = 1, loop = 100; > + u32 mdiosr; > + > + /* wait until completion */ > + while (1) { > + mdiosr = ave_r32(ndev, AVE_MDIOSR); > + if (!(mdiosr & AVE_MDIOSR_STS)) > +

Re: [PATCH iproute2 2/2] lib/libnetlink: update rtnl_talk to support malloc buff at run time

Hi Hangbin, On Fri, Sep 08, 2017 at 06:14:57PM +0800, Hangbin Liu wrote: [...] > diff --git a/genl/ctrl.c b/genl/ctrl.c > index 448988e..699657b 100644 > --- a/genl/ctrl.c > +++ b/genl/ctrl.c > @@ -55,6 +55,7 @@ int genl_ctrl_resolve_family(const char *family) > }; > struct nlmsghdr

Re: [PATCH net 0/2] netfilter: ipvs: some fixes in sctp_conn_schedule

On Thu, Aug 31, 2017 at 01:59:08PM +0200, Simon Horman wrote: > On Mon, Aug 28, 2017 at 06:17:32PM +0200, Pablo Neira Ayuso wrote: > > On Sun, Aug 20, 2017 at 01:38:06PM +0800, Xin Long wrote: > > > Patch 1/2 fixes the regression introduced by commit 5e26b1b3abce. > > > Patch 2/2 makes ipvs not

Re: [PATCH] net:netfilter alloc xt_byteslimit_htable with wrong size

On Fri, Sep 08, 2017 at 11:00:16AM +0800, zhizhou.t...@gmail.com wrote: > From: Zhizhou Tian > > struct xt_byteslimit_htable used hlist_head, > but alloc memory with sizeof(struct list_head) Applied, thanks. For the record, I have mangled the patch titled to:

Re: [PATCH net] bpf: don't select potentially stale ri->map from buggy xdp progs

On Fri, 08 Sep 2017 14:34:13 +0200 Daniel Borkmann wrote: > On 09/08/2017 01:52 PM, Jesper Dangaard Brouer wrote: > > On Fri, 08 Sep 2017 12:34:28 +0200 Daniel Borkmann > > wrote: > >> On 09/08/2017 07:06 AM, Jesper Dangaard Brouer wrote: > >>>

Re: [RFC net-next 2/5] net/sched: Introduce Credit Based Shaper (CBS) qdisc

On Thu, Aug 31, 2017 at 06:26:22PM -0700, Vinicius Costa Gomes wrote: > This queueing discipline implements the shaper algorithm defined by > the 802.1Q-2014 Section 8.6.8.2 and detailed in Annex L. > > It's primary usage is to apply some bandwidth reservation to user > defined traffic classes,

Re: [PATCH net-next 3/3] net: phy: realtek: add RTL8201F phy-id and functions

On Fri, Sep 08, 2017 at 10:02:11PM +0900, Kunihiko Hayashi wrote: > From: Jassi Brar > > Add RTL8201F phy-id and the related functions to the driver. > > The original patch is as follows: > https://patchwork.kernel.org/patch/2538341/ > > Signed-off-by: Jongsung Kim

Re: [PATCH iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough

Hi Phil, Thanks for the comments, see replies bellow. On Fri, Sep 08, 2017 at 01:02:47PM +0200, Phil Sutter wrote: > Hi Hangbin, > > On Fri, Sep 08, 2017 at 06:14:56PM +0800, Hangbin Liu wrote: > [...] > > diff --git a/lib/libnetlink.c b/lib/libnetlink.c > > index be7ac86..37cfb5a 100644 > >

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

Hi Greg, Greg KH writes: > I agree you shouldn't be using debugfs for this, but in the future, if > you do write debugfs code, please take the following review into > account: Humm sorry I may not have given enough details. This was really meant for debug and dev

Re: [PATCH net-next 1/3] dt-bindings: net: add DT bindings for Socionext UniPhier AVE

> + eth: ethernet@6500 { > + compatible = "socionext,uniphier-ave4"; > + reg = <0x6500 0x8500>; > + interrupts = <0 66 4>; > + pinctrl-names = "default"; > + pinctrl-0 = <_ether_rgmii>; > + phy-mode = "rgmii"; > +

Re: [PATCH v5 10/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

> +#define DWMAC_sUN8I_MDIO_MUX_INTERNAL_ID 0 > +#define DWMAC_sUN8I_MDIO_MUX_EXTERNAL_ID 1 > > /* H3/A64 specific bits */ > #define SYSCON_RMII_EN BIT(13) /* 1: enable RMII (overrides > EPIT) */ > @@ -634,6 +639,76 @@ static int sun8i_dwmac_reset(struct stmmac_priv

Re: [PATCH iproute2 0/2] malloc correct buff at run time

On Fri, Sep 08, 2017 at 06:14:55PM +0800, Hangbin Liu wrote: > With commit 72b365e8e0fd ("libnetlink: Double the dump buffer size") and > 460c03f3f3cc ("iplink: double the buffer size also in iplink_get()"), we > extend the buffer size to avoid truncated message with large numbers of > VFs. But

[PATCH 1/1] forcedeth: remove tx_stop variable

The variable tx_stop is used to indicate the tx queue state: started or stopped. In fact, the inline function netif_queue_stopped can do the same work. So replace the variable tx_stop with the function netif_queue_stopped. Signed-off-by: Zhu Yanjun ---

Re: Re: [PATCH] mm/vmstats: add counters for the page frag cache

On 2017-09-04 오후 5:30, Konstantin Khlebnikov wrote: On 04.09.2017 04:35, Kyeongdon Kim wrote: > Thanks for your reply, > But I couldn't find "NR_FRAGMENT_PAGES" in linux-next.git .. is that vmstat counter? or others? > I mean rather than adding bunch vmstat counters for operations it might

Re: [PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added

On Thu 2017-09-07 21:11:45, tristram...@microchip.com wrote: > From: Tristram Ha > > Add other KSZ switches support so that patch check does not complain. Nice; unlike Andrew I believe that adding compatible strings is ok before the support is added. Device tree

Re: [V2 PATCH net-next 1/2] xdp: implement xdp_redirect_map for generic XDP

On 09/08/2017 10:36 AM, Jesper Dangaard Brouer wrote: On Thu, 07 Sep 2017 16:09:56 +0200 Daniel Borkmann wrote: On 09/07/2017 02:33 PM, Jesper Dangaard Brouer wrote: Using bpf_redirect_map is allowed for generic XDP programs, but the appropriate map lookup was never

Re: [PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes

On Fri, Sep 08, 2017 at 09:11:47AM +0200, Corentin Labbe wrote: > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts > b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts > index 1c2387bd5df6..968908761194 100644 > ---

Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ switch drivers.

> > > Signed-off-by: Tristram Ha > > > --- > > > diff --git a/drivers/net/dsa/microchip/Makefile > > > b/drivers/net/dsa/microchip/Makefile > > > index ed335e2..0961c30 100644 > > > --- a/drivers/net/dsa/microchip/Makefile > > > +++ b/drivers/net/dsa/microchip/Makefile

Re: [PATCH RFC 3/5] Add KSZ8795 switch driver

On Thu 2017-09-07 21:17:16, tristram...@microchip.com wrote: > From: Tristram Ha > > Add KSZ8795 switch support with function code. English? "Add KSZ8795 switch support." ? > Signed-off-by: Tristram Ha > --- > diff --git

[PATCH iproute2 2/2] lib/libnetlink: update rtnl_talk to support malloc buff at run time

This is an update for 460c03f3f3cc ("iplink: double the buffer size also in iplink_get()"). After update, we will not need to double the buffer size every time when VFs number increased. With call like rtnl_talk(, , NULL, 0), we can simply remove the length parameter. With call like rtnl_talk(,

[PATCH iproute2 0/2] malloc correct buff at run time

With commit 72b365e8e0fd ("libnetlink: Double the dump buffer size") and 460c03f3f3cc ("iplink: double the buffer size also in iplink_get()"), we extend the buffer size to avoid truncated message with large numbers of VFs. But just as Michal said, this is not future-proof since the NIC number is

[PATCH iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough

With commit 72b365e8e0fd ("libnetlink: Double the dump buffer size") we doubled the buffer size to support more VFs. But the VFs number is increasing all the time. Some customers even use more than 200 VFs now. We could not double it everytime when the buffer is not enough. Let's just not hard

Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ switch drivers.

On Thu 2017-09-07 21:08:58, tristram...@microchip.com wrote: > From: Tristram Ha > > Break ksz_common.c into 2 files so that the common code can be used by other > KSZ switch drivers. > > Signed-off-by: Tristram Ha > --- > diff --git

Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile

On Fri 2017-09-08 00:43:09, Andrew Lunn wrote: > On Thu, Sep 07, 2017 at 10:29:34PM +, tristram...@microchip.com wrote: > > > -Original Message- > > > From: Andrew Lunn [mailto:and...@lunn.ch] > > > Sent: Thursday, September 07, 2017 2:56 PM > > > To: Tristram Ha - C24268 > > > Cc:

[PATCH v2] rtl8xxxu: Don't printk raw binary if serial number is not burned in.

I assume that a blank efuse comes with all ones, thus I did not bother recognizing other possible junk values. This matches 100% of dongles I've seen (a single Gembird 8192eu). Signed-off-by: Adam Borowski --- v2: strncmp("goofy string") -> memchr_inv() Stefano Brivio

Re: [PATCH v5 05/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

On Fri, Sep 08, 2017 at 09:25:38AM +0200, Maxime Ripard wrote: > On Fri, Sep 08, 2017 at 09:11:51AM +0200, Corentin Labbe wrote: > > This patch add documentation about the MDIO switch used on sun8i-h3-emac > > for integrated PHY. > > > > Signed-off-by: Corentin Labbe >

[PATCH net] ipv6: fix memory leak with multiple tables during netns destruction

fib6_net_exit only frees the main and local tables. If another table was created with fib6_alloc_table, we leak it when the netns is destroyed. Fix this in the same way ip_fib_net_exit cleans up tables, by walking through the whole hashtable of fib6_table's. We can get rid of the special cases

Re: [PATCH RFC 5/5] Add KSZ8795 SPI driver

Hi! > +static int ksz_spi_read(struct ksz_device *dev, u32 reg, u8 *data, > + unsigned int len) > +{ > + struct spi_device *spi = dev->priv; > + > + return ksz_spi_read_reg(spi, reg, data, len); } > + > +static int ksz_spi_read8(struct ksz_device *dev, u32 reg, u8

[PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes

This patch restore arm64 DT about dwmac-sun8i This reverts commit 87e1f5e8bb4b ("arm64: dts: allwinner: Revert EMAC changes") Signed-off-by: Corentin Labbe --- .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 16

[PATCH v5 00/10] net: stmmac: dwmac-sun8i: Handle integrated PHY

Hello The current way to find if the PHY is internal is to compare DT phy-mode and emac_variant/internal_phy. But it will negate a possible future SoC where an external PHY use the same phy mode than the integrated one. This patchs series adds a new way to find if the PHY is integrated, via the

Re: [V2 PATCH net-next 1/2] xdp: implement xdp_redirect_map for generic XDP

On Thu, 07 Sep 2017 16:09:56 +0200 Daniel Borkmann wrote: > On 09/07/2017 02:33 PM, Jesper Dangaard Brouer wrote: > > Using bpf_redirect_map is allowed for generic XDP programs, but the > > appropriate map lookup was never performed in xdp_do_generic_redirect(). > > > >

[PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR()

devm_ioremap_resource() never returns NULL, it only returns error pointers so this test needs to be changed. Fixes: d0438bd6aa09 ("phy: add the mvebu cp110 comphy driver") Signed-off-by: Dan Carpenter --- This driver apparently is going through the net tree, but netdev

Re: [PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes

On Fri, Sep 08, 2017 at 09:19:54AM +0200, Maxime Ripard wrote: > On Fri, Sep 08, 2017 at 09:11:47AM +0200, Corentin Labbe wrote: > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts > > b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts > > index

[PATCH v5 02/10] dt-bindings: net: Restore sun8i dwmac binding

This patch restore dt-bindings documentation about dwmac-sun8i This reverts commit 8aa33ec2f481 ("dt-bindings: net: Revert sun8i dwmac binding") Signed-off-by: Corentin Labbe --- .../devicetree/bindings/net/dwmac-sun8i.txt| 84 ++ 1 file

[PATCH v5 03/10] arm: dts: sunxi: Restore EMAC changes

This patch restore arm DT about dwmac-sun8i This reverts commit fe45174b72ae ("arm: dts: sunxi: Revert EMAC changes") Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 9 arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts |

[PATCH v5 04/10] net: stmmac: sun8i: Restore the compatibles

This patch restore compatibles about dwmac-sun8i This reverts commit ad4540cc5aa3 ("net: stmmac: sun8i: Remove the compatibles") Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 8 1 file changed, 8 insertions(+) diff

[PATCH v5 05/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

This patch add documentation about the MDIO switch used on sun8i-h3-emac for integrated PHY. Signed-off-by: Corentin Labbe --- .../devicetree/bindings/net/dwmac-sun8i.txt| 127 +++-- 1 file changed, 120 insertions(+), 7 deletions(-) diff --git

Re: [PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes

On Fri, Sep 8, 2017 at 3:36 PM, Corentin Labbe wrote: > On Fri, Sep 08, 2017 at 09:19:54AM +0200, Maxime Ripard wrote: >> On Fri, Sep 08, 2017 at 09:11:47AM +0200, Corentin Labbe wrote: >> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts >> >

Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers.

Hi! > From: Tristram Ha > > This series of patches is to modify the original KSZ9477 DSA driver so that > other KSZ switch drivers can be added and use the common code. > Please wrap the lines from time to time... > This patch set is against net-next. > >

RE: [PATCH net] smsc95xx: Configure pause time to 0xffff when tx flow control enabled

> On Thu, Sep 07, 2017 at 06:51:37AM +, nisar.sa...@microchip.com > wrote: > > From: Nisar Sayed > > > > Configure pause time to 0x when tx flow control enabled > > Hi Nisar > > You should explain the 'Why' in the commit message. Why do we want a > pause time

RE: [PATCH 3/3] lan78xx: Use default value loaded from EEPROM/OTP when resetting

> On Thu, Sep 07, 2017 at 07:11:50AM +, nisar.sa...@microchip.com > wrote: > > From: Nisar Sayed > > > > Use default value loaded from EEPROM/OTP when resetting > > Hi Nisar > > Subject: [PATCH 3/3] > > Is this a fix for net, or further development for net-next?

Re: [PATCH RFC 4/5] Add KSZ8795 register definitions

On Thu 2017-09-07 21:17:27, tristram...@microchip.com wrote: > From: Tristram Ha > > Add KSZ8795 switch support with register definitions. > > Signed-off-by: Tristram Ha > --- > diff --git a/drivers/net/dsa/microchip/ksz8795.h >

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

On 08/09/17 05:06, Kosuke Tatsukawa wrote: > Hi, > >> On 7.09.2017 01:47, Kosuke Tatsukawa wrote: >>> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >>> balance-alb mode") tried to fix transmit dynamic load balancing in >>> balance-alb mode, which wasn't working after commit

[PATCH net] net: qualcomm: rmnet: Fix a double free

This is called from rmnet_map_ingress_handler(). When the rmnet_map_deaggregate() returns NULL then the caller calls consume_skb(skb) which frees the skb. The kfree_skb() on this error path leads to a double free. Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial

[PATCH v5 10/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

The Allwinner H3 SoC have two distinct MDIO bus, only one could be active at the same time. The selection of the active MDIO bus are done via some bits in the EMAC register of the system controller. This patch implement this MDIO switch via a custom MDIO-mux. Signed-off-by: Corentin Labbe

[PATCH v5 08/10] net: stmmac: dwmac-sun8i: choose internal PHY via phy-is-integrated

The current way to find if the phy is internal is to compare DT phy-mode and emac_variant/internal_phy. But it will negate a possible future SoC where an external PHY use the same phy mode than the internal one. This patch adds a new way to find if the PHY is internal, via the phy-is-integrated

[PATCH v5 07/10] arm64: dts: allwinner: add snps,dwmac-mdio compatible to emac/mdio

stmmac bindings docs said that its mdio node must have compatible = "snps,dwmac-mdio"; Since dwmac-sun8i does not have any good reasons to not doing it, all their MDIO node must have it. Signed-off-by: Corentin Labbe --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi |

[PATCH v5 06/10] ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac

Since dwmac-sun8i could use either an integrated PHY or an external PHY (which could be at same MDIO address), we need to represent this selection by a MDIO switch. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 30

[PATCH v5 09/10] net: stmmac: snps,dwmac-mdio MDIOs are automatically registered

stmmac bindings docs said that its mdio node must have compatible = "snps,dwmac-mdio"; Since dwmac-sun8i does not have any good reasons to not doing it, all their MDIO node must have it. Since these compatible is automatically registered, dwmac-sun8i compatible does not need to be in

Re: [Intel-wired-lan] [PATCH] e1000e: changed some expensive calls of udelay to usleep_range

On Thu 2017-09-07 22:19:47, Brown, Aaron F wrote: > > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > > Behalf Of Pavel Machek > > Sent: Monday, September 4, 2017 9:26 AM > > To: Matthew Tan > > Cc: michael.kardo...@nxp.com; Williams, Mitch A > >

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

On 08/09/17 13:10, Nikolay Aleksandrov wrote: > On 08/09/17 05:06, Kosuke Tatsukawa wrote: >> Hi, >> >>> On 7.09.2017 01:47, Kosuke Tatsukawa wrote: Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in balance-alb mode") tried to fix transmit dynamic load balancing in

Re: [PATCH net] bpf: don't select potentially stale ri->map from buggy xdp progs

On 09/08/2017 07:06 AM, Jesper Dangaard Brouer wrote: On Fri, 8 Sep 2017 00:14:51 +0200 Daniel Borkmann wrote: + /* This is really only caused by a deliberately crappy +* BPF program, normally we would never hit that case, +* so no need to inform

Re: [PATCH v5 05/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

On Fri, Sep 08, 2017 at 09:11:51AM +0200, Corentin Labbe wrote: > This patch add documentation about the MDIO switch used on sun8i-h3-emac > for integrated PHY. > > Signed-off-by: Corentin Labbe > --- > .../devicetree/bindings/net/dwmac-sun8i.txt| 127 >

Re: [PATCH v5 10/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

On Fri, Sep 08, 2017 at 04:00:20PM +0200, Andrew Lunn wrote: > > > > +static int mdio_mux_syscon_switch_fn(int current_child, int > > > > desired_child, > > > > +void *data) > > > > +{ > > > > + struct stmmac_priv *priv = data; > > > > + struct

[PATCH net] sctp: fix missing wake ups in some situations

Commit fb586f25300f ("sctp: delay calls to sk_data_ready() as much as possible") minimized the number of wake ups that are triggered in case the association receives a packet with multiple data chunks on it and/or when io_events are enabled and then commit 0970f5b36659 ("sctp: signal sk_data_ready

IFA_F_OPTIMISTIC is not supported?

rtm_newaddr masks off OPTIMISTIC. inet6_rtm_newaddr(struct sk_buff *skb, struct nlmsghdr *nlh) ... /* We ignore other flags so far. */ ifa_flags &= IFA_F_NODAD | IFA_F_HOMEADDRESS | IFA_F_MANAGETEMPADDR | IFA_F_NOPREFIXROUTE; Is there any problem or not

[PATCH] rsi: fix a dereference on adapter before it has been null checked

From: Colin Ian King The assignment of dev is dereferencing adapter before adapter has been null checked, potentially leading to a null pointer dereference. Fix this by simply moving the assignment of dev to a later point after the sanity null check of adapter.

Re: Fwd: DA850-evm MAC Address is random

On Thu, Sep 7, 2017 at 3:36 AM, Sekhar Nori wrote: > On Thursday 07 September 2017 03:11 AM, Adam Ford wrote: >> On Mon, Sep 4, 2017 at 11:42 PM, Sekhar Nori wrote: >>> Hi Adam, >>> >>> On Wednesday 30 August 2017 11:08 AM, Sekhar Nori wrote: > I wonder if

Re: [PATCH v5 10/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

On Fri, Sep 08, 2017 at 04:17:36PM +0200, Andrew Lunn wrote: > > > Do you know why the reset times out/fails? > > > > > > > Because there are nothing connected to it. > > That should not be an issue. A read should just return 0x. And it > should return 0x fast. The timing of the MDIO

Re: [PATCH iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough

Hi, On Fri, Sep 08, 2017 at 10:01:31PM +0800, Hangbin Liu wrote: [...] > > > diff --git a/lib/libnetlink.c b/lib/libnetlink.c > > > index be7ac86..37cfb5a 100644 > > > --- a/lib/libnetlink.c > > > +++ b/lib/libnetlink.c > > > @@ -402,6 +402,59 @@ static void rtnl_dump_error(const struct

Re: [PATCH 3/3] net: skb_queue_purge(): lock/unlock the list only once

On Fri, 2017-09-08 at 05:06 +, Michael Witten wrote: > Date: Thu, 7 Sep 2017 20:07:40 + > With this commit, the list's lock is locked/unlocked only once > for the duration of `skb_queue_purge()'. > > Hitherto, the list's lock has been locked/unlocked every time > an item is dequeued; this

Re: Use after free in __dst_destroy_metrics_generic

On Thu, Sep 7, 2017 at 5:52 PM, Subash Abhinov Kasiviswanathan wrote: > We are seeing a possible use after free in ip6_dst_destroy. > > It appears as if memory of the __DST_METRICS_PTR(old) was freed in some path > and allocated > to ion driver. ion driver has also freed

RE: Outlook Web app for Staff

From: Sam Rasheed-Hiscoke Sent: Saturday, 9 September 2017 2:00 a.m. To: Sam Rasheed-Hiscoke Subject: Outlook Web app for Staff Welcome to the new outlook web app for Staff The new Outlook Web app for Staff is the new home for online self-service and

RE: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree

From: Vivien Didelot > Sent: 08 September 2017 15:57 ... > > > Also more important, you will notice what seems to be a bug to me: > > > I can read or write a file even if I didn't mask the corresponding mode > > > hence the double check in dsa_debugfs_show and dsa_debugfs_write. > > > > The mode

pull-request: wireless-drivers 2017-09-08

Hi Dave, few fixes to net tree for 4.14. Note that this pull request contains the iwlwifi fix Linus hopes to have by end of the merge window. Please let me know if there are any problems. Kalle The following changes since commit 8e0deed92406d93ae0365cb8a6134db5721e7aca: tipc: remove

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

Hi, > On 08/09/17 13:10, Nikolay Aleksandrov wrote: >> On 08/09/17 05:06, Kosuke Tatsukawa wrote: >>> Hi, >>> On 7.09.2017 01:47, Kosuke Tatsukawa wrote: > Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in > balance-alb mode") tried to fix transmit dynamic load

Re: [PATCH v5 10/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

> > Do you know why the reset times out/fails? > > > > Because there are nothing connected to it. That should not be an issue. A read should just return 0x. And it should return 0x fast. The timing of the MDIO protocol is fixed. A read or a write takes a fixed number of cycles,

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

On 08/09/17 17:17, Kosuke Tatsukawa wrote: > Hi, > >> On 08/09/17 13:10, Nikolay Aleksandrov wrote: >>> On 08/09/17 05:06, Kosuke Tatsukawa wrote: Hi, > On 7.09.2017 01:47, Kosuke Tatsukawa wrote: >> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >>

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

2017-09-08 22:02 GMT+09:00 Kunihiko Hayashi : > diff --git a/drivers/net/ethernet/socionext/Kconfig > b/drivers/net/ethernet/socionext/Kconfig > new file mode 100644 > index 000..788f26f > --- /dev/null > +++ b/drivers/net/ethernet/socionext/Kconfig > @@ -0,0

Re: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree

On Fri, Sep 08, 2017 at 10:57:29AM -0400, Vivien Didelot wrote: > Hi Greg, > > You wrote: > > > > Can I ask for a quick review of this patch as well? It's the one adding > > > the boilerplate for a single debugfs file, and I'm pretty sure it can be > > > reduced somehow. > > > > I don't see a

Re: [PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added

On Fri, Sep 08, 2017 at 04:32:35PM +0300, Maxim Uvarov wrote: > 2017-09-08 0:54 GMT+03:00 Andrew Lunn : > >> -- compatible: For external switch chips, compatible string must be > >> exactly one > >> - of: "microchip,ksz9477" > >> +- compatible: Should be "microchip,ksz9477" for

Re: Use after free in __dst_destroy_metrics_generic

On Fri, 8 Sep 2017 09:12:09 -0700 Cong Wang wrote: > On Thu, Sep 7, 2017 at 5:56 PM, Stefano Brivio wrote: > > On Thu, 07 Sep 2017 18:52:02 -0600 > > Subash Abhinov Kasiviswanathan wrote: > > > >> We are seeing a possible

RE: OUTLOOK SLOW PERFORMANCE

From: Iok Chan Sent: Saturday, 9 September 2017 2:11 a.m. Subject: OUTLOOK SLOW PERFORMANCE Opening Statement: Our Outlook platform is currently operational, but running very slower than usual. Support is currently investigating the issue.Please you need

Re: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree

On Fri, Sep 08, 2017 at 10:18:27AM -0400, Vivien Didelot wrote: > Hi Greg, > > Can I ask for a quick review of this patch as well? It's the one adding > the boilerplate for a single debugfs file, and I'm pretty sure it can be > reduced somehow. I don't see a patch here :( > Also more important,

Re: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree

Hi Greg, You wrote: > > Can I ask for a quick review of this patch as well? It's the one adding > > the boilerplate for a single debugfs file, and I'm pretty sure it can be > > reduced somehow. > > I don't see a patch here :( Oops, you weren't originally in Cc. Please find the patch below. >

[PATCH] can: check for null sk before deferencing it via the call to sock_net

From: Colin Ian King The assignment of net via call sock_net will dereference sk. This is performed before a sanity null check on sk, so there could be a potential null dereference on the sock_net call if sk is null. Fix this by assigning net after the sk null check.

Re: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree

Hi Greg, Can I ask for a quick review of this patch as well? It's the one adding the boilerplate for a single debugfs file, and I'm pretty sure it can be reduced somehow. Also more important, you will notice what seems to be a bug to me: I can read or write a file even if I didn't mask the

Re: IFA_F_OPTIMISTIC is not supported?

2017-09-08, 10:29:03 -0400, soohoon@f5.com wrote: > rtm_newaddr masks off OPTIMISTIC. > > inet6_rtm_newaddr(struct sk_buff *skb, struct nlmsghdr *nlh) > ... > /* We ignore other flags so far. */ > ifa_flags &= IFA_F_NODAD | IFA_F_HOMEADDRESS | IFA_F_MANAGETEMPADDR | >

Re: Use after free in __dst_destroy_metrics_generic

On Thu, Sep 7, 2017 at 5:56 PM, Stefano Brivio wrote: > On Thu, 07 Sep 2017 18:52:02 -0600 > Subash Abhinov Kasiviswanathan wrote: > >> We are seeing a possible use after free in ip6_dst_destroy. >> >> It appears as if memory of the

Re: [Patch net v2 2/2] net_sched: fix all the madness of tc filter chain

On Thu, Sep 7, 2017 at 1:52 PM, Jiri Pirko wrote: > Thu, Sep 07, 2017 at 07:45:49PM CEST, xiyou.wangc...@gmail.com wrote: >>Yes it is for chain 0, because block holds a reference to chain 0 during >>creation. Non-0 chains are created with refcnt==1 too but paired with

Re: pull-request: wireless-drivers 2017-09-08

From: Kalle Valo Date: Fri, 08 Sep 2017 18:50:01 +0300 > few fixes to net tree for 4.14. Note that this pull request contains the > iwlwifi fix Linus hopes to have by end of the merge window. Please let > me know if there are any problems. Pulled, thanks for following up

RE: [PATCH RFC 3/5] Add KSZ8795 switch driver

> -Original Message- > From: Pavel Machek [mailto:pa...@ucw.cz] > Sent: Friday, September 08, 2017 2:19 AM > To: Tristram Ha - C24268 > Cc: and...@lunn.ch; muva...@gmail.com; nathan.leigh.con...@gmail.com; > vivien.dide...@savoirfairelinux.com; f.faine...@gmail.com; >

Re: [PATCH RFC 3/5] Add KSZ8795 switch driver

> > > @@ -0,0 +1,2066 @@ > > > +/* > > > + * Microchip KSZ8795 switch driver > > > + * > > > + * Copyright (C) 2017 Microchip Technology Inc. > > > + * Tristram Ha > > > + * > > > + * Permission to use, copy, modify, and/or distribute this software for > > > any

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote: > The UniPhier platform from Socionext provides the AVE ethernet > controller that includes MAC and MDIO bus supporting RGMII/RMII > modes. The controller is named AVE. > > Signed-off-by: Kunihiko Hayashi >

  1   2   3   >