Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

Another test for this patch with linux-next tree with patch:  bwm-ng v0.6.1 (probing every 1.000s), press 'h' for help   input: /proc/net/dev type: rate   - iface   Rx Tx    Total ==  

[Patch net v3 3/3] net_sched: carefully handle tcf_block_put()

As pointed out by Jiri, there is still a race condition between tcf_block_put() and tcf_chain_destroy() in a RCU callback. There is no way to make it correct without proper locking or synchronization, because both operate on a shared list. Locking is hard, because the only lock we can pick here

[Patch net v3 2/3] net_sched: fix reference counting of tc filter chain

This patch fixes the following ugliness of tc filter chain refcnt: a) tp proto should hold a refcnt to the chain too. This significantly simplifies the logic. b) Chain 0 is no longer special, it is created with refcnt=1 like any other chains. All the ugliness in tcf_chain_put() can be

[Patch net v3 0/3] net_sched: fix filter chain reference counting

This patchset fixes tc filter chain reference counting and nasty race conditions with RCU callbacks. Please see each patch for details. --- v3: Rebase on the latest -net Add code comment in patch 1 Improve comment and changelog for patch 2 Add patch 3 v2: Add patch 1 Get rid of

[Patch net v3 1/3] net_sched: get rid of tcfa_rcu

gen estimator has been rewritten in commit 1c0d32fde5bd ("net_sched: gen_estimator: complete rewrite of rate estimators"), the caller is no longer needed to wait for a grace period. So this patch gets rid of it. This also completely closes a race condition between action free path and filter

[net-next] dummy: declare dummy devices as enumerated devices

Dummy device name is enumerated by the kernel, let user space be aware of the naming scheme used by dummy devices: (visible in /sys/class/net//name_assign_type). Signed-off-by: Zhang Shengju --- drivers/net/dummy.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: broken vlan support on Realtek RTL8111/8168/8411 rev 9

Benoit Panizzon : [...] > It's not marked as fixed but: > > when I try to turn offloading off I get: > > # /sbin/ethtool -K eth0 rx-vlan-offload off > ethtool: bad command line argument(s) > For more information run ethtool -h > > Could anyone give me a hint how to

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

On Mon, Sep 11, 2017 at 3:07 PM, Tom Herbert wrote: > On Mon, Sep 11, 2017 at 9:49 AM, Samudrala, Sridhar > wrote: >> On 9/10/2017 8:19 AM, Tom Herbert wrote: >>> >>> On Thu, Aug 31, 2017 at 4:27 PM, Sridhar Samudrala >>>

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

On Thu, Aug 31, 2017 at 4:27 PM, Sridhar Samudrala wrote: > This patch introduces a new socket option SO_SYMMETRIC_QUEUES that can be used > to enable symmetric tx and rx queues on a socket. > > This option is specifically useful for epoll based multi threaded

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

On Mon, 2017-09-11 at 20:12 -0700, Tom Herbert wrote: > Two ints in sock_common for this purpose is quite expensive and the > use case for this is limited-- even if a RX->TX queue mapping were > introduced to eliminate the queue pair assumption this still won't > help if the receive and transmit

RE: [PATCH] e1000e: changed some expensive calls of udelay to usleep_range

> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Kardonik Michael > Sent: Tuesday, September 5, 2017 1:27 PM > To: leoyang...@nxp.com; michael.kardo...@nxp.com; Kirsher, Jeffrey T > ; Brandeburg, Jesse >

RE: [PATCH] mwifiex: remove unnecessary call to memset

Hi Himanshu, > -Original Message- > From: Himanshu Jha [mailto:himanshujha199...@gmail.com] > Sent: 2017年9月11日 20:46 > To: amitkar...@gmail.com > Cc: Nishant Sarmukadam ; Ganapathi Bhat > ; Xinming Hu ; > kv...@codeaurora.org;

Subject: [PATCH] vxlan: only reduce known arp boardcast request to support, virtual IP

The purpose of vxlan arp reduce feature is to reply the boardcast arp request in vtep instead of sending it out to save traffic. The current implemention drops arp packet, if the ip cannot be found in neigh table. In the case of virtual IP address, user defines IP address without management from

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

On Thu, Sep 07, 2017 at 06:29:00PM -0700, Vinicius Costa Gomes wrote: > >> * Time-aware shaper (802.1Qbv): > >> > >>The idea we are currently exploring is to add a "time-aware", priority > >> based > >>qdisc, that also exposes the Tx queues available and provides a > >> mechanism for >

Re: [PATCH v2] openvswitch: Fix an error handling path in 'ovs_nla_init_match_and_action()'

On Mon, Sep 11, 2017 at 12:56 PM, Christophe JAILLET wrote: > All other error handling paths in this function go through the 'error' > label. This one should do the same. > > Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") > Signed-off-by:

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

On Mon, Sep 11, 2017 at 9:49 AM, Samudrala, Sridhar wrote: > On 9/10/2017 8:19 AM, Tom Herbert wrote: >> >> On Thu, Aug 31, 2017 at 4:27 PM, Sridhar Samudrala >> wrote: >>> >>> This patch introduces a new socket option SO_SYMMETRIC_QUEUES

RE: Extended IDR API

This improvement is good. But I have a concern that the parameters of idr_alloc and idr_alloc_ul are different. I mean in idr_alloc, we have start and end. In our new API, we keep them. So our design goal is to make them consistent. Your new API has its advantage surely. If you want to change

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

Hi Andrew, Thank you for your comments. On Fri, 8 Sep 2017 15:50:30 +0200 wrote: > > +static int ave_mdio_busywait(struct net_device *ndev) > > +{ > > + int ret = 1, loop = 100; > > + u32 mdiosr; > > + > > + /* wait until completion */ > > + while (1) { > > +

Re: [RFC net-next v2] bridge lwtunnel, VPLS & NVGRE

Hi David, Do you plan to send a v3? On 21/08/2017 18:15, David Lamparter wrote: Hi all, this is an update on the earlier "[RFC net-next] VPLS support". Note I've changed the subject lines on some of the patches to better reflect what they really do (tbh the earlier subject lines were crap.)

Hello Friend

I NEED YOUR ASSISTANCE INTO THIS TRANSACTION

Re: [patch net] mlxsw: spectrum: Fix EEPROM access in case of SFP/SFP+

On Mon, Sep 11, 2017 at 09:42:26AM +0200, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > The current code does not handle correctly the access to the upper page > in case of SFP/SFP+ EEPROM. In that case the offset should be local > and the I2C address should be changed.

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

> > > +static irqreturn_t ave_interrupt(int irq, void *netdev) > > > +{ > > > + struct net_device *ndev = (struct net_device *)netdev; > > > + struct ave_private *priv = netdev_priv(ndev); > > > + u32 gimr_val, gisr_val; > > > + > > > + gimr_val = ave_irq_disable_all(ndev); > > > + > > > + /* get

[PATCH v1 net] smsc95xx: Configure pause time to 0xffff when tx flow control enabled

From: Nisar Sayed Configure pause time to 0x when tx flow control enabled Set pause time to 0x in the pause frame to indicate the partner to stop sending the packets. When RX buffer frees up, the device sends pause frame with pause time zero for partner to

Re: [PATCH net-next 09/11] bnxt_en: bnxt: add TC flower filter offload support

Mon, Aug 28, 2017 at 07:40:33PM CEST, michael.c...@broadcom.com wrote: >From: Sathya Perla > >This patch adds support for offloading TC based flow >rules and actions for the 'flower' classifier in the bnxt_en driver. >It includes logic to parse flow rules and actions

[PATCH net] MAINTAINERS: Remove Yuval Mintz from maintainers list

From: Ariel Elior Remove Yuval from maintaining the bnx2x & qed* modules as he is no longer working for the company. Thanks Yuval for your huge contributions and tireless efforts over the many years and various companies. Ariel --- MAINTAINERS | 2 -- 1 file changed, 2

[PATCH] tipc: Use bsearch library function

Use common library function rather than explicitly coding some variant of it yourself. Signed-off-by: Thomas Meyer --- net/tipc/name_table.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/net/tipc/name_table.c

[PATCH] mwifiex: remove unnecessary call to memset

call to memset to assign 0 value immediately after allocating memory with kzalloc is unnecesaary as kzalloc allocates the memory filled with 0 value. Semantic patch used to resolve this issue: @@ expression e,e2; constant c; statement S; @@ e = kzalloc(e2, c); if(e == NULL) S - memset(e, 0,

Re: [PATCH v1 net] smsc95xx: Configure pause time to 0xffff when tx flow control enabled

On Mon, Sep 11, 2017 at 12:32:10PM +, nisar.sa...@microchip.com wrote: > From: Nisar Sayed > > Configure pause time to 0x when tx flow control enabled > > Set pause time to 0x in the pause frame to indicate the > partner to stop sending the packets. When

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

Hi Yamada-san, Thank you for your comments, On Fri, 8 Sep 2017 23:44:13 +0900 wrote: > 2017-09-08 22:02 GMT+09:00 Kunihiko Hayashi : > > > diff --git a/drivers/net/ethernet/socionext/Kconfig > >

Re: [PATCH iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough

Hi Phil and Michal, On Fri, Sep 08, 2017 at 04:51:13PM +0200, Phil Sutter wrote: > Hi, > > On Fri, Sep 08, 2017 at 10:01:31PM +0800, Hangbin Liu wrote: > [...] > > Since we have to use two static bufffers. So how about check like > > > > if (len > strlen(buffer)) > > I don't think that will

Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR()

Hi, On Saturday 09 September 2017 09:39 AM, David Miller wrote: > From: Dan Carpenter > Date: Fri, 8 Sep 2017 13:31:37 +0300 > >> devm_ioremap_resource() never returns NULL, it only returns error >> pointers so this test needs to be changed. >> >> Fixes: d0438bd6aa09

Re: [PATCH net-next 3/3] net: phy: realtek: add RTL8201F phy-id and functions

Hi Andrew, Thank your for reviewing. On Sat, 9 Sep 2017 17:55:17 +0200 wrote: > On Sat, Sep 09, 2017 at 09:03:05AM +0530, Jassi Brar wrote: > > On 9 September 2017 at 00:21, Florian Fainelli wrote: > > > On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote: > >

Re: [PATCH net-next 1/3] dt-bindings: net: add DT bindings for Socionext UniPhier AVE

Hi Andrew, On Fri, 8 Sep 2017 16:03:22 +0200 wrote: > > + eth: ethernet@6500 { > > + compatible = "socionext,uniphier-ave4"; > > + reg = <0x6500 0x8500>; > > + interrupts = <0 66 4>; > > + pinctrl-names = "default"; > > +

Re: [PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added

2017-09-08 22:48 GMT+03:00 : >> -Original Message- >> From: Maxim Uvarov [mailto:muva...@gmail.com] >> Sent: Friday, September 08, 2017 12:00 PM >> To: Florian Fainelli >> Cc: Tristram Ha - C24268; Andrew Lunn; Pavel Machek; Nathan Conrad; Vivien >> Didelot;

Re: [PATCH] tcp: TCP_USER_TIMEOUT can not work in tcp_probe_timer()

On Mon, 2017-09-11 at 08:13 -0700, Eric Dumazet wrote: > You can see we got only 3 probes, not 4. Here is complete packetdrill test showing that code behaves as expected. 0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3 +0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0 +0 bind(3, ...,

Re: [PATCH] tcp: TCP_USER_TIMEOUT can not work in tcp_probe_timer()

On Mon, 2017-09-11 at 07:49 -0700, Eric Dumazet wrote: > On Mon, 2017-09-11 at 14:27 +0800, liujia...@huawei.com wrote: > > From: liujian > > > > After the tcp socket go to ESTABLISHED stat, change IP address (server > > side), > > then the tcp socket will go

Re: WARNING in skb_warn_bad_offload

On Mon, Sep 11, 2017 at 12:20:32PM +0800, Dison River wrote: > I found a warning while fuzzing with Syzkaller on linux 4.13-rc6 on > x86_64. The full stack trace is below: > > [ cut here ] > WARNING: CPU: 3 PID: 32413 at net/core/dev.c:2592 >

Re: [PATCH] tcp: TCP_USER_TIMEOUT can not work in tcp_probe_timer()

On Mon, 2017-09-11 at 14:27 +0800, liujia...@huawei.com wrote: > From: liujian > > After the tcp socket go to ESTABLISHED stat, change IP address (server > side), > then the tcp socket will go tcp_probe_timer process. > > [root@localhost net]# netstat -toe > Active

[PATCH] tcp: TCP_USER_TIMEOUT can not work in tcp_probe_timer()

From: liujian After the tcp socket go to ESTABLISHED stat, change IP address (server side), then the tcp socket will go tcp_probe_timer process. [root@localhost net]# netstat -toe Active Internet connections (w/o servers) Proto Recv-Q Send-Q Local Address Foreign

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

Hi Florian, Thank you for your comments, On Fri, 8 Sep 2017 12:31:18 -0700 wrote: > On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote: > > The UniPhier platform from Socionext provides the AVE ethernet > > controller that includes MAC and MDIO bus supporting RGMII/RMII > >

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

Hi Florian, On Sat, 9 Sep 2017 09:30:58 -0700 wrote: > > > On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote: > > The UniPhier platform from Socionext provides the AVE ethernet > > controller that includes MAC and MDIO bus supporting RGMII/RMII > > modes. The controller is

Re: [PATCH net-next 1/3] dt-bindings: net: add DT bindings for Socionext UniPhier AVE

Hi Florian, On Fri, 8 Sep 2017 11:54:31 -0700 wrote: > On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote: > > DT bindings for the AVE ethernet controller found on Socionext's > > UniPhier platforms. > > > > Signed-off-by: Kunihiko Hayashi > >

[patch net] mlxsw: spectrum: Fix EEPROM access in case of SFP/SFP+

From: Arkadi Sharshevsky The current code does not handle correctly the access to the upper page in case of SFP/SFP+ EEPROM. In that case the offset should be local and the I2C address should be changed. Fixes: 2ea109039cd3 ("mlxsw: spectrum: Add support for access cable

[PATCH v2 net 2/3] lan78xx: Allow EEPROM write for less than MAX_EEPROM_SIZE

From: Nisar Sayed Allow EEPROM write for less than MAX_EEPROM_SIZE Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Nisar Sayed --- drivers/net/usb/lan78xx.c | 4 ++-- 1 file

[PATCH v2 net 1/3] lan78xx: Fix for eeprom read/write when device auto suspend

From: Nisar Sayed Fix for eeprom read/write when device auto suspend Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Nisar Sayed --- drivers/net/usb/lan78xx.c | 22

[PATCH v2 net 3/3] lan78xx: Use default value loaded from EEPROM/OTP when resetting

From: Nisar Sayed Use default value loaded from EEPROM/OTP when resetting The LAN78xx allows platform configurations to be loaded from EEPROM/OTP. Ex: When external phy is connected, the MAC can be configured to have speed, duplex, polarity configurations loadded from

[PATCH] datapath: Fix an error handling path in 'ovs_nla_init_match_and_action()'

All other error handling paths in this function go through the 'error' label. This one should do the same. Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") Signed-off-by: Christophe JAILLET --- I think that the comment above the function could

[PATCH v2 net 0/3] lan78xx: Fixes to lan78xx driver

From: Nisar Sayed This series of patches are for lan78xx driver. These patches fixes potential issues associated with lan78xx driver v2 - Added patch version information - Added fixes tag - Updated patch description - Updated changes as per comments v1 - Spitted

Re: [PATCH v5 10/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

On Mon, Sep 11, 2017 at 06:11:24PM +0200, Andrew Lunn wrote: > On Fri, Sep 08, 2017 at 04:28:25PM +0200, Corentin Labbe wrote: > > On Fri, Sep 08, 2017 at 04:17:36PM +0200, Andrew Lunn wrote: > > > > > Do you know why the reset times out/fails? > > > > > > > > > > > > > Because there are nothing

Re: [PATCH] datapath: Fix an error handling path in 'ovs_nla_init_match_and_action()'

Please use a proper Subject subsystem prefix for openvswitch patches. "datapath" isn't very specific in the global kernel namespace at all. The entire networking stack packet processing path is a "datapath" "openvswitch: " would have been much better.

Re: [PATCH] netfilter: ipset: ipset list may return wrong member count for set with timeout

Hi, Your patch is applied in the ipset git tree and I'm going to push it for kernel inclusion. I modified the comment part: the elements counter can still be incorrect in the case of a huge set, because elements might time out during the listing. Thanks for your patience! Best regards,

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

On 11 September 2017 19:07:33 EEST, "Mahesh Bandewar (महेश बंडेवार)" wrote: >On Sat, Sep 9, 2017 at 4:28 AM, Nikolay Aleksandrov > wrote: >> On 07/09/17 01:47, Kosuke Tatsukawa wrote: >>> Commit cbf5ecb30560 ("net: bonding: Fix transmit load

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

On 9/9/2017 6:28 PM, Alexander Duyck wrote: On Thu, Aug 31, 2017 at 4:27 PM, Sridhar Samudrala wrote: This patch introduces a new socket option SO_SYMMETRIC_QUEUES that can be used to enable symmetric tx and rx queues on a socket. This option is specifically

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

On 9/10/2017 8:19 AM, Tom Herbert wrote: On Thu, Aug 31, 2017 at 4:27 PM, Sridhar Samudrala wrote: This patch introduces a new socket option SO_SYMMETRIC_QUEUES that can be used to enable symmetric tx and rx queues on a socket. This option is specifically useful

Re: [PATCH v5 10/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

On Fri, Sep 08, 2017 at 04:28:25PM +0200, Corentin Labbe wrote: > On Fri, Sep 08, 2017 at 04:17:36PM +0200, Andrew Lunn wrote: > > > > Do you know why the reset times out/fails? > > > > > > > > > > Because there are nothing connected to it. > > > > That should not be an issue. A read should

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

Tested with connectx-5 Without patch 10Mpps - > 16 cores used    PerfTop:   66258 irqs/sec  kernel:99.3%  exact:  0.0% [4000Hz cycles],  (all, 32 CPUs)

Re: [patch net] mlxsw: spectrum: Fix EEPROM access in case of SFP/SFP+

Mon, Sep 11, 2017 at 03:58:26PM CEST, and...@lunn.ch wrote: >On Mon, Sep 11, 2017 at 09:42:26AM +0200, Jiri Pirko wrote: >> From: Arkadi Sharshevsky >> >> The current code does not handle correctly the access to the upper page >> in case of SFP/SFP+ EEPROM. In that case the

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

On Sat, Sep 9, 2017 at 4:28 AM, Nikolay Aleksandrov wrote: > On 07/09/17 01:47, Kosuke Tatsukawa wrote: >> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >> balance-alb mode") tried to fix transmit dynamic load balancing in >> balance-alb mode,

Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR()

From: Kishon Vijay Abraham I Date: Mon, 11 Sep 2017 12:54:47 +0530 > On Saturday 09 September 2017 09:39 AM, David Miller wrote: >> Yeah let's sort this out before I apply this fix to my tree. > > I'll take this fix in linux-phy tree after -rc1 is tagged if that's okay with >

Re: [PATCH net] MAINTAINERS: Remove Yuval Mintz from maintainers list

From: Date: Mon, 11 Sep 2017 17:05:13 +0300 > From: Ariel Elior > > Remove Yuval from maintaining the bnx2x & qed* modules as he is no longer > working for the company. Thanks Yuval for your huge contributions and > tireless efforts over the many years and

RE: [PATCH v1 net] smsc95xx: Configure pause time to 0xffff when tx flow control enabled

> On Mon, Sep 11, 2017 at 12:32:10PM +, nisar.sa...@microchip.com > wrote: > > From: Nisar Sayed > > > > Configure pause time to 0x when tx flow control enabled > > > > Set pause time to 0x in the pause frame to indicate the partner to > > stop sending the

[PATCH v2 net] smsc95xx: Configure pause time to 0xffff when tx flow control enabled

From: Nisar Sayed Configure pause time to 0x when tx flow control enabled Set pause time to 0x in the pause frame to indicate the partner to stop sending the packets. When RX buffer frees up, the device sends pause frame with pause time zero for partner to

Re: [PATCH net] netlink: access nlk groups safely in netlink bind and getname

On Sun, Sep 10, 2017 at 4:45 AM, Xin Long wrote: > On Sat, Sep 9, 2017 at 7:35 AM, Cong Wang wrote: >> On Tue, Sep 5, 2017 at 8:53 PM, Xin Long wrote: >>> Now there is no lock protecting nlk ngroups/groups' accessing in >>>

Re: [patch net] mlxsw: spectrum: Fix EEPROM access in case of SFP/SFP+

From: Jiri Pirko Date: Mon, 11 Sep 2017 09:42:26 +0200 > From: Arkadi Sharshevsky > > The current code does not handle correctly the access to the upper page > in case of SFP/SFP+ EEPROM. In that case the offset should be local > and the I2C address

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

On Mon, Sep 11, 2017 at 9:48 AM, Samudrala, Sridhar wrote: > > > On 9/9/2017 6:28 PM, Alexander Duyck wrote: >> >> On Thu, Aug 31, 2017 at 4:27 PM, Sridhar Samudrala >> wrote: >>> >>> This patch introduces a new socket option

Re: [PATCH] net/sched: fix pointer check in gen_handle

On Sun, Sep 10, 2017 at 12:48 PM, Josh Hunt wrote: > Fixes sparse warning about pointer in gen_handle: > net/sched/cls_rsvp.h:392:40: warning: Using plain integer as NULL pointer > > Fixes: 8113c095672f6 ("net_sched: use void pointer for filter handle") > Signed-off-by: Josh

Re: Extended IDR API

From: Matthew Wilcox Date: Mon, 11 Sep 2017 14:14:08 -0700 > I really don't like your new API. I wish you'd discussed it before > merging it. If I recall correctly, linux-kernel was CC:'d and nobody engaged. I could be wrong, and if I am then my bad, I should have

Re: [PATCH] tipc: Use bsearch library function

From: Thomas Meyer Date: Sat, 9 Sep 2017 05:18:19 +0200 > @@ -168,6 +169,18 @@ static struct name_seq *tipc_nameseq_create(u32 type, > struct hlist_head *seq_hea > return nseq; > } > > +static int nameseq_find_subseq_cmp(const void *key, const void *elt) > +{ > +

Re: [PATCH net] ipv6: sr: remove duplicate routing header type check

From: David Lebrun Date: Sun, 10 Sep 2017 14:22:01 +0100 > From: David Lebrun > > As seg6_validate_srh() already checks that the Routing Header type is > correct, it is not necessary to do it again in get_srh(). > > Fixes: 5829d70b ("ipv6: sr: fix

Re: [V3 PATCH net] xdp: implement xdp_redirect_map for generic XDP

From: Jesper Dangaard Brouer Date: Sun, 10 Sep 2017 09:47:02 +0200 > Using bpf_redirect_map is allowed for generic XDP programs, but the > appropriate map lookup was never performed in xdp_do_generic_redirect(). > > Instead the map-index is directly used as the ifindex. For

Re: [PATCH] net/sched: fix pointer check in gen_handle

From: Josh Hunt Date: Sun, 10 Sep 2017 15:48:50 -0400 > Fixes sparse warning about pointer in gen_handle: > net/sched/cls_rsvp.h:392:40: warning: Using plain integer as NULL pointer > > Fixes: 8113c095672f6 ("net_sched: use void pointer for filter handle") > Signed-off-by:

Re: WARNING: CPU: 2 PID: 4277 at lib/refcount.c:186

Hi Eric, I applied your patch and I no longer observed the warning. Thanks! I will let you know if any further problems show up during fuzzing. Regards, Shankara On Sun, Sep 10, 2017 at 11:34 PM, Eric Dumazet wrote: > On Fri, 2017-09-08 at 11:46 -0700, Eric Dumazet

Re: [Patch net v2 2/2] net_sched: fix all the madness of tc filter chain

On Mon, Sep 11, 2017 at 2:14 PM, Cong Wang wrote: > > Looks like all due to the lack of locking on block->chain_list. > I thought the rcu_barrier() could properly handle this, > but seems still not, probably I need to move it in the loop, > I am still not 100% sure if it

Re: WARNING: CPU: 2 PID: 4277 at lib/refcount.c:186

On Mon, 2017-09-11 at 17:43 -0400, Shankara Pailoor wrote: > Hi Eric, > > I applied your patch and I no longer observed the warning. Thanks! I > will let you know if any further problems show up during fuzzing. Great, I also verified this fixed the problem, I will send the official patch

Extended IDR API

I really don't like your new API. I wish you'd discussed it before merging it. Here's my redesign. Does anybody have a suggestion for improvement? We have a lovely new test-suite for the IDR (in tools/testing/radix-tree) ... when adding a new API, it's polite to update the test-suite too. Do

Re: [Patch net v2 2/2] net_sched: fix all the madness of tc filter chain

On Sun, Sep 10, 2017 at 7:33 AM, Jiri Pirko wrote: > Fri, Sep 08, 2017 at 06:37:55PM CEST, xiyou.wangc...@gmail.com wrote: >>On Thu, Sep 7, 2017 at 1:52 PM, Jiri Pirko wrote: >>> Thu, Sep 07, 2017 at 07:45:49PM CEST, xiyou.wangc...@gmail.com wrote: Yes it

Re: [PATCH v2 net-next 1/2] hv_netvsc: fix deadlock on hotplug

From: Stephen Hemminger Date: Wed, 6 Sep 2017 13:53:05 -0700 > When a virtual device is added dynamically (via host console), then > the vmbus sends an offer message for the primary channel. The processing > of this message for networking causes the network device to

Re: [PATCH v2 net-next 2/2] hv_netvsc: avoid unnecessary wakeups on subchannel creation

From: Stephen Hemminger Date: Wed, 6 Sep 2017 13:53:06 -0700 > Only need to wakeup the initiator after all sub-channels > are opened. > > Signed-off-by: Stephen Hemminger Applied.

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

From: Kosuke Tatsukawa Date: Wed, 6 Sep 2017 22:47:59 + > Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in > balance-alb mode") tried to fix transmit dynamic load balancing in > balance-alb mode, which wasn't working after commit 8b426dc54cf4 >

Re: [PATCH net] perf/bpf: fix a clang compilation issue

From: Yonghong Song Date: Thu, 7 Sep 2017 18:36:15 -0700 > clang does not support variable length array for structure member. > It has the following error during compilation: > > kernel/trace/trace_syscalls.c:568:17: error: fields must have a constant size: > 'variable length array

Re: [PATCH] netfilter: ipset: ipset list may return wrong member count for set with timeout

Hi Jozsef, Thank you. Yes, that is true, the count can still be incorrect in the case of a huge set. Thanks, Vishwanath On 09/11/2017 03:36 PM, Jozsef Kadlecsik wrote: > Hi, > > Your patch is applied in the ipset git tree and I'm going to push it for > kernel inclusion. > > I modified the

RE: [PATCH v2 net 2/3] lan78xx: Allow EEPROM write for less than MAX_EEPROM_SIZE

Nisar, >@@ -1290,8 +1290,8 @@ static int lan78xx_ethtool_set_eeprom(struct net_device >*netdev, > >/* Allow entire eeprom update only */ >if ((ee->magic == LAN78XX_EEPROM_MAGIC) && >- (ee->offset == 0) && >- (ee->len == 512) && >+ (ee->offset >= 0 &&

Re: [PATCH v5 10/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

> Even with CLK_BUS_EPHY/RST_BUS_EPHY enabled, the MAC reset timeout. > So no the CLK/RST are really for the PHY. Thanks for trying that. You said it was probably during scanning of the bus it times out. What address is causing the timeout? 0 or 1? If the internal bus can only have one PHY on

[PATCH v2] openvswitch: Fix an error handling path in 'ovs_nla_init_match_and_action()'

All other error handling paths in this function go through the 'error' label. This one should do the same. Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") Signed-off-by: Christophe JAILLET --- I think that the comment above the function could

Re: [PATCH v2 net 1/3] lan78xx: Fix for eeprom read/write when device auto suspend

On Mon, Sep 11, 2017 at 06:51:49PM +, nisar.sa...@microchip.com wrote: > From: Nisar Sayed > > Fix for eeprom read/write when device auto suspend > > Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 > Ethernet device driver") >

Re: [net-next PATCHv6 1/2] dt-bindings: net: Add DT bindings for Socionext Netsec

On Wed, Aug 30, 2017 at 03:55:52PM +0530, Jassi Brar wrote: > This patch adds documentation for Device-Tree bindings for the > Socionext NetSec Controller driver. > > Signed-off-by: Jassi Brar > --- > .../devicetree/bindings/net/socionext-netsec.txt | 46 >

[PATCH net] tcp/dccp: remove reqsk_put() from inet_child_forget()

From: Eric Dumazet Back in linux-4.4, I inadvertently put a call to reqsk_put() in inet_child_forget(), forgetting it could be called from two different points. In the case it is called from inet_csk_reqsk_queue_add(), we want to keep the reference on the request socket,

Re: [patch net] net: sched: fix memleak for chain zero

On Sun, Sep 10, 2017 at 7:03 AM, Jiri Pirko wrote: > Sat, Sep 09, 2017 at 08:46:42PM CEST, xiyou.wangc...@gmail.com wrote: >>On Thu, Sep 7, 2017 at 7:18 PM, David Miller wrote: >>> >>> This doesn't apply cleanly any more, please respin. >>> >> >>Sigh, you