[patch net-next repost 0/2] mlxsw: Add more extack error reporting

From: Jiri Pirko Ido says: Add error messages to VLAN and bridge enslavements to help users understand why the enslavement failed. Ido Schimmel (2): mlxsw: spectrum: Add extack for VLAN enslavements mlxsw: spectrum: Propagate extack further for bridge enslavements

[patch net-next repost 1/2] mlxsw: spectrum: Add extack for VLAN enslavements

From: Ido Schimmel Similar to physical ports, enslavement of VLAN devices can also fail. Use extack to indicate why the enslavement failed. $ ip link add link enp1s0np1 name enp1s0np1.10 type vlan id 10 $ ip link add name bond0 type bond mode 802.3ad $ ip link set dev

[patch net-next repost 2/2] mlxsw: spectrum: Propagate extack further for bridge enslavements

From: Ido Schimmel The code that actually takes care of bridge offload introduces a few more non-trivial constraints with regards to bridge enslavements. Propagate extack there to indicate the reason. $ ip link add link enp1s0np1 name enp1s0np1.10 type vlan id 10 $ ip link

[PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed

No rcu_read_lock is called, but rcu_read_unlock is still called. Thus rcu_read_unlock should be removed. Signed-off-by: Jia-Ju Bai --- drivers/net/wireless/ath/wcn36xx/main.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/wcn36xx/main.c

Re: [PATCH net-next RFC 5/9] net: dsa: forward hardware timestamping ioctls to switch driver

On Thu, Sep 28, 2017 at 10:25:34AM -0700, Florian Fainelli wrote: > This echoes back to Andrew's comments in patch 2, but we may have to > prefer PHY timestamping over MAC timestamping if both are available? > Richard, is that usually how the preference should be made? No, if the MAC supports

[PATCH iproute2 1/1] color: Fix ip segfault in color_fprintf() when using --color switch

This fixes two regressions: Commit 959f1428 ("color: add new COLOR_NONE and disable_color function") caused segfault, when running ip with --color switch, as 'attr + 8' in color_fprintf() access array item out of bounds. Changing latter value of ternar operator in attr_colors[] index is for

[patch net] mlxsw: spectrum_router: Avoid expensive lookup during route removal

From: Ido Schimmel In commit fc922bb0dd94 ("mlxsw: spectrum_router: Use one LPM tree for all virtual routers") I increased the scale of supported VRFs by having all of them share the same LPM tree. In order to avoid look-ups for prefix lengths that don't exist, each route

Re: [PATCH] Add a driver for Renesas uPD60620 and uPD60620A PHYs

Hi Andrew, sorry for delayed reply. Looks like I did not receive a copy of your e-mail. >> Do you suggest that there are cases where auto negotiation does not >> reach completion, and still provides a usable link status? > > My experience is that it often return 10/half, since everything

Re: [PATCH net-next RFC 1/9] net: dsa: mv88e6xxx: add accessors for PTP/TAI registers

On Thu, Sep 28, 2017 at 10:25:33AM -0500, Brandon Streiff wrote: > This patch implements support for accessing PTP/TAI registers through To avoid confusion, it would be helpful to mention what TAI stands for here and also in the source code comments! Thanks, Richard

Re: [patch net-next 1/6] net: bridge: Use the MDB_RTR_TYPE_TEMP on bridge device too

On 08/10/17 12:39, Nikolay Aleksandrov wrote: > On 08/10/17 08:23, Yotam Gigi wrote: >> On 10/05/2017 03:09 PM, Nikolay Aleksandrov wrote: >>> On 05/10/17 13:36, Jiri Pirko wrote: From: Yotam Gigi Every bridge port is in one of four mcast router port states:

Re: [PATCH net-next RFC 2/9] net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock

On Fri, Sep 29, 2017 at 03:17:02PM +, Brandon Streiff wrote: > > Although now that I'm looking it over again, I'm also not certain of > the need. Even if we're called more frequently than we expect, that > doesn't seem to be harmful with regard to timekeeping. Hmm. Just keep it simple and

[PATCH iproute2 net-next] ip: mroute: Print offload indication

Since kernel net-next commit c7c0bbeae950 ("net: ipmr: Add MFC offload indication") the kernel indicates on an MFC entry whether it was offloaded using the RTNH_F_OFFLOAD flag. Update the "ip mroute show" command to indicate when a route is offloaded, similarly to the "ip route show" command.

Re: [patch net-next 1/6] net: bridge: Use the MDB_RTR_TYPE_TEMP on bridge device too

On 08/10/17 08:23, Yotam Gigi wrote: > On 10/05/2017 03:09 PM, Nikolay Aleksandrov wrote: >> On 05/10/17 13:36, Jiri Pirko wrote: >>> From: Yotam Gigi >>> >>> Every bridge port is in one of four mcast router port states: >>> - MDB_RTR_TYPE_PERM - the port is set by the user

Re: [patch net-next 1/6] net: bridge: Use the MDB_RTR_TYPE_TEMP on bridge device too

On 10/08/2017 12:42 PM, Nikolay Aleksandrov wrote: > On 08/10/17 12:39, Nikolay Aleksandrov wrote: >> On 08/10/17 08:23, Yotam Gigi wrote: >>> On 10/05/2017 03:09 PM, Nikolay Aleksandrov wrote: On 05/10/17 13:36, Jiri Pirko wrote: > From: Yotam Gigi > > Every

Re: [PATCH net-next RFC 2/9] net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock

On Fri, Sep 29, 2017 at 03:28:02PM +, Brandon Streiff wrote: > > NETWORK_PHY_TIMESTAMPING implies NET_PTP_CLASSIFY (which I do use) > and net/core/timestamping.c (which I didn't). It probably makes more > sense to just depend on NET_PTP_CLASSIFY directly. Yes, that makes sense to do, if you

[PATCHv2] Add a driver for Renesas uPD60620 and uPD60620A PHYs

Signed-off-by: Bernd Edlinger --- drivers/net/phy/Kconfig| 5 +++ drivers/net/phy/Makefile | 1 + drivers/net/phy/uPD60620.c | 109 + 3 files changed, 115 insertions(+) create mode 100644 drivers/net/phy/uPD60620.c

Re: [PATCH net-next RFC 2/9] net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock

On Thu, Sep 28, 2017 at 10:25:34AM -0500, Brandon Streiff wrote: > +static int mv88e6xxx_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm) > +{ > + if (scaled_ppm == 0) > + return 0; > + > + return -EOPNOTSUPP; > +} We really want to have an adjustable clock here. More

Re: [patch net-next 0/2] mlxsw: Add more extack error reporting

Sun, Oct 08, 2017 at 12:23:50AM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Thu, 5 Oct 2017 23:39:58 +0200 > >> From: Jiri Pirko >> >> Ido says: >> >> Add error messages to VLAN and bridge enslavements to help users >> understand why the

Re: [PATCH net-next RFC 8/9] net: dsa: mv88e6xxx: add rx/tx timestamping support

On Thu, Sep 28, 2017 at 10:25:40AM -0500, Brandon Streiff wrote: > +static bool mv88e6xxx_should_tstamp(struct mv88e6xxx_chip *chip, int port, > + struct sk_buff *skb, unsigned int type) > +{ > + struct mv88e6xxx_port_hwtstamp *ps = >port_hwtstamp[port]; > +

[PATCH] tests: Remove bashisms (s/source/.)

Signed-off-by: Petr Vorel --- testsuite/tests/ip/link/new_link.t| 2 +- testsuite/tests/ip/link/show_dev_wo_vf_rate.t | 2 +- testsuite/tests/ip/netns/set_nsid.t | 2 +- testsuite/tests/ip/netns/set_nsid_batch.t | 2 +-

[PATCH v2 6/7] crypto:chelsio:Move DMA un/mapping to chcr from lld cxgb4 driver

Allow chcr to do DMA mapping/Unmapping instead of lld cxgb4. It moves "Copy AAD to dst buffer" requirement from driver to firmware. Signed-off-by: Harsh Jain --- drivers/crypto/chelsio/chcr_algo.c | 1645 ++ drivers/crypto/chelsio/chcr_algo.h

[PATCH v2 5/7] crypto:chelsio:Remove allocation of sg list to implement 2K limit of dsgl header

Update DMA address index instead of allocating new sg list to impose 2k size limit for each entry. Signed-off-by: Harsh Jain --- drivers/crypto/chelsio/chcr_algo.c | 237 +++ drivers/crypto/chelsio/chcr_algo.h | 3 +-

[PATCH v2 2/7] crypto:chelsio: Check error code with IS_ERR macro

From: Yeshaswi M R Gowda Check and return proper error code. Signed-off-by: Jitendra Lulla Signed-off-by: Harsh Jain --- drivers/crypto/chelsio/chcr_algo.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)

[PATCH v2 1/7] crypto:chelsio: Remove unused parameter

From: Yeshaswi M R Gowda Remove unused parameter sent to latest fw. Signed-off-by: Harsh Jain --- drivers/crypto/chelsio/chcr_algo.c | 43 +++--- drivers/crypto/chelsio/chcr_algo.h | 12 +-- 2 files changed, 23

[PATCH v2 4/7] crypto:chelsio:Use x8_ble gf multiplication to calculate IV.

gf128mul_x8_ble() will reduce gf Multiplication iteration by 8. Signed-off-by: Harsh Jain --- drivers/crypto/chelsio/chcr_algo.c | 11 +-- drivers/crypto/chelsio/chcr_crypto.h | 1 + 2 files changed, 10 insertions(+), 2 deletions(-) diff --git

[PATCH v2 3/7] crypto:gf128mul: The x8_ble multiplication functions

It multiply GF(2^128) elements in the ble format. It will be used by chelsio driver to speed up gf multiplication. Signed-off-by: Harsh Jain --- crypto/gf128mul.c | 13 + include/crypto/gf128mul.h | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-)

[PATCH v2 7/7] crypto:chelsio: Fix memory leak

Fix memory leak when device does not support crypto. Reported-by: Dan Carpenter Signed-off-by: Harsh Jain --- drivers/crypto/chelsio/chcr_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 3/3] batman-adv: Add missing kerneldoc for extack

On Samstag, 7. Oktober 2017 20:59:52 CEST David Miller wrote: > From: Sven Eckelmann > Date: Sat, 7 Oct 2017 14:21:22 +0200 > > > The parameter extack was added to batadv_softif_slave_add without adding > > the kernel-doc for it. This caused kernel-doc warnings. > > > >

Re: [PATCH iproute2] iproute: build more easily on Android

On Tue, Oct 03, 2017 at 02:03:37AM +0900, Lorenzo Colitti wrote: > iproute2 contains a bunch of kernel headers, including uapi ones. > Android's libc uses uapi headers almost directly, and uses a > script to fix kernel types that don't match what userspace > expects. > > For example:

Re: devlink dump of mlxsw_adj table triggers a panic

On 10/05/2017 02:57 AM, David Ahern wrote: > The following devlink command on a 2700 triggers a panic every time. > Kernel is net-next at 26873308b21654b6e0785b9f9e2c5414d37a4c4c > > $ devlink dpipe table dump pci/:03:00.0 name mlxsw_adj > devlink answers: No buffer space available > > >

Re: [PATCH 41/47] netfilter: convert hook list to an array

On 04/09/2017 1:42 AM, Pablo Neira Ayuso wrote: From: Aaron Conole This converts the storage and layout of netfilter hook entries from a linked list to an array. After this commit, hook entries will be stored adjacent in memory. The next pointer is no longer required.

Re: [PATCH net-next RFC 4/9] net: dsa: mv88e6xxx: add support for event capture

There are some issues here. On Thu, Sep 28, 2017 at 10:25:36AM -0500, Brandon Streiff wrote: > +static int mv88e6xxx_config_periodic_trig(struct mv88e6xxx_chip *chip, > + u32 ns, u16 picos) > +{ > + int err; > + u16 global_config; > + > + if

Re: [PATCH net-next] ipv6: Do not use this_cpu_ptr() in preemptible context

On Sun, 2017-10-08 at 18:18 +0300, Ido Schimmel wrote: > Without the rwlock and with PREEMPT_RCU we're no longer guaranteed to be > in non-preemptible context when performing a route lookup, so use > raw_cpu_ptr() instead. > > Takes care of the following splat: > [ 122.221814] BUG: using

[PATCH 00/12] radix-tree: split out struct radix_tree_root out to

The motivation of this series is to cut down unnecessary header dependency in terms of radix tree. Sub-systems or drivers that use radix-tree for data management typically embed struct radix_tree_root in their data structures, like this: struct foo { ... struct radix_tree_root

Re: [PATCH 11/12] net/mlx5: replace with

From: Masahiro Yamada Date: Mon, 9 Oct 2017 01:10:12 +0900 > The header include/linux/mlx5/driver.h requires the definition of > struct radix_tree_root, but does not need to know anything about > other radix tree stuff. > > Include instead of to > reduce the

Re: [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

On Thu, Sep 28, 2017 at 09:37:08AM +0200, Corentin Labbe wrote: > On Wed, Sep 27, 2017 at 04:02:10PM +0200, Andrew Lunn wrote: > > Hi Corentin > > > > > +Required properties for the mdio-mux node: > > > + - compatible = "mdio-mux" > > > > This is too generic. Please add a more specific

Re: [PATCH net-next RFC 0/9] net: dsa: PTP timestamping for mv88e6xxx

On Fri, Sep 29, 2017 at 05:43:23AM -0400, Richard Cochran wrote: > I happy to see this series. I just finished porting an out-of-tree > PHC driver for the Marvell mv88e635x, and I want to mainline it, but I > also have a few uglies. This series looks really good. I won't even post my mine, as

Re: [PATCH 10/12] net/mlx4: replace with

From: Masahiro Yamada Date: Mon, 9 Oct 2017 01:10:11 +0900 > The headers > - include/linux/mlx4/device.h > - drivers/net/ethernet/mellanox/mlx4/mlx4.h > require the definition of struct radix_tree_root, but do not need to > know anything about other radix tree

Re: [patch net] mlxsw: spectrum_router: Avoid expensive lookup during route removal

From: Jiri Pirko Date: Sun, 8 Oct 2017 11:53:26 +0200 > From: Ido Schimmel > > In commit fc922bb0dd94 ("mlxsw: spectrum_router: Use one LPM tree for > all virtual routers") I increased the scale of supported VRFs by having > all of them share the same

Re: [patch net-next repost 0/2] mlxsw: Add more extack error reporting

From: Jiri Pirko Date: Sun, 8 Oct 2017 11:57:54 +0200 > From: Jiri Pirko > > Ido says: > > Add error messages to VLAN and bridge enslavements to help users > understand why the enslavement failed. Series applied, thanks for the repost.

Re: [PATCH 10/12] net/mlx4: replace with

On Mon, 2017-10-09 at 02:29 +0900, Masahiro Yamada wrote: > The idea is simple; include necessary headers explicitly. Try that for kernel.h There's a reason aggregation of #includes is useful.

Re: [PATCH 00/12] radix-tree: split out struct radix_tree_root out to

On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote: <...> > > By splitting out the radix_tree_root definition, > we can reduce the header file dependency. > > Reducing the header dependency will help for speeding the kernel > build, suppressing unnecessary recompile of objects during

[PATCH] net/core: Fix BUG to BUG_ON conditionals.

Fix BUG() calls to use BUG_ON(conditional) macros. This was found using make coccicheck M=net/core on linux next tag next-20170929. Signed-off-by: Tim Hansen --- net/core/skbuff.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git

[BUG] stmmac: A possible sleep-in-atomic bug in stmmac_suspend

According to stmmac_main.c, the driver may sleep under a spinlock, and the function call path is: stmmac_suspend (acquire the spinlock) stmmac_disable_all_queues napi_disable might_sleep --> may sleep msleep --> may sleep This bug is found by my static analysis tool and my code

Re: [PATCH net-next RFC 8/9] net: dsa: mv88e6xxx: add rx/tx timestamping support

On Thu, Sep 28, 2017 at 10:25:40AM -0500, Brandon Streiff wrote: > +void mv88e6xxx_port_txtstamp(struct dsa_switch *ds, int port, > + struct sk_buff *clone, unsigned int type) > +{ > + struct mv88e6xxx_chip *chip = ds->priv; > + struct mv88e6xxx_port_hwtstamp *ps =

Re: [PATCH 10/12] net/mlx4: replace with

On Mon, Oct 09, 2017 at 02:29:15AM +0900, Masahiro Yamada wrote: > 2017-10-09 2:00 GMT+09:00 David Miller : > > From: Masahiro Yamada > > Date: Mon, 9 Oct 2017 01:10:11 +0900 > > > >> The headers > >> - include/linux/mlx4/device.h > >> -

[PATCH net-next] ipv6: Do not use this_cpu_ptr() in preemptible context

Without the rwlock and with PREEMPT_RCU we're no longer guaranteed to be in non-preemptible context when performing a route lookup, so use raw_cpu_ptr() instead. Takes care of the following splat: [ 122.221814] BUG: using smp_processor_id() in preemptible [] code: sshd/2672 [

[PATCH 10/12] net/mlx4: replace with

The headers - include/linux/mlx4/device.h - drivers/net/ethernet/mellanox/mlx4/mlx4.h require the definition of struct radix_tree_root, but do not need to know anything about other radix tree stuff. Include instead of to reduce the header dependency. While we are here, let's add missing

[PATCH 11/12] net/mlx5: replace with

The header include/linux/mlx5/driver.h requires the definition of struct radix_tree_root, but does not need to know anything about other radix tree stuff. Include instead of to reduce the number of included header files. Also, add to include/linux/mlx5/gp.h where radix tree accessors are

Re: [PATCH net-next] ipv6: Do not use this_cpu_ptr() in preemptible context

Hi Eric, On Sun, Oct 08, 2017 at 09:03:53AM -0700, Eric Dumazet wrote: > Thanks Ido for this patch. > > IMO, we no longer play this read_lock() -> write_lock() game since > ip6_dst_gc() could be called from rt6_make_pcpu_route() Right, cause we can't deadlock anymore as with the rwlock. > >

Re: [PATCH net-next,0/3] hv_netvsc: support changing TCP hash level

From: Haiyang Zhang Date: Fri, 6 Oct 2017 08:33:56 -0700 > From: Haiyang Zhang > > The patch set simplifies the existing hash level switching code for > UDP. It also adds the support for changing TCP hash level. So users > can switch

Re: [PATCH net-next] ipv6: Do not use this_cpu_ptr() in preemptible context

On Sun, 2017-10-08 at 19:54 +0300, Ido Schimmel wrote: > Hi Eric, > > prev = cmpxchg(p, NULL, pcpu_rt); > > - if (prev) { > > - /* If someone did it before us, return prev instead */ > > - /* release refcnt taken by ip6_rt_pcpu_alloc() */ > > -

[PATCH] net: ethernet: stmmac: Clean up dead code

Many macros in dwmac-ipq806x are unused and should be removed. Moreover gmac->id is an unsigned variable and therefore checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 14

Re: devlink dump of mlxsw_adj table triggers a panic

On 10/8/17 1:43 AM, Arkadi Sharshevsky wrote: > Thanks, will check it out. How many nexthops groups & overall number of > nexthops you configured? 8 ports with 62 VLANs on each (496 total vlan devices) and 62 VRFs. BGP is exchanging routes with neighbors. No multipath routes.

Re: [PATCH net-next RFC 8/9] net: dsa: mv88e6xxx: add rx/tx timestamping support

On Thu, Sep 28, 2017 at 10:25:40AM -0500, Brandon Streiff wrote: > We also utilize a feature of the "generation 3" PTP hardware that lets > us to embed the timestamp value into one of the reserved fields in the > PTP header. This lets us extract the timestamp out of the header and > avoid an SMI

Re: [PATCH 3/3] batman-adv: Add missing kerneldoc for extack

From: Sven Eckelmann Date: Sun, 08 Oct 2017 09:29:17 +0200 > Are you expected to apply this change: > = > > I was hoping that Simon is picking the patch up and forwards it do you in a > proper pull request. But I would doubt that he has a

Re: [PATCH v2] gso: fix payload length when gso_size is zero

From: Alexey Kodanev Date: Fri, 6 Oct 2017 19:02:35 +0300 > When gso_size reset to zero for the tail segment in skb_segment(), later > in ipv6_gso_segment(), __skb_udp_tunnel_segment() and gre_gso_segment() > we will get incorrect results (payload length, pcsum) for

Re: [PATCH 10/12] net/mlx4: replace with

2017-10-09 2:00 GMT+09:00 David Miller : > From: Masahiro Yamada > Date: Mon, 9 Oct 2017 01:10:11 +0900 > >> The headers >> - include/linux/mlx4/device.h >> - drivers/net/ethernet/mellanox/mlx4/mlx4.h >> require the definition of struct

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

Mistakenly sent the patch previously with a missing semicolon. Apologies. Fix BUG() calls to use BUG_ON(conditional) macros. This was found using make coccicheck M=net/core on linux next tag next-20170929 Signed-off-by: Tim Hansen --- net/core/skbuff.c | 15

RIF/VRF overflow in spectrum and reporting errors back to user

Jiri / Ido: I am looking at adding user messages for spectrum failures related to RIF and VRF overflow coming from the inetaddr and inet6addr notifier paths. The key is that if the notifiers fail the address add needs to fail and an error reported to the user as to what happened. Earlier this

[PATCH] ath10k: spectral: Simplify error checking

Variable val is unsigned so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/wireless/ath/ath10k/spectral.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/spectral.c

[PATCH] ath9k: debug: Simplify error checking

Variable val is unsigned so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/wireless/ath/ath9k/debug.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/debug.c

[PATCH] qed: Delete redundant check on dcb_app priority

dcb_app priority is unsigned thus checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[net PATCH] macvlan: Only deliver one copy of the frame to the macvlan interface

From: Alexander Duyck This patch intoduces a slight adjustment for macvlan to address the fact that in source mode I was seeing two copies of any packet addressed to the macvlan interface being delivered where there should have been only one. The issue appears to be

Re: [net PATCH] macvlan: Only deliver one copy of the frame to the macvlan interface

On Sun, 2017-10-08 at 15:54 -0700, Alexander Duyck wrote: > From: Alexander Duyck > > This patch intoduces a slight adjustment for macvlan to address the fact > that in source mode I was seeing two copies of any packet addressed to the > macvlan interface being

Re: [PATCH] net: dsa: mv88e6xxx: rework in-chip bridging

Hi Florian, On 07/10/17 13:04, Florian Fainelli wrote: > Le 10/03/17 à 23:20, Greg Ungerer a écrit : >> On Wed, Mar 29, 2017 at 04:30:16PM -0400, Vivien Didelot wrote: >>> All ports -- internal and external, for chips featuring a PVT -- have a >>> mask restricting to which internal ports a frame

Re: BUG: using smp_processor_id() in preemptible [00000000]

On Sun, 8 Oct 2017 20:47:10 -0700, Eric Dumazet wrote: > This was discussed/reported earlier today by Ido. > > https://patchwork.ozlabs.org/patch/823011/ > > We will submit an official fix shortly. Ah, sorry, I missed that!

Re: [PATCH] net/core: Fix BUG to BUG_ON conditionals.

Hi Tim, [auto build test ERROR on net-next/master] [also build test ERROR on v4.14-rc3 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] net: make ->ndo_get_phys_port_name accept 32-bit len

On Sun, 8 Oct 2017 01:19:17 +0300, Alexey Dobriyan wrote: > Buffer length passed into this hook is always IFNAMSIZ which is 16. > > Code savings on x86_64: > > add/remove: 0/0 grow/shrink: 1/9 up/down: 2/-45 (-43) > function old new delta >

RE: [PATCH] qed: Delete redundant check on dcb_app priority

> dcb_app priority is unsigned thus checking whether it is less than zero > is redundant. > > Signed-off-by: Christos Gkekas Thanks Acked-By: Tomer Tayar

BUG: using smp_processor_id() in preemptible [00000000]

Hi! This appeared in net-next over the weekend - looks likely related to this set... [ 164.456668] BUG: using smp_processor_id() in preemptible [] code: sshd/1255 [ 164.472259] caller is ip6_pol_route+0xe88/0x4a80 [ 164.477571] CPU: 10 PID: 1255 Comm: sshd Not tainted

RE: [PATCH net v1 2/2] net: fec: Let fec_ptp have its own interrupt routine

From: Troy Kisky Sent: Tuesday, October 03, 2017 8:05 AM >To: shawn@linaro.org; Andy Duan ; >netdev@vger.kernel.org; da...@davemloft.net >Cc: Fabio Estevam ; lzn...@gmail.com; Troy Kisky

Re: BUG: using smp_processor_id() in preemptible [00000000]

On Sun, Oct 8, 2017 at 8:43 PM, Jakub Kicinski wrote: > Hi! > > This appeared in net-next over the weekend - looks likely related to > this set... > > [ 164.456668] BUG: using smp_processor_id() in preemptible [] code: > sshd/1255 > [ 164.472259] caller is

[PATCH net-next 00/15] nfp: bpf ABIv2 and multi port

Hi! This series migrates our eBPF offload from old PoC firmware to a redesigned, faster and more feature rich FW. Marking support is dropped for now. We have to teach the JIT about encoding local memory accesses (one of NFP memory types). There is also code to populate the ECC of instructions

Re: [PATCH] net: dsa: mv88e6xxx: rework in-chip bridging

Le 10/08/17 à 20:23, Greg Ungerer a écrit : > Hi Florian, > > On 07/10/17 13:04, Florian Fainelli wrote: >> Le 10/03/17 à 23:20, Greg Ungerer a écrit : >>> On Wed, Mar 29, 2017 at 04:30:16PM -0400, Vivien Didelot wrote: All ports -- internal and external, for chips featuring a PVT -- have a

Re: [PATCH net-next] ipv6: fix a BUG in rt6_get_pcpu_route()

From: Eric Dumazet Date: Sun, 08 Oct 2017 21:07:18 -0700 > From: Eric Dumazet > > Ido reported following splat and provided a patch. > > [ 122.221814] BUG: using smp_processor_id() in preemptible [] code: > sshd/2672 > [ 122.221845]

Re: [pull request][for-next 0/9] Mellanox, mlx5 updates 2017-10-06

From: Saeed Mahameed Date: Fri, 6 Oct 2017 16:37:40 -0700 > This series includes some shared code updates for kernel 4.15 to both > net-next and rdma-next trees. I've pulled this into net-next, thanks Saeed.

Re: [PATCH net-next 0/6] ipv6: ipv6_dev_get_saddr() rcu works

From: Eric Dumazet Date: Sat, 7 Oct 2017 19:30:22 -0700 > Sending IPv6 udp packets on non connected sockets is quite slow, > because ipv6_dev_get_saddr() is still using an rwlock and silly > references games on ifa. > > Tested: > > $ ./super_netperf 16 -H ::555:0786

Re: [PATCH] qed: Delete redundant check on dcb_app priority

From: Christos Gkekas Date: Sun, 8 Oct 2017 23:46:47 +0100 > dcb_app priority is unsigned thus checking whether it is less than zero > is redundant. > > Signed-off-by: Christos Gkekas Applied to net-next.

Re: [PATCH net-next 0/2] net: defer cgroups init to accept()

On Sun, Oct 8, 2017 at 9:44 PM, Eric Dumazet wrote: > After TCP 3WHS became lockless, we should not attempt cgroup games > from sk_clone_lock() since listener/cgroup might be already gone. > > Move this business to inet_csk_accept() where we have > the guarantee both parent

Re: netlink backwards compatibility in userspace tools

From: "Jason A. Donenfeld" Date: Fri, 29 Sep 2017 12:22:42 +0200 > One handy aspect of Netlink is that it's backwards compatible. This > means that you can run old userspace utilities on new kernels, even if > the new kernel supports new features and netlink attributes. The wire

[PATCH net-next 06/15] nfp: bpf: remove register rename

Remove the register renumbering optimization. To implement calling map and other helpers we need more strict register layout. We can't freely reassign register numbers. This will have the effect of running in 4 context/thread mode, which should be OK since we are moving towards integrating the

[PATCH net-next 10/15] nfp: bpf: encode extended LM pointer operands

Most instructions have special fields which allow switching between base and extended Local Memory pointers. Introduce those to register encoding, we will use the extra LM pointers to access high addresses of the stack. Signed-off-by: Jakub Kicinski Reviewed-by:

[PATCH net-next 11/15] nfp: bpf: move to datapath ABI version 2

Datapath ABI version 2 stores the packet information in LMEM instead of NNRs. We also have strict restrictions on which GPRs we can use. Only GPRs 0-23 are reserved for BPF. Adjust the static register locations and "ABI" registers. Note that packet length is packed with other info so we have to

[PATCH net-next 08/15] nfp: add more white space to the instruction defines

We need to add longer OP_* defines, move the values away. Purely whitespace commit. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_asm.h | 156 +-- 1 file

[PATCH net-next 03/15] nfp: bpf: use the power of sparse to check we encode registers right

Define a new __bitwise type for software representation of registers. This will allow us to catch incorrect parameter types using sparse. Accessors we define also allow us to return correct enum type and therefore ensure all switches handle all register types. Signed-off-by: Jakub Kicinski

[PATCH net-next 07/15] nfp: bpf: remove packet marking support

Temporarily drop support for skb->mark. We are primarily focusing on XDP offload, and implementing skb->mark on the new datapath has lower priority. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman ---

[PATCH net-next 15/15] nfp: bpf: pass dst register to ld_field instruction

ld_field instruction is a bit special because the encoding uses two source registers and one of them becomes the output. We do need to pass the dst register to our encoding helpers though, otherwise the "write both banks" flag will not be observed. Signed-off-by: Jakub Kicinski

[PATCH net-next 09/15] nfp: bpf: encode LMEM accesses

NFP LMEM is a large, indirectly accessed register file. There are two basic indirect access registers. Each access operation may either use offset (up to 8 or 16 words) or perform post decrement/increment. Add encodings of LMEM indexes as instruction operands. Signed-off-by: Jakub Kicinski

[PATCH net-next 02/15] nfp: bpf: lift the single-port limitation

Limiting the eBPF offload to a single port was a workaround required for the PoC application FW which has not been released externally. It's not necessary any more. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman ---

[PATCH net-next 05/15] nfp: bpf: encode all 64bit shifts

Add encodings of all 64bit shift operations. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/bpf/jit.c | 48 +--- 1 file changed, 36 insertions(+), 12 deletions(-)

[PATCH net-next 04/15] nfp: bpf: move software reg helpers and cmd table out of translator

Move the software reg helpers and some static data to nfp_asm.c. They are related to the previous patch, but move is done in a separate commit for ease of review. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman ---

[PATCH net-next 13/15] nfp: bpf: pad code with valid nops

We need to append up to 8 nops after last instruction to make sure the CPU will not fetch garbage instructions with invalid ECC if the code store was not initialized. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman ---

[PATCH net-next 12/15] nfp: bpf: calculate code store ECC

In the initial PoC firmware I simply disabled ECC on the instruction store. Do the ECC calculation for generated instructions in the driver. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman ---

[PATCH net-next 01/15] nfp: output control messages to trace_devlink_hwmsg()

Use standard devlink trace point to allow tracing of control messages. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_app.h | 8 1 file changed, 8 insertions(+) diff --git

[PATCH net-next] ipv6: fix a BUG in rt6_get_pcpu_route()

From: Eric Dumazet Ido reported following splat and provided a patch. [ 122.221814] BUG: using smp_processor_id() in preemptible [] code: sshd/2672 [ 122.221845] caller is debug_smp_processor_id+0x17/0x20 [ 122.221866] CPU: 0 PID: 2672 Comm: sshd Not tainted

[PATCH net-next 14/15] nfp: bpf: byte swap the instructions

Device expects the instructions in little endian. Make sure we byte swap on big endian hosts. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/bpf/jit.c | 6 -- 1 file changed, 4

Re: [PATCH net-next v6 0/3] bridge: neigh msg proxy and flood suppression support

From: Roopa Prabhu Date: Fri, 6 Oct 2017 22:12:36 -0700 > From: Roopa Prabhu > > This series implements arp and nd suppression in the bridge > driver for ethernet vpns. It implements rfc7432, section 10 >

Re: [net 1/1] tipc: correct initialization of skb list

From: Jon Maloy Date: Sat, 7 Oct 2017 14:32:49 +0200 > We change the initialization of the skb transmit buffer queues > in the functions tipc_bcast_xmit() and tipc_rcast_xmit() to also > initialize their spinlocks. This is needed because we may, during > error conditions,

Re: [net 1/1] tipc: Unclone message at secondary destination lookup

From: Jon Maloy Date: Sat, 7 Oct 2017 15:07:20 +0200 > When a bundling message is received, the function tipc_link_input() > calls function tipc_msg_extract() to unbundle all inner messages of > the bundling message before adding them to input queue. > > The function

  1   2   >