Re: [PATCH net-next 2/2] chcr: Add support for Inline IPSec

Hi Atul, Thank you for the patch! Yet we hit a small issue. [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Atul-Gupta/cxgb4-Add-support-for-Inline-IPSec-Tx/20171029-060344 reproduce: # apt-get install sparse make ARCH=x86_64

Re: [patch net-next 0/4] net: sched: block callbacks follow-up

Sun, Oct 29, 2017 at 10:36:32AM CET, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Wed, 25 Oct 2017 16:34:56 +0200 > >> This patchset does a bit of cleanup of leftovers after block callbacks >> patchset. The main part is patch 2, which restores the original handling >> of

Re: [PATCH] ravb: Use common error handling code in ravb_probe()

>> @@ -2069,10 +2069,9 @@ static int ravb_probe(struct platform_device *pdev) >> irq = platform_get_irq_byname(pdev, "ch22"); >> else >> irq = platform_get_irq(pdev, 0); >> - if (irq < 0) { >> - error = irq; >> - goto

Re: KASAN: use-after-free Write in detach_if_pending

On Sun, 2017-10-29 at 13:45 +0100, Thomas Gleixner wrote: > On Fri, 27 Oct 2017, syzbot wrote: > > Cc'ed network folks. > > > syzkaller hit the following crash on > > e7989f973ae1b90ec7c0b671c81f7f553affccbe > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > >

[PATCH] mkiss: remove redundant assignment of len to ax->mtu

From: Colin Ian King Variable len is being assigned a value that is never read, hence the assignment is redundant and can be removed. Cleans up clang warning: drivers/net/hamradio/mkiss.c:443:3: warning: Value stored to 'len' is never read Signed-off-by: Colin Ian

Re: [PATCH net-next] qed: Set error code for allocation failures

From: Dan Carpenter Sent: Friday, October 27, 2017 2:52 PM >On Fri, Oct 27, 2017 at 05:32:42PM +0800, Yunsheng Lin wrote: >> > iwarp_info = _hwfn->p_rdma_info->iwarp; >> > @@ -2696,6 +2696,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn, >> > if (rc) >> >

[PATCH] smsc95xx: Use common error handling code in smsc95xx_write_eeprom()

From: Markus Elfring Date: Sun, 29 Oct 2017 11:08:34 +0100 Add a jump target so that a specific error message is stored only once at the end of this function implementation. Replace two calls of the function "netdev_warn" by goto statements. This issue was

Re: [PATCH] sr9800: Use common error handling code in sr9800_phy_powerup()

>> @@ -700,10 +700,9 @@ static int sr9800_phy_powerup(struct usbnet *dev) >> >> /* set the embedded Ethernet PHY in power-up state */ >> ret = sr_sw_reset(dev, SR_SWRESET_IPRL); >> - if (ret < 0) { >> - netdev_err(dev->net, "Failed to reset PHY: %d\n", ret); >>

[PATCH] net: ethernet: slicoss: remove redundant initialization of idx

From: Colin Ian King Variable idx is being initialized and later on over-written by a new value in a do-loop without the initial value ever being read. Hence the initializion is redundant and can be removed. Cleans up clang warning:

net: lapbether: fix double free

The function netdev_priv() returns the private data of the device. The memory to store the private data is allocated in alloc_netdev() and is released in netdev_free(). Calling kfree() on the return value of netdev_priv() after netdev_free() results in a double free bug. Signed-off-by: Pan Bian

Re: [PATCH net-next] qed: Set error code for allocation failures

From: Dan Carpenter Sent: Friday, October 27, 2017 9:40 AM > There are several places where we accidentally return success when > kcalloc() fails. > > Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and > processing mpa fpdus") > Signed-off-by: Dan

Re: [PATCH] r8169: Add support for interrupt coalesce tuning (ethtool -C)

On Sun, Oct 29, 2017 at 11:08:35AM +0900, David Miller wrote: > > Applied to net-next, thank you. Thanks a lot.

[PATCH 13/17] iwlwifi: mvm: Convert timers to use timer_setup()

From: Kees Cook In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. The RCU lifetime on baid_data is unclear, so this adds a direct

net: hns: set correct return value

The function of_parse_phandle() returns a NULL pointer if it cannot resolve a phandle property to a device_node pointer. In function hns_nic_dev_probe(), its return value is passed to PTR_ERR to extract the error code. However, in this case, the extracted error code will always be zero, which is

check

Please check for the contract.

Re: [PATCH net-next 11/14] bnxt_en: add support for Flower based vxlan encap/decap offload

Hi Sathya, Thank you for the patch! Yet we hit a small issue. [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Michael-Chan/bnxt_en-Updates-for-net-next/20171029-105709 config: i386-randconfig-x0-10291556 (attached as .config) compiler: gcc-6 (Debian

[PATCH net-next v3 2/2] net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and update

Using a spinlock in the VLAN action causes performance issues when the VLAN action is used on multiple cores. Rewrote the VLAN action to use RCU read locking for reads and updates instead. Fixed nxp flower action to use VLAN helper functions instead of accessing the structure directly (build break

[PATCH net-next v3 1/2] net sched act_vlan: Change stats update to use per-core stats

The VLAN action maintains one set of stats across all cores, and uses a spinlock to synchronize updates to it from the same. Changed this to use a per-CPU stats context instead. This change will result in better performance. Acked-by: Jamal Hadi Salim Acked-by: Jiri Pirko

[PATCH net-next v3 0/2] Completed requested changes

Hi everyone, The kbuild robot detected an issue with building the netronome drivers (flower action). Fixed them to use the VLAN helper functions instead of dereferencing the structure directly. Could you please review? Here're the changes: v2: Fixed all helper functions to use RCU

Re: [patch net-next 0/4] net: sched: block callbacks follow-up

From: Jiri Pirko Date: Wed, 25 Oct 2017 16:34:56 +0200 > This patchset does a bit of cleanup of leftovers after block callbacks > patchset. The main part is patch 2, which restores the original handling > of tc offload feature flag. Jiri, this series does not apply cleanly to

Re: [PATCH] sr9800: Use common error handling code in sr9800_phy_powerup()

Hi Markus, On Sun, Oct 29, 2017 at 11:45 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 29 Oct 2017 11:33:14 +0100 > > Add a jump target so that a specific error message is stored only once > at the end of this

Re: [patch net-next RFC 1/7] devlink: Add support for resource abstraction

On 10/25/2017 06:26 PM, David Ahern wrote: > On 10/24/17 3:22 AM, Jiri Pirko wrote: >> diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h >> index 0cbca96..9db1d70 100644 >> --- a/include/uapi/linux/devlink.h >> +++ b/include/uapi/linux/devlink.h >> @@ -69,6 +69,8 @@ enum

[GIT] Networking

1) Fix route leak in xfrm_bundle_create(). 2) In mac80211, validate user rate mask before configuring it. From Johannes Berg. 3) Properly enforce memory limits in fair queueing code, from Toke Hoiland-Jorgensen. 4) Fix lockdep splat in inet_csk_route_req(), from Eric Dumazet. 5) Fix TSO

Re: [Patch net] net_sched: avoid matching qdisc with zero handle

From: Cong Wang Date: Fri, 27 Oct 2017 22:08:56 -0700 > Davide found the following script triggers a NULL pointer > dereference: > > ip l a name eth0 type dummy > tc q a dev eth0 parent :1 handle 1: htb > > This is because for a freshly created netdevice noop_qdisc >

[PATCH] sr9800: Use common error handling code in sr9800_phy_powerup()

From: Markus Elfring Date: Sun, 29 Oct 2017 11:33:14 +0100 Add a jump target so that a specific error message is stored only once at the end of this function implementation. Replace two calls of the function "netdev_err" by goto statements. This issue was detected

Re: KASAN: use-after-free Write in detach_if_pending

On Fri, 27 Oct 2017, syzbot wrote: Cc'ed network folks. > syzkaller hit the following crash on e7989f973ae1b90ec7c0b671c81f7f553affccbe > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is

Re: [Patch net 00/16] net_sched: fix races with RCU callbacks

From: Cong Wang Date: Thu, 26 Oct 2017 18:24:27 -0700 > Recently, the RCU callbacks used in TC filters and TC actions keep > drawing my attention, they introduce at least 4 race condition bugs: ... > As suggested by Paul, we could defer the work to a workqueue and >

Re: [PATCH net 0/4] sctp: a bunch of fixes for some sparse warnings

From: Xin Long Date: Sat, 28 Oct 2017 19:43:53 +0800 > As Eric noticed, when running 'make C=2 M=net/sctp/', a plenty of > warnings or errors checked by sparse appear. They are all problems > about Endian and type cast. > > Most of them are just warnings by which no issues

Re: [PATCH net-next] tools: bpftool: add bash completion for bpftool

From: Jakub Kicinski Date: Thu, 26 Oct 2017 14:16:05 -0700 > From: Quentin Monnet > > Add a completion file for bash. The completion function runs bpftool > when needed, making it smart enough to help users complete ids or tags > for

Re: can: Use common error handling code in vxcan_newlink()

Hi Markus, this discussion went far beyond the original posted patch for vxcan.c I would suggest you post your idea of the simplified error handling flow in vxcan.c just on linux-can ML (which is the right mailing list for CAN related stuff). Thanks, Oliver On 10/28/2017 10:13 PM, SF

Re: [patch net-next v2 00/20] net: sched: convert cls ndo_setup_tc offload calls to per-block callbacks

Sat, Oct 28, 2017 at 07:17:24PM CEST, kubak...@wp.pl wrote: >On Sat, 28 Oct 2017 10:43:51 +0200, Jiri Pirko wrote: >> Sat, Oct 28, 2017 at 09:53:21AM CEST, kubak...@wp.pl wrote: >> >On Sat, 28 Oct 2017 09:20:31 +0200, Jiri Pirko wrote: >> >> Sat, Oct 28, 2017 at 02:52:00AM CEST, kubak...@wp.pl

Re: [PATCH net-next] net: aquantia: Make local functions static

From: Wei Yongjun Date: Sat, 28 Oct 2017 05:03:38 + > Fixes the following sparse warnings: > > drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c:224:5: warning: > symbol 'aq_ethtool_get_coalesce' was not declared. Should it be static? >

Re: [PATCH next 0/2] add 'private' and 'vepa' attributes to ipvlan modes

From: Mahesh Bandewar Date: Thu, 26 Oct 2017 15:09:06 -0700 > From: Mahesh Bandewar > > IPvlan has always been operating in bridge-mode for its supported modes i.e. > if the packets are destined to the adjacent neighbor dev, then IPvlan driver > will

Re: [PATCH] ravb: Use common error handling code in ravb_probe()

Hi Markus, On Sat, Oct 28, 2017 at 7:19 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 28 Oct 2017 19:10:08 +0200 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this

RE: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

Hi Yuan, Can you please give more details about this change you are proposing? Regards, Madalin > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of yuan linyu > Sent: Sunday, October 29, 2017 3:49 AM > To: netdev@vger.kernel.org

Outgoing interface check in icmpv6_echo_reply()

Hi, I need to add a check in icmp6_echo_reply() to drop any packet that is being sent using address that is not local to any linux interface. Mostly to avoid icmpv6 stats registering this packet. /* Dont send if the address is not found on any device */ ret = ipv6_chk_addr_and_flags(net, saddr,

RE: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

Also here: http://elixir.free-electrons.com/linux/latest/source/mm/percpu.c#L717 Should the fact that the memory is zeroed be included in the function description? /** * pcpu_alloc - the percpu allocator * @size: size of area to allocate in bytes * @align: alignment of area (max PAGE_SIZE)

RE: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

Is the memset part documented? Can you point to the specific comment & code that does it? Thanks > -Original Message- > From: Yuan, Linyu (NSB - CN/Shanghai) [mailto:linyu.y...@nokia-sbell.com] > Sent: Monday, October 30, 2017 7:12 AM > To: Madalin-cristian Bucur ;

RE: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

http://elixir.free-electrons.com/linux/latest/source/mm/percpu.c#L1018 > -Original Message- > From: Madalin-cristian Bucur [mailto:madalin.bu...@nxp.com] > Sent: Monday, October 30, 2017 1:15 PM > To: Yuan, Linyu (NSB - CN/Shanghai); yuan linyu; netdev@vger.kernel.org > Cc: David S .

RE: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

Hi, devm_alloc_percpu() will allocate per-cpu memory and memset allocated block content to 0. > -Original Message- > From: Madalin-cristian Bucur [mailto:madalin.bu...@nxp.com] > Sent: Monday, October 30, 2017 1:08 PM > To: yuan linyu; netdev@vger.kernel.org > Cc: David S . Miller;

[PATCH 0/5] wlcore: Fine-tuning for three function implementations

From: Markus Elfring Date: Sun, 29 Oct 2017 21:02:34 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (5): Use common error handling code in wlcore_nvs_cb() Delete an unnecessary check statement in

[iproute PATCH 3/3] ss: Fix width calculations when Netid or State columns are missing

If Netid or State columns are missing, we must not subtract one for each of these two columns from the remaining screen width, while distributing available space to columns. This one character corresponding to one delimiting space has to be subtracted only if the columns are actually printed.

[iproute PATCH 0/3] ss: netlink_show_one() clean-up, minor output fix

Patches 1/3 and 2/3 streamline process context prints in netlink_show_one(). Patch 3/3 fixes a display issue happening when Netid or State columns are not displayed. In general, the output layout of 'ss', also in the cases handled here, still has a number of issues. I will address further issues

[iproute PATCH 1/3] ss: Remove useless width specifier in process context print

Both local address and service, and remote address and service fields are already printed out in netlink_show_one() before we start printing process context, by calling sock_addr_print() twice. At this point, sock_addr_print() has already forced the remote service field to be 'serv_width' wide --

[iproute PATCH 2/3] ss: Streamline process context printing in netlink_show_one()

There's no need to check 'pid_context' before calling free(). Signed-off-by: Stefano Brivio --- misc/ss.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index fa026eb0934b..fb80d84122fc 100644 --- a/misc/ss.c +++ b/misc/ss.c

Re: [RFC] please clarify local_irq_disable() in pcpu_freelist_populate()

On 10/29/17 1:14 PM, Sebastian Andrzej Siewior wrote: On 2017-10-27 19:18:40 [-0700], Alexei Starovoitov wrote: pcpu_freelist_push() is called by bpf programs from atomic context. so raw would still be correct because the content is locked. it would be incorrect because this_* versions have

[PATCH iproute2 net-next] ip: link_ip6tnl.c/ip6tunnel.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOTE flag

From: Shmulik Ladkani IP6_TNL_F_ALLOW_LOCAL_REMOTE allows tunnel traffic on ip6tnl devices where the remote endpoint is a local host address. Specifying "[no]allow-localremote" controls the IP6_TNL_F_ALLOW_LOCAL_REMOTE flag on ip6tnl interfaces. This is the

Re: [PATCH net-next 11/14] bnxt_en: add support for Flower based vxlan encap/decap offload

Hi Sathya, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Michael-Chan/bnxt_en-Updates-for-net-next/20171029-105709 config: x86_64-randconfig-it0-10300113 (attached as .config) compiler: gcc-4.9

[PATCH] wimax/i2400m: Use common error handling code in i2400m_wake_tx_work()

From: Markus Elfring Date: Sun, 29 Oct 2017 18:00:17 +0100 Adjust jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

I wait for your prompt response.

Good day, I am Mr. Sam Azada from Burkina Faso a Minister confide on me to look for foreign partner who will assist him to invest the sum of Fifty Million Dollars ($50,000,000) in your country. He has investment interest in mining, exotic properties for commercial resident, development

Re: v6/sit tunnels and VRFs

On 10/27/17 8:43 PM, Jeff Barnhill wrote: > ping v4 loopback... > > jeff@VM2:~$ ip route list vrf myvrf > 127.0.0.0/8 dev myvrf proto kernel scope link src 127.0.0.1 > 192.168.200.0/24 via 192.168.210.3 dev enp0s8 > 192.168.210.0/24 dev enp0s8 proto kernel scope link src 192.168.210.2 > >

Re: [PATCH net-next 11/14] bnxt_en: add support for Flower based vxlan encap/decap offload

On Sun, Oct 29, 2017 at 11:22 AM, kbuild test robot wrote: > All warnings (new ones prefixed by >>): > >drivers/net//ethernet/broadcom/bnxt/bnxt_tc.c: In function > 'bnxt_tc_resolve_tunnel_hdrs': >drivers/net//ethernet/broadcom/bnxt/bnxt_tc.c:882:10: error: implicit >

[PATCH 4/5] wlcore: Use common error handling code in wlcore_set_beacon_template()

From: Markus Elfring Date: Sun, 29 Oct 2017 20:16:22 +0100 Adjust jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: [PATCH net-next] hv_netvsc: Set tx_table to equal weight after subchannels open

From: Haiyang Zhang Date: Sun, 29 Oct 2017 20:38:59 + > Could you please also queue it for net 4.14 and stable? This is not how you are supposed to handle things. When you have a bug fix you submit the fix for 'net' and then ask for it to be queued up for -stable.

Re: [PATCH net-next v13] openvswitch: enable NSH support

From: Yi Yang Date: Thu, 26 Oct 2017 15:45:16 +0800 > OVS master and 2.8 branch has merged NSH userspace > patch series, this patch is to enable NSH support > in kernel data path in order that OVS can support > NSH in compat mode by porting this. > > Signed-off-by: Yi Yang

Re: [PATCH net-next v13] openvswitch: enable NSH support

On Mon, Oct 30, 2017 at 10:01:34AM +0900, David Miller wrote: > From: Yi Yang > Date: Thu, 26 Oct 2017 15:45:16 +0800 > > > OVS master and 2.8 branch has merged NSH userspace > > patch series, this patch is to enable NSH support > > in kernel data path in order that OVS can

Re: [PATCH net-next 1/2] enic: reset fetch index

Hi Parvi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Parvi-Kaustubhi/enic-reset-fetch-index/20171029-102819 config: x86_64-randconfig-b0-10300925 (attached as .config) compiler: gcc-4.4

[PATCH 5/5] wlcore: Use common error handling code in wl1271_op_suspend()

From: Markus Elfring Date: Sun, 29 Oct 2017 20:36:39 +0100 Add a jump target so that a specific error message is stored only once at the end of this function implementation. Replace two calls of the macro "wl1271_warning" by goto statements. This issue was

[PATCH 2/5] wlcore: Delete an unnecessary check statement in wlcore_set_beacon_template()

From: Markus Elfring Date: Sun, 29 Oct 2017 19:45:07 +0100 A goto statement jumped to a target which followed a condition check immediately without the specification of useful actions between. Thus remove such unnecessary source code at the end of this function.

[PATCH 1/5] wlcore: Use common error handling code in wlcore_nvs_cb()

From: Markus Elfring Date: Sun, 29 Oct 2017 18:38:04 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: [RFC] please clarify local_irq_disable() in pcpu_freelist_populate()

On 2017-10-27 19:18:40 [-0700], Alexei Starovoitov wrote: > pcpu_freelist_push() is called by bpf programs from atomic context. so raw would still be correct because the content is locked. > lockdep thinks that __pcpu_freelist_push() can be called recursively > in the middle of

[PATCH 3/5] wlcore: Return directly after a failed ieee80211_beacon_get() in wlcore_set_beacon_template()

From: Markus Elfring Date: Sun, 29 Oct 2017 20:00:41 +0100 Return directly after a call of the function "ieee80211_beacon_get" failed at the beginning. Signed-off-by: Markus Elfring --- drivers/net/wireless/ti/wlcore/main.c | 6

Re: [REGRESSION, BISECTED] Broken networking with net/phy/marvell

Hi, On Sat, Oct 28, 2017 at 09:01:39PM +0200, Andrew Lunn wrote: > On Thu, Oct 26, 2017 at 03:28:36PM +0300, Aaro Koskinen wrote: > > When upgrading from v4.13 to v4.14-rc6 on OpenRD Client, the box loses > > network connectivity. > > What exactly is the PHY in the OpenRD? 88E1116R. > Please

[PATCH net-next v14] openvswitch: enable NSH support

v13->v14 - Rename skb_push_nsh to nsh_push per Dave's comment - Rename skb_pop_nsh to nsh_pop per Dave's comment v12->v13 - Fix NSH header length check in set_nsh v11->v12 - Fix missing changes old comments pointed out - Fix new comments for v11 v10->v11 - Fix the left three disputable

Re: [RFC PATCH v10 0/7] PCI: rockchip: Move PCIe WAKE# handling into pci core

Hi Rafael, thanks for your reply. On 10/28/2017 05:07 PM, Rafael J. Wysocki wrote: Overall, I don't quite like the direction this is going into, but I need to have a deeper look. Which may take some time, so please bear with me. ok, i'll wait for your comments, thanks :) Thanks, Rafael