Re: [PATCH 26/31] nds32: Build infrastructure

2017-11-10 Thread Greentime Hu
2017-11-09 18:33 GMT+08:00 Arnd Bergmann : > On Thu, Nov 9, 2017 at 10:02 AM, Greentime Hu wrote: >> 2017-11-08 18:16 GMT+08:00 Arnd Bergmann : >>> On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: > +config

Re: [PATCH net-next] bindings: net: stmmac: correctify note about LPI interrupt

2017-11-10 Thread Alexandre Torgue
On 11/09/2017 06:09 PM, Niklas Cassel wrote: There are two different combined signal for various interrupt events: In EQOS-CORE and EQOS-MTL configurations, mci_intr_o is the interrupt signal. In EQOS-DMA, EQOS-AHB and EQOS-AXI configurations, these interrupt events are combined with the

RE: [PATCH net-next v2 1/3] net: bgmac: Pad packets to a minimum size

2017-11-10 Thread David Laight
From: Florian Fainelli > Sent: 09 November 2017 22:35 > > In preparation for enabling Broadcom tags with b53, pad packets to a > minimum size of 64 bytes (sans FCS) in order for the Broadcom switch to > accept ingressing frames. Without this, we would typically be able to > DHCP, but not resolve

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

2017-11-10 Thread Egil Hjelmeland
On 09. nov. 2017 14:24, Andrew Lunn wrote: What should also be considered is who is pushing swithdev and DSA forward, and for what market. Pure switchdev drivers is mostly being pushed forward for Top or Rack switches. Big switches, 10G, 40G, 100G ports and lots of them. L3 routing, etc.

Re: [PATCH net] tcp: fix tcp_fastretrans_alert warning

2017-11-10 Thread David Miller
From: Yuchung Cheng Date: Tue, 7 Nov 2017 15:33:43 -0800 > This patch fixes the cause of an WARNING indicatng TCP has pending > retransmission in Open state in tcp_fastretrans_alert(). > > The root cause is a bad interaction between path mtu probing, > if enabled, and the

Re: [PATCH 1/2] bpf: add a bpf_override_function helper

2017-11-10 Thread Ingo Molnar
* Josef Bacik wrote: > @@ -551,6 +578,10 @@ static const struct bpf_func_proto > *kprobe_prog_func_proto(enum bpf_func_id func > return _get_stackid_proto; > case BPF_FUNC_perf_event_read_value: > return _perf_event_read_value_proto; > +

Re: [RFC] hv_netvsc: safer orderly shutdown

2017-11-10 Thread Vitaly Kuznetsov
Stephen Hemminger writes: > Several types of control operations require that the underlying RNDIS > infrastructure be restarted. This patch changes the ordering of the > shutdown to avoid race conditions. > Stop all transmits before doing RNDIS halt. This involves

Re: [Patch net] vlan: fix a use-after-free in vlan_device_event()

2017-11-10 Thread Fengguang Wu
It works, thank you for fixing this ancient bug! Tested-by: Fengguang Wu

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-10 Thread David Miller
From: Alexei Starovoitov Date: Wed, 8 Nov 2017 06:43:25 +0900 > looks great to me. > Peter, > could you please review x86 bits? I'm still waiting for this.

[PATCH net-next 0/2] net: dsa: lan9303: IGMP handling

2017-11-10 Thread Egil Hjelmeland
Set up the HW switch to trap IGMP packets to CPU port. And make sure skb->offload_fwd_mark is cleared for incoming IGMP packets. skb->offload_fwd_mark calculation is a candidate for consolidation into the DSA core. The calculation can probably be more polished when done at a point where DSA has

[PATCH net-next 1/2] net: dsa: lan9303: Set up trapping of IGMP to CPU port

2017-11-10 Thread Egil Hjelmeland
IGMP packets should be trapped to the CPU port. The SW bridge knows whether to forward to other ports. With "IGMP snooping for local traffic" merged, IGMP trapping is also required for stable IGMPv2 operation. LAN9303 does not trap IGMP packets by default. Enable IGMP trapping in lan9303_setup.

[PATCH net-next 2/2] net: dsa: lan9303: Clear offload_fwd_mark for IGMP

2017-11-10 Thread Egil Hjelmeland
Now that IGMP packets no longer is flooded in HW, we want the SW bridge to forward packets based on bridge configuration. To make that happen, IGMP packets must have skb->offload_fwd_mark = 0. Signed-off-by: Egil Hjelmeland --- net/dsa/tag_lan9303.c | 13 +

Re: [PATCH] net: qcom/emac: fix the error of tpd buff address valid bit

2017-11-10 Thread Timur Tabi
On 11/10/17 3:49 AM, Wang Dongsheng wrote: TPD has 46-bits as buff address valid bit. So fix the buff address from 45-bits to 46-bits. NAK. The TPD has 45 bits. Why do you say it was 46? -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm

Re: [PATCH net] net: fix incorrect comment with regard to VLAN packet handling

2017-11-10 Thread David Miller
From: Girish Moodalbail Date: Tue, 7 Nov 2017 11:32:11 -0800 > The commit bcc6d4790361 ("net: vlan: make non-hw-accel rx path similar > to hw-accel") unified accel and non-accel path for VLAN RX. With that > fix we do not register any packet_type handler for VLANs

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

2017-11-10 Thread Roman Yeryomin
On 2017-11-09 19:24, Andrew Lunn wrote: The registers writing code is where? switchdev driver? All I care about is that all the switch specific code should be in one place. The switch specific code is in the switch specific driver. Take a look under drivers/net/dsa for the switches which are

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

2017-11-10 Thread Roman Yeryomin
On 2017-11-09 20:08, Florian Fainelli wrote: On 11/09/2017 09:24 AM, Andrew Lunn wrote: The registers writing code is where? switchdev driver? All I care about is that all the switch specific code should be in one place. The switch specific code is in the switch specific driver. Take a

[net V2 3/5] net/mlx5e: Fix napi poll with zero budget

2017-11-10 Thread Saeed Mahameed
napi->poll can be called with budget 0, e.g. in netpoll scenarios where the caller only wants to poll TX rings (poll_one_napi@net/core/netpoll.c). The below commit changed RX polling from "while" loop to "do {} while", which caused to ignore the initial budget and handle at least one RX packet.

[net V2 1/5] net/mlx5: Loop over temp list to release delay events

2017-11-10 Thread Saeed Mahameed
From: Huy Nguyen list_splice_init initializing waiting_events_list after splicing it to temp list, therefore we should loop over temp list to fire the events. Fixes: 4ca637a20a52 ("net/mlx5: Delay events till mlx5 interface's add complete for pci resume") Signed-off-by: Huy

[pull request][net V2 0/5] Mellanox, mlx5 fixes 2017-11-08

2017-11-10 Thread Saeed Mahameed
Hi Dave, The follwoing series includes some fixes for mlx5 core and etherent driver. Sorry for the late submission but as you can see i have some very critical fixes below that i would like them merged into this RC. Please pull and let me know if there is any problem. For -stable:

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-10 Thread Peter Zijlstra
On Wed, Nov 08, 2017 at 06:43:25AM +0900, Alexei Starovoitov wrote: > On 11/8/17 5:28 AM, Josef Bacik wrote: > > I'm sending this through Dave since it'll conflict with other BPF changes > > in his > > tree, but since it touches tracing as well Dave would like a review from > > somebody on the

[PATCH net-next] net/mlx4: Use Kconfig flag to remove support of old gen2 Mellanox devices

2017-11-10 Thread Tariq Toukan
From: Slava Shwartsman Since Mellanox focus is on newer adapters, we would like to have the ability to disable the support for old gen2 adapters. This can be done by turning off the MLX4_CORE_GEN2 Kconfig flag. We keep it turned on by default. Signed-off-by: Slava

Re: [PATCH] net: mvneta: fix handling of the Tx descriptor counter

2017-11-10 Thread Sven Müller
Hi Simon, Until now it seems to work. No issues so far. Regards and Thanks Sven Am Thu, 9 Nov 2017 20:19:42 +0100 schrieb Andreas Tobler : > Hi Simon, > > > On 08.11.17 18:17, Simon Guinot wrote: > > Hi Sven and Andreas, > > > > Please, can you try with

Re: [PATCH net-next v7 0/3] nfp act_vlan: Rewrite of the TC vlan action to use the RCU, and incorporated review comments

2017-11-10 Thread Manish Kurup
Hi Dave, On Fri, Nov 10, 2017 at 12:53 AM, David Miller wrote: > From: Manish Kurup > Date: Tue, 7 Nov 2017 08:50:00 -0500 > >> This commit consists of 3 patches: >> >> patch1 (1/3): >> The VLAN action maintains one set of stats across all cores,

[net V2 4/5] net/mlx5e: Set page to null in case dma mapping fails

2017-11-10 Thread Saeed Mahameed
From: Inbar Karmy Currently, when dma mapping fails, put_page is called, but the page is not set to null. Later, in the page_reuse treatment in mlx5e_free_rx_descs(), mlx5e_page_release() is called for the second time, improperly doing dma_unmap (for a non-mapped address)

[net V2 2/5] net/mlx5: Cancel health poll before sending panic teardown command

2017-11-10 Thread Saeed Mahameed
From: Huy Nguyen After the panic teardown firmware command, health_care detects the error in PCI bus and calls the mlx5_pci_err_detected. This health_care flow is no longer needed because the panic teardown firmware command will bring down the PCI bus communication with the

[net V2 5/5] net/mlx5e: Increase Striding RQ minimum size limit to 4 multi-packet WQEs

2017-11-10 Thread Saeed Mahameed
From: Eugenia Emantayev This is to prevent the case of working with a single MPWQE (1 WQE is always reserved as RQ is linked-list). When the WQE is fully consumed, HW should still have available buffer in order not to drop packets. Fixes: 461017cb006a ("net/mlx5e: Support

[PATCH] net: qcom/emac: fix the error of tpd buff address valid bit

2017-11-10 Thread Wang Dongsheng
From: Wang Dongsheng TPD has 46-bits as buff address valid bit. So fix the buff address from 45-bits to 46-bits. Signed-off-by: Wang Dongsheng diff --git a/drivers/net/ethernet/qualcomm/emac/emac-mac.h b/drivers/net/ethernet/qualcomm/emac/emac-mac.h

Re: [PATCH 30/31] dt-bindings: nds32 CPU Bindings

2017-11-10 Thread Arnd Bergmann
On Fri, Nov 10, 2017 at 7:22 AM, Greentime Hu wrote: > 2017-11-09 21:57 GMT+08:00 Rob Herring : >> On Thu, Nov 9, 2017 at 3:39 AM, Greentime Hu wrote: >>> 2017-11-08 21:18 GMT+08:00 Rob Herring : Please Cc the DT

Re: [PATCH 30/31] dt-bindings: nds32 CPU Bindings

2017-11-10 Thread Greentime Hu
>>> Then having both is not valid. The strings should be in order of best >>> match to worst match where worst match is typically either older >>> implementations of IP blocks or generic'ish strings such as "ns16550" >>> for a UART. >> >> Thanks. >> I would like to explain it more clearly. >> They

Re: [PATCH net] tcp: gso: avoid refcount_t warning from tcp_gso_segment()

2017-11-10 Thread David Miller
From: Eric Dumazet Date: Tue, 07 Nov 2017 15:15:04 -0800 > From: Eric Dumazet > > When a GSO skb of truesize O is segmented into 2 new skbs of truesize N1 > and N2, we want to transfer socket ownership to the new fresh skbs. > > In order to avoid

[PATCH] socket: add THIS_MODULE to sock_fs_type.

2017-11-10 Thread Tonghao Zhang
As important member of file_system_type, we set ->owner for sock_fs_type. Signed-off-by: Tonghao Zhang --- net/socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/socket.c b/net/socket.c index c729625..b085f14 100644 --- a/net/socket.c +++

pull-request: can 2017-11-10

2017-11-10 Thread Marc Kleine-Budde
(2017-11-10 14:54:47 +0900) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-4.14-20171110 for you to fetch changes up to 4f7116757b4bd99e4ef2636c7d957a6d63035d11: can: ifi: Fix transmitter delay calculation

[PATCH 1/4] can: c_can: don't indicate triple sampling support for D_CAN

2017-11-10 Thread Marc Kleine-Budde
From: Richard Schütz The D_CAN controller doesn't provide a triple sampling mode, so don't set the CAN_CTRLMODE_3_SAMPLES flag in ctrlmode_supported. Currently enabling triple sampling is a no-op. Signed-off-by: Richard Schütz Cc: linux-stable

[PATCH 4/4] can: ifi: Fix transmitter delay calculation

2017-11-10 Thread Marc Kleine-Budde
From: Marek Vasut The CANFD transmitter delay calculation formula was updated in the latest software drop from IFI and improves the behavior of the IFI CANFD core during bitrate switching. Use the new formula to improve stability of the CANFD operation. Signed-off-by: Marek Vasut

[PATCH 2/4] can: sun4i: handle overrun in RX FIFO

2017-11-10 Thread Marc Kleine-Budde
From: Gerhard Bertelsmann SUN4Is CAN IP has a 64 byte deep FIFO buffer. If the buffer is not drained fast enough (overrun) it's getting mangled. Already received frames are dropped - the data can't be restored. Signed-off-by: Gerhard Bertelsmann

[PATCH 3/4] can: peak: Add support for new PCIe/M2 CAN FD interfaces

2017-11-10 Thread Marc Kleine-Budde
From: Stephane Grosjean This adds support for the following PEAK-System CAN FD interfaces: PCAN-cPCIe FD CAN FD Interface for cPCI Serial (2 or 4 channels) PCAN-PCIe/104-Express CAN FD Interface for PCIe/104-Express (1, 2 or 4 ch.) PCAN-miniPCIe FD CAN

Re: [PATCH net-next 1/2] net: dsa: lan9303: Set up trapping of IGMP to CPU port

2017-11-10 Thread Andrew Lunn
On Fri, Nov 10, 2017 at 12:54:34PM +0100, Egil Hjelmeland wrote: > IGMP packets should be trapped to the CPU port. The SW bridge knows > whether to forward to other ports. > > With "IGMP snooping for local traffic" merged, IGMP trapping is also > required for stable IGMPv2 operation. > > LAN9303

Re: [PATCH] socket: add THIS_MODULE to sock_fs_type.

2017-11-10 Thread David Miller
From: Tonghao Zhang Date: Fri, 10 Nov 2017 04:47:58 -0800 > As important member of file_system_type, we set > ->owner for sock_fs_type. > > Signed-off-by: Tonghao Zhang The value of THIS_MODULE is always NULL in this file. Sorry, I'm

Re: [PATCH net-next 0/2] net: dsa: lan9303: IGMP handling

2017-11-10 Thread Andrew Lunn
> skb->offload_fwd_mark calculation is a candidate for consolidation into the > DSA core. The calculation can probably be more polished when done at a point > where DSA has updated skb. Hi Egil Yes, at some point we should do this. But at the moment it is too early. We don't have enough

Re: [PATCH] net: qcom/emac: fix the error of tpd buff address valid bit

2017-11-10 Thread Timur Tabi
On 11/10/2017 07:24 AM, Wang, Dongsheng wrote: On QDF2400, EMAC TPD buff address size is [45:0]. buff address_l [31:0], buff address_h [31:18]. The address_h should change from [30:18] to [31:18]. So TPD buff address should has 46bits. Bit 31 of the Word 3 in the TPD is the Timestamp_save.

Re: [PATCH 12/31] nds32: Device specific operations

2017-11-10 Thread Greentime Hu
2017-11-09 15:04 GMT+08:00 Greentime Hu : > 2017-11-08 17:04 GMT+08:00 Arnd Bergmann : >> On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: >> >>> + >>> +#define ioremap(cookie,size) __ioremap(cookie,size,0,1) >>> +#define

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

2017-11-10 Thread Andrew Lunn
> Out of curiosity: Are there fundamental reasons why ToR switches don't use > the DSA model, or is it more historical? Yes, there is a fundamental reason. https://www.netdevconf.org/2.1/session.html?lunn_didelot_fainelli DSA always has a host Ethernet interface connected to a port of the

Re: [PATCH 0/4] make function arg and structures as const

2017-11-10 Thread Anna Schumaker
On 11/09/2017 09:21 PM, J. Bruce Fields wrote: > On Tue, Oct 17, 2017 at 12:40:27PM -0400, Jeff Layton wrote: >> On Tue, 2017-10-17 at 18:14 +0200, Bhumika Goyal wrote: >>> Make the function argument as const. After thing change, make >>> the cache_detail structures as const. >>> >>> Bhumika

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

2017-11-10 Thread Oleksandr Natalenko
Hi. I'm running the machine with this patch applied for 7 hours now, and the warning hasn't appeared yet. Typically, it should be there within the first hour. I'll keep an eye on it for a longer time, but as of now it looks good. Some explanation on this please? Thanks! 06.11.2017 23:27,

Re: [PATCH] net: qcom/emac: fix the error of tpd buff address valid bit

2017-11-10 Thread Wang, Dongsheng
Hey, Timur, On 2017/11/10 20:57, Timur Tabi wrote: On 11/10/17 3:49 AM, Wang Dongsheng wrote: TPD has 46-bits as buff address valid bit. So fix the buff address from 45-bits to 46-bits. NAK. The TPD has 45 bits.  Why do you say it was 46? On QDF2400, EMAC TPD buff address size is [45:0].

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

2017-11-10 Thread Oleksandr Natalenko
Uhh, sorry, just found the original submission [1]. [1] https://marc.info/?l=linux-netdev=151009763926816=2 10.11.2017 14:15, Oleksandr Natalenko wrote: Hi. I'm running the machine with this patch applied for 7 hours now, and the warning hasn't appeared yet. Typically, it should be there

Re: [PATCH net-next v7 0/3] nfp act_vlan: Rewrite of the TC vlan action to use the RCU, and incorporated review comments

2017-11-10 Thread David Miller
From: Manish Kurup Date: Fri, 10 Nov 2017 07:30:09 -0500 > The last version I sent out (with changes for comments), was v10, But > I noticed that you applied v7 (without the reverse xmas tree patch on > patch #3). Check my tree, I actually applied a later version than

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

2017-11-10 Thread Andrew Lunn
> OK, so looks like DSA is actually what I need. I just didn't see a clear > implementation path for e.g. ACL functions. > Correct me if I'm wrong, to add support for ar8327 ACL or port rate control > I should expand struct dsa_switch_ops, add appropriate infrastructure in > netfilter/tc

Re: [PATCH] tcp: Export to userspace the TCP state names for the trace events

2017-11-10 Thread Steven Rostedt
On Fri, 10 Nov 2017 12:56:06 +0800 Yafang Shao wrote: > Could the macro tcp_state_name() be renamed ? > If is included in include/net/tcp.h, it will Ideally, you don't want to include trace/events/*.h headers in other headers, as they can have side effects if those

Re: [RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ]

2017-11-10 Thread Thomas Gleixner
On Fri, 10 Nov 2017, Saeed Mahameed wrote: > Well, I can speak for mlx5 case or most of the network drivers, where > all of the queues associated with an interrupt, move with it, so i > don't think our current driver have this issue. I don't believe there > are network driver with fixed Per cpu

Re: [PATCH] [net-next,v3] ibmvnic: Feature implementation of Vital Product Data (VPD) for the ibmvnic driver

2017-11-10 Thread Desnes Augusto Nunes do Rosário
On 11/09/2017 06:31 PM, Nathan Fontenot wrote: On 11/09/2017 01:00 PM, Desnes Augusto Nunes do Rosario wrote: This patch implements and enables VDP support for the ibmvnic driver. Moreover, it includes the implementation of suitable structs, signal transmission/handling and functions which

Re: [PATCH] [net-next,v3] ibmvnic: Feature implementation of Vital Product Data (VPD) for the ibmvnic driver

2017-11-10 Thread Nathan Fontenot
On 11/10/2017 08:41 AM, Desnes Augusto Nunes do Rosário wrote: > > > On 11/09/2017 06:31 PM, Nathan Fontenot wrote: >> On 11/09/2017 01:00 PM, Desnes Augusto Nunes do Rosario wrote: >>> This patch implements and enables VDP support for the ibmvnic driver. >>> Moreover, it includes the

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-10 Thread kaiwan . billimoria
On Tue, 2017-11-07 at 21:32 +1100, Tobin C. Harding wrote: > Currently we are leaking addresses from the kernel to user space. > This > script is an attempt to find some of those leakages. Script parses > `dmesg` output and /proc and /sys files for hex strings that look > like > kernel addresses.

Re: [PATCH] uprobes/x86: emulate push insns for uprobe on x86

2017-11-10 Thread Oleg Nesterov
Yonghong, The patch looks good to me, but I'll try to read it carefully later. Just a couple of cosmetic nits for now. On 11/09, Yonghong Song wrote: > > --- a/arch/x86/include/asm/uprobes.h > +++ b/arch/x86/include/asm/uprobes.h > @@ -53,6 +53,10 @@ struct arch_uprobe { >

Re: [PATCH net-next v2 1/3] net: bgmac: Pad packets to a minimum size

2017-11-10 Thread Florian Fainelli
On 11/10/2017 03:10 AM, David Laight wrote: > From: Florian Fainelli >> Sent: 09 November 2017 22:35 >> >> In preparation for enabling Broadcom tags with b53, pad packets to a >> minimum size of 64 bytes (sans FCS) in order for the Broadcom switch to >> accept ingressing frames. Without this, we

Re: [PATCH net-next v2 0/3] net: dsa: b53: Turn on Broadcom tags

2017-11-10 Thread Florian Fainelli
On 11/09/2017 02:34 PM, Florian Fainelli wrote: > Hi all, > > This was long overdue, with this patch series, the b53 driver now > turns on Broadcom tags except for 5325 and 5365 which use an older > format that we do not support yet (TBD). > > First patch is necessary in order for bgmac, used on

Re: KASAN: use-after-free Read in worker_thread (2)

2017-11-10 Thread Cong Wang
On Wed, Nov 8, 2017 at 5:00 AM, Dmitry Vyukov wrote: > On Wed, Nov 8, 2017 at 1:58 PM, syzbot > > wrote: >> Hello, >> >> syzkaller hit the following crash on >> 7dfaa7bc99498da1c6c4a48bee8d2d5265161a8c >>

Re: [PATCH 12/31] nds32: Device specific operations

2017-11-10 Thread Arnd Bergmann
On Fri, Nov 10, 2017 at 5:07 PM, Greentime Hu wrote: > 2017-11-09 15:04 GMT+08:00 Greentime Hu : >> 2017-11-08 17:04 GMT+08:00 Arnd Bergmann : >>> On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: >>> +

Re: [PATCH] tcp: Export to userspace the TCP state names for the trace events

2017-11-10 Thread Song Liu
> On Nov 10, 2017, at 7:07 AM, Steven Rostedt wrote: > > On Fri, 10 Nov 2017 12:56:06 +0800 > Yafang Shao wrote: > >> Could the macro tcp_state_name() be renamed ? >> If is included in include/net/tcp.h, it will > > Ideally, you don't want to

Re: [PATCH net-next] bpf: add support for SO_PRIORITY in bpf_getsockopt

2017-11-10 Thread Vlad Dumitrescu
On Thu, Nov 9, 2017 at 4:43 PM, Alexei Starovoitov wrote: > On 11/10/17 8:04 AM, Vlad Dumitrescu wrote: >> >> From: Vlad Dumitrescu >> >> Allows BPF_PROG_TYPE_SOCK_OPS programs to read sk_priority. >> >> Signed-off-by: Vlad Dumitrescu >> --- >>

Re: [PATCH net-next 0/2] net: dsa: lan9303: IGMP handling

2017-11-10 Thread Egil Hjelmeland
Den 10. nov. 2017 15:07, skrev Andrew Lunn: skb->offload_fwd_mark calculation is a candidate for consolidation into the DSA core. The calculation can probably be more polished when done at a point where DSA has updated skb. Hi Egil Yes, at some point we should do this. But at the moment it

Re: [net-next v4 4/4] openvswitch: Add meter action support

2017-11-10 Thread Andy Zhou
On Thu, Nov 9, 2017 at 12:50 AM, Pravin Shelar wrote: > On Thu, Nov 9, 2017 at 11:00 AM, Andy Zhou wrote: >> Implements OVS kernel meter action support. >> >> Signed-off-by: Andy Zhou >> --- > I could not apply this patch on latest net-next. I will

Re: [PATCH 1/2] bpf: add a bpf_override_function helper

2017-11-10 Thread Josef Bacik
On Fri, Nov 10, 2017 at 10:34:59AM +0100, Ingo Molnar wrote: > > * Josef Bacik wrote: > > > @@ -551,6 +578,10 @@ static const struct bpf_func_proto > > *kprobe_prog_func_proto(enum bpf_func_id func > > return _get_stackid_proto; > > case

[PATCH][v2] uprobes/x86: emulate push insns for uprobe on x86

2017-11-10 Thread Yonghong Song
Uprobe is a tracing mechanism for userspace programs. Typical uprobe will incur overhead of two traps. First trap is caused by replaced trap insn, and the second trap is to execute the original displaced insn in user space. To reduce the overhead, kernel provides hooks for architectures to

Re: [PATCH] [net-next,v3] ibmvnic: Feature implementation of Vital Product Data (VPD) for the ibmvnic driver

2017-11-10 Thread Desnes Augusto Nunes do Rosário
On 11/10/2017 12:54 PM, Nathan Fontenot wrote: On 11/10/2017 08:41 AM, Desnes Augusto Nunes do Rosário wrote: On 11/09/2017 06:31 PM, Nathan Fontenot wrote: On 11/09/2017 01:00 PM, Desnes Augusto Nunes do Rosario wrote: This patch implements and enables VDP support for the ibmvnic driver.

Re: Secure Server Message

2017-11-10 Thread Webmail Internet Service
Warning!!! Account Owner Upgrade is needed by our member use due to network error, Your email was detected by Unknown IP Address 712.54.5.837 and We discovered something unusual about your email account in our computer date-base System. For Security reasons to enable automatic clean up to

[net-next v5 2/4] openvswitch: export get_dp() API.

2017-11-10 Thread Andy Zhou
Later patches will invoke get_dp() outside of datapath.c. Export it. Signed-off-by: Andy Zhou --- net/openvswitch/datapath.c | 29 - net/openvswitch/datapath.h | 31 +++ 2 files changed, 31 insertions(+), 29 deletions(-)

[net-next v5 3/4] openvswitch: Add meter infrastructure

2017-11-10 Thread Andy Zhou
OVS kernel datapath so far does not support Openflow meter action. This is the first stab at adding kernel datapath meter support. This implementation supports only drop band type. Signed-off-by: Andy Zhou --- net/openvswitch/Makefile | 1 + net/openvswitch/datapath.c | 14

[net-next v5 1/4] openvswitch: Add meter netlink definitions

2017-11-10 Thread Andy Zhou
Meter has its own netlink family. Define netlink messages and attributes for communicating with the user space programs. Signed-off-by: Andy Zhou --- include/uapi/linux/openvswitch.h | 51 1 file changed, 51 insertions(+) diff --git

[net-next v5 0/4] Openvswitch meter action

2017-11-10 Thread Andy Zhou
This patch series is the first attempt to add openvswitch meter support. We have previously experimented with adding metering support in nftables. However 1) It was not clear how to expose a named nftables object cleanly, and 2) the logic that implements metering is quite small, < 100 lines of

[net-next v5 4/4] openvswitch: Add meter action support

2017-11-10 Thread Andy Zhou
Implements OVS kernel meter action support. Signed-off-by: Andy Zhou --- include/uapi/linux/openvswitch.h | 3 +++ net/openvswitch/actions.c| 6 ++ net/openvswitch/datapath.h | 1 + net/openvswitch/flow_netlink.c | 6 ++ 4 files changed, 16 insertions(+)

Re: [PATCH v2 5/6] firmware: Add request_firmware_prefer_user() function

2017-11-10 Thread Luis R. Rodriguez
On Fri, Nov 10, 2017 at 12:38:27AM +0100, Pali Rohár wrote: > This function works pretty much like request_firmware(), but it prefer > usermode helper. If usermode helper fails then it fallback to direct > access. Useful for dynamic or model specific firmware data. > > Signed-off-by: Pali Rohár

Re: [PATCH net-next v3 1/3] net: bgmac: Pad packets to a minimum size

2017-11-10 Thread Andrew Lunn
On Fri, Nov 10, 2017 at 11:33:25AM -0800, Florian Fainelli wrote: > In preparation for enabling Broadcom tags with b53, pad packets to a > minimum size of 64 bytes (sans FCS) in order for the Broadcom switch to > accept ingressing frames. Without this, we would typically be able to > DHCP, but not

Re: [PATCH v2 5/6] firmware: Add request_firmware_prefer_user() function

2017-11-10 Thread Pali Rohár
On Friday 10 November 2017 21:26:01 Luis R. Rodriguez wrote: > On Fri, Nov 10, 2017 at 12:38:27AM +0100, Pali Rohár wrote: > > This function works pretty much like request_firmware(), but it prefer > > usermode helper. If usermode helper fails then it fallback to direct > > access. Useful for

[PATCH net-next] bpf: expose sk_priority through struct bpf_sock_ops

2017-11-10 Thread Vlad Dumitrescu
From: Vlad Dumitrescu Allows BPF_PROG_TYPE_SOCK_OPS programs to read sk_priority. Signed-off-by: Vlad Dumitrescu --- include/uapi/linux/bpf.h | 1 + net/core/filter.c | 11 +++ tools/include/uapi/linux/bpf.h | 1 + 3 files

Re: [PATCH iproute2 2/2] devlink: add batch command support

2017-11-10 Thread Leon Romanovsky
On Fri, Nov 10, 2017 at 08:10:43AM +0100, Ivan Vecera wrote: > On 10.11.2017 07:57, Leon Romanovsky wrote: > > On Fri, Nov 10, 2017 at 07:20:14AM +0100, Ivan Vecera wrote: > >> The patch adds support to batch devlink commands. > >> > >> Cc: Jiri Pirko > >> Cc: Arkadi

Re: [PATCH net-next v3 2/3] net: dsa: b53: Stop using dev->cpu_port incorrectly

2017-11-10 Thread Andrew Lunn
On Fri, Nov 10, 2017 at 11:33:26AM -0800, Florian Fainelli wrote: > dev->cpu_port is the driver local information that should only be used > to look up register offsets for a particular port, when they differ > (e.g: IMP port override), but it should certainly not be used in place > of the DSA

Re: [Patch net] vlan: fix a use-after-free in vlan_device_event()

2017-11-10 Thread Linus Torvalds
On Fri, Nov 10, 2017 at 3:50 AM, Fengguang Wu wrote: > It works, thank you for fixing this ancient bug! > > Tested-by: Fengguang Wu Thanks for all the 0day work to make people finally figure this out. Linus

Re:Partnership Request.

2017-11-10 Thread Albrecht Lutz
Good day My name is Lutz Albrecht, an attorney, I have searched for several years to locate any possible relative of a late client of mine who died intestate but left a huge financial estate. I am contacting you because you have the same last name to present you as the beneficiary of the

[PATCH net-next 6/6] bpf: Fix tcp_clamp_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: 6c4a01b27852 ("bpf: Sample bpf program to set sndcwnd clamp") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_clamp_kern.c | 24 +--- 1 file changed, 13

Re: [PATCH net-next 1/6] bpf: Fix tcp_synrto_kern.c sample program

2017-11-10 Thread Daniel Borkmann
On 11/10/2017 09:42 PM, Lawrence Brakmo wrote: The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: 8550f328f45d ("bpf: Support for per connection SYN/SYN-ACK RTOs") Hmm, for most of the series (if not all), I think Fixes tag is: 390ee7e29fc8

Re: [run_timer_softirq] BUG: unable to handle kernel paging request at 0000000000010007

2017-11-10 Thread Thomas Gleixner
On Fri, 10 Nov 2017, Linus Torvalds wrote: > On Wed, Nov 8, 2017 at 9:19 PM, Fengguang Wu wrote: > > > > Yes it's accessing the list. Here is the faddr2line output. > > Ok, so it's a corrupted timer list. Which is not a big surprise. > > It's > >

Re: [run_timer_softirq] BUG: unable to handle kernel paging request at 0000000000010007

2017-11-10 Thread Linus Torvalds
On Wed, Nov 8, 2017 at 9:19 PM, Fengguang Wu wrote: > > Yes it's accessing the list. Here is the faddr2line output. Ok, so it's a corrupted timer list. Which is not a big surprise. It's next->pprev = pprev; in __hlist_del(), and the trapping instruction

Re: [PATCH v2 5/6] firmware: Add request_firmware_prefer_user() function

2017-11-10 Thread Luis R. Rodriguez
On Fri, Nov 10, 2017 at 12:26 PM, Luis R. Rodriguez wrote: > even if you *leave* the flag in place and a driver required > this, but the kernel was compiled without CONFIG_FW_LOADER_USER_HELPER then > calling fw_load_from_user_helper would just already return -ENOENT, as such

[PATCH net-next 0/6] bpf: Fix bugs in sock_ops samples In-Reply-To:

2017-11-10 Thread Lawrence Brakmo
The programs were returning -1 in some cases when they should only return 0 or 1. Changes in the verifier now catch this issue and the programs fail to load. This is now fixed. [PATCH net-next 1/6] bpf: Fix tcp_synrto_kern.c sample program [PATCH net-next 2/6] bpf: Fix tcp_rwnd_kern.c sample

[PATCH net-next 3/6] bpf: Fix tcp_bufs_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: d9925368a641 ("bpf: Sample BPF program to set buffer sizes") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_bufs_kern.c | 14 -- 1 file changed, 8 insertions(+), 6

[PATCH net-next 4/6] bpf: Fix tcp_cong_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: bb56d4449d8b ("bpf: Sample BPF program to set congestion control") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_cong_kern.c | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH net-next 5/6] bpf: Fix tcp_iw_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: 7bc62e285479 ("bpf: Sample BPF program to set initial cwnd") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_iw_kern.c | 14 -- 1 file changed, 8 insertions(+), 6

[PATCH net-next 2/6] bpf: Fix tcp_rwnd_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: c400296bf63d ("bpf: Sample bpf program to set initial window") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_rwnd_kern.c | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH net-next 1/6] bpf: Fix tcp_synrto_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: 8550f328f45d ("bpf: Support for per connection SYN/SYN-ACK RTOs") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_synrto_kern.c | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH net-next 3/3] l2tp: remove the .tunnel_sock field from struct pppol2tp_session

2017-11-10 Thread Guillaume Nault
The last user of .tunnel_sock is pppol2tp_connect() which defensively uses it to verify internal data consistency. This check isn't necessary: l2tp_session_get() guarantees that the returned session belongs to the tunnel passed as parameter. And .tunnel_sock is never updated, so checking that it

[PATCH net-next 1/3] l2tp: remove .tunnel_sock from struct l2tp_eth

2017-11-10 Thread Guillaume Nault
This field has never been used. Signed-off-by: Guillaume Nault --- net/l2tp/l2tp_eth.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/l2tp/l2tp_eth.c b/net/l2tp/l2tp_eth.c index 3e2dec1fb0f5..5c366ecfa1cb 100644 --- a/net/l2tp/l2tp_eth.c +++ b/net/l2tp/l2tp_eth.c

[PATCH net-next 2/3] l2tp: avoid using ->tunnel_sock for getting session's parent tunnel

2017-11-10 Thread Guillaume Nault
Sessions don't need to use l2tp_sock_to_tunnel(xxx->tunnel_sock) for accessing their parent tunnel. They have the .tunnel field in the l2tp_session structure for that. Furthermore, in all these cases, the session is registered, so we're guaranteed that .tunnel isn't NULL and that the session

[PATCH net-next 0/3] l2tp: avoid aliasing tunnels socket pointer

2017-11-10 Thread Guillaume Nault
We don't need to copy the tunnel's socket pointer in the pseudo-wire specific session structures. This uselessly complicates the code and hampers evolution. This series was part of an effort to protect tunnels socket pointer with RCU. But since it provides nice cleanup, I submit it separately.

Re: [PATCH 1/8] dt-bindings: can: rcar_can: document r8a774[35] can support

2017-11-10 Thread Rob Herring
On Tue, Nov 07, 2017 at 03:10:42PM +, Fabrizio Castro wrote: > Document "renesas,can-r8a7743" and "renesas,can-r8a7745" compatible > strings. Since the fallback compatible string ("renesas,rcar-gen2-can") > activates the right code in the driver, no driver change is needed. > > Signed-off-by:

[PATCH net-next v1] xen-netback: make copy batch size configurable

2017-11-10 Thread Joao Martins
Commit eb1723a29b9a ("xen-netback: refactor guest rx") refactored Rx handling and as a result decreased max grant copy ops from 4352 to 64. Before this commit it would drain the rx_queue (while there are enough slots in the ring to put packets) then copy to all pages and write responses on the

[PATCH net-next v3 0/3] net: dsa: b53: Turn on Broadcom tags

2017-11-10 Thread Florian Fainelli
Hi all, This was long overdue, with this patch series, the b53 driver now turns on Broadcom tags except for 5325 and 5365 which use an older format that we do not support yet (TBD). First patch is necessary in order for bgmac, used on BCM5301X and Northstar Plus to work correctly and

[PATCH net-next v3 2/3] net: dsa: b53: Stop using dev->cpu_port incorrectly

2017-11-10 Thread Florian Fainelli
dev->cpu_port is the driver local information that should only be used to look up register offsets for a particular port, when they differ (e.g: IMP port override), but it should certainly not be used in place of the DSA configured CPU port. Since the DSA switch layer calls port_vlan_{add,del}()

[PATCH net-next v3 3/3] net: dsa: b53: Turn on Broadcom tags

2017-11-10 Thread Florian Fainelli
Enable Broadcom tags for b53 devices, except 5325 and 5365 which use a different Broadcom tag format not yet supported by net/dsa/tag_brcm.c. We also make sure that we can turn on Broadcom tags on a CPU port number that is capable of that: 5, 7 or 8. Signed-off-by: Florian Fainelli

[PATCH net-next v3 1/3] net: bgmac: Pad packets to a minimum size

2017-11-10 Thread Florian Fainelli
In preparation for enabling Broadcom tags with b53, pad packets to a minimum size of 64 bytes (sans FCS) in order for the Broadcom switch to accept ingressing frames. Without this, we would typically be able to DHCP, but not resolve with ARP because packets are too small and get rejected by the

  1   2   >