Re: iproute2: make ip route list to search by metric too

I think this version will be better. It uses metric mask (like for some other options) instead of simple yes/no flag. On Sat, Nov 18, 2017 at 2:44 AM, Alexander Zubkov wrote: > Hello again, > > Things turned out to be not so hard. Please take a look at the attached patch. >

[PATCH iproute2] ip route: broken logic when using default word and family not specified

Hello, I have found odd behaviour when using "ip route list" (and other bound commands) with prefix "default". When family not specified, its value is completely ignored and "ip route list default" shows all inet4 prefixes. Same do "ip route list exact default" and "ip route list match default".

Re: [PATCH] net/netlabel: Add list_next_rcu() in rcu_dereference().

On Fri, Nov 17, 2017 at 8:35 PM, David Miller wrote: > From: Tim Hansen > Date: Thu, 16 Nov 2017 12:03:34 -0500 > >> Add list_next_rcu() for fetching next list in rcu_deference safely. >> >> Found with sparse in linux-next tree on tag next-20171116.

[PATCH v2 net-next] net/tcp: trace all TCP/IP state transition with tcp_set_state tracepoint

The TCP/IP transition from TCP_LISTEN to TCP_SYN_RECV and some other transitions are not traced with tcp_set_state tracepoint. In order to trace the whole tcp lifespans, two helpers are introduced, void __tcp_set_state(struct sock *sk, int state) void __sk_state_store(struct sock *sk, int

[PATCH] man: document ip fou show

This was forgotten in cf4caf336a (2017-11-16, Add "show" subcommand to "ip fou"). Signed-off-by: Simon Ruderich --- man/man8/ip-fou.8 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/man/man8/ip-fou.8 b/man/man8/ip-fou.8 index 0c8f0a4d..81cab928 100644 ---

[PATCH] man: document ip xfrm policy nosock

Signed-off-by: Simon Ruderich --- man/man8/ip-xfrm.8 | 5 + 1 file changed, 5 insertions(+) diff --git a/man/man8/ip-xfrm.8 b/man/man8/ip-xfrm.8 index a0bbef55..988cc6aa 100644 --- a/man/man8/ip-xfrm.8 +++ b/man/man8/ip-xfrm.8 @@ -245,6 +245,7 @@ ip-xfrm \- transform

[PATCH 1/2] r8169: fix RTL8111EVL EEE and green settings

Name of functions rtl_w0w1_eri and rtl_w0w1_phy is somewhat misleading regarding order of arguments. One could assume that w0w1 means argument with bits to be reset comes before argument with bits to set. However this is not the case. So fix the order of arguments in several statements. In

Re: [PATCH net] net: accept UFO datagrams from tuntap and packet

On Fri, Nov 17, 2017 at 8:42 PM, David Miller wrote: > From: Willem de Bruijn > Date: Fri, 17 Nov 2017 17:59:13 -0500 > >> Tuntap and similar devices can inject GSO packets. Accept type >> VIRTIO_NET_HDR_GSO_UDP, even though not generating

Re: [patch net-next RFC v2 00/11] Add support for resource abstraction

On 11/14/17 9:18 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Arkadi says: > > Many of the ASIC's internal resources are limited and are shared between > several hardware procedures. For example, unified hash-based memory can > be used for many lookup purposes, like FDB and

Re: [iproute2 PATCH] man: tc-mqprio: add documentation for new offload options

On Fri, 17 Nov 2017 14:59:15 -0800 Amritha Nambiar wrote: > This patch adds documentation for additional offload modes and > associated parameters in tc-mqprio. > > Signed-off-by: Amritha Nambiar Applied both man page patches

Re: [PATCH net-next v3] net: assign err to 0 at begin in do_setlink() function

On 五, 2017-11-17 at 15:08 +0900, David Miller wrote: > From: yuan linyu > Date: Thu, 16 Nov 2017 19:59:48 +0800 > > > From: yuan linyu > >  > > each netlink attribute have proper process when error happen, > > when exit one attribute process, it

Re: [patch net-next RFC v2 09/11] mlxsw: spectrum: Add support for getting kvdl occupancy

On 11/14/17 9:18 AM, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > Add support for getting the kvdl occupancy through the resource interface. > Do you intend to add occ_get for the other kvd partitions?

[PATCH 2/2] r8169: use same RTL8111EVL green settings as in vendor driver

Adjust the code to use the same green settings as in the latest vendor driver. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/realtek/r8169.c

Re: [PATCH net] sctp: report SCTP_ERROR_INV_STRM as cpu endian

On Fri, Nov 17, 2017 at 11:04 PM, Marcelo Ricardo Leitner wrote: > On Fri, Nov 17, 2017 at 02:15:02PM +0800, Xin Long wrote: >> rfc6458 demands the send_error in SCTP_SEND_FAILED_EVENT should >> be in cpu endian, while SCTP_ERROR_INV_STRM is in big endian. >> >> This

Re: [patch net-next RFC v2 04/11] devlink: Add relation between dpipe and resource

On 11/14/17 9:18 AM, Jiri Pirko wrote: > @@ -192,6 +194,8 @@ struct devlink_dpipe_table { > const char *name; > bool counters_enabled; > bool counter_control_extern; > + u64 resource_id; > + bool resource_valid; from a space perspective, please reverse the order >

Realtek r8169: Problem with EEE on RTL8111E-VL

I have a Zotac Mini-PC with a RTL8111E-VL and just by chance figured out that EEE is disabled on the link between my EEE-capable switch and this device. After a little investigating I found that from the beginning of this driver advertising of EEE was disabled: See rtl8168e_2_hw_phy_config, line

Re: [PATCH 1/2] gre6: use log_ecn_error module parameter in ip6_tnl_rcv()

From: Alexey Kodanev Date: Fri, 17 Nov 2017 19:16:17 +0300 > After commit 308edfdf1563 ("gre6: Cleanup GREv6 receive path, call > common GRE functions") it's not used anywhere in the module, but > previously was used in ip6gre_rcv(). > > Fixes: 308edfdf1563 ("gre6:

Re: [PATCH] usbnet: ipheth: fix potential null pointer dereference in ipheth_carrier_set

From: "Gustavo A. R. Silva" Date: Fri, 17 Nov 2017 14:02:09 -0600 > _dev_ is being dereferenced before it is null checked, hence there > is a potential null pointer dereference. > > Fix this by moving the pointer dereference after _dev_ has been null > checked. > >

Re: [PATCH v2 net-next] net/tcp: trace all TCP/IP state transition with tcp_set_state tracepoint

> On Nov 18, 2017, at 7:32 AM, Yafang Shao wrote: > > The TCP/IP transition from TCP_LISTEN to TCP_SYN_RECV and some other > transitions are not traced with tcp_set_state tracepoint. > > In order to trace the whole tcp lifespans, two helpers are introduced, > void

Re: [PATCH net-next 0/2] net: fix flowlabel inconsistency in reset packet

From: Shaohua Li Date: Fri, 17 Nov 2017 10:24:49 -0800 > From: Shaohua Li > > Hi, > > Please see below tcpdump output: ... > The tcp reset packet has a different flowlabel, which causes our router > doesn't correctly close tcp connection. We are using flowlabel

Re: [PATCH net] tcp: when scheduling TLP, time of RTO should account for current ACK

From: Neal Cardwell Date: Fri, 17 Nov 2017 21:06:14 -0500 > Fix the TLP scheduling logic so that when scheduling a TLP probe, we > ensure that the estimated time at which an RTO would fire accounts for > the fact that ACKs indicating forward progress should push back RTO >

[PATCH] e1000: Fix off-by-one in debug message

Signed-off-by: Ahmad Fatoum --- drivers/net/ethernet/intel/e1000/e1000_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c index 8172cf08cc33..ba04a65d8500 100644 ---

[PATCH] man: document ip route get mark

Signed-off-by: Simon Ruderich --- Hello, Just found this in an stackoverflow article from 2015 and it really helped. So here as patch. Regards Simon man/man8/ip-route.8.in | 7 +++ 1 file changed, 7 insertions(+) diff --git a/man/man8/ip-route.8.in

Re: Realtek r8169: Problem with EEE on RTL8111E-VL

Am 18.11.2017 um 22:33 schrieb Heiner Kallweit: > I have a Zotac Mini-PC with a RTL8111E-VL and just by chance figured out > that EEE is disabled on the link between my EEE-capable switch and > this device. > > After a little investigating I found that from the beginning of this > driver

Re: [patch net-next RFC v2 02/11] devlink: Add support for resource abstraction

On 11/14/17 9:18 AM, Jiri Pirko wrote: > diff --git a/include/net/devlink.h b/include/net/devlink.h > index 4d2c6fc..960e80a 100644 > --- a/include/net/devlink.h > +++ b/include/net/devlink.h ... > @@ -469,6 +523,32 @@ devlink_dpipe_match_put(struct sk_buff *skb, > return 0; > } > >

Re: [patch net-next RFC v2 08/11] mlxsw: spectrum_dpipe: Connect dpipe tables to resources

On 11/14/17 9:18 AM, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > Connect current dpipe tables to resources. The tables are connected > in the following fashion: > 1. IPv4 host - KVD hash single > 2. IPv6 host - KVD hash double > 3. Adjacency - KVD linear Those

Re: [patch net-next RFC v2 07/11] mlxsw: spectrum: Register KVD resources with devlink

On 11/14/17 9:18 AM, Jiri Pirko wrote: > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > index d02c130..f0cbd67 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c >

RE: [PATCH v1 net-next 0/7] net: dsa: microchip: Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers

> > I really need to monitor the DSA discussion to better contribute to its > success. > > I just found out the DSA API set_addr was removed last month due to not > > everybody is using it. It cited the Marvell switch was the only switch > > using > that > > API and found a new way to program

Re: [PATCH RFC 00/25] Replacing net_mutex with rw_semaphore

Kirill Tkhai writes: > Hi, > > this is continuation of discussion from here: > > https://lkml.org/lkml/2017/11/14/298 > > The plan has changed a little bit, so I'd be happy to hear > people's comments, before I dived into all 400+ pernet subsys > and devices. > > The patch

Re: [PATCH 2/2] ip6_tunnel: pass tun_dst arg from ip6_tnl_rcv() to __ip6_tnl_rcv()

From: Alexey Kodanev Date: Fri, 17 Nov 2017 19:16:18 +0300 > Otherwise tun_dst argument is unused there. Currently, ip6_tnl_rcv() > invoked with tun_dst set to NULL, so there is no actual functional > changes introduced in this patch. Oh yes there is a functional

Re: [patch net-next RFC v2 00/11] Add support for resource abstraction

On 11/17/2017 09:58 PM, David Ahern wrote: > On 11/14/17 9:18 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Arkadi says: >> >> Many of the ASIC's internal resources are limited and are shared between >> several hardware procedures. For example, unified hash-based memory can

Re: [PATCH net] net: ena: fix race condition between device reset and link up setup

From: Date: Sat, 18 Nov 2017 03:05:36 + > From: Netanel Belgazal > > In rare cases, ena driver would reset and re-start the device, > for example, in case of misbehaving application that causes > transmit timeout > > The first step in the reset

Re: [PATCH v2 net-next] net/tcp: trace all TCP/IP state transition with tcp_set_state tracepoint

From: Yafang Shao Date: Sat, 18 Nov 2017 15:32:36 + > The TCP/IP transition from TCP_LISTEN to TCP_SYN_RECV and some other > transitions are not traced with tcp_set_state tracepoint. > > In order to trace the whole tcp lifespans, two helpers are introduced, > void

Re: [PATCH 2/2] r8169: use same RTL8111EVL green settings as in vendor driver

From: Heiner Kallweit Date: Sun, 19 Nov 2017 01:36:02 +0100 > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 19f3074a0..912549c88 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++

Re: [PATCH iproute2] ip route: broken logic when using default word and family not specified

I also opened earlier a ticket in bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197899 And Stephen Hemminger had couple of comments there which I want to argue: > $ ip route list default > Means list all routes in any address family (ie same as any) > but > > $ ip route list 0/0 > Means

Re: [patch net-next v2 00/10] net: sched: allow qdiscs to share filter block instances

Thu, Nov 16, 2017 at 12:12:47AM CET, xiyou.wangc...@gmail.com wrote: >On Sun, Nov 12, 2017 at 7:55 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Currently the filters added to qdiscs are independent. So for example if you >> have 2 netdevices and you create