Re: [PATCH 1/1] phy: Add 2.5G SGMII interface mode

2017-11-30 Thread Andrew Lunn
On Thu, Nov 30, 2017 at 10:00:35AM +0530, Bhaskar Upadhaya wrote: > Add 2.5G SGMII interface mode(PHY_INTERFACE_MODE_2500SGMII) > in existing phy_interface list.As auto-negotiation is not > supported for 2.5G SGMII Hi Bhaskar I've been thinking about this some more... Is auto negotiation not

Re: [PATCH net-next 3/5] bpftool: implement cgattach command

2017-11-30 Thread David Ahern
On 11/30/17 6:43 AM, Roman Gushchin wrote: > @@ -75,12 +80,13 @@ static int do_help(int argc, char **argv) > fprintf(stderr, > "Usage: %s [OPTIONS] OBJECT { COMMAND | help }\n" > " %s batch file FILE\n" > + " %s cgattach FILE CGROUP TYPE\n"

[PATCH net-next 1/4] net: dsa: remove trans argument from vlan ops

2017-11-30 Thread Vivien Didelot
The DSA switch VLAN ops pass the switchdev_trans structure down to the drivers, but no one is using them and they aren't supposed to anyway. Remove the trans argument from VLAN prepare and add operations. At the same time, fix the following checkpatch warning: WARNING: line over 80

[PATCH net-next 3/4] net: dsa: add switch vlan bitmap functions

2017-11-30 Thread Vivien Didelot
This patch brings no functional changes. It moves out the VLAN code iterating on a list of VLAN members into new dsa_switch_vlan_{prepare,add}_bitmap() functions. This gives us a better isolation of the two switchdev phases. Signed-off-by: Vivien Didelot ---

[PATCH net-next 0/4] net: dsa: simplify switchdev prepare phase

2017-11-30 Thread Vivien Didelot
This patch series brings no functional changes. It removes the unused switchdev_trans arguments from the dsa_switch_ops for both MDB and VLAN operations, and provides functions to prepare and add these objects for a given bitmap of ports. Vivien Didelot (4): net: dsa: remove trans argument

Re: [BUG] kernel stack corruption during/after Netlabel error

2017-11-30 Thread David Ahern
On 11/30/17 8:44 AM, David Ahern wrote: > On 11/30/17 3:50 AM, Eric Dumazet wrote: >> @@ -1631,24 +1659,6 @@ int tcp_v4_rcv(struct sk_buff *skb) >> >> th = (const struct tcphdr *)skb->data; >> iph = ip_hdr(skb); >> -/* This is tricky : We move IPCB at its correct location into >>

[PATCH net-next] net: dsa: bcm_sf2: Utilize b53_get_tag_protocol()

2017-11-30 Thread Florian Fainelli
Utilize the much more capable b53_get_tag_protocol() which takes care of all Broadcom switches specifics to resolve which port can have Broadcom tags enabled or not. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 4 ++--

Re: [PATCH net-next] net: dsa: bcm_sf2: Utilize b53_get_tag_protocol()

2017-11-30 Thread David Miller
From: Florian Fainelli Date: Thu, 30 Nov 2017 09:55:35 -0800 > Utilize the much more capable b53_get_tag_protocol() which takes care of > all Broadcom switches specifics to resolve which port can have Broadcom > tags enabled or not. > > Signed-off-by: Florian Fainelli

Re: [PATCH 1/1] phy: Add 2.5G SGMII interface mode

2017-11-30 Thread Russell King - ARM Linux
On Thu, Nov 30, 2017 at 06:41:27PM +0100, Andrew Lunn wrote: > SGMII supports passing auto-negotiation results from the PHY to the > MAC. 1000BASE-X does not. > > SGMII supports the PHY running at 10, 100, and 1000 Mbps. But to > support this, the MAC needs to replicate the bits 100, or 10 times

Re: [PATCH 3/3] MAINTAINERS: Add entry for Socionext ethernet driver

2017-11-30 Thread Joe Perches
On Thu, 2017-11-30 at 21:43 +0530, jassisinghb...@gmail.com wrote: > Add entry for the Socionext Netsec controller driver and DT bindings. [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -12617,6 +12617,14 @@ F: drivers/md/raid* > F: include/linux/raid/ > F: include/uapi/linux/raid/ >

Re: [PATCH net-next 3/5] bpftool: implement cgattach command

2017-11-30 Thread Roman Gushchin
On Thu, Nov 30, 2017 at 09:17:17AM -0700, David Ahern wrote: > On 11/30/17 6:43 AM, Roman Gushchin wrote: > > @@ -75,12 +80,13 @@ static int do_help(int argc, char **argv) > > fprintf(stderr, > > "Usage: %s [OPTIONS] OBJECT { COMMAND | help }\n" > > " %s batch

Re: [PATCH 2/3] staging: irda: Handle return value of platform_get_irq

2017-11-30 Thread arvindY
Hi Greg, On Thursday 30 November 2017 10:11 PM, Greg KH wrote: On Thu, Nov 30, 2017 at 09:13:35PM +0530, Arvind Yadav wrote: platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav ---

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-30 Thread Serge E. Hallyn
On Wed, Nov 29, 2017 at 07:35:31PM -0500, Theodore Ts'o wrote: > On Wed, Nov 29, 2017 at 11:28:52AM -0600, Serge E. Hallyn wrote: > > > > Just to be clear, module loading requires - and must always continue to > > require - CAP_SYS_MODULE against the initial user namespace. Containers > > in

Re: [PATCH RFC 2/2] veth: propagate bridge GSO to peer

2017-11-30 Thread Eric Dumazet
On Thu, 2017-11-30 at 09:10 -0800, Stephen Hemminger wrote: > > > The problem goes back into the core GSO networking code. > Something like this is needed. > > static inline bool netif_needs_gso(struct sk_buff *skb, >    const struct net_device *dev, >

Re: [PATCH RFC 2/2] veth: propagate bridge GSO to peer

2017-11-30 Thread David Miller
From: Eric Dumazet Date: Thu, 30 Nov 2017 09:26:39 -0800 > On Thu, 2017-11-30 at 09:10 -0800, Stephen Hemminger wrote: >> >> >> The problem goes back into the core GSO networking code. >> Something like this is needed. >> >> static inline bool netif_needs_gso(struct

Re: [PATCH 2/3] net: socionext: Add Synquacer NetSec driver

2017-11-30 Thread David Miller
From: Ard Biesheuvel Date: Thu, 30 Nov 2017 17:48:44 + > On 30 November 2017 at 17:42, David Miller wrote: >> From: Ard Biesheuvel >> Date: Thu, 30 Nov 2017 17:37:27 + >> >>> Well, the whole point of using

[PATCH net-next 0/2] net: dsa: cross-chip FDB support

2017-11-30 Thread Vivien Didelot
DSA can have interconnected switches. For instance, the ZII Dev Rev B board described in arch/arm/boot/dts/vf610-zii-dev-rev-b.dts has a switch fabric composed of 3 switch devices like this: lan4 lan6 CPU (eth1)| lan5 | lan7

Re: [BUG] kernel stack corruption during/after Netlabel error

2017-11-30 Thread Eric Dumazet
On Thu, 2017-11-30 at 10:30 -0700, David Ahern wrote: > On 11/30/17 8:44 AM, David Ahern wrote: > > On 11/30/17 3:50 AM, Eric Dumazet wrote: > > > @@ -1631,24 +1659,6 @@ int tcp_v4_rcv(struct sk_buff *skb) > > >   > > >   th = (const struct tcphdr *)skb->data; > > >   iph = ip_hdr(skb); > > > - /*

[PATCH net-next 2/2] net: dsa: support cross-chip FDB operations

2017-11-30 Thread Vivien Didelot
When a MAC address is added to or removed from a switch port in the fabric, the target switch must program its port and adjacent switches must program their local DSA port used to reach the target switch. For this purpose, use the dsa_towards_port() helper to identify the local switch port which

[PATCH net-next 1/2] net: dsa: introduce dsa_towards_port helper

2017-11-30 Thread Vivien Didelot
Add a new helper returning the local port used to reach an arbitrary switch port in the fabric. Its only user at the moment is the dsa_upstream_port helper, which returns the local port reaching the dedicated CPU port, but it will be used in cross-chip FDB operations. Signed-off-by: Vivien

[PATCH net-next] samples/bpf: Convert magic numbers to names in multi-prog cgroup test case

2017-11-30 Thread David Ahern
Attach flag 1 == BPF_F_ALLOW_OVERRIDE; attach flag 2 == BPF_F_ALLOW_MULTI. Update the calls to bpf_prog_attach() in test_cgrp2_attach2.c to use the names over the magic numbers. Fixes: 39323e788cb67 ("samples/bpf: add multi-prog cgroup test case") Signed-off-by: David Ahern

Re: [PATCH 1/1] phy: Add 2.5G SGMII interface mode

2017-11-30 Thread David Miller
From: Bhaskar Upadhaya Date: Thu, 30 Nov 2017 17:16:48 + > Hi Andrew, > Please find answer in lined. ... > Is auto negotiation not supported in 2.5G SGMII in general, or just in the > system you are using? Is it the PHY or the MAC which does not support it. >

Re: [PATCH 1/1] phy: Add 2.5G SGMII interface mode

2017-11-30 Thread Russell King - ARM Linux
On Thu, Nov 30, 2017 at 04:50:50PM +0100, Andrew Lunn wrote: > On Thu, Nov 30, 2017 at 10:00:35AM +0530, Bhaskar Upadhaya wrote: > > Add 2.5G SGMII interface mode(PHY_INTERFACE_MODE_2500SGMII) > > in existing phy_interface list.As auto-negotiation is not > > supported for 2.5G SGMII > > Hi

Re: [PATCH RFC 2/2] veth: propagate bridge GSO to peer

2017-11-30 Thread Stephen Hemminger
On Thu, 30 Nov 2017 09:26:39 -0800 Eric Dumazet wrote: > On Thu, 2017-11-30 at 09:10 -0800, Stephen Hemminger wrote: > > > > > > The problem goes back into the core GSO networking code. > > Something like this is needed. > > > > static inline bool

Re: [PATCH 2/3] net: socionext: Add Synquacer NetSec driver

2017-11-30 Thread Ard Biesheuvel
(+ Dan, Will) On 30 November 2017 at 17:29, David Miller wrote: > From: jassisinghb...@gmail.com > Date: Thu, 30 Nov 2017 21:43:16 +0530 > >> + priv->eeprom_base = devm_memremap(>dev, eeprom_res->start, >> +

Re: [PATCH RFC 2/2] veth: propagate bridge GSO to peer

2017-11-30 Thread Eric Dumazet
On Thu, 2017-11-30 at 10:08 -0800, Stephen Hemminger wrote: > On Thu, 30 Nov 2017 09:59:23 -0800 > Eric Dumazet wrote: > > > On Thu, 2017-11-30 at 09:49 -0800, Stephen Hemminger wrote: > > > On Thu, 30 Nov 2017 09:26:39 -0800 > > > Eric Dumazet

Re: [PATCH net-next] net/reuseport: drop legacy code

2017-11-30 Thread David Miller
From: Paolo Abeni Date: Thu, 30 Nov 2017 15:39:34 +0100 > Since commit e32ea7e74727 ("soreuseport: fast reuseport UDP socket > selection") and commit c125e80b8868 ("soreuseport: fast reuseport > TCP socket selection") the relevant reuseport socket matching the current > packet

[PATCH] rxrpc: Neaten logging macros and add KERN_DEBUG logging level

2017-11-30 Thread Joe Perches
When enabled, the current debug logging does not have a KERN_. Add KERN_DEBUG to the logging macros. Miscellanea: o Remove #define redundancy and neaten the macros a bit Signed-off-by: Joe Perches --- net/rxrpc/ar-internal.h | 75

[PATCH net-next] tools/bpf: adjust rlimit RLIMIT_MEMLOCK for test_verifier_log

2017-11-30 Thread Yonghong Song
The default rlimit RLIMIT_MEMLOCK is 64KB. In certain cases, e.g. in a test machine mimicking our production system, this test may fail due to unable to charge the required memory for prog load: # ./test_verifier_log Test log_level 0... ERROR: Program load returned: ret:-1/errno:1, expected

Re: [PATCH RFC 2/2] veth: propagate bridge GSO to peer

2017-11-30 Thread Stephen Hemminger
On Wed, 29 Nov 2017 16:35:37 -0800 Solio Sarabia wrote: > On Mon, Nov 27, 2017 at 07:02:01PM -0700, David Ahern wrote: > > On 11/27/17 6:42 PM, Solio Sarabia wrote: > > > Adding ioctl support for 'ip link set' would work. I'm still concerned > > > how to enforce the

RE: [PATCH 1/1] phy: Add 2.5G SGMII interface mode

2017-11-30 Thread Bhaskar Upadhaya
Hi Andrew, Please find answer in lined. Regards --Bhaskar -Original Message- From: Andrew Lunn [mailto:and...@lunn.ch] Sent: Thursday, November 30, 2017 9:21 PM To: Bhaskar Upadhaya Cc: netdev@vger.kernel.org; da...@davemloft.net;

Re: [PATCH] rxrpc: Neaten logging macros and add KERN_DEBUG logging level

2017-11-30 Thread David Miller
From: Joe Perches Date: Thu, 30 Nov 2017 08:21:14 -0800 > When enabled, the current debug logging does not have a KERN_. > Add KERN_DEBUG to the logging macros. > > Miscellanea: > > o Remove #define redundancy and neaten the macros a bit > > Signed-off-by: Joe Perches

Re: [PATCH RFC 2/2] veth: propagate bridge GSO to peer

2017-11-30 Thread Stephen Hemminger
On Thu, 30 Nov 2017 09:26:39 -0800 Eric Dumazet wrote: > On Thu, 2017-11-30 at 09:10 -0800, Stephen Hemminger wrote: > > > > > > The problem goes back into the core GSO networking code. > > Something like this is needed. > > > > static inline bool

Re: [BUG] kernel stack corruption during/after Netlabel error

2017-11-30 Thread David Ahern
On 11/30/17 10:57 AM, Eric Dumazet wrote: > I wonder if this should not be in a separate patch ? > > Bug was added in 971f10eca186cab238c49daa91f703c5a001b0b1 ("tcp: better > TCP_SKB_CB layout to reduce cache line misses") in linux 3.18 > > While VRF was added later. > > If you agree, I will

Re: [PATCH] rxrpc: Neaten logging macros and add KERN_DEBUG logging level

2017-11-30 Thread David Miller
From: Joe Perches Date: Thu, 30 Nov 2017 10:06:51 -0800 > Excuse is probably the wrong word here David. > Rationale maybe... I guess you turn a blind eye to the hundreds of the rxrpc patches David has posted here over the past few months That's all I'm saying. If you see

Re: [PATCH 2/3] net: socionext: Add Synquacer NetSec driver

2017-11-30 Thread David Miller
From: Ard Biesheuvel Date: Thu, 30 Nov 2017 17:37:27 + > Well, the whole point of using memremap() instead of ioremap() is that > the region has memory semantics, i.e., we read the MAC address and the > DMA engine microcode from it. If memremap() itself is flawed

Re: [PATCH 1/1] phy: Add 2.5G SGMII interface mode

2017-11-30 Thread Andrew Lunn
> [bhaskar] 2.5G in general needs to operate with auto negotiation in > disabled mode. Its 2.5G requirement and not specific to our system. > My understanding is that one of the main differences between SGMII and > 1000BASE-X is the negotiation. > [Bhaskar] which of SGMII and 1000BASE-X support

Re: [PATCH 2/3] net: socionext: Add Synquacer NetSec driver

2017-11-30 Thread Ard Biesheuvel
On 30 November 2017 at 17:42, David Miller wrote: > From: Ard Biesheuvel > Date: Thu, 30 Nov 2017 17:37:27 + > >> Well, the whole point of using memremap() instead of ioremap() is that >> the region has memory semantics, i.e., we read the MAC

Re: [PATCH 2/3] net: socionext: Add Synquacer NetSec driver

2017-11-30 Thread David Miller
From: Ard Biesheuvel Date: Thu, 30 Nov 2017 18:08:34 + > But the whole point of memremap() is obtaining a virtual mapping > that does not require accessors, but can be used like ordinary > memory. That's unfortunately not what it's doing. It's relying on the fact

[PATCH 2/3] net: socionext: Add Synquacer NetSec driver

2017-11-30 Thread jassisinghbrar
From: Jassi Brar This driver adds support for Socionext "netsec" IP Gigabit Ethernet + PHY IP used in the Synquacer SC2A11 SoC. Signed-off-by: Ard Biesheuvel Signed-off-by: Jassi Brar ---

[PATCH 3/3] MAINTAINERS: Add entry for Socionext ethernet driver

2017-11-30 Thread jassisinghbrar
From: Jassi Brar Add entry for the Socionext Netsec controller driver and DT bindings. Signed-off-by: Jassi Brar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH 1/3] dt-bindings: net: Add DT bindings for Socionext Netsec

2017-11-30 Thread jassisinghbrar
From: Jassi Brar This patch adds documentation for Device-Tree bindings for the Socionext NetSec Controller driver. Signed-off-by: Jassi Brar Signed-off-by: Ard Biesheuvel ---

Re: Commit 05cf0d1bf4 ("net: stmmac: free an skb first when there are no longer any descriptors using it") breaks stmmac?

2017-11-30 Thread Jose Abreu
Hi Niklas, Thanks for the detailed explanation! On 30-11-2017 03:51, Niklas Cassel wrote: > > Could you try to see if the following patch > solves your problem: > (still don't see why it should be needed, > considering stmmac_tx_clean() should set all non-NULL > entries to NULL) > > diff --git

Re: [BUG] kernel stack corruption during/after Netlabel error

2017-11-30 Thread Paul Moore
On Thu, Nov 30, 2017 at 7:47 AM, Paul Moore wrote: > On Thu, Nov 30, 2017 at 5:50 AM, Eric Dumazet wrote: >> On Wed, 2017-11-29 at 19:16 -0800, Casey Schaufler wrote: >>> On 11/29/2017 4:31 PM, James Morris wrote: >>> > On Wed, 29 Nov 2017, Casey

Re: [PATCH RFC 0/2] veth, bridge, and GSO maximums

2017-11-30 Thread Stephen Hemminger
On Thu, 30 Nov 2017 10:47:21 -0500 (EST) David Miller wrote: > From: Stephen Hemminger > Date: Sun, 26 Nov 2017 10:17:47 -0800 > > > This pair of patchesimproves the performance when running > > containers in an environment where underlying

Re: [PATCH 2/3] net: socionext: Add Synquacer NetSec driver

2017-11-30 Thread David Miller
From: jassisinghb...@gmail.com Date: Thu, 30 Nov 2017 21:43:16 +0530 > + priv->eeprom_base = devm_memremap(>dev, eeprom_res->start, > + resource_size(eeprom_res), > + MEMREMAP_WT); > + if (!priv->eeprom_base) { >

Re: [PATCH RFC 2/2] veth: propagate bridge GSO to peer

2017-11-30 Thread Eric Dumazet
On Thu, 2017-11-30 at 09:49 -0800, Stephen Hemminger wrote: > On Thu, 30 Nov 2017 09:26:39 -0800 > Eric Dumazet wrote: > > > On Thu, 2017-11-30 at 09:10 -0800, Stephen Hemminger wrote: > > > > > > > > > The problem goes back into the core GSO networking code. > > >

Re: [PATCH RFC 2/2] veth: propagate bridge GSO to peer

2017-11-30 Thread Stephen Hemminger
On Thu, 30 Nov 2017 09:59:23 -0800 Eric Dumazet wrote: > On Thu, 2017-11-30 at 09:49 -0800, Stephen Hemminger wrote: > > On Thu, 30 Nov 2017 09:26:39 -0800 > > Eric Dumazet wrote: > > > > > On Thu, 2017-11-30 at 09:10 -0800, Stephen Hemminger

Re: [PATCH 2/3] net: socionext: Add Synquacer NetSec driver

2017-11-30 Thread Ard Biesheuvel
On 30 November 2017 at 17:58, David Miller wrote: > From: Ard Biesheuvel > Date: Thu, 30 Nov 2017 17:48:44 + > >> On 30 November 2017 at 17:42, David Miller wrote: >>> From: Ard Biesheuvel >>>

Re: [PATCH] rxrpc: Neaten logging macros and add KERN_DEBUG logging level

2017-11-30 Thread Joe Perches
On Thu, 2017-11-30 at 12:31 -0500, David Miller wrote: > From: Joe Perches > Date: Thu, 30 Nov 2017 08:21:14 -0800 > > > When enabled, the current debug logging does not have a KERN_. > > Add KERN_DEBUG to the logging macros. > > > > Miscellanea: > > > > o Remove #define

[PATCH net-next 4/4] net: dsa: add switch mdb bitmap functions

2017-11-30 Thread Vivien Didelot
This patch brings no functional changes. It moves out the MDB code iterating on a multicast group into new dsa_switch_mdb_{prepare,add}_bitmap() functions. This gives us a better isolation of the two switchdev phases. Signed-off-by: Vivien Didelot ---

Re: [PATCH net-next 3/5] bpftool: implement cgattach command

2017-11-30 Thread David Ahern
On 11/30/17 6:43 AM, Roman Gushchin wrote: > + if (bpf_prog_attach(prog_fd, cgroup_fd, attach_type, 0)) { > + bpf_object__close(obj); > + close(prog_fd); > + close(cgroup_fd); > + p_err("Failed to attach program"); > + return -1; > +

[PATCH net-next 2/4] net: dsa: remove trans argument from mdb ops

2017-11-30 Thread Vivien Didelot
The DSA switch MDB ops pass the switchdev_trans structure down to the drivers, but no one is using them and they aren't supposed to anyway. Remove the trans argument from MDB prepare and add operations. Signed-off-by: Vivien Didelot ---

Re: [PATCH 2/3] staging: irda: Handle return value of platform_get_irq

2017-11-30 Thread Greg KH
On Thu, Nov 30, 2017 at 09:13:35PM +0530, Arvind Yadav wrote: > platform_get_irq() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/staging/irda/drivers/pxaficp_ir.c | 10 ++ > 1 file changed, 10 insertions(+)

Re: [PATCH net-next 1/2] bpf/tracing: allow user space to query prog array on the same tp

2017-11-30 Thread Daniel Borkmann
On 11/29/2017 08:20 AM, Yonghong Song wrote: > Commit e87c6bc3852b ("bpf: permit multiple bpf attachments > for a single perf event") added support to attach multiple > bpf programs to a single perf event. > Commit 2541517c32be ("tracing, perf: Implement BPF programs > attached to kprobes")

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-11-30 Thread achiad shochat
On 30 November 2017 at 05:29, Jason Wang wrote: > > > On 2017年11月29日 03:27, Jesse Brandeburg wrote: >> >> Hi, I'd like to get some feedback on a proposal to enhance virtio-net >> to ease configuration of a VM and that would enable live migration of >> passthrough network

RE: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-11-30 Thread Yan Markman
The phylink_stop is called before phylink_disconnect_phy You could see in mvpp2.c: mvpp2_stop_dev() { phylink_stop(port->phylink); } mvpp2_stop() { mvpp2_stop_dev(port); phylink_disconnect_phy(port->phylink); } .ndo_stop = mvpp2_stop, -Original Message-

Re: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-11-30 Thread Russell King - ARM Linux
On Thu, Nov 30, 2017 at 08:51:21AM +, Yan Markman wrote: > The phylink_stop is called before phylink_disconnect_phy > You could see in mvpp2.c: > > mvpp2_stop_dev() { > phylink_stop(port->phylink); > } > > mvpp2_stop() { > mvpp2_stop_dev(port); >

Re: flow cache removed = xfrm doesnt work

2017-11-30 Thread Steffen Klassert
On Mon, Nov 27, 2017 at 05:46:28PM +0100, Tomas Charvat wrote: > Gentoo-sources has no change vs vanilla in ipsec. However here is result > from Vanila 4.14.2 with OFFLOAD=N > > [ 2338.440735] BUG: unable to handle kernel NULL pointer dereference at > 0018 > [ 2338.440830] IP:

Re: [PATCH net,stable v2] vhost: fix skb leak in handle_rx()

2017-11-30 Thread Wei Xu
On Thu, Nov 30, 2017 at 10:46:17AM +0800, Jason Wang wrote: > > > On 2017年11月29日 23:31, Michael S. Tsirkin wrote: > > On Wed, Nov 29, 2017 at 09:23:24AM -0500,w...@redhat.com wrote: > > > From: Wei Xu > > > > > > Matthew found a roughly 40% tcp throughput regression with

[PATCH] net: phy-micrel: check return code in flp center function

2017-11-30 Thread Max Uvarov
Fix obvious typo that first return value is set but not checked. Signed-off-by: Max Uvarov --- drivers/net/phy/micrel.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index fdb43dd..ab46141 100644

RE: [PATCH V11 0/5] hash addresses printed with %p

2017-11-30 Thread David Laight
From: Andrew Morton > Sent: 29 November 2017 23:21 > > > > The added advantage of hashing %p is that security is now opt-out, if > > you _really_ want the address you have to work a little harder and use > > %px. You need a system-wide opt-out that prints the actual values. Otherwise developers

[PATCH 1/1] phy: Add 2.5G SGMII interface mode

2017-11-30 Thread Bhaskar Upadhaya
Add 2.5G SGMII interface mode(PHY_INTERFACE_MODE_2500SGMII) in existing phy_interface list.As auto-negotiation is not supported for 2.5G SGMII, we need to add a new type PHY_INTERFACE_MODE_2500SGMII to differentiate SGMII-1G and SGMII-2.5G with different setting for auto-negotiation.

Re: [PATCH v2 25/35] nds32: Build infrastructure

2017-11-30 Thread Greentime Hu
2017-11-30 15:52 GMT+08:00 Geert Uytterhoeven : > On Thu, Nov 30, 2017 at 6:48 AM, Greentime Hu wrote: >> 2017-11-30 4:27 GMT+08:00 Arnd Bergmann : >>> On Wed, Nov 29, 2017 at 3:10 PM, Greentime Hu wrote:

Re: [PATCH v2 25/35] nds32: Build infrastructure

2017-11-30 Thread Arnd Bergmann
On Thu, Nov 30, 2017 at 6:48 AM, Greentime Hu wrote: > 2017-11-30 4:27 GMT+08:00 Arnd Bergmann : >> On Wed, Nov 29, 2017 at 3:10 PM, Greentime Hu wrote: >>> 2017-11-29 19:57 GMT+08:00 Arnd Bergmann : >> When you put them in a

[PATCH net] net: mvpp2: allocate zeroed tx descriptors

2017-11-30 Thread Antoine Tenart
From: Yan Markman Reserved and unused fields in the Tx descriptors should be 0. The PPv2 driver doesn't clear them at run-time (for performance reasons) but these descriptors aren't zeroed when allocated, which can lead to unpredictable behaviors. This patch fixes this by

Re: [PATCH v2 25/35] nds32: Build infrastructure

2017-11-30 Thread Greentime Hu
2017-11-30 17:30 GMT+08:00 Arnd Bergmann : > On Thu, Nov 30, 2017 at 6:48 AM, Greentime Hu wrote: >> 2017-11-30 4:27 GMT+08:00 Arnd Bergmann : >>> On Wed, Nov 29, 2017 at 3:10 PM, Greentime Hu wrote: 2017-11-29 19:57

Re: [PATCH] rxrpc: Neaten logging macros and add KERN_DEBUG logging level

2017-11-30 Thread Joe Perches
On Thu, 2017-11-30 at 13:13 -0500, David Miller wrote: > From: Joe Perches > Date: Thu, 30 Nov 2017 10:06:51 -0800 > > > Excuse is probably the wrong word here David. > > Rationale maybe... > > I guess you turn a blind eye to the hundreds of the rxrpc patches > David has

[PATCH 0/3] Receive packets filtering for macb driver

2017-11-30 Thread Rafal Ozieblo
This patch series adds support for receive packets filtering for Cadence GEM driver. Packets can be redirect to different hardware queues based on source IP, destination IP, source port or destination port. To enable filtering, support for RX queueing was added as well. Rafal Ozieblo (3): net:

Re: [PATCH 1/1] phy: Add 2.5G SGMII interface mode

2017-11-30 Thread Russell King - ARM Linux
On Thu, Nov 30, 2017 at 07:26:21PM +0100, Andrew Lunn wrote: > On Thu, Nov 30, 2017 at 06:15:20PM +, Russell King - ARM Linux wrote: > > On Thu, Nov 30, 2017 at 06:41:27PM +0100, Andrew Lunn wrote: > > > SGMII supports passing auto-negotiation results from the PHY to the > > > MAC. 1000BASE-X

Re: [PATCH net-next] samples/bpf: Convert magic numbers to names in multi-prog cgroup test case

2017-11-30 Thread Daniel Borkmann
On 11/30/2017 06:02 PM, David Ahern wrote: > Attach flag 1 == BPF_F_ALLOW_OVERRIDE; attach flag 2 == BPF_F_ALLOW_MULTI. > Update the calls to bpf_prog_attach() in test_cgrp2_attach2.c to use the > names over the magic numbers. > > Fixes: 39323e788cb67 ("samples/bpf: add multi-prog cgroup test

[PATCH 2/2] bnxt_en: Add ETH_RESET_AP support

2017-11-30 Thread Scott Branden
Add ETH_RESET_AP support handling to reset the internal Application Processor(s) of the SmartNIC card. Signed-off-by: Scott Branden --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 11 +++ drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h | 1 + 2

[PATCH v5 net-next 0/3] ip6_gre: add erspan native tunnel for ipv6

2017-11-30 Thread William Tu
The patch series add support for ERSPAN tunnel over ipv6. The first patch refectors the existing ipv4 gre implementation and the second refactors the ipv6 gre's xmit code. Finally the last patch introduces erspan protocol. change in v5: - add cover-letter description change in v4: - rebase

[PATCH v5 net-next 1/3] ip_gre: Refector the erpsan tunnel code.

2017-11-30 Thread William Tu
Move two erspan functions to header file, erspan.h, so ipv6 erspan implementation can use it. Signed-off-by: William Tu --- include/net/erspan.h | 51 + net/ipv4/ip_gre.c| 54

[PATCH v5 net-next 2/3] ip6_gre: Refactor ip6gre xmit codes

2017-11-30 Thread William Tu
This patch refactors the ip6gre_xmit_{ipv4, ipv6}. It is a prep work to add the ip6erspan tunnel. Signed-off-by: William Tu --- net/ipv6/ip6_gre.c | 123 - 1 file changed, 75 insertions(+), 48 deletions(-) diff --git

[PATCH v5 net-next 3/3] ip6_gre: Add ERSPAN native tunnel support

2017-11-30 Thread William Tu
The patch adds support for ERSPAN tunnel over ipv6. Signed-off-by: William Tu --- include/net/ip6_tunnel.h | 1 + net/ipv6/ip6_gre.c | 270 ++- 2 files changed, 267 insertions(+), 4 deletions(-) diff --git

[PATCH net-next 0/5] PHYLINK preparatory patches for DSA

2017-11-30 Thread Florian Fainelli
Hi all, In preparation for having DSA migrate to PHYLINK, I had to come up with a number of preparatory patches: - we need to be able to pass phy_flags from an external component calling phylink_of_phy_connect() - DSA tries to connect through OF first, then fallsback using its own internal

[PATCH net-next 2/5] net: phy: phylink: Use PHY device interface if N/A

2017-11-30 Thread Florian Fainelli
We may not always be able to resolve a correct phy_interface_t value before actually connecting to the PHY device, when that happens, just have phylink_connect_phy() utilize what the PHY device/driver provided. Signed-off-by: Florian Fainelli --- drivers/net/phy/phylink.c

[PATCH net-next 3/5] net: phy: phylink: Demote error message to debug

2017-11-30 Thread Florian Fainelli
Some subsystems like DSA may be trying to connect to a PHY through OF first, and then attempt a connect using a local MDIO bus, demote the error message: "unable to find PHY node" into a debug print. Signed-off-by: Florian Fainelli --- drivers/net/phy/phylink.c | 2 +- 1

[PATCH net-next 5/5] net: phy: phylink: Report MoCA as PORT_BNC

2017-11-30 Thread Florian Fainelli
Similarly to what PHYLIB already does, make sure that PHY_INTERFACE_MODE_MOCA is reported as PORT_BNC. Signed-off-by: Florian Fainelli --- drivers/net/phy/phylink.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/phylink.c

Re: [PATCH] rxrpc: Neaten logging macros and add KERN_DEBUG logging level

2017-11-30 Thread David Miller
From: Joe Perches Date: Thu, 30 Nov 2017 10:18:24 -0800 > _Nobody_ reads everything on lkml. True, in fact I don't read lkml at all. That wasn't the point I was trying to make.

[PATCH 1/3] net: macb: Added support for many RX queues

2017-11-30 Thread Rafal Ozieblo
To be able for packet reception on different RX queues some configuration has to be performed. This patch checks how many hardware queue does GEM support and initializes them. Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/macb.h | 26 ++-

[PATCH 2/3] net: macb: Added some queue statistics

2017-11-30 Thread Rafal Ozieblo
Added statistics per queue: - qX_rx_packets - qX_rx_bytes - qX_rx_dropped - qX_tx_packets - qX_tx_bytes - qX_tx_dropped Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/macb.h | 31 +- drivers/net/ethernet/cadence/macb_main.c | 37

[PATCH net-next v2] vmxnet3: increase default rx ring sizes

2017-11-30 Thread Shrikrishna Khare
There are several reasons for increasing the receive ring sizes: 1. The original ring size of 256 was chosen about 10 years ago when vmxnet3 was first created. At that time, 10Gbps Ethernet was not prevalent and servers were dominated by 1Gbps Ethernet. Now 10Gbps is common place, and higher

Re: [PATCH net-next v2] vmxnet3: increase default rx ring sizes

2017-11-30 Thread David Miller
From: Shrikrishna Khare Date: Thu, 30 Nov 2017 10:29:51 -0800 > There are several reasons for increasing the receive ring sizes: ... > Signed-off-by: Shrikrishna Khare > Acked-by: Jin Heo > Acked-by: Guolin Yang >

Re: [PATCH net] net: dsa: bcm_sf2: Set correct CHAIN_ID and slice number mask

2017-11-30 Thread David Miller
From: Florian Fainelli Date: Thu, 30 Nov 2017 10:45:26 -0800 > When configuring an IPv6 address mask, we should use SLICE_NUM_MASK as > the mask in order to make sure all bits are masked by the hardware. > Also, we want matching entries to have a CHAIN_ID value set to the

[PATCH v4 net-next 0/3]

2017-11-30 Thread William Tu
change in v4: - rebase on top of net-next - use log_ecn_error in ip6_tnl_rcv change in v3: - add inline for functions in header - rebase on top of net-next change in v2: - remove inline - fix some indent - fix errors reports by clang and scan-build William Tu (3): ip_gre:

[PATCH v4 net-next 1/3] ip_gre: Refector the erpsan tunnel code.

2017-11-30 Thread William Tu
Move two erspan functions to header file, erspan.h, so ipv6 erspan implementation can use it. Signed-off-by: William Tu --- include/net/erspan.h | 51 + net/ipv4/ip_gre.c| 54

[PATCH v4 net-next 3/3] ip6_gre: Add ERSPAN native tunnel support

2017-11-30 Thread William Tu
The patch adds support for ERSPAN tunnel over ipv6. Signed-off-by: William Tu --- include/net/ip6_tunnel.h | 1 + net/ipv6/ip6_gre.c | 270 ++- 2 files changed, 267 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] rxrpc: Neaten logging macros and add KERN_DEBUG logging level

2017-11-30 Thread David Howells
Joe Perches wrote: > There is no listed rxrpc maintainer. There's a script in the kernel called get_maintainer.pl which you might find of use: warthog>./scripts/get_maintainer.pl net/rxrpc/ "David S. Miller" (maintainer:NETWORKING

Fw: [Bug 198047] New: Regression in e1000e with kernel 4.14.3

2017-11-30 Thread Stephen Hemminger
Begin forwarded message: Date: Thu, 30 Nov 2017 19:32:04 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 198047] New: Regression in e1000e with kernel 4.14.3 https://bugzilla.kernel.org/show_bug.cgi?id=198047 Bug ID: 198047

Re: [PATCH net-next] net: llc: remove init_net check

2017-11-30 Thread Eric Dumazet
On Thu, 2017-11-30 at 14:45 -0500, Alexander Aring wrote: > Commit e730c15519d09 ("[NET]: Make packet reception network namespace > safe") added several init_net compares to protocols with unknown > net namespace support. The idea was as users started using the > different > protocols they would

Re: [PATCH v7 1/5] add infrastructure for tagging functions as error injectable

2017-11-30 Thread Josef Bacik
On Wed, Nov 29, 2017 at 05:59:39PM +0100, Daniel Borkmann wrote: > On 11/28/2017 09:02 PM, Josef Bacik wrote: > > On Tue, Nov 28, 2017 at 11:58:41AM -0700, Jonathan Corbet wrote: > >> On Wed, 22 Nov 2017 16:23:30 -0500 > >> Josef Bacik wrote: > >>> From: Josef Bacik

[PATCH 3/3] net: macb: Added support for RX filtering

2017-11-30 Thread Rafal Ozieblo
This patch allows filtering received packets to different hardware queues (aka ntuple). Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/macb.h | 109 ++ drivers/net/ethernet/cadence/macb_main.c | 336 ++- 2 files

[PATCH net] net: dsa: bcm_sf2: Set correct CHAIN_ID and slice number mask

2017-11-30 Thread Florian Fainelli
When configuring an IPv6 address mask, we should use SLICE_NUM_MASK as the mask in order to make sure all bits are masked by the hardware. Also, we want matching entries to have a CHAIN_ID value set to the same value as the rule index we return to user-space for convenience, so fix that too.

Re: [PATCH net-next] tools/bpf: adjust rlimit RLIMIT_MEMLOCK for test_verifier_log

2017-11-30 Thread Daniel Borkmann
On 11/30/2017 05:52 PM, Yonghong Song wrote: > The default rlimit RLIMIT_MEMLOCK is 64KB. In certain cases, > e.g. in a test machine mimicking our production system, this test may > fail due to unable to charge the required memory for prog load: > # ./test_verifier_log > Test log_level 0... >

[PATCH net-next] net: llc: remove init_net check

2017-11-30 Thread Alexander Aring
Commit e730c15519d09 ("[NET]: Make packet reception network namespace safe") added several init_net compares to protocols with unknown net namespace support. The idea was as users started using the different protocols they would test and enable them. In our use-case we generate STP enabled Linux

Re: [PATCH] rxrpc: Neaten logging macros and add KERN_DEBUG logging level

2017-11-30 Thread Joe Perches
On Thu, 2017-11-30 at 19:34 +, David Howells wrote: > Joe Perches wrote: > > > There is no listed rxrpc maintainer. > > There's a script in the kernel called get_maintainer.pl which you might find > of use: Yeah, I've heard of it. I also wrote it btw. >

Re: [PATCH net-next 1/3] rds: tcp: remove redundant function rds_tcp_conn_paths_destroy()

2017-11-30 Thread Santosh Shilimkar
On 11/30/2017 11:11 AM, Sowmini Varadhan wrote: A side-effect of Commit c14b0366813a ("rds: tcp: set linger to 1 when unloading a rds-tcp") is that we always send a RST on the tcp connection for rds_conn_destroy(), so rds_tcp_conn_paths_destroy() is not needed any more and is removed in this

Re: [PATCH net-next 3/3] rds: tcp: atomically purge entries from rds_tcp_conn_list during netns delete

2017-11-30 Thread Santosh Shilimkar
On 11/30/2017 11:11 AM, Sowmini Varadhan wrote: The rds_tcp_kill_sock() function parses the rds_tcp_conn_list to find the rds_connection entries marked for deletion as part of the netns deletion under the protection of the rds_tcp_conn_lock. Since the rds_tcp_conn_list tracks rds_tcp_connections

  1   2   3   4   >