RE: dsa with 2 rgmii channels (1st is 2 switches & 2nd is phy)

2018-03-09 Thread Alayev Michael
Hi Andrew, You have advised me to change the compatibility to "marvell,mv88e6190". The problem is that my linux version is Xilinx 4.4.0 (2016.2) - it contains mv88e6xxx driver files that do not support 6190 (though they do support 6085) and the driver has slightly different file tree. The closes

Re: [bpf-next V2 PATCH 07/15] virtio_net: convert to use generic xdp_frame and xdp_return_frame API

2018-03-09 Thread Jason Wang
On 2018年03月08日 21:08, Jesper Dangaard Brouer wrote: The virtio_net driver assumes XDP frames are always released based on page refcnt (via put_page). Thus, is only queues the XDP data pointer address and uses virt_to_head_page() to retrieve struct page. Use the XDP return API to get away from

Re: [bpf-next V2 PATCH 10/15] xdp: rhashtable with allocator ID to pointer mapping

2018-03-09 Thread Jason Wang
On 2018年03月08日 21:08, Jesper Dangaard Brouer wrote: Use the IDA infrastructure for getting a cyclic increasing ID number, that is used for keeping track of each registered allocator per RX-queue xdp_rxq_info. Instead of using the IDR infrastructure, which uses a radix tree, use a dynamic rhash

Re: [PATCH net 2/2] l2tp: fix races with ipv4-mapped ipv6 addresses

2018-03-09 Thread Paolo Abeni
Hi, On Thu, 2018-03-08 at 19:59 +0100, Guillaume Nault wrote: > On Thu, Mar 08, 2018 at 03:37:27PM +0100, Paolo Abeni wrote: > > When creating a new socket, l2tp_tunnel_create() ensures that > > such socket is connected, but when using a socket provided by > > the user space, no check is done on t

Re: [PATCH bpf-next 1/7] tools: bpftool: silence 'missing initializer' warnings

2018-03-09 Thread Jiri Benc
On Thu, 8 Mar 2018 23:38:12 -0800, Jakub Kicinski wrote: > FWIW I couldn't reproduce this one. Out of curiosity what GCC did you > use? gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16) Jiri

Re: [bpf-next V2 PATCH 06/15] tun: convert to use generic xdp_frame and xdp_return_frame API

2018-03-09 Thread Jesper Dangaard Brouer
On Fri, 9 Mar 2018 15:16:35 +0800 Jason Wang wrote: > On 2018年03月08日 23:16, Jesper Dangaard Brouer wrote: > > Hi Jason, > > > > Please see below FIXME, which is actually a question to you. > > > > On Thu, 08 Mar 2018 14:08:11 +0100 Jesper Dangaard Brouer > > wrote: > > > >> diff --git a/drive

Re: [PATCH net-next 1/1] tc-testing: add csum tests

2018-03-09 Thread Davide Caratti
On Thu, 2018-03-08 at 14:56 -0500, Roman Mashak wrote: > Signed-off-by: Roman Mashak > --- > .../tc-testing/tc-tests/actions/csum.json | 410 > + > 1 file changed, 410 insertions(+) > create mode 100644 > tools/testing/selftests/tc-testing/tc-tests/actions/csum.jso

Re: [PATCH bpf-next 0/7] tools: bpf: standardize make

2018-03-09 Thread Daniel Borkmann
On 03/08/2018 11:00 PM, Jiri Benc wrote: > Currently, 'make bpf' in the tools/ directory does not provide the standard > quiet output except for bpftool (which is however listed with a wrong > directory). Worse, it does not respect the build output directory. > > The 'make bpf_install' does not wo

Re: [PATCH bpf-next] bpf: comment why dots in filenames under BPF virtual FS are not allowed

2018-03-09 Thread Daniel Borkmann
On 03/09/2018 08:46 AM, Jakub Kicinski wrote: > From: Quentin Monnet > > When pinning a file under the BPF virtual file system (traditionally > /sys/fs/bpf), using a dot in the name of the location to pin at is not > allowed. For example, trying to pin at "/sys/fs/bpf/foo.bar" will be > rejected

[PATCH net v2 1/2] net: ipv6: keep sk status consistent after datagram connect failure

2018-03-09 Thread Paolo Abeni
On unsuccesful ip6_datagram_connect(), if the failure is caused by ip6_datagram_dst_update(), the sk peer information are cleared, but the sk->sk_state is preserved. If the socket was already in an established status, the overall sk status is inconsistent and fouls later checks in datagram code.

[PATCH net v2 0/2] l2tp: fix races with ipv4-mapped ipv6 addresses

2018-03-09 Thread Paolo Abeni
The syzbot reported an l2tp oops that uncovered some races in the l2tp xmit path and a partially related issue in the generic ipv6 code. We need to address them separately. v1 -> v2: - add missing fixes tag in patch 1 - fix several issues in patch 2 Paolo Abeni (2): net: ipv6: keep sk status

[PATCH net v2 2/2] l2tp: fix races with ipv4-mapped ipv6 addresses

2018-03-09 Thread Paolo Abeni
When creating a new socket, l2tp_tunnel_create() ensures that such socket is connected, but when using a socket provided by the user space, no check is done on the socket state. This may foul the later check for ipv6 sockets that are ipv4-mapped, e.g. in case of unconnected ipv6 socket bound to ip

Re: [bpf-next V2 PATCH 02/15] xdp: introduce xdp_return_frame API and use in cpumap

2018-03-09 Thread Jesper Dangaard Brouer
On Fri, 9 Mar 2018 15:24:10 +0800 Jason Wang wrote: > On 2018年03月08日 21:07, Jesper Dangaard Brouer wrote: > > Introduce an xdp_return_frame API, and convert over cpumap as > > the first user, given it have queued XDP frame structure to leverage. > > > > Signed-off-by: Jesper Dangaard Brouer > >

Re: [bpf-next V2 PATCH 10/15] xdp: rhashtable with allocator ID to pointer mapping

2018-03-09 Thread Jesper Dangaard Brouer
On Fri, 9 Mar 2018 16:08:58 +0800 Jason Wang wrote: > On 2018年03月08日 21:08, Jesper Dangaard Brouer wrote: > > Use the IDA infrastructure for getting a cyclic increasing ID number, > > that is used for keeping track of each registered allocator per > > RX-queue xdp_rxq_info. Instead of using the

[PATCH net-next] net: introduce IFF_NO_RX_HANDLER

2018-03-09 Thread Paolo Abeni
Some network devices - notably ipvlan slave - are not compatible with any kind of rx_handler. Currently the hook can be installed but any configuration (bridge, bond, macsec, ...) is nonfunctional. This change allocates a priv_flag bit to mark such devices and explicitly forbid installing a rx_han

Re: [bpf-next V2 PATCH 07/15] virtio_net: convert to use generic xdp_frame and xdp_return_frame API

2018-03-09 Thread Jesper Dangaard Brouer
On Fri, 9 Mar 2018 16:03:28 +0800 Jason Wang wrote: > On 2018年03月08日 21:08, Jesper Dangaard Brouer wrote: > > The virtio_net driver assumes XDP frames are always released based on > > page refcnt (via put_page). Thus, is only queues the XDP data pointer > > address and uses virt_to_head_page() t

Re: [PATCH] net: use skb_is_gso_sctp() instead of open-coding

2018-03-09 Thread Daniel Borkmann
On 03/09/2018 04:06 AM, Daniel Axtens wrote: [...] > This depends on d02f51cbcf12 ("bpf: fix bpf_skb_adjust_net/bpf_skb_proto_xlat > to deal with gso sctp skbs") which introduces the required helper. > That is in the bpf tree at the moment. It's in net tree already by now: https://git.kernel.org/

Re: [PATCH] drivers: vhost: vsock: fixed a brace coding style issue

2018-03-09 Thread Stefan Hajnoczi
On Fri, Mar 09, 2018 at 08:26:03AM +0530, Vaibhav Murkute wrote: > Fixed a coding style issue. > > Signed-off-by: Vaibhav Murkute > --- > drivers/vhost/vsock.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

from Aziz Dake

2018-03-09 Thread Aziz Dake
Attn: Sir/Madam, I am Mr. Aziz Dake, a Minister confide on me to look for foreign partner who will assist him to invest the sum of Thirty Million Dollars ($30,000,000) in your country. He has investment interest in mining, exotic properties for commercial resident, development properties, hot

[PATCH iproute2/net-next] tc: f_flower: Add support for matching first frag packets

2018-03-09 Thread Simon Horman
From: Pieter Jansen van Vuuren Add matching support for distinguishing between first and later fragmented packets. # tc filter add dev eth0 protocol ip parent : \ flower indev eth0 \ ip_flags firstfrag \ ip_proto udp \ action mirred egress redirect dev eth1 # tc f

Re: [PATCH net-next] net: stmmac: remove superfluous wmb() memory barriers

2018-03-09 Thread Jose Abreu
Hi Niklas, On 08-03-2018 10:30, Niklas Cassel wrote: > These wmb() memory barriers are performed after the last descriptor write, > and they are followed by enable_dma_transmission()/set_tx_tail_ptr(), > i.e. a writel() to MMIO register space. > Since writel() itself performs the equivalent of a w

Re: [PATCH] rsi: Remove stack VLA usage

2018-03-09 Thread Kalle Valo
"Tobin C. Harding" writes: > The kernel would like to have all stack VLA usage removed[1]. rsi uses > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > is defined using a magic number. We can use a pre-processor defined > constant and declare the array to maximum size.

[PATCH] net: hns: use put_device() if device_register fail

2018-03-09 Thread Arvind Yadav
if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/hisilicon/hns/hnae.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c b/driv

Re: [PATCH net-next] net: stmmac: remove superfluous wmb() memory barriers

2018-03-09 Thread Pavel Machek
On Fri 2018-03-09 10:26:11, Jose Abreu wrote: > Hi Niklas, > > On 08-03-2018 10:30, Niklas Cassel wrote: > > These wmb() memory barriers are performed after the last descriptor write, > > and they are followed by enable_dma_transmission()/set_tx_tail_ptr(), > > i.e. a writel() to MMIO register spa

Re: [PATCH net-next] net: do not create fallback tunnels for non-default namespaces

2018-03-09 Thread Jiri Benc
On Thu, 8 Mar 2018 12:51:41 -0800, Eric Dumazet wrote: > Note that these tunnels are still created for the initial namespace, > to be the least intrusive for typical setups. Since this is a knob and must be turned on explicitly, why we don't get rid of the automatic interfaces even for the initia

Re: [PATCH/RFC 2/3] net/sched: act_tunnel_key: add extended ack support

2018-03-09 Thread Jiri Benc
On Tue, 6 Mar 2018 18:08:04 +0100, Simon Horman wrote: > - if (!tb[TCA_TUNNEL_KEY_PARMS]) > + if (!tb[TCA_TUNNEL_KEY_PARMS]) { > + NL_SET_ERR_MSG(extack, "Missing tunnel key parameter"); "parameters" (it's not just one parameter) > @@ -107,6 +109,7 @@ static int tunnel_key_in

Re: [PATCH/RFC 3/3] net/sched: add tunnel option support to act_tunnel_key

2018-03-09 Thread Jiri Benc
On Tue, 6 Mar 2018 18:08:05 +0100, Simon Horman wrote: > +static int > +tunnel_key_copy_geneve_opt(const struct nlattr *nla, int dst_len, void *dst, > +struct netlink_ext_ack *extack) > +{ > + struct nlattr *tb[TCA_TUNNEL_KEY_ENC_OPT_GENEVE_MAX + 1]; > + int err, da

[PATCH] net: ipv6: xfrm6_state: remove VLA usage

2018-03-09 Thread Andreas Christoforou
The kernel would like to have all stack VLA usage removed[1]. Signed-off-by: Andreas Christoforou --- net/ipv6/xfrm6_state.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/net/ipv6/xfrm6_state.c b/net/ipv6/xfrm6_state.c index b15075a..45c0d98 100644 --- a/net/ipv6/xfr

[PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

2018-03-09 Thread Andreas Christoforou
The kernel would like to have all stack VLA usage removed. Signed-off-by: Andreas Christoforou --- drivers/net/wireless/ath/ath9k/dfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/dfs.c b/drivers/net/wireless/ath/ath9k/dfs.c index 6fee9a4

Re: [PATCH] net: ipv6: xfrm6_state: remove VLA usage

2018-03-09 Thread Steffen Klassert
On Fri, Mar 09, 2018 at 02:21:46PM +0200, Andreas Christoforou wrote: > The kernel would like to have all stack VLA usage removed[1]. > > Signed-off-by: Andreas Christoforou Can you please explain why you want this change?

Re: [PATCH] net: ipv6: xfrm6_state: remove VLA usage

2018-03-09 Thread Mathias Krause
On 9 March 2018 at 13:21, Andreas Christoforou wrote: > The kernel would like to have all stack VLA usage removed[1]. > > Signed-off-by: Andreas Christoforou > --- > net/ipv6/xfrm6_state.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/net/ipv6/xfrm6_state.c b/ne

Re: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

2018-03-09 Thread Himanshu Jha
On Fri, Mar 09, 2018 at 02:30:12PM +0200, Andreas Christoforou wrote: > The kernel would like to have all stack VLA usage removed. > > Signed-off-by: Andreas Christoforou > --- > drivers/net/wireless/ath/ath9k/dfs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/driv

Re: linux-next: manual merge of the selinux tree with the net-next tree

2018-03-09 Thread Marcelo Ricardo Leitner
On Thu, Mar 08, 2018 at 01:07:03PM +1100, Stephen Rothwell wrote: > The resolution now looks like below (there were more changes to this > file in the net-next tree). It will keep changing every time this file > is touched :-( Ugh, sorry for that, Stephen. Considering how much of a hassle this a

Re: [PATCH net-next] net: do not create fallback tunnels for non-default namespaces

2018-03-09 Thread Eric Dumazet
Hi Jiri On Fri, Mar 9, 2018 at 3:06 AM, Jiri Benc wrote: > On Thu, 8 Mar 2018 12:51:41 -0800, Eric Dumazet wrote: >> Note that these tunnels are still created for the initial namespace, >> to be the least intrusive for typical setups. > > Since this is a knob and must be turned on explicitly, wh

Re: [PATCH] net: ipv6: xfrm6_state: remove VLA usage

2018-03-09 Thread Steffen Klassert
On Fri, Mar 09, 2018 at 01:49:07PM +0100, Mathias Krause wrote: > On 9 March 2018 at 13:21, Andreas Christoforou > wrote: > > The kernel would like to have all stack VLA usage removed[1]. > > > > Signed-off-by: Andreas Christoforou > > --- > > net/ipv6/xfrm6_state.c | 8 +++- > > 1 file chan

Re: [bpf-next V2 PATCH 02/15] xdp: introduce xdp_return_frame API and use in cpumap

2018-03-09 Thread Jason Wang
On 2018年03月09日 17:35, Jesper Dangaard Brouer wrote: On Fri, 9 Mar 2018 15:24:10 +0800 Jason Wang wrote: On 2018年03月08日 21:07, Jesper Dangaard Brouer wrote: Introduce an xdp_return_frame API, and convert over cpumap as the first user, given it have queued XDP frame structure to leverage. Si

Re: [bpf-next V2 PATCH 10/15] xdp: rhashtable with allocator ID to pointer mapping

2018-03-09 Thread Jason Wang
On 2018年03月09日 17:37, Jesper Dangaard Brouer wrote: On Fri, 9 Mar 2018 16:08:58 +0800 Jason Wang wrote: On 2018年03月08日 21:08, Jesper Dangaard Brouer wrote: Use the IDA infrastructure for getting a cyclic increasing ID number, that is used for keeping track of each registered allocator per R

Re: [PATCH net-next] net: do not create fallback tunnels for non-default namespaces

2018-03-09 Thread Jiri Benc
On Fri, 9 Mar 2018 04:53:07 -0800, Eric Dumazet wrote: > Unless you bring it up ;) Often, you need some options to be specified, thus you end up creating another interface anyway. > Compatibility problems, mostly. > Some users might depend on existing behavior. How is this a compatibility probl

Re: [bpf-next V2 PATCH 07/15] virtio_net: convert to use generic xdp_frame and xdp_return_frame API

2018-03-09 Thread Jason Wang
On 2018年03月09日 17:44, Jesper Dangaard Brouer wrote: On Fri, 9 Mar 2018 16:03:28 +0800 Jason Wang wrote: On 2018年03月08日 21:08, Jesper Dangaard Brouer wrote: The virtio_net driver assumes XDP frames are always released based on page refcnt (via put_page). Thus, is only queues the XDP data po

Re: [PATCH net-next] net: do not create fallback tunnels for non-default namespaces

2018-03-09 Thread Eric Dumazet
On Fri, Mar 9, 2018 at 5:08 AM, Jiri Benc wrote: > On Fri, 9 Mar 2018 04:53:07 -0800, Eric Dumazet wrote: >> Unless you bring it up ;) > > Often, you need some options to be specified, thus you end up creating > another interface anyway. > >> Compatibility problems, mostly. >> Some users might de

[PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage

2018-03-09 Thread Andreas Christoforou
The kernel would like to have all stack VLA usage removed. This is the correct patch. Signed-off-by: Andreas Christoforou --- drivers/net/wireless/ath/ath9k/dfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/dfs.c b/drivers/net/wireless/ath

[PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

2018-03-09 Thread Mohammed Gamal
Commit 009f766 intended to filter multicast/broadcast, however the NDIS filter wasn't set properly in non-promiscuous modes, which resulted in issues like DHCP timeouts. This patch sets the filter flags correctly. Fixes: 009f766 ("hv_netvsc: filter multicast/broadcast") Signed-off-by: Mohammed Ga

Re: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage

2018-03-09 Thread Joe Perches
On Fri, 2018-03-09 at 15:23 +0200, Andreas Christoforou wrote: > The kernel would like to have all stack VLA usage removed. > This is the correct patch. [] > diff --git a/drivers/net/wireless/ath/ath9k/dfs.c > b/drivers/net/wireless/ath/ath9k/dfs.c [] > @@ -101,7 +101,7 @@ static bool ath9k_check_

[PATCH net 0/2] mlxsw: ACL and mirroring fixes

2018-03-09 Thread Ido Schimmel
Hi, The first patch fixes offload of rules using the 'pass' action. Instead of continuing to evaluate lower priority rules, the binding is terminated and the packet proceeds to the bridge and router blocks on ingress, or goes out of the port on egress. Second patch prevents the user from mirrorin

Re: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage

2018-03-09 Thread Eric Dumazet
On 03/09/2018 05:23 AM, Andreas Christoforou wrote: The kernel would like to have all stack VLA usage removed. This is the correct patch. Signed-off-by: Andreas Christoforou This is a lazy changelog really. 'This is the correct patch' has no technical value. What is VLA ? Sure, _now_ it

[PATCH net 1/2] mlxsw: spectrum: Fix gact_ok offloading

2018-03-09 Thread Ido Schimmel
From: Jiri Pirko For ok GACT action, TERMINATE binding_cmd should be used in action set passed down to HW. Fixes: b2925957ec1a9 ("mlxsw: spectrum_flower: Offload "ok" termination action") Signed-off-by: Jiri Pirko Reported-by: Alexander Petrovskiy Signed-off-by: Ido Schimmel --- drivers/net/

[PATCH net 2/2] mlxsw: spectrum: Prevent duplicate mirrors

2018-03-09 Thread Ido Schimmel
From: Petr Machata The Spectrum ASIC doesn't support mirroring more than once from a single binding point (which is a port-direction pair). Therefore detect that a second binding of a given binding point is attempted. To that end, extend struct mlxsw_sp_span_inspected_port to track whether a giv

Re: [PATCH net 2/2] mlxsw: spectrum: Prevent duplicate mirrors

2018-03-09 Thread Ido Schimmel
+Stephen On Fri, Mar 09, 2018 at 03:33:53PM +0200, Ido Schimmel wrote: > From: Petr Machata > > The Spectrum ASIC doesn't support mirroring more than once from a single > binding point (which is a port-direction pair). Therefore detect that a > second binding of a given binding point is attempte

[PATCH v2 net 4/5] tcp: prevent bogus undos when SACK is not enabled

2018-03-09 Thread Ilpo Järvinen
When a cumulative ACK lands to high_seq at the end of loss recovery and SACK is not enabled, the sender needs to avoid false fast retransmits (RFC6582). The avoidance mechanisms is implemented by remaining in the loss recovery CA state until one additional cumulative ACK arrives. During the operati

[PATCH v2 net 0/5] tcp: fixes to non-SACK TCP

2018-03-09 Thread Ilpo Järvinen
Here is a series of fixes to issues that occur when SACK is not enabled for a TCP connection. These are not fixes to just some remote corner cases of recovery but many/almost all recoveries without SACK will be impacted by one (or even more than one) of them. The bogus bursts that the sender side f

[PATCH v2 net 3/5] tcp: move false FR condition into tcp_false_fast_retrans_possible()

2018-03-09 Thread Ilpo Järvinen
No functional changes. This change simplifies the next change slightly. Signed-off-by: Ilpo Järvinen --- net/ipv4/tcp_input.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 1277afb..4ccba94 100644 --- a/n

[PATCH v2 net 2/5] tcp: prevent bogus FRTO undos with non-SACK flows

2018-03-09 Thread Ilpo Järvinen
If SACK is not enabled and the first cumulative ACK after the RTO retransmission covers more than the retransmitted skb, a spurious FRTO undo will trigger (assuming FRTO is enabled for that RTO). The reason is that any non-retransmitted segment acknowledged will set FLAG_ORIG_SACK_ACKED in tcp_clea

[PATCH v2 net 5/5] tcp: send real dupACKs by locking advertized window for non-SACK flows

2018-03-09 Thread Ilpo Järvinen
Currently, the TCP code is overly eager to increase window on almost every ACK. It makes those ACKs that the receiver should sent as dupACKs look like they update window that is not considered a real dupACK by the non-SACK sender-side code. Therefore the sender needs to resort to RTO to recover los

Re: [PATCH net 4/5] tcp: prevent bogus undos when SACK is not enabled

2018-03-09 Thread Ilpo Järvinen
On Wed, 7 Mar 2018, Yuchung Cheng wrote: > On Wed, Mar 7, 2018 at 12:19 PM, Neal Cardwell wrote: > > > > On Wed, Mar 7, 2018 at 7:59 AM, Ilpo Järvinen > > wrote: > > > A bogus undo may/will trigger when the loss recovery state is > > > kept until snd_una is above high_seq. If tcp_any_retrans_do

[PATCH v2 net 1/5] tcp: feed correct number of pkts acked to cc modules also in recovery

2018-03-09 Thread Ilpo Järvinen
A miscalculation for the number of acknowledged packets occurs during RTO recovery whenever SACK is not enabled and a cumulative ACK covers any non-retransmitted skbs. The reason is that pkts_acked value calculated in tcp_clean_rtx_queue is not correct for slow start after RTO as it may include seg

Re: dsa with 2 rgmii channels (1st is 2 switches & 2nd is phy)

2018-03-09 Thread Andrew Lunn
On Fri, Mar 09, 2018 at 08:00:40AM +, Alayev Michael wrote: > Hi Andrew, > > You have advised me to change the compatibility to "marvell,mv88e6190". > The problem is that my linux version is Xilinx 4.4.0 (2016.2) - it contains > mv88e6xxx driver files that do not support 6190 (though they do

Re: [PATCH net 4/5] tcp: prevent bogus undos when SACK is not enabled

2018-03-09 Thread Eric Dumazet
On 03/09/2018 06:11 AM, Ilpo Järvinen wrote: On Wed, 7 Mar 2018, Yuchung Cheng wrote: On Wed, Mar 7, 2018 at 12:19 PM, Neal Cardwell wrote: On Wed, Mar 7, 2018 at 7:59 AM, Ilpo Järvinen wrote: A bogus undo may/will trigger when the loss recovery state is kept until snd_una is above high_

Re: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

2018-03-09 Thread Kalle Valo
Himanshu Jha writes: > On Fri, Mar 09, 2018 at 02:30:12PM +0200, Andreas Christoforou wrote: >> The kernel would like to have all stack VLA usage removed. >> >> Signed-off-by: Andreas Christoforou >> --- >> drivers/net/wireless/ath/ath9k/dfs.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 dele

Re: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage

2018-03-09 Thread Kalle Valo
Andreas Christoforou writes: > The kernel would like to have all stack VLA usage removed. > > This is the correct patch. > > Signed-off-by: Andreas Christoforou Please use versioning in the patches: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_mi

[PATCH ethtool 0/3] RSS ntuple filters

2018-03-09 Thread Edward Cree
This series adds support for the management of extra RSS contexts and RSS spreading of ntuple/NFC filters introduced in kernel commit 84a1d9c48200 ("net: ethtool: extend RXNFC API to support RSS spreading of filter matches"). Edward Cree (3): ethtool-copy.h: sync with net-next ethtool: add s

[PATCH ethtool 1/3] ethtool-copy.h: sync with net-next

2018-03-09 Thread Edward Cree
This covers kernel changes up to commit 84a1d9c48200, net: ethtool: extend RXNFC API to support RSS spreading of filter matches Signed-off-by: Edward Cree --- ethtool-copy.h | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/ethtool-copy.h b

[PATCH ethtool 3/3] ethtool.8: Document RSS context control and RSS filters

2018-03-09 Thread Edward Cree
Signed-off-by: Edward Cree --- ethtool.8.in | 28 1 file changed, 28 insertions(+) diff --git a/ethtool.8.in b/ethtool.8.in index 690e55e..99ac62f 100644 --- a/ethtool.8.in +++ b/ethtool.8.in @@ -274,6 +274,7 @@ ethtool \- query or control network driver and hardware

[PATCH ethtool 2/3] ethtool: add support for extra RSS contexts and RSS steering filters

2018-03-09 Thread Edward Cree
RSS contexts can be created on a device with -X ... context new, modified with -X ... context N, and deleted with -X ... context N delete. N-tuple filters can be directed at those contexts with -N ... context N. Signed-off-by: Edward Cree --- ethtool.c | 141 +++

Re: [PATCH net] test_rhashtable: Add missing rcu_read_lock()

2018-03-09 Thread Herbert Xu
On Thu, Mar 08, 2018 at 07:10:47PM +0200, Paul Blakey wrote: > > I know but I wanted to show the inner structure for the failure case, iirc > walk doesn't provide this. Fair enough. Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor

Re: [PATCH net-next] net: stmmac: remove superfluous wmb() memory barriers

2018-03-09 Thread David Miller
From: Jose Abreu Date: Fri, 9 Mar 2018 10:26:11 + > Sorry but I know at least two architectures which don't do a > wmb() upon an writel [1] [2]. This can be critical if if we are > accessing the device through some slow or filled bus which will > delay accesses to the device IO. Notice that w

Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

2018-03-09 Thread David Miller
From: Mohammed Gamal Date: Fri, 9 Mar 2018 12:22:22 +0100 > Commit 009f766 intended to filter multicast/broadcast, however > it did cause DHCP timeouts. A closer look showed that the filters > were not set properly causing this issue. > > Fixes: 009f766 ("hv_netvsc: filter multicast/broadcast")

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-09 Thread Andy Lutomirski
>> On Mar 8, 2018, at 9:08 PM, Alexei Starovoitov wrote: >> >> On 3/8/18 7:54 PM, Andy Lutomirski wrote: >> >> >> >>> On Mar 8, 2018, at 7:06 PM, Linus Torvalds >>> wrote: >>> >>> >>> Honestly, that "read twice" thing may be what scuttles this. >>> Initially, I thought it was a non-issue, becaus

GREETINGS FROM MOHAMMED AHMED .

2018-03-09 Thread Mr Mohamad Ahmed
My Dear Friend. I am Mr. Mohammed Ahmed a banker in Bank of Africa Burkina Faso West Africa, Please i want to transfer an abandoned sum of 13.5 millions USD to your account.50% will be for you and 50% for me. No risk involved. Contact me for more details along with your personal information neede

Re: [PATCH net 4/5] tcp: prevent bogus undos when SACK is not enabled

2018-03-09 Thread David Miller
From: Ilpo Järvinen Date: Fri, 9 Mar 2018 16:11:47 +0200 (EET) > Unfortunately I don't have now permission to publish the time-seq > graph about it but I've tried to improve the changelog messages so > that you can better understand under which conditions the problem > occurs. It is indeed extre

Re: [PATCH net 4/5] tcp: prevent bogus undos when SACK is not enabled

2018-03-09 Thread David Miller
From: Eric Dumazet Date: Fri, 9 Mar 2018 06:32:21 -0800 > We have the goal of updating packetdrill and publish soon our > regression suite (about 1500 TCP tests) > > CC Willem who is working on that. Excellent news!

[PATCH net 0/3] a couple of erspan fixes

2018-03-09 Thread William Tu
The series fixes a couple of erspan issues. The first patch adds the erspan v2 proto type to the ip6 tunnel lookup. The second patch improves the error handling when users screws the version number in metadata. The final patch makes sure the skb has enough headroom for pushing erspan header when x

[PATCH net 1/3] ip6gre: add erspan v2 to tunnel lookup

2018-03-09 Thread William Tu
The patch adds the erspan v2 proto in ip6gre_tunnel_lookup so the erspan v2 tunnel can be found correctly. Signed-off-by: William Tu --- net/ipv6/ip6_gre.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index 18a3dfbd0300..a056c2bb4b

[PATCH net 2/3] ip6erspan: improve error handling for erspan version number.

2018-03-09 Thread William Tu
When users fill in incorrect erspan version number through the struct erspan_metadata uapi, current code skips pushing the erspan header but continue pushing the gre header, which is incorrect. The patch fixes it by returning error. Signed-off-by: William Tu --- net/ipv6/ip6_gre.c | 2 ++ 1 fil

[PATCH net 3/3] ip6erspan: make sure enough headroom at xmit.

2018-03-09 Thread William Tu
The patch adds skb_cow_header() to ensure enough headroom at ip6erspan_tunnel_xmit before pushing the erspan header to the skb. Signed-off-by: William Tu --- net/ipv6/ip6_gre.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index 4ab476d3a46e..9a75

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2018-03-09 Thread David Woodhouse
On Fri, 2015-03-06 at 17:37 +0100, Florian Westphal wrote: > > > > I did performance measurements in the following way: > > >  > > > Removed those pieces of the packet pipeline that I don't necessarily > > > need one-by-one.  Then measured their effect on small packet > > > performance. > > >  >

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-09 Thread Alexei Starovoitov
On 3/9/18 7:16 AM, Andy Lutomirski wrote: On Mar 8, 2018, at 9:08 PM, Alexei Starovoitov wrote: On 3/8/18 7:54 PM, Andy Lutomirski wrote: On Mar 8, 2018, at 7:06 PM, Linus Torvalds wrote: Honestly, that "read twice" thing may be what scuttles this. Initially, I thought it was a non-issu

Re: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage

2018-03-09 Thread Rosen Penev
On Fri, Mar 9, 2018 at 5:29 AM, Joe Perches wrote: > On Fri, 2018-03-09 at 15:23 +0200, Andreas Christoforou wrote: >> The kernel would like to have all stack VLA usage removed. >> This is the correct patch. > [] >> diff --git a/drivers/net/wireless/ath/ath9k/dfs.c >> b/drivers/net/wireless/ath/a

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2018-03-09 Thread David Miller
From: David Woodhouse Date: Fri, 09 Mar 2018 15:31:15 + > Eschewing a 15% speedup on the basis that "well, even though we've had > three of these already for a decade, we're worried that adding a fourth > might open the floodgates to further patches" does seem a little odd to > me, FWIW. The

Re: [bpf-next V2 PATCH 02/15] xdp: introduce xdp_return_frame API and use in cpumap

2018-03-09 Thread Jesper Dangaard Brouer
On Fri, 9 Mar 2018 21:04:23 +0800 Jason Wang wrote: > On 2018年03月09日 17:35, Jesper Dangaard Brouer wrote: > > On Fri, 9 Mar 2018 15:24:10 +0800 > > Jason Wang wrote: > > > >> On 2018年03月08日 21:07, Jesper Dangaard Brouer wrote: > >>> Introduce an xdp_return_frame API, and convert over cpumap

Re: [bpf-next V2 PATCH 10/15] xdp: rhashtable with allocator ID to pointer mapping

2018-03-09 Thread Jesper Dangaard Brouer
On Fri, 9 Mar 2018 21:07:36 +0800 Jason Wang wrote: > >>> Use the IDA infrastructure for getting a cyclic increasing ID number, > >>> that is used for keeping track of each registered allocator per > >>> RX-queue xdp_rxq_info. > >>> > >>> Signed-off-by: Jesper Dangaard Brouer > >> A stupid q

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2018-03-09 Thread David Woodhouse
On Fri, 2018-03-09 at 10:57 -0500, David Miller wrote: > From: David Woodhouse > Date: Fri, 09 Mar 2018 15:31:15 + > > > Eschewing a 15% speedup on the basis that "well, even though we've had > > three of these already for a decade, we're worried that adding a fourth > > might open the floo

Re: [PATCH net v2] ipv6: fix access to non-linear packet in ndisc_fill_redirect_hdr_option()

2018-03-09 Thread David Miller
From: Lorenzo Bianconi Date: Thu, 8 Mar 2018 17:00:02 +0100 > Fix the following slab-out-of-bounds kasan report in > ndisc_fill_redirect_hdr_option when the incoming ipv6 packet is not > linear and the accessed data are not in the linear data region of orig_skb. ... > The test scenario to trigg

Re: [PATCH net] ieee802154: 6lowpan: fix possible NULL deref in lowpan_device_event()

2018-03-09 Thread David Miller
From: Stefan Schmidt Date: Thu, 8 Mar 2018 17:21:49 +0100 > Did you miss this or would you prefer if I do a pull request for > this single patch? Either way would be fine with me. Sorry, this escaped me. Applied and queued up for -stable, thanks.

Re: [PATCH net-next 1/1] tc-testing: add csum tests

2018-03-09 Thread David Miller
From: Roman Mashak Date: Thu, 8 Mar 2018 14:56:43 -0500 > Signed-off-by: Roman Mashak Applied, thanks.

Re: [PATCH net-next] net: dsa: mv88e6xxx: Fix irq free'ing

2018-03-09 Thread David Miller
From: Andrew Lunn Date: Thu, 8 Mar 2018 21:21:36 +0100 > Call the common irq free function, rather than going recursive and > blowing away the stack, followed by the machine. > > Fixes: 294d711ee8c0 ("net: dsa: mv88e6xxx: Poll when no interrupt defined") > Signed-off-by: Andrew Lunn Applied,

Re: [PATCH v2 net-next] tools: tc-testing: Can refer to $TESTID in test spec

2018-03-09 Thread David Miller
From: "Brenda J. Butler" Date: Thu, 8 Mar 2018 15:27:44 -0500 > When processing the commands in the test cases, substitute > the test id for $TESTID. This helps to make more flexible > tests. For example, the testid can be given as a command > line argument. > > As an example, if we wish to s

Re: [PATCH v2 net-next] tools: tc-testing: Can pause just before post-suite

2018-03-09 Thread David Miller
From: "Brenda J. Butler" Date: Thu, 8 Mar 2018 15:28:03 -0500 > With option -P, the test script will pause just before > the post_suite functions are called. This allows the tester to > inspect the system before it is torn down. > > Signed-off-by: Brenda J. Butler This looks a lot better, ap

Re: [PATCH net-next] net: do not create fallback tunnels for non-default namespaces

2018-03-09 Thread David Miller
From: Eric Dumazet Date: Thu, 8 Mar 2018 12:51:41 -0800 > fallback tunnels (like tunl0, gre0, gretap0, erspan0, sit0, > ip6tnl0, ip6gre0) are automatically created when the corresponding > module is loaded. > > These tunnels are also automatically created when a new network > namespace is creat

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-09 Thread Andy Lutomirski
On Fri, Mar 9, 2018 at 3:39 PM, Alexei Starovoitov wrote: > On 3/9/18 7:16 AM, Andy Lutomirski wrote: On Mar 8, 2018, at 9:08 PM, Alexei Starovoitov wrote: On 3/8/18 7:54 PM, Andy Lutomirski wrote: > On Mar 8, 2018, at 7:06 PM, Linus Torvalds > wrote: >

Re: [PATCH v3 net-next 0/4] Fix event generation for actions batch Add/Delete mode

2018-03-09 Thread David Miller
From: Roman Mashak Date: Thu, 8 Mar 2018 16:59:16 -0500 > When adding or deleting a batch of entries, the kernel sends upto > TCA_ACT_MAX_PRIO entries in an event to user space. However it does not > consider that the action sizes may vary and require different skb sizes. > > For example : > >

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2018-03-09 Thread Florian Westphal
David Woodhouse wrote: > > > On Fri, 2015-03-06 at 17:37 +0100, Florian Westphal wrote: > > > > > > I did performance measurements in the following way: > > > >  > > > > Removed those pieces of the packet pipeline that I don't necessarily > > > > need one-by-one.  Then measured their effect on

Re: [PATCH net-next 0/9] fixes for configuration lost problems

2018-03-09 Thread David Miller
From: Peng Li Date: Fri, 9 Mar 2018 10:36:55 +0800 > This patchset refactors some functions and some bugs in order > to fix the configuration loss problem when resetting and > setting channel number. Series applied, thank you.

Re: [PATCH] drivers: vhost: vsock: fixed a brace coding style issue

2018-03-09 Thread David Miller
From: Vaibhav Murkute Date: Fri, 9 Mar 2018 08:26:03 +0530 > Fixed a coding style issue. > > Signed-off-by: Vaibhav Murkute Applied to net-next, thanks.

Re: [PATCH] net: use skb_is_gso_sctp() instead of open-coding

2018-03-09 Thread David Miller
From: Daniel Axtens Date: Fri, 9 Mar 2018 14:06:09 +1100 > As well as the basic conversion, I noticed that a lot of the > SCTP code checks gso_type without first checking skb_is_gso() > so I have added that where appropriate. > > Also, document the helper. > > Cc: Daniel Borkmann > Cc: Marcel

[PATCH net] ipv4: lock mtu in fnhe when received PMTU < net.ipv4.route.min_pmtu

2018-03-09 Thread Sabrina Dubroca
Prior to the rework of PMTU information storage in commit 2c8cec5c10bc ("ipv4: Cache learned PMTU information in inetpeer."), when a PMTU event advertising a PMTU smaller than net.ipv4.route.min_pmtu was received, we would disable setting the DF flag on packets by locking the MTU metric, and set th

Re: [PATCH net v2 2/2] l2tp: fix races with ipv4-mapped ipv6 addresses

2018-03-09 Thread Guillaume Nault
> diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c > index 83421c6f0bef..9726e3f37745 100644 > --- a/net/l2tp/l2tp_core.c > +++ b/net/l2tp/l2tp_core.c > @@ -1112,11 +1125,32 @@ int l2tp_xmit_skb(struct l2tp_session *session, > struct sk_buff *skb, int hdr_len > goto out_unloc

Re: [PATCH net 1/3] vhost_net: initialize rx_ring in vhost_net_open()

2018-03-09 Thread Michael S. Tsirkin
On Fri, Mar 09, 2018 at 02:50:32PM +0800, Jason Wang wrote: > From: Alexander Potapenko > > KMSAN reported a use of uninit memory in vhost_net_buf_unproduce() > while trying to access n->vqs[VHOST_NET_VQ_TX].rx_ring: > > == > BUG: K

Re: [PATCH net 2/3] vhost_net: keep private_data and rx_ring synced

2018-03-09 Thread Michael S. Tsirkin
On Fri, Mar 09, 2018 at 02:50:33PM +0800, Jason Wang wrote: > We get pointer ring from the exported sock, this means we should keep > rx_ring and vq->private synced during both vq stop and backend set, > otherwise we may see stale rx_ring. > > Fixes: c67df11f6e480 ("vhost_net: try batch dequing fr

Re: [PATCH net 0/3] Several fixes for vhost_net ptr_ring usage

2018-03-09 Thread Michael S. Tsirkin
On Fri, Mar 09, 2018 at 02:50:31PM +0800, Jason Wang wrote: > Hi: > > This small series try to fix several bugs of ptr_ring usage in > vhost_net. Please review. > > Thanks ACK series, thanks Jason! > Alexander Potapenko (1): > vhost_net: initialize rx_ring in vhost_net_open() > > Jason Wang

Re: [PATCH] pktgen: Remove VLA usage

2018-03-09 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 8 Mar 2018 23:43:40 -0600 > In preparation to enabling -Wvla, remove VLA usage and replace it > with a fixed-length array instead. > > Signed-off-by: Gustavo A. R. Silva > --- > David, > > I'm not sure how often this function is being called and, > depend

  1   2   3   >