[PATCH bpf v3] x86/cpufeature: bpf hack for clang not supporting asm goto

Commit d0266046ad54 ("x86: Remove FAST_FEATURE_TESTS") removed X86_FAST_FEATURE_TESTS and make macro static_cpu_has() always use __always_inline function _static_cpu_has() funciton. The static_cpu_has() uses gcc feature asm goto construct, which is not supported by clang. Issues ==

Re: VRF: ICMPV6 Echo Reply failed to egress if ingress pkt Src is IPV6 Global and Dest is IPV6 Link Local.

On 4/30/18 6:58 AM, Sukumar Gopalakrishnan wrote: > VRF: ICMPV6 Echo Reply failed to egress if ingress pkt Src is IPV6 > Global and Dest is IPV6 Link Local. ... > if (fl6->flowi6_oif == dev->ifindex) { try adding ' && !rt6_need_strict(saddr)' to the above. If it works, add a comment above the

Re: INFO: rcu detected stall in __schedule

On Thu, May 3, 2018 at 7:45 AM, Tetsuo Handa wrote: > I'm not sure whether this is a PPP bug. > > As of uptime = 484, RCU says that it stalled for 125 seconds. > > -- > [ 484.407032] INFO: rcu_sched self-detected stall on CPU > [ 484.412488] 0-...!:

[PATCH v6] bpf, x86_32: add eBPF JIT compiler for ia32

The JIT compiler emits ia32 bit instructions. Currently, It supports eBPF only. Classic BPF is supported because of the conversion by BPF core. Almost all instructions from eBPF ISA supported except the following: BPF_ALU64 | BPF_DIV | BPF_K BPF_ALU64 | BPF_DIV | BPF_X BPF_ALU64 | BPF_MOD | BPF_K

[PATCH net-next] cxgb4: update latest firmware version supported

Change t4fw_version.h to update latest firmware version number to 1.19.1.0. Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/t4fw_version.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [PATCH net-next v3 2/2] openvswitch: Support conntrack zone limit

On Mon, Apr 30, 2018 at 2:28 PM, Yi-Hung Wei wrote: > Currently, nf_conntrack_max is used to limit the maximum number of > conntrack entries in the conntrack table for every network namespace. > For the VMs and containers that reside in the same namespace, > they share the

Re: DSA switch

On Wed, May 2, 2018 at 11:56 PM, Andrew Lunn wrote: > On Wed, May 02, 2018 at 11:20:05PM +0300, Ran Shalit wrote: >> Hello, >> >> Is it possible to use switch just like external real switch, >> connecting all ports to the same subnet ? > > Yes. Just bridge all ports/interfaces

Re: [PATCH RFC net-next] net: ipvs: Adjust gso_size for IPPROTO_TCP

On Wed, May 02, 2018 at 10:30:32PM +0300, Julian Anastasov wrote: > > Hello, > > On Wed, 2 May 2018, Martin KaFai Lau wrote: > > > On Wed, May 02, 2018 at 09:38:43AM +0300, Julian Anastasov wrote: > > > > > > - initial traffic for port 21 does not use GSO. But after > > > every packet

Re: DSA switch

On Thu, May 3, 2018 at 10:11 AM, Jiri Pirko wrote: > Thu, May 03, 2018 at 08:50:52AM CEST, ransha...@gmail.com wrote: >>On Wed, May 2, 2018 at 11:56 PM, Andrew Lunn wrote: >>> On Wed, May 02, 2018 at 11:20:05PM +0300, Ran Shalit wrote: Hello, Is

Re: [PATCH net] macsonic: Set platform device coherent_dma_mask

Hi Finn, On Thu, May 3, 2018 at 6:24 AM, Finn Thain wrote: > Set the device's coherent_dma_mask to avoid a WARNING splat. > Please see commit 205e1b7f51e4 ("dma-mapping: warn when there is > no coherent_dma_mask"). > > Cc: linux-m...@lists.linux-m68k.org >

Re: [PATCH net-next v3 1/2] openvswitch: Add conntrack limit netlink definition

On Mon, Apr 30, 2018 at 2:28 PM, Yi-Hung Wei wrote: > Define netlink messages and attributes to support user kernel > communication that uses the conntrack limit feature. > > Signed-off-by: Yi-Hung Wei > --- > include/uapi/linux/openvswitch.h | 62 >

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

Hi Finn, On Thu, May 3, 2018 at 6:23 AM, Finn Thain wrote: > Set the device's coherent_dma_mask to avoid a WARNING splat. > Please see commit 205e1b7f51e4 ("dma-mapping: warn when there is > no coherent_dma_mask"). > > Cc: linux-m...@lists.linux-m68k.org > Tested-by:

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

On 2018年05月03日 10:09, Tiwei Bie wrote: So how about we use the straightforward way then? You mean we do new += vq->vring_packed.num instead of event_idx -= vq->vring_packed.num before calling vring_need_event()? The problem is that, the second param (new_idx) of vring_need_event() will be

Re: r8169 doesn't work after boot until `transmit queue 0 timed out`

On Fri, Apr 27, 2018 at 8:22 PM, ojab // wrote: > Oh hai! > > I've created bugzilla ticket about this, but I'm not sure if anyone > reads it, so duplicating here. > > I have new motherboard (ASUS A320-K) with 10ec:8168 realtek network > card installed and it doesn't work (i. e.

Re: [PATCH v2 bpf-next 1/2] bpf: enable stackmap with build_id in nmi context

On Wed, May 02, 2018 at 04:20:29PM -0700, Song Liu wrote: > Currently, we cannot parse build_id in nmi context because of > up_read(>mm->mmap_sem), this makes stackmap with build_id > less useful. This patch enables parsing build_id in nmi by putting > the up_read() call in irq_work. To avoid

Re: DSA switch

Thu, May 03, 2018 at 08:50:52AM CEST, ransha...@gmail.com wrote: >On Wed, May 2, 2018 at 11:56 PM, Andrew Lunn wrote: >> On Wed, May 02, 2018 at 11:20:05PM +0300, Ran Shalit wrote: >>> Hello, >>> >>> Is it possible to use switch just like external real switch, >>> connecting all

Re: [PATCH v2 bpf-next 2/2] bpf: add selftest for stackmap with build_id in NMI context

On Wed, May 02, 2018 at 04:20:30PM -0700, Song Liu wrote: > This new test captures stackmap with build_id with hardware event > PERF_COUNT_HW_CPU_CYCLES. > > Because we only support one ips-to-build_id lookup per cpu in NMI > context, stack_amap will not be able to do the lookup in this test.

Re: [RFC V3 PATCH 1/8] vhost: move get_rx_bufs to vhost.c

On 2018年05月02日 16:05, Tiwei Bie wrote: On Mon, Apr 23, 2018 at 01:34:53PM +0800, Jason Wang wrote: Move get_rx_bufs() to vhost.c and rename it to vhost_get_rx_bufs(). This helps to hide vring internal layout from A small typo. Based on the code change in this patch, it seems that this

[PATCH net-next 2/2] selftests: forwarding: Allow running specific tests

Similar to commit a511858c7536 ("selftests: fib_tests: Allow user to run a specific test"), allow user to run only a subset of the tests using the TESTS environment variable. This is useful when not all the tests can pass on a given system. Example: # export TESTS="ping_ipv4 ping_ipv6" #

[PATCH net-next 0/2] selftests: forwarding: Two enhancements

First patch increases the maximum deviation in the multipath tests which proved to be too low in some cases. Second patch allows user to run only specific tests from each file using the TESTS environment variable. This granularity is needed in setups where not all the tests can pass. Ido

[PATCH net-next 1/2] selftests: forwarding: Increase maximum deviation in multipath test

We sometimes observe failures in the test due to too large discrepancy between the measured and expected ratios. For example: TEST: ECMP [FAIL] Too large discrepancy between expected and measured ratios INFO: Expected ratio

Re: [PATCH net-next 2/2] selftests: forwarding: Allow running specific tests

Thu, May 03, 2018 at 09:51:33AM CEST, ido...@mellanox.com wrote: >Similar to commit a511858c7536 ("selftests: fib_tests: Allow user to run >a specific test"), allow user to run only a subset of the tests using >the TESTS environment variable. > >This is useful when not all the tests can pass on a

Re: [PATCH net-next v7 3/7] sch_cake: Add optional ACK filter

Hi Toke, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/sched-Add-Common-Applications-Kept-Enhanced-cake-qdisc/20180503-073002 coccinelle warnings: (new ones prefixed

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

On Thu, 3 May 2018, Geert Uytterhoeven wrote: > > --- a/drivers/net/ethernet/apple/macmace.c > > +++ b/drivers/net/ethernet/apple/macmace.c > > @@ -203,6 +203,10 @@ static int mace_probe(struct platform_device *pdev) > > unsigned char checksum = 0; > > int err; > > > > + err

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

On Thu, May 03, 2018 at 10:46:56AM +0200, Geert Uytterhoeven wrote: > Perhaps you can add a new helper (platform_device_register_simple_dma()?) > that takes the DMA mask, too? > With people setting the mask to kill the WARNING splat, this may become > more common. > > struct platform_device_info

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

Hi Finn, CC Christoph On Thu, May 3, 2018 at 10:38 AM, Finn Thain wrote: > On Thu, 3 May 2018, Geert Uytterhoeven wrote: >> > --- a/drivers/net/ethernet/apple/macmace.c >> > +++ b/drivers/net/ethernet/apple/macmace.c >> > @@ -203,6 +203,10 @@ static int

[PATCH ipsec-next] xfrm: use a dedicated slab cache for struct xfrm_state

struct xfrm_state is rather large (768 bytes here) and therefore wastes quite a lot of memory as it falls into the kmalloc-1024 slab cache, leaving 256 bytes of unused memory per XFRM state object -- a net waste of 25%. Using a dedicated slab cache for struct xfrm_state reduces the level of

Re: Silently dropped UDP packets on kernel 4.14

Hi Florian, On Thu, May 3, 2018 at 7:03 AM, Florian Westphal wrote: > I'm sorry for suggesting that. > > It doesn't work, because of NAT. > NAT rewrites packet content and changes the reply tuple, but the tuples > determine the hash insertion location. > > I don't know how to

[PATCH V2] net/netlink: optimize seq_puts and seq_printf in af_netlink.c

Before the patch, the command `cat /proc/net/netlink` will output like: https://clbin.com/BojZv After the patch: https://clbin.com/lnu4L The optimization will make convenience for using `cat /proc/net/netlink` But,The checkpatch will give a warning: WARNING: quoted string split across lines

[PATCH] net/mlx5e: fix spelling mistake: "loobpack" -> "loopback"

From: Colin Ian King Trivial fix to spelling mistake in netdev_err error message Signed-off-by: Colin Ian King --- drivers/net/ethernet/mellanox/mlx5/core/en_selftest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] sctp: fix a potential missing-check bug

On Thu, May 3, 2018 at 8:39 AM, Marcelo Ricardo Leitner wrote: > On Thu, May 03, 2018 at 08:31:28AM -0500, Wenwen Wang wrote: >> On Thu, May 3, 2018 at 7:46 AM, Marcelo Ricardo Leitner >> wrote: >> > On Thu, May 03, 2018 at 07:01:51AM -0500,

Re: [PATCH 1/2] ixgbe: release lock for the duration of ixgbe_suspend_close()

On Thu, May 3, 2018 at 6:30 AM, Pavel Tatashin wrote: > Hi Alex, Hi Pavel, >> I'm not a fan of dropping the mutex while we go through >> ixgbe_close_suspend. I'm concerned it will result in us having a >> number of races on shutdown. > > I would agree, but

Re: DSA switch

On Thu, May 3, 2018 at 10:11 AM, Jiri Pirko wrote: > Thu, May 03, 2018 at 08:50:52AM CEST, ransha...@gmail.com wrote: >>On Wed, May 2, 2018 at 11:56 PM, Andrew Lunn wrote: >>> On Wed, May 02, 2018 at 11:20:05PM +0300, Ran Shalit wrote: Hello, Is

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

On Thu, May 03, 2018 at 03:25:29PM +0800, Jason Wang wrote: > On 2018年05月03日 10:09, Tiwei Bie wrote: > > > > > So how about we use the straightforward way then? > > > > You mean we do new += vq->vring_packed.num instead > > > > of event_idx -= vq->vring_packed.num before calling > > > >

Re: [PATCH bpf-next v3 00/15] Introducing AF_XDP support

From: Björn Töpel Date: Wed, 2 May 2018 13:01:21 +0200 > This patch set introduces a new address family called AF_XDP that is > optimized for high performance packet processing and, in upcoming > patch sets, zero-copy semantics. In this patch set, we have removed > all

Re: [PATCH net-next 0/2] Update csum tc action for batch operation.

From: Craig Dillabaugh Date: Tue, 1 May 2018 10:17:42 -0400 > This patchset includes two patches the first updating act_csum.c > to include the get_fill_size routine required for batch operation, and > the second including updated TDC tests for the feature. Series

Re: [PATCH net-next v7 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

David Miller writes: > From: Toke Høiland-Jørgensen > Date: Wed, 02 May 2018 17:11:03 +0200 > >> diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c >> new file mode 100644 >> index ..18bc147f12bc >> --- /dev/null >> +++ b/net/sched/sch_cake.c

Re: [PATCH net-next] net: core: rework skb_probe_transport_header()

From: Paolo Abeni Date: Thu, 3 May 2018 11:35:35 +0200 > When the transport header is not available, skb_probe_transport_header() > resorts to fully dissect the flow keys, even if it only needs the > ransport offset. We can obtain the latter using a simpler flow dissector - >

Re: [PATCH net-next] net: bridge: avoid duplicate notification on up/down/change netdev events

From: Nikolay Aleksandrov Date: Thu, 3 May 2018 13:47:24 +0300 > While handling netdevice events, br_device_event() sometimes uses > br_stp_(disable|enable)_port which unconditionally send a notification, > but then a second notification for the same event is sent

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Wed, 2 May 2018, John Stoffel wrote: > You miss my point, which is that there's no explanation of what the > difference is between SLAB and SLUB and which I should choose. The > same goes here. If the KConfig option doesn't give useful info, it's > useless. So what, we could write

Re: [PATCH net-next mlxsw v2 0/2] bridge: FDB: Notify about removal of non-user-added entries

From: Petr Machata Date: Thu, 03 May 2018 14:43:40 +0200 > Device drivers may generally need to keep in sync with bridge's FDB. In > particular, for its offload of tc mirror action where the mirrored-to > device is a gretap device, mlxsw needs to listen to a number of events,

Re: [PATCH net-next] net: core: rework skb_probe_transport_header()

On Thu, 2018-05-03 at 13:32 -0400, David Miller wrote: > From: Paolo Abeni > Date: Thu, 3 May 2018 11:35:35 +0200 > > > When the transport header is not available, skb_probe_transport_header() > > resorts to fully dissect the flow keys, even if it only needs the > > ransport

Re: [PATCH net-next] net: stmmac: Add support for U32 TC filter using Flexible RX Parser

From: Jose Abreu Date: Thu, 3 May 2018 13:45:30 +0100 > +static int dwmac5_rxp_update_single_entry(void __iomem *ioaddr, > + struct stmmac_tc_entry *entry, int pos) Please follow the Linux networking coding style for function arguments in function

KMSAN: uninit-value in strcmp

Hello, syzbot found the following crash on: HEAD commit:d2d741e5d189 kmsan: add initialization for shmem pages git tree: https://github.com/google/kmsan.git/master console output: https://syzkaller.appspot.com/x/log.txt?x=1005149780 kernel config:

Re: [PATCH] qed: fix spelling mistake: "offloded" -> "offloaded"

From: Colin King Date: Thu, 3 May 2018 16:19:32 +0100 > From: Colin Ian King > > Trivial fix to spelling mistake in DP_NOTICE message > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH net 0/3] net/smc: fixes 2018/05/03

From: Ursula Braun Date: Thu, 3 May 2018 17:57:36 +0200 > From: Ursula Braun > > Dave, > > here are smc fixes for 2 problems: > * receive buffers in SMC must be registered. If registration fails >these buffers must not be kept within the

[PATCH RESEND] SUNRPC: fix include for cmpxchg_relaxed()

Currently net/sunrpc/xprtmultipath.c is the only file outside of arch/ headers and asm-generic/ headers to include , apparently for the use of cmpxchg_relaxed(). However, many architectures do not provide cmpxchg_relaxed() in their , and it is necessary to include to get this definition, as

Re: [PATCH bpf-next v3 00/15] Introducing AF_XDP support

On Wed, May 2, 2018 at 1:01 PM, Björn Töpel wrote: > From: Björn Töpel > > This patch set introduces a new address family called AF_XDP that is > optimized for high performance packet processing Great patchset, thanks. > and, in upcoming > patch

Re: [PATCH 1/2] ixgbe: release lock for the duration of ixgbe_suspend_close()

On 5/3/2018 9:46 AM, Alexander Duyck wrote: > On Thu, May 3, 2018 at 6:30 AM, Pavel Tatashin > wrote: >> Hi Alex, > > Hi Pavel, > >>> I'm not a fan of dropping the mutex while we go through >>> ixgbe_close_suspend. I'm concerned it will result in us having a >>>

Re: DSA switch

> It seems that although the bridge command functions, it takes several > seconds (~6-7 seconds !) from the time it resturns to shell till a > real communication works (ping between 2 PCs connected to switch). > Does it usually takes so much time ? PHY link up can take a second or two. Less if

Re: [PATCH v1 net-next] net: dsa: mv88e6xxx: Fix name string for 88E6141

Hmm, sorry, this is already merged. It seems I forgor to etch new commits for some time. On Thu, 3 May 2018 15:11:43 +0200 Andrew Lunn wrote: > On Thu, May 03, 2018 at 03:06:55PM +0200, Marek Behún wrote: > > The structure was copied from 88E6341 but the name was not changed. >

Re: [PATCH 1/2] ixgbe: release lock for the duration of ixgbe_suspend_close()

> Hi Pavel, you might want to pull lock optimization out of this patch series. > The parallelization by itself is valuable, and optimizations for individual > devices including locks can come later. Hi Steve, Yes, I will pull this patch out of the series. Thank you for the suggestion. Pavel

Re: [PATCH net,stable] qmi_wwan: do not steal interfaces from class drivers

From: Bjørn Mork Date: Wed, 2 May 2018 22:22:54 +0200 > The USB_DEVICE_INTERFACE_NUMBER matching macro assumes that > the { vendorid, productid, interfacenumber } set uniquely > identifies one specific function. This has proven to fail > for some configurable devices. One

Re: [PATCH net] tcp: restore autocorking

From: Eric Dumazet Date: Wed, 2 May 2018 20:25:13 -0700 > When adding rb-tree for TCP retransmit queue, we inadvertently broke > TCP autocorking. > > tcp_should_autocork() should really check if the rtx queue is not empty. > > Tested: ... > Fixes: 75c119afe14f ("tcp:

Re: [PATCH net-next] ip6_gre: correct the function name in ip6gre_tnl_addr_conflict() comment

From: Sun Lianwen Date: Thu, 3 May 2018 09:34:29 +0800 > The function name is wrong in ip6gre_tnl_addr_conflict() comment, which > use ip6_tnl_addr_conflict instead of ip6gre_tnl_addr_conflict. > > Signed-off-by: Sun Lianwen Applied.

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

On Tue, 1 May 2018, Andrew Morton wrote: > On Tue, 24 Apr 2018 12:33:01 -0400 (EDT) Mikulas Patocka > wrote: > > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > On Tue 24-04-18 11:30:40, Mikulas Patocka wrote: > > > > > > > > > > > > On Tue, 24 Apr

Re: [lkp-robot] 486ad79630 [ 15.532543] BUG: unable to handle kernel NULL pointer dereference at 0000000000000004

On Wed, May 2, 2018 at 10:44 PM, Andrew Morton wrote: > On Wed, 2 May 2018 21:58:25 -0700 Cong Wang wrote: > >> On Wed, May 2, 2018 at 9:27 PM, Andrew Morton >> wrote: >> > >> > So it's saying that something which

[PATCH bpf-next v4 2/4] bpf: sockmap, add hash map support

Sockmap is currently backed by an array and enforces keys to be four bytes. This works well for many use cases and was originally modeled after devmap which also uses four bytes keys. However, this has become limiting in larger use cases where a hash would be more appropriate. For example users

[PATCH bpf-next v4 1/4] bpf: sockmap, refactor sockmap routines to work with hashmap

This patch only refactors the existing sockmap code. This will allow much of the psock initialization code path and bpf helper codes to work for both sockmap bpf map types that are backed by an array, the currently supported type, and the new hash backed bpf map type sockhash. Most the fallout

[PATCH bpf-next v4 0/4] Hash support for sock

In the original sockmap implementation we got away with using an array similar to devmap. However, unlike devmap where an ifindex has a nice 1:1 function into the map we have found some use cases with sockets that need to be referenced using longer keys. This series adds support for a sockhash

[PATCH bpf-next v4 3/4] bpf: selftest additions for SOCKHASH

This runs existing SOCKMAP tests with SOCKHASH map type. To do this we push programs into include file and build two BPF programs. One for SOCKHASH and one for SOCKMAP. We then run the entire test suite with each type. Signed-off-by: John Fastabend ---

[PATCH bpf-next v4 4/4] bpf: bpftool, support for sockhash

This adds the SOCKHASH map type to bpftools so that we get correct pretty printing. Signed-off-by: John Fastabend --- tools/bpf/bpftool/map.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c index a6cdb64..4420b1a

[PATCH rdma-next] MAINTAINERS: Remove bouncing @mellanox.com addresses

From: Leon Romanovsky Delete non-existent @mellanox.com addresses from MAINTAINERS file. Signed-off-by: Leon Romanovsky --- MAINTAINERS | 6 -- 1 file changed, 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0a1410d5a621..1b52c7e7fc7d

[PATCH] atm: zatm: Fix potential Spectre v1

pool can be indirectly controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. This issue was detected with the help of Smatch: drivers/atm/zatm.c:1462 zatm_ioctl() warn: potential spectre issue 'zatm_dev->pool_info' (local cap) Fix this by

Re: [PATCH net-next v2 00/15] ARM: sun8i: r40: Add Ethernet support

From: Maxime Ripard Date: Thu, 3 May 2018 15:12:57 +0200 > Hi Dave, > > On Wed, May 02, 2018 at 11:06:17AM -0400, David Miller wrote: >> From: Chen-Yu Tsai >> Date: Wed, 2 May 2018 00:33:45 +0800 >> >> > I should've mentioned that patches 3 ~ 10, and

Re: [PATCH] net/mlx5: fix spelling mistake: "modfiy" -> "modify"

From: Colin King Date: Thu, 3 May 2018 14:35:03 +0100 > From: Colin Ian King > > Trivial fix to spelling mistake in netdev_warn warning message > > Signed-off-by: Colin Ian King Saeed, please send this to me in

Re: [PATCH net-next mlxsw 0/3] selftests: forwarding: Updates to sysctl handling

From: Petr Machata Date: Thu, 03 May 2018 12:36:52 +0200 > Some selftests need to adjust sysctl settings. In order to be neutral to > the system that the test is run on, it is a good practice to change back > to the original setting after the test ends. That involves some >

Re: [PATCH net-next 0/4] mlxsw: Introduce support for CQEv1/2

From: Ido Schimmel Date: Thu, 3 May 2018 14:59:38 +0300 > Jiri says: > > Current SwitchX2 and Spectrum FWs support CQEv0 and that is what we > implement in mlxsw. Spectrum FW also supports CQE v1 and v2. > However, Spectrum-2 won't support CQEv0. Prepare for it and setup

Re: [PATCH net-next] net: core: rework skb_probe_transport_header()

From: Paolo Abeni Date: Thu, 03 May 2018 19:59:16 +0200 > On Thu, 2018-05-03 at 13:32 -0400, David Miller wrote: >> From: Paolo Abeni >> Date: Thu, 3 May 2018 11:35:35 +0200 >> >> > When the transport header is not available, skb_probe_transport_header()

Re: [PATCH bpf-next v4 0/4] Hash support for sock

From: John Fastabend Date: Thu, 3 May 2018 11:28:24 -0700 > In the original sockmap implementation we got away with using an > array similar to devmap. However, unlike devmap where an ifindex > has a nice 1:1 function into the map we have found some use cases > with

Re: [PATCH] sctp: fix a potential missing-check bug

On Thu, May 3, 2018 at 7:46 AM, Marcelo Ricardo Leitner wrote: > On Thu, May 03, 2018 at 07:01:51AM -0500, Wenwen Wang wrote: >> On Wed, May 2, 2018 at 8:48 PM, Marcelo Ricardo Leitner >> wrote: >> > On Wed, May 02, 2018 at 08:27:05PM -0500,

Re: [PATCH 2/2] drivers core: multi-threading device shutdown

On Thu, May 3, 2018 at 1:54 AM Tobin C. Harding wrote: > This code was a pleasure to read, super clean. Hi Tobin, Thank you very much for your review, I will address all of your comments in the next revision. BTW, I found a lock ordering issue in my work that that I

Re: [PATCH RESEND] SUNRPC: fix include for cmpxchg_relaxed()

On Thu, 2018-05-03 at 14:50 +0100, Mark Rutland wrote: > Currently net/sunrpc/xprtmultipath.c is the only file outside of arch/ > headers and asm-generic/ headers to include , apparently > for the use of cmpxchg_relaxed(). > > However, many architectures do not provide cmpxchg_relaxed() in their

Re: [PATCH net-next] inet: add bound ports statistic

From: Stephen Hemminger Date: Wed, 2 May 2018 15:11:08 -0700 > +int inet_bind_bucket_count(struct proto *prot); ... > +/* Count how many any entries are in the bind hash table */ > +unsigned int inet_bind_bucket_count(struct proto *prot) If it doesn't build, it

Re: [bpf-next v1 0/9] bpf: Add helper to do FIB lookups

From: David Ahern Date: Wed, 2 May 2018 20:53:10 -0700 > Provide a helper for doing a FIB and neighbor lookup in the kernel > tables from an XDP program. The helper provides a fastpath for forwarding > packets. If the packet is a local delivery or for any reason is not a >

Re: [PATCH net] tcp: restore autocorking

On Thu, May 3, 2018 at 4:06 AM Tariq Toukan wrote: > On 03/05/2018 6:25 AM, Eric Dumazet wrote: > > When adding rb-tree for TCP retransmit queue, we inadvertently broke > > TCP autocorking. > > > > tcp_should_autocork() should really check if the rtx queue is not empty. >

Re: [PATCH v1 net-next] net: dsa: mv88e6xxx: 88E6141/6341 SERDES support

Sent v2 On Thu, 3 May 2018 15:15:15 +0200 Andrew Lunn wrote: > On Thu, May 03, 2018 at 03:06:48PM +0200, Marek Behún wrote: > > The 88E6141/6341 switches (also known as Topaz) have 1 SGMII lane, > > which can be configured the same way as the SERDES lane on 88E6390. > > > >

Re: [PATCH net] tcp: restore autocorking

On Wed, May 2, 2018 at 11:25 PM, Eric Dumazet wrote: > Fixes: 75c119afe14f ("tcp: implement rb-tree based retransmit queue") > Signed-off-by: Eric Dumazet > Reported-by: Michael Wenig > Tested-by: Michael Wenig

Re: [RFC][PATCH bpf] tools: bpftool: Fix tags for bpf-to-bpf calls

Alexei Starovoitov wrote: On 3/1/18 12:51 AM, Naveen N. Rao wrote: Daniel Borkmann wrote: Worst case if there's nothing better, potentially what one could do in bpf_prog_get_info_by_fd() is to dump an array of full addresses and have the imm part as the index pointing to one of them, just

Re: [PATCH] sctp: fix a potential missing-check bug

On Thu, May 03, 2018 at 08:31:28AM -0500, Wenwen Wang wrote: > On Thu, May 3, 2018 at 7:46 AM, Marcelo Ricardo Leitner > wrote: > > On Thu, May 03, 2018 at 07:01:51AM -0500, Wenwen Wang wrote: > >> On Wed, May 2, 2018 at 8:48 PM, Marcelo Ricardo Leitner > >>

Re: [PATCH bpf-next 00/12] Move ld_abs/ld_ind to native BPF

On 05/03/2018 03:05 AM, Daniel Borkmann wrote: > This set simplifies BPF JITs significantly by moving ld_abs/ld_ind > to native BPF, for details see individual patches. Main rationale > is in patch 'implement ld_abs/ld_ind in native bpf'. Thanks! [...] Noticed a minor issue, therefore will respin

[PATCH] netfilter: nf_queue: Replace conntrack entry

SKBs are assigned a conntrack entry before being passed to any NFQUEUEs, and if no entry is found then a new one is created. This behavior causes problems for some traffic patterns. For example, if two UDP packets to/from the same host (using the same ports) arrive at the "same" time, both are

[PATCH v2 net-next] net: dsa: mv88e6xxx: 88E6141/6341 SERDES support

The 88E6141/6341 switches (also known as Topaz) have 1 SGMII lane, which can be configured the same way as the SERDES lane on 88E6390. Signed-off-by: Marek Behun --- drivers/net/dsa/mv88e6xxx/chip.c | 2 ++ drivers/net/dsa/mv88e6xxx/serdes.c | 20

RE: [PATCH net] tcp: restore autocorking

Thank you, Eric, for fixing this! Michael -Original Message- From: Eric Dumazet [mailto:eduma...@google.com] Sent: Wednesday, May 2, 2018 8:25 PM To: David S . Miller Cc: netdev ; Eric Dumazet ; Michael Wenig

Re: [PATCH net] tcp: restore autocorking

On Wed, May 2, 2018 at 11:25 PM Eric Dumazet wrote: > When adding rb-tree for TCP retransmit queue, we inadvertently broke > TCP autocorking. > tcp_should_autocork() should really check if the rtx queue is not empty. ... > Fixes: 75c119afe14f ("tcp: implement rb-tree

[PATCH] qed: fix spelling mistake: "offloded" -> "offloaded"

From: Colin Ian King Trivial fix to spelling mistake in DP_NOTICE message Signed-off-by: Colin Ian King --- drivers/net/ethernet/qlogic/qed/qed_roce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH net] rds: do not leak kernel memory to user land

From: Eric Dumazet Date: Wed, 2 May 2018 14:53:39 -0700 > syzbot/KMSAN reported an uninit-value in put_cmsg(), originating > from rds_cmsg_recv(). > > Simply clear the structure, since we have holes there, or since > rx_traces might be smaller than

Re: [PATCH 1/2] ixgbe: release lock for the duration of ixgbe_suspend_close()

Hi Alex, > I'm not a fan of dropping the mutex while we go through > ixgbe_close_suspend. I'm concerned it will result in us having a > number of races on shutdown. I would agree, but ixgbe_close_suspend() is already called without this mutex from ixgbe_close(). This path is executed also during

Re: [PATCH v2 net-next 2/4] net: add skeleton of bpfilter kernel module

On 03/05/18 05:36, Alexei Starovoitov wrote: > bpfilter.ko consists of bpfilter_kern.c (normal kernel module code) > and user mode helper code that is embedded into bpfilter.ko > > The steps to build bpfilter.ko are the following: > - main.c is compiled by HOSTCC into the bpfilter_umh elf

[PATCH] net/mlx5: fix spelling mistake: "modfiy" -> "modify"

From: Colin Ian King Trivial fix to spelling mistake in netdev_warn warning message Signed-off-by: Colin Ian King --- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH net-next v7 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

From: Toke Høiland-Jørgensen Date: Wed, 02 May 2018 17:11:03 +0200 > diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c > new file mode 100644 > index ..18bc147f12bc > --- /dev/null > +++ b/net/sched/sch_cake.c > +static inline cobalt_time_t cobalt_get_time(void)

Re: [PATCH] atm: zatm: Fix potential Spectre v1

From: Randy Dunlap Date: Thu, 3 May 2018 12:09:40 -0700 > Just for (my) info: all of these types of patches are to prevent > what is loaded in cache when the index is out of range, right? > Not some random pool_info[random], but pool_info[valid, i.e., 0]. > > Since the

[GIT] Networking

1) Various sockmap fixes from John Fastabend (pinned map handling, blocking in recvmsg, double page put, error handling during redirect failures, etc.) 2) Fix dead code handling in x86-64 JIT, from Gianluca Borello. 3) Missing device put in RDS IB code, from Dag Moxnes. 4) Don't process

Re: DSA switch

On Thu, May 3, 2018 at 11:41 PM, Andrew Lunn wrote: > On Thu, May 03, 2018 at 11:35:08PM +0300, Ran Shalit wrote: >> On Wed, May 2, 2018 at 11:56 PM, Andrew Lunn wrote: >> > On Wed, May 02, 2018 at 11:20:05PM +0300, Ran Shalit wrote: >> >> Hello, >> >> >> >> Is it

Re: DSA switch

> I am using kernel 2.6.37, but I think it is not kernel issue, but more > bad patches done on kernel. > It is based on TI's kernel, but with some custom modifications on > driver's switch, to make it work with TI's cpsw switch. > Seems like someone made some bad patch, I'll continue investigating

[PATCH v6 4/5] ixgbe: Report PCIe link properties with pcie_print_link_status()

From: Bjorn Helgaas Previously the driver used pcie_get_minimum_link() to warn when the NIC is in a slot that can't supply as much bandwidth as the NIC could use. pcie_get_minimum_link() can be misleading because it finds the slowest link and the narrowest link (which may

Re: [PATCH] net: ethernet: sun: niu set correct packet size in skb

From: Rob Taglang Date: Thu, 03 May 2018 11:06:04 -0400 > Currently, skb->len and skb->data_len are set to the page size, not > the packet size. This causes the frame check sequence to not be > located at the "end" of the packet resulting in ethernet frame check > errors. The

RE: [PATCH v6 0/5] PCI: Improve PCIe link status reporting

> -Original Message- > This does change the dmesg reporting of link speeds, and in the ixgbe case, > it changes the reporting from KERN_WARN level to KERN_INFO. If that's an > issue, let's talk about it. I'm hoping the reduce code size, improved > functionality, and consistency across

Re: [PATCH] net: ethernet: sun: niu set correct packet size in skb

Ah, gotcha. Should I make a new thread? Patch should be properly formatted below. Thanks, Rob Signed-off-by: Rob Taglang --- drivers/net/ethernet/sun/niu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/sun/niu.c

[PATCH net] nsh: fix infinite loop

syzbot caught an infinite recursion in nsh_gso_segment(). Problem here is that we need to make sure the NSH header is of reasonable length. BUG: MAX_LOCK_DEPTH too low! turning off the locking correctness validator. depth: 48 max: 48! 48 locks held by syz-executor0/10189: #0: (ptrval)

  1   2   3   >