Re: [PATCH RESEND net-next v2 1/8] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-14 Thread Maxime Ripard
On Sun, May 13, 2018 at 09:59:22PM -0700, Chen-Yu Tsai wrote: > On Sun, May 13, 2018 at 1:29 PM, Andrew Lunn wrote: > > On Sun, May 13, 2018 at 01:11:08PM -0700, Chen-Yu Tsai wrote: > >> On Sun, May 13, 2018 at 1:05 PM, Andrew Lunn wrote: > >> >> > Hi Chen-Yu > >>

[PATCH bpf-next v2] samples/bpf: xdp_monitor, accept short options

2018-05-14 Thread Prashant Bhole
Updated optstring parameter for getopt_long() to accept short options. Also updated usage() function. Signed-off-by: Prashant Bhole --- samples/bpf/xdp_monitor_user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2] ipvlan: flush arp table when mac address changed

2018-05-14 Thread Sergei Shtylyov
Hello. On 5/14/2018 12:22 PM, liuq...@huawei.com wrote: From: Keefe Liu When master device's mac has been changed, the commit <32c10bbfe914> "ipvlan: always use the current L2 addr of the master" makes the IPVlan devices's mac changed commit 32c10bbfe914 ("ipvlan:

Re: [PATCH net-next v2 06/13] phy: add 2.5G SGMII mode to the phy_mode enum

2018-05-14 Thread Antoine Tenart
Hi Russell, On Tue, May 08, 2018 at 01:34:08PM +0100, Russell King - ARM Linux wrote: > On Fri, May 04, 2018 at 03:56:36PM +0200, Antoine Tenart wrote: > > This patch adds one more generic PHY mode to the phy_mode enum, to allow > > configuring generic PHYs to the 2.5G SGMII mode by using the

Re: [kbuild-all] [PATCH net-next 2/2] sctp: add sctp_make_op_error_limited and reuse inner functions

2018-05-14 Thread Ye Xiaolong
Sorry for the late response. On 04/29, Marcelo Ricardo Leitner wrote: >On Mon, Apr 30, 2018 at 10:14:06AM +0800, kbuild test robot wrote: >> Hi Marcelo, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on net-next/master] >> >> url: >>

Re: [PATCH net-next v2 15/15] arm64: dts: allwinner: a64: add SRAM controller device tree node

2018-05-14 Thread Maxime Ripard
1;5201;0c On Sun, May 13, 2018 at 12:37:49PM -0700, Chen-Yu Tsai wrote: > On Wed, May 2, 2018 at 4:54 AM, Maxime Ripard > wrote: > > On Wed, May 02, 2018 at 06:19:51PM +0800, Icenowy Zheng wrote: > >> > >> > >> 于 2018年5月2日 GMT+08:00 下午5:53:21, Chen-Yu Tsai

答复: [PATCH] ipvlan: flush arp table when mac address changed

2018-05-14 Thread liuqifa
Hi, > > Hi, > > On Sat, 2018-05-12 at 19:00 +0800, liuq...@huawei.com wrote: > > From: Keefe Liu > > > > When master device's mac has been changed, the commit <32c10bbfe914> > > "ipvlan: always use the current L2 addr of the master" makes the > > IPVlan devices's mac changed

[PATCH net-next] net: stmmac: Add Jose Abreu as co-maintainer

2018-05-14 Thread Jose Abreu
I'm offering to be a co-maintainer for stmmac driver. As per discussion with Alexandre, I will arranje to get STM32 boards to test patches in GMAC version 3.x and 4.1. I also have HW to test GMAC version 5. Looking forward to contribute to net-dev! Signed-off-by: Jose Abreu

Re: [PATCH] net: phy: micrel: workaround for errata #2 for KSZ9031

2018-05-14 Thread Sergei Shtylyov
Hello! On 5/14/2018 11:22 AM, Marco Felsch wrote: From: Markus Niebel handle errata #2 for KSZ9031: force 1000Base-T master Attention: enabling the workaround will cause no link to other GIGE master. Signed-off-by: Markus Niebel

Re: [PATCH] ipvlan: flush arp table when mac address changed

2018-05-14 Thread Paolo Abeni
Hi, On Sat, 2018-05-12 at 19:00 +0800, liuq...@huawei.com wrote: > From: Keefe Liu > > When master device's mac has been changed, the > commit <32c10bbfe914> "ipvlan: always use the current L2 > addr of the master" makes the IPVlan devices's mac changed > also, but it

Re: [PATCH] net: mvpp2: fix mvpp2_tx()'s return type

2018-05-14 Thread Antoine Tenart
Hi Luc, On Tue, Apr 24, 2018 at 03:16:53PM +0200, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this

Re: [PATCH] net: phy: micrel: workaround for errata #2 for KSZ9031

2018-05-14 Thread Uwe Kleine-König
Hello, > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > index f41b224a9cdb..3e4243e4f7a7 100644 > --- a/drivers/net/phy/micrel.c > +++ b/drivers/net/phy/micrel.c > @@ -528,6 +528,8 @@ static int ksz9031_enable_edpd(struct phy_device *phydev) > > static int

Re: [PATCH v2] net/mlx4_core: Fix error handling in mlx4_init_port_info.

2018-05-14 Thread Tariq Toukan
On 14/05/2018 2:38 AM, Tarick Bedeir wrote: Avoid exiting the function with a lingering sysfs file (if the first call to device_create_file() fails while the second succeeds), and avoid calling devlink_port_unregister() twice. In other words, either mlx4_init_port_info() succeeds and returns

Re: [PATCH net-next v9 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-14 Thread Toke Høiland-Jørgensen
David Miller writes: > From: Toke Høiland-Jørgensen > Date: Tue, 08 May 2018 16:34:19 +0200 > >> +struct cake_flow { >> +/* this stuff is all needed per-flow at dequeue time */ >> +struct sk_buff*head; >> +struct sk_buff*tail; > > Please do

Re: [PATCH net-next] net: phy: sfp: handle cases where neither BR,min nor BR,max is given

2018-05-14 Thread Antoine Tenart
Hi Russell, On Tue, May 08, 2018 at 01:30:26PM +0100, Russell King - ARM Linux wrote: > > The electronic engineer in me says that using zero isn't really valid > because there are coupling capacitors in the SFP module that block DC. > These blocking capacitors are required by the SFP+ specs to

Re: [PATCH net-next] net: stmmac: Add Jose Abreu as co-maintainer

2018-05-14 Thread Alexandre Torgue
On 05/14/2018 11:29 AM, Jose Abreu wrote: I'm offering to be a co-maintainer for stmmac driver. As per discussion with Alexandre, I will arranje to get STM32 boards to test patches in GMAC version 3.x and 4.1. I also have HW to test GMAC version 5. Looking forward to contribute to net-dev!

[PATCH net-next] cxgb4: do not fail vf instatiation in slave mode

2018-05-14 Thread Ganesh Goudar
From: Arjun Vynipadath We no longer require a check for cxgb4 to be MASTER when configuring SRIOV, It was required when we had module parameter to instantiate vf. Signed-off-by: Arjun Vynipadath Signed-off-by: Casey Leedom

Re: [PATCH bpf-next] samples/bpf: xdp_monitor, accept short options

2018-05-14 Thread Prashant Bhole
On 5/12/2018 1:31 AM, Jesper Dangaard Brouer wrote: On Fri, 11 May 2018 10:37:51 +0900 Prashant Bhole wrote: updated optstring accept short options Signed-off-by: Prashant Bhole --- samples/bpf/xdp_monitor_user.c | 2 +-

Re: [PATCH net] xfrm6: avoid potential infinite loop in _decode_session6()

2018-05-14 Thread Steffen Klassert
On Sun, May 13, 2018 at 08:23:49PM -0400, David Miller wrote: > From: Eric Dumazet > Date: Sat, 12 May 2018 02:49:30 -0700 > > > syzbot found a way to trigger an infinitie loop by overflowing > > @offset variable that has been forced to use u16 for some very > > obscure

Re: [PATCH net-next v2 02/13] net: phy: sfp: handle non-wired SFP connectors

2018-05-14 Thread Antoine Tenart
Hi Russell, On Tue, May 08, 2018 at 12:52:47PM +0100, Russell King - ARM Linux wrote: > On Fri, May 04, 2018 at 03:56:32PM +0200, Antoine Tenart wrote: > > SFP connectors can be solder on a board without having any of their pins > > (LOS, i2c...) wired. In such cases the SFP link state cannot be

Re: [PATCH v2] net/mlx4_core: Fix error handling in mlx4_init_port_info.

2018-05-14 Thread Leon Romanovsky
On Sun, May 13, 2018 at 04:38:45PM -0700, Tarick Bedeir wrote: > Avoid exiting the function with a lingering sysfs file (if the first > call to device_create_file() fails while the second succeeds), and avoid > calling devlink_port_unregister() twice. > > In other words, either

[PATCH net-next] mlxsw: spectrum_span: Support LAG under mirror-to-gretap

2018-05-14 Thread Ido Schimmel
From: Petr Machata When resolving a path that the packet will take after being encapsulated in mirror-to-gretap scenarios, one of the devices en route could be a LAG. In that case, mirror to first up slave that corresponds to a front panel port. Signed-off-by: Petr Machata

Greetings

2018-05-14 Thread Ms Sophie Gabrielle
My sincere greetings, My Name is Ms Sophie Gabrielle, 19 years old single girl, the only child and daughter of late Mr & Mrs Edward Anthony a Togolese by origin, presently i am writing to you from Togo the capital of Togo. I was impressed when i saw your contact. i have 5.5 million US dollars

Re: [PATCH] net: phy: micrel: workaround for errata #2 for KSZ9031

2018-05-14 Thread Sergei Shtylyov
On 5/14/2018 11:22 AM, Marco Felsch wrote: From: Markus Niebel handle errata #2 for KSZ9031: force 1000Base-T master Attention: enabling the workaround will cause no link to other GIGE master. Signed-off-by: Markus Niebel

Re: KASAN: use-after-free Read in remove_wait_queue (2)

2018-05-14 Thread Eric Biggers
[+ppp list and maintainer] On Wed, Feb 28, 2018 at 08:59:02AM -0800, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > f3afe530d644488a074291da04a69a296ab63046 (Tue Feb 27 22:02:39 2018 +) > Merge branch 'fixes-v4.16-rc4' of >

[PATCH net-next 2/2] cxgb4: Support ethtool private flags

2018-05-14 Thread Ganesh Goudar
From: Arjun Vynipadath This is used to change TX workrequests, which helps in host->vf communication. Signed-off-by: Arjun Vynipadath Signed-off-by: Casey Leedom Signed-off-by: Ganesh Goudar ---

[PATCH net-next 1/2] cxgb4: Add support for FW_ETH_TX_PKT_VM_WR

2018-05-14 Thread Ganesh Goudar
From: Arjun Vynipadath The present TX workrequest(FW_ETH_TX_PKT_WR) cant be used for host->vf communication, since it doesn't loopback the outgoing packets to virtual interfaces on the same port. This can be done using FW_ETH_TX_PKT_VM_WR. This fix depends on ethtool_flags to

[PATCH] net: phy: micrel: workaround for errata #2 for KSZ9031

2018-05-14 Thread Marco Felsch
From: Markus Niebel handle errata #2 for KSZ9031: force 1000Base-T master Attention: enabling the workaround will cause no link to other GIGE master. Signed-off-by: Markus Niebel [m.fel...@pengutronix.de: move dt binding to the KSZ9031 entry]

[PATCH v2] ipvlan: flush arp table when mac address changed

2018-05-14 Thread liuqifa
From: Keefe Liu When master device's mac has been changed, the commit <32c10bbfe914> "ipvlan: always use the current L2 addr of the master" makes the IPVlan devices's mac changed also, but it doesn't flush the IPVlan's arp table. Signed-off-by: Keefe Liu

Re: [PATCH net-next] net: stmmac: Add Jose Abreu as co-maintainer

2018-05-14 Thread Sergei Shtylyov
Hello! On 5/14/2018 12:29 PM, Jose Abreu wrote: I'm offering to be a co-maintainer for stmmac driver. As per discussion with Alexandre, I will arranje to get STM32 boards to Arrange. :-) test patches in GMAC version 3.x and 4.1. I also have HW to test GMAC version 5. Looking forward

Re: [kbuild-all] [PATCH net-next 2/2] sctp: add sctp_make_op_error_limited and reuse inner functions

2018-05-14 Thread Ye Xiaolong
On 05/14, Marcelo Ricardo Leitner wrote: >On Mon, May 14, 2018 at 03:40:53PM +0800, Ye Xiaolong wrote: >> >> config: x86_64-randconfig-x006-201817 (attached as .config) >> >> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 >> >> reproduce: >> >> # save the attached .config to linux build tree >>

Re: [PATCH] net: phy: micrel: workaround for errata #2 for KSZ9031

2018-05-14 Thread Andrew Lunn
On Mon, May 14, 2018 at 10:22:18AM +0200, Marco Felsch wrote: > From: Markus Niebel > > handle errata #2 for KSZ9031: force 1000Base-T master > > Attention: enabling the workaround will cause no link to > other GIGE master. Hi Marco It would be good to document why this

Re: INFO: rcu detected stall in kfree_skbmem

2018-05-14 Thread Neil Horman
On Fri, May 11, 2018 at 12:00:38PM +0200, Dmitry Vyukov wrote: > On Mon, Apr 30, 2018 at 8:09 PM, syzbot > wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:5d1365940a68 Merge > >

Re: [PATCH v2] Revert "alx: remove WoL support"

2018-05-14 Thread David Miller
From: AceLan Kao Date: Mon, 14 May 2018 11:28:39 +0800 > This reverts commit bc2bebe8de8ed4ba6482c9cc370b0dd72ffe8cd2. > > The WoL feature is a must to pass Energy Star 6.1 and above, > the power consumption will be measured during S3 with WoL is enabled. > >

[PATCH net] cxgb4: Correct ntuple mask validation for hash filters

2018-05-14 Thread Ganesh Goudar
From: Kumar Sanghvi Earlier code of doing bitwise AND with field width bits was wrong. Instead, simplify code to calculate ntuple_mask based on supplied fields and then compare with mask configured in hw - which is the correct and simpler way to validate ntuple mask. Fixes:

[RFC][PATCH bpf v3 4/5] tools: bpf: sync bpf uapi header

2018-05-14 Thread Sandipan Das
Syncing the bpf.h uapi header with tools so that struct bpf_prog_info has the new fields for storing the kernel symbol addresses for the JITed functions in a program. Signed-off-by: Sandipan Das --- tools/include/uapi/linux/bpf.h | 2 ++ 1 file changed, 2

[RFC][PATCH bpf v3 2/5] bpf: powerpc64: add JIT support for multi-function programs

2018-05-14 Thread Sandipan Das
This adds support for bpf-to-bpf function calls in the powerpc64 JIT compiler. The JIT compiler converts the bpf call instructions to native branch instructions. After a round of the usual passes, the start addresses of the JITed images for the callee functions are known. Finally, to fixup the

[RFC][PATCH bpf v3 5/5] tools: bpftool: resolve call addresses without using imm field

2018-05-14 Thread Sandipan Das
Currently, we resolve the callee's address for a JITed function call by using the imm field of the call instruction as an offset from __bpf_call_base. If bpf_jit_kallsyms is enabled, we further use this address to get the callee's kernel symbol's name. For some architectures, such as powerpc64,

[RFC][PATCH bpf v3 1/5] bpf: allow 64-bit offsets for bpf function calls

2018-05-14 Thread Sandipan Das
The imm field of a bpf instruction is a signed 32-bit integer. For JIT bpf-to-bpf function calls, it stores the offset of the start address of the callee's JITed image from __bpf_call_base. For some architectures, such as powerpc64, this offset may be as large as 64 bits and cannot be accomodated

Re: [kbuild-all] [PATCH net-next 2/2] sctp: add sctp_make_op_error_limited and reuse inner functions

2018-05-14 Thread Marcelo Ricardo Leitner
On Mon, May 14, 2018 at 03:40:53PM +0800, Ye Xiaolong wrote: > >> config: x86_64-randconfig-x006-201817 (attached as .config) > >> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 > >> reproduce: > >> # save the attached .config to linux build tree > >> make ARCH=x86_64 > >> > >> All errors

[PATCH v3] ipvlan: call netdevice notifier when master mac address changed

2018-05-14 Thread liuqifa
From: Keefe Liu When master device's mac has been changed, the commit 32c10bbfe914 ("ipvlan: always use the current L2 addr of the master") makes the IPVlan devices's mac changed also, but it doesn't do related works such as flush the IPVlan devices's arp table.

[PATCH net-next] cxgb4: add tc flower match support for tunnel VNI

2018-05-14 Thread Ganesh Goudar
From: Kumar Sanghvi Adds support for matching flows based on tunnel VNI value. Introduces fw APIs for allocating/removing MPS entries related to encapsulation. And uses the same while adding/deleting filters for offloading flows based on tunnel VNI match. Signed-off-by:

Re: [PATCH 2/5] crypto: chtls: wait for memory sendmsg, sendpage

2018-05-14 Thread Dan Carpenter
On Mon, May 14, 2018 at 04:30:56PM +0530, Atul Gupta wrote: > Reported-by: Gustavo A. R. Silva > Signed-off-by: Atul Gupta There isn't a commit message for this. It should say what the user visible effects of this bug are. I haven't seen

[PATCH v3] selftests: add headers_install to lib.mk

2018-05-14 Thread Anders Roxell
If the kernel headers aren't installed we can't build all the tests. Add a new make target rule 'khdr' in the file lib.mk to generate the kernel headers and that gets include for every test-dir Makefile that includes lib.mk If the testdir in turn have its own sub-dirs the top_srcdir needs to be

[PATCH net 2/2] vmxnet3: use DMA memory barriers where required

2018-05-14 Thread hpreg
The gen bits must be read first from (resp. written last to) DMA memory. The proper way to enforce this on Linux is to call dma_rmb() (resp. dma_wmb()). Signed-off-by: Regis Duchesne Acked-by: Ronak Doshi --- drivers/net/vmxnet3/vmxnet3_drv.c | 22

[PATCH net 1/2] vmxnet3: set the DMA mask before the first DMA map operation

2018-05-14 Thread hpreg
The DMA mask must be set before, not after, the first DMA map operation, or the first DMA map operation could in theory fail on some systems. Fixes: b0eb57cb97e78 ("VMXNET3: Add support for virtual IOMMU") Signed-off-by: Regis Duchesne Acked-by: Ronak Doshi

[bpf-next PATCH 2/5] bpf, doc: rename txt files to rst files

2018-05-14 Thread Jesper Dangaard Brouer
This will cause them to get auto rendered, e.g. when viewing them on GitHub. Followup patches will correct the content to be RST compliant. Also adjust README.rst to point to the renamed files. Signed-off-by: Jesper Dangaard Brouer --- Documentation/bpf/README.rst|

[bpf-next PATCH 4/5] bpf, doc: convert bpf_devel_QA.rst to use RST formatting

2018-05-14 Thread Jesper Dangaard Brouer
Same story as bpf_design_QA.rst RST format conversion. Again thanks to Quentin Monnet for fixes and patches that have been squashed. Signed-off-by: Jesper Dangaard Brouer --- Documentation/bpf/bpf_devel_QA.rst | 799

[bpf-next PATCH 3/5] bpf, doc: convert bpf_design_QA.rst to use RST formatting

2018-05-14 Thread Jesper Dangaard Brouer
The RST formatting is done such that that when rendered or converted to different formats, an automatic index with links are created to the subsections. Thus, the questions are created as sections (or subsections), in-order to get the wanted auto-generated FAQ/QA index. Special thanks to Quentin

[bpf-next PATCH 5/5] bpf, doc: howto use/run the BPF selftests

2018-05-14 Thread Jesper Dangaard Brouer
I always forget howto run the BPF selftests. Thus, lets add that info to the QA document. Documentation was based on Cilium's documentation: http://cilium.readthedocs.io/en/latest/bpf/#verifying-the-setup Signed-off-by: Jesper Dangaard Brouer ---

[PATCH 2/5] crypto: chtls: wait for memory sendmsg, sendpage

2018-05-14 Thread Atul Gupta
Reported-by: Gustavo A. R. Silva Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h | 1 + drivers/crypto/chelsio/chtls/chtls_io.c | 90 +-- drivers/crypto/chelsio/chtls/chtls_main.c | 1 + 3

[PATCH 1/5] crypto:chtls: key len correction

2018-05-14 Thread Atul Gupta
corrected the key length to copy 128b key. Removed 192b and 256b key as user input supports key of size 128b in gcm_ctx Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_hw.c | 6 +- 1 file changed,

[PATCH 0/5] build warnings cleanup

2018-05-14 Thread Atul Gupta
Build warnings cleanup reported for - using only 128b key - wait for buffer in sendmsg/sendpage - check for null before using skb - free rspq_skb_cache in error path - indentation Atul Gupta (5): crypto:chtls: key len correction crypto: chtls: wait for memory sendmsg, sendpage crypto:

[PATCH 4/5] crypto: chtls: kbuild warnings

2018-05-14 Thread Atul Gupta
- unindented continue - check for null page - signed return Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[PATCH 3/5] crypto: chtls: dereference null variable

2018-05-14 Thread Atul Gupta
skb dereferenced before check in sendpage Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 5/5] crypto: chtls: free beyond end rspq_skb_cache

2018-05-14 Thread Atul Gupta
Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/chelsio/chtls/chtls_main.c

[PATCH] crypto: chtls: generic handling of data and hdr

2018-05-14 Thread Atul Gupta
removed redundant check and made TLS PDU and header recv handling common as received from HW. Ensure that only tls header is read in cpl_rx_tls_cmp read-ahead and skb is freed when entire data is processed. Signed-off-by: Atul Gupta Signed-off-by: Harsh Jain

[RFC][PATCH bpf v3 3/5] bpf: get JITed function addresses via syscall

2018-05-14 Thread Sandipan Das
This adds new two new fields to struct bpf_prog_info. For multi-function programs, these fields can be used to pass a list of kernel symbol addresses for all functions in a given program and to userspace using the bpf system call with the BPF_OBJ_GET_INFO_BY_FD command. When bpf_jit_kallsyms is

Re: [PATCH net-next 1/2] cxgb4: Add support for FW_ETH_TX_PKT_VM_WR

2018-05-14 Thread kbuild test robot
Hi Arjun, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Ganesh-Goudar/cxgb4-Add-support-for-FW_ETH_TX_PKT_VM_WR/20180514-163558 config: x86_64-acpi-redef (attached as .config) compiler: gcc-7

Re: [PATCH RESEND net-next v2 1/8] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-14 Thread Andrew Lunn
> > Currently no other board requires this, but this is already part of the > > binding. The new stuff limits the range for a specific SoC, simply because > > that is the range supported by the control register. Not implementing, i.e. > > supporting the whole range from the property, which might

Re: [kbuild-all] [PATCH net-next 2/2] sctp: add sctp_make_op_error_limited and reuse inner functions

2018-05-14 Thread Marcelo Ricardo Leitner
On Mon, May 14, 2018 at 07:47:20PM +0800, Ye Xiaolong wrote: > On 05/14, Marcelo Ricardo Leitner wrote: > >On Mon, May 14, 2018 at 03:40:53PM +0800, Ye Xiaolong wrote: > >> >> config: x86_64-randconfig-x006-201817 (attached as .config) > >> >> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 > >> >>

[bpf-next PATCH 1/5] bpf, doc: add basic README.rst file

2018-05-14 Thread Jesper Dangaard Brouer
A README.rst file in a directory have special meaning for sites like github, which auto renders the contents. Plus search engines like Google also index these README.rst files. Auto rendering allow us to use links, for (re)directing eBPF users to other places where docs live. The end-goal would

[bpf-next PATCH 0/5] bpf, doc: convert Documentation/bpf to RST-formatting

2018-05-14 Thread Jesper Dangaard Brouer
The kernel is moving files under Documentation to use the RST (reStructuredText) format and Sphinx [1]. This patchset converts the files under Documentation/bpf/ into RST format. The Sphinx integration is left as followup work. [1] https://www.kernel.org/doc/html/latest/doc-guide/sphinx.html

Re: [PATCH bpf-next v2] samples/bpf: xdp_monitor, accept short options

2018-05-14 Thread Jesper Dangaard Brouer
On Mon, 14 May 2018 17:29:15 +0900 Prashant Bhole wrote: > Updated optstring parameter for getopt_long() to accept short options. > Also updated usage() function. > > Signed-off-by: Prashant Bhole > --- Acked-by: Jesper

[PATCH 02/14] net: sched: change type of reference and bind counters

2018-05-14 Thread Vlad Buslov
Change type of action reference counter to refcount_t. Change type of action bind counter to atomic_t. This type is used to allow decrementing bind counter without testing for 0 result. Signed-off-by: Vlad Buslov --- include/net/act_api.h | 5 +++--

[PATCH 01/14] net: sched: use rcu for action cookie update

2018-05-14 Thread Vlad Buslov
Implement functions to atomically update and free action cookie using rcu mechanism. Signed-off-by: Vlad Buslov --- include/net/act_api.h | 2 +- include/net/pkt_cls.h | 1 + net/sched/act_api.c | 44 ++-- 3 files changed, 32

[PATCH 05/14] net: sched: always take reference to action

2018-05-14 Thread Vlad Buslov
Without rtnl lock protection it is no longer safe to use pointer to tc action without holding reference to it. (it can be destroyed concurrently) Remove unsafe action idr lookup function. Instead of it, implement safe tcf idr check function that atomically looks up action in idr and increments

Re: [PATCH net-next v9 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-14 Thread David Miller
From: Toke Høiland-Jørgensen Date: Mon, 14 May 2018 11:08:28 +0200 > David Miller writes: > >> From: Toke Høiland-Jørgensen >> Date: Tue, 08 May 2018 16:34:19 +0200 >> >>> +struct cake_flow { >>> + /* this stuff is all needed per-flow at

[net-next 11/11] i40evf: Fix a hardware reset support in VF driver

2018-05-14 Thread Jeff Kirsher
From: Paweł Jabłoński This patch fixes a hardware reset support in VF driver. It is needed because when a hardware reset is detected adapter->state is in __I40EVF_RESETTING state before i40evf_reset_task is called. Without this patch unloading VF driver after a

[net-next 04/11] i40e: remove duplicate pfc stats

2018-05-14 Thread Jeff Kirsher
From: Jacob Keller The pfc related priority stats are already handled separately as these stats are actually arrays of length I40E_MAX_USER_PRIORITY. Thus, including them within i40e_gstrings_stats will just duplicate data. Worse, the sizeof will be incorrect, as it

[net-next 06/11] i40e: Fix recalculation of MSI-X vectors for VMDq

2018-05-14 Thread Jeff Kirsher
From: Patryk Małek This patch adds a recalculation of number of MSI-X vectors for VMDq in the case where we have less vectors available than we would want to reserve for VMDq. It fixes the issue where we recalculate vectors left and vectors wanted but we didn't take into

[net-next 10/11] i40e: free the skb after clearing the bitlock

2018-05-14 Thread Jeff Kirsher
From: Jacob Keller In commit bbc4e7d273b5 ("i40e: fix race condition with PTP_TX_IN_PROGRESS bits") we modified the code which handles Tx timestamps so that we would clear the progress bit as soon as possible. A later commit 0bc0706b46cd ("i40e: check for Tx timestamp

Re: Kernel panic on kernel-3.10.0-693.21.1.el7 in ndisc.h

2018-05-14 Thread Alexander Aring
Hi, On Sun, May 13, 2018 at 02:35:07PM +0300, Roman Makhov wrote: > Hello, > > We have a problem with Kernel panic after upgrade from CentOS 7.3 > (kernel-3.10.0-514.el7) to CentOS 7.4 (kernel-3.10.0-693.21.1.el7). > It occurs when we have the incoming traffic from other nodes and we > are

Re: [linux-stable-3.16.y] tun: allow positive return values on dev_get_valid_name() call

2018-05-14 Thread Ben Hutchings
On Mon, 2018-05-14 at 15:47 +0200, Sedat Dilek wrote: > Hi Ben, > > some Debian/jessie systems were caught by the bug-report in [1]. > This issue was recently fixed in an updated Debian kernel for v3.16.y. > > Will you include the patch "tun: allow positive return values on >

[PATCH 00/14] Modify action API for implementing lockless actions

2018-05-14 Thread Vlad Buslov
Currently, all netlink protocol handlers for updating rules, actions and qdiscs are protected with single global rtnl lock which removes any possibility for parallelism. This patch set is a first step to remove rtnl lock dependency from TC rules update path. It updates act API to use atomic

Re: [PATCH 02/14] net: sched: change type of reference and bind counters

2018-05-14 Thread Jiri Pirko
Mon, May 14, 2018 at 04:27:03PM CEST, vla...@mellanox.com wrote: >Change type of action reference counter to refcount_t. > >Change type of action bind counter to atomic_t. >This type is used to allow decrementing bind counter without testing >for 0 result. > >Signed-off-by: Vlad Buslov

[PATCH] lib/rhashtable: reorder some inititalization sequences

2018-05-14 Thread Davidlohr Bueso
rhashtable_init() allocates memory at the very end of the call, once everything is setup; with the exception of the nelems parameter. However, unless the user is doing something bogus with params for which -EINVAL is returned, memory allocation is the only operation that can trigger the call to

Re: [PATCH 03/14] net: sched: add 'delete' function to action ops

2018-05-14 Thread Jiri Pirko
Mon, May 14, 2018 at 05:12:22PM CEST, j...@resnulli.us wrote: >Mon, May 14, 2018 at 04:27:04PM CEST, vla...@mellanox.com wrote: >>Extend action ops with 'delete' function. Each action type to implement its >>own delete function that doesn't depend on rtnl lock. >> >>Signed-off-by: Vlad Buslov

Re: [PATCH V2] mlx4_core: allocate ICM memory in page size chunks

2018-05-14 Thread Qing Huang
On 5/13/2018 2:00 AM, Tariq Toukan wrote: On 11/05/2018 10:23 PM, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter slow path doing memory compact/migration ops

Re: [PATCH 06/14] net: sched: implement reference counted action release

2018-05-14 Thread Jiri Pirko
Mon, May 14, 2018 at 04:27:07PM CEST, vla...@mellanox.com wrote: [...] >+static int tcf_action_del_1(struct net *net, char *kind, u32 index, >+ struct netlink_ext_ack *extack) >+{ >+ const struct tc_action_ops *ops; >+ int err = -EINVAL; >+ >+ ops =

[PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

2018-05-14 Thread Vlad Buslov
Substitute calls to action insert function with calls to action insert unique function that warns if insertion overwrites index in idr. Signed-off-by: Vlad Buslov --- net/sched/act_bpf.c| 2 +- net/sched/act_connmark.c | 2 +- net/sched/act_csum.c | 2 +-

Re: [PATCH v1 iproute2-next 1/3] rdma: update rdma_netlink.h to get driver attrs

2018-05-14 Thread Steve Wise
On 5/13/2018 8:15 AM, Leon Romanovsky wrote: > On Mon, May 07, 2018 at 08:53:10AM -0700, Steve Wise wrote: >> Signed-off-by: Steve Wise >> --- >> rdma/include/uapi/rdma/rdma_netlink.h | 37 >> ++- >> 1 file changed, 36

Re: net: ieee802154: 6lowpan: fix frag reassembly

2018-05-14 Thread David Miller
From: Stefan Schmidt Date: Mon, 14 May 2018 17:22:18 +0200 > Please apply f18fa5de5ba7f1d6650951502bb96a6e4715a948 > > (net: ieee802154: 6lowpan: fix frag reassembly) to the 4.16.x stable tree. > > Earlier trees are not needed as the problem was introduced in 4.16. > >

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-14 Thread Michel Machado
On 09/05/18 01:37 PM, Michel Machado wrote: On 05/09/2018 10:43 AM, Jamal Hadi Salim wrote: On 08/05/18 10:27 PM, Cong Wang wrote: On Tue, May 8, 2018 at 6:29 AM, Jamal Hadi Salim wrote: I like the suggestion of extending skbmod to mark skbprio based on ds. Given that

[PATCH 09/14] net: sched: don't release reference on action overwrite

2018-05-14 Thread Vlad Buslov
Return from action init function with reference to action taken, even when overwriting existing action. Action init API initializes its fourth argument (pointer to pointer to tc action) to either existing action with same index or newly created action. In case of existing index(and bind argument

[PATCH 14/14] net: sched: implement delete for all actions

2018-05-14 Thread Vlad Buslov
Implement delete function that is required to delete actions without holding rtnl lock. Use action API function that atomically deletes action only if it is still in action idr. This implementation prevents concurrent threads from deleting same action twice. Signed-off-by: Vlad Buslov

[PATCH 10/14] net: sched: extend act API for lockless actions

2018-05-14 Thread Vlad Buslov
Implement new action API function to atomically delete action with specified index and to atomically insert unique action. These functions are required to implement init and delete functions for specific actions that do not rely on rtnl lock. Signed-off-by: Vlad Buslov ---

[PATCH 11/14] net: core: add new/replace rate estimator lock parameter

2018-05-14 Thread Vlad Buslov
Extend rate estimator new and replace APIs with additional spinlock parameter used by lockless actions to protect rate_est pointer from concurrent modification. Signed-off-by: Vlad Buslov --- include/net/gen_stats.h| 2 ++ net/core/gen_estimator.c | 58

[PATCH 12/14] net: sched: retry action check-insert on concurrent modification

2018-05-14 Thread Vlad Buslov
Retry check-insert sequence in action init functions if action with same index was inserted concurrently. Signed-off-by: Vlad Buslov --- net/sched/act_bpf.c| 8 +++- net/sched/act_connmark.c | 8 +++- net/sched/act_csum.c | 8 +++-

[PATCH 06/14] net: sched: implement reference counted action release

2018-05-14 Thread Vlad Buslov
Implement helper function to delete action using new action ops delete function implemented by each action for lockless execution. Implement action put function that releases reference to action and frees it if necessary. Refactor action deletion code to use new put function and not to rely on

Re: [PATCH 03/14] net: sched: add 'delete' function to action ops

2018-05-14 Thread Jiri Pirko
Mon, May 14, 2018 at 04:27:04PM CEST, vla...@mellanox.com wrote: >Extend action ops with 'delete' function. Each action type to implement its >own delete function that doesn't depend on rtnl lock. > >Signed-off-by: Vlad Buslov >--- > include/net/act_api.h | 1 + > 1 file

net: ieee802154: 6lowpan: fix frag reassembly

2018-05-14 Thread Stefan Schmidt
Hello. Please apply f18fa5de5ba7f1d6650951502bb96a6e4715a948 (net: ieee802154: 6lowpan: fix frag reassembly) to the 4.16.x stable tree. Earlier trees are not needed as the problem was introduced in 4.16. Normally net/ patches would come through DaveM, but he asked me for this one to submit

Re: net: ieee802154: 6lowpan: fix frag reassembly

2018-05-14 Thread Greg KH
On Mon, May 14, 2018 at 05:22:18PM +0200, Stefan Schmidt wrote: > Hello. > > > Please apply f18fa5de5ba7f1d6650951502bb96a6e4715a948 > > (net: ieee802154: 6lowpan: fix frag reassembly) to the 4.16.x stable tree. > > > Earlier trees are not needed as the problem was introduced in 4.16. > > >

[PATCH v2 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-14 Thread Steve Wise
This enhancement allows printing rdma device-specific state, if provided by the kernel. This is done in a generic manner, so rdma tool doesn't need to know about the details of every type of rdma device. Driver attributes for a rdma resource are in the form of tuples,

[PATCH v2 iproute2-next 3/3] rdma: update man pages

2018-05-14 Thread Steve Wise
Update the man pages for the resource attributes as well as the driver-specific attributes. Signed-off-by: Steve Wise --- man/man8/rdma-resource.8 | 29 ++--- man/man8/rdma.8 | 2 +- 2 files changed, 27 insertions(+), 4 deletions(-)

[PATCH v2 iproute2-next 0/3] RDMA tool driver-specific resource tracking

2018-05-14 Thread Steve Wise
Hello, This series enhances the iproute2 rdma tool to include displaying driver-specific resource attributes. It is the user-space part of the kernel driver resource tracking series that has been accepted for merging into linux-4.18 [1] If there are no additional review comments, it can now be

[PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes

2018-05-14 Thread Steve Wise
Pull in the rdma_netlink.h changes from kernel commits: 25a0ad85156a ("RDMA/nldev: Add explicit pad attribute") da5c85078215 ("RDMA/nldev: add driver-specific resource tracking)" Signed-off-by: Steve Wise --- rdma/include/uapi/rdma/rdma_netlink.h | 26

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-14 Thread Steve Wise
On 5/13/2018 8:24 AM, Leon Romanovsky wrote: > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: >> This enhancement allows printing rdma device-specific state, if provided >> by the kernel. This is done in a generic manner, so rdma tool doesn't > Double space between "." and "This".

Re: [PATCH v3 0/1] multi-threading device shutdown

2018-05-14 Thread Greg KH
On Mon, May 07, 2018 at 11:54:01AM -0400, Pavel Tatashin wrote: > Changelog > v2 - v3 > - Fixed warning from kbuild test. > - Moved device_lock/device_unlock inside device_shutdown_tree(). > > v1 - v2 > - It turns out we cannot lock more than MAX_LOCK_DEPTH by a single >

Re: [PATCH 01/14] net: sched: use rcu for action cookie update

2018-05-14 Thread Jiri Pirko
Mon, May 14, 2018 at 04:27:02PM CEST, vla...@mellanox.com wrote: >Implement functions to atomically update and free action cookie >using rcu mechanism. > >Signed-off-by: Vlad Buslov Signed-off-by: Jiri Pirko

  1   2   3   4   >