Re: [PATCH v3 net-next 5/9] net: stmmac: Add MDIO related functions for XGMAC2

2018-08-07 Thread Florian Fainelli
On 08/07/2018 06:35 AM, Jose Abreu wrote: > Hi Florian, > > On 06-08-2018 16:25, Florian Fainelli wrote: >> On August 6, 2018 12:59:54 AM PDT, Jose Abreu >> wrote: >>> On 03-08-2018 20:06, Florian Fainelli wrote: On 08/03/2018 08:50 AM, Jose Abreu wrote: > Add the MDIO related

[RFC] spi: add spi multiplexing functions for dt

2018-08-07 Thread Ben Whitten
Like I2C busses SPI devices can also sit behind multiplexers. This patch adds is based off the I2C implementation and allows description in the devicetree. Signed-off-by: Ben Whitten --- drivers/spi/Kconfig | 10 +++ drivers/spi/Makefile| 3 + drivers/spi/spi-mux.c | 181

[PATCH lora-next 09/10] net: lora: sx1301: convert agc calibrate to regmap functions

2018-08-07 Thread Ben Whitten
From: Ben Whitten We convert the AGC calibration function over to regmap and take the opportunity to make the expected firmware versions defines. Switch to taking a pointer to our private data. Signed-off-by: Ben Whitten --- drivers/net/lora/sx1301.c | 101

[PATCH lora-next 07/10] net: lora: sx1301: convert read and write burst to take priv data

2018-08-07 Thread Ben Whitten
From: Ben Whitten As part of standardising on passing our priv data around we convert read and write burst to take the priv data, there is a small compat step needed in the old _read and _write functions and will be removed in the next step. Signed-off-by: Ben Whitten ---

[PATCH lora-next 10/10] net: lora: sx1301: convert all firmware to regmap

2018-08-07 Thread Ben Whitten
The last stage in the probe function loads the final firmwares to the sx1301. Signed-off-by: Ben Whitten --- drivers/net/lora/sx1301.c | 67 --- 1 file changed, 28 insertions(+), 39 deletions(-) diff --git a/drivers/net/lora/sx1301.c

[PATCH lora-next 01/10] net: lora: sx1301: add register, bit-fields, and helpers for regmap

2018-08-07 Thread Ben Whitten
From: Ben Whitten The register and bit-field definitions are taken from the SX1301 datasheet version 2.01 dated June 2014 with the revision information 'First released version'. The reset state and RW capability of each field is not reflected in this patch however from the datasheet: "Bits and

[PATCH lora-next 00/10] Conversing sx1301 to regmap and regfield

2018-08-07 Thread Ben Whitten
This series converts the majority of sx1301 code to using regmap and regfield system. The SPI subsystem is as yet untouched but will be converted to a regmap_bus in a future series with sx1257 conversions. Interestingly the initial state did not work for me as I was getting kernel oopses

[PATCH lora-next 08/10] net: lora: sx1301: convert read and write to priv pointer

2018-08-07 Thread Ben Whitten
From: Ben Whitten Convert the next layer of read and writes to our private pointer, once again compatiblity later in the page read and write layer. The page functions will be removed with this full stack as page switches are handled by regmap automatically. Signed-off-by: Ben Whitten ---

[PATCH lora-next 04/10] net: lora: sx1301: convert probe function to regmap access

2018-08-07 Thread Ben Whitten
From: Ben Whitten Keeping change sets small we convert the probe function over to regmap and regmap_field access for initialisation. Signed-off-by: Ben Whitten --- drivers/net/lora/sx1301.c | 155 +- drivers/net/lora/sx1301.h | 7 +++ 2 files

[PATCH lora-next 02/10] net: lora: add methods for devm registration

2018-08-07 Thread Ben Whitten
From: Ben Whitten Follow the devm model so that we can avoid lengthy unwind code. Signed-off-by: Ben Whitten --- drivers/net/lora/dev.c | 20 include/linux/lora/dev.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/net/lora/dev.c b/drivers/net/lora/dev.c

[PATCH lora-next 03/10] net: lora: sx1301: convert to devm registration of netdev

2018-08-07 Thread Ben Whitten
From: Ben Whitten We allow the devres framework handle the clean removal of resources on teardown of the device, in this case the SPI device, saving lengthy unwind code and improving clarity. Signed-off-by: Ben Whitten --- drivers/net/lora/sx1301.c | 87

[PATCH lora-next 06/10] net: lora: sx1301: simplify firmware loading and convert

2018-08-07 Thread Ben Whitten
From: Ben Whitten As part of changing our internal pointers to our priv data we add the spi_device temporarily for downstream burst read/writes. Just pass firmware pointer to the load and remove redundant size checks, as both MCUs have the same program size add a define. Use devm_kzalloc for

[PATCH lora-next 05/10] net: lora: sx1301: add device to private data and convert ram reads

2018-08-07 Thread Ben Whitten
From: Ben Whitten It's easier to simply add a pointer to our device to our private data, this way we can avoid passing around our spi_device and instead just pass private data which is more flexible. As its a two line change its coupled with converting AGC and ARB ram reads to regmap functions.

Re: [PATCH v3 net-next 9/9] dt-bindings: net: stmmac: Add the bindings documentation for XGMAC2.

2018-08-07 Thread Rob Herring
On Fri, Aug 03, 2018 at 04:50:27PM +0100, Jose Abreu wrote: > Adds the documentation for XGMAC2 DT bindings. > > Signed-off-by: Jose Abreu > Cc: David S. Miller > Cc: Joao Pinto > Cc: Giuseppe Cavallaro > Cc: Alexandre Torgue > Cc: Sergei Shtylyov > Cc: devicet...@vger.kernel.org > Cc: Rob

Re: [PATCH net-next 4/6] net/sched: allow flower to match tunnel options

2018-08-07 Thread Or Gerlitz
On Tue, Aug 7, 2018 at 6:36 PM, Simon Horman wrote: > From: Pieter Jansen van Vuuren > > Allow matching on options in Geneve tunnel headers. > This makes use of existing tunnel metadata support. > > The options can be described in the form > CLASS:TYPE:DATA/CLASS_MASK:TYPE_MASK:DATA_MASK, where

Re: [PATCH net-next 2/6] nfp: flower: allow matching on ipv4 UDP tunnel tos and ttl

2018-08-07 Thread Or Gerlitz
On Tue, Aug 7, 2018 at 6:35 PM, Simon Horman wrote: > From: John Hurley > > The addition of FLOW_DISSECTOR_KEY_ENC_IP to TC flower means that the ToS > and TTL of the tunnel header can now be matched on. > > Extend the NFP tunnel match function to include these new fields. (referring to you

[PATCH net-next v2 0/3] net: Support Wake-on-LAN using filters

2018-08-07 Thread Florian Fainelli
Hi David, John, This is technically a v2, but this patch series builds on your feedback and defines the following: - a new WAKE_* bit: WAKE_FILTER which can be enabled alongside other type of Wake-on-LAN to support waking up on a programmed filter (match + action) - a new RX_CLS_FLOW_WAKE flow

[PATCH] ethtool: Add support for Wake-on-LAN using filters

2018-08-07 Thread Florian Fainelli
Define a way to specify that a flow's action is to be used for Wake-on-LAN purposes (using -2 as an action value) and define a new Wake-on-LAN flag: 'f' which enables the Ethernet adapter for Wake-on-LAN using filters. Signed-off-by: Florian Fainelli --- ethtool-copy.h | 2 ++ ethtool.8.in |

[PATCH net-next v2 3/3] net: systemport: Add support for WAKE_FILTER

2018-08-07 Thread Florian Fainelli
The SYSTEMPORT MAC allows up to 8 filters to be programmed to wake-up from LAN. Verify that we have up to 8 filters and program them to the appropriate RXCHK entries to be matched (along with their masks). We need to update the entry and exit to Wake-on-LAN mode to keep the RXCHK engine running

[PATCH net-next v2 1/3] ethtool: Add WAKE_FILTER and RX_CLS_FLOW_WAKE

2018-08-07 Thread Florian Fainelli
Add the ability to specify through ethtool::rxnfc that a rule location is special and will be used to participate in Wake-on-LAN, by e.g: having a specific pattern be matched. When this is the case, fs->ring_cookie must be set to the special value RX_CLS_FLOW_WAKE. We also define an additional

[PATCH net-next v2 2/3] net: dsa: bcm_sf2: Propagate ethtool::rxnfc to CPU port

2018-08-07 Thread Florian Fainelli
Allow propagating ethtool::rxnfc programming to the CPU/management port such that it is possible for such a CPU to perform e.g: Wake-on-LAN using filters configured by the switch. We need a tiny bit of cooperation between the switch drivers which is able to do the full flow matching, whereas the

[PATCH net-next 1/1] tc-tests: initial version of nat action unit tests

2018-08-07 Thread Keara Leibovitz
Initial set of nat action unit tests. Signed-off-by: Keara Leibovitz --- .../selftests/tc-testing/tc-tests/actions/nat.json | 593 + 1 file changed, 593 insertions(+) create mode 100644 tools/testing/selftests/tc-testing/tc-tests/actions/nat.json diff --git

[net-next 12/12] i40e: fix i40e_add_queue_stats data pointer update

2018-08-07 Thread Jeff Kirsher
From: Jacob Keller This function accidentally failed to update the data pointer, which caused the reported stats to be incorrect. Additionally, statistics which follow queue stats in the output would potentially read non-zeroed garbage data from the ethtool buffer. This occurred because the

[net-next 06/12] i40e: convert VEB TC stats to use an i40e_stats array

2018-08-07 Thread Jeff Kirsher
From: Jacob Keller The VEB TC stats are currently implemented with separate parsing, instead of using the i40e_stats array and associated helper functions. This is likely because the stats rely on embedding the TC number into the stat name. Update i40e_add_stat_strings to take variadic

[net-next 03/12] i40e: add helper function for copying strings from stat arrays

2018-08-07 Thread Jeff Kirsher
From: Jacob Keller Many of the ethtool statistics use the same basic logic for copying strings into the supplied buffer. A set of stats are stored in a const array of i40e_stats structures, and we apply these all together. Simplify the stats code by introducing a helper function which can take

[net-next 01/12] i40e: Remove duplicated prepare call in i40e_shutdown

2018-08-07 Thread Jeff Kirsher
From: Sergey Nemov Function call to i40e_prep_for_reset() is duplicated in i40e_shutdown routine and gets called before i40e_enable_mc_magic_wake() which blocks it from being executed correctly on system reboot or shutdown because adminq is already disabled by first i40e_prep_for_reset() call.

[net-next 00/12][pull request] 40GbE Intel Wired LAN Driver Updates 2018-08-07

2018-08-07 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Sergey cleans up a duplicate call to i40e_prep_for_reset() during shutdown. YueHaibing cleans up i40evf by removing code that was never being used or called within the driver. Jake updates the ethtool statistics to use a helper function

[net-next 09/12] i40e: fix warning about shadowed ring parameter

2018-08-07 Thread Jeff Kirsher
From: Jacob Keller In commit 147e81ec7568 ("i40e: Test memory before ethtool alloc succeeds") code was added to handle ring allocation on systems with low memory. It shadowed the ring parameter pointer by introducing a local ring pointer inside the for loop. Most of the code in the loop already

[net-next 07/12] i40e: convert priority flow control stats to use helpers

2018-08-07 Thread Jeff Kirsher
From: Jacob Keller The priority flow control statistics are laid out in the stats structure using arrays. This made it unwieldy to use as part of an i40e_stats array. Add a new structure type, i40e_pfc_stats, and a helper function i40e_get_pfc_stats which can return the stats for a given

[net-next 11/12] i40e: Add AQ command for rearrange NVM structure

2018-08-07 Thread Jeff Kirsher
From: Piotr Azarewicz During switching between old NVM structure approach (called structured NVM) to new one (called flat NVM) or backward flash needs to be rearranged to required NVM structure. This is a part of transition from one NVM structure to another. The function is introduced to command

[net-next 02/12] i40e/i40evf: remove redundant functions i40evf_aq_{set/get}_phy_register

2018-08-07 Thread Jeff Kirsher
From: YueHaibing There are no in-tree callers. Signed-off-by: YueHaibing Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- .../net/ethernet/intel/i40evf/i40e_common.c | 69 --- 1 file changed, 69 deletions(-) diff --git

[net-next 10/12] i40e: Add additional return code to i40e_asq_send_command

2018-08-07 Thread Jeff Kirsher
From: Piotr Azarewicz Firmware can return a busy state, so the function return I40E_ERR_NOT_READY. Signed-off-by: Piotr Azarewicz Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_adminq.c | 2 ++ drivers/net/ethernet/intel/i40evf/i40e_adminq.c

[net-next 05/12] i40e: Set fec_config when forcing link state

2018-08-07 Thread Jeff Kirsher
From: Mariusz Stachura This patch configures FEC setting in i40e_force_link_state(). For some reason setting this field was overlooked thus causing 25G link to be configured incorrectly. Signed-off-by: Mariusz Stachura Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 04/12] i40e: add helper to copy statistic values into ethtool buffer

2018-08-07 Thread Jeff Kirsher
From: Jacob Keller Similar to the helper function to copy the ethtool stats strings, add and use a helper function for copying the ethtool stats into the supplied buffer. Just like before, we use a macro to avoid having to pass ARRAY_SIZE manually, so as to reduce chance of bugs. Some of the

Re: [PATCH net-next] liquidio: avoided acquiring post_lock for data only queues

2018-08-07 Thread David Miller
From: Felix Manlunas Date: Mon, 6 Aug 2018 13:09:40 -0700 > From: Intiyaz Basha > > All control commands (soft commands) goes through only Queue 0 > (control and data queue). So only queue-0 needs post_lock, > other queues are only data queues and does not need post_lock > > Added a flag to

Re: e1000e driver stuck at 10Mbps after reconnection

2018-08-07 Thread Camille Bordignon
Le lundi 06 août 2018 à 15:45:29 (-0700), Alexander Duyck a écrit : > On Mon, Aug 6, 2018 at 4:59 AM, Camille Bordignon > wrote: > > Hello, > > > > Recently we experienced some issues with intel NIC (I219-LM and I219-V). > > It seems that after a wire reconnection, auto-negotation "fails" and > >

Re: [PATCH net-next v6 10/11] net: sched: atomically check-allocate action

2018-08-07 Thread Cong Wang
On Thu, Jul 5, 2018 at 7:24 AM Vlad Buslov wrote: > > Implement function that atomically checks if action exists and either takes > reference to it, or allocates idr slot for action index to prevent > concurrent allocations of actions with same index. Use EBUSY error pointer > to indicate that

Re: [PATCH net-next 2/6] nfp: flower: allow matching on ipv4 UDP tunnel tos and ttl

2018-08-07 Thread John Hurley
On Tue, Aug 7, 2018 at 6:46 PM, Or Gerlitz wrote: > On Tue, Aug 7, 2018 at 6:35 PM, Simon Horman > wrote: >> From: John Hurley >> >> The addition of FLOW_DISSECTOR_KEY_ENC_IP to TC flower means that the ToS >> and TTL of the tunnel header can now be matched on. >> >> Extend the NFP tunnel

Re: [PATCH net-next,v3] net/tls: Calculate nsg for zerocopy path without skb_cow_data.

2018-08-07 Thread David Miller
From: Doron Roberts-Kedes Date: Tue, 7 Aug 2018 10:55:17 -0700 > On Tue, Aug 07, 2018 at 04:10:50PM +, Vakul Garg wrote: >> >> >> > -Original Message- >> > From: Doron Roberts-Kedes [mailto:doro...@fb.com] >> > Sent: Tuesday, August 7, 2018 1:18 AM >> > To: David S . Miller >> >

Re: pull-request: bpf-next 2018-08-07

2018-08-07 Thread David Miller
From: Daniel Borkmann Date: Tue, 7 Aug 2018 19:57:53 +0200 > The following pull-request contains BPF updates for your *net-next* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git Pulled,

Re: [PATCH net-next v2 0/3] net: Support Wake-on-LAN using filters

2018-08-07 Thread David Miller
From: Florian Fainelli Date: Tue, 7 Aug 2018 10:50:19 -0700 > This is technically a v2, but this patch series builds on your feedback > and defines the following: > > - a new WAKE_* bit: WAKE_FILTER which can be enabled alongside other type > of Wake-on-LAN to support waking up on a

Re: Is it currently possible to connect SFP to dsa port?

2018-08-07 Thread Andrew Lunn
On Tue, Aug 07, 2018 at 09:00:23PM +0200, Marek Behun wrote: > Hello, > > I have a question regarding DSA/SFP code. > > We are working on a modular router where it is possible to connect > multiple switch cards and at most one SFP cage card to a router. > > Does the sfp/dsa driver support

Re: [PATCH net v2] dccp: fix undefined behavior with 'cwnd' shift in ccid2_cwnd_restart()

2018-08-07 Thread David Miller
From: Alexey Kodanev Date: Tue, 7 Aug 2018 20:03:57 +0300 > The shift of 'cwnd' with '(now - hc->tx_lsndtime) / hc->tx_rto' value > can lead to undefined behavior [1]. > > In order to fix this use a gradual shift of the window with a 'while' > loop, similar to what tcp_cwnd_restart() is doing.

Re: [PATCH net-next 13/14] net: core: add new/replace rate estimator lock parameter

2018-08-07 Thread Marcelo Ricardo Leitner
On Mon, Aug 06, 2018 at 09:54:24AM +0300, Vlad Buslov wrote: > Extend rate estimator 'new' and 'replace' APIs with additional spinlock > parameter to be used by rtnl-unlocked actions to protect rate_est pointer > from concurrent modification. I'm wondering if this additional parameter is really

[PATCH net-next] ieee802154: hwsim: fix rcu handling

2018-08-07 Thread Alexander Aring
This patch adds missing rcu_assign_pointer()/rcu_dereference() to used rcu pointers. There was already a previous commit c5d99d2b35da ("ieee802154: hwsim: fix rcu address annotation"), but there was more which was pointed out on my side by using newest sparse version. Cc: Stefan Schmidt Fixes:

Re: [PATCH v8 bpf-next 02/10] veth: Add driver XDP

2018-08-07 Thread Toshiaki Makita
Hi Daniel, Thank you for taking a look! On 2018/08/07 23:26, Daniel Borkmann wrote: > On 08/03/2018 09:58 AM, Toshiaki Makita wrote: > [...] >> + >> +static struct sk_buff *veth_xdp_rcv_skb(struct veth_priv *priv, >> +struct sk_buff *skb) >> +{ >> +u32

Re: [PATCH net-next 1/1] tc-tests: initial version of nat action unit tests

2018-08-07 Thread David Miller
From: Keara Leibovitz Date: Tue, 7 Aug 2018 15:18:43 -0400 > Initial set of nat action unit tests. > > Signed-off-by: Keara Leibovitz Applied, thank you.

Re: [Patch net] llc: use refcount_inc_not_zero() for llc_sap_find()

2018-08-07 Thread David Miller
From: Cong Wang Date: Tue, 7 Aug 2018 12:41:38 -0700 > llc_sap_put() decreases the refcnt before deleting sap > from the global list. Therefore, there is a chance > llc_sap_find() could find a sap with zero refcnt > in this global list. > > Close this race condition by checking if refcnt is

Re: [PATCH net-next] selftests: forwarding: gre_multipath: Update next-hop statistics match criteria

2018-08-07 Thread David Miller
From: Nir Dotan Date: Tue, 7 Aug 2018 19:41:55 +0300 > gre_multipath test was using egress vlan_id matching on flows, for the > purpose of collecting next-hops statistics, later to be compared > against configured weights. > As matching on vlan_id on egress direction is not supported on all HW

[PATCH net-next] ieee802154: hwsim: fix copy-paste error in hwsim_set_edge_lqi()

2018-08-07 Thread Wei Yongjun
The return value from kzalloc() is not checked correctly. The test is done against a wrong variable. This patch fix it. Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb") Signed-off-by: Wei Yongjun --- drivers/net/ieee802154/mac802154_hwsim.c | 2 +- 1 file changed, 1

Re: [net-next 00/12][pull request] 40GbE Intel Wired LAN Driver Updates 2018-08-07

2018-08-07 Thread David Miller
From: Jeff Kirsher Date: Tue, 7 Aug 2018 12:27:45 -0700 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff.

Re: [PATCH net-next v6 11/11] net: sched: change action API to use array of pointers to actions

2018-08-07 Thread Cong Wang
On Thu, Jul 5, 2018 at 7:24 AM Vlad Buslov wrote: > attr_size = tcf_action_full_attrs_size(attr_size); > > if (event == RTM_GETACTION) > - ret = tcf_get_notify(net, portid, n, , event, extack); > + ret = tcf_get_notify(net, portid, n, actions, event,

[PATCH net-next] ieee802154: hwsim: fix missing unlock on error in hwsim_add_one()

2018-08-07 Thread Wei Yongjun
Add the missing unlock before return from function hwsim_add_one() in the error handling case. Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb") Signed-off-by: Wei Yongjun --- drivers/net/ieee802154/mac802154_hwsim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Is it currently possible to connect SFP to dsa port?

2018-08-07 Thread Marek Behun
Hello, I have a question regarding DSA/SFP code. We are working on a modular router where it is possible to connect multiple switch cards and at most one SFP cage card to a router. Does the sfp/dsa driver support connecting SFP port to a DSA port? For example the Marvell 6390 switch has two

Re: [PATCH net-next-internal] net: sched: cls_flower: set correct offload data in fl_reoffload

2018-08-07 Thread David Miller
From: Vlad Buslov Date: Mon, 6 Aug 2018 11:27:10 +0300 > fl_reoffload implementation sets following members of struct > tc_cls_flower_offload incorrectly: > - masked key instead of mask > - key instead of masked key > > Fix fl_reoffload to provide correct data to offload callback. > >

Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts

2018-08-07 Thread David Miller
From: Al Viro Date: Sun, 5 Aug 2018 18:22:38 +0100 > Unlike fs.val.lport and fs.val.fport, cxgb4_process_flow_match() > sets fs.val.{l,f}ip to net-endian values without conversion - they come > straight from flow_dissector_key_ipv4_addrs ->dst and ->src resp. So > the assignment in

Re: [PATCH net-next 0/6] nfp: flower: tunnel TTL & TOS, and Geneve options set & match support

2018-08-07 Thread David Miller
From: Simon Horman Date: Tue, 7 Aug 2018 17:35:57 +0200 > this series contains updates for the TC Flower classifier > and the offload facility for it in the NFP driver. > > * Patches 1 & 2: update the NFP driver to allow offload > of matching and setting tunnel ToS/TTL of flows using the TC

Re: [PATCH net-next] ip6_tunnel: collect_md xmit: Use ip_tunnel_key's provided src address

2018-08-07 Thread David Miller
From: Shmulik Ladkani Date: Mon, 6 Aug 2018 15:00:59 +0300 > When using an ip6tnl device in collect_md mode, the xmit methods ignore > the ipv6.src field present in skb_tunnel_info's key, both for route > calculation purposes (flowi6 construction) and for assigning the > packet's final

Re: [PATCH net-next v3 0/3] qed: Add Multi-TC RoCE support

2018-08-07 Thread David Miller
From: Denis Bolotin Date: Tue, 7 Aug 2018 15:48:07 +0300 > Hi Dave, > This patch series adds support for multiple concurrent traffic classes for > RoCE. > The first three patches enable the required parts of the driver to learn the > TC > configuration, and the last one makes use of it to

Re: [PATCH net-next,v3] net/tls: Calculate nsg for zerocopy path without skb_cow_data.

2018-08-07 Thread Doron Roberts-Kedes
On Tue, Aug 07, 2018 at 04:10:50PM +, Vakul Garg wrote: > > > > -Original Message- > > From: Doron Roberts-Kedes [mailto:doro...@fb.com] > > Sent: Tuesday, August 7, 2018 1:18 AM > > To: David S . Miller > > Cc: Vakul Garg ; Dave Watson > > ; Boris Pismenny ; Aviad > > Yehezkel ;

[net-next 08/12] i40e: remove unnecessary i variable causing -Wshadow warning

2018-08-07 Thread Jeff Kirsher
From: Jacob Keller Commit c61c8fe1d592 ("i40e: Implement an ethtool private flag to stop LLDP in FW") added an extra for-loop which added a shadowing 'i' variable as the index. However, the local variable i already exists, and we already use it as a loop index. Additionally, at this point,

Re: [RFC] spi: add spi multiplexing functions for dt

2018-08-07 Thread Andreas Färber
Hi Ben, Am 07.08.2018 um 19:32 schrieb Ben Whitten: > Like I2C busses SPI devices can also sit behind multiplexers. > This patch adds is based off the I2C implementation and allows > description in the devicetree. > > Signed-off-by: Ben Whitten > --- > drivers/spi/Kconfig | 10 +++ >

Re: [PATCH lora-next 02/10] net: lora: add methods for devm registration

2018-08-07 Thread Andreas Färber
Am 07.08.2018 um 19:32 schrieb Ben Whitten: > From: Ben Whitten > > Follow the devm model so that we can avoid lengthy unwind code. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/dev.c | 20 > include/linux/lora/dev.h | 1 + > 2 files changed, 21 insertions(+)

Re: [RFC] spi: add spi multiplexing functions for dt

2018-08-07 Thread Ben Whitten
On Tue, 7 Aug 2018 at 22:17, Andreas Färber wrote: > > Hi Ben, > > Am 07.08.2018 um 19:32 schrieb Ben Whitten: > > Like I2C busses SPI devices can also sit behind multiplexers. > > This patch adds is based off the I2C implementation and allows > > description in the devicetree. > > > >

Re: [PATCH net-next 0/2] ibmvnic: Update firmware error reporting

2018-08-07 Thread David Miller
From: Thomas Falcon Date: Mon, 6 Aug 2018 21:39:57 -0500 > This patch set cleans out a lot of dead code from the ibmvnic driver > and adds some more. The error ID field of the descriptor is not filled > in by firmware, so do not print it and do not use it to query for > more detailed

Re: Is it currently possible to connect SFP to dsa port?

2018-08-07 Thread Andrew Lunn
On Tue, Aug 07, 2018 at 12:43:11PM -0700, Florian Fainelli wrote: > > > On 08/07/2018 12:00 PM, Marek Behun wrote: > > Hello, > > > > I have a question regarding DSA/SFP code. > > > > We are working on a modular router where it is possible to connect > > multiple switch cards and at most one

[PATCH net-next,v4] net/tls: Calculate nsg for zerocopy path without skb_cow_data.

2018-08-07 Thread Doron Roberts-Kedes
decrypt_skb fails if the number of sg elements required to map is greater than MAX_SKB_FRAGS. nsg must always be calculated, but skb_cow_data adds unnecessary memcpy's for the zerocopy case. The new function skb_nsg calculates the number of scatterlist elements required to map the skb without

Re: Is it currently possible to connect SFP to dsa port?

2018-08-07 Thread Florian Fainelli
On 08/07/2018 12:00 PM, Marek Behun wrote: > Hello, > > I have a question regarding DSA/SFP code. > > We are working on a modular router where it is possible to connect > multiple switch cards and at most one SFP cage card to a router. > > Does the sfp/dsa driver support connecting SFP port

pull-request: bpf-next 2018-08-07

2018-08-07 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Add cgroup local storage for BPF programs, which provides a fast accessible memory for storing various per-cgroup data like number of transmitted packets, etc, from Roman. 2)

Re: [Patch net] vsock: split dwork to avoid reinitializations

2018-08-07 Thread David Miller
From: Cong Wang Date: Mon, 6 Aug 2018 11:06:02 -0700 > syzbot reported that we reinitialize an active delayed > work in vsock_stream_connect(): > > ODEBUG: init active (active state 0) object type: timer_list hint: > delayed_work_timer_fn+0x0/0x90 kernel/workqueue.c:1414 >

Re: [PATCH bpf-next 3/3] bpf: add sample for BPF_MAP_TYPE_QUEUE

2018-08-07 Thread Jakub Kicinski
On Mon, 06 Aug 2018 15:58:47 +0200, Mauricio Vasquez B wrote: > @@ -109,6 +110,7 @@ xdpsock-objs := xdpsock_user.o > xdp_fwd-objs := xdp_fwd_user.o > task_fd_query-objs := bpf_load.o task_fd_query_user.o $(TRACE_HELPERS) > xdp_sample_pkts-objs := xdp_sample_pkts_user.o $(TRACE_HELPERS) >

[Patch net] llc: use refcount_inc_not_zero() for llc_sap_find()

2018-08-07 Thread Cong Wang
llc_sap_put() decreases the refcnt before deleting sap from the global list. Therefore, there is a chance llc_sap_find() could find a sap with zero refcnt in this global list. Close this race condition by checking if refcnt is zero or not in llc_sap_find(), if it is zero then it is being removed

[net-next:master 479/480] drivers/net/ieee802154/mac802154_hwsim.c:409:17: sparse: incorrect type in assignment (different address spaces)

2018-08-07 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 1ba982806ce58baac44c52e6c7812245afad27c8 commit: c5d99d2b35dadebab2408bb10dcd50364eaaf9f4 [479/480] ieee802154: hwsim: fix rcu address annotation reproduce: # apt-get install sparse git

[PATCH net-next v3 2/3] qed: Add a flag which indicates if offload TC is set

2018-08-07 Thread Denis Bolotin
Distinguish not set offload_tc from offload_tc 0 and add getters and setters. Signed-off-by: Michal Kalderon Signed-off-by: Ariel Elior Signed-off-by: Denis Bolotin --- drivers/net/ethernet/qlogic/qed/qed.h | 3 +++ drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 2 +-

[PATCH net-next v3 1/3] qed: Add DCBX API - qed_dcbx_get_priority_tc()

2018-08-07 Thread Denis Bolotin
The API receives a priority and looks for the TC it is mapped to in the operational DCBX configuration. The API returns QED_DCBX_DEFAULT_TC (0) when DCBX is disabled. Signed-off-by: Michal Kalderon Signed-off-by: Ariel Elior Signed-off-by: Denis Bolotin ---

[PATCH net-next v3 3/3] qed: Add Multi-TC RoCE support

2018-08-07 Thread Denis Bolotin
RoCE qps use a pair of physical queues (pq) received from the Queue Manager (QM) - an offload queue (OFLD) and a low latency queue (LLT). The QM block creates a pq for each TC, and allows RoCE qps to ask for a pq with a specific TC. As a result, qps with different VLAN priorities can be mapped to

[PATCH net-next v3 0/3] qed: Add Multi-TC RoCE support

2018-08-07 Thread Denis Bolotin
Hi Dave, This patch series adds support for multiple concurrent traffic classes for RoCE. The first three patches enable the required parts of the driver to learn the TC configuration, and the last one makes use of it to enable the feature. Please consider applying this to net-next. V1->V2:

RE: [RFC PATCH 0/2] net: macb: Disable TX checksum offloading on all Zynq

2018-08-07 Thread Harini Katakam
Hi Claudiu, > -Original Message- > From: Claudiu Beznea [mailto:claudiu.bez...@microchip.com] > Sent: Tuesday, August 7, 2018 2:21 PM > To: Harini Katakam ; Jennifer Dahm > > Cc: netdev@vger.kernel.org; David S . Miller ; Nathan > Sullivan ; Rafal Ozieblo ; > Harini Katakam ; Nicolas

Re: [RFC PATCH 0/2] net: macb: Disable TX checksum offloading on all Zynq

2018-08-07 Thread Claudiu Beznea
Hi Harini, On 01.08.2018 15:53, Harini Katakam wrote: > Hi Jennifer, > > On Tue, Jun 5, 2018 at 10:21 AM, Harini Katakam wrote: >> Hi Jeniffer, >> >> On Mon, Jun 4, 2018 at 8:35 PM, Nicolas Ferre >> wrote: >>> Jennifer, >>> >>> On 25/05/2018 at 23:44, Jennifer Dahm wrote: During

RE: [PATCH RFC net-next 1/1] net/tls: Combined memory allocation for decryption request

2018-08-07 Thread Vakul Garg
> -Original Message- > From: Dave Watson [mailto:davejwat...@fb.com] > Sent: Tuesday, August 7, 2018 8:26 PM > To: Vakul Garg > Cc: netdev@vger.kernel.org; bor...@mellanox.com; > avia...@mellanox.com; da...@davemloft.net > Subject: Re: [PATCH RFC net-next 1/1] net/tls: Combined memory

Re: [PATCH v3 net-next 5/9] net: stmmac: Add MDIO related functions for XGMAC2

2018-08-07 Thread Jose Abreu
On 07-08-2018 14:35, Jose Abreu wrote: > Hi Florian, > > On 06-08-2018 16:25, Florian Fainelli wrote: >> On August 6, 2018 12:59:54 AM PDT, Jose Abreu >> wrote: >>> On 03-08-2018 20:06, Florian Fainelli wrote: On 08/03/2018 08:50 AM, Jose Abreu wrote: > Add the MDIO related

[PATCH net-next 6/6] nfp: flower: add geneve option match offload

2018-08-07 Thread Simon Horman
From: Pieter Jansen van Vuuren Introduce a new layer for matching on geneve options. This allows offloading filters configured to match geneve with options. Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 6

[PATCH net-next 5/6] nfp: flower: add geneve option push action offload

2018-08-07 Thread Simon Horman
From: Pieter Jansen van Vuuren Introduce new push geneve option action. This allows offloading filters configured to entunnel geneve with options. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman ---

[PATCH net-next 2/6] nfp: flower: allow matching on ipv4 UDP tunnel tos and ttl

2018-08-07 Thread Simon Horman
From: John Hurley The addition of FLOW_DISSECTOR_KEY_ENC_IP to TC flower means that the ToS and TTL of the tunnel header can now be matched on. Extend the NFP tunnel match function to include these new fields. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman

[PATCH net-next 1/6] nfp: flower: set ip tunnel ttl from encap action

2018-08-07 Thread Simon Horman
From: John Hurley The TTL for encapsulating headers in IPv4 UDP tunnels is taken from a route lookup. Modify this to first check if a user has specified a TTL to be used in the TC action. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman ---

[PATCH net-next 0/6] nfp: flower: tunnel TTL & TOS, and Geneve options set & match support

2018-08-07 Thread Simon Horman
Hi Dave, this series contains updates for the TC Flower classifier and the offload facility for it in the NFP driver. * Patches 1 & 2: update the NFP driver to allow offload of matching and setting tunnel ToS/TTL of flows using the TC Flower classifier and tun_key action * Patches 3 & 4:

[PATCH net-next 3/6] flow_dissector: allow dissection of tunnel options from metadata

2018-08-07 Thread Simon Horman
Allow the existing 'dissection' of tunnel metadata to 'dissect' options already present in tunnel metadata. This dissection is controlled by a new dissector key, FLOW_DISSECTOR_KEY_ENC_OPTS. This dissection only occurs when skb_flow_dissect_tunnel_info() is called, currently only the Flower

RE: [PATCH net-next,v3] net/tls: Calculate nsg for zerocopy path without skb_cow_data.

2018-08-07 Thread Vakul Garg
> -Original Message- > From: Doron Roberts-Kedes [mailto:doro...@fb.com] > Sent: Tuesday, August 7, 2018 1:18 AM > To: David S . Miller > Cc: Vakul Garg ; Dave Watson > ; Boris Pismenny ; Aviad > Yehezkel ; netdev@vger.kernel.org; Doron > Roberts-Kedes > Subject: [PATCH net-next,v3]

Re: [PATCH net-next] ieee802154: hwsim: fix rcu address annotation

2018-08-07 Thread David Miller
From: Stefan Schmidt Date: Tue, 7 Aug 2018 17:28:43 +0200 > Could you apply this patch directly to net-next? Sure, no problem, done.

Re: [PATCH net-next] ieee802154: hwsim: fix rcu address annotation

2018-08-07 Thread Stefan Schmidt
Hello Dave. On 08/07/2018 04:34 PM, Alexander Aring wrote: > This patch fixes the following sparse warning about mismatch rcu > attribute for address space annotation: > > ... > error: incompatible types in comparison expression (different modifiers) > error: incompatible types in comparison

[PATCH net-next 4/6] net/sched: allow flower to match tunnel options

2018-08-07 Thread Simon Horman
From: Pieter Jansen van Vuuren Allow matching on options in Geneve tunnel headers. This makes use of existing tunnel metadata support. The options can be described in the form CLASS:TYPE:DATA/CLASS_MASK:TYPE_MASK:DATA_MASK, where CLASS is represented as a 16bit hexadecimal value, TYPE as an

Re: [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order

2018-08-07 Thread Stefano Brivio
Hi Pravin, On Tue, 31 Jul 2018 16:12:03 -0700 Pravin Shelar wrote: > Rather than reducing number of thread down to 1, we could find better > number of FDs per port. > How about this simple solution: > 1. Allocate (N * P) FDs as long as it is under FD limit. > 2. If FD limit (-EMFILE) is hit

Re: [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order

2018-08-07 Thread Stefano Brivio
On Tue, 7 Aug 2018 15:31:11 +0200 Stefano Brivio wrote: > I would instead try to address the concerns that you had about the > original patch adding fairness in the kernel, rather than trying to > make the issue appear less severe in ovs-vswitchd. And, by the way, if we introduce a way to

Re: [PATCH bpf-next 2/3] selftests/bpf: add test cases for BPF_MAP_TYPE_QUEUE

2018-08-07 Thread Daniel Borkmann
On 08/06/2018 03:58 PM, Mauricio Vasquez B wrote: > Signed-off-by: Mauricio Vasquez B > --- > tools/include/uapi/linux/bpf.h |5 ++ > tools/testing/selftests/bpf/test_maps.c | 72 > +++ > 2 files changed, 77 insertions(+) > > diff --git

Re: [PATCH v8 bpf-next 02/10] veth: Add driver XDP

2018-08-07 Thread Daniel Borkmann
On 08/03/2018 09:58 AM, Toshiaki Makita wrote: > This is the basic implementation of veth driver XDP. > > Incoming packets are sent from the peer veth device in the form of skb, > so this is generally doing the same thing as generic XDP. > > This itself is not so useful, but a starting point to

[PATCH net-next] ieee802154: hwsim: fix rcu address annotation

2018-08-07 Thread Alexander Aring
This patch fixes the following sparse warning about mismatch rcu attribute for address space annotation: ... error: incompatible types in comparison expression (different modifiers) error: incompatible types in comparison expression (different address spaces) ... Some __rcu annotation was at

Re: [PATCH bpf-next 1/3] bpf: add bpf queue map

2018-08-07 Thread Daniel Borkmann
On 08/06/2018 03:58 PM, Mauricio Vasquez B wrote: > Bpf queue implements a LIFO/FIFO data containers for ebpf programs. > > It allows to push an element to the queue by using the update operation > and to pop an element from the queue by using the lookup operation. > > A use case for this is to

Re: [PATCH bpf-next 1/3] bpf: add bpf queue map

2018-08-07 Thread Alexei Starovoitov
On Mon, Aug 06, 2018 at 03:58:30PM +0200, Mauricio Vasquez B wrote: > Bpf queue implements a LIFO/FIFO data containers for ebpf programs. queue/stack datastructure would be a great addition. > It allows to push an element to the queue by using the update operation > and to pop an element from

Re: [PATCH RFC net-next 1/1] net/tls: Combined memory allocation for decryption request

2018-08-07 Thread Dave Watson
Hi Vakul, Only minor comments, mostly looks good to me. Thanks > +/* This function decrypts the input skb into either out_iov or in out_sg > + * or in skb buffers itself. The input parameter 'zc' indicates if > + * zero-copy mode needs to be tried or not. With zero-copy mode, either > + *

Re: [PATCH 4.9-stable] tcp: add tcp_ooo_try_coalesce() helper

2018-08-07 Thread Greg KH
On Sat, Aug 04, 2018 at 10:10:00AM +0100, David Woodhouse wrote: > From: Eric Dumazet > > commit 58152ecbbcc6a0ce7fddd5bf5f6ee535834ece0c upstream. > > In case skb in out_or_order_queue is the result of > multiple skbs coalescing, we would like to get a proper gso_segs > counter tracking, so

  1   2   >