Re: [v3, net-next, 02/12] net: stmmac: Do not keep rearming the coalesce timer in stmmac_xmit

On Fri, 2018-05-18 at 14:55 +0100, Jose Abreu wrote: > This is cutting down performance. Once the timer is armed it should run > after the time expires for the first packet sent and not the last one. > > After this change, running iperf, the performance gain is +/- 24%. Hi Guys, Since v4.18, we

[PATCH 1/1] tap: RCU usage and comment fixes

The tap_queue and the 'tap_dev' are loosely coupled, not 'macvlan_dev'. Taking rcu_read_lock a little later seems can slightly reduce rcu read critical section. Signed-off-by: Wang Jian --- drivers/net/tap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH iproute2-next] iproute_lwtunnel: allow specifying 'src' for 'encap ip' / 'encap ip6'

This allows the user to specify the LWTUNNEL_IP_SRC/LWTUNNEL_IP6_SRC when setting an lwtunnel encapsulation route. Signed-off-by: Shmulik Ladkani --- ip/iproute_lwtunnel.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/ip/iproute_lwtunnel.c

Dear intended recipient

-- Good-Day!, Can you assist me to handle this transaction? I will forward you the full details about the transaction if you are ready. Yours faithfully Mr. Malik Sanfo --

[PATCH] datapath.c: fix missing return value check of nla_nest_start()

Function queue_userspace_packet() defined in net/openvswitch/datapath.c calls nla_nest_start() to allocate memory for struct nlattr which is dereferenced immediately. As nla_nest_start() may return NULL on failure, this code piece may cause NULL pointer dereference bug. ---

[regression] r8169 without realtek_phy

There is network regression for me. 4.18 was good. 4.18+ is bad. There was some phy changes in r8169 driver. Fortunately adding CONFIG_REALTEK_PHY=m to kernel config fixed the regression. Should r8169 depend on realtek_phy? Does that breaks something else? Network doesn't work with Generic PHY

mv88e6xxx: question: can switch irq be shared?

Hello, I am wondering if the main device irq in dsa/mv88e6xxx/chip.c can be requested as shared (see patch below). The reason is that our board is wired so that irqs from all switches come to the same gpio. Marek --- drivers/net/dsa/mv88e6xxx/chip.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: virtio_net failover and initramfs (was: Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework)

On 16.08.2018 00:17, Siwei Liu wrote: > On Wed, Aug 15, 2018 at 12:05 PM, Samudrala, Sridhar > wrote: >> On 8/14/2018 5:03 PM, Siwei Liu wrote: >>> >>> Are we sure all userspace apps skip and ignore slave interfaces by >>> just looking at "IFLA_MASTER" attribute? >>> >>> When STANDBY is enabled

Re: virtio_net failover and initramfs (was: Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework)

On 17.08.2018 11:51, Harald Hoyer wrote: > On 16.08.2018 00:17, Siwei Liu wrote: >> On Wed, Aug 15, 2018 at 12:05 PM, Samudrala, Sridhar >> wrote: >>> On 8/14/2018 5:03 PM, Siwei Liu wrote: Are we sure all userspace apps skip and ignore slave interfaces by just looking at

[PATCH net-next] net: dsa: mv88e6xxx: Share main switch IRQ

On some boards the interrupt can be shared between multiple devices. For example on Turris Mox the interrupt is shared between all switches. Signed-off-by: Marek Behun --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [iproute PATCH 07/10] ip: Add missing -M flag to help text

Hi Stephen, On Thu, Aug 16, 2018 at 12:27:59PM +0200, Phil Sutter wrote: > Signed-off-by: Phil Sutter > --- > ip/ip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Seems like this patch wasn't applied. Did you perhaps drop it by accident? Cheers, Phil

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

On Thu, 16 Aug 2018 14:02:44 +0200, Eelco Chaudron wrote: > On 11 Aug 2018, at 21:06, David Miller wrote: > > > From: Jakub Kicinski > > Date: Thu, 9 Aug 2018 20:26:08 -0700 > > > >> It is not immediately clear why this is needed. The memory and > >> updating two sets of counters won't come

Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1

On Thu, Aug 16, 2018 at 11:58 PM, Russell King - ARM Linux wrote: > On Thu, Aug 16, 2018 at 10:35:16PM +0200, Marc Haber wrote: >> On Mon, Jun 25, 2018 at 05:41:27PM +0100, Peter Robinson wrote: >> > So with that and the other fix there was no improvement, with those >> > and the BPF JIT disabled

[PATCH]ipv6: multicast: In mld_send_cr function moving read lock to second for loop

In function mld_send_cr, the first loop is already protected by idev->mc_lock, it dont need idev->lock read lock, hence moving it only to second for loop. Signed-off-by: Guruswamy Basavaiah --- net/ipv6/mcast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/mcast.c

Re: mv88e6xxx: question: can switch irq be shared?

On Fri, Aug 17, 2018 at 11:30:55AM +0200, Marek Behún wrote: > Hello, I am wondering if the main device irq in > dsa/mv88e6xxx/chip.c can be requested as shared (see patch below). This probably works O.K, but its not something anybody else has done. So there could be some hidden issues.

Re: [PATCH iproute2-next] iproute_lwtunnel: allow specifying 'src' for 'encap ip' / 'encap ip6'

On Fri, 17 Aug 2018 10:31:34 +0300 Shmulik Ladkani wrote: > This allows the user to specify the LWTUNNEL_IP_SRC/LWTUNNEL_IP6_SRC > when setting an lwtunnel encapsulation route. > > Signed-off-by: Shmulik Ladkani > --- > ip/iproute_lwtunnel.c | 22 -- > 1 file changed, 20

Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts

On Fri, Aug 17, 2018 at 06:35:41PM +0530, Ganesh Goudar wrote: > Thanks, Al. The patch looks good to me but it does not seem > to be showing up in patchwork, should I resend the patch on > your behalf to net tree ? Umm... I thought net-next had been closed until -rc1, hadn't it? Anyway,

Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1

On 08/17/2018 02:25 PM, Peter Robinson wrote: > On Thu, Aug 16, 2018 at 11:58 PM, Russell King - ARM Linux > wrote: >> On Thu, Aug 16, 2018 at 10:35:16PM +0200, Marc Haber wrote: >>> On Mon, Jun 25, 2018 at 05:41:27PM +0100, Peter Robinson wrote: So with that and the other fix there was no

Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts

Thanks, Al. The patch looks good to me but it does not seem to be showing up in patchwork, should I resend the patch on your behalf to net tree ? Ganesh

[PATCH ethtool] ethtool: document WoL filters option also in help message

Commit eff0bb337223 ("ethtool: Add support for WAKE_FILTER (WoL using filters)") added option "f" for wake on lan and documented it in man page but not in the output of "ethtool --help". Signed-off-by: Michal Kubecek --- ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] net: dsa: add support for ksz9897 ethernet switch

Hi, this email is from Rob's (experimental) review bot. I found a couple of common problems with your patch. Please see below. On Wed, 15 Aug 2018 16:51:23 +0100, Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > ksz9477 is superset of ksz9xx series, driver just works > out of the box for

Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1

On Fri, Aug 17, 2018 at 1:40 PM, Daniel Borkmann wrote: > On 08/17/2018 02:25 PM, Peter Robinson wrote: >> On Thu, Aug 16, 2018 at 11:58 PM, Russell King - ARM Linux >> wrote: >>> On Thu, Aug 16, 2018 at 10:35:16PM +0200, Marc Haber wrote: On Mon, Jun 25, 2018 at 05:41:27PM +0100, Peter

Re: [PATCH iproute2] ipmaddr: use preferred_family when given

On Fri, Aug 17, 2018 at 9:29 AM, Stephen Hemminger wrote: > On Wed, 15 Aug 2018 16:08:55 -0700 > Mahesh Bandewar wrote: > >> From: Mahesh Bandewar >> >> When creating socket() AF_INET is used irrespective of the family >> that is given at the command-line (with -4, -6, or -0). This change >>

[PATCH net-next] r8169: add missing Kconfig dependency

Now that we switched the r8169 driver to use phylib, there's a dependency on the Realtek PHY drivers. This dependency was missing in Kconfig. Reported-by: Jouni Mettälä Fixes: f1e911d5d0df ("r8169: add basic phylib support") Signed-off-by: Heiner Kallweit ---

Re: [iproute PATCH v4] Make colored output configurable

On Thu, 16 Aug 2018 11:37:03 +0200 Phil Sutter wrote: > Allow for -color={never,auto,always} to have colored output disabled, > enabled only if stdout is a terminal or enabled regardless of stdout > state. > > Signed-off-by: Phil Sutter > --- > Changes since v1: > - Allow to override isatty()

[PATCH] sunhme: convert printk to pr_cont

The kernel adds newlines automatically unless pr_cont is used. This patch converts sunhme to use pr_cont, so that the messages are not broken to multiple lines. The patch also adds "\n" to a few strings that were missing it. Signed-off-by: Mikulas Patocka Cc: sta...@vger.kernel.org ---

WICHTIGE MITTEILUNG

Lieber Freund, Ich bin Herr Richard Wahl der Mega-Gewinner von $ 533M In Mega Millions Jackpot spende ich an 5 zufällige Personen, wenn Sie diese E-Mail erhalten, dann wurde Ihre E-Mail nach einem Spinball ausgewählt. Ich habe den größten Teil meines Vermögens auf eine Reihe von

Re: [PATCH bpf] tools/bpf: fix bpf selftest test_cgroup_storage failure

On Fri, Aug 17, 2018 at 08:54:15AM -0700, Yonghong Song wrote: > The bpf selftest test_cgroup_storage failed in one of > our production test servers. > # sudo ./test_cgroup_storage > Failed to create map: Operation not permitted > > It turns out this is due to insufficient locked memory >

Re: [PATCH net-next] net: dsa: mv88e6xxx: Share main switch IRQ

From: Marek Behún Date: Fri, 17 Aug 2018 12:09:49 +0200 > On some boards the interrupt can be shared between multiple devices. > For example on Turris Mox the interrupt is shared between all switches. > > Signed-off-by: Marek Behun The net-next tree is closed, please resubmit when it opens

Re: [PATCH iproute2] ipmaddr: use preferred_family when given

On Wed, 15 Aug 2018 16:08:55 -0700 Mahesh Bandewar wrote: > From: Mahesh Bandewar > > When creating socket() AF_INET is used irrespective of the family > that is given at the command-line (with -4, -6, or -0). This change > will open the socket with the preferred family. > > Signed-off-by:

Re: [PATCH iproute2-next] iproute_lwtunnel: allow specifying 'src' for 'encap ip' / 'encap ip6'

Hi, On Fri, 17 Aug 2018 08:00:22 -0700 Stephen Hemminger wrote: > If you accept an attribute on input you need to parse it and display it the > same way in the show command. Note print_encap_ip and print_encap_ip6 already handle LWTUNNEL_IP_SRC and LWTUNNEL_IP6_SRC (since long ago, 1e5293056

Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1

On 08/17/2018 06:17 PM, Russell King - ARM Linux wrote: > On Fri, Aug 17, 2018 at 02:40:19PM +0200, Daniel Borkmann wrote: >> I'd have one potential bug suspicion, for the 4.18 one you were trying, >> could you run with the below patch to see whether it would help? > > I think this is almost

Re: [PATCH ethtool] ethtool: document WoL filters option also in help message

On 08/17/2018 06:21 AM, Michal Kubecek wrote: > Commit eff0bb337223 ("ethtool: Add support for WAKE_FILTER (WoL using > filters)") added option "f" for wake on lan and documented it in man page > but not in the output of "ethtool --help". > > Signed-off-by: Michal Kubecek Acked-by: Florian

Re: [regression] r8169 without realtek_phy

On 17.08.2018 19:39, Florian Fainelli wrote: > +Heiner, > > On 08/17/2018 01:33 AM, Jouni Mettälä wrote: >> There is network regression for me. 4.18 was good. 4.18+ is bad. There >> was some phy changes in r8169 driver. Fortunately adding >> CONFIG_REALTEK_PHY=m to kernel config fixed the

Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1

Hi Daniel, > Daniel Borkmann hat am 17. August 2018 um 20:30 > geschrieben: > > > On 08/17/2018 06:17 PM, Russell King - ARM Linux wrote: > > On Fri, Aug 17, 2018 at 02:40:19PM +0200, Daniel Borkmann wrote: > >> I'd have one potential bug suspicion, for the 4.18 one you were trying, > >>

Re: virtio_net failover and initramfs

On 8/17/2018 2:56 AM, Harald Hoyer wrote: On 17.08.2018 11:51, Harald Hoyer wrote: On 16.08.2018 00:17, Siwei Liu wrote: On Wed, Aug 15, 2018 at 12:05 PM, Samudrala, Sridhar wrote: On 8/14/2018 5:03 PM, Siwei Liu wrote: Are we sure all userspace apps skip and ignore slave interfaces by just

RE: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

> On 8/16/2018 1:26 PM, Sagi Grimberg wrote: > > > >> Let me know if you want me to try this or any particular fix. > > > > Steve, can you test this one? > > Yes! I'll try it out tomorrow. > > Stevo > Hey Sagi, The patch works allowing connections for the various affinity mappings below:

Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1

On Fri, Aug 17, 2018 at 02:40:19PM +0200, Daniel Borkmann wrote: > I'd have one potential bug suspicion, for the 4.18 one you were trying, > could you run with the below patch to see whether it would help? I think this is almost certainly the problem - looking at the history, it seems that the

Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts

From: Al Viro Date: Fri, 17 Aug 2018 16:43:20 +0100 > Umm... I thought net-next had been closed until -rc1, hadn't > it? That's correct.

Re: [PATCH net-next] r8169: add missing Kconfig dependency

On 08/17/2018 11:42 AM, Heiner Kallweit wrote: > Now that we switched the r8169 driver to use phylib, there's a > dependency on the Realtek PHY drivers. This dependency was missing > in Kconfig. > > Reported-by: Jouni Mettälä > Fixes: f1e911d5d0df ("r8169: add basic phylib support") >

[PATCH bpf] tools/bpf: fix bpf selftest test_cgroup_storage failure

The bpf selftest test_cgroup_storage failed in one of our production test servers. # sudo ./test_cgroup_storage Failed to create map: Operation not permitted It turns out this is due to insufficient locked memory with system default 16KB. Similar to other self tests, let us arm the process

[iproute PATCH v5 1/2] Make colored output configurable

Allow for -color={never,auto,always} to have colored output disabled, enabled only if stdout is a terminal or enabled regardless of stdout state. Signed-off-by: Phil Sutter --- Changes since v1: - Allow to override isatty() check by specifying '-color' flag more than once. - Document new

[iproute PATCH 2/2] lib: Make check_enable_color() return boolean

As suggested, turn return code into true/false although it's not checked anywhere yet. Fixes: 4d829626a ("Merge common code for conditionally colored output") Signed-off-by: Phil Sutter --- include/color.h | 2 +- lib/color.c | 8 2 files changed, 5 insertions(+), 5

Re: [regression] r8169 without realtek_phy

+Heiner, On 08/17/2018 01:33 AM, Jouni Mettälä wrote: > There is network regression for me. 4.18 was good. 4.18+ is bad. There > was some phy changes in r8169 driver. Fortunately adding > CONFIG_REALTEK_PHY=m to kernel config fixed the regression. > > Should r8169 depend on realtek_phy? Does

Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts

On Fri, Aug 17, 2018 at 07:09:49PM +0100, Al Viro wrote: > Re that code - are you sure it doesn't need le64_to_cpu(*src)? Because from > what > I understand about PCI (which matches just fine to the comments in the same > driver), > you probably do need that. Again, the only real way to find

Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts

On Fri, Aug 17, 2018 at 07:58:41PM +0100, Al Viro wrote: > On Fri, Aug 17, 2018 at 07:09:49PM +0100, Al Viro wrote: > > > Re that code - are you sure it doesn't need le64_to_cpu(*src)? Because > > from what > > I understand about PCI (which matches just fine to the comments in the same > >

Re: mv88e6xxx: question: can switch irq be shared?

From: Marek Behún Date: Fri, 17 Aug 2018 11:30:55 +0200 > -IRQF_ONESHOT | IRQF_TRIGGER_FALLING, > +IRQF_ONESHOT | IRQF_TRIGGER_FALLING > +| IRQF_SHARED, The "|" operator shoudl end a line not start

Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts

On Fri, Aug 17, 2018 at 04:43:20PM +0100, Al Viro wrote: > On Fri, Aug 17, 2018 at 06:35:41PM +0530, Ganesh Goudar wrote: > > Thanks, Al. The patch looks good to me but it does not seem > > to be showing up in patchwork, should I resend the patch on > > your behalf to net tree ? > > Umm... I

Re: [PATCH bpf] bpf: fix redirect to map under tail calls

On Fri, Aug 17, 2018 at 11:26:14PM +0200, Daniel Borkmann wrote: > Commits 109980b894e9 ("bpf: don't select potentially stale ri->map > from buggy xdp progs") and 7c3001313396 ("bpf: fix ri->map_owner > pointer on bpf_prog_realloc") tried to mitigate that buggy programs > using bpf_redirect_map()

[RFC v3 net-next 0/5] eBPF and struct scatterlist

This is v3 of the RFC sent earlier, (https://patchwork.ozlabs.org/cover/931785/). v2->v3: - As per the review feedback received, this patchset reuses as much code as possible from sockmap/sk_msg. e.g. it uses existing struct sk_msg_buff, struct sk_msg_md, sk_msg_convert_ctx_access and part of

[RFC v3 net-next 1/5] eBPF: Add new eBPF prog type BPF_PROG_TYPE_SOCKET_SG_FILTER

Add new eBPF prog type BPF_PROG_TYPE_SOCKET_SG_FILTER which uses the existing socket filter infrastructure for bpf program attach and load. SOCKET_SG_FILTER eBPF program receives struct scatterlist as bpf context contrast to SOCKET_FILTER which deals with struct skb. This is useful for kernel

[RFC v3 net-next 4/5] rds: invoke socket sg filter attached to rds socket

RDS module sits on top of TCP (rds_tcp) and IB (rds_rdma), so messages arrive in form of skb (over TCP) and scatterlist (over IB/RDMA). However, because socket filter only deal with skb (e.g. struct skb as bpf context) we can only use socket filter for rds_tcp and not for rds_rdma. Considering

[RFC v3 net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER

Add a sample program that shows how socksg program is used and attached to socket filter. The kernel sample program deals with struct scatterlist that is passed as bpf context. When run in server mode, the sample RDS program opens PF_RDS socket, attaches eBPF program to RDS socket which then uses

[RFC v3 net-next 2/5] ebpf: Add sg_filter_run()

When sg_filter_run() is invoked it runs the attached eBPF prog of type BPF_PROG_TYPE_SOCKET_SG_FILTER which deals with struct scatterlist. Signed-off-by: Tushar Dave Acked-by: Sowmini Varadhan --- include/linux/filter.h | 8 include/uapi/linux/bpf.h | 6 ++

[RFC v3 net-next 3/5] ebpf: fix bpf_msg_pull_data

Like sockmap (sk_msg), socksg also deals with struct scatterlist therefore socksg programs can use existing bpf helper bpf_msg_pull_data to access packet data contained in struct scatterlist. While doing some prelimnary testing, there are couple of issues found with bpf_msg_pull_data that are

[PATCH] fm10k_main.c: fix missing return value check of alloc_skb()

Function fm10k_init_module() defined in drivers/net/ethernet/intel/fm10k/fm10k_main.c calls alloc_workqueue() to allocate memory for struct workqueue_struct which is dereferenced immediately. As alloc_workqueue() may return NULL on failure, this code piece may cause NULL pointer dereference

[PATCH] fm10k_main.c: fix missing return value check of alloc_skb()

Function fm10k_init_module() defined in drivers/net/ethernet/intel/fm10k/fm10k_main.c calls alloc_workqueue() to allocate memory for struct workqueue_struct which is dereferenced immediately. As alloc_workqueue() may return NULL on failure, this code piece may cause NULL pointer dereference

pull-request: bpf 2018-08-18

Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix a BPF selftest failure in test_cgroup_storage due to rlimit restrictions, from Yonghong. 2) Fix a suspicious RCU rcu_dereference_check() warning triggered from removing a device's

Re: [PATCH] sunhme: convert printk to pr_cont

From: Mikulas Patocka Date: Fri, 17 Aug 2018 15:12:22 -0400 (EDT) > The kernel adds newlines automatically unless pr_cont is used. This patch > converts sunhme to use pr_cont, so that the messages are not broken to > multiple lines. > > The patch also adds "\n" to a few strings that were

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

Hey Sagi, The patch works allowing connections for the various affinity mappings below: One comp_vector per core across all cores, starting with numa-local cores: Thanks Steve, is this your "Tested by:" tag?

Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1

On Fri, Aug 17, 2018 at 5:17 PM, Russell King - ARM Linux wrote: > On Fri, Aug 17, 2018 at 02:40:19PM +0200, Daniel Borkmann wrote: >> I'd have one potential bug suspicion, for the 4.18 one you were trying, >> could you run with the below patch to see whether it would help? > > I think this is

Re: [Intel-wired-lan] [PATCH next-queue 0/8] ixgbe/ixgbevf: IPsec offload support for VFs

On Fri, Aug 17, 2018 at 4:19 PM Shannon Nelson wrote: > > > On 8/16/2018 2:36 PM, Shannon Nelson wrote: > > On 8/16/2018 2:15 PM, Alexander Duyck wrote: > >> On Tue, Aug 14, 2018 at 10:10 AM Shannon Nelson > >> wrote: > >>> > >>> On 8/14/2018 8:30 AM, Alexander Duyck wrote: > On Mon, Aug

Re: [Intel-wired-lan] [PATCH next-queue 0/8] ixgbe/ixgbevf: IPsec offload support for VFs

On 8/16/2018 2:36 PM, Shannon Nelson wrote: On 8/16/2018 2:15 PM, Alexander Duyck wrote: On Tue, Aug 14, 2018 at 10:10 AM Shannon Nelson wrote: On 8/14/2018 8:30 AM, Alexander Duyck wrote: On Mon, Aug 13, 2018 at 11:43 AM Shannon Nelson wrote: This set of patches implements IPsec

Re: Bug in FIB insert

On 8/16/18 6:59 PM, Md. Islam wrote: > There is a bug in fib_table_insert(). If I add following routes, > > 23.20.0.0/14     veth1 > 23.20.0.0/15     veth2 > > FIB lookup on 23.22.111.212  results veth1, not veth2. > veth1 is the correct lookup

Re: [PATCH] fm10k_main.c: fix missing return value check of alloc_skb()

On Sat, Aug 18, 2018 at 10:00:58AM +0800, Jiecheng Wu wrote: > Function fm10k_init_module() defined in > drivers/net/ethernet/intel/fm10k/fm10k_main.c calls alloc_workqueue() to > allocate memory for struct workqueue_struct which is dereferenced > immediately. As alloc_workqueue() may return

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

On Fri, Aug 17, 2018 at 01:03:20PM -0700, Sagi Grimberg wrote: > > > Hey Sagi, > > > > The patch works allowing connections for the various affinity mappings > > below: > > > > One comp_vector per core across all cores, starting with numa-local cores: > > Thanks Steve, is this your "Tested

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

Hi Jason, The new patchworks doesn't grab patches inlined in messages, so you will need to resend it. Yes, just wanted to to add Steve's tested by as its going to lists that did not follow this thread. Also, can someone remind me what the outcome is here? Does it supersede Leon's patch:

Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1

On Fri, Aug 17, 2018 at 7:30 PM, Daniel Borkmann wrote: > On 08/17/2018 06:17 PM, Russell King - ARM Linux wrote: >> On Fri, Aug 17, 2018 at 02:40:19PM +0200, Daniel Borkmann wrote: >>> I'd have one potential bug suspicion, for the 4.18 one you were trying, >>> could you run with the below patch

Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1

Hi Stefan, >> On 08/17/2018 06:17 PM, Russell King - ARM Linux wrote: >> > On Fri, Aug 17, 2018 at 02:40:19PM +0200, Daniel Borkmann wrote: >> >> I'd have one potential bug suspicion, for the 4.18 one you were trying, >> >> could you run with the below patch to see whether it would help? >> > >>

[PATCH bpf] bpf: fix redirect to map under tail calls

Commits 109980b894e9 ("bpf: don't select potentially stale ri->map from buggy xdp progs") and 7c3001313396 ("bpf: fix ri->map_owner pointer on bpf_prog_realloc") tried to mitigate that buggy programs using bpf_redirect_map() helper call do not leave stale maps behind. Idea was to add a map_owner

Re: [PATCH net-next v1] net/tls: Add support for async decryption of tls records

On 08/16/18 08:49 PM, Vakul Garg wrote: > Changes since RFC version: > 1) Improved commit message. > 2) Fixed dequeued record offset handling because of which few of > tls selftests 'recv_partial, recv_peek, recv_peek_multiple' were > failing. Thanks! Commit message much

Re: [PATCH bpf] tools/bpf: fix bpf selftest test_cgroup_storage failure

On Fri, Aug 17, 2018 at 08:54:15AM -0700, Yonghong Song wrote: > The bpf selftest test_cgroup_storage failed in one of > our production test servers. > # sudo ./test_cgroup_storage > Failed to create map: Operation not permitted > > It turns out this is due to insufficient locked memory >

RE: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

> > > > Hey Sagi, > > > > The patch works allowing connections for the various affinity mappings > below: > > > > One comp_vector per core across all cores, starting with numa-local cores: > > Thanks Steve, is this your "Tested by:" tag? Sure: Tested-by: Steve Wise

Re: [PATCH net-next] r8169: add missing Kconfig dependency

From: Florian Fainelli Date: Fri, 17 Aug 2018 11:45:57 -0700 > On 08/17/2018 11:42 AM, Heiner Kallweit wrote: >> Now that we switched the r8169 driver to use phylib, there's a >> dependency on the Realtek PHY drivers. This dependency was missing >> in Kconfig. >> >> Reported-by: Jouni Mettälä

Re: [PATCH] sunhme: convert printk to pr_cont

From: Mikulas Patocka Date: Fri, 17 Aug 2018 16:08:49 -0400 (EDT) > I'm not an expert on networking code - you can change it if it is more > appropriate this way. What Stephen is asking of you doesn't require networking expertiece and he even gave you an example of how to do it. All you would

Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1

On 08/17/2018 11:13 PM, Peter Robinson wrote: > On Fri, Aug 17, 2018 at 7:30 PM, Daniel Borkmann wrote: >> On 08/17/2018 06:17 PM, Russell King - ARM Linux wrote: >>> On Fri, Aug 17, 2018 at 02:40:19PM +0200, Daniel Borkmann wrote: I'd have one potential bug suspicion, for the 4.18 one you

Re: [PATCH] sunhme: convert printk to pr_cont

On Fri, 17 Aug 2018 15:12:22 -0400 (EDT) Mikulas Patocka wrote: > === > --- linux-stable.orig/drivers/net/ethernet/sun/sunhme.c 2018-04-20 > 18:11:00.0 +0200 > +++ linux-stable/drivers/net/ethernet/sun/sunhme.c

Re: [PATCH iproute2-next] iproute_lwtunnel: allow specifying 'src' for 'encap ip' / 'encap ip6'

On 8/17/18 1:31 AM, Shmulik Ladkani wrote: > This allows the user to specify the LWTUNNEL_IP_SRC/LWTUNNEL_IP6_SRC > when setting an lwtunnel encapsulation route. > > Signed-off-by: Shmulik Ladkani > --- > ip/iproute_lwtunnel.c | 22 -- > 1 file changed, 20 insertions(+), 2

Re: [iproute PATCH v5 1/2] Make colored output configurable

On 8/17/18 10:38 AM, Phil Sutter wrote: > Allow for -color={never,auto,always} to have colored output disabled, > enabled only if stdout is a terminal or enabled regardless of stdout > state. > > Signed-off-by: Phil Sutter > --- > Changes since v1: > - Allow to override isatty() check by

Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts

On Fri, Aug 17, 2018 at 07:59:44PM +0100, Al Viro wrote: > On Fri, Aug 17, 2018 at 07:58:41PM +0100, Al Viro wrote: > > On Fri, Aug 17, 2018 at 07:09:49PM +0100, Al Viro wrote: > > > > > Re that code - are you sure it doesn't need le64_to_cpu(*src)? Because > > > from what > > > I understand

Re: [PATCH] sunhme: convert printk to pr_cont

On Fri, 17 Aug 2018, Stephen Hemminger wrote: > On Fri, 17 Aug 2018 15:12:22 -0400 (EDT) > Mikulas Patocka wrote: > > > === > > --- linux-stable.orig/drivers/net/ethernet/sun/sunhme.c 2018-04-20 > > 18:11:00.0 +0200

RE: [PATCH net-next v1] net/tls: Add support for async decryption of tls records

> -Original Message- > From: Dave Watson > Sent: Saturday, August 18, 2018 3:43 AM > To: Vakul Garg > Cc: netdev@vger.kernel.org; bor...@mellanox.com; > avia...@mellanox.com; da...@davemloft.net > Subject: Re: [PATCH net-next v1] net/tls: Add support for async decryption of > tls