[PATCH iproute2] testsuite: ss: Fix spacing in expected output for ssfilter.t

2018-11-10 Thread Stefano Brivio
Since commit 00240899ec0b ("ss: Actually print left delimiter for columns") changes spacing in ss output, we also need to adjust for that in the ss filter test. Fixes: 00240899ec0b ("ss: Actually print left delimiter for columns") Signed-off-by: Stefano Brivio --- testsuite/tests/ss/ssfilter.t

Re: [RFC PATCH 0/3] acpi: Add acpi mdio support code

2018-11-10 Thread Wang, Dongsheng
Hi Andrew, On 2018/11/9 7:23, Andrew Lunn wrote: > On Thu, Nov 08, 2018 at 03:21:29PM +0800, Wang Dongsheng wrote: >> Originally I just push "phy-handle" support for ACPI on the QCOM QDF2400 >> platform. After some discussion and following Andrew's advice, I send >> out with a generic version of

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-10 Thread Paweł Staszewski
W dniu 10.11.2018 o 01:06, David Ahern pisze: On 11/9/18 9:21 AM, David Ahern wrote: Is there possible to add only counters from xdp for vlans ? This will help me in testing. I will take a look today at adding counters that you can dump using bpftool. It will be a temporary solution for

Re: [PATCH] add an initial version of snmp_counter.rst

2018-11-10 Thread Randy Dunlap
On 11/9/18 10:13 AM, yupeng wrote: > The snmp_counter.rst run a set of simple experiments, explains the > meaning of snmp counters depend on the experiments' results. This is > an initial version, only covers a small part of the snmp counters. > > Signed-off-by: yupeng > --- >

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-10 Thread David Ahern
On 11/10/18 6:18 AM, Paweł Staszewski wrote: > > ./xdp_fwd enp175s0f0 enp175s0f1 > libbpf: failed to create map (name: 'stats_map'): Operation not permitted > libbpf: failed to load object './xdp_fwd_kern.o' Forgot I had increased locked memory: ulimit -l unlimited ./xdp_fwd enp175s0f0

Re: [PATCH mlx5-next 08/10] IB/mlx5: Call PAGE_FAULT_RESUME command asynchronously

2018-11-10 Thread Leon Romanovsky
On Fri, Nov 09, 2018 at 09:59:53AM -0700, Jason Gunthorpe wrote: > On Fri, Nov 09, 2018 at 06:26:22PM +0200, Leon Romanovsky wrote: > > On Thu, Nov 08, 2018 at 07:49:03PM +, Jason Gunthorpe wrote: > > > On Thu, Nov 08, 2018 at 09:10:15PM +0200, Leon Romanovsky wrote: > > > > From: Moni Shoua

[PATCH net-next] OVS: remove VLAN_TAG_PRESENT - fixup

2018-11-10 Thread Michał Mirosław
It turns out I missed one VLAN_TAG_PRESENT in OVS code while rebasing. This fixes it. Fixes: 9df46aefafa6 ("OVS: remove use of VLAN_TAG_PRESENT") Signed-off-by: Michał Mirosław --- net/openvswitch/flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/openvswitch/flow.c

Re: [PATCH bpf-next 0/3] bpf: Allow narrow loads with offset > 0

2018-11-10 Thread Alexei Starovoitov
On Tue, Nov 06, 2018 at 05:23:25PM -0800, Andrey Ignatov wrote: > This patch set adds support for narrow loads with offset > 0 to BPF > verifier. > > Patch 1 provides more details and is the main patch in the set. > Patches 2 and 3 add new test cases to test_verifier and test_sock_addr >

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-10 Thread Paweł Staszewski
W dniu 10.11.2018 o 20:34, Jesper Dangaard Brouer pisze: I want you to experiment with: ethtool --set-priv-flags DEVICE rx_striding_rq off just checked that previously connectx4 was have thos disabled:  ethtool --show-priv-flags enp175s0f0 Private flags for enp175s0f0: rx_cqe_moder  

Re: [PATCH net-next v2] documentation of some IP/ICMP snmp counters

2018-11-10 Thread peng yu
my changes depend on previous feedback: 1 group counters by protocol 2 remove all text which is pasted from RFC 3 about the simple command as 'ping', I hope to provide a full test steps, so I still keep them in the document 4 use capital letter for the abbreviated keywords 5 tried to fix grammar

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-10 Thread Paweł Staszewski
W dniu 10.11.2018 o 20:34, Jesper Dangaard Brouer pisze: On Fri, 9 Nov 2018 23:20:38 +0100 Paweł Staszewski wrote: W dniu 08.11.2018 o 20:12, Paweł Staszewski pisze: CPU load is lower than for connectx4 - but it looks like bandwidth limit is the same :) But also after reaching

From Mr Hamzak Wadrago;

2018-11-10 Thread Hamzak Wadrago
I am Mr hamzak wadrago, the chief operating officer with my bank and I want to inform you that an amount of US$15.5 million will be moved on your name as the Foreign Business Partner to our late deceased customer. I need your help to receive this money as we shall share the money in the ratio of

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-10 Thread Paweł Staszewski
W dniu 10.11.2018 o 22:01, Jesper Dangaard Brouer pisze: On Sat, 10 Nov 2018 21:02:10 +0100 Paweł Staszewski wrote: W dniu 10.11.2018 o 20:34, Jesper Dangaard Brouer pisze: I want you to experiment with: ethtool --set-priv-flags DEVICE rx_striding_rq off just checked that previously

[BUG] xfrm: unable to handle kernel NULL pointer dereference

2018-11-10 Thread Jean-Philippe Menil
Hi guys, we're seeing unexpected crashes from kernel 4.15 to 4.18.17, using IPsec VTI interfaces, on several vpn hosts, since upgrade from 4.4. Attached, the offended oops against 4.18. Output of decodedecode: [ 37.134864] Code: 8b 44 24 70 0f c8 89 87 b4 00 00 00 48 8b 86 20 05 00 00 8b

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-10 Thread Jesper Dangaard Brouer
On Fri, 9 Nov 2018 23:20:38 +0100 Paweł Staszewski wrote: > W dniu 08.11.2018 o 20:12, Paweł Staszewski pisze: > > CPU load is lower than for connectx4 - but it looks like bandwidth > > limit is the same :) > > But also after reaching 60Gbit/60Gbit > > > >  bwm-ng v0.6.1 (probing every

Re: [PATCH iproute2] testsuite: ss: Fix spacing in expected output for ssfilter.t

2018-11-10 Thread Phil Sutter
Hi Stefano, On Sat, Nov 10, 2018 at 10:21:59AM +0100, Stefano Brivio wrote: > Since commit 00240899ec0b ("ss: Actually print left delimiter for > columns") changes spacing in ss output, we also need to adjust for that in > the ss filter test. > > Fixes: 00240899ec0b ("ss: Actually print left

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-10 Thread Jesper Dangaard Brouer
On Sat, 10 Nov 2018 20:56:02 +0100 Paweł Staszewski wrote: > W dniu 10.11.2018 o 20:49, Paweł Staszewski pisze: > > > > > > W dniu 10.11.2018 o 20:34, Jesper Dangaard Brouer pisze: > >> On Fri, 9 Nov 2018 23:20:38 +0100 Paweł Staszewski > >> wrote: > >> > >>> W dniu 08.11.2018 o 20:12,

Re: SACK compression patch causing performance drop

2018-11-10 Thread Eric Dumazet
On 11/08/2018 07:14 AM, Eric Dumazet wrote: > > > On 11/08/2018 12:23 AM, Jean-Louis Dupond wrote: >> Hi, >> >> Was somebody able to check this? >> Really think this should be fixed :) >> >> Thanks >> Jean-Louis >> > > I somehow missed this email. > > Packet captures might help, please send

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-10 Thread Jesper Dangaard Brouer
On Sat, 10 Nov 2018 21:02:10 +0100 Paweł Staszewski wrote: > W dniu 10.11.2018 o 20:34, Jesper Dangaard Brouer pisze: > > I want you to experiment with: > > > > ethtool --set-priv-flags DEVICE rx_striding_rq off > > just checked that previously connectx4 was have thos disabled: >  ethtool

[PATCH net-next v2] documentation of some IP/ICMP snmp counters

2018-11-10 Thread yupeng
The snmp_counter.rst explains the meanings of snmp counters. It also provides a set of experiments (only 1 for this initial patch), combines the experiments' resutls and the snmp counters' meanings. This is an initial path, only explains a part of IP/ICMP counters and provide a simple ping test.

Re: [PATCH net-next] OVS: remove VLAN_TAG_PRESENT - fixup

2018-11-10 Thread David Miller
From: Michał Mirosław Date: Sat, 10 Nov 2018 19:55:34 +0100 > It turns out I missed one VLAN_TAG_PRESENT in OVS code while rebasing. > This fixes it. > > Fixes: 9df46aefafa6 ("OVS: remove use of VLAN_TAG_PRESENT") > Signed-off-by: Michał Mirosław Applied, thanks.

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-10 Thread Paweł Staszewski
W dniu 10.11.2018 o 22:53, Paweł Staszewski pisze: W dniu 10.11.2018 o 22:01, Jesper Dangaard Brouer pisze: On Sat, 10 Nov 2018 21:02:10 +0100 Paweł Staszewski wrote: W dniu 10.11.2018 o 20:34, Jesper Dangaard Brouer pisze: I want you to experiment with:    ethtool --set-priv-flags

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-10 Thread Paweł Staszewski
W dniu 10.11.2018 o 23:06, Jesper Dangaard Brouer pisze: On Sat, 10 Nov 2018 20:56:02 +0100 Paweł Staszewski wrote: W dniu 10.11.2018 o 20:49, Paweł Staszewski pisze: W dniu 10.11.2018 o 20:34, Jesper Dangaard Brouer pisze: On Fri, 9 Nov 2018 23:20:38 +0100 Paweł Staszewski wrote:

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-10 Thread Paweł Staszewski
W dniu 10.11.2018 o 20:49, Paweł Staszewski pisze: W dniu 10.11.2018 o 20:34, Jesper Dangaard Brouer pisze: On Fri, 9 Nov 2018 23:20:38 +0100 Paweł Staszewski wrote: W dniu 08.11.2018 o 20:12, Paweł Staszewski pisze: CPU load is lower than for connectx4 - but it looks like bandwidth

Re: [PATCH net v2] net: sched: cls_flower: validate nested enc_opts_policy to avoid warning

2018-11-10 Thread David Miller
From: Jakub Kicinski Date: Fri, 9 Nov 2018 21:06:26 -0800 > TCA_FLOWER_KEY_ENC_OPTS and TCA_FLOWER_KEY_ENC_OPTS_MASK can only > currently contain further nested attributes, which are parsed by > hand, so the policy is never actually used resulting in a W=1 > build warning: > >

[PATCH net-next 2/2] r8169: use proper constant for PCI vendor USR instead of numerical id

2018-11-10 Thread Heiner Kallweit
Use proper constant for PCI vendor USR instead of numerical id. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index

[PATCH net-next 1/2] PCI: add USR vendor id

2018-11-10 Thread Heiner Kallweit
Add U.S. Robotics (USR) PCI vendor id. Signed-off-by: Heiner Kallweit --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 69f0abe1b..144de2e89 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h

Re: [PATCH v5 bpf-next 0/7] bpftool: support loading flow dissector

2018-11-10 Thread Alexei Starovoitov
On Fri, Nov 09, 2018 at 12:15:11PM -0800, Jakub Kicinski wrote: > On Fri, 9 Nov 2018 08:21:39 -0800, Stanislav Fomichev wrote: > > v5 changes: > > * FILE -> PATH for load/loadall (can be either file or directory now) > > * simpler implementation for __bpf_program__pin_name > > * removed p_err for

[PATCH net-next] sctp: Fix SKB list traversal in sctp_intl_store_ordered().

2018-11-10 Thread David Miller
Same change as made to sctp_intl_store_reasm(). To be fully correct, an iterator has an undefined value when something like skb_queue_walk() naturally terminates. This will actually matter when SKB queues are converted over to list_head. Formalize what this code ends up doing with the current

RE,

2018-11-10 Thread Miss Juliet Muhammad
I have a deal for you, in your region.

[PATCH net-next 4/4] net: dsa: mv88e6xxx: Add support for SERDES on ports 2-8 for 6390X

2018-11-10 Thread Andrew Lunn
The 6390X family has 8 SERDES interfaces. When ports 9 and 10 are not using all their SERDES interfaces, the unused ones can be assigned to ports 2-8. Add support for interrupts from SERDES interfaces connected to these lower ports. Signed-off-by: Andrew Lunn ---

[PATCH net-next] net: dsa: mv88e6xxx: Work around mv886e6161 SERDES missing MII_PHYSID2

2018-11-10 Thread Andrew Lunn
We already have a workaround for a couple of switches whose internal PHYs only have the Marvel OUI, but no model number. We detect such PHYs and give them the 6390 ID as the model number. However the mv88e6161 has two SERDES interfaces in the same address range as its internal PHYs. These suffer

[PATCH bpf-next v2 1/3] bpf: Allow narrow loads with offset > 0

2018-11-10 Thread Andrey Ignatov
Currently BPF verifier allows narrow loads for a context field only with offset zero. E.g. if there is a __u32 field then only the following loads are permitted: * off=0, size=1 (narrow); * off=0, size=2 (narrow); * off=0, size=4 (full). On the other hand LLVM can generate a load with

[PATCH bpf-next v2 3/3] selftests/bpf: Test narrow loads with off > 0 for bpf_sock_addr

2018-11-10 Thread Andrey Ignatov
Add more test cases for context bpf_sock_addr to test narrow loads with offset > 0 for ctx->user_ip4 field (__u32): * off=1, size=1; * off=2, size=1; * off=3, size=1; * off=2, size=2. Signed-off-by: Andrey Ignatov --- tools/testing/selftests/bpf/test_sock_addr.c | 28 +--- 1

[PATCH bpf-next v2 0/3] bpf: Allow narrow loads with offset > 0

2018-11-10 Thread Andrey Ignatov
This patch set adds support for narrow loads with offset > 0 to BPF verifier. Patch 1 provides more details and is the main patch in the set. Patches 2 and 3 add new test cases to test_verifier and test_sock_addr selftests. v1->v2: - fix -Wdeclaration-after-statement warning. Andrey Ignatov

[PATCH bpf-next v2 2/3] selftests/bpf: Test narrow loads with off > 0 in test_verifier

2018-11-10 Thread Andrey Ignatov
Test the following narrow loads in test_verifier for context __sk_buff: * off=1, size=1 - ok; * off=2, size=1 - ok; * off=3, size=1 - ok; * off=0, size=2 - ok; * off=1, size=2 - fail; * off=0, size=2 - ok; * off=3, size=2 - fail. Signed-off-by: Andrey Ignatov ---

Re: [PATCH bpf-next v2 0/3] bpf: Allow narrow loads with offset > 0

2018-11-10 Thread Alexei Starovoitov
On Sat, Nov 10, 2018 at 10:15:12PM -0800, Andrey Ignatov wrote: > This patch set adds support for narrow loads with offset > 0 to BPF > verifier. > > Patch 1 provides more details and is the main patch in the set. > Patches 2 and 3 add new test cases to test_verifier and test_sock_addr >

[PATCH net-next 0/5] net: phy: convert advertise and supported to linkmode

2018-11-10 Thread Andrew Lunn
This is the last part in converting phylib to make use of a linux bitmap, not a u32, to represent links modes. This will allow support for PHYs > 1Gbps, which need to use link modes represented by a bit > 32. A number of MAC and PHY drivers need changes to support this. However the previous two

[PATCH net-next 2/5] net: phy: Convert u32 phydev->lp_advertising to linkmode

2018-11-10 Thread Andrew Lunn
Convert phy drivers to report the link partner advertised modes using a linkmode bitmap. This allows them to report the higher speeds which don't fit in a u32. Signed-off-by: Andrew Lunn --- drivers/net/phy/lxt.c| 4 ++-- drivers/net/phy/marvell.c| 26 --

[PATCH net-next 5/5] net: phy: Add support for resolving 5G and 2.5G autoneg

2018-11-10 Thread Andrew Lunn
Now that 2.5G and 5G can be represented in phydev->advertising and phydev->lp_advertising, add these two links modes as possible resolutions to auto negotiation. Signed-off-by: Andrew Lunn --- drivers/net/phy/phy-core.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH net-next 4/5] net: phy: Add more link modes to the settings table

2018-11-10 Thread Andrew Lunn
Now that PHYs and MAC can support more than 32 bit masks, add link modes which are > 31 to the PHY settings table. Signed-off-by: Andrew Lunn --- drivers/net/phy/phy-core.c | 162 - 1 file changed, 158 insertions(+), 4 deletions(-) diff --git

Re: [PATCH bpf-next 0/3] bpf: Allow narrow loads with offset > 0

2018-11-10 Thread Alexei Starovoitov
On Sat, Nov 10, 2018 at 11:13 AM Alexei Starovoitov wrote: > > On Tue, Nov 06, 2018 at 05:23:25PM -0800, Andrey Ignatov wrote: > > This patch set adds support for narrow loads with offset > 0 to BPF > > verifier. > > > > Patch 1 provides more details and is the main patch in the set. > > Patches

[PATCH net-next 0/2] r8169: add USR PCI vendor id

2018-11-10 Thread Heiner Kallweit
Add constant for U.S. Robotics (USR) PCI id and use it in the r8169 driver. Alternatively this change could go thorugh the PCI tree, up to Bjorn/David. Heiner Kallweit (2): PCI: add USR vendor id r8169: use proper constant for PCI vendor USR instead of id

Re: [PATCH bpf-next] filter: add BPF_ADJ_ROOM_DATA mode to bpf_skb_adjust_room()

2018-11-10 Thread Nicolas Dichtel
Le 09/11/2018 à 19:51, Martin Lau a écrit : > On Thu, Nov 08, 2018 at 04:11:37PM +0100, Nicolas Dichtel wrote: [snip] >> +static int bpf_skb_data_shrink(struct sk_buff *skb, u32 len) >> +{ >> +unsigned short hhlen = skb->dev->header_ops ? >> +

[PATCH] iucv: Remove SKB list assumptions.

2018-11-10 Thread David Miller
Eliminate the assumption that SKBs and SKB list heads can be cast to eachother in SKB list handling code. This change also appears to fix a bug since the list->next pointer is sampled outside of holding the SKB queue lock. Signed-off-by: David S. Miller --- net/iucv/af_iucv.c | 41

[PATCH net-next 3/5] net: phy: Fixup kerneldoc markup.

2018-11-10 Thread Andrew Lunn
Add missing markup for function parameters Signed-off-by: Andrew Lunn --- include/linux/mii.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mii.h b/include/linux/mii.h index e7112e878bb0..fb7ae4ae8ce3 100644 --- a/include/linux/mii.h +++ b/include/linux/mii.h

[PATCH net-next 1/5] net: ethernet: Convert phydev advertize and supported from u32 to link mode

2018-11-10 Thread Andrew Lunn
There are a few MAC/PHYs combinations which now support > 1Gbps. These may need to make use of link modes with bits > 31. Thus their supported PHY features or advertised features cannot be implemented using the current bitmap in a u32. Convert to using a linkmode bitmap, which can support all the

[patch net] net: dsa: mv88e6xxx: Fix clearing of stats counters

2018-11-10 Thread Andrew Lunn
The mv88e6161 would sometime fail to probe with a timeout waiting for the switch to complete an operation. This operation is supposed to clear the statistics counters. However, due to a read/modify/write, without the needed mask, the operation actually carried out was more random, with invalid

[PATCH net-next] net: phy: remove states PHY_STARTING and PHY_PENDING

2018-11-10 Thread Heiner Kallweit
Both states aren't used. Most likely they result from an idea that never materialized. So remove them. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.c | 7 --- include/linux/phy.h | 22 ++ 2 files changed, 2 insertions(+), 27 deletions(-) diff --git

[PATCH net-next 2/4] net: dsa: mv88e6xxx: Differentiate between 6390 and 6390X cmodes

2018-11-10 Thread Andrew Lunn
The X family variants support additional ports modes, for 10G operation, which the non-X variants don't have. Add a port_set_cmode() for non-X variants to enforce this. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 7 +-- drivers/net/dsa/mv88e6xxx/port.c | 15

[PATCH net-next 0/4] net: dsa: mv88e6xxx: Support more SERDES interfacxes

2018-11-10 Thread Andrew Lunn
Currently the SERDES interfaces for ports 9 and 10 on the mv88e6390x are supported, allowing upto 10G. However, when unused, these SERDES interfaces can be used by some of the lower ports for 1000Base-X. The tricky bit here is ordering. The SERDES have to become free from ports 9 or 10 before

[PATCH net-next 1/4] net: dsa: mv88e6xxx: Group cmode ops together

2018-11-10 Thread Andrew Lunn
Move .port_set_cmode next to .port_get_cmode. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index e05d4eddc935..13c6d76d9150 100644 ---

[PATCH net-next 3/4] net: dsa: mv88e6xxx: Default ports 9/10 6390X CMODE to 1000BaseX

2018-11-10 Thread Andrew Lunn
The 6390X family has 8 SERDES interfaces. This allows ports 9 and 10 to support up to 10Gbps using 4 SERDES interfaces. However, when lower speeds are used, which need fewer SERDES interfaces, the unused SERDES interfaces can be used by ports 2-8. The hardware defaults to ports 9 and 10 having

Re: Should the bridge learn from frames with link local destination MAC address?

2018-11-10 Thread Andrew Lunn
> >Andrew, I agree with your analysis also. We have hit this problem too > >(and we have an internal bug tracking it). > >We have not acted on this so far because of the fear of breaking > >existing deployments. I am all for fixing this if there is a > >clean way. > > +1 and since this would be a

[PATCH net] act_mirred: clear skb->tstamp on redirect

2018-11-10 Thread Eric Dumazet
If sch_fq is used at ingress, skbs that might have been timestamped by net_timestamp_set() if a packet capture is requesting timestamps could be delayed by arbitrary amount of time, since sch_fq time base is MONOTONIC. Fix this problem by moving code from sch_netem.c to act_mirred.c. Fixes:

[PATCH net-next] sctp: Fix SKB list traversal in sctp_intl_store_reasm().

2018-11-10 Thread David Miller
To be fully correct, an iterator has an undefined value when something like skb_queue_walk() naturally terminates. This will actually matter when SKB queues are converted over to list_head. Formalize what this code ends up doing with the current implementation. Signed-off-by: David S. Miller