Re: [PATCH net-next] nxp: fix trivial comment typo

2018-11-16 Thread Vladimir Zapolskiy
Hello Andrea, On 11/14/2018 08:47 PM, Andrea Claudi wrote: > s/rxfliterctrl/rxfilterctrl > > Signed-off-by: Andrea Claudi thank you for the patch, but let me ask you to change the subject line by adding the expected prefixes 'net: lpc_eth: fix trivial comment typo'. Also it would be nice to

[PATCH] socket: do a generic_file_splice_read when proto_ops has no splice_read

2018-11-16 Thread kaslevs
From: Slavomir Kaslev splice(2) fails with -EINVAL when called reading on a socket with no splice_read set in its proto_ops (such as vsock sockets). Switch this to fallbacks to a generic_file_splice_read instead. Signed-off-by: Slavomir Kaslev --- net/socket.c | 2 +- 1 file changed, 1

Re: [PATCH net-next 2/2] net/sched: act_police: don't use spinlock in the data path

2018-11-16 Thread Davide Caratti
On Thu, 2018-11-15 at 05:53 -0800, Eric Dumazet wrote: > > On 11/15/2018 03:43 AM, Davide Caratti wrote: > > On Wed, 2018-11-14 at 22:46 -0800, Eric Dumazet wrote: > > > On 09/13/2018 10:29 AM, Davide Caratti wrote: > > > > use RCU instead of spinlocks, to protect concurrent read/write on > > > >

selftests: net: udpgro.sh hangs on DUT devices running Linux -next

2018-11-16 Thread Naresh Kamboju
Kernel selftests: net: udpgro.sh hangs / waits forever on x86_64 and arm32 devices running Linux -next. Test getting PASS on arm64 devices. Do you see this problem ? Short error log: - ip6tables v1.6.1: can't initialize ip6tables table `nat': Table does not exist (do you need

Re: [RFC v1 2/3] vxlan: add support for underlay in non-default VRF

2018-11-16 Thread Alexis Bauvin
Le 16 nov. 2018 à 08:37, David Ahern a écrit : > On 11/15/18 2:05 AM, Alexis Bauvin wrote: >> Le 14 nov. 2018 à 20:58, David Ahern a écrit : >>> >>> you are making this more specific than it needs to be >>> >>> On 11/14/18 1:31 AM, Alexis Bauvin wrote: diff --git

[PATCH v3 1/4] bpf: allow zero-initializing hash map seed

2018-11-16 Thread Lorenz Bauer
Add a new flag BPF_F_ZERO_SEED, which forces a hash map to initialize the seed to zero. This is useful when doing performance analysis both on individual BPF programs, as well as the kernel's hash table implementation. Signed-off-by: Lorenz Bauer --- include/uapi/linux/bpf.h | 3 +++

[PATCH v3 0/4] bpf: allow zero-initialising hash map seed

2018-11-16 Thread Lorenz Bauer
Allow forcing the seed of a hash table to zero, for deterministic execution during benchmarking and testing. Changes from v2: * Change ordering of BPF_F_ZERO_SEED in linux/bpf.h Comments adressed from v1: * Add comment to discourage production use to linux/bpf.h * Require CAP_SYS_ADMIN Lorenz

[PATCH v3 3/4] tools: sync linux/bpf.h

2018-11-16 Thread Lorenz Bauer
Synchronize changes to linux/bpf.h from * "bpf: allow zero-initializing hash map seed" * "bpf: move BPF_F_QUERY_EFFECTIVE after map flags" Signed-off-by: Lorenz Bauer --- tools/include/uapi/linux/bpf.h | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git

[PATCH v3 4/4] tools: add selftest for BPF_F_ZERO_SEED

2018-11-16 Thread Lorenz Bauer
Check that iterating two separate hash maps produces the same order of keys if BPF_F_ZERO_SEED is used. Signed-off-by: Lorenz Bauer --- tools/testing/selftests/bpf/test_maps.c | 68 + 1 file changed, 57 insertions(+), 11 deletions(-) diff --git

Re: [PATCH net-next 6/8] net: eth: altera: tse: add support for ptp and timestamping

2018-11-16 Thread Dalon Westergreen
On Thu, 2018-11-15 at 18:14 -0800, Richard Cochran wrote: > On Thu, Nov 15, 2018 at 06:55:29AM -0800, Dalon Westergreen wrote: > > Sure, I would like to keep the debugfs entries for disabling freq > > correction,and > > reading the current scaled_ppm value. I intend to use these to tune > >

Compliment of the day to you Dear Friend.

2018-11-16 Thread Mrs Amina.Kadi
Compliment of the day to you Dear Friend. Dear Friend. I am Mrs. Amina Kadi. am sending this brief letter to solicit your partnership to transfer $5.5 million US Dollars. I shall send you more information and procedures when I receive positive response from you. Mrs. Amina Kadi

Re: [PATCH 00/10] add flow_rule infrastructure

2018-11-16 Thread Or Gerlitz
On Fri, Nov 16, 2018 at 3:43 AM Pablo Neira Ayuso wrote: > This patchset introduces a kernel intermediate representation (IR) to > express ACL hardware offloads, this is heavily based on the existing > flow dissector infrastructure and the TC actions. This IR can be used by > different frontend

[PATCH v3 2/4] bpf: move BPF_F_QUERY_EFFECTIVE after map flags

2018-11-16 Thread Lorenz Bauer
BPF_F_QUERY_EFFECTIVE is in the middle of the flags valid for BPF_MAP_CREATE. Move it to its own section to reduce confusion. Signed-off-by: Lorenz Bauer --- include/uapi/linux/bpf.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/uapi/linux/bpf.h

[PATCH net V3 4/5] net/smc: atomic SMCD cursor handling

2018-11-16 Thread Ursula Braun
Running uperf tests with SMCD on LPARs results in corrupted cursors. SMCD cursors should be treated atomically to fix cursor corruption. Signed-off-by: Ursula Braun --- net/smc/smc_cdc.c | 24 +-- net/smc/smc_cdc.h | 58 +--

[PATCH net V3 3/5] net/smc: add SMC-D shutdown signal

2018-11-16 Thread Ursula Braun
From: Hans Wippel When a SMC-D link group is freed, a shutdown signal should be sent to the peer to indicate that the link group is invalid. This patch adds the shutdown signal to the SMC code. Signed-off-by: Hans Wippel Signed-off-by: Ursula Braun --- net/smc/smc_core.c | 10 --

[PATCH net V3 2/5] net/smc: use queue pair number when matching link group

2018-11-16 Thread Ursula Braun
From: Karsten Graul When searching for an existing link group the queue pair number is also to be taken into consideration. When the SMC server sends a new number in a CLC packet (keeping all other values equal) then a new link group is to be created on the SMC client side. Signed-off-by:

[PATCH net V3 5/5] net/smc: use after free fix in smc_wr_tx_put_slot()

2018-11-16 Thread Ursula Braun
From: Ursula Braun In smc_wr_tx_put_slot() field pend->idx is used after being cleared. That means always idx 0 is cleared in the wr_tx_mask. This results in a broken administration of available WR send payload buffers. Signed-off-by: Ursula Braun --- net/smc/smc_wr.c | 4 +++- 1 file

[PATCH net V3 0/5] net/smc: fixes 2018-11-12

2018-11-16 Thread Ursula Braun
Dave, here is V3 of some net/smc fixes in different areas for the net tree. v1->v2: do not define 8-byte alignment for union smcd_cdc_cursor in patch 4/5 "net/smc: atomic SMCD cursor handling" v2->v3: stay with 8-byte alignment for union smcd_cdc_cursor in patch 4/5 "net/smc: atomic

[PATCH net V3 1/5] net/smc: abort CLC connection in smc_release

2018-11-16 Thread Ursula Braun
From: Hans Wippel In case of a non-blocking SMC socket, the initial CLC handshake is performed over a blocking TCP connection in a worker. If the SMC socket is released, smc_release has to wait for the blocking CLC socket operations (e.g., kernel_connect) inside the worker. This patch aborts a

[PATCH 1/3] bpf: respect size hint to BPF_PROG_TEST_RUN if present

2018-11-16 Thread Lorenz Bauer
Use data_size_out as a size hint when copying test output to user space. A program using BPF_PERF_OUTPUT can compare its own buffer length with data_size_out after the syscall to detect whether truncation has taken place. Callers which so far did not set data_size_in are not affected.

[PATCH 3/3] selftests: add a test for bpf_prog_test_run output size

2018-11-16 Thread Lorenz Bauer
Make sure that bpf_prog_test_run returns the correct length in the size_out argument and that the kernel respects the output size hint. Signed-off-by: Lorenz Bauer --- tools/testing/selftests/bpf/test_progs.c | 34 1 file changed, 34 insertions(+) diff --git

[PATCH 2/3] libbpf: require size hint in bpf_prog_test_run

2018-11-16 Thread Lorenz Bauer
Require size_out to be non-NULL if data_out is given. This prevents accidental overwriting of process memory after the output buffer. Adjust callers of bpf_prog_test_run to this behaviour. Signed-off-by: Lorenz Bauer --- tools/lib/bpf/bpf.c | 4 +++-

[PATCH 0/3] Fix unsafe BPF_PROG_TEST_RUN interface

2018-11-16 Thread Lorenz Bauer
Right now, there is no safe way to use BPF_PROG_TEST_RUN with data_out. This is because bpf_test_finish copies the output buffer to user space without checking its size. This can lead to the kernel overwriting data in user space after the buffer if xdp_adjust_head and friends are in play. Fix

Re: [PATCH net-next 2/2] net/sched: act_police: don't use spinlock in the data path

2018-11-16 Thread Eric Dumazet
On 11/16/2018 03:28 AM, Davide Caratti wrote: > On Thu, 2018-11-15 at 05:53 -0800, Eric Dumazet wrote: >> >> On 11/15/2018 03:43 AM, Davide Caratti wrote: >>> On Wed, 2018-11-14 at 22:46 -0800, Eric Dumazet wrote: On 09/13/2018 10:29 AM, Davide Caratti wrote: > use RCU instead of

Re: [PATCH net-next 2/2] net/sched: act_police: don't use spinlock in the data path

2018-11-16 Thread Eric Dumazet
On 11/16/2018 06:34 AM, Eric Dumazet wrote: > >> +s64 tcfp_toks; >> +s64 tcfp_ptoks; >> +s64 tcfp_t_c; > > I suggest to use a single cache line with a dedicated spinlock and these > three s64 > > spinlock_t

RE: [PATCH net-next 2/2] net/sched: act_police: don't use spinlock in the data path

2018-11-16 Thread David Laight
From: Eric Dumazet > Sent: 16 November 2018 14:35 ... > I suggest to use a single cache line with a dedicated spinlock and these > three s64 > > spinlock_t tcfp_lock cacheline_aligned_in_smp; > s64 ... > s64 ... > s64

Re: [PATCH net-next 6/8] net: eth: altera: tse: add support for ptp and timestamping

2018-11-16 Thread Dalon Westergreen
On Thu, 2018-11-15 at 18:14 -0800, Richard Cochran wrote: > On Thu, Nov 15, 2018 at 06:55:29AM -0800, Dalon Westergreen wrote: > > I would prefer to keep altera just to be consistent with the altera_tse > > stuff, > > and i intend to reusethis code for a 10GbE driver, so perhaps altera_tod to > >

Re: [PATCH net] sctp: not allow to set asoc prsctp_enable by sockopt

2018-11-16 Thread Neil Horman
On Thu, Nov 15, 2018 at 09:41:01PM -0200, Marcelo Ricardo Leitner wrote: > [ re-sending, without html this time ] > > On Thu, Nov 15, 2018, 15:26 Neil Horman > > On Thu, Nov 15, 2018 at 08:25:36PM -0200, Marcelo Ricardo Leitner wrote: > > > On Thu, Nov 15, 2018 at 04:43:10PM -0500, Neil Horman

Re: [PATCH net-next 2/2] net/sched: act_police: don't use spinlock in the data path

2018-11-16 Thread Eric Dumazet
On 11/16/2018 06:41 AM, David Laight wrote: > From: Eric Dumazet >> Sent: 16 November 2018 14:35 > ... >> I suggest to use a single cache line with a dedicated spinlock and these >> three s64 >> >> spinlock_t tcfp_lock cacheline_aligned_in_smp; >> s64 ... >>

Re: [PATCH v3 0/4] bpf: allow zero-initialising hash map seed

2018-11-16 Thread Song Liu
> On Nov 16, 2018, at 3:41 AM, Lorenz Bauer wrote: > > Allow forcing the seed of a hash table to zero, for deterministic > execution during benchmarking and testing. > > Changes from v2: > * Change ordering of BPF_F_ZERO_SEED in linux/bpf.h > > Comments adressed from v1: > * Add comment to

Re: [PATCH v3 0/4] bpf: allow zero-initialising hash map seed

2018-11-16 Thread Song Liu
> On Nov 16, 2018, at 3:41 AM, Lorenz Bauer wrote: > > Allow forcing the seed of a hash table to zero, for deterministic > execution during benchmarking and testing. > > Changes from v2: > * Change ordering of BPF_F_ZERO_SEED in linux/bpf.h > > Comments adressed from v1: > * Add comment to

Linux kernel hangs if using RV1108 with MSZ8863 switch with two ports connected

2018-11-16 Thread Otavio Salvador
Hi, I have a custom design based on Rockchip RV1108 that uses an MSZ8863 switch running kernel 4.19. The dts part is as follows: { pinctrl-names = "default"; pinctrl-0 = <_pins>; snps,reset-gpio = < RK_PC1 GPIO_ACTIVE_LOW>; snps,reset-active-low; clock_in_out = "output"; status = "okay"; };

Re: [PATCH net-next 7/8] net: eth: altera: tse: add msgdma prefetcher

2018-11-16 Thread Thor Thayer
Hi Dalon, Just a few comments/questions. On 11/14/18 6:50 PM, Dalon Westergreen wrote: From: Dalon Westergreen Add support for the mSGDMA prefetcher. The prefetcher adds support for a linked list of descriptors in system memory. The prefetcher feeds these to the mSGDMA dispatcher. The

[PATCH net-next] net: align pcpu_sw_netstats and pcpu_lstats structs

2018-11-16 Thread Eric Dumazet
Do not risk spanning these small structures on two cache lines, it is absolutely not worth it. For 32bit arches, the hint might not be enough, but we do not really care anymore. Signed-off-by: Eric Dumazet --- include/linux/netdevice.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH net] ip_tunnel: don't force DF when MTU is locked

2018-11-16 Thread Sabrina Dubroca
The various types of tunnels running over IPv4 can ask to set the DF bit to do PMTU discovery. However, PMTU discovery is subject to the threshold set by the net.ipv4.route.min_pmtu sysctl, and is also disabled on routes with "mtu lock". In those cases, we shouldn't set the DF bit. This patch

Re: [PATCH net-next 6/8] net: eth: altera: tse: add support for ptp and timestamping

2018-11-16 Thread Richard Cochran
On Fri, Nov 16, 2018 at 06:48:15AM -0800, Dalon Westergreen wrote: > For naming, how about intel_fpga_tod ? Fine by me. Thanks, Richard

Re: [Patch net] net: invert the check of detecting hardware RX checksum fault

2018-11-16 Thread Cong Wang
On Thu, Nov 15, 2018 at 8:50 PM Herbert Xu wrote: > > On Thu, Nov 15, 2018 at 06:23:38PM -0800, Cong Wang wrote: > > > > > Normally if the hardware's partial checksum is valid then we just > > > trust it and send the packet along. However, if the partial > > > checksum is invalid we don't trust

Re: [BUG] xfrm: unable to handle kernel NULL pointer dereference

2018-11-16 Thread Steffen Klassert
On Fri, Nov 16, 2018 at 08:48:00PM +0200, Lennert Buytenhek wrote: > On Sat, Nov 10, 2018 at 08:34:34PM +0100, Jean-Philippe Menil wrote: > > > we're seeing unexpected crashes from kernel 4.15 to 4.18.17, using > > IPsec VTI interfaces, on several vpn hosts, since upgrade from 4.4. > > I looked

Re: [Patch net] net: invert the check of detecting hardware RX checksum fault

2018-11-16 Thread Cong Wang
On Fri, Nov 16, 2018 at 12:06 PM Cong Wang wrote: > > Hmm, now I see how it works. Actually it uses the differences between > these two check's as the difference between hardware checksum with > skb_checksum(). > Well... This is true only when there is a skb_checksum_init*() or

Re: [Patch net] net: invert the check of detecting hardware RX checksum fault

2018-11-16 Thread Eric Dumazet
On 11/16/2018 12:15 PM, Cong Wang wrote: > On Thu, Nov 15, 2018 at 8:52 PM Eric Dumazet wrote: >> >> It is very possible NIC provides an incorrect CHECKSUM_COMPLETE, in the >> case non zero trailer bytes were added by a buggy switch (or host) >> >> Saeed can comment/confirm, but the theory is

[PATCH mlx5-next 10/12] net/mlx5: EQ, Generic EQ

2018-11-16 Thread Saeed Mahameed
Add mlx5_eq_{create/destroy}_generic APIs and EQE access methods, for mlx5 core consumers generic EQs. This API will be used in downstream patch to move page fault (RDMA ODP) EQ logic into mlx5_ib rdma driver, hence it will use a generic EQ. Current mlx5 EQ allocation scheme: On load mlx5

[PATCH mlx5-next 09/12] net/mlx5: EQ, Different EQ types

2018-11-16 Thread Saeed Mahameed
In mlx5 we have three types of usages for EQs, 1. Asynchronous EQs, used internally by mlx5 core for a. FW command completions b. FW page requests c. one EQ for all other Asynchronous events 2. Completion EQs, used for CQ completion (we create one per core) 3. *Special type of EQ (page fault)

[PATCH mlx5-next 03/12] net/mlx5: EQ, No need to store eq index as a field

2018-11-16 Thread Saeed Mahameed
eq->index is used only for completion EQs and is assigned to be the completion eq index, it is used only when traversing the completion eqs list, and it can be calculated dynamically, thus remove the eq->index field. Signed-off-by: Saeed Mahameed Reviewed-by: Leon Romanovsky Reviewed-by: Tariq

[PATCH mlx5-next 02/12] net/mlx5: EQ, Remove unused fields and structures

2018-11-16 Thread Saeed Mahameed
Some fields and structures are not referenced nor used by the driver, remove them. Signed-off-by: Saeed Mahameed Reviewed-by: Leon Romanovsky Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/eq.c | 11 --- include/linux/mlx5/driver.h | 3 --- 2

[PATCH mlx5-next 06/12] net/mlx5: EQ, Create all EQs in one place

2018-11-16 Thread Saeed Mahameed
Instead of creating the EQ table in three steps at driver load, - allocate irq vectors - allocate async EQs - allocate completion EQs Gather all of the procedures into one function in eq.c and call it from driver load. This will help us reduce the EQ and EQ table private structures visibility

Re: [Patch net] net: invert the check of detecting hardware RX checksum fault

2018-11-16 Thread Cong Wang
On Thu, Nov 15, 2018 at 8:52 PM Eric Dumazet wrote: > > It is very possible NIC provides an incorrect CHECKSUM_COMPLETE, in the > case non zero trailer bytes were added by a buggy switch (or host) > > Saeed can comment/confirm, but the theory is that the NIC does header > analysis and > computes

[PATCH net-next] add part of TCP counts explanations in snmp_counters.rst

2018-11-16 Thread yupeng
Add explanations of some generic TCP counters, fast open related counters and TCP abort related counters and several examples. Signed-off-by: yupeng --- Documentation/networking/snmp_counter.rst | 525 +- 1 file changed, 524 insertions(+), 1 deletion(-) diff --git

[PATCH net 1/2] tc-testing: tdc.py: ignore errors when decoding stdout/stderr

2018-11-16 Thread Lucas Bates
Prevent exceptions from being raised while decoding output from an executed command. There is no impact on tdc's execution and the verify command phase would fail the pattern match. Signed-off-by: Lucas Bates --- tools/testing/selftests/tc-testing/tdc.py | 4 ++-- 1 file changed, 2

[PATCH net 0/2] Prevent uncaught exceptions in tdc

2018-11-16 Thread Lucas Bates
This patch series addresses two potential bugs in tdc that can cause exceptions to be raised in certain circumstances. These exceptions are generally not handled, so instead we will prevent them from being raised. Brenda J. Butler (1): tc-testing: tdc.py: Guard against lack of returncode in

[PATCH net 2/2] tc-testing: tdc.py: Guard against lack of returncode in executed command

2018-11-16 Thread Lucas Bates
From: "Brenda J. Butler" Add some defensive coding in case one of the subprocesses created by tdc returns nothing. If no object is returned from exec_cmd, then tdc will halt with an unhandled exception. Signed-off-by: Brenda J. Butler Signed-off-by: Lucas Bates ---

Re: [BUG] xfrm: unable to handle kernel NULL pointer dereference

2018-11-16 Thread Lennert Buytenhek
On Sat, Nov 10, 2018 at 08:34:34PM +0100, Jean-Philippe Menil wrote: > we're seeing unexpected crashes from kernel 4.15 to 4.18.17, using > IPsec VTI interfaces, on several vpn hosts, since upgrade from 4.4. I looked into this with Jean-Philippe, and it appears to be crashing on a NULL pointer

Re: [PATCH] [PATCH net-next] tun: fix multiqueue rx

2018-11-16 Thread Matt Cover
On Fri, Nov 16, 2018 at 1:10 PM Michael S. Tsirkin wrote: > > On Fri, Nov 16, 2018 at 12:00:15AM -0700, Matthew Cover wrote: > > When writing packets to a descriptor associated with a combined queue, the > > packets should end up on that queue. > > > > Before this change all packets written to

Re: [Patch net] net: invert the check of detecting hardware RX checksum fault

2018-11-16 Thread Cong Wang
On Thu, Nov 15, 2018 at 8:59 PM Herbert Xu wrote: > > On Thu, Nov 15, 2018 at 08:52:23PM -0800, Eric Dumazet wrote: > > > > It is very possible NIC provides an incorrect CHECKSUM_COMPLETE, in the > > case non zero trailer bytes were added by a buggy switch (or host) > > We should probably change

RE: [PATCH iproute2-next v3] rdma: Document IB device renaming option

2018-11-16 Thread Ruhl, Michael J
>-Original Message- >From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- >ow...@vger.kernel.org] On Behalf Of Leon Romanovsky >Sent: Sunday, November 4, 2018 2:11 PM >To: David Ahern >Cc: Leon Romanovsky ; netdev >; RDMA mailing list ; >Stephen Hemminger >Subject: [PATCH

Re: [PATCH] [PATCH net-next] tun: fix multiqueue rx

2018-11-16 Thread Michael S. Tsirkin
On Fri, Nov 16, 2018 at 12:00:15AM -0700, Matthew Cover wrote: > When writing packets to a descriptor associated with a combined queue, the > packets should end up on that queue. > > Before this change all packets written to any descriptor associated with a > tap interface end up on rx-0, even

[PATCH mlx5-next 05/12] net/mlx5: EQ, Move all EQ logic to eq.c

2018-11-16 Thread Saeed Mahameed
Move completion EQs flows from main.c to eq.c, reasons: 1) It is where this logic belongs. 2) It will help centralize the EQ logic in one file for downstream refactoring, and future extensions/updates. Signed-off-by: Saeed Mahameed Reviewed-by: Leon Romanovsky Reviewed-by: Tariq Toukan ---

[PATCH mlx5-next 04/12] net/mlx5: EQ, Remove redundant completion EQ list lock

2018-11-16 Thread Saeed Mahameed
Completion EQs list is only modified on driver load/unload, locking is not required, remove it. Signed-off-by: Saeed Mahameed Reviewed-by: Leon Romanovsky Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/eq.c | 2 -- drivers/net/ethernet/mellanox/mlx5/core/main.c | 17

[PATCH mlx5-next 07/12] net/mlx5: EQ, irq_info and rmap belong to eq_table

2018-11-16 Thread Saeed Mahameed
irq_info and rmap are EQ properties of the driver, and only needed for EQ objects, move them to the eq_table EQs database structure. Signed-off-by: Saeed Mahameed Reviewed-by: Leon Romanovsky Reviewed-by: Tariq Toukan --- .../net/ethernet/mellanox/mlx5/core/en_main.c | 4 +-

[PATCH mlx5-next 11/12] {net,IB}/mlx5: Move Page fault EQ and ODP logic to RDMA

2018-11-16 Thread Saeed Mahameed
Use the new generic EQ API to move all ODP RDMA data structures and logic form mlx5 core driver into mlx5_ib driver. Signed-off-by: Saeed Mahameed Reviewed-by: Leon Romanovsky Reviewed-by: Tariq Toukan --- drivers/infiniband/hw/mlx5/main.c | 10 +-

[PATCH mlx5-next 08/12] net/mlx5: EQ, Privatize eq_table and friends

2018-11-16 Thread Saeed Mahameed
Move unnecessary EQ table structures and declaration from the public include/linux/mlx5/driver.h into the private area of mlx5_core and into eq.c/eq.h. Introduce new mlx5 EQ APIs: mlx5_comp_vectors_count(dev); mlx5_comp_irq_get_affinity_mask(dev, vector); And use them from mlx5_ib or mlx5e

[PATCH mlx5-next 00/12] mlx5 core generic EQ API for RDMA ODP

2018-11-16 Thread Saeed Mahameed
Hi, This patchset is for mlx5-next shared branch, and will be applied there once the review is done. This patchset introduces mostly refactoring work and EQ related code updates to allow moving the ODP rdma only logic from mlx5_core into mlx5 ib where it belongs, and will allow future updates

[PATCH mlx5-next 01/12] net/mlx5: EQ, Use the right place to store/read IRQ affinity hint

2018-11-16 Thread Saeed Mahameed
Currently the cpu affinity hint mask for completion EQs is stored and read from the wrong place, since reading and storing is done from the same index, there is no actual issue with that, but internal irq_info for completion EQs stars at MLX5_EQ_VEC_COMP_BASE offset in irq_info array, this patch

[PATCH mlx5-next 12/12] net/mlx5: EQ, Make EQE access methods inline

2018-11-16 Thread Saeed Mahameed
These are one/two liner generic EQ access methods, better have them declared static inline in eq.h. Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/eq.c | 23 - .../net/ethernet/mellanox/mlx5/core/lib/eq.h | 25 ++- 2 files changed, 24

Re: [PATCH bpf-next v2] bpftool: make libbfd optional

2018-11-16 Thread Alexei Starovoitov
On Mon, Nov 12, 2018 at 1:44 PM Stanislav Fomichev wrote: > > Make it possible to build bpftool without libbfd. libbfd and libopcodes are > typically provided in dev/dbg packages (binutils-dev in debian) which we > usually don't have installed on the fleet machines and we'd like a way to have >

Re: [PATCH bpf-next v2] bpftool: make libbfd optional

2018-11-16 Thread Alexei Starovoitov
On Fri, Nov 16, 2018 at 08:52:23PM -0800, Stanislav Fomichev wrote: > I actually wanted to follow up with a v2 when > https://lkml.org/lkml/2018/11/16/243 reaches bpf-next (I got an ack > already). it will go via perf tree, so not related. > Alternatively, I can follow up with another patch on

Re: [PATCH bpf-next v2] bpftool: make libbfd optional

2018-11-16 Thread Stanislav Fomichev
On 11/16, Alexei Starovoitov wrote: > On Fri, Nov 16, 2018 at 08:52:23PM -0800, Stanislav Fomichev wrote: > > I actually wanted to follow up with a v2 when > > https://lkml.org/lkml/2018/11/16/243 reaches bpf-next (I got an ack > > already). > > it will go via perf tree, so not related. My

Re: [PATCH net-next] selftests: add explicit test for multiple concurrent GRO sockets

2018-11-16 Thread David Miller
From: Paolo Abeni Date: Thu, 15 Nov 2018 03:24:05 +0100 > This covers for proper accounting of encap needed static keys > > Signed-off-by: Paolo Abeni Applied.

Re: [PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2018-11-16 Thread David Miller
From: Dalon Westergreen Date: Wed, 14 Nov 2018 16:50:40 -0800 > @@ -202,7 +204,7 @@ int sgdma_tx_buffer(struct altera_tse_private *priv, > struct tse_buffer *buffer) > /* enqueue the request to the pending transmit queue */ > queue_tx(priv, buffer); > > - return 1; > +

Re: [PATCH net-next v1 1/4] etf: Cancel timer if there are no pending skbs

2018-11-16 Thread David Miller
From: Vinicius Costa Gomes Date: Wed, 14 Nov 2018 17:26:32 -0800 > From: Jesus Sanchez-Palencia > > There is no point in firing the qdisc watchdog if there are no future > skbs pending in the queue and the watchdog had been set previously. > > Signed-off-by: Jesus Sanchez-Palencia Applied.

Re: [PATCH net-next v1 2/4] etf: Use cached rb_root

2018-11-16 Thread David Miller
From: Vinicius Costa Gomes Date: Wed, 14 Nov 2018 17:26:33 -0800 > From: Jesus Sanchez-Palencia > > ETF's peek() operation is heavily used so use an rb_root_cached instead > and leverage rb_first_cached() which will run in O(1) instead of > O(log n). > > Even if on 'timesortedlist_clear()' we

Re: [PATCH net-next v1 3/4] etf: Split timersortedlist_erase()

2018-11-16 Thread David Miller
From: Vinicius Costa Gomes Date: Wed, 14 Nov 2018 17:26:34 -0800 > From: Jesus Sanchez-Palencia > > This is just a refactor that will simplify the implementation of the > next patch in this series which will drop all expired packets on the > dequeue flow. > > Signed-off-by: Jesus

Re: [PATCH net-next v1 4/4] etf: Drop all expired packets

2018-11-16 Thread David Miller
From: Vinicius Costa Gomes Date: Wed, 14 Nov 2018 17:26:35 -0800 > From: Jesus Sanchez-Palencia > > Currently on dequeue() ETF only drops the first expired packet, which > causes a problem if the next packet is already expired. When this > happens, the watchdog will be configured with a time

Re: [PATCH net-next 0/3] dpaa2-eth: add bql support

2018-11-16 Thread David Miller
From: Ioana Ciocoi Radulescu Date: Wed, 14 Nov 2018 11:48:34 + > The first two patches make minor tweaks to the driver to > simplify bql implementation. The third patch adds the actual > bql support. Series applied, thanks!

Re: [PATCH] allow DSCP values in ip rulesB

2018-11-16 Thread David Miller
From: Pavel Balaev Date: Wed, 14 Nov 2018 17:30:37 +0300 > Hello, for now IP rules supports only old TOS values and we cannot use > DSCP. > > This patch adds support for DSCP values in IP rules: > > $ ip r add default via 192.168.0.6 table test > $ ip ru add tos 0x80 table test > $ ip ru > 0:

Re: [PATCH bpf-next v2] filter: add BPF_ADJ_ROOM_DATA mode to bpf_skb_adjust_room()

2018-11-16 Thread Alexei Starovoitov
On Tue, Nov 13, 2018 at 05:35:17PM +0100, Nicolas Dichtel wrote: > This new mode enables to add or remove an l2 header in a programmatic way > with cls_bpf. > For example, it enables to play with mpls headers. > > Signed-off-by: Nicolas Dichtel > Acked-by: Martin KaFai Lau Acked-by: Alexei

Re: [PATCH net-next] udp: fix jump label misuse

2018-11-16 Thread David Miller
From: Paolo Abeni Date: Thu, 15 Nov 2018 02:34:50 +0100 > The commit 60fb9567bf30 ("udp: implement complete book-keeping for > encap_needed") introduced a severe misuse of jump label APIs, which > syzbot, as reported by Eric, was able to exploit. > > When multiple sockets/process can

Re: [PATCH v2 04/21] octeontx2-af: Relax resource lock into mutex

2018-11-16 Thread David Miller
From: sunil.kovv...@gmail.com Date: Thu, 15 Nov 2018 16:29:29 +0530 > From: Stanislaw Kardach > > The resource locks does not need to be a spinlock as they are not > used in any interrupt handling routines (only in bottom halves). > Therefore relax them into a mutex so that later on we may use

Re: [PATCH net-next 0/7] net: sched: gred: introduce per-virtual queue attributes

2018-11-16 Thread David Miller
From: Jakub Kicinski Date: Wed, 14 Nov 2018 22:23:44 -0800 > This series updates the GRED Qdisc. The Qdisc matches nfp offload very > well, but before we can offload it there are a number of improvements > to make. > > First few patches add extack messages to the Qdisc and pass extack > to

Re: [PATCH bpf-next] selftests/bpf: Fix uninitialized duration warning

2018-11-16 Thread Alexei Starovoitov
On Fri, Nov 9, 2018 at 6:20 PM Joe Stringer wrote: > > Daniel Borkmann reports: > > test_progs.c: In function ‘main’: > test_progs.c:81:3: warning: ‘duration’ may be used uninitialized in this > function [-Wmaybe-uninitialized] >printf("%s:PASS:%s %d nsec\n", __func__, tag, duration);\ >

Re: [PATCH net] ipv6: fix a dst leak when removing its exception

2018-11-16 Thread David Miller
From: Xin Long Date: Wed, 14 Nov 2018 00:48:28 +0800 > These is no need to hold dst before calling rt6_remove_exception_rt(). > The call to dst_hold_safe() in ip6_link_failure() was for ip6_del_rt(), > which has been removed in Commit 93531c674315 ("net/ipv6: separate > handling of FIB entries

Re: [PATCH bpf-next v2 0/3] bpf: Support socket lookup in CGROUP_SOCK_ADDR progs

2018-11-16 Thread Alexei Starovoitov
On Fri, Nov 9, 2018 at 6:54 PM Andrey Ignatov wrote: > > This patch set makes bpf_sk_lookup_tcp, bpf_sk_lookup_udp and > bpf_sk_release helpers available in programs of type > BPF_PROG_TYPE_CGROUP_SOCK_ADDR. > > Patch 1 is a fix for bpf_sk_lookup_udp that was already merged to bpf > (stable)

Re: [PATCH v3] net: Add trace events for all receive exit points

2018-11-16 Thread David Miller
From: Geneviève Bastien Date: Tue, 13 Nov 2018 15:13:26 -0500 > @@ -5222,9 +5228,14 @@ static void netif_receive_skb_list_internal(struct > list_head *head) > */ > int netif_receive_skb(struct sk_buff *skb) > { > + int ret; > + > trace_netif_receive_skb_entry(skb); > > -

Re: [patch net-next] net: 8021q: move vlan offload registrations into vlan_core

2018-11-16 Thread David Miller
From: Jiri Pirko Date: Tue, 13 Nov 2018 23:22:48 +0100 > From: Jiri Pirko > > Currently, the vlan packet offloads are registered only upon 8021q module > load. However, even without this module loaded, the offloads could be > utilized, for example by openvswitch datapath. As reported by

[next-queue PATCH v1 2/2] Documentation: igb: Add a section about CBS

2018-11-16 Thread Vinicius Costa Gomes
Add some pointers to the definition of the CBS algorithm, and some notes about the limits of its implementation in the i210 family of controllers. Signed-off-by: Vinicius Costa Gomes --- Documentation/networking/igb.rst | 19 +++ 1 file changed, 19 insertions(+) diff --git

[next-queue PATCH v1 1/2] igb: Change RXPBSIZE size when setting Qav mode

2018-11-16 Thread Vinicius Costa Gomes
From: Jesus Sanchez-Palencia Section 4.5.9 of the datasheet says that the total size of all packet buffers combined (TxPB 0 + 1 + 2 + 3 + RxPB + BMC2OS + OS2BMC) must not exceed 60KB. Today we are configuring a total of 62KB, so reduce the RxPB from 32KB to 30KB in order to respect that. The

Re: [PATCH bpf-next] bpf: libbpf: Fix bpf_program__next() API

2018-11-16 Thread Alexei Starovoitov
On Mon, Nov 12, 2018 at 03:44:53PM -0800, Martin KaFai Lau wrote: > This patch restores the behavior in > commit eac7d84519a3 ("tools: libbpf: don't return '.text' as a program for > multi-function programs") > such that bpf_program__next() does not return pseudo programs in ".text". > > Fixes:

Re: [Patch net-next] net: remove unused skb_send_sock()

2018-11-16 Thread David Miller
From: Cong Wang Date: Mon, 12 Nov 2018 18:05:24 -0800 > Signed-off-by: Cong Wang Applied.

Re: Linux kernel hangs if using RV1108 with MSZ8863 switch with two ports connected

2018-11-16 Thread Andrew Lunn
On Fri, Nov 16, 2018 at 04:28:29PM -0200, Otavio Salvador wrote: > Hi, > > I have a custom design based on Rockchip RV1108 that uses an MSZ8863 > switch running kernel 4.19. > > The dts part is as follows: > > { > pinctrl-names = "default"; > pinctrl-0 = <_pins>; > snps,reset-gpio = < RK_PC1

Re: [PATCH net] net/sched: act_pedit: fix memory leak when IDR allocation fails

2018-11-16 Thread David Miller
From: Davide Caratti Date: Wed, 14 Nov 2018 12:17:25 +0100 > tcf_idr_check_alloc() can return a negative value, on allocation failures > (-ENOMEM) or IDR exhaustion (-ENOSPC): don't leak keys_ex in these cases. > > Fixes: 0190c1d452a9 ("net: sched: atomically check-allocate action") >

[PATCH net-next] net: align gnet_stats_basic_cpu struct

2018-11-16 Thread Eric Dumazet
This structure is small (12 or 16 bytes depending on 64bit or 32bit kernels), but we do not want it spanning two cache lines. Signed-off-by: Eric Dumazet --- include/net/gen_stats.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/gen_stats.h

Re: [RFC v1 2/3] vxlan: add support for underlay in non-default VRF

2018-11-16 Thread David Ahern
On 11/16/18 2:41 AM, Alexis Bauvin wrote: > The case I am trying to cover here is the user creating a VXLAN device with > eth0 > as its lower device (ip link add vxlan0 type vxlan ... dev eth0), thus > ignoring > the fact that it should be br0 (the actual L3 interface). In this case, the > only