Re: [PATCH v5 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

On Thu, Oct 22, 2015 at 11:57 AM, Punit Vara wrote: Hi Punit, > Remove empty line suggested by Sergei > A commit message is here to, in the future, help us all understand what and why this change was made, so you should not include comments about what you changed since a

Re: [PATCH] Bluetooth: hci_smd: Qualcomm WCNSS HCI driver

On Sat 03 Oct 09:55 PDT 2015, Marcel Holtmann wrote: > Hi Bjorn, > [..] > >> Especially the kbuild test robot complained loudly. > >> > > > > Sorry, I forgot to mention in the patch that the patch depends on the > > qcom_smd_id patch - that's available in linux-next. I will take another > >

[PATCH v2 6/7] Bluetooth: Add HCI device identifier for Qualcomm SMD

This patch assigns the next free HCI device identifier to Bluetooth devices based on the Qualcomm Shared Memory channels. Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> --- Changes since v1: - Split out this from the btqcomsmd patch include/net/bluetooth/hci.h | 1 +

Re: [PATCH] Bluetooth: hci_smd: Qualcomm WCNSS HCI driver

On Wed 30 Sep 23:54 PDT 2015, Marcel Holtmann wrote: > Hi Bjorn, > > > The Qualcomm WCNSS chip provides two SMD channels to the BT core; one > > for command and one for event packets. This driver exposes the two > > channels as a hci device. > > [..] > > diff --git a/drivers/bluetooth/Makefile

[PATCH] net: add Qualcomm IPC router

From: Courtney Cavin Add an implementation of Qualcomm's IPC router protocol, used to communicate with service providing remote processors. Signed-off-by: Courtney Cavin --- Downstream this code also includes a large part of a

Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding

On Tue 29 Dec 10:34 PST 2015, Rob Herring wrote: > On Sun, Dec 27, 2015 at 05:34:27PM -0800, Bjorn Andersson wrote: > > Add binding representing the Qualcomm wcn3620/60/80 WiFi block. > > Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> > > --- > >

Re: [PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

On Wed, Dec 30, 2015 at 8:47 AM, Souptick Joarder <jrdr.li...@gmail.com> wrote: > > HI Bjorn, > > On Thu, Dec 24, 2015 at 2:03 PM, Bjorn Andersson <bj...@kryo.se> wrote: > > Make the addr parameter const in SET_IEEE80211_PERM_ADDR() to save > > clients from h

Re: [PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

On Wed, Dec 30, 2015 at 10:30 AM, Souptick Joarder <jrdr.li...@gmail.com> wrote: > On Wed, Dec 30, 2015 at 10:35 PM, Bjorn Andersson <bj...@kryo.se> wrote: >> On Wed, Dec 30, 2015 at 8:47 AM, Souptick Joarder <jrdr.li...@gmail.com> >> wrote: >>> >>

[PATCH 3/4] wcn36xx: Transition driver to SMD client

The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> --- drivers/net/wirele

[PATCH 0/4] WCN36xx convert to mainline SMD interface

during boot of the WCNSS core. This is being worked on separately. [1] https://lkml.org/lkml/2015/12/27/185 Bjorn Andersson (4): wcn36xx: Fold indication payload into message header wcn36xx: Change indication list lock to spinlock wcn36xx: Transition driver to SMD client dt: binding: Add

[PATCH 2/4] wcn36xx: Change indication list lock to spinlock

In preparation for handling incoming messages from IRQ context, change the indication list lock to a spinlock Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> --- drivers/net/wireless/ath/wcn36xx/smd.c | 12 ++-- drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 2

[PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding

Add binding representing the Qualcomm wcn3620/60/80 WiFi block. Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> --- .../bindings/net/wireless/qcom,wcn36xx-wifi.txt| 76 ++ 1 file changed, 76 insertions(+) create mode 100644 Documentation/devi

[PATCH 1/4] wcn36xx: Fold indication payload into message header

Merge the two allocation instead of separately allocating room for the indication payload. Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> --- drivers/net/wireless/ath/wcn36xx/smd.c | 15 ++- drivers/net/wireless/ath/wcn36xx/smd.h | 2 +- 2 files chan

Re: [PATCH 2/4] wcn36xx: Change indication list lock to spinlock

On Mon 28 Dec 15:06 PST 2015, Stephen Hemminger wrote: > On Sun, 27 Dec 2015 17:34:25 -0800 > Bjorn Andersson <bj...@kryo.se> wrote: > > > In preparation for handling incoming messages from IRQ context, change > > the indication list lock to a spinlock > > &

[PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

Make the addr parameter const in SET_IEEE80211_PERM_ADDR() to save clients from having to cast away a const qualifier. Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> --- include/net/mac80211.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inclu

[PATCH 3/6] wcn36xx: Split mmio space into explicit regions

Split the wcnss mmio space into explicit regions for ccu and dxe and acquire these from the node referenced by the qcom,mmio phandle. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/dxe.c | 26 --- drivers/net/wireless/ath/w

[PATCH 5/6] wcn36xx: Transition driver to SMD client

The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- This patch d

[PATCH 4/6] wcn36xx: Correct DXE chip version differentiation

The CCU block in WCNSS is configured for appropriate routing of interrupts from the DXE to the application cpu, this is not dependant on the iris version (wcn3660 vs wcn3680), but rather if the SoC has a riva or pronto built in. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.

[PATCH 1/6] wcn36xx: Fold indication payload into message header

From: Bjorn Andersson <bjorn.anders...@sonymobile.com> Merge the two allocation instead of separately allocating room for the indication payload. Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- dr

[PATCH 2/6] wcn36xx: Change indication list lock to spinlock

From: Bjorn Andersson <bjorn.anders...@sonymobile.com> In preparation for handling incoming messages from IRQ context, change the indication list lock to a spinlock Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> Signed-off-by: Bjorn Andersson <bjorn.ander

[PATCH 6/6] wcn36xx: Fix up wcn36xx_smd_update_scan_params()

Fix up the wcn36xx_smd_update_scan_params() to work with non-ancient versions of the firmware and support actually specifying the list of channels. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 4 ++-- drivers/net/wireless/ath/w

Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding

On Tue, Dec 29, 2015 at 11:03 AM, Bjorn Andersson <bj...@kryo.se> wrote: > On Tue 29 Dec 10:34 PST 2015, Rob Herring wrote: > >> On Sun, Dec 27, 2015 at 05:34:27PM -0800, Bjorn Andersson wrote: >> > Add binding representing the Qualcomm wcn3620/60/80 WiFi block. >>

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

On Fri, Apr 8, 2016 at 12:06 PM, Timur Tabi wrote: > Andrew Lunn wrote: > >> There are two different things here. One is configuring the pin to be >> a GPIO. The second is using the GPIO as a GPIO. In this case, >> bit-banging the MDIO bus. >> >> The firmware could be doing

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

On Fri 08 Apr 16:01 PDT 2016, Timur Tabi wrote: > Bjorn Andersson wrote: > > >It sounds like you're trying to say that the pins used can be are > >muxed as GPIO or MDIO, in the TLMM. > > I'm not 100% sure, but I think that's correct. If you don't want to have > n

[PATCH v2 15/15] wcn36xx: Use correct command struct for EXIT_BMPS_REQ

From: Pontus Fuchs <pontus.fu...@gmail.com> EXIT_BMPS_REQ was using the command struct for ENTER_BMPS_REQ. I spotted this when looking at command dumps. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- driver

[PATCH v2 13/15] wcn36xx: Track association state

From: Pontus Fuchs <pontus.fu...@gmail.com> Knowing the association state is needed for mc filtering. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 2 ++ driver

[PATCH v2 08/15] wcn36xx: Remove sta pointer in private vif struct

From: Pontus Fuchs <pontus.fu...@gmail.com> This does not work with multiple sta's in a vif. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 3 --- drivers/net/wi

[PATCH v2 14/15] wcn36xx: Implement multicast filtering

OMISC_IN_BSS usage] Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 6 ++-- drivers/net/wireless/ath/wcn36xx/main.c | 50 ++-- drivers/net/wireless/ath/wcn36xx/smd.c | 51

[PATCH v2 12/15] wcn36xx: Clear encrypt_type when deleting bss key

From: Pontus Fuchs <pontus.fu...@gmail.com> This fixes a problem connecting to an open network after being connected to an encrypted network. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wi

[PATCH v2 10/15] wcn36xx: Copy all members in config_sta v1 conversion

From: Pontus Fuchs <pontus.fu...@gmail.com> When converting to version 1 of the config_sta struct not all members where copied. This fixes the problem of multicast frames not being delivered on an encrypted network. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-o

[PATCH v2 03/15] wcn36xx: Add helper macros to cast vif to private vif and vice versa

From: Pontus Fuchs <pontus.fu...@gmail.com> Makes the code a little easier to read. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/debug.c | 12 +++- drivers/net/wi

[PATCH v2 06/15] wcn36xx: Add helper macros to cast sta to priv

; Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 14 ++ drivers/net/wireless/ath/wcn36xx/smd.c | 12 ++-- drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 6 ++ 3 files changed, 18 insertions(+), 14 deleti

[PATCH v2 04/15] wcn36xx: Use consistent name for private vif

From: Pontus Fuchs <pontus.fu...@gmail.com> Some code used priv_vif and some used vif_priv. Convert all to vif_priv for consistency. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/

[PATCH v2 01/15] wcn36xx: Clean up wcn36xx_smd_send_beacon

From: Pontus Fuchs <pontus.fu...@gmail.com> Needed for coming improvements. No functional changes. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 7 +-- driver

[PATCH v2 02/15] wcn36xx: Pad TIM PVM if needed

d-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Jason Mobarak <j...@cozybit.com> [bjorn: squashed in Jason's fixup] Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 3 +++ drivers/net/wireless/ath/wcn36xx/smd.c |

[PATCH v2 11/15] wcn36xx: Use allocated self sta index instead of hard coded

From: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/smd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH v2 07/15] wcn36xx: Fetch private sta data from sta entry instead of from vif

From: Pontus Fuchs <pontus.fu...@gmail.com> For consistency with other code. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 09/15] wcn36xx: Parse trigger_ba response properly

From: Pontus Fuchs <pontus.fu...@gmail.com> This message does not follow the canonical format and needs it's own parser. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/

[PATCH v2 05/15] wcn36xx: Use define for invalid index and fix typo

From: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 2 +- drivers/net/wireless/ath/wcn36xx/main.c | 4 ++-- drivers/net/wi

[PATCH 09/16] wcn36xx: Parse trigger_ba response properly

From: Pontus Fuchs <pontus.fu...@gmail.com> This message does not follow the canonical format and needs it's own parser. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/

[PATCH 08/16] wcn36xx: Remove sta pointer in private vif struct

From: Pontus Fuchs <pontus.fu...@gmail.com> This does not work with multiple sta's in a vif. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 3 --- drivers/net/wi

[PATCH 10/16] wcn36xx: Copy all members in config_sta v1 conversion

From: Pontus Fuchs <pontus.fu...@gmail.com> When converting to version 1 of the config_sta struct not all members where copied. This fixes the problem of multicast frames not being delivered on an encrypted network. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-o

[PATCH 14/16] wcn36xx: Implement multicast filtering

OMISC_IN_BSS usage] Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 6 ++-- drivers/net/wireless/ath/wcn36xx/main.c | 50 ++-- drivers/net/wi

[PATCH 11/16] wcn36xx: Use allocated self sta index instead of hard coded

From: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/smd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

From: Pontus Fuchs <pontus.fu...@gmail.com> For consistency with other code. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 05/16] wcn36xx: Use define for invalid index and fix typo

From: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 2 +- drivers/net/wireless/ath/wcn36xx/main.c | 4 ++-- drivers/net/wi

[PATCH 04/16] wcn36xx: Use consistent name for private vif

From: Pontus Fuchs <pontus.fu...@gmail.com> Some code used priv_vif and some used vif_priv. Convert all to vif_priv for consistency. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/

[PATCH 00/16] Misc wcn36xx fixes

As I was debugging some issues with the wcn36xx driver I found a series of patches that exists in Eugene's github tree but not in mainline. Noteworthy is the long requested feature of having working ARP support. Please apply these rebased and relocated patches. Jason Mobarak (1): wcn36xx:

[PATCH 03/16] wcn36xx: Add helper macros to cast vif to private vif and vice versa

From: Pontus Fuchs <pontus.fu...@gmail.com> Makes the code a little easier to read. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/debug.c | 12 +++- drivers/net/wi

[PATCH 01/16] wcn36xx: Clean up wcn36xx_smd_send_beacon

From: Pontus Fuchs <pontus.fu...@gmail.com> Needed for coming improvements. No functional changes. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 7 +-- driver

[PATCH 02/16] wcn36xx: Pad TIM PVM if needed

From: Pontus Fuchs <pontus.fu...@gmail.com> The wcn36xx FW expects a fixed size TIM PVM in the beacon template. If supplied with a shorter than expected PVM it will overwrite the IE following the TIM. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjo

Re: [PATCH 3/4] wcn36xx: Transition driver to SMD client

this depends on changes to the wcnss_ctrl driver, which are being reviewed right now. Regards, Bjorn > 2015-12-28 1:34 GMT+00:00 Bjorn Andersson <bj...@kryo.se>: >> The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD >> channel, as such it should be a SMD client. Th

[PATCH 16/16] wcn36xx: Use correct command struct for EXIT_BMPS_REQ

From: Pontus Fuchs <pontus.fu...@gmail.com> EXIT_BMPS_REQ was using the command struct for ENTER_BMPS_REQ. I spotted this when looking at command dumps. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- driver

[PATCH 15/16] wcn36xx: don't pad beacons for mesh

dy.beacon_length is incorrectly calculated for mesh mode. Fix this. Signed-off-by: Jason Mobarak <j...@cozybit.com> Signed-off-by: Chun-Yeow Yeoh <yeohchuny...@cozybit.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/smd.c | 5 +

[PATCH 12/16] wcn36xx: Clear encrypt_type when deleting bss key

From: Pontus Fuchs <pontus.fu...@gmail.com> This fixes a problem connecting to an open network after being connected to an encrypted network. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wi

[PATCH 13/16] wcn36xx: Track association state

From: Pontus Fuchs <pontus.fu...@gmail.com> Knowing the association state is needed for mc filtering. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 2 ++ driver

[RESEND PATCH 15/16] wcn36xx: don't pad beacons for mesh

dy.beacon_length is incorrectly calculated for mesh mode. Fix this. Fixes: 8ad99a4e3ee5 ("wcn36xx: Pad TIM PVM if needed") Signed-off-by: Jason Mobarak <j...@cozybit.com> Signed-off-by: Chun-Yeow Yeoh <yeohchuny...@cozybit.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@

Re: [RESEND PATCH 15/16] wcn36xx: don't pad beacons for mesh

On Tue 29 Mar 14:41 PDT 2016, Bjorn Andersson wrote: > From: Jason Mobarak <j...@cozybit.com> > > Patch "wcn36xx: Pad TIM PVM if needed" has caused a regression in mesh > beaconing. The field tim_off is always 0 for mesh mode, and thus > pvm_len (referring t

Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

e system] > > url: > https://github.com/0day-ci/linux/commits/Bjorn-Andersson/Misc-wcn36xx-fixes/20160329-141847 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git > master > config: sparc64-allyesconfig (attached as .config) > reproduce

[PATCH] wcn36xx: Set SMD timeout to 10 seconds

seconds for the communication layer. By extending the wcn36xx timeout to match this we follows the same flow for the boot procedure and can successfully configure WiFi as wlan0 is registered. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/smd

Re: [PATCH v2] net: Add Qualcomm IPC router

On Wed 27 Apr 09:22 PDT 2016, David Miller wrote: > From: Bjorn Andersson <bjorn.anders...@linaro.org> > Date: Tue, 26 Apr 2016 22:48:05 -0700 > > > + rc = qcom_smd_send(qdev->channel, skb->data, skb->len); > > I truly dislike adding networking pro

[PATCH v3 1/2] soc: qcom: smd: Introduce compile stubs

Introduce compile stubs for the SMD API, allowing consumers to be compile tested. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v2: - Introduce this patch, to allow compile testing of QRTR_SMD include/linux/soc/qcom/smd.h | 28 +

[PATCH v3 2/2] net: Add Qualcomm IPC router

From: Courtney Cavin <courtney.ca...@sonymobile.com> Add an implementation of Qualcomm's IPC router protocol, used to communicate with service providing remote processors. Signed-off-by: Courtney Cavin <courtney.ca...@sonymobile.com> Signed-off-by: Bjorn Andersson <bjorn.anders...

[PATCH v2] net: Add Qualcomm IPC router

From: Courtney Cavin <courtney.ca...@sonymobile.com> Add an implementation of Qualcomm's IPC router protocol, used to communicate with service providing remote processors. Signed-off-by: Courtney Cavin <courtney.ca...@sonymobile.com> Signed-off-by: Bjorn Andersson <bjorn.anders...

Re: QRTR merge conflict resolution

On Tue 17 May 17:43 PDT 2016, Stephen Rothwell wrote: > Hi David, > > On Tue, 17 May 2016 14:11:54 -0400 (EDT) David Miller <da...@davemloft.net> > wrote: > > > > From: Bjorn Andersson <bjorn.anders...@linaro.org> > > Date: Fri, 13 May 2016 15:19:09

Re: linux-next: build failure after merge of the net-next tree

second pull request towards arm-soc and thought the SMD changes missed this cycle. Your patch looks good, but I'm not sure how we should approach the merge window; Andy can't pick the patch because he doesn't have the qrtr code and David doesn't have the SMD patches coming through Andy. FWIW,

[RFC] wcn36xx: Implement firmware assisted scan

Using the software based channel scan mechanism from mac80211 keeps us offline for 10-15 second, we should instead issue a start_scan/end_scan on each channel reducing this time. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- With this implementation I see a red

QRTR merge conflict resolution (was: Re: linux-next: build failure after merge of the net-next tree)

On Fri 13 May 14:01 PDT 2016, Arnd Bergmann wrote: > On Tuesday 10 May 2016 11:39:34 Bjorn Andersson wrote: [..] > > I assume we could have the QRTR go through Andy and arm-soc, with > > David's approval and this fix squashed in. But we're running rather late > > in this cyc

[PATCH v4 2/2] net: Add Qualcomm IPC router

From: Courtney Cavin <courtney.ca...@sonymobile.com> Add an implementation of Qualcomm's IPC router protocol, used to communicate with service providing remote processors. Signed-off-by: Courtney Cavin <courtney.ca...@sonymobile.com> Signed-off-by: Bjorn Andersson <bjorn.anders...

[PATCH v4 1/2] soc: qcom: smd: Introduce compile stubs

Introduce compile stubs for the SMD API, allowing consumers to be compile tested. Acked-by: Andy Gross <andy.gr...@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v3: - None Changes since v2: - Introduce this patch, to allow compile testing

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

On Thu 14 Apr 16:34 PDT 2016, Timur Tabi wrote: [..] > So I think the solution is to create a device tree (and ACPI) property that > holds the mask. > > dma-mask = <0 0x>; > > or > > dma-mask = <0x 0x>; > > The driver will then do this: > > u64

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

On Fri 15 Apr 10:00 PDT 2016, Timur Tabi wrote: > Bjorn Andersson wrote: > >For platform devices being populated via from DT you will pass: > >of_platform_bus_create() > > of_platform_device_create_pdata() > > of_dma_configure() > > > >Wh

[PATCH v3 07/18] wcn36xx: Fetch private sta data from sta entry instead of from vif

From: Pontus Fuchs <pontus.fu...@gmail.com> For consistency with other code. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v1: - Reordered after the now previous patch, to make wcn36xx_sta_to_

[PATCH v3 13/18] wcn36xx: Track association state

From: Pontus Fuchs <pontus.fu...@gmail.com> Knowing the association state is needed for mc filtering. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 2 ++ driver

[PATCH v3 09/18] wcn36xx: Parse trigger_ba response properly

From: Pontus Fuchs <pontus.fu...@gmail.com> This message does not follow the canonical format and needs it's own parser. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/

[PATCH v3 15/18] wcn36xx: Use correct command struct for EXIT_BMPS_REQ

From: Pontus Fuchs <pontus.fu...@gmail.com> EXIT_BMPS_REQ was using the command struct for ENTER_BMPS_REQ. I spotted this when looking at command dumps. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- driver

[PATCH v3 14/18] wcn36xx: Implement multicast filtering

OMISC_IN_BSS usage] Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 6 ++-- drivers/net/wireless/ath/wcn36xx/main.c | 50 ++-- drivers/net/wireless/ath/wcn36xx/smd.c | 51

[PATCH v3 11/18] wcn36xx: Use allocated self sta index instead of hard coded

From: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/smd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH v3 18/18] wcn36xx: Fill in capability list

Fill in the capability list with more values from the downstream driver. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v2: - Added this patch to the series drivers/net/wireless/ath/wcn36xx/hal.h | 39 drivers/net/wirele

[PATCH v3 16/18] wcn36xx: Delete BSS before idling link

When disabling the beacon we must delete the bss before idling the link. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v2: - Added this patch to the series drivers/net/wireless/ath/wcn36xx/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3 17/18] wcn36xx: Correct remove bss key response encoding

The WCN36XX_HAL_RMV_BSSKEY_RSP carries a single u32 with "status", so we can use the standard status check function for decoding the result. This is the last user of the v2 status checker, so remove the struct and helper function. Signed-off-by: Bjorn Andersson <bjorn.anders.

[PATCH v3 04/18] wcn36xx: Use consistent name for private vif

From: Pontus Fuchs <pontus.fu...@gmail.com> Some code used priv_vif and some used vif_priv. Convert all to vif_priv for consistency. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/

[PATCH v3 10/18] wcn36xx: Copy all members in config_sta v1 conversion

From: Pontus Fuchs <pontus.fu...@gmail.com> When converting to version 1 of the config_sta struct not all members where copied. This fixes the problem of multicast frames not being delivered on an encrypted network. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-o

[PATCH v3 12/18] wcn36xx: Clear encrypt_type when deleting bss key

From: Pontus Fuchs <pontus.fu...@gmail.com> This fixes a problem connecting to an open network after being connected to an encrypted network. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wi

[PATCH v3 02/18] wcn36xx: Pad TIM PVM if needed

d-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Jason Mobarak <j...@cozybit.com> [bjorn: squashed in Jason's fixup] Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v1: - Merged in Jason's patch for skipping the padding in mesh mode. dri

[PATCH v3 05/18] wcn36xx: Use define for invalid index and fix typo

From: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 2 +- drivers/net/wireless/ath/wcn36xx/main.c | 4 ++-- drivers/net/wi

[PATCH v3 00/18] wcn36xx fixes

rect WCN36XX_HAL_RMV_BSSKEY_RSP decoder - Added patch with missing capabilities from downstream Changes since v1: - Reorder patch 6 and 7 to not break the build temporarily - Inline fix from Jason Mobarak in the TIM PVM padding Bjorn Andersson (3): wcn36xx: Delete BSS before idling link wcn36xx: Cor

[PATCH v3 01/18] wcn36xx: Clean up wcn36xx_smd_send_beacon

From: Pontus Fuchs <pontus.fu...@gmail.com> Needed for coming improvements. No functional changes. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> [bjorn: restored BEACON_TEMPLATE_SIZE define to 0x180] Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> ---

[PATCH v3 03/18] wcn36xx: Add helper macros to cast vif to private vif and vice versa

From: Pontus Fuchs <pontus.fu...@gmail.com> Makes the code a little easier to read. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/debug.c | 12 +++- drivers/net/wi

[PATCH v3 08/18] wcn36xx: Remove sta pointer in private vif struct

From: Pontus Fuchs <pontus.fu...@gmail.com> This does not work with multiple sta's in a vif. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 3 --- drivers/net/wi

[PATCH v3 06/18] wcn36xx: Add helper macros to cast sta to priv

; Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 14 ++ drivers/net/wireless/ath/wcn36xx/smd.c | 12 ++-- drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 6 ++ 3 files changed, 18 insertions(+), 14 deleti

Re: [PATCH v2 01/15] wcn36xx: Clean up wcn36xx_smd_send_beacon

On Sun 03 Apr 15:16 PDT 2016, Bjorn Andersson wrote: > From: Pontus Fuchs <pontus.fu...@gmail.com> > > Needed for coming improvements. No functional changes. > Kalle, Eugene, Have you picked up these patches yet? As I was debugging a firmware crash when tryi

[PATCH v2 1/2] wcn36xx: Transition driver to SMD client

The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Res

[PATCH v2 2/2] wcn36xx: Implement firmware assisted scan

Using the software based channel scan mechanism from mac80211 keeps us offline for 10-15 second, we should instead issue a start_scan/end_scan on each channel reducing this time. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- It's been a while since I posted this as an

[PATCH] wcn36xx: Silence error about unsupported smd event 188

Sometimes the firmware sends a HAL_DEL_BA_IND, the prima driver silently ignore this message so let's do the same to silence the error message. Cc: Nicolas Dechesne <nicolas.deche...@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless

[PATCH] wcn36xx: Implement print_reg indication

Some firmware versions sends a "print register indication", handle this by printing out the content. Cc: Nicolas Dechesne <n...@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 16 dr

[PATCH] wcn36xx: Implement cancel_hw_scan

In the even that the wcn36xx interface is brought down while a hw_scan is active we must abort and wait for the ongoing scan to signal completion to mac80211. Reported-by: Mart Raudsepp <l...@gentoo.org> Fixes: 886039036c20 ("wcn36xx: Implement firmware assisted scan") Sign

Re: [PATCH v3 1/2] wcn36xx: Transition driver to SMD client

On Fri 02 Sep 09:24 PDT 2016, Kalle Valo wrote: > Bjorn Andersson <bjorn.anders...@linaro.org> writes: > > > The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD > > channel, as such it should be a SMD client. This patch makes this > > transition,

[PATCH v4 4/4] wcn36xx: Implement print_reg indication

Some firmware versions sends a "print register indication", handle this by printing out the content. Cc: Nicolas Dechesne <n...@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v3: - Rebased separate patch onto this series dr

[PATCH v4 2/4] wcn36xx: Transition driver to SMD client

The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v3:

  1   2   >