RE: [PATCH 3/7] sh_eth: offload RX checksum on R7S72100

2019-01-29 Thread Chris Brandt
On Tuesday, January 29, 2019, Sergei Shtylyov wrote: > On 01/29/2019 11:00 AM, Simon Horman wrote: > > As you may have guessed the implication of my question is that > > IMHO it would be best only to add this feature to SoCs where > > it has been tested. > >You don't trust the manuals? :-) >

[PATCH] net: ethernet: renesas: sh_eth: do not access POST registers if not exist

2016-08-26 Thread Chris Brandt
: Chris Brandt --- drivers/net/ethernet/renesas/sh_eth.c | 7 +++ drivers/net/ethernet/renesas/sh_eth.h | 1 + 2 files changed, 8 insertions(+) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 1f8240a..850a13c 100644 --- a/drivers/net/ethernet

RE: [PATCH] net: ethernet: renesas: sh_eth: do not access POST registers if not exist

2016-08-29 Thread Chris Brandt
On 08/28/2016, Sergei Shtylyov wrote: >> The RZ/A1 has a TSU, but since it only has one Ethernet port, it does >> not have POST registers. > >I'm not sure the reason is having one port... do you have the old SH > manuals somewhere? :-) Yes, I used to support the SH7757. It had dual ETHER an

RE: [PATCH] net: ethernet: renesas: sh_eth: do not access POST registers if not exist

2016-08-30 Thread Chris Brandt
Hello Sergei, On Aug 29, 2016, Sergei Shtylyov wrote: >SH7757 is not the only platform with TSU, there's e.g. R8A7740 ARM > SoC which only has 1 GETHER channel... I don't have the R8A7740 manual (R-Mobile A1) so I can't see. But even if it does not have the POST registers, it might not hurt

[PATCH v2] net: ethernet: renesas: sh_eth: add POST registers for rz

2016-09-07 Thread Chris Brandt
can cause a memory corruption or panic. This patch fixes the panic and properly enables CAM. Reported-by: Daniel Palmer Signed-off-by: Chris Brandt --- v2: * POST registers really do exist, so just add them --- drivers/net/ethernet/renesas/sh_eth.c | 7 +++ 1 file changed, 7 insertions

RE: [PATCH] net: ethernet: renesas: sh_eth: do not access POST registers if not exist

2016-09-08 Thread Chris Brandt
As a follow up on this thread: On 8/30/2016, Geert Uytterhoeven wrote: > > I just looked at the RZ/A1 register space and there seems to be dummy > > registers in the POST1-4 area. I can write to them and read back what I > > wrote...which is all that the sh_eth driver cares about. I bet when the

RE: [PATCH v2] net: ethernet: renesas: sh_eth: add POST registers for rz

2016-09-09 Thread Chris Brandt
On 9/9/2016, Sergei Shtylyov wrote: > > sh_eth_private *mdp) { > > if (sh_eth_is_rz_fast_ether(mdp)) { > > sh_eth_tsu_write(mdp, 0, TSU_TEN); /* Disable all CAM entry */ > > + sh_eth_tsu_write(mdp, TSU_FWSLC_POSTENU | TSU_FWSLC_POSTENL, > > +TS

[PATCH] sh_eth: add missing checks for status bits

2016-11-30 Thread Chris Brandt
ption) handlers: [] sh_eth_interrupt Disabling IRQ #21 Fixes: db893473d313a4ad ("sh_eth: Add support for r7s72100") Signed-off-by: Chris Brandt --- drivers/net/ethernet/renesas/sh_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/renesa

RE: [PATCH] sh_eth: add missing checks for status bits

2016-12-01 Thread Chris Brandt
On 12/1/2016, Sergei Shtylyov wrote: > Hello! > > Please always CC me on the sh_eth/ravb driver patches as directed by > scripts/get_maintainer.pl. OK. I'm sorry. > On 11/30/2016 11:01 PM, Chris Brandt wrote: > > > When streaming a lot of data and the

[PATCH v2] sh_eth: remove unchecked interrupts

2016-12-01 Thread Chris Brandt
ption) handlers: [] sh_eth_interrupt Disabling IRQ #21 Fixes: db893473d313a4ad ("sh_eth: Add support for r7s72100") Signed-off-by: Chris Brandt --- v2: * switched from modifying eesr_err_check to modifying eesipr_value --- drivers/net/ethernet/renesas/sh_eth.c | 2 +- 1 file changed, 1

RE: [PATCH v2] sh_eth: remove unchecked interrupts

2016-12-01 Thread Chris Brandt
On 12/1/2016, Sergei Shtylyov wrote: > One thing you've missed so far is mentioning R7S72100 (RZ/A1) in the > subject. This driver supports many SoCs, you're only fixing one of them... For the last sh_eth.c patch I submitted, I had: "net: ethernet: renesas: sh_eth: add POST registers for rz"

[PATCH v3] sh_eth: remove unchecked interrupts for RZ/A1

2016-12-01 Thread Chris Brandt
ll" option) handlers: [] sh_eth_interrupt Disabling IRQ #21 Fixes: db893473d313a4ad ("sh_eth: Add support for r7s72100") Signed-off-by: Chris Brandt Acked-by: Sergei Shtylyov --- v3: * add RZ/A1 to subject line v2: * switched from modifying eesr_err_check to modifying eesipr_value

RE: [PATCH v2] sh_eth: remove unchecked interrupts

2016-12-01 Thread Chris Brandt
Hi Geert, On 12/1/2016, Sergei Shtylyov wrote: > > On 12/01/2016 05:42 PM, Geert Uytterhoeven wrote: > > >> --- a/drivers/net/ethernet/renesas/sh_eth.c > >> +++ b/drivers/net/ethernet/renesas/sh_eth.c > >> @@ -518,7 +518,7 @@ static struct sh_eth_cpu_data r7s72100_data = { > >> > >> .ecs