Re: [patch 04/13] ppp_generic: fix lockdep warning

2007-05-11 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Fri, 11 May 2007 16:57:19 -0400 applied I was under the impression that this patch didn't actually fix the problem yet? I might be thinking about something else... - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [IPSEC]: Don't warn if high-order hash resize fails

2007-05-14 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Mon, 14 May 2007 15:48:37 +1000 Hi Dave: I just got this when rekeying my VPN (2.6.21.1): events/0: page allocation failure. order:7, mode:0xd0 [c0146235] __alloc_pages+0x1e5/0x2e0 [c0146356] __get_free_pages+0x26/0x50 [c02a01ef]

Re: [patch 04/13] ppp_generic: fix lockdep warning

2007-05-14 Thread David Miller
From: Jarek Poplawski [EMAIL PROTECTED] Date: Mon, 14 May 2007 08:07:00 +0200 After sending this patch I was a little confused, when next lockdep warning report appeared, and I thought - since this is not enough, this patch could be dumped. But now I changed my mind: there are really many

Re: [IPSEC]: Don't warn if high-order hash resize fails

2007-05-14 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Mon, 14 May 2007 17:39:41 +1000 [IPSEC]: Check validity of direction in xfrm_policy_byid The function xfrm_policy_byid takes a dir argument but finds the policy using the index instead. We only use the dir argument to update the policy count for

Re: [patch 04/13] ppp_generic: fix lockdep warning

2007-05-14 Thread David Miller
From: Jarek Poplawski [EMAIL PROTECTED] Date: Mon, 14 May 2007 09:28:45 +0200 Yes, this is very good idea, and I wonder, why you didn't try this yourself (after my ignore). Because you are a skilled programmer and you might find some flaw in my suggestion :-) - To unsubscribe from this list:

Re: [PATCH 1/1] Reverse sense of promisc tests in ip6_mc_input

2007-05-14 Thread David Miller
From: David Stevens [EMAIL PROTECTED] Date: Sat, 12 May 2007 17:21:10 -0700 Your patch looks correct to me. +-DLS Signed-off-by: David L Stevens [EMAIL PROTECTED] Patch applied, thanks Corey and David for reviewing. I'll push this to -stable too. - To unsubscribe

Re: [PATCH] improved locking performance in rt_run_flush()

2007-05-14 Thread David Miller
From: Dave Johnson [EMAIL PROTECTED] Date: Sat, 12 May 2007 12:36:47 -0400 While testing adding/deleting large numbers of interfaces, I found rt_run_flush() was the #1 cpu user in a kernel profile by far. The below patch changes rt_run_flush() to only take each spinlock protecting the

Re: [PATCH 6/6] [IPV4] SNMP: Display new statistics at /proc/net/snmp

2007-05-14 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] Date: Sat, 12 May 2007 01:19:49 +0900 (JST) In article [EMAIL PROTECTED] (at Sat, 12 May 2007 01:10:04 +0900), Mitsuru Chinen [EMAIL PROTECTED] says: [IPV4] SNMP: Display new statistics at /proc/net/netstat This displays the statistics

Re: [Oops] unix_dgram_connect locking problem?

2007-05-14 Thread David Miller
From: Frederik Deweerdt [EMAIL PROTECTED] Date: Fri, 11 May 2007 17:00:14 +0200 I think that not unix_state_rlock'ing other in unix_dgram_connect may cause it to become NULL while passing it to selinux_socket_unix_may_send. With the following patch applied, I've seen no oops so far (1-2 hours

Re: [IPV4] LVS: Allow to send ICMP unreachable responses when real-servers are removed

2007-05-14 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 14 May 2007 12:21:34 +0200 This allows any user to send spoofed packets when ip_nonlocal_bind is set, which is a quite big change in behaviour of this option. The TPROXY patches include a similar change, but use a flag in struct flowi that

Re: [RFC] New driver API to speed up small packets xmits

2007-05-15 Thread David Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Tue, 15 May 2007 09:25:28 -0700 I'll have to think about implementing that for IPoIB. One issue I see is if I have, say, 4 free entries in my send queue and skb_gso_segment() gives me back 5 packets to send. It's not clear I can recover at that

Re: [PATCH] don't put multicasts with mc_ttl=0 on the wire

2007-05-15 Thread David Miller
From: [EMAIL PROTECTED] Date: Tue, 15 May 2007 12:56:02 -0700 A colleague of mine found that multicasts with a ttl of 0 can be sent on the wire. This happens if the sender doesn't belong to the destination multicast group. With the following the multicast ttl is respected whether or not

Re: [RFC] New driver API to speed up small packets xmits

2007-05-15 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Tue, 15 May 2007 15:05:28 -0700 On Tue, 2007-05-15 at 14:08 -0700, Roland Dreier wrote: Well, IPoIB doesn't do netif_wake_queue() until half the device's TX queue is free, so we should get batching. However, I'm not sure that I can count

Re: [RFC] New driver API to speed up small packets xmits

2007-05-15 Thread David Miller
From: Shirley Ma [EMAIL PROTECTED] Date: Tue, 15 May 2007 14:22:57 -0700 I just wonder without TSO support in HW, how much benefit we can get by pushing GSO from interface layer to device layer besides we can do multiple packets in IPoIB. I bet the gain is non-trivial. I'd say about

Re: [RFC] New driver API to speed up small packets xmits

2007-05-15 Thread David Miller
From: Shirley Ma [EMAIL PROTECTED] Date: Tue, 15 May 2007 14:35:13 -0700 I would think it might be better to implement dequeueN in interface xmit which will benefit multiple streams as well not just for large packet. I think it is beneficial to have both, each of them helps with

Re: [RFC] New driver API to speed up small packets xmits

2007-05-15 Thread David Miller
From: Shirley Ma [EMAIL PROTECTED] Date: Tue, 15 May 2007 16:33:22 -0700 That's interesting. So a generic LRO in interface layer will benefit the preformance more, right? Receiving path TCP N times is more expensive than sending, I think. If you look at some of the drivers doing LRO,

Re: [PATCH 1/1] [TIPC]: Fixed erroneous introduction of for_each_netdev

2007-05-15 Thread David Miller
From: Jon Paul Maloy [EMAIL PROTECTED] Date: Tue, 15 May 2007 20:21:14 -0400 Signed-off-by: Jon Paul Maloy [EMAIL PROTECTED] Sorry about that Jon, I thought the new code was correct :-/ - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH (take 2)] netdev: lockdep classes in register_netdevice Re: [patch 04/13] ppp_generic: fix lockdep warning

2007-05-15 Thread David Miller
From: Jarek Poplawski [EMAIL PROTECTED] Date: Wed, 16 May 2007 07:40:00 +0200 After initializing dev-_xmit_lock register_netdevice() sets lockdep class according to dev-type. Idea of this patch - by David Miller. Reported tested by: Yuriy N. Shkandybin [EMAIL PROTECTED] Signed-off

Re: [PATCH (take 2)] netdev: lockdep classes in register_netdevice Re: [patch 04/13] ppp_generic: fix lockdep warning

2007-05-16 Thread David Miller
From: Jarek Poplawski [EMAIL PROTECTED] Date: Wed, 16 May 2007 08:17:32 +0200 BTW - I think some patch on vlan cannot do any harm (at least like this previous of mine - with only ppp considered), and maybe this all could be forgotten. Let's wait to see if any new messages show up. I think

Re: incorrect defines in mii.h

2007-05-16 Thread David Miller
From: Matvejchikov Ilya [EMAIL PROTECTED] Date: Wed, 16 May 2007 11:01:04 +0400 Hi all! The following defines are incorrect (include/linux/mii.h): #define BMSR_100FULL2 0x0200 /* Can do 100BASE-T2 HDX */ #define BMSR_100HALF2 0x0400 /* Can do 100BASE-T2 FDX */ it

Re: [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread David Miller
From: Rick Jones [EMAIL PROTECTED] Date: Wed, 16 May 2007 11:41:15 -0700 Some more of my paranoid questions :) So, if a driver tries to enable MSI and that is unsuccessful (I'll try to avoid using the possibly loaded term fails) shouldn't that show-up _somewhere_? Just how normal is an

Re: [PATCH] [NET_SCHED]make qdisc_restart more readable

2007-05-16 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Wed, 16 May 2007 18:55:04 -0400 On Mon, 2007-14-05 at 09:30 -0400, jamal wrote: Incoporating last comments from Patrick. Dave, I think this is ready to apply - against net-2.6 from this morning. Dave - hold onto this patch - Sridhar Samudrala [EMAIL

Re: 2.6.21-rc7: BUG: sleeping function called from invalid context at net/core/sock.c:1523

2007-05-16 Thread David Miller
From: Jiri Kosina [EMAIL PROTECTED] Date: Thu, 17 May 2007 01:03:55 +0200 (CEST) On Wed, 16 May 2007, Jiri Kosina wrote: since Jiri has a good test case for it, I leave it to him for testing. If he confirms that this fixes the locking issues, then this is Signed-off-by: Marcel

Re: RT patches expose netdev race [was Re: [RFC] [patch 2/2] powerpc 2.6.21-rt1: fix kernel hang and/or panic

2007-05-16 Thread David Miller
From: [EMAIL PROTECTED] (Linas Vepstas) Date: Wed, 16 May 2007 19:18:02 -0500 Hi, On Tue, May 15, 2007 at 08:09:02PM +1000, Benjamin Herrenschmidt wrote: On Tue, 2007-05-15 at 17:47 +0900, Tsutomu OWA wrote: I encountered the following error when doing netperf from other machine to

Re: [PATCH] TCP slow start: comments and cleanup

2007-05-17 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 16 May 2007 14:57:00 -0700 Add more comments to describe our version of tcp_slow_start(). Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied, thanks Stephen. - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: linux-2.6.22-rc1-g7b104bcb build #254 failed in tcp_yeah.c

2007-05-17 Thread David Miller
From: Toralf Förster [EMAIL PROTECTED] Date: Wed, 16 May 2007 22:18:44 +0200 net/built-in.o: In function `tcp_yeah_init': tcp_yeah.c:(.text+0x526f8): undefined reference to `tcp_vegas_init' net/built-in.o: In function `tcp_yeah_pkts_acked': tcp_yeah.c:(.text+0x52756): undefined reference to

Re: linux-2.6.22-rc1-gb2cd6415 build #257 failed in ./net/rxrpc/ar-peer.c

2007-05-17 Thread David Miller
From: Toralf Förster [EMAIL PROTECTED] Date: Thu, 17 May 2007 21:06:24 +0200 Hello, the build with the attached .config failed, make ends with: ... AS arch/i386/lib/semaphore.o CC arch/i386/lib/strstr.o CC arch/i386/lib/usercopy.o AR arch/i386/lib/lib.a

Re: [PATCH] TCP YeAH selects TCP Vegas with Kconfig

2007-05-17 Thread David Miller
From: Brandon Philips [EMAIL PROTECTED] Date: Thu, 17 May 2007 11:54:29 -0700 I tried building TCP YeAH into my kernel with TCP Vegas as a module and the build failed because TCP YeAH depends on Vegas. This patch makes Kconfig aware of the YeAH dependency on Vegas. I fixed this and posted

Re: [IPV4] LVS: Allow to send ICMP unreachable responses when real-servers are removed

2007-05-17 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 17 May 2007 18:40:28 +0200 In any case some better solution than the current one needs to be found, allowing users to send spoofed packets is far worse than using a non-desired source address for ICMP packets. Agreed, but it only occurs if

Re: Correct rp_filter help text.

2007-05-17 Thread David Miller
From: Dave Jones [EMAIL PROTECTED] Date: Thu, 17 May 2007 17:58:19 -0400 As mentioned in http://bugzilla.kernel.org/show_bug.cgi?id=5015 The helptext implies that this is on by default. This may be true on some distros (Fedora/RHEL have it enabled in /etc/sysctl.conf), but the kernel defaults

Re: [PATCH] Fix incorrect prototype for ipxrtr_route_packet()

2007-05-17 Thread David Miller
From: David Woodhouse [EMAIL PROTECTED] Date: Fri, 18 May 2007 09:48:32 +0800 On Thu, 2007-05-17 at 15:27 -0700, Andrew Morton wrote: If only we could find some way in which all callers of a function as well as its definition can see the same declaration? Well, building with --combine

Re: [RFC] netdevice ops

2007-05-17 Thread David Miller
From: Ben Greear [EMAIL PROTECTED] Date: Thu, 17 May 2007 21:23:16 -0700 Vlan code uses several of the methods, so I'm not sure how it will save any memory Feeling particularly dense today? Only one copy of the ops will be needed for all vlan devices: static const struct netdev_ops

Re: [RFC] netdevice ops

2007-05-17 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 17 May 2007 21:07:37 -0700 I want to take all the function pointers of 'struct net_device' and move them to 'struct net_device_ops'. This will save memory for the case of lots of devices, as well as reduce initialization code. Rough plan:

Re: [RFC] netdevice ops

2007-05-17 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Fri, 18 May 2007 00:54:13 -0400 Stephen Hemminger wrote: I want to take all the function pointers of 'struct net_device' and move them to 'struct net_device_ops'. This will save memory for the case of lots of devices, as well as reduce

Re: [IPV4] LVS: Allow to send ICMP unreachable responses when real-servers are removed

2007-05-18 Thread David Miller
From: Julian Anastasov [EMAIL PROTECTED] Date: Fri, 18 May 2007 11:40:54 +0300 (EEST) On Thu, 17 May 2007, Patrick McHardy wrote: In any case some better solution than the current one needs to be found, allowing users to send spoofed packets is far worse than using a non-desired source

Re: [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference

2007-05-19 Thread David Miller
From: Eugene Teo [EMAIL PROTECTED] Date: Sat, 19 May 2007 13:49:11 +0800 Spotted by the Coverity checker. Why am I not surprised :-( There is no bug here, if Coverity warns every single time skb_peek() is used and not tested against NULL, that's a very serious shortcoming of Coverity or what

Re: [PATCH] rfkill: Fix check for correct rfkill allocation

2007-05-19 Thread David Miller
From: Ivo van Doorn [EMAIL PROTECTED] Date: Sat, 19 May 2007 14:08:43 +0200 coverity has spotted a bug in rfkill.c (bug id #1627), in rfkill_allocate() NULL was returns if the kzalloc() works, and deref the NULL pointer if it fails, Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] I really

Re: [PATCH RESEND net-2.6] [TCP] FRTO: Add missing ECN CWR sending to one of the responses

2007-05-19 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Fri, 18 May 2007 12:15:21 +0300 (EEST) The conservative spurious RTO response did not queue CWR even though the sending rate was lowered. Whenever reduction happens regardless of reason, CWR should be sent (forgetting to send it is not very fatal

Re: [PATCH net-2.6 2/2] [TCP] FRTO: Prevent state inconsistency in corner cases

2007-05-19 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Fri, 18 May 2007 12:17:44 +0300 (EEST) State could become inconsistent in two cases: 1) Userspace disabled FRTO by tuning sysctl when one of the TCP flows was in the middle of FRTO algorithm (and then RTO is again triggered) 2) SACK

Re: [PATCH][af_key]pfkey_add: Optimize SA adds and algorithm probes

2007-05-19 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 19 May 2007 07:21:48 +1000 On Fri, May 18, 2007 at 02:34:12PM +1000, Herbert Xu wrote: Actually, I think we should just probe for the specific algorithm requested rather than everything. See patch below. Doh, forgot to actually remove the

Re: oops in net/ipv4/icmp.c:icmp_send() with icmp_errors_use_inbound_ifaddr (fwd)

2007-05-19 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 17 May 2007 18:52:29 +0200 [IPV4]: icmp: fix crash with sysctl_icmp_errors_use_inbound_ifaddr When icmp_send is called on the local output path before the packet hits ip_output, skb-dev is not set, causing a crash when

Re: [5/5] 2.6.22-rc2: known regressions

2007-05-19 Thread David Miller
From: Michal Piotrowski [EMAIL PROTECTED] Date: Sun, 20 May 2007 00:06:33 +0200 Subject: OOPS triggered by ip(8) deconfiguring a network interface References : http://bugzilla.kernel.org/show_bug.cgi?id=8491 Submitter : Ben Collins [EMAIL PROTECTED] Status : Unknown Might be fixed

Re: [PATCH] libertas: skb dereferenced after netif_rx

2007-05-20 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Sat, 19 May 2007 21:47:00 -0400 Dan Williams wrote: On Fri, 2007-05-18 at 14:09 -0400, John W. Linville wrote: On Wed, May 16, 2007 at 05:01:27PM -0400, Florin Malita wrote: In libertas_process_rxed_packet() and process_rxed_802_11_packet() the

Re: TCP_MD5 and Intel e1000

2007-05-22 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] Date: Tue, 22 May 2007 18:36:47 +0900 (JST) In article [EMAIL PROTECTED] (at Tue, 22 May 2007 10:57:38 +0200), Eric Dumazet [EMAIL PROTECTED] says: I have tried to set up quagga with tcp-md5 support from kernel. All seems ok with a

Re: [RFC] New driver API to speed up small packets xmits

2007-05-22 Thread David Miller
From: Shirley Ma [EMAIL PROTECTED] Date: Tue, 22 May 2007 15:22:35 -0700 Yep, for any NIC that supports SG but not TSO then software GSO will be a big win. When the NIC doesn't support SG then the win is mostly offset by the need to copy the packet again. Cheers, -- We could

Re: [RFC] New driver API to speed up small packets xmits

2007-05-22 Thread David Miller
From: Shirley Ma [EMAIL PROTECTED] Date: Tue, 22 May 2007 15:58:05 -0700 Sorry for the confusion. I am thinking to avoid copy in skb_segment() for GSO. The way could be in tcp_sendmsg() to allocate small discontiguous buffers (equal = MTU) instead of allocating pages. The SKB splitting

Re: [IPSEC]: Fix warnings with casting int to pointer

2007-05-22 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Tue, 22 May 2007 21:27:03 +1000 Hi Dave: Here's patch to fix the warnings. [IPSEC]: Fix warnings with casting int to pointer This patch adds some casts to shut up the warnings introduced by my last patch that added a common interator function

Re: [RTNETLINK]: Allow changing of subsets of netdevice flags in rtnl_setlink

2007-05-22 Thread David Miller
Applied, thanks for finding this interface deficiency. :-) - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RTNETLINK]: Remove remains of wireless extensions over rtnetlink

2007-05-22 Thread David Miller
From: Johannes Berg [EMAIL PROTECTED] Date: Tue, 22 May 2007 11:27:46 +0200 [RTNETLINK]: Remove remains of wireless extensions over rtnetlink Remove some unused variables and function arguments related to the recently removed wireless extensions over rtnetlink. Still more! Sorry

Re: IFF_PROMISC again

2007-05-22 Thread David Miller
From: Ben Greear [EMAIL PROTECTED] Date: Tue, 22 May 2007 17:08:18 -0700 Anyone know the reasoning for masking out the PROMISC flag in dev_get_flags() ? Because promiscuous status is a counter, not a binary on-off state. You can't expect to just clear it and expect all the other promiscuous

Re: bad networking related lag in v2.6.22-rc2

2007-05-23 Thread David Miller
From: Ingo Molnar [EMAIL PROTECTED] Date: Wed, 23 May 2007 13:40:21 +0200 * Herbert Xu [EMAIL PROTECTED] wrote: [NET_SCHED]: Fix qdisc_restart return value when dequeue is empty My previous patch that changed the return value of qdisc_restart incorrectly made the case where dequeue

Re: [FIX][PATCH] ipv6 addrconf.c REMOVED #if patch

2007-05-23 Thread David Miller
From: Urs Thuermann [EMAIL PROTECTED] Date: 21 May 2007 20:20:51 +0200 Oliver Hartkopp [EMAIL PROTECTED] writes: Yep - you were right. It looks better like this as ARPHRD_SIT is defined in if_arp.h in any CONFIG_* case ... Oliver asked me to resend the patch with a sane mailer that

Re: [patch 1/8] use mutex instead of binary semaphore in idt77252 driver

2007-05-23 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 23 May 2007 14:35:48 -0700 From: Matthias Kaehlcke [EMAIL PROTECTED] Use mutex instead of binary semaphore in idt77252 driver. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] Cc: chas williams [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL

Re: [patch 2/8] Use menuconfig objects: DCCP

2007-05-23 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 23 May 2007 14:35:49 -0700 From: Jan Engelhardt [EMAIL PROTECTED] Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] Cc: Arnaldo Carvalho de

Re: [patch 3/8] Use menuconfig objects: IPVS

2007-05-23 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 23 May 2007 14:35:51 -0700 From: Jan Engelhardt [EMAIL PROTECTED] Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] Acked-by: Simon Horman

Re: [patch 4/8] Use menuconfig objects: SCTP

2007-05-23 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 23 May 2007 14:35:54 -0700 From: Jan Engelhardt [EMAIL PROTECTED] Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] Cc: Vlad Yasevich [EMAIL

Re: [patch 5/8] Use menuconfig objects: TIPC

2007-05-23 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 23 May 2007 14:35:55 -0700 From: Jan Engelhardt [EMAIL PROTECTED] Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] Cc: Per Liden [EMAIL

Re: [patch 6/8] Use menuconfig objects: ARCNET

2007-05-23 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 23 May 2007 14:35:56 -0700 From: Jan Engelhardt [EMAIL PROTECTED] Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] Signed-off-by: Andrew

Re: [patch 7/8] Use menuconfig objects: tokenring

2007-05-23 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 23 May 2007 14:35:57 -0700 From: Jan Engelhardt [EMAIL PROTECTED] Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] Signed-off-by: Andrew

Re: [PATCH 1/1] [TIPC]: Fixed erroneous introduction of for_each_netdev

2007-05-23 Thread David Miller
From: Jon Paul Maloy [EMAIL PROTECTED] Date: Tue, 15 May 2007 20:21:14 -0400 Signed-off-by: Jon Paul Maloy [EMAIL PROTECTED] Patch applied, thanks Jon. I specifically had the developer of that change audit for this exact kind of bug, my apologies that this one case still slipped through :-/

Re: bad networking related lag in v2.6.22-rc2

2007-05-24 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 24 May 2007 07:41:00 +0200 David Miller wrote: * Herbert Xu [EMAIL PROTECTED] wrote: [NET_SCHED]: Fix qdisc_restart return value when dequeue is empty Applied, thanks everyone. Even though it didn't fix this problem, this patch I

Re: Bluetooth fixes for 2.6.22-rc2

2007-05-24 Thread David Miller
From: Marcel Holtmann [EMAIL PROTECTED] Date: Thu, 24 May 2007 18:47:24 +0200 Hi Dave, here are two more bug fixes that should go into 2.6.22 before its final release. The USB driver change is minor and the L2CAP change has been verified with Bluetooth compliance tester and also the L2CAP

Re: [PATCH netdev] wrong timeout value in sk_wait_data() v2

2007-05-24 Thread David Miller
From: Vasily Averin [EMAIL PROTECTED] Date: Thu, 24 May 2007 09:23:14 +0400 sys_setsockopt() do not check properly timeout values for SO_RCVTIMEO/SO_SNDTIMEO, for example it's possible to set negative timeout values. POSIX do not defines behaviour for sys_setsockopt in case negative timeouts,

Re: [PATCH][af_key]pfkey_add: Optimize SA adds and algorithm probes

2007-05-24 Thread David Miller
From: Mark Huth [EMAIL PROTECTED] Date: Thu, 24 May 2007 17:15:30 -0700 I'm a bit curious why all of the crypto modules got loaded, but it doesn't matter. When SADB_REGISTER is performed on a PF_KEY socket, it calls xfrm_probe_algs() which iterates over the lists and loads all the availble

[PATCH]: Packet drops during larval state resolution

2007-05-24 Thread David Miller
The current IPSEC rule resolution behavior we have does not work for a lot of people, even though technically it's an improvement from the -EAGAIN buisness we had before. Right now we'll block until the key manager resolves the route. That works for simple cases, but many folks would rather

Re: [RESEND][PATCH] [NET_SCHED]make qdisc_restart more readable

2007-05-24 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Thu, 24 May 2007 21:58:00 -0400 Dave please apply this patch; against latest net-2.6 Jamal, as much as I love your patch, it's a cleanup and doesn't fix any bugs and we're outside of the merge window for 2.6.22 I'll queue this up for sure when I open up the

[PATCH]: Make XFRM_ACQ_EXPIRES tweakable

2007-05-24 Thread David Miller
I've had several requests for the capability to change this timeout, which I think is perfectly reasonable. So I intend to merge the following upstream unless I hear some objections :-) commit 7191f131aff4797f2a906495c7b285d8adf47da2 Author: David S. Miller [EMAIL PROTECTED] Date: Thu May 24

Re: [PATCH]: Make XFRM_ACQ_EXPIRES tweakable

2007-05-25 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 25 May 2007 07:17:40 +0200 --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_state.c @@ -33,6 +33,8 @@ EXPORT_SYMBOL(sysctl_xfrm_aevent_etime); u32 sysctl_xfrm_aevent_rseqth = XFRM_AE_SEQT_SIZE; EXPORT_SYMBOL(sysctl_xfrm_aevent_rseqth);

Re: [PATCH][IPSEC]: Fix IPv6 AH calculation in outbound

2007-05-25 Thread David Miller
From: Kazunori MIYAZAWA [EMAIL PROTECTED] Date: Fri, 25 May 2007 16:09:14 +0900 Hello David, I send a patch to fix IPv6 AH calculation of outbound. This is for the linux-2.6.22-rc2. Thank you for resending I will apply this. BTW, I sent a patch to fix kernel panic when using inter

Re: [PATCH]: Make XFRM_ACQ_EXPIRES tweakable

2007-05-25 Thread David Miller
From: Chuck Ebbert [EMAIL PROTECTED] Date: Fri, 25 May 2007 11:31:00 -0400 On 05/25/2007 01:13 AM, David Miller wrote: I've had several requests for the capability to change this timeout, which I think is perfectly reasonable. So I intend to merge the following upstream unless I hear

Re: [PATCH 0/9]: tcp-2.6 patchset

2007-05-26 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:35:53 +0300 Dave, you could consider applying other than the last one if they seem ok to you too (you'll need to rebase your tcp-2.6 in that case first to apply cleanly those that touch tcp_sync_left_out :-)). Absolutely, I'll do

Re: [PATCH 0/9]: tcp-2.6 patchset

2007-05-27 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sun, 27 May 2007 10:58:27 +0300 (EEST) On Sat, 26 May 2007, David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:35:53 +0300 Dave, you could consider applying other than the last one if they seem ok to you

Re: EIP is at netlink_insert+0x41/0x10c

2007-05-28 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Sun, 27 May 2007 23:52:34 -0700 I wonder how /bin/init got to run netlink stuff. glibc uses it, but I don't think init does anything which would make use of those features. - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH][IPSEC] fix panic when using inter address familiy IPsec on loopback

2007-05-29 Thread David Miller
From: Kazunori MIYAZAWA [EMAIL PROTECTED] Date: Fri, 20 Apr 2007 19:02:51 +0900 I send patches to fix panic when using inter address family IPsec on loopback device. These patches can be applied to current linux-2.6 and should also be net-2.6. Best regards, Signed-off-by: Kazunori

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Wed, 30 May 2007 20:42:32 +0200 Stephen Hemminger wrote: Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c === --- linux-2.6.22-rc-mm.orig/net/sched/sch_generic.c2007-05-24

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread David Miller
From: Matt Mackall [EMAIL PROTECTED] Date: Wed, 30 May 2007 17:10:39 -0500 Are you agreeing that it seems wasteful to add per-packet overhead? This patch is not doing that. Yes, and I know that :-) - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread David Miller
From: Matt Mackall [EMAIL PROTECTED] Date: Wed, 30 May 2007 17:36:12 -0500 On Wed, May 30, 2007 at 03:29:39PM -0700, David Miller wrote: From: Matt Mackall [EMAIL PROTECTED] Date: Wed, 30 May 2007 17:10:39 -0500 Are you agreeing that it seems wasteful to add per-packet overhead

Re: Fix ipOutNoRoutes counter error for TCP and UDP

2007-05-30 Thread David Miller
Please stop sending your patche emails twice every time. I got the first copy! Thank you :-) - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] bridge: round off STP perodic timers

2007-05-31 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 30 May 2007 12:14:22 -0700 Peroidic STP timers don't have to be exact. The hold timer runs at 1HZ, and the hello timer normally runs at 2HZ; save power by aligning it them to next second. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]

Re: [PATCH 0/4] mac80211 fixes for 2.6.22

2007-05-31 Thread David Miller
From: John W. Linville [EMAIL PROTECTED] Date: Wed, 30 May 2007 14:25:38 -0400 Some bug fixes that should be applied to 2.6.22: mac80211: fail back to use associate from reassociate mac80211: fix memory leak when defrag fragments mac80211: always set carrier status on open

Re: [git patch] since the definition of dst_discard_in and dst_discard_out are the same,,they should merged into one

2007-05-31 Thread David Miller
From: Rankle_ [EMAIL PROTECTED] Date: Thu, 31 May 2007 15:26:54 +0800 From 30d6996860f7e5589d1bce10404bbcfd6592c9de Mon Sep 17 00:00:00 2001 From: Denis Cheng [EMAIL PROTECTED] Date: Thu, 31 May 2007 15:21:58 +0800 Subject: [PATCH] since the definition of dst_discard_in and dst_discard_out

Re: [PATCH 1/9] [TCP]: Move Reno SACKed_out counter functions earlier

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:35:54 +0300 From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] This is of course trivial and fine, applied. - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH 2/9] [TCP] FRTO: remove unnecessary fackets/sacked_out recounting

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:35:55 +0300 From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] F-RTO does not touch SACKED_ACKED bits at all, so there is no need to recount them in tcp_enter_frto_loss. After removal of the else branch, nested ifs can be

Re: [PATCH 3/9] [TCP]: Tighten tcp_sock's belt, drop left_out

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:35:56 +0300 From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] It is easily calculable when needed and user are not that many after all. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] This looks good, but are you

Re: [PATCH 4/9] [TCP]: Access to highest_sack obsoletes forward_cnt_hint

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:35:57 +0300 From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] In addition, added a reference about the purpose of the loop. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] Nice observation, patch applied. - To

Re: [PATCH 5/9] [TCP]: Move code from tcp_ecn.h to tcp*.c and tcp.h remove it

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:35:58 +0300 From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] No other users exist for tcp_ecn.h. Very few things remain in tcp.h, for most TCP ECN functions callers reside within a single .c file and can be placed

Re: [PATCH 6/9] [TCP]: Reorganize lost marking code

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:35:59 +0300 From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] The indentation started to get scary, so I reorganized code so that some trivial ifs are in tcp_update_scoreboard and the main loops remain in

Re: [PATCH 7/9] [TCP]: Correct fastpath entrypoint below high_seq

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:36:00 +0300 From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] In addition, implemented find_below using minus one. Some reorganization was necessary to make code efficient again. Signed-off-by: Ilpo Järvinen [EMAIL

Re: Suspicious fackets_out handling

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Mon, 23 Apr 2007 14:28:21 +0300 (EEST) There are IMHO two problems in it. First of all, nothing ensures that the skb TCP is fragmenting is actually below the forwardmost sack block (and thus is included to the fackets_out)... Good catch, I agree

Re: [TG3]: Fix link problem on Dell's onboard 5906.

2007-05-31 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Thu, 31 May 2007 15:03:39 -0700 [TG3]: Fix link problem on Dell's onboard 5906. The bug is caused by code that always set (TG3_FLAG_USE_MI_INTERRUPT | TG3_FLAG_USE_LINKCHG_REG) on all Dell's onboard devices. With these 2 flags set, the link status

Re: [Oops] unix_dgram_connect locking problem?

2007-05-31 Thread David Miller
From: Frederik Deweerdt [EMAIL PROTECTED] Date: Fri, 11 May 2007 17:00:14 +0200 I'm seeing an Oops[1] with a 2.6.19.2 kernel: Frederik, I finally was able to spend some quality time on this issue today. Sorry for taking so long. I came up with a series of two patches, the first one makes the

Re: [PATCH] use default 32768-61000 outgoing port range in all cases

2007-05-31 Thread David Miller
From: Mark Glines [EMAIL PROTECTED] Date: Tue, 15 May 2007 15:50:54 -0700 I noticed I had chopped off a whole comment, when I meant to only remove part of it. So I've fixed that. This is a reissued use-high-ports-for-local-stuff.diff, with a comment fix. Does anyone have a problem with

Re: [PATCH] improved locking performance in rt_run_flush()

2007-05-31 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Sun, 20 May 2007 15:11:48 +1000 David Miller [EMAIL PROTECTED] wrote: From: Dave Johnson [EMAIL PROTECTED] The below patch changes rt_run_flush() to only take each spinlock protecting the rt_hash_table once instead of taking a spinlock

Re: [PATCH] net: fix comparisons of unsigned 0

2007-05-31 Thread David Miller
From: Bill Nottingham [EMAIL PROTECTED] Date: Wed, 30 May 2007 03:56:13 -0400 Recent gcc versions emit warnings when unsigned variables are compared 0 or = 0. Signed-off-by: Bill Nottingham [EMAIL PROTECTED] Patch applied, thanks. - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] [TCP]: Fix GSO ignorance of pkts_acked arg (cong.cntrl modules)

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Wed, 30 May 2007 12:10:06 +0300 (EEST) Based on feedback from Stephen, I changed the commit msg bit clearer, the patch remains the same. [PATCH] [TCP]: Fix GSO ignorance of pkts_acked arg (cong.cntrl modules) The code used to ignore GSO

Re: Fix ipOutNoRoutes counter error for TCP and UDP

2007-05-31 Thread David Miller
From: Wei Dong [EMAIL PROTECTED] Date: Thu, 31 May 2007 09:16:50 +0800 Hi Mr. David I have modified my patch according to you advice. I think - EHOSTUNREACH is only for input path. In output path, we can just simply check-ENETUNREACH (^_^), the patch is shown in the end of this mail. I

Re: [NET] gso: Fix GSO feature mask in sk_setup_caps

2007-05-31 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Fri, 1 Jun 2007 15:13:49 +1000 [NET] gso: Fix GSO feature mask in sk_setup_caps This isn't a bug just yet as only TCP uses sk_setup_caps for GSO. However, if and when UDP or something else starts using it this is likely to cause a problem if we

Re: Fix ipOutNoRoutes counter error for TCP and UDP

2007-05-31 Thread David Miller
From: weidong [EMAIL PROTECTED] Date: Fri, 01 Jun 2007 13:37:08 +0800 Mr David Sorry to trouble many times, I will attention to this next time. I have made this patch again, and I tried, it can be patched to the recently kernel of linux-2.6.21.3. following is the patch, and

Re: [ICMP]: Fix icmp_errors_use_inbound_ifaddr sysctl

2007-06-01 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Fri, 01 Jun 2007 19:24:18 +0200 It seems like you missed this patch in the previous thread discussing the problem, so here's a resend. Thanks for resending, applied, thanks Patrick. - To unsubscribe from this list: send the line unsubscribe netdev

Re: ETHTOOL_GSET IOCTL on GigE links

2007-06-01 Thread David Miller
From: Jeff Haran [EMAIL PROTECTED] Date: Fri, 1 Jun 2007 15:51:18 -0700 OK, but my question remains. In the case where a device supports one set of speeds via autonegotiation and another set via forcing, how does one tell which speeds can be forced and which can be autonegotiated?

  1   2   3   4   5   6   7   8   9   10   >