Re: ieee80211 patches

2005-08-25 Thread Jean Tourrilhes
Hi, I don't want to disturb the good work you guys are doing, but I had a few comments on your patch regarding the WE APIs. In particular : -- +struct translate_scan { + char *start; + char *stop; + int count;

Re: ieee80211 patches

2005-08-31 Thread Jean Tourrilhes
On Wed, Aug 31, 2005 at 05:43:32PM -0400, Peter Jones wrote: On Wed, 2005-08-31 at 10:52 -0700, Jean Tourrilhes wrote: Peter Jones [EMAIL PROTECTED] wrote : I don't think that's really right either. For one thing, things like DHCP's timeout start counting at about the same time

Re: ieee80211 patches

2005-09-01 Thread Jean Tourrilhes
On Thu, Sep 01, 2005 at 02:13:21PM +0200, Jiri Benc wrote: On Wed, 31 Aug 2005 10:52:54 -0700, Jean Tourrilhes wrote: I personally consider that a bug in ifplugd. For example, the hp100 Ethernet driver will start media sensing only in the open() call, which means that ifplugd won't work

Re: ieee80211 patches

2005-09-01 Thread Jean Tourrilhes
On Thu, Sep 01, 2005 at 07:36:34PM +0100, Pedro Ramalhais wrote: Oops, my brain had censored that part of the iwconfig manual. Yeah, it come at the end of a long page ;-) Reading that, and since i imagine that few people use it, Not explicitely, but it's used internally.

Re: ifplugd (was: Re: ieee80211 patches)

2005-09-02 Thread Jean Tourrilhes
Lennart Poettering wrote : It is simply not true that all current network drivers set IFF_RUNNING correctly. ifplugd does the best it can to detect the carrier, but is still incompatible out of the box with some drivers. To write carrier detection code that works reliably on most drivers

[PATCH 2.6.13] atmel_cs : WE-17 support

2005-09-02 Thread Jean Tourrilhes
Hi Jeff, This adds support for WE-17 to the atmel_cs driver. Not tested, I don't have the HW. Regards, Jean Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED] diff -u -p linux/drivers/net/wireless/atmel.18.c linux/drivers/net/wireless/atmel.c --- linux/drivers

[PATCH 2.6.13] wl3501_cs : WE-17 support

2005-09-02 Thread Jean Tourrilhes
Hi Jeff, wl3501_cs won't compile with WE-19. This patches fixes it. Regards, Jean Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED] Acked-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] diff -u -p linux/drivers/net/wireless/wl3501.18.h linux/drivers/net

[PATCH 2.6.13] prism54 : WE-17 support

2005-09-02 Thread Jean Tourrilhes
Hi Jeff, My patch that adds WE-17 support to the Prism54 driver went already in the kernel, except for a tiny bit that was dropped on the way. This is the missing bit Tested with 2.6.13 (with real HW). Regards, Jean Signed-off-by: Jean Tourrilhes

Re: [PATCH 2.6.18] WE-21 for bcm43xx (wireless-2.6 git)

2006-08-31 Thread Jean Tourrilhes
On Thu, Aug 31, 2006 at 03:09:04PM +0200, Johannes Berg wrote: Jean, This is the version of the patch for out-of-tree, I guess you will need it. Not tested. We don't, neither softmac nor bcm43xx is maintained out-of-tree any more. johannes Cool. I should have checked...

Re: [PATCH] WE-21 for bcm43xx (wireless-2.6 git)

2006-08-31 Thread Jean Tourrilhes
On Thu, Aug 31, 2006 at 09:57:45AM -0400, John W. Linville wrote: On Thu, Aug 31, 2006 at 08:22:22AM -0500, Larry Finger wrote: John, have you merged, or do you plan to merge, [PATCH 2.6.18] WE-21 support (core API) into wireless-2.6? I guess that is still up for discussion. It looks

Re: [PATCH 2.6.18] WE-21 support (core API)

2006-08-31 Thread Jean Tourrilhes
On Thu, Aug 31, 2006 at 03:32:18PM +0200, Johannes Berg wrote: On Tue, 2006-08-29 at 17:56 -0700, Jean Tourrilhes wrote: o modulation o long/short retry o relative power saving. I strongly disagree to these. And I strongly disagree with your

Re: [PATCH 2.6.18] WE-21 support (core API)

2006-09-01 Thread Jean Tourrilhes
On Fri, Sep 01, 2006 at 08:54:00AM +0200, Johannes Berg wrote: On Thu, 2006-08-31 at 10:12 -0700, Jean Tourrilhes wrote: And I strongly disagree with your disagrement ;-) You're of course free to do that :) But let me explain. And my explanation is even more simple : let's

Re: [PATCH 2.6.18] WE-21 support (core API)

2006-09-01 Thread Jean Tourrilhes
On Fri, Sep 01, 2006 at 08:55:48PM +0200, Michael Buesch wrote: Note that one thing that worry me with your approach is footprint. I've used various embedded devices over the years, such as the Gumstix (4MB Flash), and this is why WE was optimised for footprint. Can you please

Re: [PATCH 2.6.18] WE-21 support (core API)

2006-09-05 Thread Jean Tourrilhes
On Mon, Sep 04, 2006 at 10:35:09AM +0200, Johannes Berg wrote: Uh, please don't strip me from the CC list :) WE-netlink is optional. And WE-ioctl could be made optional (still on the todo list). You can also disable WE-event and WE-iwspy for further footprint reduction. The real

Re: [RFC] Alternate WE-21 support (core API)

2006-09-06 Thread Jean Tourrilhes
On Wed, Sep 06, 2006 at 04:55:44PM -0400, John W. Linville wrote: On Thu, Aug 31, 2006 at 04:00:05PM +0200, Johannes Berg wrote: On Thu, 2006-08-31 at 06:51 -0700, Jouni Malinen wrote: I don't know about the others, but long/short retry limits have users (e.g., Host AP driver) and

Re: [RFC] Alternate WE-21 support (core API)

2006-09-08 Thread Jean Tourrilhes
On Fri, Sep 08, 2006 at 10:29:23AM -0400, John W. Linville wrote: On Wed, Sep 06, 2006 at 02:30:53PM -0700, Jean Tourrilhes wrote: On Wed, Sep 06, 2006 at 04:55:44PM -0400, John W. Linville wrote: + * V20 to V21 + * -- + * - Remove (struct net_device

Re: [PATCH 1/3] [IrDA] af_irda.c cleanups

2006-09-11 Thread Jean Tourrilhes
On Mon, Sep 11, 2006 at 08:46:36AM +0300, Samuel Ortiz wrote: Hi Dave, We lock the socket when both releasing and getting a disconnected notification. In the latter case, we also ste the socket as orphan. This fixes a potential kernel bug that can be triggered when we get the disconnection

Re: [RFC] Alternate WE-21 support (core API)

2006-09-12 Thread Jean Tourrilhes
On Tue, Sep 12, 2006 at 10:43:57AM +0200, Johannes Berg wrote: But there are bits left and right, so more inspection of drivers would be needed. For example, wavelan and netwave are using encryption key sizes which are not compatible with 802.11. Hmm, interesting. Will need to think

Re: [PATCH 2.6.18] WE-21 for ipw2200

2006-09-12 Thread Jean Tourrilhes
On Tue, Sep 12, 2006 at 02:02:59PM -0400, John W. Linville wrote: On Tue, Aug 29, 2006 at 06:01:40PM -0700, Jean Tourrilhes wrote: @@ -8861,7 +8861,7 @@ static int ipw_wx_set_essid(struct net_d int length = 0; mutex_lock(priv-mutex); if (wrqu-essid.flags wrqu-essid.length

Re: [PATCH 2.6.18] WE-21 for ipw2200

2006-09-12 Thread Jean Tourrilhes
On Tue, Sep 12, 2006 at 02:02:59PM -0400, John W. Linville wrote: On Tue, Aug 29, 2006 at 06:01:40PM -0700, Jean Tourrilhes wrote: This hunk doesn't apply to the upstream branch of wireless-2.6. I propose this one instead: @@ -8875,8 +8875,6 @@ static int ipw_wx_set_essid(struct net_d

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-09-21 Thread Jean Tourrilhes
On Fri, Sep 22, 2006 at 12:38:44AM +0200, Jiri Benc wrote: On Thu, 21 Sep 2006 13:39:18 -0700, mabbas wrote: I can fix the patch to do just that if we agree on that. Well, we need a flag indicating whether we are associated or not. I don't know about such a flag in WE (hopefully we will

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-09-21 Thread Jean Tourrilhes
On Thu, Sep 21, 2006 at 05:42:35PM -0700, Jouni Malinen wrote: On Thu, Sep 21, 2006 at 03:55:14PM -0700, Jean Tourrilhes wrote: Jean, are there any other possibilities? Yes, dropping SIOCSIWAP (set) entirely, and keep only SIOCGIWAP (get). I don't think that this would

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Jean Tourrilhes
On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: On Fri, 29 Sep 2006 20:01:54 -0400 Here's the traceback I got: slab error in verify_redzone_free(): cache `size-32': memory outside object was overwritten [c0103ad2] dump_trace+0x64/0x1cd [c0103c4d]

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Jean Tourrilhes
On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: On Fri, 29 Sep 2006 20:01:54 -0400 A quick strace of gkrellm finds these likely ioctl's causing the problem: % grep ioctl /tmp/foo2 | sort -u | more ioctl(13, SIOCGIWESSID, 0xbfbcdb9c) = 0 ioctl(13, SIOCGIWRANGE,

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-02 Thread Jean Tourrilhes
On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: On Fri, 29 Sep 2006 20:01:54 -0400 % grep ioctl /tmp/foo2 | sort -u | more ioctl(13, SIOCGIWESSID, 0xbfbcdb9c) = 0 ioctl(13, SIOCGIWRANGE, 0xbfbcdbdc) = 0 ioctl(13, SIOCGIWRATE, 0xbfbcdbbc) = 0 Yes. The

[PATCH 2.6] Fix WE-21 Orinoco overflow issue...

2006-10-02 Thread Jean Tourrilhes
Hi John, This patch fixes the Orinoco driver overflow issue with WE-21. This was discussed on the mailing list, the reporter confirmed that it fixes the issue and Andrew has already added this patch in tree. Regards, Jean

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-03 Thread Jean Tourrilhes
On Tue, Oct 03, 2006 at 05:58:31PM +0200, Samuel Tardieu wrote: Jean == Jean Tourrilhes [EMAIL PROTECTED] writes: Jean @@ -2500,9 +2501,9 @@ static int orinoco_hw_get_essid(struct o Jean len = le16_to_cpu(essidbuf.len); Jean BUG_ON(len IW_ESSID_MAX_SIZE); Jean Jean

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-03 Thread Jean Tourrilhes
On Tue, Oct 03, 2006 at 06:45:35PM +0200, Samuel Tardieu wrote: On 3/10, Jean Tourrilhes wrote: | I suggest that you revert the memset() to IW_ESSID_MAX_SIZE+1 so that | the last byte is cleared as well. Or am I missing something? | | No, that would bring back the slab/memory overflow

Request to postpone WE-21

2006-10-05 Thread Jean Tourrilhes
Hi John, Based on the feedback, I formally request you to back out all of WE-21 from 2.6.19. Rationale : it's probably too early. You can keep it for a later date if you wish. Regards, Jean - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: Request to postpone WE-21

2006-10-05 Thread Jean Tourrilhes
On Thu, Oct 05, 2006 at 04:49:54PM -0400, John W. Linville wrote: On Thu, Oct 05, 2006 at 09:31:13AM -0700, Jean Tourrilhes wrote: Based on the feedback, I formally request you to back out all of WE-21 from 2.6.19. Rationale : it's probably too early. You can keep it for a later date

Re: Request to postpone WE-21

2006-10-05 Thread Jean Tourrilhes
On Thu, Oct 05, 2006 at 04:49:54PM -0400, John W. Linville wrote: On Thu, Oct 05, 2006 at 09:31:13AM -0700, Jean Tourrilhes wrote: Based on the feedback, I formally request you to back out all of WE-21 from 2.6.19. Rationale : it's probably too early. You can keep it for a later date

Re: Request to postpone WE-21

2006-10-05 Thread Jean Tourrilhes
On Thu, Oct 05, 2006 at 03:15:50PM -0700, Jouni Malinen wrote: On Thu, Oct 05, 2006 at 03:12:46PM -0700, Jean Tourrilhes wrote: + if((cmd == SIOCSIWESSID) || + (cmd == SIOCSIWNICKN)) { + if(extra[iwr-u.data.length - 1] == '\0

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-05 Thread Jean Tourrilhes
On Thu, Oct 05, 2006 at 06:37:53PM -0400, Pavel Roskin wrote: Hello! On Tue, 2006-10-03 at 09:34 -0700, Jean Tourrilhes wrote: I don't really want to overstep my authority there, my goal was to minimise the changes. Pavel will have to clean up my mess, so I don't want change things

Re: Request to postpone WE-21

2006-10-10 Thread Jean Tourrilhes
On Tue, Oct 10, 2006 at 03:40:04PM -0400, John W. Linville wrote: I think this patch still has two problems. One is that the length modification does not happen until after the Check what user space is giving us clause. So, max length requests will fail. (Did you check SIOCGIWESSID w/

Re: SIOCGIWSCAN wireless event behaviour

2006-04-20 Thread Jean Tourrilhes
On Thu, Apr 20, 2006 at 10:37:32AM -0400, Dan Williams wrote: On Thu, 2006-04-20 at 15:15 +0100, Daniel Drake wrote: Hi Jean, A query regarding wireless events: under which circumstances should a driver/stack send a SIOCGIWSCAN event to userspace? Should it be sent whenever a

Re: dBm cutoff at -1dBm is too low

2006-05-05 Thread Jean Tourrilhes
On Thu, May 04, 2006 at 12:37:45PM -0400, Pavel Roskin wrote: Hello, Jean! I'm converting Orinoco to the dBm reporting, and it turns out that the best signal iwconfig will report is -1dBm (0.8mW). This would happen if qual-level has its highest value of 255. Please see this code from

Re: dBm cutoff at -1dBm is too low

2006-05-08 Thread Jean Tourrilhes
On Sat, May 06, 2006 at 11:32:12PM -0400, Pavel Roskin wrote: On Fri, 2006-05-05 at 10:28 -0700, Jean Tourrilhes wrote: There are still quite a few drivers which have not been converted to use IW_QUAL_DBM, so I don't want to drop the backward compatibility yet. But shouldn't you

Re: dBm cutoff at -1dBm is too low

2006-05-09 Thread Jean Tourrilhes
On Tue, May 09, 2006 at 12:54:55AM -0400, Pavel Roskin wrote: On Mon, 2006-05-08 at 10:17 -0700, Jean Tourrilhes wrote: But shouldn't you trust the drivers using IW_QUAL_DBM, whether the value is positive or negative? You can't remove the test, making the rest pointeless. Old

Re: [PATCH 1/5] new pcmcia IDs for hostap - ASUS WL-110

2006-05-12 Thread Jean Tourrilhes
Marcin Juszkiewicz wrote : This time I checked more carefully my changeset and split it into smaller parts. Few of my patches was tested by OpenZaurus users, some are waiting for testing. I'm sorry, but I will have again to veto part of your patch. You are removing IDs from

Re: SIOCSIWESSID + SIOCSIWAP behaviour

2006-05-15 Thread Jean Tourrilhes
On Sun, May 14, 2006 at 11:29:38PM -0400, Dan Williams wrote: On Mon, 2006-05-15 at 00:29 +0100, Daniel Drake wrote: Hi Jean, Hi, Nice discussion you got going here ;-) I'd just like to check my understanding (and softmacs implementation) of SIWESSID and SIWAP behaviour,

Re: SIOCSIWESSID + SIOCSIWAP behaviour

2006-05-15 Thread Jean Tourrilhes
On Mon, May 15, 2006 at 02:40:14PM -0700, Jouni Malinen wrote: On Mon, May 15, 2006 at 01:28:13PM -0700, Jean Tourrilhes wrote: I believe the BSSID has to be unique. HP APs can also offer multiple ESSID for the same BSSID, but they do so using different BSSID. If you look

Re: [PATCH] wavelan: fix section mismatch

2006-05-25 Thread Jean Tourrilhes
On Thu, May 25, 2006 at 11:09:21AM -0700, Randy.Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Fix section mismatch warning: WARNING: drivers/net/wireless/wavelan.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offset 0x371e) and 'cleanup_module'

Re: [2.6 patch] kill drivers/net/irda/sir_core.c

2005-11-21 Thread Jean Tourrilhes
functions. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Go for it. Ack-by : Jean Tourrilhes [EMAIL PROTECTED] Jean - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

[PATCH 2.6.15] Add bit-rates to scan output

2005-12-02 Thread Jean Tourrilhes
Hi Guys, This is a quick patch I made for the Prism54 driver to display bit-rates in the scan output. This patch was made for 2.6.15-rc4 and seem to do the right thing. If one of you could push that to the various Prism54 repository, I would be glad. Have fun...

Re: [2.6 patch] net/: fix the WIRELESS_EXT abuse

2005-12-05 Thread Jean Tourrilhes
Adrian Bunk wrote : Using WIRELESS_EXT instead of CONFIG_NET_RADIO is simply ugly. Sorry, but I did not see this e-mail in my inbox. Maybe my spam filter is too agressive. I would prefer that to the alternative... You are probably right that something need to be done about it,

Re: [2.6 patch] net/: fix the WIRELESS_EXT abuse

2005-12-05 Thread Jean Tourrilhes
On Mon, Dec 05, 2005 at 03:51:36PM -0800, jt wrote: Adrian Bunk wrote : Using WIRELESS_EXT instead of CONFIG_NET_RADIO is simply ugly. You are probably right that something need to be done about it, but I believe this is the wrong direction. I would prefer you to replace

Re: Broadcom 43xx first results

2005-12-06 Thread Jean Tourrilhes
Jiri Benc wrote : On Mon, 05 Dec 2005 13:46:43 -0500, Jeff Garzik wrote: Use the stack that's already in the kernel. Encouraging otherwise hinders continued wireless progress under Linux. There is nothing like a 802.11 stack currently in the kernel, regardless what James Ketrenos is

Re: Broadcom 43xx first results

2005-12-07 Thread Jean Tourrilhes
On Tue, Dec 06, 2005 at 02:47:28PM -0800, jt wrote: MadWifi stack : drivers using it : MadWifi (non GPL) drivers in progress : FreeHAL Atheros, Prism54 softMAC, ural-ralink Sam kindly pointed out that my statement above may be confusing. It should read : MadWifi stack :

Re: Broadcom 43xx first results

2005-12-07 Thread Jean Tourrilhes
On Tue, Dec 06, 2005 at 11:11:02PM -0800, Jouni Malinen wrote: On Tue, Dec 06, 2005 at 02:47:28PM -0800, Jean Tourrilhes wrote: DeviceScape stack : drivers using it : ? potential drivers : hostap, ipw2100, ipw2200, r8180, adm8211 It's mainly used with Atheros chipsets nowadays

Re: Wireless: One small step towards a more perfect union...?

2006-01-11 Thread Jean Tourrilhes
John W. Linville wrote : If you are the maintainer of an out-of-tree driver or other component (e.g. softmac), please let me hear from you (publicly or privately). Complete and up to date list of driver and their contact person is, and always has been, in the Linux WLAN Howto. As many

Re: wireless: recap of current issues (stack)

2006-01-17 Thread Jean Tourrilhes
On Sat, Jan 14, 2006 at 02:51:14PM +0100, Michael Buesch wrote: On Saturday 14 January 2006 00:03, you wrote: As an aside to this whole thing, I know we're talking about *kernel* wireless but it's worthless to most people without good userland support as well. Anyone have any thoughts

Re: wireless: recap of current issues (stack)

2006-01-17 Thread Jean Tourrilhes
On Tue, Jan 17, 2006 at 08:23:50PM +0100, Olivier Blin wrote: And most of the time, userland has to poll for scan results or association status, netlink notifications would help. For example, it would be a lot easier for ifplugd to listen on a netlink, instead of polling for current AP and

Re: IRDA maintainer status

2006-01-18 Thread Jean Tourrilhes
On Wed, Jan 18, 2006 at 10:52:26AM -0800, Stephen Hemminger wrote: Dave, Jean says he really doesn't have time to much IRDA any more. The following would help motivate someone who has more time. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Thanks ;-) (Unfortunately,

Re: IRDA maintainer status

2006-01-18 Thread Jean Tourrilhes
On Wed, Jan 18, 2006 at 02:07:18PM -0800, David S. Miller wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 18 Jan 2006 10:52:26 -0800 Dave, Jean says he really doesn't have time to much IRDA any more. The following would help motivate someone who has more time.

Re: [2.6 patch] net/: fix the WIRELESS_EXT abuse

2006-01-20 Thread Jean Tourrilhes
On Thu, Jan 19, 2006 at 09:57:24PM -0500, John W. Linville wrote: On Mon, Dec 05, 2005 at 06:48:15PM -0800, Jean Tourrilhes wrote: On Mon, Dec 05, 2005 at 03:51:36PM -0800, jt wrote: Adrian Bunk wrote : Using WIRELESS_EXT instead of CONFIG_NET_RADIO is simply ugly. You

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-01-30 Thread Jean Tourrilhes
On Fri, Jan 27, 2006 at 05:01:44PM -0800, Jouni Malinen wrote: On Thu, Jan 12, 2006 at 03:00:58PM -0500, Dan Williams wrote: ESSIDs can technically include NULL characters. Drivers should not be adjusting the length of the ESSID before reporting it in their SIOCGIWESSID handlers. Breaks

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-01-30 Thread Jean Tourrilhes
On Mon, Jan 30, 2006 at 01:28:44PM -0500, Dan Williams wrote: I'll post a revert patch for the patch I originally sent so that we go back to the original behavior. Sorry, I may have overreacted. I think that's a worthwhile change, let's just plan it properly. Dan Jean - To

Re: Please pull 'we21-fix' branch of wireless-2.6.git

2006-10-19 Thread Jean Tourrilhes
On Thu, Oct 19, 2006 at 05:56:53PM -0400, John W. Linville wrote: Jeff, Here is my ugly patch to fix userland ABI compatibility for WE-21. It tries to detect WE = 20 by the request length or the inclusion of '\0' in the length for the ESSID and NICKN ioctls. If it finds that, it

Re: [airo.c bug] Couldn't allocate RX FID / Max tries exceeded when issueing command

2006-11-02 Thread Jean Tourrilhes
On Thu, Nov 02, 2006 at 04:21:16PM -0500, Ivan Matveich wrote: On 11/2/06, Dan Williams [EMAIL PROTECTED] wrote: Do you know which kernel version that patch first appeared in? It was committed on 1 Dec 2005, and 2.6.15 was released on 3 Jan 2006. That would be a great idea, let us know

Re: [PATCH 2.6] WE-22 : prevent information leak on 64 bit

2007-04-17 Thread Jean Tourrilhes
On Mon, Apr 02, 2007 at 12:06:50PM +0200, Johannes Berg wrote: Jean Tourrilhes wrote : Johannes Berg discovered that kernel space was leaking to userspace on 64 bit platform. He made a first patch to fix that. This is an improved version of his patch. This was tested on 2.6.21

Re: [PATCH 2.6] WE-22 : prevent information leak on 64 bit

2007-04-17 Thread Jean Tourrilhes
On Tue, Apr 17, 2007 at 02:34:42PM -0400, John W. Linville wrote: On Tue, Apr 17, 2007 at 10:08:20AM -0700, Jean Tourrilhes wrote: First, I'm the current active maintainer of the wext-over-netlink interface, and nobody bothered to even 'inform' me about its removal, let alone consult

Re: [PATCH 2.6] WE-22 : prevent information leak on 64 bit

2007-04-18 Thread Jean Tourrilhes
On Wed, Apr 18, 2007 at 01:34:50AM +0200, Michael Buesch wrote: I'd say nobody but you does fully understand WEXT. Not true. If tommorow I was run over by an ICE, you could ask Jouni, Dan or Pavel to take over. Have fun... Jean - To unsubscribe from this list: send the

Re: [PATCH 3/9] wext: remove dead debug code

2007-04-26 Thread Jean Tourrilhes
On Tue, Apr 24, 2007 at 08:07:35PM +0200, Johannes Berg wrote: This patch kills a whole bunch of code that can only ever be used by defining some things in wext.c. Also, the things that are printed are mostly useless since the API is fairly well-tested. Signed-off-by: Johannes Berg [EMAIL

Re: [PATCH 7/9] wext: reduce inline abuse

2007-04-26 Thread Jean Tourrilhes
On Tue, Apr 24, 2007 at 08:07:39PM +0200, Johannes Berg wrote: This patch removes a bunch of inline abuse from wext. Most functions that were marked inline are only used once so the compiler will inline them anyway, others are used multiple times but there's no requirement for them to be

Re: [PATCH 9/9] net_device: dont include wext bits if not required

2007-04-26 Thread Jean Tourrilhes
On Tue, Apr 24, 2007 at 08:07:41PM +0200, Johannes Berg wrote: This patch makes the wext bits in struct net_device depend on CONFIG_WIRELESS_EXT. Signed-off-by: Johannes Berg [EMAIL PROTECTED] I personally would not do that. Having conditional fields in struct net_device is very bad,

Re: [PATCH 7/9] wext: reduce inline abuse

2007-04-26 Thread Jean Tourrilhes
On Thu, Apr 26, 2007 at 07:03:27PM +0200, Michael Buesch wrote: Sure, other people have different opinions on that, but I think with my approach we get smallest code with good speed. Try with gcc-3.3 if you don't trust me. Your patch will produce bigger and slower code. Thanks.

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-02-09 Thread Jean Tourrilhes
On Wed, Feb 08, 2006 at 08:06:33PM -0500, John W. Linville wrote: On Mon, Jan 30, 2006 at 02:28:43PM -0800, Jean Tourrilhes wrote: On Mon, Jan 30, 2006 at 01:28:44PM -0500, Dan Williams wrote: I'll post a revert patch for the patch I originally sent so that we go back to the original

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-02-10 Thread Jean Tourrilhes
On Fri, Feb 10, 2006 at 09:33:00AM -0500, Dan Williams wrote: Jean, You mean it would be wise to _not_ commit this patch, right? Yeah, it depend which way you look at it. I was talking of the reverse patch ;-) John: if that's the case (and I think it is?), please back that patch

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-02-13 Thread Jean Tourrilhes
On Fri, Feb 10, 2006 at 02:20:22PM -0500, Dan Williams wrote: Hmm, I'm still confused... Dan Don't worry, you are not the only one being confused... Anyway, I made some decisions, for a change ;-) Wireless Extensions 21 will be the big switch over when ESSID length are the

[PATCH 2.6.16] Wavelan_cs bitfield fixes

2006-02-16 Thread Jean Tourrilhes
Hi Jeff, Some bitfields were incorrectly initialised in wavelan_cs, causing some compiler warning. Also killed a error message that should not be there... Tested in 2.6.16-rc3... Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED] Have fun... Jean diff -u

Re: ANNOUNCE: new DHCP client for linux 2.6.x

2006-02-17 Thread Jean Tourrilhes
Stefan Rompf wrote : dhcpclient A DHCP client for linux 2.6, using modern kernel features, (c) 2006 Stefan Rompf. Motivation Using a notebook, I'm often traveling between different networks. After replugging, I always needed to issue a

Re: ANNOUNCE: new DHCP client for linux 2.6.x

2006-02-17 Thread Jean Tourrilhes
On Fri, Feb 17, 2006 at 09:44:39PM +0100, Stefan Rompf wrote: Am Freitag 17 Februar 2006 19:39 schrieb Jean Tourrilhes: I congratulate you on your good work. Thanks! I will share with you my personal gripe on most DHCP clients : they depend too much on those link signalling

[PATCH] WE-20 for kernel 2.6.16

2006-02-22 Thread Jean Tourrilhes
would also like to thank Alexey Kuznetsov for his helpful suggestions to make this patch better. Have fun... Jean Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED] --- diff -u -p linux/include/linux/wireless.19.h linux

Re: [PATCH] WE-20 for kernel 2.6.16

2006-02-27 Thread Jean Tourrilhes
On Mon, Feb 27, 2006 at 08:06:29PM +0100, Michael Buesch wrote: On Monday 27 February 2006 18:34, Jean Tourrilhes wrote: On Sat, Feb 25, 2006 at 11:48:39PM +0100, Johannes Berg wrote: On Sat, 2006-02-25 at 17:09 -0500, Jeff Garzik wrote: I strongly ACK the use of rtnetlink, but I

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-06 Thread Jean Tourrilhes
Jouni Malinen wrote : On Mon, Mar 06, 2006 at 04:44:27PM +0100, Jiri Benc wrote: PRISM2_PARAM_ADM_STATUS is not used anywhere in kernel nor in userspace. It just passes a value to the driver, so it's safe to remove it. This is used to implement radio on/off without having to change

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-06 Thread Jean Tourrilhes
On Mon, Mar 06, 2006 at 03:23:04PM -0800, Jouni Malinen wrote: On Mon, Mar 06, 2006 at 02:25:52PM -0800, Jean Tourrilhes wrote: Jouni Malinen wrote : This is used to implement radio on/off without having to change other parts of the configuration (e.g., set interfaces down

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-08 Thread Jean Tourrilhes
On Tue, Mar 07, 2006 at 07:11:27PM -0800, Simon Barber wrote: Overloading configuration parameters with extra meanings like this makes it harder to configure the system - I think it's useful to keep an on/off function separate from the power setting. Simon The main issue I have

Re: [RFC PATCH] softmac: send WEXT assoc/disassoc events to userspace

2006-03-09 Thread Jean Tourrilhes
Dan Williams wrote : Completely untested, not entirely sure it compiles. For whatever reason, softmac is sending custom events to userspace already, but it should _really_ be sending the right WEXT events instead. Comments? If this looks good, please apply it. Good catch ! Thanks

Re: [PATCH 14/16] ipw2200: wireless extension sensitivity

2006-03-09 Thread Jean Tourrilhes
Jiri Benc wrote : On Thu, 09 Mar 2006 11:39:06 +0800, Zhu Yi wrote: On Wed, 2006-03-08 at 13:23 +0100, Jiri Benc wrote: I don't think it's a good idea to misuse 'iwconfig sens' for this. This has been discussed on ipw2100-devel ML. Jean will change the manual for 'iwconfig sens'.

Re: Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not

2006-03-24 Thread Jean Tourrilhes
Jouni Malinen wrote : On Fri, Mar 24, 2006 at 10:57:22AM -0500, Dan Williams wrote: hidden this is something that ieee80211 does that's completely wrong. Drivers need to report the _exact_ ESSID from the air in their scan results. It's up to the user space app to deal with ESSID length

Re: Re: [SOFTMAC] Reduce scan dwell time

2006-03-24 Thread Jean Tourrilhes
Jouni Malinen wrote : On Thu, Mar 23, 2006 at 08:16:04PM -0500, Dan Williams wrote: That's why wireless-tools and Wireless Extensions switched to passive scanning. Can you please point to some documentation/email thread/etc. describing this preference to use passive scanning? I was not

Re: Re: [SOFTMAC] Reduce scan dwell time

2006-03-24 Thread Jean Tourrilhes
On Fri, Mar 24, 2006 at 03:38:50PM -0500, Dan Williams wrote: On Fri, 2006-03-24 at 12:12 -0800, Jean Tourrilhes wrote: Jouni Malinen wrote : On Thu, Mar 23, 2006 at 08:16:04PM -0500, Dan Williams wrote: That's why wireless-tools and Wireless Extensions switched to passive

Re: rtnetlink compile failure.

2006-03-24 Thread Jean Tourrilhes
Dave Jones wrote : I accidentally ended up with a config that set NET_RADIO off, and NET_WIRELESS_RTNETLINK on, which blew up thus.. Good catch ! Actually, in 2.6.17, NET_RADIO and WIRELESS_EXT were separated. So, I would suggest the following instead :

[PATCH 2.6.16] zd1201 wireless stat update

2006-03-24 Thread Jean Tourrilhes
was compiled on 2.6.16. I don't have hardware, so it's not tested, but I can't see how I could have messed up. Regards, Jean Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED] - diff -u -p linux/drivers/usb/net/zd1201.19.c linux

Re: 32bit compat for rtnetlink wireless extensions?

2006-03-27 Thread Jean Tourrilhes
On Sun, Mar 26, 2006 at 02:08:48PM +0200, Arnd Bergmann wrote: I stumbled over the 'WE-20 for kernel 2.6.16' and afaict, there is no way that IW_HEADER_TYPE_POINT rtnetlink messages can work when using 32 bit user tools on a 64 bit kernel. Please check again ;-) I agree that it's not

Re: 32bit compat for rtnetlink wireless extensions?

2006-03-27 Thread Jean Tourrilhes
On Mon, Mar 27, 2006 at 11:10:44PM +0200, Arnd Bergmann wrote: Am Monday 27 March 2006 20:42 schrieb Jean Tourrilhes: Actually, when things are passed over RtNetlink, the pointer is removed, and the content of IW_HEADER_TYPE_POINT is moved to not leave a gap. Ah, that makes sense

Re: [PATCH 2.6.16] zd1201 wireless stat update

2006-03-27 Thread Jean Tourrilhes
On Mon, Mar 27, 2006 at 04:57:01PM -0500, John W. Linville wrote: On Fri, Mar 24, 2006 at 04:45:24PM -0800, Jean Tourrilhes wrote: Hi all, The dev-get_wireless_stats field is deprecated and slowly be surely going away. Most drivers have been updated months ago. Actually

[PATCH 2.6.17-rc1] Fix IWENCODEEXT security permissions

2006-04-04 Thread Jean Tourrilhes
Hi, Check the permissions when user-space try to read the encryption parameters via SIOCGIWENCODEEXT. This is trivial and probably should go in 2.6.17... Bug was found by Brian Eaton [EMAIL PROTECTED], thanks ! Have fun... Jean Signed-off-by: Jean

[PATCH 2.6.17-rc1] Revert NET_RADIO Kconfig title change

2006-04-04 Thread Jean Tourrilhes
this change help disambiguate the relation between those two options. Have fun... Jean Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED] --- diff -u -p linux/drivers/net/wireless/Kconfig-b1 linux/drivers/net/wireless/Kconfig

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-13 Thread Jean Tourrilhes
Pete Zaitcev wrote : Do you realize that block means enterering the kernel and calling schedule(), which is exactly what is NOT happening in the patch? I would not mind if the tools blocked in GIWSCAN, only until it returns success and not EGAIN. Do you realise that block means

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-13 Thread Jean Tourrilhes
Stephen Hemminger wrote : Sounds like you want a message interface like netlink, not ioctl's. We have the message interface (through a Wireless Events, since WE-14). However, netlink is highly undesirable in embedded space for bloat reason. Jean - To unsubscribe from this

Re: [RFC: 2.6 patch] net/irda/irias_object.c: remove unused exports

2006-04-14 Thread Jean Tourrilhes
Hi, You now need to send those patches to : [EMAIL PROTECTED] Personally, I don't see what this patch buy us... Jean On Fri, Apr 14, 2006 at 01:44:46PM +0200, Adrian Bunk wrote: This patch removes the following unused EXPORT_SYMBOL's: -

[PATCH 2.6.17-rc1] Fix RtNetlink ENCODE security permissions

2006-04-14 Thread Jean Tourrilhes
. Fully tested on 2.6.17-rc1. Have fun... Jean Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED] --- diff -u -p linux/net/core/wireless.j1.c linux/net/core/wireless.c --- linux/net/core/wireless.j1.c2006-04-13 18:29

Re: [PATCH 2.6.17-rc1] Fix RtNetlink ENCODE security permissions

2006-04-14 Thread Jean Tourrilhes
On Fri, Apr 14, 2006 at 10:59:13AM -0700, Randy.Dunlap wrote: On Fri, 14 Apr 2006 10:47:26 -0700 Jean Tourrilhes wrote: Hi John, I've just realised that the RtNetlink code does not check the permission for SIOCGIWENCODE and SIOCGIWENCODEEXT, which means that any user can read

Re: [PATCH] sir: switch to a workqueue

2006-04-14 Thread Jean Tourrilhes
On Fri, Apr 14, 2006 at 08:20:15PM +0200, Christoph Hellwig wrote: sir_kthread.c pretty much duplicates the workqueue functionality. Switch it to use a workqueue instead. It could probably use schedule_work/schedule_delayed_work instead of having it's own waitqueue, but I'd rather leave that

Re: softmac: semantics of SIOCSIWFREQ

2006-04-17 Thread Jean Tourrilhes
On Sun, Apr 16, 2006 at 02:34:48PM +0200, Johannes Berg wrote: [breaking out to a new thread so discussion on this doesn't get too hidden, CC Jean since he designed this] - Is SIOCSIWFREQ allowed while associated? No idea. Usually no, but... If you are in managed mode,

Re: softmac: semantics of SIOCSIWFREQ

2006-04-17 Thread Jean Tourrilhes
On Mon, Apr 17, 2006 at 08:48:10PM +0200, Johannes Berg wrote: On Mon, 2006-04-17 at 09:37 -0700, Jean Tourrilhes wrote: Usually no, but... If you are in managed mode, SIOCSIWFREQ usually should return an error, because it is not allowed. Ok. If you are in ad-hoc mode

Re: softmac: semantics of SIOCSIWFREQ

2006-04-17 Thread Jean Tourrilhes
On Mon, Apr 17, 2006 at 09:27:09PM +0200, Johannes Berg wrote: On Mon, 2006-04-17 at 12:06 -0700, Jean Tourrilhes wrote: Definitely. I was just pointing out that scanning behaviour is not dictated by current setting of the drivers (except when the hardware does it, cf. Ornoco

[PATCH 2.6.20] kobject net ifindex + rename

2007-02-27 Thread Jean Tourrilhes
scripts, and on another system running udev. Have fun... Jean Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED] - diff -u -p linux/include/linux/kobject.j1.h linux/include/linux/kobject.h --- linux/include/linux/kobject.j1.h

Re: [PATCH 2.6.20] kobject net ifindex + rename

2007-02-28 Thread Jean Tourrilhes
On Wed, Feb 28, 2007 at 07:36:17AM -0800, Greg KH wrote: On Tue, Feb 27, 2007 at 05:27:41PM -0800, Jean Tourrilhes wrote: diff -u -p linux/drivers/base/class.j1.c linux/drivers/base/class.c --- linux/drivers/base/class.j1.c 2007-02-26 18:38:10.0 -0800 +++ linux/drivers/base

  1   2   >