On Mon, 21 Dec 2020 at 17:01, Hongwei Zhang wrote:
>
> Dear Reviewer,
>
> When FTGMAC100 driver is used on other NCSI Ethernet controllers, few
> controllers have compatible issue. One example is Intel I210 Ethernet
> controller on AST2600 BMC, with FTGMAC100 driver, it always trigger
> RXDES0_RX_
On Sun, 20 Dec 2020 at 12:40, John Wang wrote:
>
> When aggregating ncsi interfaces and dedicated interfaces to bond
> interfaces, the ncsi response handler will use the wrong net device to
> find ncsi_dev, so that the ncsi interface will not work properly.
> Here, we use the net device registered
On Thu, 12 Nov 2020 at 00:57, Jakub Kicinski wrote:
>
> On Thu, 12 Nov 2020 11:10:21 +1030 Joel Stanley wrote:
> > If a user unbinds and re-binds a ncsi aware driver, the kernel will
> > attempt to register the netlink interface at runtime. The structure is
> > marked
;8064ed5c>] (ftgmac100_probe) from [<805d4d90>] (platform_drv_probe+0x58/0xa8)
r9:80e527cc r8: r7:80eb4bcc r6:80e527cc r5:bd141410 r4:
Signed-off-by: Joel Stanley
---
net/ncsi/ncsi-netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ncsi/ncsi-
form_drv_remove+0x34/0x4c)
Fixes: bd466c3fb5a4 ("net/faraday: Support NCSI mode")
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday/ftgmac100.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
b/drivers/net/ethernet/faraday/ftgmac
On Thu, 12 Nov 2020 at 01:20, Jakub Kicinski wrote:
>
> On Thu, 12 Nov 2020 01:11:04 +0000 Joel Stanley wrote:
> > On Thu, 12 Nov 2020 at 00:57, Jakub Kicinski wrote:
> > >
> > > On Thu, 12 Nov 2020 11:10:21 +1030 Joel Stanley wrote:
> > > > If a use
Fixes: 955dc68cb9b2 ("net/ncsi: Add generic netlink family")
Signed-off-by: Joel Stanley
---
v2: Implement Jakub's suggestion
- drop __ro_after_init change
- register netlink with subsys_intcall
- remove unregister function
net/ncsi/ncsi-manage.c | 5 -
net/ncsi/ncsi-n
On Thu, 12 Nov 2020 at 23:22, Jakub Kicinski wrote:
>
> On Thu, 12 Nov 2020 11:01:45 +1030 Joel Stanley wrote:
> > When removing the driver we would hit
> > BUG_ON(!list_empty(&dev->ptype_specific))
> > in net/core/dev.c due to still having the NC-SI packet hand
form_drv_remove+0x34/0x4c)
Fixes: bd466c3fb5a4 ("net/faraday: Support NCSI mode")
Signed-off-by: Joel Stanley
---
v2: Also unregister in _probe
drivers/net/ethernet/faraday/ftgmac100.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
b/
form_drv_remove+0x34/0x4c)
Fixes: bd466c3fb5a4 ("net/faraday: Support NCSI mode")
Signed-off-by: Joel Stanley
---
v3: Apply to net so it can go in as a fix
v2: Also unregister in _probe
---
drivers/net/ethernet/faraday/ftgmac100.c | 4
1 file changed, 4 insertions(+)
diff --git a/driv
On Mon, 19 Oct 2020 at 07:39, Dylan Hung wrote:
>
> The cpu accesses the register and the memory via different bus/path on
> aspeed soc. So we can not guarantee that the tx-poll command
Just the 2600, or other versions too?
> (register access) is always behind the tx descriptor (memory). In ot
n its value is zero
> > regardless the edotr mask.
>
> Again, why is that ? Can you elaborate ? What race are you trying to
> address here ?
>
> Cheers,
> Ben.
>
> > Fixes: 52c0cae87465 ("ftgmac100: Remove tx descriptor accessors")
> > Signed-off-by: Dy
off-by: Dylan Hung
> Signed-off-by: Joel Stanley
Reviewed-by: Joel Stanley
> ---
> drivers/net/ethernet/faraday/ftgmac100.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
> b/drivers/net/ethernet/faraday/ftgmac100.c
>
On Tue, 20 Oct 2020 at 06:23, Benjamin Herrenschmidt
wrote:
>
> On Tue, 2020-10-20 at 04:13 +, Joel Stanley wrote:
> > On Mon, 19 Oct 2020 at 23:20, Benjamin Herrenschmidt
> > wrote:
> > >
> > > On Mon, 2020-10-19 at 16:57 +0800, Dylan Hung wrote:
>
+0x2dc/0x300
[ 67.046123] NETDEV WATCHDOG: eth2 (ftgmac100): transmit queue 0 timed out
Fixes: 52c0cae87465 ("ftgmac100: Remove tx descriptor accessors")
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday/ftgmac100.c | 10 ++
1 file changed, 10 insertions(+)
di
On Wed, 21 Oct 2020 at 00:00, Benjamin Herrenschmidt
wrote:
>
> On Wed, 2020-10-21 at 08:36 +1030, Joel Stanley wrote:
> > We must ensure the tx descriptor updates are visible before updating
> > the tx pointer.
> >
> > This resolves the tx hangs observed on the 2
On Wed, 21 Oct 2020 at 12:40, Arnd Bergmann wrote:
>
> On Wed, Oct 21, 2020 at 12:39 PM Joel Stanley wrote:
>
> >
> > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
> > b/drivers/net/ethernet/faraday/ftgmac100.c
> > index 331d4bdd4a67..15cdfeb135b0 1006
On Mon, 26 Oct 2020 at 22:22, Benjamin Herrenschmidt
wrote:
>
> On Fri, 2020-10-23 at 13:08 +, Dylan Hung wrote:
> > The issue was found on our test chip (ast2600 version A0) which is
> > just for testing and won't be mass-produced. This HW bug has been
> > fixed on ast2600 A1 and later versi
On Thu, 22 Oct 2020 at 07:41, Benjamin Herrenschmidt
wrote:
>
> On Wed, 2020-10-21 at 14:40 +0200, Arnd Bergmann wrote:
> > On Wed, Oct 21, 2020 at 12:39 PM Joel Stanley wrote:
> >
> > >
> > > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
> > &g
On Tue, 20 Oct 2020 at 04:14, Joel Stanley wrote:
>
> On Mon, 19 Oct 2020 at 08:57, Dylan Hung wrote:
> >
> > The interrupt handler may set the flag to reset the mac in the future,
> > but that flag is not cleared once the reset has occured.
> >
> > Fixes: 1
iewed-by: Joel Stanley
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday/ftgmac100.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
b/drivers/net/ethernet/faraday/ftgmac100.c
index 88bfe2107938..04421aec2dfd 100644
--- a/drivers/net/et
According to the ASPEED datasheet, gigabit speeds require a clock of
100MHz or higher. Other speeds require 25MHz or higher.
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday/ftgmac100.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/net/ethernet
On Tue, Oct 10, 2017 at 2:34 PM, Florian Fainelli wrote:
>
>
> On 10/09/2017 09:49 PM, Joel Stanley wrote:
>> According to the ASPEED datasheet, gigabit speeds require a clock of
>> 100MHz or higher. Other speeds require 25MHz or higher.
>>
>> Signed-off-by: Jo
On Tue, Oct 10, 2017 at 4:14 PM, Benjamin Herrenschmidt
wrote:
> On Tue, 2017-10-10 at 15:19 +1030, Joel Stanley wrote:
>> According to the ASPEED datasheet, gigabit speeds require a clock of
>> 100MHz or higher. Other speeds require 25MHz or higher.
>
> Did you try &quo
other upstream users of the FTGMAC100 driver so it
is hard to know the clocking requirements of other platforms. Therefore
a conservative approach was taken with enabling clocks. If the platform
is not ASPEED, both requesting the clock and configuring the speed is
skipped.
Signed-off-by: Joel Stanley
other upstream users of the FTGMAC100 driver it is
hard to know the clocking requirements of other platforms. Therefore a
conservative approach was taken with enabling clocks. If the platform is
not ASPEED, both requesting the clock and configuring the speed is
skipped.
Signed-off-by: Joel Stanley
. misbehaving network device firmware, but we do not need them
filling up the kernel logs in normal operation.
Acked-by: Samuel Mendoza-Jonas
Signed-off-by: Joel Stanley
---
v2: Fix alignment in ftgmac100 change
---
drivers/net/ethernet/faraday/ftgmac100.c | 4 ++--
net/ncsi/ncsi-aen.c
v2:
Fix indent issue and commit message based on Joe's feedback
Add Sam's acks
Here are three changes to silence unnecessary warnings in the ncsi code.
The final patch adds Sam as the maintainer for NCSI.
Joel Stanley (4):
net/ncsi: Silence debug messages
net/ncsi: Drop no mor
Sam has been handing the maintenance of NCSI for a number release cycles
now.
Acked-by: Samuel Mendoza-Jonas
Signed-off-by: Joel Stanley
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9d5eeff51b5f..44851f7c46fc 100644
--- a/MAINTAINERS
This does not provide useful information. As the ncsi maintainer said:
> either we get a channel or broadcom has gone out to lunch
Acked-by: Samuel Mendoza-Jonas
Signed-off-by: Joel Stanley
---
net/ncsi/ncsi-manage.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/ncsi/ncsi-manag
etdev_dbg is enabled
> via the dynamic debug control file.
Which is what we're after in this case.
Acked-by: Samuel Mendoza-Jonas
Signed-off-by: Joel Stanley
---
v2: update commit message
net/ncsi/ncsi-aen.c| 6 +++---
net/ncsi/ncsi-manage.c | 33 +++--
Sam has been handing the maintenance of NCSI for a number release cycles
now.
Signed-off-by: Joel Stanley
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9d5eeff51b5f..44851f7c46fc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9756,6
This does not provide useful information. As the ncsi maintainer said:
> either we get a channel or broadcom has gone out to lunch
Signed-off-by: Joel Stanley
---
net/ncsi/ncsi-manage.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c
in
. misbehaving network device firmware, but we do not need them
filling up the kernel logs in normal operation.
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday/ftgmac100.c | 2 +-
net/ncsi/ncsi-aen.c | 4 ++--
net/ncsi/ncsi-manage.c | 14
Here are three changes to silence unnecessary warnings in the ncsi code.
The final patch adds Sam as the maintainer for NCSI.
Joel Stanley (4):
net/ncsi: Silence debug messages
net/ncsi: Drop no more channels message
net/ncsi: Use netdev_dbg for debug messages
MAINTAINERS: Add Sam as the
This moves all of the netdev_printk(KERN_DEBUG, ...) messages over to
netdev_dbg. There is no change in behaviour.
Signed-off-by: Joel Stanley
---
net/ncsi/ncsi-aen.c| 6 +++---
net/ncsi/ncsi-manage.c | 33 +++--
2 files changed, 18 insertions(+), 21 deletions
Hi Ivan,
On Tue, 13 Oct 2020 at 12:38, Ivan Mikhaylov wrote:
>
> phy-handle can't be handled well for ast2400/2500 which has an embedded
> MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize
> PHYs from mdio child node with of_mdiobus_register.
Good idea. The driver has bec
can put:
Fixes: 39bfab8844a0 ("net: ftgmac100: Add support for DT phy-handle property")
Reviewed-by: Joel Stanley
> ---
> drivers/net/ethernet/faraday/ftgmac100.c | 5 +
> drivers/net/ethernet/faraday/ftgmac100.h | 8
> 2 files changed, 13 insertions(+)
>
>
On Wed, 14 Oct 2020 at 13:32, Dylan Hung wrote:
> > > The new HW arbitration feature on Aspeed ast2600 will cause MAC TX to
> > > hang when handling scatter-gather DMA. Disable the problematic
> > > feature by setting MAC register 0x58 bit28 and bit27.
> >
> > Hi Dylan,
> >
> > What are the sympt
On Thu, 15 Oct 2020 at 01:49, Dylan Hung wrote:
> > > I was encountering this issue when I was running the iperf TX test. The
> > symptom is the TX descriptors are consumed, but no complete packet is sent
> > out.
> >
> > What parameters are you using for iperf? I did a lot of testing with
> > ip
On Thu, 27 Sep 2018 at 00:39, wrote:
>
> > > As I understand Justin's version adds a generic handler, using the NCSI
> > > Netlink interface to pass OEM commands and responses to and from
> > > userspace, which does the actual packet handling.
> > Thanks for the direction Sam! Justin, if you do
Looks like this was mistakenly added to the tree as part of
commit 186b3c998c50 ("virtio-net: support XDP_REDIRECT").
Signed-off-by: Joel Stanley
---
drivers/net/virtio_net. | 0
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 drivers/net/virtio_net.
diff --git
200us.
>
> Signed-off-by: Benjamin Herrenschmidt
I gave this a spin on the problematic hardware, as well as a few other
machines. Looks good, thanks Ben.
Tested-by: Joel Stanley
Cheers,
Joel
> ---
> drivers/net/ethernet/faraday/ftgmac100.c | 2 +-
> 1 file changed, 1 insertion(+)
On Mon, Jul 24, 2017 at 4:29 PM, Benjamin Herrenschmidt
wrote:
> Populate mii_bus->parent with our own platform device before
> registering, which makes it easier to locate the MDIO bus
> in sysfs when trying to diagnose problems.
>
> Signed-off-by: Benjamin Herrenschmidt
Acke
iced, I do have a bug not returning the error.
Acked-by: Benjamin Herrenschmidt
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday/ftgmac100.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
b/drivers/net/ethernet
On Mon, Aug 14, 2017 at 10:59 AM, Samuel Mendoza-Jonas
wrote:
> Make use of the ndo_vlan_rx_{add,kill}_vid callbacks to have the NCSI
> stack process new VLAN tags and configure the channel VLAN filter
> appropriately.
> Several VLAN tags can be set and a "Set VLAN Filter" packet must be sent
> fo
o be gone over, there's a few command/response code paths that are
> never triggered and could be broken in similar ways.
So we're okay here.
> Signed-off-by: Samuel Mendoza-Jonas
Reviewed-by: Joel Stanley
Cheers,
Joel
> ---
> v2: Rebased on latest net-next
>
> net/n
t; filter in that case (we do have HW vlan tag extraction and injection,
> which my driver supports, but that's different flags).
Reviewed-by: Joel Stanley
> ---
> v2: Moved ftgmac100 change into same patch and reordered
>
> drivers/net/ethernet/faraday/ftgmac100.c | 5 +
&g
cit includes.
>
> Signed-off-by: Mark Brown
Acked-by: Joel Stanley
Thank you for fixing this Mark.
Cheers,
Joel
> ---
> drivers/net/ethernet/faraday/ftgmac100.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
> b/dr
This device is a single-port RGMII 10/100/1000BASE-T PHY with EEE & WOL.
Signed-off-by: Joel Stanley
---
drivers/net/phy/broadcom.c | 13 +
include/linux/brcmphy.h| 2 ++
2 files changed, 15 insertions(+)
diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadc
On Wed, Apr 5, 2017 at 3:17 PM, Florian Fainelli wrote:
>
>
> On 04/04/2017 10:33 PM, Joel Stanley wrote:
>> This device is a single-port RGMII 10/100/1000BASE-T PHY with EEE & WOL.
>
> This looks good, although Rafal did beat you to it:
>
> 0fc9ae107669760c2a86
On Sat, Oct 22, 2016 at 3:50 AM, Xo Wang wrote:
> This PHY has internal delays enabled after reset. This clears the
> internal delay enables unless the interface specifically requests them.
>
> Signed-off-by: Xo Wang
Reviewed-by: Joel Stanley
Cheers,
Joel
> ---
> drivers/
On Sat, Oct 22, 2016 at 3:50 AM, Xo Wang wrote:
> Add the RXD-to-RXC skew (delay) time bit in the Miscellaneous Control
> shadow register and a mask for the shadow selector field.
>
> Remove a re-definition of MII_BCM54XX_AUXCTL_SHDWSEL_AUXCTL.
>
> Signed-off-by: Xo Wang
NCSI stack and
with a directly attached PHY.
Cheers,
Joel
Andrew Jeffery (2):
net/ftgmac100: Separate rx page storage from rxdesc
net/ftgmac100: Make EDO{R,T}R bits configurable
Gavin Shan (2):
net/faraday: Avoid PHYSTS_CHG interrupt
net/faraday: Clear stale interrupts
Joel Stanley (3
From: Andrew Jeffery
These bits are #defined at a fixed location. In order to support future
hardware that has chosen to move these bits around move the bits into a
member of the struct ftgmac100.
Signed-off-by: Andrew Jeffery
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday
PHYSTS_CHG interrupt, as it helps keep us safe from unhygienic
(vendor) bootloaders.
Cheers,
Joel
Andrew Jeffery (2):
net/faraday: Separate rx page storage from rxdesc
net/faraday: Make EDO{R,T}R bits configurable
Gavin Shan (1):
net/faraday: Clear stale interrupts
Joel Stanley (3):
n
Shan
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday/ftgmac100.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
b/drivers/net/ethernet/faraday/ftgmac100.c
index 47f512224b57..189373743ddf 100644
--- a/drivers/net/ethernet/faraday/ftgmac
The Aspeed SoCs have a new MDIO interface as an option in the G4 and G5
SoCs. The old one is still available, so select it in order to remain
compatible with the ftgmac100 driver.
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday/ftgmac100.c | 9 +
drivers/net/ethernet
marked as reserved but still functional. In the ast2500 this bit is
reused for another function, so we need a work around.
This was confirmed with engineers from Aspeed that using bit 30 is
correct for both the ast2400 and ast2500 SoCs.
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday
more discussion.
Signed-off-by: Joel Stanley
---
v2:
- Reworked to mask out PHYSTS_CHG instead of trying to determine the IRQ line
level
drivers/net/ethernet/faraday/ftgmac100.c | 10 +++---
drivers/net/ethernet/faraday/ftgmac100.h | 1 +
2 files changed, 4 insertions(+), 7 deletions(-)
: Andrew Jeffery
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday/ftgmac100.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
b/drivers/net/ethernet/faraday/ftgmac100.c
index 36361f8bf894
Please ignore this one.
On Thu, Sep 22, 2016 at 8:33 AM, Joel Stanley wrote:
> Hello Dave,
>
> This series adds support to the ftgmac100 driver for the Aspeed ast2400 and
> ast2500 SoCs. In particular, they ensure the driver works correctly on the
> ast2500 where the MAC bloc
On Fri, Oct 14, 2016 at 1:23 PM, Gavin Shan wrote:
> The issue was found on BCM5718 which has two NCSI channels in one
> package: C0 and C1. C0 is in link-up state while C1 is in link-down
> state. C0 is chosen as active channel until unplugging and plugging
> C0's cable: On unplugging C0's cable
On Fri, Oct 14, 2016 at 1:23 PM, Gavin Shan wrote:
> The issue was found on BCM5718 which has two NCSI channels in one
> package: C0 and C1. Both of them are connected to different LANs,
> means they are in link-up state and C0 is chosen as the active
> one until resetting BCM5718 happens as belo
Hi Gavin,
On Fri, Oct 14, 2016 at 1:23 PM, Gavin Shan wrote:
> This splits out the code that handles ncsi_dev_state_suspend_select
> so that we can add more code to the handler in subsequent patch.
> Apart from adding a error tag to reuse the code in error path,
> no logical changes introduced.
>
The Aspeed SoCs have a new MDIO interface as an option in the G4 and G5
SoCs. The old one is still available, so select it in order to remain
compatible with the ftgmac100 driver.
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday/ftgmac100.c | 9 +
drivers/net/ethernet
: [ISR] = 0x200: PHYSTS_CHG
[ 20.30] ftgmac100 1e66.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG
This is because the driver was enabling low-level sensitive interrupt
generation where the systems are wired for high-level. All CPU cycles
are spent servicing this interrupt.
Signed-off-by: Joel
marked as reserved but still functional. In the ast2500 this bit is
reused for another function, so we need a work around.
This was confirmed with engineers from Aspeed that using bit 30 is
correct for both the ast2400 and ast2500 SoCs.
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday
Shan
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday/ftgmac100.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
b/drivers/net/ethernet/faraday/ftgmac100.c
index f2ea6c2f1fbd..7ba0f2d58a8b 100644
--- a/drivers/net/ethernet/faraday/ftgmac
wasted
to process the false alarm.
This sets bit#11 in MACCR (0x50) to avoid the bogus interrupt.
Signed-off-by: Gavin Shan
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday/ftgmac100.c | 1 +
drivers/net/ethernet/faraday/ftgmac100.h | 1 +
2 files changed, 2 insertions(+)
diff --git
: Andrew Jeffery
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday/ftgmac100.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
b/drivers/net/ethernet/faraday/ftgmac100.c
index 36361f8bf894
From: Andrew Jeffery
These bits are #defined at a fixed location. In order to support future
hardware that has chosen to move these bits around move the bits into a
member of the struct ftgmac100.
Signed-off-by: Andrew Jeffery
Signed-off-by: Joel Stanley
---
drivers/net/ethernet/faraday
NCSI stack and
with a directly attached PHY.
Cheers,
Joel
Andrew Jeffery (2):
net/ftgmac100: Separate rx page storage from rxdesc
net/ftgmac100: Make EDO{R,T}R bits configurable
Gavin Shan (2):
net/faraday: Avoid PHYSTS_CHG interrupt
net/faraday: Clear stale interrupts
Joel Stanley (3
On Wed, Sep 21, 2016 at 12:59 AM, Andrew Lunn wrote:
> On Tue, Sep 20, 2016 at 10:13:14PM +1000, Benjamin Herrenschmidt wrote:
>> On Tue, 2016-09-20 at 16:00 +0930, Joel Stanley wrote:
>> > On Aspeed SoC with a direct PHY connection (non-NSCI), we receive
>> >
On Wed, Sep 21, 2016 at 6:33 PM, Benjamin Herrenschmidt
wrote:
> On Wed, 2016-09-21 at 11:32 +0930, Joel Stanley wrote:
>> I had a look at the eval board schematic and it appears that the line
>> has pull down resistors on it, explaining why the IRQ fires when it's
>>
75 matches
Mail list logo
