Re: [PATCH] net: Reduce skb_warn_bad_offload() noise.

2017-08-09 Thread Tonghao Zhang
Thanks, I send a patch, which will revert commit 6e7bc478c9a0 in net-next. On Wed, Aug 9, 2017 at 1:46 AM, Willem de Bruijn wrote: >>> @@ -2670,6 +2670,7 @@ static inline bool skb_needs_check(struct >>> sk_buff *skb, bool tx_path) >>> { >>> if (tx_path)

Re: [PATCH] net: Reduce skb_warn_bad_offload() noise.

2017-08-08 Thread Willem de Bruijn
>> @@ -2670,6 +2670,7 @@ static inline bool skb_needs_check(struct >> sk_buff *skb, bool tx_path) >> { >> if (tx_path) >> return skb->ip_summed != CHECKSUM_PARTIAL && >> + skb->ip_summed != CHECKSUM_UNNECESSARY && >>

Re: [PATCH] net: Reduce skb_warn_bad_offload() noise.

2017-08-08 Thread Willem de Bruijn
> In a case, there is also warn info. The test topo is shown as below. Thanks for testing the patch, Tonghao. > The warn info is shown as below [1]. If we change the CHECKSUM_NONE to > CHECKSUM_UNNECESSARY in the udp4_ufo_fragment(). > and we should add a check in skb_needs_check() when

Re: [PATCH] net: Reduce skb_warn_bad_offload() noise.

2017-08-07 Thread Tonghao Zhang
Hi Willem In a case, there is also warn info. The test topo is shown as below. VM01: veth1 and eth0 in the VM01 are inserted to ovs br0. veth0(IP: 172.16.34.100/24) —— veth1--br0--eth0 iperf3 -c 172.168.100.13 -i 1 -P 10 -t 10 -u -b 1000M -l 10K VM02 eth0(IP: 172.16.34.200/24) iperf3 -s

Re: [PATCH] net: Reduce skb_warn_bad_offload() noise.

2017-08-07 Thread Tonghao Zhang
That is fine to me. I have tested it. Thanks. On Mon, Aug 7, 2017 at 12:42 PM, Willem de Bruijn wrote: >> The openvswitch kernel module calls the __skb_gso_segment()(and sets >> tx_path = false) when passing packets to userspace. The UFO will set >> the ip_summed

Re: [PATCH] net: Reduce skb_warn_bad_offload() noise.

2017-08-06 Thread Willem de Bruijn
> The openvswitch kernel module calls the __skb_gso_segment()(and sets > tx_path = false) when passing packets to userspace. The UFO will set > the ip_summed to CHECKSUM_NONE. There are a lot of warn logs. The warn > log is shown as below. I guess we should revert the patch. Indeed, the software

Re: [PATCH] net: Reduce skb_warn_bad_offload() noise.

2017-08-06 Thread Tonghao Zhang
On Fri, Aug 4, 2017 at 9:29 PM, Eric Dumazet wrote: > On Fri, 2017-08-04 at 06:11 -0700, Tonghao Zhang wrote: >> This patch will revert the b2504a5dbe "net: reduce >> skb_warn_bad_offload() noise". The ovs will call the >> __skb_gso_segment() with tx false. When segmenting

Re: [PATCH] net: Reduce skb_warn_bad_offload() noise.

2017-08-04 Thread Eric Dumazet
On Fri, 2017-08-04 at 06:11 -0700, Tonghao Zhang wrote: > This patch will revert the b2504a5dbe "net: reduce > skb_warn_bad_offload() noise". The ovs will call the > __skb_gso_segment() with tx false. When segmenting UDP with UFO, > the __skb_gso_segment raises a warning as below [1], because the

[PATCH] net: Reduce skb_warn_bad_offload() noise.

2017-08-04 Thread Tonghao Zhang
This patch will revert the b2504a5dbe "net: reduce skb_warn_bad_offload() noise". The ovs will call the __skb_gso_segment() with tx false. When segmenting UDP with UFO, the __skb_gso_segment raises a warning as below [1], because the ip_summed is CHECKSUM_NONE. While the net-next has removed the