Re: [PATCH RFC] net: stmmac: unify registers dumps methods

2017-02-21 Thread Giuseppe CAVALLARO
On 2/20/2017 2:44 PM, Corentin Labbe wrote: The stmmac driver have two methods for registers dumps: via ethtool and at init (if NETIF_MSG_HW is enabled). It is better to keep only one method, ethtool, since the other was ugly. This patch convert all dump_regs() function from "printing regs" to

[PATCH RFC] net: stmmac: unify registers dumps methods

2017-02-20 Thread Corentin Labbe
The stmmac driver have two methods for registers dumps: via ethtool and at init (if NETIF_MSG_HW is enabled). It is better to keep only one method, ethtool, since the other was ugly. This patch convert all dump_regs() function from "printing regs" to "fill the reg_space used by ethtool".

[PATCH RFC] net: stmmac: unify registers dumps methods

2017-02-20 Thread Corentin Labbe
hello The following patch address the problem that two way of dumping registers are available in stmmac, via ethtool and directly at init (if NETIF_MSG_HW is enabled). It is better to keep only one method, ethtool, since the other was ugly (logs of pr_xxx). But by working on this issue, I saw