Re: [PATCH net] net: rtnl_register in net_ns_init need rtnl_lock

2016-09-22 Thread Hannes Frederic Sowa
On Thu, Sep 22, 2016, at 19:20, Cong Wang wrote: > > I don't think it is a big issue but wanted the writes to the > > rtnl_msg_handlers array to be strictly serialized. I was working on > > adding this to other places, too. Maybe better for net-next even? > > But they are called during boot, why i

Re: [PATCH net] net: rtnl_register in net_ns_init need rtnl_lock

2016-09-22 Thread Cong Wang
On Thu, Sep 22, 2016 at 6:41 AM, Hannes Frederic Sowa wrote: > On 22.09.2016 15:03, Eric Dumazet wrote: >> On Thu, 2016-09-22 at 13:03 +0200, Hannes Frederic Sowa wrote: >>> Signed-off-by: Hannes Frederic Sowa >>> --- >>> net/core/net_namespace.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >

Re: [PATCH net] net: rtnl_register in net_ns_init need rtnl_lock

2016-09-22 Thread Eric Dumazet
On Thu, 2016-09-22 at 15:41 +0200, Hannes Frederic Sowa wrote: > I found this during working on the file and actually saw no live issues > (belonged to another series which I just split up). > > I don't think it is a big issue but wanted the writes to the > rtnl_msg_handlers array to be strictly

Re: [PATCH net] net: rtnl_register in net_ns_init need rtnl_lock

2016-09-22 Thread Hannes Frederic Sowa
On 22.09.2016 15:03, Eric Dumazet wrote: > On Thu, 2016-09-22 at 13:03 +0200, Hannes Frederic Sowa wrote: >> Signed-off-by: Hannes Frederic Sowa >> --- >> net/core/net_namespace.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c >>

Re: [PATCH net] net: rtnl_register in net_ns_init need rtnl_lock

2016-09-22 Thread Eric Dumazet
On Thu, 2016-09-22 at 13:03 +0200, Hannes Frederic Sowa wrote: > Signed-off-by: Hannes Frederic Sowa > --- > net/core/net_namespace.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c > index 2c2eb1b629b11d..a2ace299f28355 100644 > ---

[PATCH net] net: rtnl_register in net_ns_init need rtnl_lock

2016-09-22 Thread Hannes Frederic Sowa
Signed-off-by: Hannes Frederic Sowa --- net/core/net_namespace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index 2c2eb1b629b11d..a2ace299f28355 100644 --- a/net/core/net_namespace.c +++ b/net/core/net_namespace.c @@ -758,9 +758,11 @@