Re: [PATCH net-next 0/6] ibmvnic: Update TX pool and TX routines
On 03/14/2018 01:03 PM, David Miller wrote: > From: Thomas Falcon > Date: Tue, 13 Mar 2018 19:34:17 -0500 > >> This patch restructures the TX pool data structure and provides a >> separate TX pool array for TSO transmissions. This is already used >> in some way due to our unique DMA situation, namely that we cannot >> use single DMA mappings for packet data. Previously, both buffer >> arrays used the same pool entry. This restructuring allows for >> some additional cleanup in the driver code, especially in some >> places in the device transmit routine. >> >> In addition, it allows us to more easily track the consumer >> and producer indexes of a particular pool. This has been >> further improved by better tracking of in-use buffers to >> prevent possible data corruption in case an invalid buffer >> entry is used. > ... >> ibmvnic: Update release RX pool routine > I think you need to fix up this Subject line to say TX instead > of RX. > > Thanks. > Drat, I missed that. I'll send another version shortly. Thanks.
Re: [PATCH net-next 0/6] ibmvnic: Update TX pool and TX routines
From: Thomas Falcon Date: Tue, 13 Mar 2018 19:34:17 -0500 > This patch restructures the TX pool data structure and provides a > separate TX pool array for TSO transmissions. This is already used > in some way due to our unique DMA situation, namely that we cannot > use single DMA mappings for packet data. Previously, both buffer > arrays used the same pool entry. This restructuring allows for > some additional cleanup in the driver code, especially in some > places in the device transmit routine. > > In addition, it allows us to more easily track the consumer > and producer indexes of a particular pool. This has been > further improved by better tracking of in-use buffers to > prevent possible data corruption in case an invalid buffer > entry is used. ... > ibmvnic: Update release RX pool routine I think you need to fix up this Subject line to say TX instead of RX. Thanks.
[PATCH net-next 0/6] ibmvnic: Update TX pool and TX routines
This patch restructures the TX pool data structure and provides a separate TX pool array for TSO transmissions. This is already used in some way due to our unique DMA situation, namely that we cannot use single DMA mappings for packet data. Previously, both buffer arrays used the same pool entry. This restructuring allows for some additional cleanup in the driver code, especially in some places in the device transmit routine. In addition, it allows us to more easily track the consumer and producer indexes of a particular pool. This has been further improved by better tracking of in-use buffers to prevent possible data corruption in case an invalid buffer entry is used. Thomas Falcon (6): ibmvnic: Generalize TX pool structure ibmvnic: Update and clean up reset TX pool routine ibmvnic: Update release RX pool routine ibmvnic: Update TX pool initialization routine ibmvnic: Update TX and TX completion routines ibmvnic: Improve TX buffer accounting drivers/net/ethernet/ibm/ibmvnic.c | 235 + drivers/net/ethernet/ibm/ibmvnic.h | 8 +- 2 files changed, 136 insertions(+), 107 deletions(-) -- 1.8.3.1
