Re: [PATCH] tcp_input: move out condition check from tcp_data_queue()

2017-08-06 Thread Eric Dumazet
On Sun, 2017-08-06 at 21:57 +0400, Ilya Matveychikov wrote: > > On Aug 6, 2017, at 9:07 PM, Eric Dumazet wrote: > > > > On Sun, 2017-08-06 at 13:51 +0400, Ilya Matveychikov wrote: > >> As tcp_data_queue() function is used just only twice it's better > >> to move out the

Re: [PATCH] tcp_input: move out condition check from tcp_data_queue()

2017-08-06 Thread Ilya Matveychikov
> On Aug 6, 2017, at 9:07 PM, Eric Dumazet wrote: > > On Sun, 2017-08-06 at 13:51 +0400, Ilya Matveychikov wrote: >> As tcp_data_queue() function is used just only twice it's better >> to move out the first check and wrap it with inline. It saves a >> single call in case

Re: [PATCH] tcp_input: move out condition check from tcp_data_queue()

2017-08-06 Thread Eric Dumazet
On Sun, 2017-08-06 at 13:51 +0400, Ilya Matveychikov wrote: > As tcp_data_queue() function is used just only twice it's better > to move out the first check and wrap it with inline. It saves a > single call in case the condition evaluated as true. > > Signed-off-by: Ilya V. Matveychikov