Re: [PATCH net-next 05/10] bnxt_en: Fix ethtool -l|-L inconsistent channel counts.

2016-09-19 Thread Michael Chan
On Mon, Sep 19, 2016 at 2:51 AM, Mintz, Yuval wrote: >> >> If the user chooses 2 rx and 1 tx, he will use 3 msix vectors (3 completion >> rings, >> etc). If the user chooses 2 combined (1 with rx/tx, >> 1 with rx only), he will use 2 msix vectors (2 completion rings,

RE: [PATCH net-next 05/10] bnxt_en: Fix ethtool -l|-L inconsistent channel counts.

2016-09-19 Thread Mintz, Yuval
> >> The existing code is inconsistent in reporting and accepting the > >> combined channel count. bnxt_get_channels() reports maximum combined > >> as the maximum rx count. bnxt_set_channels() accepts combined count > >> that cannot be bigger than max rx or max tx. > >> > >> For example, if max

RE: [PATCH net-next 05/10] bnxt_en: Fix ethtool -l|-L inconsistent channel counts.

2016-09-19 Thread Mintz, Yuval
> >> >> The existing code is inconsistent in reporting and accepting the > >> >> combined channel count. bnxt_get_channels() reports maximum > >> >> combined as the maximum rx count. bnxt_set_channels() accepts > >> >> combined count that cannot be bigger than max rx or max tx. > >> >> > >> >>

Re: [PATCH net-next 05/10] bnxt_en: Fix ethtool -l|-L inconsistent channel counts.

2016-09-19 Thread Michael Chan
On Mon, Sep 19, 2016 at 2:21 AM, Mintz, Yuval wrote: >> >> The existing code is inconsistent in reporting and accepting the >> >> combined channel count. bnxt_get_channels() reports maximum combined >> >> as the maximum rx count. bnxt_set_channels() accepts combined

Re: [PATCH net-next 05/10] bnxt_en: Fix ethtool -l|-L inconsistent channel counts.

2016-09-19 Thread Michael Chan
On Mon, Sep 19, 2016 at 1:33 AM, Mintz, Yuval wrote: >> The existing code is inconsistent in reporting and accepting the combined >> channel count. bnxt_get_channels() reports maximum combined as the >> maximum rx count. bnxt_set_channels() accepts combined count that

RE: [PATCH net-next 05/10] bnxt_en: Fix ethtool -l|-L inconsistent channel counts.

2016-09-19 Thread Mintz, Yuval
> The existing code is inconsistent in reporting and accepting the combined > channel count. bnxt_get_channels() reports maximum combined as the > maximum rx count. bnxt_set_channels() accepts combined count that cannot be > bigger than max rx or max tx. > > For example, if max rx = 2 and max