Re: [PATCH v3 01/11] net: phy: Add rockchip phy driver support

2017-08-09 Thread David.Wu
Hi Andrew, 在 2017/8/2 21:21, Andrew Lunn 写道: +static struct phy_driver rockchip_phy_driver[] = { +{ + .phy_id = 0x1234d400, + .phy_id_mask= 0xfff0, + .name = "Rockchip internal EPHY", + .features =

Re: [PATCH v3 01/11] net: phy: Add rockchip phy driver support

2017-08-02 Thread Andrew Lunn
> +static struct phy_driver rockchip_phy_driver[] = { > +{ > + .phy_id = 0x1234d400, > + .phy_id_mask= 0xfff0, > + .name = "Rockchip internal EPHY", > + .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause > +

Re: [PATCH v3 01/11] net: phy: Add rockchip phy driver support

2017-08-02 Thread Corentin Labbe
Hello I have some minor comment below > + > +#include > +#include > +#include > +#include > +#include > +#include in alphabetic order please [...] > +static int rockchip_init_tstmode(struct phy_device *phydev) > +{ > + int ret; > + > + /* Enable access to Analog and DSP register