Re: [RFC PATCH] net: don't set __LINK_STATE_START until after dev->open() call

2017-08-09 Thread David Miller
From: "Keller, Jacob E" Date: Wed, 9 Aug 2017 20:00:55 + > That's what I am worried about. However, I think there are problems > with leaving it. A lot of drivers rely on netif_running() to > determine whether or not the device is open, but they may be using > it

RE: [RFC PATCH] net: don't set __LINK_STATE_START until after dev->open() call

2017-08-09 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of David Miller > Sent: Tuesday, August 08, 2017 6:17 PM > To: Keller, Jacob E <jacob.e.kel...@intel.com> > Cc: netdev@vger.kernel.org > Subject: Re:

Re: [RFC PATCH] net: don't set __LINK_STATE_START until after dev->open() call

2017-08-08 Thread David Miller
From: Jacob Keller Date: Mon, 7 Aug 2017 15:24:21 -0700 > Fix an issue with relying on netif_running() which could be true during > when dev->open() handler is being called, even if it would exit with > a failure. This ensures the state does not get set and removed