Re: [bpf-next PATCH v2 05/18] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data

2018-03-16 Thread John Fastabend
On 03/15/2018 05:37 PM, Daniel Borkmann wrote: > On 03/16/2018 12:06 AM, Alexei Starovoitov wrote: >> On Thu, Mar 15, 2018 at 11:55:39PM +0100, Daniel Borkmann wrote: >>> On 03/15/2018 11:20 PM, Alexei Starovoitov wrote: On Thu, Mar 15, 2018 at 11:17:12PM +0100, Daniel Borkmann wrote: >

Re: [bpf-next PATCH v2 05/18] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data

2018-03-15 Thread Daniel Borkmann
On 03/16/2018 12:06 AM, Alexei Starovoitov wrote: > On Thu, Mar 15, 2018 at 11:55:39PM +0100, Daniel Borkmann wrote: >> On 03/15/2018 11:20 PM, Alexei Starovoitov wrote: >>> On Thu, Mar 15, 2018 at 11:17:12PM +0100, Daniel Borkmann wrote: On 03/15/2018 10:59 PM, Alexei Starovoitov wrote:

Re: [bpf-next PATCH v2 05/18] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data

2018-03-15 Thread Alexei Starovoitov
On Thu, Mar 15, 2018 at 11:55:39PM +0100, Daniel Borkmann wrote: > On 03/15/2018 11:20 PM, Alexei Starovoitov wrote: > > On Thu, Mar 15, 2018 at 11:17:12PM +0100, Daniel Borkmann wrote: > >> On 03/15/2018 10:59 PM, Alexei Starovoitov wrote: > >>> On Mon, Mar 12, 2018 at 12:23:29PM -0700, John

Re: [bpf-next PATCH v2 05/18] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data

2018-03-15 Thread Daniel Borkmann
On 03/15/2018 11:20 PM, Alexei Starovoitov wrote: > On Thu, Mar 15, 2018 at 11:17:12PM +0100, Daniel Borkmann wrote: >> On 03/15/2018 10:59 PM, Alexei Starovoitov wrote: >>> On Mon, Mar 12, 2018 at 12:23:29PM -0700, John Fastabend wrote: +/* User return codes for SK_MSG prog type. */

Re: [bpf-next PATCH v2 05/18] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data

2018-03-15 Thread Alexei Starovoitov
On Thu, Mar 15, 2018 at 11:17:12PM +0100, Daniel Borkmann wrote: > On 03/15/2018 10:59 PM, Alexei Starovoitov wrote: > > On Mon, Mar 12, 2018 at 12:23:29PM -0700, John Fastabend wrote: > >> > >> +/* User return codes for SK_MSG prog type. */ > >> +enum sk_msg_action { > >> + SK_MSG_DROP = 0, >

Re: [bpf-next PATCH v2 05/18] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data

2018-03-15 Thread Daniel Borkmann
On 03/15/2018 10:59 PM, Alexei Starovoitov wrote: > On Mon, Mar 12, 2018 at 12:23:29PM -0700, John Fastabend wrote: >> >> +/* User return codes for SK_MSG prog type. */ >> +enum sk_msg_action { >> +SK_MSG_DROP = 0, >> +SK_MSG_PASS, >> +}; > > do we really need new enum here? > It's the

Re: [bpf-next PATCH v2 05/18] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data

2018-03-15 Thread John Fastabend
On 03/15/2018 02:59 PM, Alexei Starovoitov wrote: > On Mon, Mar 12, 2018 at 12:23:29PM -0700, John Fastabend wrote: >> >> +/* User return codes for SK_MSG prog type. */ >> +enum sk_msg_action { >> +SK_MSG_DROP = 0, >> +SK_MSG_PASS, >> +}; > > do we really need new enum here? Nope and

Re: [bpf-next PATCH v2 05/18] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data

2018-03-15 Thread Alexei Starovoitov
On Mon, Mar 12, 2018 at 12:23:29PM -0700, John Fastabend wrote: > > +/* User return codes for SK_MSG prog type. */ > +enum sk_msg_action { > + SK_MSG_DROP = 0, > + SK_MSG_PASS, > +}; do we really need new enum here? It's the same as 'enum sk_action' and SK_DROP == SK_MSG_DROP and there

Re: [bpf-next PATCH v2 05/18] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data

2018-03-15 Thread David Miller
From: John Fastabend Date: Mon, 12 Mar 2018 12:23:29 -0700 > This implements a BPF ULP layer to allow policy enforcement and > monitoring at the socket layer. In order to support this a new > program type BPF_PROG_TYPE_SK_MSG is used to run the policy at > the