Re: question about UNDEFINE/REDEFINE

2018-02-13 Thread David Fabian
Hello Pablo, what do you think about this proposal? -- S pozdravem, David Fabian Cluster Design, s.r.o. Dne úterý 30. ledna 2018 12:05:48 CET, David Fabian napsal(a): > Hello Pablo, > > Dne pátek 26. ledna 2018 14:45:49 CET, Pablo Neira Ayuso napsal(a): > > 2) Probably even cleaner is to look

[PATCH] netfilter: ipt_ah: return boolean instead of integer

2018-02-13 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true/false instead of 1/0. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/ipv4/netfilter/ipt_ah.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/netfilter/ipt_

Re: Apply "netfilter: nf_queue: Make the queue_handler pernet" to 4.4-stable

2018-02-13 Thread Greg Kroah-Hartman
On Fri, Feb 09, 2018 at 04:19:06PM -0800, Eric Biggers wrote: > Hi Greg, can you please apply commit dc3ee32e96d7 ("netfilter: nf_queue: Make > the queue_handler pernet") to 4.4-stable? syzbot is hitting the crash in > nfqnl_nf_hook_drop() by interrupting thread creation in pg_net_init(). An OOM

[PATCH net] netfilter: nat: cope with negative port range

2018-02-13 Thread Paolo Abeni
syzbot reported a division by 0 bug in the netfilter nat code: divide error: [#1] SMP KASAN Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 1 PID: 4168 Comm: syzkaller034710 Not tainted 4.16.0-rc1+ #309 Hardware name: Google Google Compute Engine/Google Compute Engine

Re: [PATCH net] netfilter: nat: cope with negative port range

2018-02-13 Thread Florian Westphal
Paolo Abeni wrote: > Fixes: c7232c9979cb ("netfilter: add protocol independent NAT core") are you sure? When I looked this was a day 0 bug, the code was just moved from ipv4. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.k

Re: [PATCH net] netfilter: nat: cope with negative port range

2018-02-13 Thread Paolo Abeni
On Tue, 2018-02-13 at 18:02 +0100, Florian Westphal wrote: > Paolo Abeni wrote: > > Fixes: c7232c9979cb ("netfilter: add protocol independent NAT core") > > are you sure? > When I looked this was a day 0 bug, the code was just moved from ipv4. You are right, the named commit just move around the