Re: [netmod] YANG doctor review of draft-ietf-netmod-intf-ext-yang-04

2017-07-05 Thread Robert Wilton
Hi Andy, Thanks for this review, and sorry for the very slow reply. I believe that I have addressed most of your comments in the updated draft-ietf-netmod-intf-ext-yang-05 version. The only comment that I have not directly addressed relates to "identity ethSubInterface", and this is because

Re: [netmod] YANG doctor review of draft-ietf-netmod-intf-ext-yang-04

2017-04-11 Thread Martin Bjorklund
Ladislav Lhotka wrote: > Martin Bjorklund writes: > > > Robert Wilton wrote: > >> Hi Vladimir, all, > >> > >> > >> On 10/04/2017 17:19, Vladimir Vassilev wrote: > >> > Hello, > >> > > >> > On 04/06/2017 07:43 PM, Andy Bierman wrote: > >> >> > >> >> 3) identity ethSubInterface > >> >> > >> >>

Re: [netmod] YANG doctor review of draft-ietf-netmod-intf-ext-yang-04

2017-04-11 Thread Martin Bjorklund
Robert Wilton wrote: > Hi Vladimir, all, > > > On 10/04/2017 17:19, Vladimir Vassilev wrote: > > Hello, > > > > On 04/06/2017 07:43 PM, Andy Bierman wrote: > >> > >> 3) identity ethSubInterface > >> > >> This identity is used in the encapsulation container when-stmt. > >> It is not clear if this

Re: [netmod] YANG doctor review of draft-ietf-netmod-intf-ext-yang-04

2017-04-10 Thread Robert Wilton
Hi Vladimir, all, On 10/04/2017 17:19, Vladimir Vassilev wrote: Hello, On 04/06/2017 07:43 PM, Andy Bierman wrote: 3) identity ethSubInterface This identity is used in the encapsulation container when-stmt. It is not clear if this is intended as a base identity (like identity sub-interface

Re: [netmod] YANG doctor review of draft-ietf-netmod-intf-ext-yang-04

2017-04-10 Thread Vladimir Vassilev
Hello, On 04/06/2017 07:43 PM, Andy Bierman wrote: 3) identity ethSubInterface This identity is used in the encapsulation container when-stmt. It is not clear if this is intended as a base identity (like identity sub-interface) An example for the encapsulation container would help clarify th

[netmod] YANG doctor review of draft-ietf-netmod-intf-ext-yang-04

2017-04-06 Thread Andy Bierman
Overall: The document is well-written and almost ready for publication Comments: 1) No examples or guidance for "encaps-type" The document does not really define the standards value for this empty choice. There are no examples showing its use. More work is needed for this part of the module.