Re: [netmod] Structuring a DHCP module

2021-01-21 Thread Martin Björklund
Hi, I think it is a matter of taste and perhaps future extensibility if this model is done as one or more YANG modules. It can certainly be done in one module, with features for client, server and relay, but it is also ok to have 3 modules for the different functions. And once you have these 3

Re: [netmod] Structuring a DHCP module

2021-01-21 Thread Ladislav Lhotka
Hi, in my YD review 4.5 years ago I actually recommended to use separate modules: https://mailarchive.ietf.org/arch/msg/yang-doctors/GXHkGqZeIidMzpziZmK_ICrKPs4/ I think it is a matter of how much the different part overlap. For an implementer, it seems to be easier to pick just the relevant

Re: [netmod] Structuring a DHCP module

2021-01-21 Thread tom petch
Inline From: Andy Bierman Sent: 20 January 2021 18:32 On Wed, Jan 20, 2021 at 8:41 AM tom petch mailto:ie...@btconnect.com>> wrote: Juergen, Lada, Martin, Andy I wonder if one of you, or perhaps another on this list, would be willing to give advice on the structuring of the YANG module

Re: [netmod] Structuring a DHCP module

2021-01-21 Thread ianfarrer
Hi, Thanks for all your input on the question. Based on Martin’s proposal, combining the element modules with their associated options modules, and moving duplicate option definitions into the common module (resulting in 4 modules), here’s some very rough calculations on the resulting amount

Re: [netmod] Structuring a DHCP module

2021-01-21 Thread tom petch
From: Ladislav Lhotka Sent: 21 January 2021 12:58 Hi, in my YD review 4.5 years ago I actually recommended to use separate modules: https://mailarchive.ietf.org/arch/msg/yang-doctors/GXHkGqZeIidMzpziZmK_ICrKPs4/ I think it is a matter of how much the different part overlap. For an

Re: [netmod] Structuring a DHCP module

2021-01-21 Thread Martin Björklund
tom petch wrote: > From: Ladislav Lhotka > Sent: 21 January 2021 12:58 > > Hi, > > in my YD review 4.5 years ago I actually recommended to use separate > modules: > > https://mailarchive.ietf.org/arch/msg/yang-doctors/GXHkGqZeIidMzpziZmK_ICrKPs4/ > > I think it is a matter of how much the

Re: [netmod] Structuring a DHCP module

2021-01-21 Thread ianfarrer
I’m planning to restructure so that the common module is imported by client, server and relay, which means that the identity/role is no longer needed for this. (I need to look at whether the identities are needed for other reasons, such as how the modules will be extended with additional option

Re: [netmod] Structuring a DHCP module

2021-01-21 Thread tom petch
From: Martin Björklund Sent: 21 January 2021 17:07 tom petch wrote: > From: Ladislav Lhotka > Sent: 21 January 2021 12:58 > > Hi, > > in my YD review 4.5 years ago I actually recommended to use separate > modules: > >