[netsniff-ng] Re: flowtop: ping for fixes ...

2015-07-13 Thread Daniel Borkmann
On 07/13/2015 10:24 AM, Vadim Kochan wrote: Hi, After 1 week I decided to ping for some flowtop related fixes: http://article.gmane.org/gmane.linux.network.netsniff-ng/973 http://article.gmane.org/gmane.linux.network.netsniff-ng/974 Sorry for the long delay. I've applied both

Re: [netsniff-ng] [PATCH] flowtop: Fix flows disappearing

2015-07-13 Thread Daniel Borkmann
On 07/04/2015 09:18 PM, Vadim Kochan wrote: From: Vadim Kochan vadi...@gmail.com While removing flow which is pointed by 'head' then head is set to NULL and all the list disappears, so fixed by set removing flow next entry to list 'head'. Signed-off-by: Vadim Kochan vadi...@gmail.com

Re: [netsniff-ng] [PATCH 0/5] flowtop: Add traffic accounting dump

2015-07-13 Thread Vadim Kochan
On Mon, Jul 13, 2015 at 11:28:49AM +0200, Daniel Borkmann wrote: On 07/08/2015 12:20 PM, Vadim Kochan wrote: From: Vadim Kochan vadi...@gmail.com Added periodic (0.5s) dump of existing and visible flow to update packets bytes counters. Needs to clone nf_conntrack object for new added flow

Re: [netsniff-ng] [PATCH 0/5] flowtop: Add traffic accounting dump

2015-07-13 Thread Vadim Kochan
On Mon, Jul 13, 2015 at 12:31:39PM +0300, Vadim Kochan wrote: On Mon, Jul 13, 2015 at 11:28:49AM +0200, Daniel Borkmann wrote: On 07/08/2015 12:20 PM, Vadim Kochan wrote: From: Vadim Kochan vadi...@gmail.com Added periodic (0.5s) dump of existing and visible flow to update packets

Re: [netsniff-ng] [PATCH 0/5] flowtop: Add traffic accounting dump

2015-07-13 Thread Daniel Borkmann
On 07/13/2015 12:09 PM, Vadim Kochan wrote: On Mon, Jul 13, 2015 at 12:31:39PM +0300, Vadim Kochan wrote: ... If I understood correctly, you asked to do not use separated sysctl module unless it will not be used in other places ? But these funcs can be used statically in flowtop.c so they then

[netsniff-ng] wrong number of packets filtered in

2015-07-13 Thread Unnikannan Nair, Jishnu
Hi I'm using netsniff-ng for sniffing UDP packets on a network. For testign the performance I tried to send packets using iperf with bandwidth 100M and length 250. When the capture was completed iperf says it send 28000 packets sent but netsniff-ng shows a lesser value and it also shows 0%

[netsniff-ng] [PATCH v2 0/4] flowtop: Add traffic accounting dump

2015-07-13 Thread Vadim Kochan
From: Vadim Kochan vadi...@gmail.com Added periodic dump of existing and visible flow to update packets bytes counters. Needs to clone nf_conntrack object for new added flow entry to update counters for this particular flow, instead of dump entire conntrack table. Counters are showed in human

[netsniff-ng] [PATCH v2 2/4] flowtop: Add connection traffic accounting

2015-07-13 Thread Vadim Kochan
Mark each flow if it is visible on the screen to know if it is needed update traffic acct info. Changed to use non blocking recv of nf conntrack events to update traffic accounting. Now nf_conntrack is cloned when new flow entry is added to send dump request which is used to update traffic

[netsniff-ng] [PATCH v2 1/4] flowtop: Refactor walking for each flow node by presenter

2015-07-13 Thread Vadim Kochan
Change code to walk each flow by presenter to look more understandable. Signed-off-by: Vadim Kochan vadi...@gmail.com --- flowtop.c | 138 +- 1 file changed, 56 insertions(+), 82 deletions(-) diff --git a/flowtop.c b/flowtop.c index

[netsniff-ng] [PATCH v2 3/4] flowtop: Show total numbers of flows

2015-07-13 Thread Vadim Kochan
Count flows which might be showed and show this number on the top status line. Signed-off-by: Vadim Kochan vadi...@gmail.com --- flowtop.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/flowtop.c b/flowtop.c index 55de258..64fd824 100644

Re: [netsniff-ng] [PATCH 0/5] flowtop: Add traffic accounting dump

2015-07-13 Thread Vadim Kochan
On Mon, Jul 13, 2015 at 12:41:10PM +0200, Daniel Borkmann wrote: On 07/13/2015 12:09 PM, Vadim Kochan wrote: On Mon, Jul 13, 2015 at 12:31:39PM +0300, Vadim Kochan wrote: ... If I understood correctly, you asked to do not use separated sysctl module unless it will not be used in other places

[netsniff-ng] flowtop: ping for fixes ...

2015-07-13 Thread Vadim Kochan
Hi, After 1 week I decided to ping for some flowtop related fixes: http://article.gmane.org/gmane.linux.network.netsniff-ng/973 http://article.gmane.org/gmane.linux.network.netsniff-ng/974 and series about traffic counters: